indent -kr -i8 -brf -bbb -fnc -l132 -nce on all of webcit-classic
[citadel.git] / webcit / auth.c
index 994c00c976322826aed4032210effee66d5b41b0..790d5429bc3700081cb7dec604bfffab4107f964 100644 (file)
@@ -1,57 +1,52 @@
+
 /*
  * These functions handle authentication of users to a Citadel server.
  *
- * Copyright (c) 1996-2011 by the citadel.org team
+ * Copyright (c) 1996-2021 by the citadel.org team
  *
- * This program is open source software.  You can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 3 of the
- * License, or (at your option) any later version.
+ * This program is open source software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License, version 3.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #include "webcit.h"
 #include "webserver.h"
 #include <ctype.h>
 
-extern uint32_t hashlittle( const void *key, size_t length, uint32_t initval);
+extern uint32_t hashlittle(const void *key, size_t length, uint32_t initval);
 
 /*
  * Access level definitions.  This is initialized from a function rather than a
  * static array so that the strings may be localized.
  */
-char *axdefs[7]; 
+char *axdefs[7];
 
 void initialize_axdefs(void) {
 
        /* an erased user */
-       axdefs[0] = _("Deleted");       
+       axdefs[0] = _("Deleted");
 
        /* a new user */
-       axdefs[1] = _("New User");      
+       axdefs[1] = _("New User");
 
        /* a trouble maker */
-       axdefs[2] = _("Problem User");  
+       axdefs[2] = _("Problem User");
 
        /* user with normal privileges */
-       axdefs[3] = _("Local User");    
+       axdefs[3] = _("Local User");
 
        /* a user that may access network resources */
-       axdefs[4] = _("Network User");  
+       axdefs[4] = _("Network User");
 
        /* a moderator */
        axdefs[5] = _("Preferred User");
 
        /* chief */
-       axdefs[6] = _("Aide");          
+       axdefs[6] = _("Admin");
 }
 
 
@@ -60,8 +55,7 @@ void initialize_axdefs(void) {
  * Display the login screen
  * mesg = the error message if last attempt failed.
  */
-void display_login(void)
-{
+void display_login(void) {
        begin_burst();
        output_headers(1, 0, 0, 0, 1, 0);
        do_template("login");
@@ -84,8 +78,7 @@ void display_login(void)
  * pass                        his password
  * serv_response       The parameters returned from a Citadel USER or NEWU command
  */
-void become_logged_in(const StrBuf *user, const StrBuf *pass, StrBuf *serv_response)
-{
+void become_logged_in(const StrBuf * user, const StrBuf * pass, StrBuf * serv_response) {
        wcsession *WCC = WC;
        StrBuf *Buf;
        StrBuf *FloorDiv;
@@ -95,8 +88,8 @@ void become_logged_in(const StrBuf *user, const StrBuf *pass, StrBuf *serv_respo
        if (WCC->wc_fullname == NULL)
                WCC->wc_fullname = NewStrBufPlain(NULL, StrLength(serv_response));
        StrBufExtract_token(WCC->wc_fullname, serv_response, 0, '|');
-       StrBufCutLeft(WCC->wc_fullname, 4 );
-       
+       StrBufCutLeft(WCC->wc_fullname, 4);
+
        if (WCC->wc_username == NULL)
                WCC->wc_username = NewStrBufDup(user);
        else {
@@ -125,11 +118,11 @@ void become_logged_in(const StrBuf *user, const StrBuf *pass, StrBuf *serv_respo
                const char *pch;
 
                pch = ChrPtr(Buf) + 4;
-               /*WCC->new_mail  =*/ StrBufExtractNext_long(Buf, &pch, '|');
+               /*WCC->new_mail  = */ StrBufExtractNext_long(Buf, &pch, '|');
                WCC->need_regi = StrBufExtractNext_long(Buf, &pch, '|');
                WCC->need_vali = StrBufExtractNext_long(Buf, &pch, '|');
                if (WCC->cs_inet_email == NULL)
-                       WCC->cs_inet_email  = NewStrBuf();
+                       WCC->cs_inet_email = NewStrBuf();
                StrBufExtract_NextToken(WCC->cs_inet_email, Buf, &pch, '|');
        }
        get_preference("floordiv_expanded", &FloorDiv);
@@ -188,8 +181,7 @@ void ajax_login_newuser(void) {
 /* 
  * Try to create an account manually after an OpenID was verified
  */
-void openid_manual_create(void)
-{
+void openid_manual_create(void) {
        StrBuf *Buf;
 
        /* Did the user change his mind?  Pack up and go home. */
@@ -227,7 +219,8 @@ void openid_manual_create(void)
                        do_template("authpopup_finished");
                        end_burst();
                }
-       } else {
+       }
+       else {
                /* Still no good!  Go back to teh dialog to select a username */
                const StrBuf *Buf;
                putbstr("__claimed_id", NewStrBufDup(sbstr("openid_url")));
@@ -249,16 +242,12 @@ void openid_manual_create(void)
  * Perform authentication using OpenID
  * assemble the checkid_setup request and then redirect to the user's identity provider
  */
-void do_openid_login(void)
-{
+void do_openid_login(void) {
        char buf[4096];
 
        snprintf(buf, sizeof buf,
-               "OIDS %s|%s/finalize_openid_login|%s",
-               bstr("openid_url"),
-               ChrPtr(site_prefix),
-               ChrPtr(site_prefix)
-       );
+                "OIDS %s|%s/finalize_openid_login|%s", bstr("openid_url"), ChrPtr(site_prefix), ChrPtr(site_prefix)
+           );
 
        serv_puts(buf);
        serv_getln(buf, sizeof buf);
@@ -281,8 +270,7 @@ void do_openid_login(void)
  * Complete the authentication using OpenID
  * This function handles the positive or negative assertion from the user's Identity Provider
  */
-void finalize_openid_login(void)
-{
+void finalize_openid_login(void) {
        StrBuf *Buf;
        wcsession *WCC = WC;
        int linecount = 0;
@@ -304,10 +292,10 @@ void finalize_openid_login(void)
                                const char *HKey;
                                HashPos *Cursor;
                                int len;
-                               
-                               Cursor = GetNewHashPos (WCC->Hdr->urlstrings, 0);
+
+                               Cursor = GetNewHashPos(WCC->Hdr->urlstrings, 0);
                                while (GetNextHashPos(WCC->Hdr->urlstrings, Cursor, &HKLen, &HKey, &U)) {
-                                       u = (urlcontent*) U;
+                                       u = (urlcontent *) U;
                                        if (!strncasecmp(u->url_key, "openid.", 7)) {
                                                serv_printf("%s|%s", &u->url_key[7], ChrPtr(u->url_data));
                                        }
@@ -316,11 +304,9 @@ void finalize_openid_login(void)
                                serv_puts("000");
 
                                linecount = 0;
-                               while (len = StrBuf_ServGetln(Buf), 
-                                      ((len >= 0) &&
-                                       ((len != 3) || strcmp(ChrPtr(Buf), "000") )))
-                               {
-                                       if (linecount == 0) result = NewStrBufDup(Buf);
+                               while (len = StrBuf_ServGetln(Buf), ((len >= 0) && ((len != 3) || strcmp(ChrPtr(Buf), "000")))) {
+                                       if (linecount == 0)
+                                               result = NewStrBufDup(Buf);
                                        if (!strcasecmp(ChrPtr(result), "authenticate")) {
                                                if (linecount == 1) {
                                                        username = NewStrBufDup(Buf);
@@ -350,7 +336,7 @@ void finalize_openid_login(void)
        /*
         * Is this an attempt to associate a new OpenID with an account that is already logged in?
         */
-       if ( (WCC->logged_in) && (havebstr("attach_existing")) ) {
+       if ((WCC->logged_in) && (havebstr("attach_existing"))) {
                display_openids();
        }
 
@@ -366,7 +352,8 @@ void finalize_openid_login(void)
                        output_headers(1, 0, 0, 0, 1, 0);
                        do_template("authpopup_finished");
                        end_burst();
-               } else {
+               }
+               else {
                        begin_burst();
                        output_headers(1, 0, 0, 0, 1, 0);
                        wc_printf("<html><body>");
@@ -396,7 +383,7 @@ void finalize_openid_login(void)
 
        /* Something went VERY wrong if we get to this point */
        else {
-               syslog(1, "finalize_openid_login() failed to do anything.  This is a code problem.\n");
+               syslog(LOG_DEBUG, "finalize_openid_login() failed to do anything.  This is a code problem.\n");
                begin_burst();
                output_headers(1, 0, 0, 0, 1, 0);
                wc_printf("<html><body>");
@@ -415,56 +402,14 @@ void finalize_openid_login(void)
 
 /*
  * Display a welcome screen to the user.
- *
- * If this is the first time login, and the web based setup is enabled, 
- * lead the user through the setup routines
  */
-void do_welcome(void)
-{
+void do_welcome(void) {
        StrBuf *Buf;
-#ifdef XXX_NOT_FINISHED_YET_XXX
-       FILE *fp;
-       int i;
-
-       /**
-        * See if we have to run the first-time setup wizard
-        */
-       if (WC->is_aide) {
-               if (!setup_wizard) {
-                       int len;
-                       sprintf(wizard_filename, "setupwiz.%s.%s",
-                               ctdlhost, ctdlport);
-                       len = strlen(wizard_filename);
-                       for (i=0; i<len; ++i) {
-                               if (    (wizard_filename[i]==' ')
-                                       || (wizard_filename[i] == '/')
-                               ) {
-                                       wizard_filename[i] = '_';
-                               }
-                       }
-       
-                       fp = fopen(wizard_filename, "r");
-                       if (fp != NULL) {
-                               fgets(buf, sizeof buf, fp);
-                               buf[strlen(buf)-1] = 0;
-                               fclose(fp);
-                               if (atoi(buf) == serv_info.serv_rev_level) {
-                                       setup_wizard = 1;       /* already run */
-                               }
-                       }
-               }
-
-               if (!setup_wizard) {
-                       http_redirect("setup_wizard");
-               }
-       }
-#endif
-
        /*
         * Go to the user's preferred start page
         */
        if (!get_preference("startpage", &Buf)) {
-               Buf = NewStrBuf ();
+               Buf = NewStrBuf();
                StrBufPrintf(Buf, "dotskip?room=_BASEROOM_");
                set_preference("startpage", Buf, 1);
        }
@@ -474,7 +419,7 @@ void do_welcome(void)
        if (StrLength(Buf) == 0) {
                StrBufAppendBufPlain(Buf, "dotgoto?room=_BASEROOM_", -1, 0);
        }
-       syslog(9, "Redirecting to user's start page: %s\n", ChrPtr(Buf));
+       syslog(LOG_DEBUG, "Redirecting to user's start page: %s\n", ChrPtr(Buf));
        http_redirect(ChrPtr(Buf));
 }
 
@@ -483,7 +428,6 @@ void do_welcome(void)
  * Disconnect from the Citadel server, and end this WebCit session
  */
 void end_webcit_session(void) {
-       
        serv_puts("QUIT");
        WC->killthis = 1;
        /* close() of citadel socket will be done by do_housekeeping() */
@@ -493,8 +437,7 @@ void end_webcit_session(void) {
 /* 
  * Log out the session with the Citadel server
  */
-void do_logout(void)
-{
+void do_logout(void) {
        wcsession *WCC = WC;
        char buf[SIZ];
 
@@ -511,46 +454,8 @@ void do_logout(void)
 
        /* Calling output_headers() this way causes the cookies to be un-set */
        output_headers(1, 1, 0, 1, 0, 0);
-
-       /* For sites in guest mode, redirect to the landing page after we're logged out */
-       if (WC->serv_info->serv_supports_guest) {
-               wc_printf("     <script type=\"text/javascript\">       "
-                       "       window.location='/';                    "
-                       "       </script>                               "
-               );
-       }
-
-       wc_printf("<div id=\"logout_screen\">");
-        wc_printf("<div class=\"box\">");
-        wc_printf("<div class=\"boxlabel\">");
-       wc_printf(_("Log off"));
-        wc_printf("</div><div class=\"boxcontent\">");
-       serv_puts("MESG goodbye");
-       serv_getln(buf, sizeof buf);
-
-       if (WCC->serv_sock >= 0) {
-               if (buf[0] == '1') {
-                       fmout("'CENTER'");
-               } else {
-                       wc_printf("Goodbye\n");
-               }
-       }
-       else {
-               wc_printf(_("This program was unable to connect or stay "
-                       "connected to the Citadel server.  Please report "
-                       "this problem to your system administrator.")
-               );
-               wc_printf("<a href=\"http://www.citadel.org/doku.php/"
-                       "faq:mastering_your_os:net#netstat\">%s</a>",
-                       _("Read More..."));
-       }
-
-       wc_printf("<hr /><div class=\"buttons\"> "
-               "<span class=\"button_link\"><a href=\".\">");
-       wc_printf(_("Log in again"));
-       wc_printf("</a></span>");
-       wc_printf("</div></div></div>\n");
-       if (WC->serv_info->serv_supports_guest) {
+       do_template("logout");
+       if ((WCC->serv_info != NULL) && WCC->serv_info->serv_supports_guest) {
                display_default_landing_page();
                return;
        }
@@ -563,20 +468,14 @@ void do_logout(void)
 /* 
  * Special page for monitoring scripts etc
  */
-void monitor(void)
-{
+void monitor(void) {
        output_headers(0, 0, 0, 0, 0, 0);
 
-       hprintf("Content-type: text/plain\r\n"
-               "Server: " PACKAGE_STRING "\r\n"
-               "Connection: close\r\n"
-       );
+       hprintf("Content-type: text/plain\r\n" "Server: " PACKAGE_STRING "\r\n" "Connection: close\r\n");
        begin_burst();
 
-       wc_printf("Connection to Citadel server at %s:%s : %s\r\n",
-               ctdlhost, ctdlport,
-               (WC->connected ? "SUCCESS" : "FAIL")
-       );
+       wc_printf("Connection to Citadel server in %s : %s\r\n", ctdl_dir, (WC->connected ? "SUCCESS" : "FAIL")
+           );
 
        wDumpContent(0);
 }
@@ -585,8 +484,7 @@ void monitor(void)
 /*
  * validate new users
  */
-void validate(void)
-{
+void validate(void) {
        char cmd[SIZ];
        char user[SIZ];
        char buf[SIZ];
@@ -594,9 +492,9 @@ void validate(void)
 
        output_headers(1, 1, 1, 0, 0, 0);
 
-        do_template("box_begin_1");
-        StrBufAppendBufPlain(WC->WBuf, _("Validate new users"), -1, 0);
-        do_template("box_begin_2");
+       do_template("box_begin_1");
+       StrBufAppendBufPlain(WC->WBuf, _("Validate new users"), -1, 0);
+       do_template("box_begin_2");
 
        /* If the user just submitted a validation, process it... */
        safestrncpy(buf, bstr("user"), sizeof buf);
@@ -638,8 +536,7 @@ void validate(void)
                        serv_getln(buf, sizeof buf);
                        ++a;
                        if (a == 1)
-                               wc_printf("#%s<br><H1>%s</H1>",
-                                       buf, &cmd[4]);
+                               wc_printf("#%s<br><H1>%s</H1>", buf, &cmd[4]);
                        if (a == 2) {
                                char *pch;
                                int haveChar = 0;
@@ -647,23 +544,18 @@ void validate(void)
                                int haveOther = 0;
                                int haveLong = 0;
                                pch = buf;
-                               while (!IsEmptyStr(pch))
-                               {
+                               while (!IsEmptyStr(pch)) {
                                        if (isdigit(*pch))
                                                haveNum = 1;
                                        else if (isalpha(*pch))
                                                haveChar = 1;
                                        else
                                                haveOther = 1;
-                                       pch ++;
+                                       pch++;
                                }
                                if (pch - buf > 7)
                                        haveLong = 1;
-                               switch (haveLong + 
-                                       haveChar + 
-                                       haveNum + 
-                                       haveOther)
-                               {
+                               switch (haveLong + haveChar + haveNum + haveOther) {
                                case 0:
                                        pch = _("very weak");
                                        break;
@@ -693,10 +585,10 @@ void validate(void)
                        if (a == 8)
                                wc_printf("%s<br>\n", buf);
                        if (a == 9)
-                               wc_printf(_("Current access level: %d (%s)\n"),
-                                       atoi(buf), axdefs[atoi(buf)]);
+                               wc_printf(_("Current access level: %d (%s)\n"), atoi(buf), axdefs[atoi(buf)]);
                } while (strcmp(buf, "000"));
-       } else {
+       }
+       else {
                wc_printf("<H1>%s</H1>%s<br>\n", user, &cmd[4]);
        }
 
@@ -706,8 +598,7 @@ void validate(void)
        for (a = 0; a <= 6; ++a) {
                wc_printf("<a href=\"validate?nonce=%d?user=", WC->nonce);
                urlescputs(user);
-               wc_printf("&axlevel=%d\">%s</A>&nbsp;&nbsp;&nbsp;\n",
-                       a, axdefs[a]);
+               wc_printf("&axlevel=%d\">%s</A>&nbsp;&nbsp;&nbsp;\n", a, axdefs[a]);
        }
        wc_printf("<br>\n");
 
@@ -724,8 +615,7 @@ void validate(void)
  * (Set during_login to 1 if this registration is being performed during
  * new user login and will require chaining to the proper screen.)
  */
-void display_reg(int during_login)
-{
+void display_reg(int during_login) {
        folder Room;
        StrBuf *Buf;
        message_summary *VCMsg = NULL;
@@ -735,7 +625,7 @@ void display_reg(int during_login)
        Buf = NewStrBuf();
        memset(&Room, 0, sizeof(folder));
        if (goto_config_room(Buf, &Room) != 0) {
-               syslog(9, "display_reg() exiting because goto_config_room() failed\n");
+               syslog(LOG_WARNING, "display_reg() exiting because goto_config_room() failed\n");
                if (during_login) {
                        pop_destination();
                }
@@ -743,7 +633,7 @@ void display_reg(int during_login)
                        display_main_menu();
                }
                FreeStrBuf(&Buf);
-               FlushFolder(&Room);             
+               FlushFolder(&Room);
                return;
        }
        FlushFolder(&Room);
@@ -751,7 +641,7 @@ void display_reg(int during_login)
        FreeStrBuf(&Buf);
        vcard_msgnum = locate_user_vcard_in_this_room(&VCMsg, &VCAtt);
        if (vcard_msgnum < 0L) {
-               syslog(9, "display_reg() exiting because locate_user_vcard_in_this_room() failed\n");
+               syslog(LOG_WARNING, "display_reg() exiting because locate_user_vcard_in_this_room() failed\n");
                if (during_login) {
                        pop_destination();
                }
@@ -774,74 +664,16 @@ void display_reg(int during_login)
 
 }
 
-
-/*
- * display form for changing your password
- */
-void display_changepw(void)
-{
-       WCTemplputParams SubTP;
-       char buf[SIZ];
-       StrBuf *Buf;
-       output_headers(1, 1, 1, 0, 0, 0);
-
-       Buf = NewStrBufPlain(_("Change your password"), -1);
-       memset(&SubTP, 0, sizeof(WCTemplputParams));
-       SubTP.Filter.ContextType = CTX_STRBUF;
-       SubTP.Context = Buf;
-       DoTemplate(HKEY("box_begin"), NULL, &SubTP);
-
-       FreeStrBuf(&Buf);
-
-       if (!IsEmptyStr(WC->ImportantMessage)) {
-               wc_printf("<span class=\"errormsg\">"
-                       "%s</span><br>\n", WC->ImportantMessage);
-               safestrncpy(WC->ImportantMessage, "", sizeof WC->ImportantMessage);
-       }
-
-       serv_puts("MESG changepw");
-       serv_getln(buf, sizeof buf);
-       if (buf[0] == '1') {
-               fmout("CENTER");
-       }
-
-       wc_printf("<form name=\"changepwform\" action=\"changepw\" method=\"post\">\n");
-       wc_printf("<input type=\"hidden\" name=\"nonce\" value=\"%d\">\n", WC->nonce);
-       wc_printf("<table class=\"altern\" ");
-       wc_printf("<tr class=\"even\"><td>");
-       wc_printf(_("Enter new password:"));
-       wc_printf("</td><td>");
-       wc_printf("<input type=\"password\" name=\"newpass1\" value=\"\" maxlength=\"20\"></td></tr>\n");
-       wc_printf("<tr class=\"odd\"><td>");
-       wc_printf(_("Enter it again to confirm:"));
-       wc_printf("</td><td>");
-       wc_printf("<input type=\"password\" name=\"newpass2\" value=\"\" maxlength=\"20\"></td></tr>\n");
-       wc_printf("</table>\n");
-
-       wc_printf("<div class=\"buttons\">\n");
-       wc_printf("<input type=\"submit\" name=\"change_action\" value=\"%s\">", _("Change password"));
-       wc_printf("&nbsp;");
-       wc_printf("<input type=\"submit\" name=\"cancel_action\" value=\"%s\">\n", _("Cancel"));
-       wc_printf("</div>\n");
-       wc_printf("</form>\n");
-
-       do_template("box_end");
-       wDumpContent(1);
-}
-
 /*
  * change password
  * if passwords match, propagate it to citserver.
  */
-void changepw(void)
-{
-       char buf[SIZ];
+void changepw(void) {
+       StrBuf *Line;
        char newpass1[32], newpass2[32];
 
        if (!havebstr("change_action")) {
-               safestrncpy(WC->ImportantMessage, 
-                       _("Cancelled.  Password was not changed."),
-                       sizeof WC->ImportantMessage);
+               AppendImportantMessage(_("Cancelled.  Password was not changed."), -1);
                display_main_menu();
                return;
        }
@@ -850,42 +682,38 @@ void changepw(void)
        safestrncpy(newpass2, bstr("newpass2"), sizeof newpass2);
 
        if (strcasecmp(newpass1, newpass2)) {
-               safestrncpy(WC->ImportantMessage, 
-                       _("They don't match.  Password was not changed."),
-                       sizeof WC->ImportantMessage);
-               display_changepw();
+               AppendImportantMessage(_("They don't match.  Password was not changed."), -1);
+               do_template("menu_change_pw");
                return;
        }
 
        if (IsEmptyStr(newpass1)) {
-               safestrncpy(WC->ImportantMessage, 
-                       _("Blank passwords are not allowed."),
-                       sizeof WC->ImportantMessage);
-               display_changepw();
+               AppendImportantMessage(_("Blank passwords are not allowed."), -1);
+               do_template("menu_change_pw");
                return;
        }
 
+       Line = NewStrBuf();
        serv_printf("SETP %s", newpass1);
-       serv_getln(buf, sizeof buf);
-       sprintf(WC->ImportantMessage, "%s", &buf[4]);
-       if (buf[0] == '2') {
+       StrBuf_ServGetln(Line);
+       if (GetServerStatusMsg(Line, NULL, 1, 0) == 2) {
                if (WC->wc_password == NULL)
-                       WC->wc_password = NewStrBufPlain(buf, -1);
+                       WC->wc_password = NewStrBufPlain(ChrPtr(Line) + 4, StrLength(Line) - 4);
                else {
                        FlushStrBuf(WC->wc_password);
-                       StrBufAppendBufPlain(WC->wc_password,  buf, -1, 0);
+                       StrBufAppendBufPlain(WC->wc_password, ChrPtr(Line) + 4, StrLength(Line) - 4, 0);
                }
                display_main_menu();
        }
        else {
-               display_changepw();
+               do_template("menu_change_pw");
        }
+       FreeStrBuf(&Line);
 }
 
 
-int ConditionalHaveAccessCreateRoom(StrBuf *Target, WCTemplputParams *TP)
-{
-       StrBuf *Buf;    
+int ConditionalHaveAccessCreateRoom(StrBuf * Target, WCTemplputParams * TP) {
+       StrBuf *Buf;
 
        Buf = NewStrBuf();
        serv_puts("CRE8 0");
@@ -902,15 +730,13 @@ int ConditionalHaveAccessCreateRoom(StrBuf *Target, WCTemplputParams *TP)
 }
 
 
-int ConditionalAide(StrBuf *Target, WCTemplputParams *TP)
-{
+int ConditionalAide(StrBuf * Target, WCTemplputParams * TP) {
        wcsession *WCC = WC;
-       return (WCC != NULL) ? ((WCC->logged_in == 0)||(WC->is_aide == 0)) : 0;
+       return (WCC != NULL) ? ((WCC->logged_in == 0) || (WC->is_aide == 0)) : 0;
 }
 
 
-int ConditionalIsLoggedIn(StrBuf *Target, WCTemplputParams *TP) 
-{
+int ConditionalIsLoggedIn(StrBuf * Target, WCTemplputParams * TP) {
        wcsession *WCC = WC;
        return (WCC != NULL) ? (WCC->logged_in == 0) : 0;
 
@@ -931,24 +757,22 @@ void _display_reg(void) {
 }
 
 
-void Header_HandleAuth(StrBuf *Line, ParsedHttpHdrs *hdr)
-{
-       if (hdr->HR.got_auth == NO_AUTH) /* don't override cookie auth... */
-       {
+void Header_HandleAuth(StrBuf * Line, ParsedHttpHdrs * hdr) {
+       if (hdr->HR.got_auth == NO_AUTH) {      /* don't override cookie auth... */
                if (strncasecmp(ChrPtr(Line), "Basic", 5) == 0) {
                        StrBufCutLeft(Line, 6);
                        StrBufDecodeBase64(Line);
                        hdr->HR.plainauth = Line;
                        hdr->HR.got_auth = AUTH_BASIC;
                }
-               else 
-                       syslog(1, "Authentication scheme not supported! [%s]\n", ChrPtr(Line));
+               else
+                       syslog(LOG_WARNING, "Authentication scheme not supported! [%s]\n", ChrPtr(Line));
        }
 }
 
 
-void CheckAuthBasic(ParsedHttpHdrs *hdr)
-{
+void CheckAuthBasic(ParsedHttpHdrs * hdr) {
+
 /*
   todo: enable this if we can have other sessions than authenticated ones.
        if (hdr->DontNeedAuth)
@@ -956,16 +780,10 @@ void CheckAuthBasic(ParsedHttpHdrs *hdr)
 */
        StrBufAppendBufPlain(hdr->HR.plainauth, HKEY(":"), 0);
        StrBufAppendBuf(hdr->HR.plainauth, hdr->HR.user_agent, 0);
-       hdr->HR.SessionKey = hashlittle(SKEY(hdr->HR.plainauth), 89479832);
-/*
-       syslog(1, "CheckAuthBasic: calculated sessionkey %ld\n", 
-               hdr->HR.SessionKey);
-*/
 }
 
 
-void GetAuthBasic(ParsedHttpHdrs *hdr)
-{
+void GetAuthBasic(ParsedHttpHdrs * hdr) {
        const char *Pos = NULL;
        if (hdr->c_username == NULL)
                hdr->c_username = NewStrBufPlain(HKEY(DEFAULT_HTTPAUTH_USER));
@@ -976,9 +794,9 @@ void GetAuthBasic(ParsedHttpHdrs *hdr)
 }
 
 
-void Header_HandleCookie(StrBuf *Line, ParsedHttpHdrs *hdr)
-{
+void Header_HandleCookie(StrBuf * Line, ParsedHttpHdrs * hdr) {
        const char *pch;
+
 /*
   todo: enable this if we can have other sessions than authenticated ones.
        if (hdr->DontNeedAuth)
@@ -993,20 +811,12 @@ void Header_HandleCookie(StrBuf *Line, ParsedHttpHdrs *hdr)
        StrBufCutLeft(hdr->HR.RawCookie, (pch - ChrPtr(hdr->HR.RawCookie)) + 7);
        StrBufDecodeHex(hdr->HR.RawCookie);
 
-       cookie_to_stuff(Line, &hdr->HR.desired_session,
-                       hdr->c_username,
-                       hdr->c_password,
-                       hdr->c_roomname,
-                       hdr->c_language
-       );
+       cookie_to_stuff(Line, &hdr->HR.desired_session, hdr->c_username, hdr->c_password, hdr->c_roomname, hdr->c_language);
        hdr->HR.got_auth = AUTH_COOKIE;
 }
 
 
-void 
-HttpNewModule_AUTH
-(ParsedHttpHdrs *httpreq)
-{
+void HttpNewModule_AUTH(ParsedHttpHdrs * httpreq) {
        httpreq->c_username = NewStrBufPlain(HKEY(DEFAULT_HTTPAUTH_USER));
        httpreq->c_password = NewStrBufPlain(HKEY(DEFAULT_HTTPAUTH_PASS));
        httpreq->c_roomname = NewStrBuf();
@@ -1014,10 +824,7 @@ HttpNewModule_AUTH
 }
 
 
-void 
-HttpDetachModule_AUTH
-(ParsedHttpHdrs *httpreq)
-{
+void HttpDetachModule_AUTH(ParsedHttpHdrs * httpreq) {
        FLUSHStrBuf(httpreq->c_username);
        FLUSHStrBuf(httpreq->c_password);
        FLUSHStrBuf(httpreq->c_roomname);
@@ -1025,10 +832,7 @@ HttpDetachModule_AUTH
 }
 
 
-void 
-HttpDestroyModule_AUTH
-(ParsedHttpHdrs *httpreq)
-{
+void HttpDestroyModule_AUTH(ParsedHttpHdrs * httpreq) {
        FreeStrBuf(&httpreq->c_username);
        FreeStrBuf(&httpreq->c_password);
        FreeStrBuf(&httpreq->c_roomname);
@@ -1036,43 +840,36 @@ HttpDestroyModule_AUTH
 }
 
 
-void 
-InitModule_AUTH
-(void)
-{
+void InitModule_AUTH(void) {
        initialize_axdefs();
        RegisterHeaderHandler(HKEY("COOKIE"), Header_HandleCookie);
        RegisterHeaderHandler(HKEY("AUTHORIZATION"), Header_HandleAuth);
 
        /* no url pattern at all? Show login. */
-       WebcitAddUrlHandler(HKEY(""), "", 0, do_welcome, ANONYMOUS|COOKIEUNNEEDED);
+       WebcitAddUrlHandler(HKEY(""), "", 0, do_welcome, ANONYMOUS | COOKIEUNNEEDED);
 
-       WebcitAddUrlHandler(HKEY("do_welcome"), "", 0, do_welcome, ANONYMOUS|COOKIEUNNEEDED);
+       WebcitAddUrlHandler(HKEY("do_welcome"), "", 0, do_welcome, ANONYMOUS | COOKIEUNNEEDED);
        WebcitAddUrlHandler(HKEY("openid_login"), "", 0, do_openid_login, ANONYMOUS);
        WebcitAddUrlHandler(HKEY("finalize_openid_login"), "", 0, finalize_openid_login, ANONYMOUS);
        WebcitAddUrlHandler(HKEY("openid_manual_create"), "", 0, openid_manual_create, ANONYMOUS);
        WebcitAddUrlHandler(HKEY("validate"), "", 0, validate, 0);
        WebcitAddUrlHandler(HKEY("do_welcome"), "", 0, do_welcome, 0);
        WebcitAddUrlHandler(HKEY("display_reg"), "", 0, _display_reg, 0);
-       WebcitAddUrlHandler(HKEY("display_changepw"), "", 0, display_changepw, 0);
        WebcitAddUrlHandler(HKEY("changepw"), "", 0, changepw, 0);
        WebcitAddUrlHandler(HKEY("termquit"), "", 0, do_logout, 0);
-       WebcitAddUrlHandler(HKEY("do_logout"), "", 0, do_logout, ANONYMOUS|COOKIEUNNEEDED|FORCE_SESSIONCLOSE);
-       WebcitAddUrlHandler(HKEY("monitor"), "", 0, monitor, ANONYMOUS|COOKIEUNNEEDED|FORCE_SESSIONCLOSE);
-       WebcitAddUrlHandler(HKEY("ajax_login_username_password"), "", 0, ajax_login_username_password, AJAX|ANONYMOUS);
-       WebcitAddUrlHandler(HKEY("ajax_login_newuser"), "", 0, ajax_login_newuser, AJAX|ANONYMOUS);
+       WebcitAddUrlHandler(HKEY("do_logout"), "", 0, do_logout, ANONYMOUS | COOKIEUNNEEDED | FORCE_SESSIONCLOSE);
+       WebcitAddUrlHandler(HKEY("monitor"), "", 0, monitor, ANONYMOUS | COOKIEUNNEEDED | FORCE_SESSIONCLOSE);
+       WebcitAddUrlHandler(HKEY("ajax_login_username_password"), "", 0, ajax_login_username_password, AJAX | ANONYMOUS);
+       WebcitAddUrlHandler(HKEY("ajax_login_newuser"), "", 0, ajax_login_newuser, AJAX | ANONYMOUS);
        WebcitAddUrlHandler(HKEY("switch_language"), "", 0, switch_language, ANONYMOUS);
-       RegisterConditional(HKEY("COND:AIDE"), 2, ConditionalAide, CTX_NONE);
-       RegisterConditional(HKEY("COND:LOGGEDIN"), 2, ConditionalIsLoggedIn, CTX_NONE);
-       RegisterConditional(HKEY("COND:MAY_CREATE_ROOM"), 2,  ConditionalHaveAccessCreateRoom, CTX_NONE);
+       RegisterConditional("COND:AIDE", 2, ConditionalAide, CTX_NONE);
+       RegisterConditional("COND:LOGGEDIN", 2, ConditionalIsLoggedIn, CTX_NONE);
+       RegisterConditional("COND:MAY_CREATE_ROOM", 2, ConditionalHaveAccessCreateRoom, CTX_NONE);
        return;
 }
 
 
-void 
-SessionDestroyModule_AUTH
-(wcsession *sess)
-{
+void SessionDestroyModule_AUTH(wcsession * sess) {
        FreeStrBuf(&sess->wc_username);
        FreeStrBuf(&sess->wc_fullname);
        FreeStrBuf(&sess->wc_password);