* serv_getln now is a wrapper around existing functionality. a new temporary var...
[citadel.git] / webcit / messages.c
index 652083d5ad30da864d89f2805d02d5a76d999b2c..055009199cf6cfc05193dc627fe1e6424e1ea8ae 100644 (file)
 HashList *MsgHeaderHandler = NULL;
 HashList *MsgEvaluators = NULL;
 HashList *MimeRenderHandler = NULL;
-int analyze_msg = 0;
+int dbg_analyze_msg = 0;
 
 #define SUBJ_COL_WIDTH_PCT             50      /**< Mailbox view column width */
 #define SENDER_COL_WIDTH_PCT           30      /**< Mailbox view column width */
 #define DATE_PLUS_BUTTONS_WIDTH_PCT    20      /**< Mailbox view column width */
 
-
+void jsonMessageListHdr(void);
 
 void display_enter(void);
-int longcmp_r(const void *s1, const void *s2);
-int summcmp_subj(const void *s1, const void *s2);
-int summcmp_rsubj(const void *s1, const void *s2);
-int summcmp_sender(const void *s1, const void *s2);
-int summcmp_rsender(const void *s1, const void *s2);
-int summcmp_date(const void *s1, const void *s2);
-int summcmp_rdate(const void *s1, const void *s2);
 
 /*----------------------------------------------------------------------------*/
 
@@ -42,54 +35,38 @@ typedef struct _MsgPartEvaluatorStruct {
 /*----------------------------------------------------------------------------*/
 
 
-
-/*
- * I wanna SEE that message!
- *
- * msgnum              Message number to display
- * printable_view      Nonzero to display a printable view
- * section             Optional for encapsulated message/rfc822 submessage
- */
-int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, int printable_view, const StrBuf *PartNum) {
+int load_message(message_summary *Msg, 
+                StrBuf *FoundCharset,
+                StrBuf **Error)
+{
+       wcsession *WCC = WC;
        StrBuf *Buf;
        StrBuf *HdrToken;
-       StrBuf *FoundCharset;
-       HashPos  *it;
-       void *vMime;
-       message_summary *Msg = NULL;
        headereval *Hdr;
        void *vHdr;
        char buf[SIZ];
        int Done = 0;
        int state=0;
-       long len;
-       const char *Key;
-       WCTemplputParams SubTP;
-
+       
        Buf = NewStrBuf();
-       lprintf(1, "----------%s---------MSG4 %ld|%s--------------\n", tmpl, msgnum, ChrPtr(PartNum));
-       serv_printf("MSG4 %ld|%s", msgnum, ChrPtr(PartNum));
+       lprintf(1, "-------------------MSG4 %ld|%s--------------\n", Msg->msgnum, ChrPtr(Msg->PartNum));
+       if (Msg->PartNum != NULL)
+               serv_printf("MSG4 %ld|%s", Msg->msgnum, ChrPtr(Msg->PartNum));
+       else
+               serv_printf("MSG4 %ld", Msg->msgnum);
+
        StrBuf_ServGetln(Buf);
        if (GetServerStatus(Buf, NULL) != 1) {
-               StrBufAppendPrintf(Target, "<strong>");
-               StrBufAppendPrintf(Target, _("ERROR:"));
-               StrBufAppendPrintf(Target, "</strong> %s<br />\n", &buf[4]);
+               *Error = NewStrBuf();
+               StrBufAppendPrintf(*Error, "<strong>");
+               StrBufAppendPrintf(*Error, _("ERROR:"));
+               StrBufAppendPrintf(*Error, "</strong> %s<br />\n", &buf[4]);
                FreeStrBuf(&Buf);
                return 0;
        }
 
        /** begin everythingamundo table */
-
-
        HdrToken = NewStrBuf();
-       Msg = (message_summary *)malloc(sizeof(message_summary));
-       memset(Msg, 0, sizeof(message_summary));
-       Msg->msgnum = msgnum;
-       Msg->PartNum = PartNum;
-       Msg->MsgBody =  (wc_mime_attachment*) malloc(sizeof(wc_mime_attachment));
-       memset(Msg->MsgBody, 0, sizeof(wc_mime_attachment));
-       Msg->MsgBody->msgnum = msgnum;
-       FoundCharset = NewStrBuf();
        while ((StrBuf_ServGetln(Buf)>=0) && !Done) {
                if ( (StrLength(Buf)==3) && 
                    !strcmp(ChrPtr(Buf), "000")) 
@@ -97,7 +74,8 @@ int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, in
                        Done = 1;
                        if (state < 2) {
                                lprintf(1, _("unexpected end of message"));
-                               
+                               if (Msg->MsgBody->Data == NULL)
+                                       Msg->MsgBody->Data = NewStrBuf();
                                Msg->MsgBody->ContentType = NewStrBufPlain(HKEY("text/html"));
                                StrBufAppendPrintf(Msg->MsgBody->Data, "<div><i>");
                                StrBufAppendPrintf(Msg->MsgBody->Data, _("unexpected end of message"));
@@ -116,7 +94,7 @@ int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, in
                        StrBufCutLeft(Buf, StrLength(HdrToken) + 1);
                        
 #ifdef TECH_PREVIEW
-                       if (analyze_msg) lprintf(1, ":: [%s] = [%s]\n", ChrPtr(HdrToken), ChrPtr(Buf));
+                       if (dbg_analyze_msg) lprintf(1, ":: [%s] = [%s]\n", ChrPtr(HdrToken), ChrPtr(Buf));
 #endif
                        /* look up one of the examine_* functions to parse the content */
                        if (GetHash(MsgHeaderHandler, SKEY(HdrToken), &vHdr) &&
@@ -126,8 +104,12 @@ int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, in
                                if (Hdr->Type == 1) {
                                        state++;
                                }
-                       }
-                       else lprintf(1, "don't know how to handle message header[%s]\n", ChrPtr(HdrToken));
+                       }/* TODO: 
+                       else LogError(Target, 
+                                     __FUNCTION__,  
+                                     "don't know how to handle message header[%s]\n", 
+                                     ChrPtr(HdrToken));
+                        */
                        break;
                case 1:/* Message Mime Header */
                        if (StrLength(Buf) == 0) {
@@ -143,7 +125,7 @@ int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, in
                                if (StrLength(HdrToken) > 0) {
                                        StrBufCutLeft(Buf, StrLength(HdrToken) + 1);
 #ifdef TECH_PREVIEW
-                                       if (analyze_msg) lprintf(1, ":: [%s] = [%s]\n", ChrPtr(HdrToken), ChrPtr(Buf));
+                                       if (dbg_analyze_msg) lprintf(1, ":: [%s] = [%s]\n", ChrPtr(HdrToken), ChrPtr(Buf));
 #endif
                                        /* the examine*'s know how to do with mime headers too... */
                                        if (GetHash(MsgHeaderHandler, SKEY(HdrToken), &vHdr) &&
@@ -157,7 +139,7 @@ int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, in
                case 2: /* Message Body */
                        
                        if (Msg->MsgBody->size_known > 0) {
-                               StrBuf_ServGetBLOB(Msg->MsgBody->Data, Msg->MsgBody->length);
+                               StrBuf_ServGetBLOBBuffered(Msg->MsgBody->Data, Msg->MsgBody->length);
                                state ++;
                                /*/ todo: check next line, if not 000, append following lines */
                        }
@@ -178,28 +160,6 @@ int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, in
        /* now we put the body mimepart we read above into the mimelist */
        Put(Msg->AllAttach, SKEY(Msg->MsgBody->PartNum), Msg->MsgBody, DestroyMime);
        
-       /* strip the bare contenttype, so we ommit charset etc. */
-       StrBufExtract_token(Buf, Msg->MsgBody->ContentType, 0, ';');
-       StrBufTrim(Buf);
-       /* look up the renderer, that will convert this mimeitem into the htmlized form */
-       if (GetHash(MimeRenderHandler, SKEY(Buf), &vHdr) &&
-           (vHdr != NULL)) {
-               RenderMimeFuncStruct *Render;
-               Render = (RenderMimeFuncStruct*)vHdr;
-               Render->f(Msg->MsgBody, NULL, FoundCharset);
-       }
-
-       if (StrLength(Msg->reply_references)> 0) {
-               /* Trim down excessively long lists of thread references.  We eliminate the
-                * second one in the list so that the thread root remains intact.
-                */
-               int rrtok = num_tokens(ChrPtr(Msg->reply_references), '|');
-               int rrlen = StrLength(Msg->reply_references);
-               if ( ((rrtok >= 3) && (rrlen > 900)) || (rrtok > 10) ) {
-                       StrBufRemove_token(Msg->reply_references, 1, '|');
-               }
-       }
-
        /* Generate a reply-to address */
        if (StrLength(Msg->Rfca) > 0) {
                if (Msg->reply_to == NULL)
@@ -215,8 +175,8 @@ int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, in
        else 
        {
                if ((StrLength(Msg->OtherNode)>0) && 
-                   (strcasecmp(ChrPtr(Msg->OtherNode), ChrPtr(serv_info.serv_nodename))) &&
-                   (strcasecmp(ChrPtr(Msg->OtherNode), ChrPtr(serv_info.serv_humannode)) ))
+                   (strcasecmp(ChrPtr(Msg->OtherNode), ChrPtr(WCC->serv_info->serv_nodename))) &&
+                   (strcasecmp(ChrPtr(Msg->OtherNode), ChrPtr(WCC->serv_info->serv_humannode)) ))
                {
                        if (Msg->reply_to == NULL)
                                Msg->reply_to = NewStrBuf();
@@ -232,6 +192,69 @@ int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, in
                        StrBufAppendBuf(Msg->reply_to, Msg->from, 0);
                }
        }
+       FreeStrBuf(&Buf);
+       FreeStrBuf(&HdrToken);
+       return 1;
+}
+
+
+
+/*
+ * I wanna SEE that message!
+ *
+ * msgnum              Message number to display
+ * printable_view      Nonzero to display a printable view
+ * section             Optional for encapsulated message/rfc822 submessage
+ */
+int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, const StrBuf *PartNum) 
+{
+       StrBuf *Buf;
+       StrBuf *FoundCharset;
+       HashPos  *it;
+       void *vMime;
+       message_summary *Msg = NULL;
+       void *vHdr;
+       long len;
+       const char *Key;
+       WCTemplputParams SubTP;
+       StrBuf *Error = NULL;
+
+       Buf = NewStrBuf();
+       FoundCharset = NewStrBuf();
+       Msg = (message_summary *)malloc(sizeof(message_summary));
+       memset(Msg, 0, sizeof(message_summary));
+       Msg->msgnum = msgnum;
+       Msg->PartNum = PartNum;
+       Msg->MsgBody =  (wc_mime_attachment*) malloc(sizeof(wc_mime_attachment));
+       memset(Msg->MsgBody, 0, sizeof(wc_mime_attachment));
+       Msg->MsgBody->msgnum = msgnum;
+
+       if (!load_message(Msg, FoundCharset, &Error)) {
+               StrBufAppendBuf(Target, Error, 0);
+               FreeStrBuf(&Error);
+       }
+
+       /* strip the bare contenttype, so we ommit charset etc. */
+       StrBufExtract_token(Buf, Msg->MsgBody->ContentType, 0, ';');
+       StrBufTrim(Buf);
+       /* look up the renderer, that will convert this mimeitem into the htmlized form */
+       if (GetHash(MimeRenderHandler, SKEY(Buf), &vHdr) &&
+           (vHdr != NULL)) {
+               RenderMimeFuncStruct *Render;
+               Render = (RenderMimeFuncStruct*)vHdr;
+               Render->f(Msg->MsgBody, NULL, FoundCharset);
+       }
+
+       if (StrLength(Msg->reply_references)> 0) {
+               /* Trim down excessively long lists of thread references.  We eliminate the
+                * second one in the list so that the thread root remains intact.
+                */
+               int rrtok = num_tokens(ChrPtr(Msg->reply_references), '|');
+               int rrlen = StrLength(Msg->reply_references);
+               if ( ((rrtok >= 3) && (rrlen > 900)) || (rrtok > 10) ) {
+                       StrBufRemove_token(Msg->reply_references, 1, '|');
+               }
+       }
 
        /* now check if we need to translate some mimeparts, and remove the duplicate */
        it = GetNewHashPos(Msg->AllAttach, 0);
@@ -242,19 +265,21 @@ int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, in
        }
        DeleteHashPos(&it);
        memset(&SubTP, 0, sizeof(WCTemplputParams));
-       SubTP.ContextType = CTX_MAILSUM;
+       SubTP.Filter.ContextType = CTX_MAILSUM;
        SubTP.Context = Msg;
        DoTemplate(tmpl, tmpllen, Target, &SubTP);
 
        DestroyMessageSummary(Msg);
        FreeStrBuf(&FoundCharset);
-       FreeStrBuf(&HdrToken);
        FreeStrBuf(&Buf);
        return 1;
 }
 
 
 
+
+
+
 /*
  * Unadorned HTML output of an individual message, suitable
  * for placing in a hidden iframe, for printing, or whatever
@@ -263,13 +288,14 @@ int read_message(StrBuf *Target, const char *tmpl, long tmpllen, long msgnum, in
  */
 void embed_message(void) {
        long msgnum = 0L;
+       wcsession *WCC = WC;
        const StrBuf *Tmpl = sbstr("template");
 
-       msgnum = StrTol(WC->UrlFragment2);
+       msgnum = StrTol(WCC->UrlFragment2);
        if (StrLength(Tmpl) > 0) 
-               read_message(WC->WBuf, SKEY(Tmpl), msgnum, 0, NULL);
+               read_message(WCC->WBuf, SKEY(Tmpl), msgnum, NULL);
        else 
-               read_message(WC->WBuf, HKEY("view_message"), msgnum, 0, NULL);
+               read_message(WCC->WBuf, HKEY("view_message"), msgnum, NULL);
 }
 
 
@@ -290,7 +316,7 @@ void print_message(void) {
 
        begin_burst();
 
-       read_message(WC->WBuf, HKEY("view_message_print"), msgnum, 1, NULL);
+       read_message(WC->WBuf, HKEY("view_message_print"), msgnum, NULL);
 
        wDumpContent(0);
 }
@@ -306,7 +332,7 @@ void mobile_message_view(void) {
   output_headers(1, 0, 0, 0, 0, 1);
   begin_burst();
   do_template("msgcontrols", NULL);
-  read_message(WC->WBuf, HKEY("view_message"), msgnum,1, NULL);
+  read_message(WC->WBuf, HKEY("view_message"), msgnum, NULL);
   wDumpContent(0);
 }
 
@@ -389,7 +415,7 @@ message_summary *ReadOneMessageSummary(StrBuf *RawMessage, const char *DefaultSu
  * servcmd:            the citadel command to send to the citserver
  * with_headers:       also include some of the headers with the message numbers (more expensive)
  */
-int load_msg_ptrs(char *servcmd, int with_headers)
+int load_msg_ptrs(const char *servcmd, int with_headers)
 {
        StrBuf* FoundCharset = NULL;
         wcsession *WCC = WC;
@@ -400,6 +426,7 @@ int load_msg_ptrs(char *servcmd, int with_headers)
        long len;
        int n;
        int skipit;
+       const char *Ptr;
 
        if (WCC->summ != NULL) {
                DeleteHash(&WCC->summ);
@@ -421,11 +448,12 @@ int load_msg_ptrs(char *servcmd, int with_headers)
        {
                if (nummsgs < maxload) {
                        skipit = 0;
+                       Ptr = NULL;
                        Msg = (message_summary*)malloc(sizeof(message_summary));
                        memset(Msg, 0, sizeof(message_summary));
 
-                       Msg->msgnum = StrBufExtract_long(Buf, 0, '|');
-                       Msg->date = StrBufExtract_long(Buf, 1, '|');
+                       Msg->msgnum = StrBufExtractNext_long(Buf, &Ptr, '|');
+                       Msg->date = StrBufExtractNext_long(Buf, &Ptr, '|');
                        /* 
                         * as citserver probably gives us messages in forward date sorting
                         * nummsgs should be the same order as the message date.
@@ -437,18 +465,18 @@ int load_msg_ptrs(char *servcmd, int with_headers)
                        }
                        if (!skipit) {
                                Msg->from = NewStrBufPlain(NULL, StrLength(Buf));
-                               StrBufExtract_token(Buf2, Buf, 2, '|');
+                               StrBufExtract_NextToken(Buf2, Buf, &Ptr, '|');
                                if (StrLength(Buf2) != 0) {
                                        /** Handle senders with RFC2047 encoding */
                                        StrBuf_RFC822_to_Utf8(Msg->from, Buf2, WCC->DefaultCharset, FoundCharset);
                                }
                        
                                /** Nodename */
-                               StrBufExtract_token(Buf2, Buf, 3, '|');
+                               StrBufExtract_NextToken(Buf2, Buf, &Ptr, '|');
                                if ((StrLength(Buf2) !=0 ) &&
                                    ( ((WCC->room_flags & QR_NETWORK)
-                                      || ((strcasecmp(ChrPtr(Buf2), ChrPtr(serv_info.serv_nodename))
-                                           && (strcasecmp(ChrPtr(Buf2), ChrPtr(serv_info.serv_fqdn))))))))
+                                      || ((strcasecmp(ChrPtr(Buf2), ChrPtr(WCC->serv_info->serv_nodename))
+                                           && (strcasecmp(ChrPtr(Buf2), ChrPtr(WCC->serv_info->serv_fqdn))))))))
                                {
                                        StrBufAppendBufPlain(Msg->from, HKEY(" @ "), 0);
                                        StrBufAppendBuf(Msg->from, Buf2, 0);
@@ -457,11 +485,11 @@ int load_msg_ptrs(char *servcmd, int with_headers)
                                /** Not used:
                                    StrBufExtract_token(Msg->inetaddr, Buf, 4, '|');
                                */
-
+                               StrBufSkip_NTokenS(Buf, &Ptr, '|', 1);
                                Msg->subj = NewStrBufPlain(NULL, StrLength(Buf));
-                               StrBufExtract_token(Buf2,  Buf, 5, '|');
+                               StrBufExtract_NextToken(Buf2,  Buf, &Ptr, '|');
                                if (StrLength(Buf2) == 0)
-                                       StrBufAppendBufPlain(Msg->subj, _("(no subj)"), -1,0);
+                                       StrBufAppendBufPlain(Msg->subj, _("(no subject)"), -1,0);
                                else {
                                        StrBuf_RFC822_to_Utf8(Msg->subj, Buf2, WCC->DefaultCharset, FoundCharset);
                                        if ((StrLength(Msg->subj) > 75) && 
@@ -518,7 +546,7 @@ long DrawMessageDropdown(StrBuf *Selector, long maxmsgs, long startmsg, int nMes
        WCTemplputParams SubTP;
 
        memset(&SubTP, 0, sizeof(WCTemplputParams));
-       SubTP.ContextType = CTX_LONGVECTOR;
+       SubTP.Filter.ContextType = CTX_LONGVECTOR;
        SubTP.Context = &vector;
        TmpBuf = NewStrBuf();
        At = GetNewHashPos(WCC->summ, nMessages);
@@ -575,7 +603,12 @@ long DrawMessageDropdown(StrBuf *Selector, long maxmsgs, long startmsg, int nMes
        }
        vector[6] = 0;
        FlushStrBuf(TmpBuf);
-       vector[1] = lbstr("maxmsgs") == 9999999;
+       if (maxmsgs == 9999999) {
+               vector[1] = 1;
+               ret = maxmsgs;
+       }
+       else
+               vector[1] = 0;          
        vector[2] = 0;
        dbg_print_longvector(vector);
        DoTemplate(HKEY("select_messageindex_all"), TmpBuf, &SubTP);
@@ -659,10 +692,17 @@ void readloop(long oper)
        int sortit = 0;
        int defaultsortorder = 0;
        WCTemplputParams SubTP;
+       char *ab_name;
 
        if (havebstr("is_summary") && (1 == (ibstr("is_summary"))))
                WCC->wc_view = VIEW_MAILBOX;
 
+       if (!WCC->is_ajax) {
+       output_headers(1, 1, 1, 0, 0, 0);
+       } else if (WCC->wc_view == VIEW_MAILBOX) {
+         jsonMessageListHdr();
+       }
+
        switch (WCC->wc_view) {
        case VIEW_WIKI:
                sprintf(buf, "wiki?room=%s&page=home", ChrPtr(WCC->wc_roomname));
@@ -671,7 +711,7 @@ void readloop(long oper)
        case VIEW_CALBRIEF:
        case VIEW_CALENDAR:
                load_seen = 1;
-               strcpy(cmd, "MSGS ALL|||1");
+               strcpy(cmd, "MSGS ALL");
                maxmsgs = 32767;
                parse_calendar_view_request(&calv);
                break;
@@ -738,15 +778,11 @@ void readloop(long oper)
                }
                
        }
-       if (!WCC->is_ajax) {
-       output_headers(1, 1, 1, 0, 0, 0);
-       } else if (WCC->wc_view == VIEW_MAILBOX) {
-         jsonMessageListHdr();
-       }
+
        nummsgs = load_msg_ptrs(cmd, with_headers);
        if (nummsgs == 0) {
                if (care_for_empty_list) {
-                       wprintf("<div align=\"center\"><br /><em>");
+                       wprintf("<div class=\"nomsgs\"><br><em>");
                        switch (oper) {
                        case readnew:
                                wprintf(_("No new messages."));
@@ -757,7 +793,7 @@ void readloop(long oper)
                        default:
                                wprintf(_("No messages here."));
                        }
-                       wprintf("</em><br /></div>\n");
+                       wprintf("</em><br></div>\n");
                        goto DONE;
                }
 
@@ -766,7 +802,7 @@ void readloop(long oper)
        if (sortit) {
                CompareFunc SortIt;
                memset(&SubTP, 0, sizeof(WCTemplputParams));
-               SubTP.ContextType = CTX_NONE;
+               SubTP.Filter.ContextType = CTX_NONE;
                SubTP.Context = NULL;
                SortIt =  RetrieveSort(&SubTP, NULL, 0,
                                       HKEY("date"), defaultsortorder);
@@ -805,7 +841,7 @@ void readloop(long oper)
 
                }
                memset(&SubTP, 0, sizeof(WCTemplputParams));
-               SubTP.ContextType = CTX_STRBUF;
+               SubTP.Filter.ContextType = CTX_STRBUF;
                SubTP.Context = MessageDropdown;
                DoTemplate(HKEY("msg_listselector_top"), BBViewToolBar, &SubTP);
                StrBufAppendBuf(WCC->WBuf, BBViewToolBar, 0);
@@ -846,13 +882,15 @@ void readloop(long oper)
                                display_note(Msg, Msg->is_new);
                                break;
                        case VIEW_ADDRESSBOOK:
-                               fetch_ab_name(Msg, buf);
+                               ab_name = NULL;
+                               fetch_ab_name(Msg, &ab_name);
                                ++num_ab;
                                addrbook = realloc(addrbook,
                                                   (sizeof(addrbookent) * num_ab) );
-                               safestrncpy(addrbook[num_ab-1].ab_name, buf,
+                               safestrncpy(addrbook[num_ab-1].ab_name, ab_name,
                                            sizeof(addrbook[num_ab-1].ab_name));
                                addrbook[num_ab-1].ab_msgnum = Msg->msgnum;
+                               free(ab_name);
                                break;
                        case VIEW_BBS: /* Tag the mails we want to show in bbview... */
                        default:
@@ -886,7 +924,7 @@ void readloop(long oper)
                        /** if we do a split bbview in the future, begin messages div here */
                        
                        for (a=0; a<num_displayed; ++a) {
-                               read_message(WCC->WBuf, HKEY("view_message"), displayed_msgs[a], 0, NULL);
+                               read_message(WCC->WBuf, HKEY("view_message"), displayed_msgs[a], NULL);
                        }
                        
                        /** if we do a split bbview in the future, end messages div here */
@@ -895,7 +933,7 @@ void readloop(long oper)
                        displayed_msgs = NULL;
                }
                memset(&SubTP, 0, sizeof(WCTemplputParams));
-               SubTP.ContextType = CTX_STRBUF;
+               SubTP.Filter.ContextType = CTX_STRBUF;
                SubTP.Context = MessageDropdown;
                DoTemplate(HKEY("msg_listselector_bottom"), BBViewToolBar, &SubTP);
                StrBufAppendBuf(WCC->WBuf, BBViewToolBar, 0);
@@ -919,7 +957,10 @@ DONE:
        case VIEW_NOTES:
                break;
        case VIEW_ADDRESSBOOK:
-               do_addrbook_view(addrbook, num_ab);     /** Render the address book */
+               if (is_singlecard)
+                       read_message(WC->WBuf, HKEY("view_message"), lbstr("startmsg"), NULL);
+               else
+                       do_addrbook_view(addrbook, num_ab);     /** Render the address book */
                break;
        case VIEW_MAILBOX: 
        case VIEW_BBS:
@@ -928,11 +969,10 @@ DONE:
        }
        /** Note: wDumpContent() will output one additional </div> tag. */
        if (WCC->wc_view != VIEW_MAILBOX) {
-         // We ought to move this out into template
-       wprintf("</div>\n");            /** end of 'content' div */
-       wDumpContent(1);
+               /* We ought to move this out into template */
+               wDumpContent(1);
        } else {
-         end_burst();
+               end_burst();
        }
        WCC->startmsg = 0;
        WCC->maxmsgs = 0;
@@ -961,12 +1001,12 @@ void post_mime_to_server(void) {
        char *txtmail = NULL;
 
        sprintf(top_boundary, "Citadel--Multipart--%s--%04x--%04x",
-               ChrPtr(serv_info.serv_fqdn),
+               ChrPtr(WCC->serv_info->serv_fqdn),
                getpid(),
                ++seq
        );
        sprintf(alt_boundary, "Citadel--Multipart--%s--%04x--%04x",
-               ChrPtr(serv_info.serv_fqdn),
+               ChrPtr(WCC->serv_info->serv_fqdn),
                getpid(),
                ++seq
        );
@@ -1104,11 +1144,11 @@ void post_message(void)
                 */
                pch = strrchr(ChrPtr(att->FileName), '/');
                if (pch != NULL) {
-                       StrBufCutLeft(att->FileName, pch - ChrPtr(att->FileName));
+                       StrBufCutLeft(att->FileName, pch - ChrPtr(att->FileName) + 1);
                }
                pch = strrchr(ChrPtr(att->FileName), '\\');
                if (pch != NULL) {
-                       StrBufCutLeft(att->FileName, pch - ChrPtr(att->FileName));
+                       StrBufCutLeft(att->FileName, pch - ChrPtr(att->FileName) + 1);
                }
 
                /**
@@ -1147,9 +1187,10 @@ void post_message(void)
                {
                        const StrBuf *ref = sbstr("references");
                        references = NewStrBufPlain(ChrPtr(ref), StrLength(ref));
-                       lprintf(9, "Converting: %s\n", ChrPtr(references));
+                       if (*ChrPtr(references) == '|') {       /* remove leading '|' if present */
+                               StrBufCutLeft(references, 1);
+                       }
                        StrBufReplaceChars(references, '|', '!');
-                       lprintf(9, "Converted: %s\n", ChrPtr(references));
                }
                if (havebstr("subject")) {
                        const StrBuf *Subj;
@@ -1291,7 +1332,7 @@ void display_enter(void)
         * message" command really means "add new entry."
         */
        if (WCC->wc_default_view == VIEW_ADDRESSBOOK) {
-               do_edit_vcard(-1, "", "", ChrPtr(WCC->wc_roomname));
+               do_edit_vcard(-1, "", NULL, NULL, "",  ChrPtr(WCC->wc_roomname));
                return;
        }
 
@@ -1501,7 +1542,6 @@ void postpart(StrBuf *partnum, StrBuf *filename, int force_download)
                else {
                        content_type = NewStrBufDup(part->ContentType);
                }
-               output_headers(0, 0, 0, 0, 0, 0);
                StrBufAppendBuf(WC->WBuf, part->Data, 0);
                http_transmit_thing(ChrPtr(content_type), 0);
        } else {
@@ -1524,61 +1564,72 @@ void postpart(StrBuf *partnum, StrBuf *filename, int force_download)
  * partnum             The MIME part to be output
  * force_download      Nonzero to force set the Content-Type: header to "application/octet-stream"
  */
-void mimepart(const char *msgnum, const char *partnum, int force_download)
+void mimepart(int force_download)
 {
-       char buf[256];
+       wcsession *WCC = WC;
+       StrBuf *Buf;
        off_t bytes;
-       char content_type[256];
-       
-       serv_printf("OPNA %s|%s", msgnum, partnum);
-       serv_getln(buf, sizeof buf);
-       if (buf[0] == '2') {
-               bytes = extract_long(&buf[4], 0);
-               if (force_download) {
-                       strcpy(content_type, "application/octet-stream");
-               }
-               else {
-                       extract_token(content_type, &buf[4], 3, '|', sizeof content_type);
+       StrBuf *ContentType = NewStrBufPlain(HKEY("application/octet-stream"));
+       const char *CT;
+
+       Buf = NewStrBuf();
+       serv_printf("OPNA %s|%s", ChrPtr(WCC->UrlFragment2), ChrPtr(WCC->UrlFragment3));
+       StrBuf_ServGetln(Buf);
+       if (GetServerStatus(Buf, NULL) == 2) {
+               StrBufCutLeft(Buf, 4);
+               bytes = StrBufExtract_long(Buf, 0, '|');
+               if (!force_download) {
+                       StrBufExtract_token(ContentType, Buf, 3, '|');
                }
-               output_headers(0, 0, 0, 0, 0, 0);
 
-               read_server_binary(WC->WBuf, bytes);
+               read_server_binary(WCC->WBuf, bytes, Buf);
                serv_puts("CLOS");
-               serv_getln(buf, sizeof buf);
-               http_transmit_thing(content_type, 0);
+               StrBuf_ServGetln(Buf);
+               CT = ChrPtr(ContentType);
+
+               if (!force_download) {
+                       if (!strcasecmp(ChrPtr(ContentType), "application/octet-stream")) {
+                               CT = GuessMimeByFilename(SKEY(WCC->UrlFragment4));
+                       }
+                       if (!strcasecmp(ChrPtr(ContentType), "application/octet-stream")) {
+                               CT = GuessMimeType(SKEY(WCC->WBuf));
+                       }
+               }
+               http_transmit_thing(CT, 0);
        } else {
-               hprintf("HTTP/1.1 404 %s\n", &buf[4]);
+               StrBufCutLeft(Buf, 4);
+               hprintf("HTTP/1.1 404 %s\n", ChrPtr(Buf));
                output_headers(0, 0, 0, 0, 0, 0);
                hprintf("Content-Type: text/plain\r\n");
-               wprintf(_("An error occurred while retrieving this part: %s\n"), &buf[4]);
+               wprintf(_("An error occurred while retrieving this part: %s\n"), 
+                       ChrPtr(Buf));
                end_burst();
        }
+       FreeStrBuf(&ContentType);
+       FreeStrBuf(&Buf);
 }
 
 
 /*
  * Read any MIME part of a message, from the server, into memory.
  */
-char *load_mimepart(long msgnum, char *partnum)
+StrBuf *load_mimepart(long msgnum, char *partnum)
 {
-       char buf[SIZ];
        off_t bytes;
-       char content_type[SIZ];
-       char *content;
+       StrBuf *Buf;
        
+       Buf = NewStrBuf();
        serv_printf("DLAT %ld|%s", msgnum, partnum);
-       serv_getln(buf, sizeof buf);
-       if (buf[0] == '6') {
-               bytes = extract_long(&buf[4], 0);
-               extract_token(content_type, &buf[4], 3, '|', sizeof content_type);
-
-               content = malloc(bytes + 2);
-               serv_read(content, bytes);
+       StrBuf_ServGetln(Buf);
+       if (GetServerStatus(Buf, NULL) == 6) {
+               StrBufCutLeft(Buf, 4);
+               bytes = StrBufExtract_long(Buf, 0, '|');
 
-               content[bytes] = 0;     /* null terminate for good measure */
-               return(content);
+               StrBuf_ServGetBLOBBuffered(Buf, bytes);
+               return(Buf);
        }
        else {
+               FreeStrBuf(&Buf);
                return(NULL);
        }
 }
@@ -1588,38 +1639,35 @@ char *load_mimepart(long msgnum, char *partnum)
  */
 void MimeLoadData(wc_mime_attachment *Mime)
 {
-       char buf[SIZ];
+       StrBuf *Buf;
        off_t bytes;
 /* TODO: is there a chance the contenttype is different  to the one we know?    */
        serv_printf("DLAT %ld|%s", Mime->msgnum, ChrPtr(Mime->PartNum));
-       serv_getln(buf, sizeof buf);
-       if (buf[0] == '6') {
-               bytes = extract_long(&buf[4], 0);
-
+       Buf = NewStrBuf();
+       StrBuf_ServGetln(Buf);
+       if (GetServerStatus(Buf, NULL) == 6) {
+               bytes = extract_long(&(ChrPtr(Buf)[4]), 0);
+                                    
                if (Mime->Data == NULL)
                        Mime->Data = NewStrBufPlain(NULL, bytes);
-               StrBuf_ServGetBLOB(Mime->Data, bytes);
-
+               StrBuf_ServGetBLOBBuffered(Mime->Data, bytes);
        }
        else {
                FlushStrBuf(Mime->Data);
                /* TODO XImportant message */
        }
+       FreeStrBuf(&Buf);
 }
 
 
 
 
 void view_mimepart(void) {
-       mimepart(ChrPtr(WC->UrlFragment2),
-                ChrPtr(WC->UrlFragment3),
-                0);
+       mimepart(0);
 }
 
 void download_mimepart(void) {
-       mimepart(ChrPtr(WC->UrlFragment2),
-                ChrPtr(WC->UrlFragment3),
-                1);
+       mimepart(1);
 }
 
 void view_postpart(void) {
@@ -1640,18 +1688,18 @@ void h_readfwd(void) { readloop(readfwd);}
 void h_headers(void) { readloop(headers);}
 void h_do_search(void) { readloop(do_search);}
 
-void jsonMessageListHdr(void) {
-  // TODO: make a generic function
+void jsonMessageListHdr(void) 
+{
+       /* TODO: make a generic function */
   hprintf("HTTP/1.1 200 OK\r\n");
   hprintf("Content-type: application/json; charset=utf-8\r\n");
-  hprintf("Server: %s / %s\r\n", PACKAGE_STRING, ChrPtr(serv_info.serv_software));
+  hprintf("Server: %s / %s\r\n", PACKAGE_STRING, ChrPtr(WC->serv_info->serv_software));
   hprintf("Connection: close\r\n");
   hprintf("Pragma: no-cache\r\nCache-Control: no-store\r\nExpires:-1\r\n");
   begin_burst();
 }
-// Spit out the new summary view. This is basically a static page, so clients can cache the layout, all the dirty work is javascript :)
+/* Spit out the new summary view. This is basically a static page, so clients can cache the layout, all the dirty work is javascript :) */
 void new_summary_view(void) {
-  output_headers(1,1,1,0,0,1);
   begin_burst();
   DoTemplate(HKEY("msg_listview"),NULL,&NoCtx);
   DoTemplate(HKEY("trailing"),NULL,&NoCtx);
@@ -1659,9 +1707,11 @@ void new_summary_view(void) {
 }
 /** Output message list in JSON-format */
 void jsonMessageList(void) {
-  StrBuf *room = sbstr("room");
+  const StrBuf *room = sbstr("room");
+  long oper = (havebstr("query")) ? do_search : readnew;
   WC->is_ajax = 1; 
-  smart_goto(room);
+  gotoroom(room);
+  readloop(oper);
   WC->is_ajax = 0;
 }
 
@@ -1669,25 +1719,25 @@ void
 InitModule_MSG
 (void)
 {
-       RegisterPreference(HKEY("use_sig"), 
+       RegisterPreference("use_sig",
                           _("Attach signature to email messages?"), 
                           PRF_YESNO, 
                           NULL);
-       RegisterPreference(HKEY("signature"), _("Use this signature:"), PRF_QP_STRING, NULL);
-       RegisterPreference(HKEY("default_header_charset")
+       RegisterPreference("signature", _("Use this signature:"), PRF_QP_STRING, NULL);
+       RegisterPreference("default_header_charset"
                           _("Default character set for email headers:"), 
                           PRF_STRING, 
                           NULL);
-       RegisterPreference(HKEY("defaultfrom"), _("Preferred email address"), PRF_STRING, NULL);
-       RegisterPreference(HKEY("defaultname")
+       RegisterPreference("defaultfrom", _("Preferred email address"), PRF_STRING, NULL);
+       RegisterPreference("defaultname"
                           _("Preferred display name for email messages"), 
                           PRF_STRING, 
                           NULL);
-       RegisterPreference(HKEY("defaulthandle")
+       RegisterPreference("defaulthandle"
                           _("Preferred display name for bulletin board posts"), 
                           PRF_STRING, 
                           NULL);
-       RegisterPreference(HKEY("mailbox"),_("Mailbox view mode"), PRF_STRING, NULL);
+       RegisterPreference("mailbox",_("Mailbox view mode"), PRF_STRING, NULL);
 
        WebcitAddUrlHandler(HKEY("readnew"), h_readnew, NEED_URL);
        WebcitAddUrlHandler(HKEY("readold"), h_readold, NEED_URL);
@@ -1709,13 +1759,7 @@ InitModule_MSG
        WebcitAddUrlHandler(HKEY("postpart"), view_postpart, NEED_URL);
        WebcitAddUrlHandler(HKEY("postpart_download"), download_postpart, NEED_URL);
 
-       // json
+       /* json */
        WebcitAddUrlHandler(HKEY("roommsgs"), jsonMessageList,0);
-
-       WebcitAddUrlHandler(HKEY("mimepart"), view_mimepart, NEED_URL);
-       WebcitAddUrlHandler(HKEY("mimepart_download"), download_mimepart, NEED_URL);
-       WebcitAddUrlHandler(HKEY("postpart"), view_postpart, NEED_URL);
-       WebcitAddUrlHandler(HKEY("postpart_download"), download_postpart, NEED_URL);
-
        return ;
 }