use the same way to display all banners and services contents
[citadel.git] / webcit / messages.c
index 0314e44878f3aca9d0a8b244b19a463cf076fb59..eed0838855985a4c724a0371027e2114c12f6433 100644 (file)
@@ -74,7 +74,7 @@ void utf8ify_rfc822_string(char *buf) {
        char *isav;                     /**< Saved pointer to input buffer */
        char *osav;                     /**< Saved pointer to output buffer */
        int passes = 0;
-       int i;
+       int i, len;
        int illegal_non_rfc2047_encoding = 0;
 
        /** Sometimes, badly formed messages contain strings which were simply
@@ -83,9 +83,11 @@ void utf8ify_rfc822_string(char *buf) {
         *  handle it anyway by converting from a user-specified default
         *  charset to UTF-8 if we see any nonprintable characters.
         */
-       for (i=0; i<strlen(buf); ++i) {
+       len = strlen(buf);
+       for (i=0; i<len; ++i) {
                if ((buf[i] < 32) || (buf[i] > 126)) {
                        illegal_non_rfc2047_encoding = 1;
+                       i = len; ///< take a shortcut, it won't be more than one.
                }
        }
        if (illegal_non_rfc2047_encoding) {
@@ -211,14 +213,15 @@ void utf8ify_rfc822_string(char *buf) {
 void rfc2047encode(char *target, int maxlen, char *source)
 {
        int need_to_encode = 0;
-       int i;
+       int i, len;
        unsigned char ch;
 
        if (target == NULL) return;
-
-       for (i=0; i<strlen(source); ++i) {
+       len = strlen(source);
+       for (i=0; i<len; ++i) {
                if ((source[i] < 32) || (source[i] > 126)) {
                        need_to_encode = 1;
+                       i = len; ///< shortcut. won't become more than 1
                }
        }
 
@@ -228,7 +231,7 @@ void rfc2047encode(char *target, int maxlen, char *source)
        }
 
        strcpy(target, "=?UTF-8?Q?");
-       for (i=0; i<strlen(source); ++i) {
+       for (i=0; i<len; ++i) {
                ch = (unsigned char) source[i];
                if ((ch < 32) || (ch > 126) || (ch == 61)) {
                        sprintf(&target[strlen(target)], "=%02X", ch);
@@ -251,51 +254,52 @@ void rfc2047encode(char *target, int maxlen, char *source)
  */
 void url(char *buf)
 {
-
-       int pos;
-       int start, end;
+       int len;
+       char *start, *end, *pos;
        char urlbuf[SIZ];
        char outbuf[1024];
-       start = (-1);
-       end = strlen(buf);
 
-       for (pos = 0; pos < strlen(buf); ++pos) {
-               if (!strncasecmp(&buf[pos], "http://", 7))
+       start = NULL;
+       len = strlen(buf);
+       end = buf + len;
+       for (pos = buf; (pos < end) && (start == NULL); ++pos) {
+               if (!strncasecmp(pos, "http://", 7))
                        start = pos;
-               if (!strncasecmp(&buf[pos], "ftp://", 6))
+               if (!strncasecmp(pos, "ftp://", 6))
                        start = pos;
        }
 
-       if (start < 0)
+       if (start == NULL)
                return;
 
-       for (pos = strlen(buf); pos > start; --pos) {
-               if (  (!isprint(buf[pos]))
-                  || (isspace(buf[pos]))
-                  || (buf[pos] == '{')
-                  || (buf[pos] == '}')
-                  || (buf[pos] == '|')
-                  || (buf[pos] == '\\')
-                  || (buf[pos] == '^')
-                  || (buf[pos] == '[')
-                  || (buf[pos] == ']')
-                  || (buf[pos] == '`')
-                  || (buf[pos] == '<')
-                  || (buf[pos] == '>')
-                  || (buf[pos] == '(')
-                  || (buf[pos] == ')')
+       for (pos = buf+len; pos > start; --pos) {
+               if (  (!isprint(*pos))
+                  || (isspace(*pos))
+                  || (*pos == '{')
+                  || (*pos == '}')
+                  || (*pos == '|')
+                  || (*pos == '\\')
+                  || (*pos == '^')
+                  || (*pos == '[')
+                  || (*pos == ']')
+                  || (*pos == '`')
+                  || (*pos == '<')
+                  || (*pos == '>')
+                  || (*pos == '(')
+                  || (*pos == ')')
                ) {
                        end = pos;
                }
        }
 
-       strncpy(urlbuf, &buf[start], end - start);
-       urlbuf[end - start] = 0;
+       strncpy(urlbuf, start, end - start);
+       urlbuf[end - start] = '\0';
 
-       strncpy(outbuf, buf, start);
-       sprintf(&outbuf[start], "%ca href=%c%s%c TARGET=%c%s%c%c%s%c/A%c",
+       if (start != buf)
+               strncpy(outbuf, buf, start - buf );
+       sprintf(&outbuf[start-buf], "%ca href=%c%s%c TARGET=%c%s%c%c%s%c/A%c",
                LB, QU, urlbuf, QU, QU, TARGET, QU, RB, urlbuf, LB, RB);
-       strcat(outbuf, &buf[end]);
+       strcat(outbuf, end);
        if ( strlen(outbuf) < 250 )
                strcpy(buf, outbuf);
 }
@@ -308,29 +312,32 @@ void url(char *buf)
 void vcard_n_prettyize(char *name)
 {
        char *original_name;
-       int i;
+       int i, j, len;
 
        original_name = strdup(name);
+       len = strlen(original_name);
        for (i=0; i<5; ++i) {
-               if (strlen(original_name) > 0) {
-                       if (original_name[strlen(original_name)-1] == ' ') {
-                               original_name[strlen(original_name)-1] = 0;
+               if (len > 0) {
+                       if (original_name[len-1] == ' ') {
+                               original_name[--len] = 0;
                        }
-                       if (original_name[strlen(original_name)-1] == ';') {
-                               original_name[strlen(original_name)-1] = 0;
+                       if (original_name[len-1] == ';') {
+                               original_name[--len] = 0;
                        }
                }
        }
        strcpy(name, "");
-       for (i=0; i<strlen(original_name); ++i) {
+       j=0;
+       for (i=0; i<len; ++i) {
                if (original_name[i] == ';') {
-                       strcat(name, ", ");
+                       name[j++] = ',';
+                       name[j++] = ' ';                        
                }
                else {
-                       name[strlen(name)+1] = 0;
-                       name[strlen(name)] = original_name[i];
+                       name[j++] = original_name[i];
                }
        }
+       name[j] = '\0';
        free(original_name);
 }
 
@@ -417,11 +424,12 @@ void display_parsed_vcard(struct vCard *v, int full) {
                return;
        }
 
-       wprintf("<div align=center><table bgcolor=#aaaaaa width=50%%>");
+       wprintf("<div align=center>"
+               "<table bgcolor=#aaaaaa width=50%%>");
        for (pass=1; pass<=2; ++pass) {
 
                if (v->numprops) for (i=0; i<(v->numprops); ++i) {
-
+                       int len;
                        thisname = strdup(v->prop[i].name);
                        extract_token(firsttoken, thisname, 0, ';', sizeof firsttoken);
        
@@ -436,16 +444,20 @@ void display_parsed_vcard(struct vCard *v, int full) {
                                        remove_token(thisname, j, ';');
                                }
                        }
+                       
+                       len = strlen(v->prop[i].value);
        
                        if (is_qp) {
-                               thisvalue = malloc(strlen(v->prop[i].value) + 50);
+                               // %ff can become 6 bytes in utf8 
+                               thisvalue = malloc(len * 2 + 3); 
                                j = CtdlDecodeQuotedPrintable(
                                        thisvalue, v->prop[i].value,
-                                       strlen(v->prop[i].value) );
+                                       len);
                                thisvalue[j] = 0;
                        }
                        else if (is_b64) {
-                               thisvalue = malloc(strlen(v->prop[i].value) + 50);
+                               // ff will become one byte..
+                               thisvalue = malloc(len + 50);
                                CtdlDecodeBase64(
                                        thisvalue, v->prop[i].value,
                                        strlen(v->prop[i].value) );
@@ -458,7 +470,7 @@ void display_parsed_vcard(struct vCard *v, int full) {
        
                        /** N is name, but only if there's no FN already there */
                        if (!strcasecmp(firsttoken, "n")) {
-                               if (strlen(fullname) == 0) {
+                               if (IsEmptyStr(fullname)) {
                                        strcpy(fullname, thisvalue);
                                        vcard_n_prettyize(fullname);
                                }
@@ -480,7 +492,7 @@ void display_parsed_vcard(struct vCard *v, int full) {
                        }
        
                        else if (!strcasecmp(firsttoken, "email")) {
-                               if (strlen(mailto) > 0) strcat(mailto, "<br />");
+                               if (!IsEmptyStr(mailto)) strcat(mailto, "<br />");
                                strcat(mailto,
                                        "<a href=\"display_enter"
                                        "?force_room=_MAIL_?recp=");
@@ -495,7 +507,7 @@ void display_parsed_vcard(struct vCard *v, int full) {
                                strcat(mailto, "</A>");
                        }
                        else if (!strcasecmp(firsttoken, "tel")) {
-                               if (strlen(phone) > 0) strcat(phone, "<br />");
+                               if (!IsEmptyStr(phone)) strcat(phone, "<br />");
                                strcat(phone, thisvalue);
                                for (j=0; j<num_tokens(thisname, ';'); ++j) {
                                        extract_token(buf, thisname, j, ';', sizeof buf);
@@ -521,7 +533,7 @@ void display_parsed_vcard(struct vCard *v, int full) {
                                        wprintf("</TD><TD>");
                                        for (j=0; j<num_tokens(thisvalue, ';'); ++j) {
                                                extract_token(buf, thisvalue, j, ';', sizeof buf);
-                                               if (strlen(buf) > 0) {
+                                               if (!IsEmptyStr(buf)) {
                                                        escputs(buf);
                                                        if (j<3) wprintf("<br />");
                                                        else wprintf(" ");
@@ -563,24 +575,24 @@ void display_parsed_vcard(struct vCard *v, int full) {
                        "<FONT SIZE=+1><B>");
                        escputs(fullname);
                        wprintf("</B></FONT>");
-                       if (strlen(title) > 0) {
+                       if (!IsEmptyStr(title)) {
                                wprintf("<div align=right>");
                                escputs(title);
                                wprintf("</div>");
                        }
-                       if (strlen(org) > 0) {
+                       if (!IsEmptyStr(org)) {
                                wprintf("<div align=right>");
                                escputs(org);
                                wprintf("</div>");
                        }
                        wprintf("</TD></TR>\n");
                
-                       if (strlen(phone) > 0) {
+                       if (!IsEmptyStr(phone)) {
                                wprintf("<tr><td>");
                                wprintf(_("Telephone:"));
                                wprintf("</td><td>%s</td></tr>\n", phone);
                        }
-                       if (strlen(mailto) > 0) {
+                       if (!IsEmptyStr(mailto)) {
                                wprintf("<tr><td>");
                                wprintf(_("E-mail:"));
                                wprintf("</td><td>%s</td></tr>\n", mailto);
@@ -697,24 +709,22 @@ void read_message(long msgnum, int printable_view, char *section) {
        serv_printf("MSG4 %ld|%s", msgnum, section);
        serv_getln(buf, sizeof buf);
        if (buf[0] != '1') {
-               wprintf("<STRONG>");
+               wprintf("<strong>");
                wprintf(_("ERROR:"));
-               wprintf("</STRONG> %s<br />\n", &buf[4]);
+               wprintf("</strong> %s<br />\n", &buf[4]);
                return;
        }
 
        /** begin everythingamundo table */
-       if (!printable_view) {
-               wprintf("<div class=\"fix_scrollbar_bug\">\n");
-               wprintf("<table width=100%% border=1 cellspacing=0 "
-                       "cellpadding=0><TR><TD>\n");
-       }
+        if (!printable_view) {
+                wprintf("<div class=\"fix_scrollbar_bug message\" ");
+                wprintf("onMouseOver=document.getElementById(\"msg%ld\").style.visibility=\"visible\" ", msgnum);
+                wprintf("onMouseOut=document.getElementById(\"msg%ld\").style.visibility=\"hidden\" >", msgnum);
+        }
 
        /** begin message header table */
-       wprintf("<table width=100%% border=0 cellspacing=0 "
-               "cellpadding=1 bgcolor=\"#CCCCCC\"><tr><td>\n");
+       wprintf("<div class=\"message_header\">");
 
-       wprintf("<span class=\"message_header\">");
        strcpy(m_subject, "");
        strcpy(m_cc, "");
 
@@ -723,7 +733,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                        wprintf("<i>");
                        wprintf(_("unexpected end of message"));
                        wprintf(" (1)</i><br /><br />\n");
-                       wprintf("</span>\n");
+                       wprintf("</div>\n");
                        return;
                }
                if (!strncasecmp(buf, "nhdr=yes", 8))
@@ -748,12 +758,14 @@ void read_message(long msgnum, int printable_view, char *section) {
                        safestrncpy(m_subject, &buf[5], sizeof m_subject);
                }
                if (!strncasecmp(buf, "cccc=", 5)) {
+                       int len;
                        safestrncpy(m_cc, &buf[5], sizeof m_cc);
-                       if (strlen(reply_all) > 0) {
+                       if (!IsEmptyStr(reply_all)) {
                                strcat(reply_all, ", ");
                        }
-                       safestrncpy(&reply_all[strlen(reply_all)], &buf[5],
-                               (sizeof reply_all - strlen(reply_all)) );
+                       len = strlen(reply_all);
+                       safestrncpy(&reply_all[len], &buf[5],
+                               (sizeof reply_all - len) );
                }
                if ((!strncasecmp(buf, "hnod=", 5))
                    && (strcasecmp(&buf[5], serv_info.serv_humannode))) {
@@ -761,7 +773,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                }
                if ((!strncasecmp(buf, "room=", 5))
                    && (strcasecmp(&buf[5], WC->wc_roomname))
-                   && (strlen(&buf[5])>0) ) {
+                   && (!IsEmptyStr(&buf[5])) ) {
                        wprintf(_("in "));
                        wprintf("%s&gt; ", &buf[5]);
                }
@@ -777,18 +789,20 @@ void read_message(long msgnum, int printable_view, char *section) {
                        if ( ((WC->room_flags & QR_NETWORK)
                        || ((strcasecmp(&buf[5], serv_info.serv_nodename)
                        && (strcasecmp(&buf[5], serv_info.serv_fqdn)))))
-                       && (strlen(rfca)==0)
+                       && (IsEmptyStr(rfca))
                        ) {
                                wprintf("@%s ", &buf[5]);
                        }
                }
                if (!strncasecmp(buf, "rcpt=", 5)) {
+                       int len;
                        wprintf(_("to "));
-                       if (strlen(reply_all) > 0) {
+                       if (!IsEmptyStr(reply_all)) {
                                strcat(reply_all, ", ");
                        }
-                       safestrncpy(&reply_all[strlen(reply_all)], &buf[5],
-                               (sizeof reply_all - strlen(reply_all)) );
+                       len = strlen(reply_all);
+                       safestrncpy(&reply_all[len], &buf[5],
+                               (sizeof reply_all - len) );
 #ifdef HAVE_ICONV
                        utf8ify_rfc822_string(&buf[5]);
 #endif
@@ -797,7 +811,9 @@ void read_message(long msgnum, int printable_view, char *section) {
                }
                if (!strncasecmp(buf, "time=", 5)) {
                        fmt_date(now, atol(&buf[5]), 0);
+                       wprintf("<span>");
                        wprintf("%s ", now);
+                       wprintf("</span>");
                }
 
                if (!strncasecmp(buf, "part=", 5)) {
@@ -810,12 +826,12 @@ void read_message(long msgnum, int printable_view, char *section) {
 
                        striplt(mime_name);
                        striplt(mime_filename);
-                       if ( (strlen(mime_filename) == 0) && (strlen(mime_name) > 0) ) {
+                       if ( (IsEmptyStr(mime_filename)) && (!IsEmptyStr(mime_name)) ) {
                                strcpy(mime_filename, mime_name);
                        }
 
                        if (!strcasecmp(mime_content_type, "message/rfc822")) {
-                               if (strlen(mime_submessages) > 0) {
+                               if (!IsEmptyStr(mime_submessages)) {
                                        strcat(mime_submessages, "|");
                                }
                                strcat(mime_submessages, mime_partnum);
@@ -833,7 +849,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                        else if ( ( (!strcasecmp(mime_disposition, "attachment")) 
                             || (!strcasecmp(mime_disposition, "inline"))
                             || (!strcasecmp(mime_disposition, ""))
-                            ) && (strlen(mime_content_type) > 0)
+                            ) && (!IsEmptyStr(mime_content_type))
                        ) {
                                ++num_attach_links;
                                attach_links = realloc(attach_links,
@@ -875,8 +891,8 @@ void read_message(long msgnum, int printable_view, char *section) {
        }
 
        /** Generate a reply-to address */
-       if (strlen(rfca) > 0) {
-               if (strlen(from) > 0) {
+       if (!IsEmptyStr(rfca)) {
+               if (!IsEmptyStr(from)) {
                        snprintf(reply_to, sizeof(reply_to), "%s <%s>", from, rfca);
                }
                else {
@@ -884,7 +900,7 @@ void read_message(long msgnum, int printable_view, char *section) {
                }
        }
        else {
-               if ( (strlen(node) > 0)
+       if ((!IsEmptyStr(node))
                   && (strcasecmp(node, serv_info.serv_nodename))
                   && (strcasecmp(node, serv_info.serv_humannode)) ) {
                        snprintf(reply_to, sizeof(reply_to), "%s @ %s",
@@ -899,32 +915,15 @@ void read_message(long msgnum, int printable_view, char *section) {
                wprintf("****");
        }
 
-       wprintf("</span>");
 #ifdef HAVE_ICONV
        utf8ify_rfc822_string(m_cc);
        utf8ify_rfc822_string(m_subject);
 #endif
-       if (strlen(m_cc) > 0) {
-               wprintf("<br />"
-                       "<span class=\"message_subject\">");
-               wprintf(_("CC:"));
-               wprintf(" ");
-               escputs(m_cc);
-               wprintf("</span>");
-       }
-       if (strlen(m_subject) > 0) {
-               wprintf("<br />"
-                       "<span class=\"message_subject\">");
-               wprintf(_("Subject:"));
-               wprintf(" ");
-               escputs(m_subject);
-               wprintf("</span>");
-       }
-       wprintf("</td>\n");
 
-       /** start msg buttons */
-       if (!printable_view) {
-               wprintf("<td align=right><span class=\"msgbuttons\">\n");
+        /** start msg buttons */
+
+        if (!printable_view) {
+                wprintf("<p id=\"msg%ld\" class=\"msgbuttons\" >\n",msgnum);
 
                /** Reply */
                if ( (WC->wc_view == VIEW_MAILBOX) || (WC->wc_view == VIEW_BBS) ) {
@@ -934,12 +933,12 @@ void read_message(long msgnum, int printable_view, char *section) {
                        }
                        wprintf("?recp=");
                        urlescputs(reply_to);
-                       if (strlen(m_subject) > 0) {
+                       if (!IsEmptyStr(m_subject)) {
                                wprintf("?subject=");
                                if (strncasecmp(m_subject, "Re:", 3)) wprintf("Re:%20");
                                urlescputs(m_subject);
                        }
-                       wprintf("\">[%s]</a> ", _("Reply"));
+                       wprintf("\"><span>[</span>%s<span>]</span></a> ", _("Reply"));
                }
 
                /** ReplyQuoted */
@@ -949,12 +948,12 @@ void read_message(long msgnum, int printable_view, char *section) {
                                wprintf("?replyquote=%ld", msgnum);
                                wprintf("?recp=");
                                urlescputs(reply_to);
-                               if (strlen(m_subject) > 0) {
+                               if (!IsEmptyStr(m_subject)) {
                                        wprintf("?subject=");
                                        if (strncasecmp(m_subject, "Re:", 3)) wprintf("Re:%20");
                                        urlescputs(m_subject);
                                }
-                               wprintf("\">[%s]</a> ", _("ReplyQuoted"));
+                               wprintf("\"><span>[</span>%s<span>]</span></a> ", _("ReplyQuoted"));
                        }
                }
 
@@ -966,12 +965,12 @@ void read_message(long msgnum, int printable_view, char *section) {
                        urlescputs(reply_to);
                        wprintf("?cc=");
                        urlescputs(reply_all);
-                       if (strlen(m_subject) > 0) {
+                       if (!IsEmptyStr(m_subject)) {
                                wprintf("?subject=");
                                if (strncasecmp(m_subject, "Re:", 3)) wprintf("Re:%20");
                                urlescputs(m_subject);
                        }
-                       wprintf("\">[%s]</a> ", _("ReplyAll"));
+                       wprintf("\"><span>[</span>%s<span>]</span></a> ", _("ReplyAll"));
                }
 
                /** Forward */
@@ -979,45 +978,61 @@ void read_message(long msgnum, int printable_view, char *section) {
                        wprintf("<a href=\"display_enter?fwdquote=%ld?subject=", msgnum);
                        if (strncasecmp(m_subject, "Fwd:", 4)) wprintf("Fwd:%20");
                        urlescputs(m_subject);
-                       wprintf("\">[%s]</a> ", _("Forward"));
+                       wprintf("\"><span>[</span>%s<span>]</span></a> ", _("Forward"));
                }
 
                /** If this is one of my own rooms, or if I'm an Aide or Room Aide, I can move/delete */
                if ( (WC->is_room_aide) || (WC->is_mailbox) || (WC->room_flags2 & QR2_COLLABDEL) ) {
                        /** Move */
-                       wprintf("<a href=\"confirm_move_msg?msgid=%ld\">[%s]</a> ",
+                       wprintf("<a href=\"confirm_move_msg?msgid=%ld\"><span>[</span>%s<span>]</span></a> ",
                                msgnum, _("Move"));
        
                        /** Delete */
                        wprintf("<a href=\"delete_msg?msgid=%ld\" "
                                "onClick=\"return confirm('%s');\">"
-                               "[%s]</a> ", msgnum, _("Delete this message?"), _("Delete")
+                               "<span>[</span>%s<span>]</span> "
+                               "</a> ", msgnum, _("Delete this message?"), _("Delete")
                        );
                }
 
                /** Headers */
                wprintf("<a href=\"#\" onClick=\"window.open('msgheaders/%ld', 'headers%ld', 'toolbar=no,location=no,directories=no,copyhistory=no,status=yes,scrollbars=yes,resizable=yes,width=600,height=400'); \" >"
-                       "[%s]</a>", msgnum, msgnum, _("Headers"));
+                       "<span>[</span>%s<span>]</span></a>", msgnum, msgnum, _("Headers"));
 
 
                /** Print */
                wprintf("<a href=\"#\" onClick=\"window.open('printmsg/%ld', 'print%ld', 'toolbar=no,location=no,directories=no,copyhistory=no,status=yes,scrollbars=yes,resizable=yes,width=600,height=400'); \" >"
-                       "[%s]</a>", msgnum, msgnum, _("Print"));
+                       "<span>[</span>%s<span>]</span></a>", msgnum, msgnum, _("Print"));
+
+               wprintf("</p>");
 
-               wprintf("</span></td>");
        }
 
-       wprintf("</tr></table>\n");
+       if (!IsEmptyStr(m_cc)) {
+               wprintf("<p>");
+               wprintf(_("CC:"));
+               wprintf(" ");
+               escputs(m_cc);
+               wprintf("</p>");
+       }
+       if (!IsEmptyStr(m_subject)) {
+               wprintf("<p class=\"message_subject\">");
+               wprintf(_("Subject:"));
+               wprintf(" ");
+               escputs(m_subject);
+               wprintf("</p>");
+       }
+
+       wprintf("</div>");
 
        /** Begin body */
-       wprintf("<table class=\"messages_background\" "
-               "cellpadding=1 cellspacing=0><tr><td>");
+       wprintf("<div class=\"message_content\">");
 
        /**
         * Learn the content type
         */
        strcpy(mime_content_type, "text/plain");
-       while (serv_getln(buf, sizeof buf), (strlen(buf) > 0)) {
+       while (serv_getln(buf, sizeof buf), (!IsEmptyStr(buf))) {
                if (!strcmp(buf, "000")) {
                        wprintf("<i>");
                        wprintf(_("unexpected end of message"));
@@ -1029,22 +1044,27 @@ void read_message(long msgnum, int printable_view, char *section) {
                        striplt(msg4_partnum);
                }
                if (!strncasecmp(buf, "Content-type:", 13)) {
+                       int len;
                        safestrncpy(mime_content_type, &buf[13], sizeof(mime_content_type));
                        striplt(mime_content_type);
-                       for (i=0; i<strlen(mime_content_type); ++i) {
+                       len = strlen(mime_content_type);
+                       for (i=0; i<len; ++i) {
                                if (!strncasecmp(&mime_content_type[i], "charset=", 8)) {
                                        safestrncpy(mime_charset, &mime_content_type[i+8],
                                                sizeof mime_charset);
                                }
                        }
-                       for (i=0; i<strlen(mime_content_type); ++i) {
+                       for (i=0; i<len; ++i) {
                                if (mime_content_type[i] == ';') {
                                        mime_content_type[i] = 0;
+                                       len = i - 1;
                                }
                        }
-                       for (i=0; i<strlen(mime_charset); ++i) {
+                       len = strlen(mime_charset);
+                       for (i=0; i<len; ++i) {
                                if (mime_charset[i] == ';') {
                                        mime_charset[i] = 0;
+                                       len = i - 1;
                                }
                        }
                }
@@ -1074,8 +1094,10 @@ void read_message(long msgnum, int printable_view, char *section) {
        else if ( (!strcasecmp(mime_content_type, "text/plain"))
                || (!strcasecmp(mime_content_type, "text")) ) {
                while (serv_getln(buf, sizeof buf), strcmp(buf, "000")) {
-                       if (buf[strlen(buf)-1] == '\n') buf[strlen(buf)-1] = 0;
-                       if (buf[strlen(buf)-1] == '\r') buf[strlen(buf)-1] = 0;
+                       int len;
+                       len = strlen(buf);
+                       if (buf[len-1] == '\n') buf[--len] = 0;
+                       if (buf[len-1] == '\r') buf[--len] = 0;
 
 #ifdef HAVE_ICONV
                        if (ic != (iconv_t)(-1) ) {
@@ -1091,8 +1113,9 @@ void read_message(long msgnum, int printable_view, char *section) {
                        }
 #endif
 
-                       while ((strlen(buf) > 0) && (isspace(buf[strlen(buf) - 1])))
-                               buf[strlen(buf) - 1] = 0;
+                       len = strlen(buf);
+                       while ((!IsEmptyStr(buf)) && (isspace(buf[len-1])))
+                               buf[--len] = 0;
                        if ((bq == 0) &&
                        ((!strncmp(buf, ">", 1)) || (!strncmp(buf, " >", 2)) )) {
                                wprintf("<blockquote>");
@@ -1123,7 +1146,7 @@ void read_message(long msgnum, int printable_view, char *section) {
        }
 
        /** If there are attached submessages, display them now... */
-       if ( (strlen(mime_submessages) > 0) && (!section[0]) ) {
+       if ( (!IsEmptyStr(mime_submessages)) && (!section[0]) ) {
                for (i=0; i<num_tokens(mime_submessages, '|'); ++i) {
                        extract_token(buf, mime_submessages, i, '|', sizeof buf);
                        /** use printable_view to suppress buttons */
@@ -1144,7 +1167,7 @@ void read_message(long msgnum, int printable_view, char *section) {
        }
 
        /** Handler for vCard parts */
-       if (strlen(vcard_partnum) > 0) {
+       if (!IsEmptyStr(vcard_partnum)) {
                part_source = load_mimepart(msgnum, vcard_partnum);
                if (part_source != NULL) {
 
@@ -1165,7 +1188,7 @@ void read_message(long msgnum, int printable_view, char *section) {
        }
 
        /** Handler for calendar parts */
-       if (strlen(cal_partnum) > 0) {
+       if (!IsEmptyStr(cal_partnum)) {
                part_source = load_mimepart(msgnum, cal_partnum);
                if (part_source != NULL) {
                        cal_process_attachment(part_source,
@@ -1179,12 +1202,11 @@ void read_message(long msgnum, int printable_view, char *section) {
        }
 
 ENDBODY:
-       wprintf("</td></tr></table>\n");
+       wprintf("</div>\n");
 
        /** end everythingamundo table */
        if (!printable_view) {
-               wprintf("</td></tr></table>\n");
-               wprintf("</div><br />\n");
+               wprintf("</div>\n");
        }
 
        if (num_attach_links > 0) {
@@ -1365,7 +1387,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                        }
                        if ((!strncasecmp(buf, "room=", 5))
                            && (strcasecmp(&buf[5], WC->wc_roomname))
-                           && (strlen(&buf[5])>0) ) {
+                           && (!IsEmptyStr(&buf[5])) ) {
                                wprintf(_("in "));
                                wprintf("%s&gt; ", &buf[5]);
                        }
@@ -1381,7 +1403,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                                if ( ((WC->room_flags & QR_NETWORK)
                                || ((strcasecmp(&buf[5], serv_info.serv_nodename)
                                && (strcasecmp(&buf[5], serv_info.serv_fqdn)))))
-                               && (strlen(rfca)==0)
+                               && (IsEmptyStr(rfca))
                                ) {
                                        wprintf("@%s ", &buf[5]);
                                }
@@ -1422,7 +1444,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
 #ifdef HAVE_ICONV
                utf8ify_rfc822_string(m_subject);
 #endif
-               if (strlen(m_subject) > 0) {
+               if (!IsEmptyStr(m_subject)) {
                        wprintf(_("Subject:"));
                        wprintf(" ");
                        msgescputs(m_subject);
@@ -1439,12 +1461,13 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
         * Learn the content type
         */
        strcpy(mime_content_type, "text/plain");
-       while (serv_getln(buf, sizeof buf), (strlen(buf) > 0)) {
+       while (serv_getln(buf, sizeof buf), (!IsEmptyStr(buf))) {
                if (!strcmp(buf, "000")) {
                        wprintf("%s (4)", _("unexpected end of message"));
                        goto ENDBODY;
                }
                if (!strncasecmp(buf, "Content-type: ", 14)) {
+                       int len;
                        safestrncpy(mime_content_type, &buf[14],
                                sizeof(mime_content_type));
                        for (i=0; i<strlen(mime_content_type); ++i) {
@@ -1453,14 +1476,18 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                                                sizeof mime_charset);
                                }
                        }
-                       for (i=0; i<strlen(mime_content_type); ++i) {
+                       len = strlen(mime_content_type);
+                       for (i=0; i<len; ++i) {
                                if (mime_content_type[i] == ';') {
                                        mime_content_type[i] = 0;
+                                       len = i - 1;
                                }
                        }
-                       for (i=0; i<strlen(mime_charset); ++i) {
+                       len = strlen(mime_charset);
+                       for (i=0; i<len; ++i) {
                                if (mime_charset[i] == ';') {
                                        mime_charset[i] = 0;
+                                       len = i - 1;
                                }
                        }
                }
@@ -1488,13 +1515,15 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
        /* Boring old 80-column fixed format text gets handled this way... */
        else if (!strcasecmp(mime_content_type, "text/plain")) {
                while (serv_getln(buf, sizeof buf), strcmp(buf, "000")) {
-                       if (buf[strlen(buf)-1] == '\n') buf[strlen(buf)-1] = 0;
-                       if (buf[strlen(buf)-1] == '\r') buf[strlen(buf)-1] = 0;
+                       int len;
+                       len = strlen(buf);
+                       if (buf[len-1] == '\n') buf[--len] = 0;
+                       if (buf[len-1] == '\r') buf[--len] = 0;
 
 #ifdef HAVE_ICONV
                        if (ic != (iconv_t)(-1) ) {
                                ibuf = buf;
-                               ibuflen = strlen(ibuf);
+                               ibuflen = len;
                                obuflen = SIZ;
                                obuf = (char *) malloc(obuflen);
                                osav = obuf;
@@ -1505,8 +1534,9 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                        }
 #endif
 
-                       while ((strlen(buf) > 0) && (isspace(buf[strlen(buf) - 1])))
-                               buf[strlen(buf) - 1] = 0;
+                       len = strlen(buf);
+                       while ((!IsEmptyStr(buf)) && (isspace(buf[len - 1]))) 
+                               buf[--len] = 0;
                        if ((bq == 0) &&
                        ((!strncmp(buf, ">", 1)) || (!strncmp(buf, " >", 2)) )) {
                                wprintf("<blockquote>");
@@ -1518,7 +1548,7 @@ void pullquote_message(long msgnum, int forward_attachments, int include_headers
                        }
                        wprintf("<tt>");
                        url(buf);
-                       msgescputs(buf);
+                       msgescputs1(buf);
                        wprintf("</tt><br />");
                }
                wprintf("</i><br />");
@@ -1608,7 +1638,7 @@ ENDBODY:
 void display_summarized(int num) {
        char datebuf[64];
 
-       wprintf("<tr id=\"m%ld\" style=\"width:100%%;font-weight:%s;background-color:#ffffff\" "
+       wprintf("<tr id=\"m%ld\" style=\"font-weight:%s;\" "
                "onMouseDown=\"CtdlMoveMsgMouseDown(event,%ld)\">",
                WC->summ[num].msgnum,
                (WC->summ[num].is_new ? "bold" : "normal"),
@@ -1673,7 +1703,7 @@ void display_addressbook(long msgnum, char alpha) {
                }
        }
 
-       if (strlen(vcard_partnum) > 0) {
+       if (!IsEmptyStr(vcard_partnum)) {
                vcard_source = load_mimepart(msgnum, vcard_partnum);
                if (vcard_source != NULL) {
 
@@ -1734,7 +1764,7 @@ void fetch_ab_name(long msgnum, char *namebuf) {
        int mime_length;
        char vcard_partnum[SIZ];
        char *vcard_source = NULL;
-       int i;
+       int i, len;
        struct message_summary summ;
 
        if (namebuf == NULL) return;
@@ -1764,7 +1794,7 @@ void fetch_ab_name(long msgnum, char *namebuf) {
                }
        }
 
-       if (strlen(vcard_partnum) > 0) {
+       if (!IsEmptyStr(vcard_partnum)) {
                vcard_source = load_mimepart(msgnum, vcard_partnum);
                if (vcard_source != NULL) {
 
@@ -1777,7 +1807,8 @@ void fetch_ab_name(long msgnum, char *namebuf) {
 
        lastfirst_firstlast(namebuf);
        striplt(namebuf);
-       for (i=0; i<strlen(namebuf); ++i) {
+       len = strlen(namebuf);
+       for (i=0; i<len; ++i) {
                if (namebuf[i] != ';') return;
        }
        strcpy(namebuf, _("(no name)"));
@@ -1824,11 +1855,13 @@ void do_addrbook_view(struct addrbookent *addrbook, int num_ab) {
        int bg = 0;
        static int NAMESPERPAGE = 60;
        int num_pages = 0;
-       int page = 0;
        int tabfirst = 0;
-       char tabfirst_label[SIZ];
+       char tabfirst_label[64];
        int tablast = 0;
-       char tablast_label[SIZ];
+       char tablast_label[64];
+       char this_tablabel[64];
+       int page = 0;
+       char **tablabels;
 
        if (num_ab == 0) {
                wprintf("<br /><br /><br /><div align=\"center\"><i>");
@@ -1841,66 +1874,70 @@ void do_addrbook_view(struct addrbookent *addrbook, int num_ab) {
                qsort(addrbook, num_ab, sizeof(struct addrbookent), abcmp);
        }
 
-       num_pages = num_ab / NAMESPERPAGE;
+       num_pages = (num_ab / NAMESPERPAGE) + 1;
 
-       page = atoi(bstr("page"));
+       tablabels = malloc(num_pages * sizeof (char *));
+       if (tablabels == NULL) {
+               wprintf("<br /><br /><br /><div align=\"center\"><i>");
+               wprintf(_("An internal error has occurred."));
+               wprintf("</i></div>\n");
+               return;
+       }
 
-       wprintf("Page: ");
-       for (i=0; i<=num_pages; ++i) {
-               if (i != page) {
-                       wprintf("<a href=\"readfwd?page=%d\">", i);
-               }
-               else {
-                       wprintf("<B>");
-               }
+       for (i=0; i<num_pages; ++i) {
                tabfirst = i * NAMESPERPAGE;
                tablast = tabfirst + NAMESPERPAGE - 1;
                if (tablast > (num_ab - 1)) tablast = (num_ab - 1);
                nametab(tabfirst_label, addrbook[tabfirst].ab_name);
                nametab(tablast_label, addrbook[tablast].ab_name);
-               wprintf("[%s&nbsp;-&nbsp;%s]",
-                       tabfirst_label, tablast_label
-               );
-               if (i != page) {
-                       wprintf("</A>\n");
-               }
-               else {
-                       wprintf("</B>\n");
-               }
+               sprintf(this_tablabel, "%s&nbsp;-&nbsp;%s", tabfirst_label, tablast_label);
+               tablabels[i] = strdup(this_tablabel);
        }
-       wprintf("<br />\n");
 
-       wprintf("<table border=0 cellspacing=0 "
-               "cellpadding=3 width=100%%>\n"
-       );
+       tabbed_dialog(num_pages, tablabels);
+       page = (-1);
 
        for (i=0; i<num_ab; ++i) {
 
-               if ((i / NAMESPERPAGE) == page) {
+               if ((i / NAMESPERPAGE) != page) {       /* New tab */
+                       page = (i / NAMESPERPAGE);
+                       if (page > 0) {
+                               wprintf("</tr></table>\n");
+                               end_tab(page-1, num_pages);
+                       }
+                       begin_tab(page, num_pages);
+                       wprintf("<table border=0 cellspacing=0 cellpadding=3 width=100%%>\n");
+                       displayed = 0;
+               }
 
-                       if ((displayed % 4) == 0) {
-                               if (displayed > 0) {
-                                       wprintf("</tr>\n");
-                               }
-                               bg = 1 - bg;
-                               wprintf("<tr bgcolor=\"#%s\">",
-                                       (bg ? "DDDDDD" : "FFFFFF")
-                               );
+               if ((displayed % 4) == 0) {
+                       if (displayed > 0) {
+                               wprintf("</tr>\n");
                        }
-       
-                       wprintf("<td>");
-       
-                       wprintf("<a href=\"readfwd?startmsg=%ld&is_singlecard=1",
-                               addrbook[i].ab_msgnum);
-                       wprintf("?maxmsgs=1?summary=0?alpha=%s\">", bstr("alpha"));
-                       vcard_n_prettyize(addrbook[i].ab_name);
-                       escputs(addrbook[i].ab_name);
-                       wprintf("</a></td>\n");
-                       ++displayed;
+                       bg = 1 - bg;
+                       wprintf("<tr bgcolor=\"#%s\">",
+                               (bg ? "DDDDDD" : "FFFFFF")
+                       );
                }
+       
+               wprintf("<td>");
+
+               wprintf("<a href=\"readfwd?startmsg=%ld&is_singlecard=1",
+                       addrbook[i].ab_msgnum);
+               wprintf("?maxmsgs=1?summary=0?alpha=%s\">", bstr("alpha"));
+               vcard_n_prettyize(addrbook[i].ab_name);
+               escputs(addrbook[i].ab_name);
+               wprintf("</a></td>\n");
+               ++displayed;
        }
 
        wprintf("</tr></table>\n");
+       end_tab((num_pages-1), num_pages);
+
+       for (i=0; i<num_pages; ++i) {
+               free(tablabels[i]);
+       }
+       free(tablabels);
 }
 
 
@@ -1961,11 +1998,11 @@ int load_msg_ptrs(char *servcmd, int with_headers)
                                WC->summ[nummsgs-1].msgnum = WC->msgarr[nummsgs-1];
                                safestrncpy(WC->summ[nummsgs-1].subj,
                                        _("(no subject)"), sizeof WC->summ[nummsgs-1].subj);
-                               if (strlen(fullname) > 0) {
+                               if (!IsEmptyStr(fullname)) {
                                        safestrncpy(WC->summ[nummsgs-1].from,
                                                fullname, sizeof WC->summ[nummsgs-1].from);
                                }
-                               if (strlen(subject) > 0) {
+                               if (!IsEmptyStr(subject)) {
                                safestrncpy(WC->summ[nummsgs-1].subj, subject,
                                        sizeof WC->summ[nummsgs-1].subj);
                                }
@@ -1977,7 +2014,7 @@ int load_msg_ptrs(char *servcmd, int with_headers)
                                        strcpy(&WC->summ[nummsgs-1].subj[72], "...");
                                }
 
-                               if (strlen(nodename) > 0) {
+                               if (!IsEmptyStr(nodename)) {
                                        if ( ((WC->room_flags & QR_NETWORK)
                                           || ((strcasecmp(nodename, serv_info.serv_nodename)
                                           && (strcasecmp(nodename, serv_info.serv_fqdn)))))
@@ -2170,13 +2207,13 @@ void readloop(char *oper)
        get_preference(sortpref_name, sortpref_value, sizeof sortpref_value);
 
        sortby = bstr("sortby");
-       if ( (strlen(sortby) > 0) && (strcasecmp(sortby, sortpref_value)) ) {
+       if ( (!IsEmptyStr(sortby)) && (strcasecmp(sortby, sortpref_value)) ) {
                set_preference(sortpref_name, sortby, 1);
        }
-       if (strlen(sortby) == 0) sortby = sortpref_value;
+       if (IsEmptyStr(sortby)) sortby = sortpref_value;
 
        /** mailbox sort */
-       if (strlen(sortby) == 0) sortby = "rdate";
+       if (IsEmptyStr(sortby)) sortby = "rdate";
 
        /** message board sort */
        if (!strcasecmp(sortby, "reverse")) {
@@ -2371,7 +2408,6 @@ void readloop(char *oper)
        }
 
        if (is_summary) {
-               wprintf("</div>\n");            /** end of 'content' div */
 
                wprintf("<script language=\"javascript\" type=\"text/javascript\">"
                        " document.onkeydown = CtdlMsgListKeyPress;     "
@@ -2387,14 +2423,14 @@ void readloop(char *oper)
                        "<table cellspacing=0 style=\"width:100%%\">"
                        "<tr>"
                );
-               wprintf("<td width=%d%%><b><i>%s</i></b> %s</td>"
-                       "<td width=%d%%><b><i>%s</i></b> %s</td>"
-                       "<td width=%d%%><b><i>%s</i></b> %s"
+               wprintf("<th width=%d%%>%s %s</th>"
+                       "<th width=%d%%>%s %s</th>"
+                       "<th width=%d%%>%s %s"
                        "&nbsp;"
-                       "<input type=\"submit\" name=\"delete_button\" style=\"font-size:6pt\" "
+                       "<input type=\"submit\" name=\"delete_button\" id=\"delbutton\" "
                        " onClick=\"CtdlDeleteSelectedMessages(event)\" "
                        " value=\"%s\">"
-                       "</td>"
+                       "</th>"
                        "</tr>\n"
                        ,
                        SUBJ_COL_WIDTH_PCT,
@@ -2411,11 +2447,108 @@ void readloop(char *oper)
 
                        "<div class=\"fix_scrollbar_bug\">\n"
 
-                       "<table class=\"mailbox_summary\" id=\"summary_headers\" rules=rows "
+                       "<table class=\"mailbox_summary\" id=\"summary_headers\" "
                        "cellspacing=0 style=\"width:100%%;-moz-user-select:none;\">"
                );
        }
 
+
+       /**
+        * Set the "is_bbview" variable if it appears that we are looking at
+        * a classic bulletin board view.
+        */
+       if ((!is_tasks) && (!is_calendar) && (!is_addressbook)
+             && (!is_notes) && (!is_singlecard) && (!is_summary)) {
+               is_bbview = 1;
+       }
+
+       /**
+        * If we're not currently looking at ALL requested
+        * messages, then display the selector bar
+        */
+       if (is_bbview) {
+               /** begin bbview scroller */
+               wprintf("<form name=\"msgomatic\" class=\"selector_top\" >");
+               wprintf(_("Reading #"), lowest_displayed, highest_displayed);
+
+               wprintf("<select name=\"whichones\" size=\"1\" "
+                       "OnChange=\"location.href=msgomatictop.whichones.options"
+                       "[selectedIndex].value\">\n");
+
+               if (bbs_reverse) {
+                       for (b=nummsgs-1; b>=0; b = b - maxmsgs) {
+                               hi = b + 1;
+                               lo = b - maxmsgs + 2;
+                               if (lo < 1) lo = 1;
+                               wprintf("<option %s value="
+                                       "\"%s"
+                                       "?startmsg=%ld"
+                                       "?maxmsgs=%d"
+                                       "?summary=%d\">"
+                                       "%d-%d</option> \n",
+                                       ((WC->msgarr[lo-1] == startmsg) ? "selected" : ""),
+                                       oper,
+                                       WC->msgarr[lo-1],
+                                       maxmsgs,
+                                       is_summary,
+                                       hi, lo);
+                       }
+               }
+               else {
+                       for (b=0; b<nummsgs; b = b + maxmsgs) {
+                               lo = b + 1;
+                               hi = b + maxmsgs + 1;
+                               if (hi > nummsgs) hi = nummsgs;
+                               wprintf("<option %s value="
+                                       "\"%s"
+                                       "?startmsg=%ld"
+                                       "?maxmsgs=%d"
+                                       "?summary=%d\">"
+                                       "%d-%d</option> \n",
+                                       ((WC->msgarr[b] == startmsg) ? "selected" : ""),
+                                       oper,
+                                       WC->msgarr[lo-1],
+                                       maxmsgs,
+                                       is_summary,
+                                       lo, hi);
+                       }
+               }
+
+               wprintf("<option value=\"%s?startmsg=%ld"
+                       "?maxmsgs=9999999?summary=%d\">",
+                       oper,
+                       WC->msgarr[0], is_summary);
+               wprintf(_("All"));
+               wprintf("</option>");
+               wprintf("</select> ");
+               wprintf(_("of %d messages."), nummsgs);
+
+               /** forward/reverse */
+               wprintf("&nbsp;<select name=\"direction\" size=\"1\" "
+                       "OnChange=\"location.href=msgomatictop.direction.options"
+                       "[selectedIndex].value\">\n"
+               );
+
+               wprintf("<option %s value=\"%s?sortby=forward\">",
+                       (bbs_reverse ? "" : "selected"),
+                       oper
+               );
+               wprintf(_("oldest to newest"));
+               wprintf("</option>\n");
+       
+               wprintf("<option %s value=\"%s?sortby=reverse\">",
+                       (bbs_reverse ? "selected" : ""),
+                       oper
+               );
+               wprintf(_("newest to oldest"));
+               wprintf("</option>\n");
+       
+               wprintf("</select></form>\n");
+               /** end bbview scroller */
+       }
+
+
+
        for (a = 0; a < nummsgs; ++a) {
                if ((WC->msgarr[a] >= startmsg) && (num_displayed < maxmsgs)) {
 
@@ -2456,14 +2589,6 @@ void readloop(char *oper)
                }
        }
 
-       /**
-        * Set the "is_bbview" variable if it appears that we are looking at
-        * a classic bulletin board view.
-        */
-       if ((!is_tasks) && (!is_calendar) && (!is_addressbook)
-             && (!is_notes) && (!is_singlecard) && (!is_summary)) {
-               is_bbview = 1;
-       }
 
        /** Output loop */
        if (displayed_msgs != NULL) {
@@ -2491,10 +2616,7 @@ void readloop(char *oper)
                /** Here's the grab-it-to-resize-the-message-list widget */
                wprintf("<div id=\"resize_msglist\" "
                        "onMouseDown=\"CtdlResizeMsgListMouseDown(event)\">"
-                       "<div class=\"fix_scrollbar_bug\">"
-                       "<table width=100%% border=3 cellspacing=0 "
-                       "bgcolor=\"#cccccc\" "
-                       "cellpadding=0><TR><TD> </td></tr></table>"
+                       "<div class=\"fix_scrollbar_bug\"> <hr>"
                        "</div></div>\n"
                );
 
@@ -2514,7 +2636,7 @@ void readloop(char *oper)
         */
        if (is_bbview) {
                /** begin bbview scroller */
-               wprintf("<form name=\"msgomatic\">");
+               wprintf("<form name=\"msgomatic\" class=\"selector_bottom\" >");
                wprintf(_("Reading #"), lowest_displayed, highest_displayed);
 
                wprintf("<select name=\"whichones\" size=\"1\" "
@@ -2561,12 +2683,11 @@ void readloop(char *oper)
                }
 
                wprintf("<option value=\"%s?startmsg=%ld"
-                       "?maxmsgs=9999999?summary=%d\">"
-                       "ALL"
-                       "</option> ",
+                       "?maxmsgs=9999999?summary=%d\">",
                        oper,
                        WC->msgarr[0], is_summary);
-
+               wprintf(_("All"));
+               wprintf("</option>");
                wprintf("</select> ");
                wprintf(_("of %d messages."), nummsgs);
 
@@ -2576,15 +2697,19 @@ void readloop(char *oper)
                        "[selectedIndex].value\">\n"
                );
 
-               wprintf("<option %s value=\"%s?sortby=forward\">oldest to newest</option>\n",
+               wprintf("<option %s value=\"%s?sortby=forward\">",
                        (bbs_reverse ? "" : "selected"),
                        oper
                );
+               wprintf(_("oldest to newest"));
+               wprintf("</option>\n");
        
-               wprintf("<option %s value=\"%s?sortby=reverse\">newest to oldest</option>\n",
+               wprintf("<option %s value=\"%s?sortby=reverse\">",
                        (bbs_reverse ? "selected" : ""),
                        oper
                );
+               wprintf(_("newest to oldest"));
+               wprintf("</option>\n");
        
                wprintf("</select></form>\n");
                /** end bbview scroller */
@@ -2604,8 +2729,8 @@ DONE:
        }
 
        /** Note: wDumpContent() will output one additional </div> tag. */
+       wprintf("</div>\n");            /** end of 'content' div */
        wDumpContent(1);
-       if (addrbook != NULL) free(addrbook);
 
        /** free the summary */
        if (WC->summ != NULL) {
@@ -2613,6 +2738,7 @@ DONE:
                WC->num_summ = 0;
                WC->summ = NULL;
        }
+       if (addrbook != NULL) free(addrbook);
 }
 
 
@@ -2756,10 +2882,10 @@ void post_message(void)
                return;
        }
 
-       if (strlen(bstr("cancel_button")) > 0) {
+       if (!IsEmptyStr(bstr("cancel_button"))) {
                sprintf(WC->ImportantMessage, 
                        _("Cancelled.  Message was not posted."));
-       } else if (strlen(bstr("attach_button")) > 0) {
+       } else if (!IsEmptyStr(bstr("attach_button"))) {
                display_enter();
                return;
        } else if (atol(bstr("postseq")) == dont_post) {
@@ -2782,9 +2908,9 @@ void post_message(void)
                serv_getln(buf, sizeof buf);
                if (buf[0] == '4') {
                        post_mime_to_server();
-                       if ( (strlen(bstr("recp")) > 0)
-                          || (strlen(bstr("cc")) > 0)
-                          || (strlen(bstr("bcc")) > 0)
+                       if (  (!IsEmptyStr(bstr("recp")))
+                          || (!IsEmptyStr(bstr("cc"  )))
+                          || (!IsEmptyStr(bstr("bcc" )))
                        ) {
                                sprintf(WC->ImportantMessage, _("Message has been sent.\n"));
                        }
@@ -2806,13 +2932,13 @@ void post_message(void)
         *  We may have been supplied with instructions regarding the location
         *  to which we must return after posting.  If found, go there.
         */
-       if (strlen(bstr("return_to")) > 0) {
+       if (!IsEmptyStr(bstr("return_to"))) {
                http_redirect(bstr("return_to"));
        }
        /**
         *  If we were editing a page in a wiki room, go to that page now.
         */
-       else if (strlen(bstr("wikipage")) > 0) {
+       else if (!IsEmptyStr(bstr("wikipage"))) {
                snprintf(buf, sizeof buf, "wiki?page=%s", bstr("wikipage"));
                http_redirect(buf);
        }
@@ -2838,6 +2964,7 @@ void display_enter(void)
        char *display_name;
        struct wc_attachment *att;
        int recipient_required = 0;
+       int subject_required = 0;
        int recipient_bad = 0;
        int i;
        int is_anonymous = 0;
@@ -2845,7 +2972,7 @@ void display_enter(void)
 
        now = time(NULL);
 
-       if (strlen(bstr("force_room")) > 0) {
+       if (!IsEmptyStr(bstr("force_room"))) {
                gotoroom(bstr("force_room"));
        }
 
@@ -2858,6 +2985,7 @@ void display_enter(void)
        /** First test to see whether this is a room that requires recipients to be entered */
        serv_puts("ENT0 0");
        serv_getln(buf, sizeof buf);
+
        if (!strncmp(buf, "570", 3)) {          /** 570 means that we need a recipient here */
                recipient_required = 1;
        }
@@ -2867,6 +2995,11 @@ void display_enter(void)
                return;
        }
 
+       /* Is the server strongly recommending that the user enter a message subject? */
+       if ((buf[3] != '\0') && (buf[4] != '\0')) {
+               subject_required = extract_int(&buf[4], 1);
+       }
+
        /**
         * Are we perhaps in an address book view?  If so, then an "enter
         * message" command really means "add new entry."
@@ -2905,8 +3038,7 @@ void display_enter(void)
        embed_room_banner(NULL, navbar_none);
        wprintf("</div>\n");
        wprintf("<div id=\"content\">\n"
-               "<div class=\"fix_scrollbar_bug\">"
-               "<table class=\"messages_background\"><tr><td>");
+               "<div class=\"fix_scrollbar_bug message \">");
 
        /** Now check our actual recipients if there are any */
        if (recipient_required) {
@@ -2919,7 +3051,9 @@ void display_enter(void)
                serv_getln(buf, sizeof buf);
 
                if (!strncmp(buf, "570", 3)) {  /** 570 means we have an invalid recipient listed */
-                       if (strlen(bstr("recp")) + strlen(bstr("cc")) + strlen(bstr("bcc")) > 0) {
+                       if (!IsEmptyStr(bstr("recp")) && 
+                           !IsEmptyStr(bstr("cc"  )) && 
+                           !IsEmptyStr(bstr("bcc" ))) {
                                recipient_bad = 1;
                        }
                }
@@ -2944,18 +3078,36 @@ void display_enter(void)
                wprintf("<input type=\"hidden\" name=\"wikipage\" value=\"%s\">\n", bstr("wikipage"));
        }
        wprintf("<input type=\"hidden\" name=\"return_to\" value=\"%s\">\n", bstr("return_to"));
+       wprintf("<input type=\"hidden\" name=\"nonce\" value=\"%ld\">\n", WC->nonce);
+
+       /** submit or cancel buttons */
+        wprintf("<p class=\"send_edit_msg\">");
+        wprintf("<input type=\"submit\" name=\"send_button\" value=\"");
+        if (recipient_required) {
+                wprintf(_("Send message"));
+        } else {
+                wprintf(_("Post message"));
+        }
+        wprintf("\">&nbsp;"
+                "<input type=\"submit\" name=\"cancel_button\" value=\"%s\">\n", _("Cancel"));
+        wprintf("</p>");
 
        /** header bar */
 
-       wprintf("<img src=\"static/newmess3_24x.gif\" align=middle alt=\" \">");
+       wprintf("<img src=\"static/newmess3_24x.gif\" class=\"imgedit\">");
+       wprintf("  ");  /** header bar */
        fmt_date(buf, now, 0);
-       wprintf("%s ", buf);
+       wprintf("%s", buf);
+       wprintf("\n");  /** header bar */
 
+       wprintf("<div>");
+       wprintf("<label for=\"from_id\" > ");
        wprintf(_(" <I>from</I> "));
+       wprintf("</label>");
 
        /* Allow the user to select any of his valid screen names */
 
-       wprintf("<select name=\"display_name\" size=1>\n");
+       wprintf("<select name=\"display_name\" size=1 id=\"from_id\">\n");
 
        serv_puts("GVSN");
        serv_getln(buf, sizeof buf);
@@ -3001,82 +3153,66 @@ void display_enter(void)
 
        wprintf(_(" <I>in</I> "));
        escputs(WC->wc_roomname);
-       wprintf("<br>\n");      /** header bar */
+       wprintf("</div>");
 
-       wprintf("<table border=\"0\" width=\"100%%\">\n");
        if (recipient_required) {
 
-               wprintf("<tr><td>");
-               wprintf("<font size=-1>");
+               wprintf("<div style=\"float: left;\"><label for=\"recp_id\"> ");
                wprintf(_("To:"));
-               wprintf("</font>");
-               wprintf("</td><td>"
+               wprintf("</label>"
                        "<input autocomplete=\"off\" type=\"text\" name=\"recp\" id=\"recp_id\" value=\"");
                escputs(bstr("recp"));
-               wprintf("\" size=50 maxlength=1000 />");
+               wprintf("\" size=45 maxlength=1000 />");
                wprintf("<div class=\"auto_complete\" id=\"recp_name_choices\"></div>");
 
-               /** Pop open an address book -- begin **/
 
-               wprintf(
-                       "<a href=\"javascript:PopOpenAddressBook();\" title=\"%s\">"
-                       "<img border=0 width=16 height=16 src=\"static/viewcontacts_16x.gif\">"
-                       "</a>", _("Contacts")
-               );
-
-               /** Pop open an address book -- end **/
-
-               wprintf("</td><td></td></tr>\n");
-
-               wprintf("<tr><td>");
-               wprintf("<font size=-1>");
+               wprintf("<br/><label for=\"cc_id\"> ");
                wprintf(_("CC:"));
-               wprintf("</font>");
-               wprintf("</td><td>"
+               wprintf("</label>"
                        "<input autocomplete=\"off\" type=\"text\" name=\"cc\" id=\"cc_id\" value=\"");
                escputs(bstr("cc"));
-               wprintf("\" size=50 maxlength=1000 />");
+               wprintf("\" size=45 maxlength=1000 />");
                wprintf("<div class=\"auto_complete\" id=\"cc_name_choices\"></div>");
-               wprintf("</td><td></td></tr>\n");
-
-               wprintf("<tr><td>");
-               wprintf("<font size=-1>");
+               wprintf("<br/><label for=\"bcc_id\"> ");
                wprintf(_("BCC:"));
-               wprintf("</font>");
-               wprintf("</td><td>"
+               wprintf("</label>"
                        "<input autocomplete=\"off\" type=\"text\" name=\"bcc\" id=\"bcc_id\" value=\"");
                escputs(bstr("bcc"));
-               wprintf("\" size=50 maxlength=1000 />");
+               wprintf("\" size=45 maxlength=1000 />");
                wprintf("<div class=\"auto_complete\" id=\"bcc_name_choices\"></div>");
-               wprintf("</td><td></td></tr>\n");
 
                /** Initialize the autocomplete ajax helpers (found in wclib.js) */
                wprintf("<script type=\"text/javascript\">      \n"
                        " activate_entmsg_autocompleters();     \n"
                        "</script>                              \n"
                );
-       }
+               wprintf("</div>");
 
-       wprintf("<tr><td>");
-       wprintf("<font size=-1>");
-       wprintf(_("Subject (optional):"));
-       wprintf("</font>");
-       wprintf("</td><td>"
-               "<input type=\"text\" name=\"subject\" value=\"");
-       escputs(bstr("subject"));
-       wprintf("\" size=50 maxlength=70></td><td>\n");
+               /** Pop open an address book -- begin **/
+               wprintf(
+                       "<a href=\"javascript:PopOpenAddressBook('recp_id|%s|cc_id|%s|bcc_id|%s');\" "
+                       "title=\"%s\">"
+                       "<img align=middle border=0 width=24 height=24 src=\"static/viewcontacts_24x.gif\">"
+                       "&nbsp;%s</a>",
+                       _("To:"), _("CC:"), _("BCC:"),
+                       _("Contacts"), _("Contacts")
+               );
+               /** Pop open an address book -- end **/
+       }
 
-       wprintf("<input type=\"submit\" name=\"send_button\" value=\"");
-       if (recipient_required) {
-               wprintf(_("Send message"));
-       } else {
-               wprintf(_("Post message"));
+       wprintf("<div style=\"clear: both;\"><label for=\"subject_id\" > ");
+       if (recipient_required || subject_required) {
+               wprintf(_("Subject:"));
+       }
+       else {
+               wprintf(_("Subject (optional):"));
        }
-       wprintf("\">&nbsp;"
-               "<input type=\"submit\" name=\"cancel_button\" value=\"%s\">\n", _("Cancel"));
-       wprintf("</td></tr></table>\n");
+       wprintf("</label>"
+               "<input type=\"text\" name=\"subject\" id=\"subject_id\" value=\" ");
+       escputs(bstr("subject"));
+       wprintf("\" size=45 maxlength=70>\n");
 
-       wprintf("<center>");
+       wprintf("</div>\n");
 
        wprintf("<textarea name=\"msgtext\" cols=\"80\" rows=\"15\">");
 
@@ -3113,10 +3249,12 @@ void display_enter(void)
        if ( (WC->is_mailbox) && (strcmp(bstr("sig_inserted"), "yes")) ) {
                get_preference("use_sig", buf, sizeof buf);
                if (!strcasecmp(buf, "yes")) {
+                       int len;
                        get_preference("signature", ebuf, sizeof ebuf);
                        euid_unescapize(buf, ebuf);
                        wprintf("<br>--<br>");
-                       for (i=0; i<strlen(buf); ++i) {
+                       len = strlen(buf);
+                       for (i=0; i<len; ++i) {
                                if (buf[i] == '\n') {
                                        wprintf("<br>");
                                }
@@ -3143,30 +3281,15 @@ void display_enter(void)
        }
 
        wprintf("</textarea>");
-       wprintf("</center><br />\n");
 
        /**
-        * The following script embeds the TinyMCE richedit control, and automatically
+        * The following template embeds the TinyMCE richedit control, and automatically
         * transforms the textarea into a richedit textarea.
         */
-       wprintf(
-               "<script language=\"javascript\" type=\"text/javascript\" src=\"tiny_mce/tiny_mce.js\"></script>\n"
-               "<script language=\"javascript\" type=\"text/javascript\">"
-               "tinyMCE.init({"
-               "       mode : \"textareas\", width : \"100%%\", browsers : \"msie,gecko\", "
-               "       theme : \"advanced\", plugins : \"iespell\", "
-               "       theme_advanced_buttons1 : \"bold, italic, underline, strikethrough, justifyleft, justifycenter, justifyright, justifyfull, bullist, numlist, cut, copy, paste, link, image, help, forecolor, iespell, code\", "
-               "       theme_advanced_buttons2 : \"\", "
-               "       theme_advanced_buttons3 : \"\", "
-               "       content_css : \"static/webcit-tinymce.css\" "
-               "});"
-               "</script>\n"
-       );
-
+       do_template("richedit");
 
        /** Enumerate any attachments which are already in place... */
-       wprintf("<img src=\"static/diskette_24x.gif\" border=0 "
-               "align=middle height=16 width=16> ");
+       wprintf("<div><img src=\"static/diskette_24x.gif\" class=\"imgedit\" ");
        wprintf(_("Attachments:"));
        wprintf(" ");
        wprintf("<select name=\"which_attachment\" size=1>");
@@ -3183,41 +3306,22 @@ void display_enter(void)
        /** Now offer the ability to attach additional files... */
        wprintf("&nbsp;&nbsp;&nbsp;");
        wprintf(_("Attach file:"));
-       wprintf(" <input NAME=\"attachfile\" "
-               "SIZE=16 TYPE=\"file\">\n&nbsp;&nbsp;"
+       wprintf(" <input name=\"attachfile\" "
+               "size=16 type=\"file\">\n&nbsp;&nbsp;"
                "<input type=\"submit\" name=\"attach_button\" value=\"%s\">\n", _("Add"));
+       wprintf("</div>");
 
-       /** Seth asked for these to be at the top *and* bottom... */
-       wprintf("<input type=\"submit\" name=\"send_button\" value=\"");
-       if (recipient_required) {
-               wprintf(_("Send message"));
-       } else {
-               wprintf(_("Post message"));
-       }
-       wprintf("\">&nbsp;"
-               "<input type=\"submit\" name=\"cancel_button\" value=\"%s\">\n", _("Cancel"));
 
        /** Make sure we only insert our signature once */
        if (strcmp(bstr("sig_inserted"), "yes")) {
-               wprintf("<INPUT TYPE=\"hidden\" NAME=\"sig_inserted\" VALUE=\"yes\">\n");
+               wprintf("<input type=\"hidden\" name=\"sig_inserted\" value=\"yes\">\n");
        }
 
        wprintf("</form>\n");
-       wprintf("</td></tr></table></div>\n");
+       wprintf("</div></div>\n");
 
-       wprintf("</div>\n");    /* End of 'content' div */
-
-       /* Open a new div, hidden initially, for address book popups.
-        * FIXME put this in its own function so we can use it from the
-        * calendar too.
-        */
-       wprintf("<div id=\"address_book_popup\" style=\"display:none;\">");
-       wprintf("<div id=\"address_book_popup_container_div\">");
-       wprintf("<div id=\"address_book_popup_middle_div\"></div>");
-       wprintf("<div id=\"address_book_inner_div\"></div>");
-       wprintf("</div>");
-       /* The 'address_book_popup' div will be closed by wDumpContent() */
-DONE:  wDumpContent(1);
+DONE:  address_book_popup();
+       wDumpContent(1);
 }
 
 
@@ -3255,7 +3359,7 @@ void move_msg(void)
 
        msgid = atol(bstr("msgid"));
 
-       if (strlen(bstr("move_button")) > 0) {
+       if (!IsEmptyStr(bstr("move_button"))) {
                sprintf(buf, "MOVE %ld|%s", msgid, bstr("target_room"));
                serv_puts(buf);
                serv_getln(buf, sizeof buf);
@@ -3285,12 +3389,12 @@ void confirm_move_msg(void)
 
        output_headers(1, 1, 2, 0, 0, 0);
        wprintf("<div id=\"banner\">\n");
-       wprintf("<TABLE WIDTH=100%% BORDER=0><TR><TD>");
-       wprintf("<SPAN CLASS=\"titlebar\">");
+       wprintf("<h1>");
        wprintf(_("Confirm move of message"));
-       wprintf("</SPAN>\n");
-       wprintf("</TD></TR></TABLE>\n");
-       wprintf("</div>\n<div id=\"content\">\n");
+       wprintf("</h1>");
+       wprintf("</div>\n");
+
+       wprintf("<div id=\"content\" class=\"service\">\n");
 
        wprintf("<CENTER>");
 
@@ -3298,6 +3402,7 @@ void confirm_move_msg(void)
        wprintf("<br />\n");
 
        wprintf("<form METHOD=\"POST\" action=\"move_msg\">\n");
+       wprintf("<input type=\"hidden\" name=\"nonce\" value=\"%ld\">\n", WC->nonce);
        wprintf("<INPUT TYPE=\"hidden\" NAME=\"msgid\" VALUE=\"%s\">\n", bstr("msgid"));
 
        wprintf("<SELECT NAME=\"target_room\" SIZE=5>\n");