URL-Parsing: fix off by one when checking the length of URL params
[citadel.git] / webcit / paramhandling.c
index 912aa6f0be33b8a546e372a2f6695e803fa17a90..9db69f7e78791ab4b7072958b0fa1d696c2626fb 100644 (file)
@@ -1,5 +1,15 @@
 /*
  * parse urlparts and post data
+ *
+ * Copyright (c) 1996-2012 by the citadel.org team
+ *
+ * This program is open source software.  You can redistribute it and/or
+ * modify it under the terms of the GNU General Public License, version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
  */
 
 #include "webcit.h"
@@ -40,18 +50,18 @@ void ParseURLParams(StrBuf *url)
                        bptr++;
                }
                keylen = aptr - up - 1; /* -1 -> '=' */
-               if(keylen > sizeof(u->url_key)) {
-                       syslog(1, "URLkey to long! [%s]", up);
-                       continue;
+               if(keylen >= sizeof(u->url_key)) {
+                       syslog(1, "invalid url_key from %s", ChrPtr(WCC->Hdr->HR.browser_host));
+                       return;
                }
 
                u = (urlcontent *) malloc(sizeof(urlcontent));
                memcpy(u->url_key, up, keylen);
                u->url_key[keylen] = '\0';
                if (keylen < 0) {
-                       syslog(1, "URLkey to long! [%s]", up);
+                       syslog(1, "invalid url_key from %s", ChrPtr(WCC->Hdr->HR.browser_host));
                        free(u);
-                       continue;
+                       return;
                }
                
                if (strncmp(u->url_key, "__", 2) != 0)
@@ -61,7 +71,7 @@ void ParseURLParams(StrBuf *url)
                        u->url_data = NewStrBufPlain(aptr, len);
                        StrBufUnescape(u->url_data, 1);
 #ifdef DEBUG_URLSTRINGS
-                       syslog(9, "%s = [%ld]  %s\n", 
+                       syslog(9, "%s = [%d]  %s\n", 
                                u->url_key, 
                                StrLength(u->url_data), 
                                ChrPtr(u->url_data)); 
@@ -71,7 +81,7 @@ void ParseURLParams(StrBuf *url)
                        len = bptr - aptr;
                        u->url_data = NewStrBufPlain(aptr, len);
                        StrBufUnescape(u->url_data, 1);
-                       syslog(1, "REJECTED because of __ is internal only: %s = [%ld]  %s\n", 
+                       syslog(1, "REJECTED because of __ is internal only: %s = [%d]  %s\n", 
                                u->url_key, 
                                StrLength(u->url_data), 
                                ChrPtr(u->url_data)); 
@@ -308,7 +318,7 @@ void upload_handler(char *name, char *filename, char *partnum, char *disp,
        long keylen;
 
 #ifdef DEBUG_URLSTRINGS
-       syslog(9, "\033[31mupload_handler() name=%s, type=%s, len=%d\033[0m\n", name, cbtype, length);
+       syslog(9, "upload_handler() name=%s, type=%s, len=%d", name, cbtype, length);
 #endif
        if (WCC->Hdr->urlstrings == NULL)
                WCC->Hdr->urlstrings = NewHash(1, NULL);
@@ -325,7 +335,7 @@ void upload_handler(char *name, char *filename, char *partnum, char *disp,
                        Put(WCC->Hdr->urlstrings, u->url_key, keylen, u, free_url);
                }
                else {
-                       syslog(1, "REJECTED because of __ is internal only: %s = [%ld]  %s\n", 
+                       syslog(1, "REJECTED because of __ is internal only: %s = [%d]  %s\n", 
                                u->url_key, 
                                StrLength(u->url_data), 
                                ChrPtr(u->url_data)); 
@@ -333,7 +343,7 @@ void upload_handler(char *name, char *filename, char *partnum, char *disp,
                        free_url(u);
                }
 #ifdef DEBUG_URLSTRINGS
-               syslog(9, "Key: <%s> len: [%ld] Data: <%s>\n", 
+               syslog(9, "Key: <%s> len: [%d] Data: <%s>", 
                        u->url_key, 
                        StrLength(u->url_data), 
                        ChrPtr(u->url_data));
@@ -347,7 +357,7 @@ void upload_handler(char *name, char *filename, char *partnum, char *disp,
                WCC->upload_filename = NewStrBufPlain(filename, -1);
                safestrncpy(WCC->upload_content_type, cbtype, sizeof(WC->upload_content_type));
 #ifdef DEBUG_URLSTRINGS
-               syslog(9, "File: <%s> len: [%ld]\n", filename, length);
+               syslog(9, "File: <%s> len: [%ld]", filename, length);
 #endif
                
        }
@@ -359,9 +369,10 @@ void upload_handler(char *name, char *filename, char *partnum, char *disp,
 void PutBstr(const char *key, long keylen, StrBuf *Value)
 {
        urlcontent *u;
+       wcsession *WCC = WC;
 
-       if(keylen > sizeof(u->url_key)) {
-               syslog(1, "URLkey to long! [%s]", key);
+       if(keylen >= sizeof(u->url_key)) {
+               syslog(1, "invalid url_key from %s", ChrPtr(WCC->Hdr->HR.browser_host));
                FreeStrBuf(&Value);
                return;
        }
@@ -421,11 +432,11 @@ void diagnostics(void)
        wc_printf("Session: %d<hr />\n", WC->wc_session);
        wc_printf("Command: <br><PRE>\n");
 /*     
-StrEscPuts(WC->UrlFragment1);
+StrEscAppend(WC->WBuf, NULL, WC->UrlFragment1, 0, 0);
        wc_printf("<br>\n");
-       StrEscPuts(WC->UrlFragment2);
+StrEscAppend(WC->WBuf, NULL, WC->UrlFragment12 0, 0);
        wc_printf("<br>\n");
-       StrEscPuts(WC->UrlFragment3);
+StrEscAppend(WC->WBuf, NULL, WC->UrlFragment3, 0, 0);
 */
        wc_printf("</PRE><hr />\n");
        wc_printf("Variables: <br><PRE>\n");
@@ -466,14 +477,88 @@ void tmplput_url_part(StrBuf *Target, WCTemplputParams *TP)
        }
 }
 
+typedef struct __BstrPair {
+       StrBuf *x;
+       StrBuf *y;
+}BstrPair;
+CtxType CTX_BSTRPAIRS = CTX_NONE;
+void HFreeBstrPair(void *pv)
+{
+       BstrPair *p = (BstrPair*) pv;
+       FreeStrBuf(&p->x);
+       FreeStrBuf(&p->y);
+       free(pv);
+}
+
+HashList *iterate_GetBstrPairs(StrBuf *Target, WCTemplputParams *TP)
+{
+       StrBuf *X, *Y;
+        const char *ch = NULL;
+        long len;
+       const StrBuf *TheBStr;
+       BstrPair *OnePair;
+        HashList *List;
+       const char *Pos = NULL;
+       int i = 0;
+
+       if (HaveTemplateTokenString(NULL, TP, 2, &ch, &len))
+        {
+                GetTemplateTokenString(Target, TP, 2, &ch, &len);
+        }
+       else 
+       {
+               return NULL;
+       }
+
+       TheBStr = SBstr(ch, len);
+       if ((TheBStr == NULL) || (StrLength(TheBStr) == 0))
+               return NULL;
+       List = NewHash(1, NULL);
+       while (Pos != StrBufNOTNULL)
+       {
+               X = NewStrBufPlain(NULL, StrLength(TheBStr));
+               StrBufExtract_NextToken(X, TheBStr, &Pos, '|');
+               if (Pos == StrBufNOTNULL) {
+                       FreeStrBuf(&X);
+                       DeleteHash(&List);
+                       return NULL;
+               }
+               Y = NewStrBufPlain(NULL, StrLength(TheBStr));
+               StrBufExtract_NextToken(Y, TheBStr, &Pos, '|');
+               OnePair = (BstrPair*)malloc(sizeof(BstrPair));
+               OnePair->x = X;
+               OnePair->y = Y;
+               Put(List, IKEY(i), OnePair, HFreeBstrPair);
+               i++;
+       }
+       return List;
+}
+
+
+void tmplput_bstr_pair(StrBuf *Target, WCTemplputParams *TP, int XY)
+{
+       BstrPair *Pair = (BstrPair*) CTX(CTX_BSTRPAIRS);
+
+       StrBufAppendTemplate(Target, TP, (XY)?Pair->y:Pair->x, 0);
+}
+
+void tmplput_bstr_pair_x(StrBuf *Target, WCTemplputParams *TP)
+{      tmplput_bstr_pair(Target, TP, 0); }
+void tmplput_bstr_pair_y(StrBuf *Target, WCTemplputParams *TP)
+{      tmplput_bstr_pair(Target, TP, 1); }
 
 void 
 InitModule_PARAMHANDLING
 (void)
 {
+       RegisterCTX(CTX_BSTRPAIRS);
        WebcitAddUrlHandler(HKEY("diagnostics"), "", 0, diagnostics, NEED_URL);
 
-       RegisterConditional(HKEY("COND:BSTR"), 1, ConditionalBstr, CTX_NONE);
+       RegisterIterator("ITERATE:BSTR:PAIR", 1, NULL, iterate_GetBstrPairs, NULL, DeleteHash, CTX_BSTRPAIRS, CTX_NONE, IT_NOFLAG);
+       RegisterNamespace("BSTR:PAIR:X", 1, 2, tmplput_bstr_pair_x, NULL, CTX_BSTRPAIRS);
+       RegisterNamespace("BSTR:PAIR:Y", 1, 2, tmplput_bstr_pair_y, NULL, CTX_BSTRPAIRS);
+
+       RegisterConditional("COND:BSTR", 1, ConditionalBstr, CTX_NONE);
        RegisterNamespace("BSTR", 1, 2, tmplput_bstr, NULL, CTX_NONE);
        RegisterNamespace("BSTR:FORWARD", 1, 2, tmplput_bstrforward, NULL, CTX_NONE);
        RegisterNamespace("URLPART", 1, 2, tmplput_url_part, NULL, CTX_NONE);