* move room listing related stuff into its own file
[citadel.git] / webcit / roomops.c
index 54948e49e221dea1d9f0b9d23dc6ea6111b2be59..f6347c660fc165d6fef89d0260ff975c3065c6d0 100644 (file)
@@ -5,26 +5,16 @@
 
 #include "webcit.h"
 #include "webserver.h"
+#include "roomops.h"
 #define MAX_FLOORS 128
-char floorlist[MAX_FLOORS][SIZ]; /**< list of our floor names */
-
-char *viewdefs[9]; /**< the different kinds of available views */
-
-/** See GetFloorListHash and GetRoomListHash for info on these. Basically we pull LFLR/LKRA etc. and set up a room HashList with these keys. */
-const char FLOOR_PARAM_NAMES[(FLOOR_PARAM_LEN + 1)][15] = {"ID",
-                                                          "NAME", 
-                                                          "ROOMS"};
-const char ROOM_PARAM_NAMES[(ROOM_PARAM_LEN + 1)][20] = {"NAME",
-                                                        "FLAG",
-                                                        "FLOOR",
-                                                        "LISTORDER",
-                                                        "ACL",
-                                                        "CURVIEW",
-                                                        "DEFVIEW",
-                                                        "LASTCHANGE"};
-/* Because avoiding strlen at run time is a Good Thing(TM) */
-const int FLOOR_PARAM_NAMELEN[(FLOOR_PARAM_LEN +1)] = {2, 4, 5};
-const int ROOM_PARAM_NAMELEN[(ROOM_PARAM_LEN +1)] = {4, 4, 5, 9, 3, 7, 7, 8};
+
+char floorlist[MAX_FLOORS][SIZ];       /* list of our floor names */
+
+char *viewdefs[9];                     /* the different kinds of available views */
+
+/* See GetFloorListHash and GetRoomListHash for info on these.
+ * Basically we pull LFLR/LKRA etc. and set up a room HashList with these keys.
+ */
 
 void display_whok(void);
 
@@ -97,52 +87,6 @@ void load_floorlist(StrBuf *Buf)
 }
 
 
-/*
- * Free a session's march list
- */
-void free_march_list(wcsession *wcf)
-{
-       struct march *mptr;
-
-       while (wcf->march != NULL) {
-               mptr = wcf->march->next;
-               free(wcf->march);
-               wcf->march = mptr;
-       }
-
-}
-
-
-
-/*
- * remove a room from the march list
- */
-void remove_march(const StrBuf *aaa)
-{
-       struct march *mptr, *mptr2;
-
-       if (WC->march == NULL)
-               return;
-
-       if (!strcasecmp(WC->march->march_name, ChrPtr(aaa))) {
-               mptr = WC->march->next;
-               free(WC->march);
-               WC->march = mptr;
-               return;
-       }
-       mptr2 = WC->march;
-       for (mptr = WC->march; mptr != NULL; mptr = mptr->next) {
-               if (!strcasecmp(mptr->march_name, ChrPtr(aaa))) {
-                       mptr2->next = mptr->next;
-                       free(mptr);
-                       mptr = mptr2;
-               } else {
-                       mptr2 = mptr;
-               }
-       }
-}
-
-
 
 
 /*
@@ -162,7 +106,7 @@ void room_tree_list(struct roomlisting *rp)
        strcpy(rmname, rp->rlname);
        f = rp->rlflags;
 
-       wprintf("<a href=\"dotgoto&room=");
+       wprintf("<a href=\"dotgoto?room=");
        urlescputs(rmname);
        wprintf("\"");
        wprintf(">");
@@ -182,11 +126,8 @@ void room_tree_list(struct roomlisting *rp)
 }
 
 
-/** 
- * \brief Room ordering stuff (compare first by floor, then by order)
- * \param r1 first roomlist to compare
- * \param r2 second roomlist co compare
- * \return are they the same???
+/* 
+ * Room ordering stuff (compare first by floor, then by order)
  */
 int rordercmp(struct roomlisting *r1, struct roomlisting *r2)
 {
@@ -208,9 +149,8 @@ int rordercmp(struct roomlisting *r1, struct roomlisting *r2)
 }
 
 
-/**
- * \brief Common code for all room listings
- * \param variety what???
+/*
+ * Common code for all room listings
  */
 void listrms(char *variety)
 {
@@ -221,7 +161,7 @@ void listrms(char *variety)
        struct roomlisting *rp;
        struct roomlisting *rs;
 
-       /** Ask the server for a room list */
+       /* Ask the server for a room list */
        serv_puts(variety);
        serv_getln(buf, sizeof buf);
        if (buf[0] != '1') {
@@ -264,7 +204,7 @@ void listrms(char *variety)
 
        room_tree_list(rl);
 
-       /**
+       /*
         * If no rooms were listed, print an nbsp to make the cell
         * borders show up anyway.
         */
@@ -272,8 +212,8 @@ void listrms(char *variety)
 }
 
 
-/**
- * \brief list all forgotten rooms
+/*
+ * list all forgotten rooms
  */
 void zapped_list(void)
 {
@@ -298,8 +238,8 @@ void zapped_list(void)
 }
 
 
-/**
- * \brief read this room's info file (set v to 1 for verbose mode)
+/*
+ * read this room's info file (set v to 1 for verbose mode)
  */
 void readinfo(StrBuf *Target, WCTemplputParams *TP)
 {
@@ -324,14 +264,15 @@ void readinfo(StrBuf *Target, WCTemplputParams *TP)
 
                 wprintf("<div class=\"infos\" "
                        "onclick=\"javascript:Effect.Appear('room_infos', { duration: 0.5 });\" "
-                       ">");
+                       ">"
+               );
                escputs(briefinfo);
                 wprintf("</div><div id=\"room_infos\" style=\"display:none;\">");
                wprintf("<img class=\"close_infos\" "
                        "onclick=\"javascript:Effect.Fade('room_infos', { duration: 0.5 });\" "
-                       "src=\"static/closewindow.gif\" alt=\"%s\">",
+                       "src=\"static/closewindow.gif\" alt=\"%s\"  width=\"16\" height=\"16\">",
                        _("Close window")
-                       );
+               );
                escputs(fullinfo);
                 wprintf("</div>");
        }
@@ -343,12 +284,10 @@ void readinfo(StrBuf *Target, WCTemplputParams *TP)
 
 
 
-/**
- * \brief Display room banner icon.  
- * The server doesn't actually
- * need the room name, but we supply it in order to
- * keep the browser from using a cached icon from 
- * another room.
+/*
+ * Display room banner icon.  
+ * The server doesn't actually need the room name, but we supply it in
+ * order to keep the browser from using a cached icon from another room.
  */
 void embed_room_graphic(StrBuf *Target, WCTemplputParams *TP)
 {
@@ -357,7 +296,7 @@ void embed_room_graphic(StrBuf *Target, WCTemplputParams *TP)
        serv_puts("OIMG _roompic_");
        serv_getln(buf, sizeof buf);
        if (buf[0] == '2') {
-               wprintf("<img height=\"64px\" src=\"image&name=_roompic_&room=");
+               wprintf("<img height=\"64px\" src=\"image?name=_roompic_&room=");
                urlescputs(ChrPtr(WC->wc_roomname));
                wprintf("\">");
                serv_puts("CLOS");
@@ -366,37 +305,37 @@ void embed_room_graphic(StrBuf *Target, WCTemplputParams *TP)
        else if (WC->wc_view == VIEW_ADDRESSBOOK) {
                wprintf("<img class=\"roompic\" alt=\"\" src=\""
                        "static/viewcontacts_48x.gif"
-                       "\">"
+                       "\" >"
                        );
        }
        else if ( (WC->wc_view == VIEW_CALENDAR) || (WC->wc_view == VIEW_CALBRIEF) ) {
                wprintf("<img class=\"roompic\" alt=\"\" src=\""
                        "static/calarea_48x.gif"
-                       "\">"
+                       "\" width=\"48\" height=\"48\">"
                        );
        }
        else if (WC->wc_view == VIEW_TASKS) {
                wprintf("<img class=\"roompic\" alt=\"\" src=\""
                        "static/taskmanag_48x.gif"
-                       "\">"
+                       "\" width=\"48\" height=\"48\">"
                        );
        }
        else if (WC->wc_view == VIEW_NOTES) {
                wprintf("<img class=\"roompic\" alt=\"\" src=\""
                        "static/storenotes_48x.gif"
-                       "\">"
+                       "\" width=\"48\" height=\"48\">"
                        );
        }
        else if (WC->wc_view == VIEW_MAILBOX) {
                wprintf("<img class=\"roompic\" alt=\"\" src=\""
                        "static/privatemess_48x.gif"
-                       "\">"
+                       "\" width=\"48\" height=\"48\">"
                        );
        }
        else {
                wprintf("<img class=\"roompic\" alt=\"\" src=\""
                        "static/chatrooms_48x.gif"
-                       "\">"
+                       "\" width=\"48\" height=\"48\">"
                        );
        }
 
@@ -404,8 +343,8 @@ void embed_room_graphic(StrBuf *Target, WCTemplputParams *TP)
 
 
 
-/**
- * \brief Display the current view and offer an option to change it
+/*
+ * Display the current view and offer an option to change it
  */
 void embed_view_o_matic(StrBuf *Target, WCTemplputParams *TP)
 {
@@ -422,17 +361,17 @@ void embed_view_o_matic(StrBuf *Target, WCTemplputParams *TP)
                "[selectedIndex].value\">\n");
 
        for (i=0; i<(sizeof viewdefs / sizeof (char *)); ++i) {
-               /**
+               /*
                 * Only offer the views that make sense, given the default
                 * view for the room.  For example, don't offer a Calendar
                 * view in a non-Calendar room.
                 */
                if (
                        (i == WC->wc_view)
-                       ||      (i == WC->wc_default_view)                      /**< default */
-                       ||      ( (i == 0) && (WC->wc_default_view == 1) )      /**< mail or bulletin */
-                       ||      ( (i == 1) && (WC->wc_default_view == 0) )      /**< mail or bulletin */
-                       /** ||  ( (i == 7) && (WC->wc_default_view == 3) )      (calendar list temporarily disabled) */
+                       ||      (i == WC->wc_default_view)                      /* default */
+                       ||      ( (i == 0) && (WC->wc_default_view == 1) )      /* mail or bulletin */
+                       ||      ( (i == 1) && (WC->wc_default_view == 0) )      /* mail or bulletin */
+                       /* ||   ( (i == 7) && (WC->wc_default_view == 3) )      (calendar list temporarily disabled) */
                        ) {
 
                        wprintf("<option %s value=\"changeview?view=%d\">",
@@ -446,8 +385,8 @@ void embed_view_o_matic(StrBuf *Target, WCTemplputParams *TP)
 }
 
 
-/**
- * \brief Display a search box
+/*
+ * Display a search box
  */
 void embed_search_o_matic(StrBuf *Target, WCTemplputParams *TP)
 {
@@ -463,11 +402,11 @@ void embed_search_o_matic(StrBuf *Target, WCTemplputParams *TP)
 }
 
 
-/**
- * \brief              Embed the room banner
+/*
+ * Embed the room banner
  *
- * \param got          The information returned from a GOTO server command
- * \param navbar_style         Determines which navigation buttons to display
+ * got                 The information returned from a GOTO server command
+ * navbar_style        Determines which navigation buttons to display
  *
  */
 
@@ -478,7 +417,7 @@ void embed_room_banner(char *got, int navbar_style) {
        char with_files[256];
        int file_count=0;
        
-       /**
+       /*
         * We need to have the information returned by a GOTO server command.
         * If it isn't supplied, we fake it by issuing our own GOTO.
         */
@@ -490,25 +429,27 @@ void embed_room_banner(char *got, int navbar_style) {
                got = buf;
        }
 
-       /** The browser needs some information for its own use */
+       /* The browser needs some information for its own use */
        wprintf("<script type=\"text/javascript\">      \n"
                "       room_is_trash = %d;             \n"
                "</script>\n",
                WC->wc_is_trash
-               );
+       );
 
-       /**
+       /*
         * If the user happens to select the "make this my start page" link,
         * we want it to remember the URL as a "/dotskip" one instead of
         * a "skip" or "gotonext" or something like that.
         */
-       if (WCC->Hdr->this_page == NULL)
+       if (WCC->Hdr->this_page == NULL) {
                WCC->Hdr->this_page = NewStrBuf();
+       }
        StrBufPrintf(WCC->Hdr->this_page, 
-                    "dotskip&room=%s",
-                    ChrPtr(WC->wc_roomname));
+                    "dotskip?room=%s",
+                    ChrPtr(WC->wc_roomname)
+       );
 
-       /** Check for new mail. */
+       /* Check for new mail. */
        WC->new_mail = extract_int(&got[4], 9);
        WC->wc_view = extract_int(&got[4], 11);
 
@@ -548,7 +489,7 @@ void embed_room_banner(char *got, int navbar_style) {
                if (navbar_style == navbar_default) wprintf(
                        "<li class=\"ungoto\">"
                        "<a href=\"ungoto\">"
-                       "<img src=\"static/ungoto2_24x.gif\" alt=\"\">"
+                       "<img src=\"static/ungoto2_24x.gif\" alt=\"\" width=\"24\" height=\"24\">"
                        "<span class=\"navbar_link\">%s</span></A>"
                        "</li>\n", _("Ungoto")
                        );
@@ -557,7 +498,7 @@ void embed_room_banner(char *got, int navbar_style) {
                        wprintf(
                                "<li class=\"newmess\">"
                                "<a href=\"readnew\">"
-                               "<img src=\"static/newmess2_24x.gif\" alt=\"\">"
+                               "<img src=\"static/newmess2_24x.gif\" alt=\"\" width=\"24\" height=\"24\">"
                                "<span class=\"navbar_link\">%s</span></A>"
                                "</li>\n", _("Read new messages")
                                );
@@ -570,7 +511,7 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"viewcontacts\">"
                                        "<a href=\"readfwd\">"
                                        "<img src=\"static/viewcontacts_24x.gif\" "
-                                       "alt=\"\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
                                        "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("View contacts")
@@ -581,7 +522,7 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"staskday\">"
                                        "<a href=\"readfwd?calview=day\">"
                                        "<img src=\"static/taskday2_24x.gif\" "
-                                       "alt=\"\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
                                        "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Day view")
@@ -590,7 +531,7 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"monthview\">"
                                        "<a href=\"readfwd?calview=month\">"
                                        "<img src=\"static/monthview2_24x.gif\" "
-                                       "alt=\"\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
                                        "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Month view")
@@ -601,7 +542,7 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"monthview\">"
                                        "<a href=\"readfwd?calview=month\">"
                                        "<img src=\"static/monthview2_24x.gif\" "
-                                       "alt=\"\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
                                        "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Calendar list")
@@ -612,7 +553,7 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"taskmanag\">"
                                        "<a href=\"readfwd\">"
                                        "<img src=\"static/taskmanag_24x.gif\" "
-                                       "alt=\"\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
                                        "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("View tasks")
@@ -623,7 +564,7 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"viewnotes\">"
                                        "<a href=\"readfwd\">"
                                        "<img src=\"static/viewnotes_24x.gif\" "
-                                       "alt=\"\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
                                        "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("View notes")
@@ -634,7 +575,7 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"readallmess\">"
                                        "<a id=\"m_refresh\" href=\"readfwd\">"
                                        "<img src=\"static/readallmess3_24x.gif\" "
-                                       "alt=\"\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
                                        "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Refresh message list")
@@ -645,7 +586,7 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"readallmess\">"
                                        "<a href=\"readfwd\">"
                                        "<img src=\"static/readallmess3_24x.gif\" "
-                                       "alt=\"\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
                                        "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Wiki home")
@@ -654,9 +595,9 @@ void embed_room_banner(char *got, int navbar_style) {
                        default:
                                wprintf(
                                        "<li class=\"readallmess\">"
-                                       "<a href=\"readfwd?startmsg=20&maxmsgs=20&is_summary=0&SortBy=date&SortOrder=2\">"
+                                       "<a href=\"readfwd\">"
                                        "<img src=\"static/readallmess3_24x.gif\" "
-                                       "alt=\"\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
                                        "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Read all messages")
@@ -672,7 +613,8 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"addnewcontact\">"
                                        "<a href=\"display_enter\">"
                                        "<img src=\"static/addnewcontact_24x.gif\" "
-                                       "alt=\"\"><span class=\"navbar_link\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
+                                       "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Add new contact")
                                        );
@@ -685,7 +627,8 @@ void embed_room_banner(char *got, int navbar_style) {
                                if (havebstr("day"  )) wprintf("?day=%s", bstr("day"));
                                wprintf("\">"
                                        "<img  src=\"static/addevent_24x.gif\" "
-                                       "alt=\"\"><span class=\"navbar_link\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
+                                       "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Add new event")
                                        );
@@ -695,7 +638,8 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"newmess\">"
                                        "<a href=\"display_enter\">"
                                        "<img  src=\"static/newmess3_24x.gif\" "
-                                       "alt=\"\"><span class=\"navbar_link\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
+                                       "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Add new task")
                                        );
@@ -705,7 +649,8 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"enternewnote\">"
                                        "<a href=\"add_new_note\">"
                                        "<img  src=\"static/enternewnote_24x.gif\" "
-                                       "alt=\"\"><span class=\"navbar_link\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
+                                       "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Add new note")
                                        );
@@ -717,7 +662,8 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"newmess\">"
                                        "<a href=\"display_enter?wikipage=%s\">"
                                        "<img  src=\"static/newmess3_24x.gif\" "
-                                       "alt=\"\"><span class=\"navbar_link\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
+                                       "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", buf, _("Edit this page")
                                        );
@@ -727,7 +673,8 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"newmess\">"
                                        "<a href=\"display_enter\">"
                                        "<img  src=\"static/newmess3_24x.gif\" "
-                                       "alt=\"\"><span class=\"navbar_link\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
+                                       "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Write mail")
                                        );
@@ -735,7 +682,7 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"newmess\">"
                                        "<a href=\"javascript:deleteAllSelectedMessages();\">"
                                        "<img  src=\"static/delete.gif\" "
-                                       "alt=\"\"><span class=\"navbar_link\">"
+                                       "alt=\"\" width=\"24\" height=\"24\"><span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Delete")
                                        );
@@ -745,7 +692,8 @@ void embed_room_banner(char *got, int navbar_style) {
                                        "<li class=\"newmess\">"
                                        "<a href=\"display_enter\">"
                                        "<img  src=\"static/newmess3_24x.gif\" "
-                                       "alt=\"\"><span class=\"navbar_link\">"
+                                       "alt=\"\" width=\"24\" height=\"24\">"
+                                       "<span class=\"navbar_link\">"
                                        "%s"
                                        "</span></a></li>\n", _("Enter a message")
                                        );
@@ -757,7 +705,8 @@ void embed_room_banner(char *got, int navbar_style) {
                        "<li class=\"skipthisroom\">"
                        "<a href=\"skip\" "
                        "title=\"%s\">"
-                       "<img  src=\"static/skipthisroom_24x.gif\" alt=\"\">"
+                       "<img  src=\"static/skipthisroom_24x.gif\" alt=\"\" "
+                       "width=\"24\" height=\"24\">"
                        "<span class=\"navbar_link\">%s</span></a>"
                        "</li>\n",
                        _("Leave all messages marked as unread, go to next room with unread messages"),
@@ -768,7 +717,8 @@ void embed_room_banner(char *got, int navbar_style) {
                        "<li class=\"markngo\">"
                        "<a href=\"gotonext\" "
                        "title=\"%s\">"
-                       "<img  src=\"static/markngo_24x.gif\" alt=\"\">"
+                       "<img  src=\"static/markngo_24x.gif\" alt=\"\" "
+                       "width=\"24\" height=\"24\">"
                        "<span class=\"navbar_link\">%s</span></a>"
                        "</li>\n",
                        _("Mark all messages as read, go to next room with unread messages"),
@@ -794,7 +744,8 @@ long gotoroom(const StrBuf *gname)
        strcpy(WC->ugname, ChrPtr(WC->wc_roomname));
        WC->uglsn = ls;
        Buf = NewStrBuf();
-       /** move to the new room */
+
+       /* move to the new room */
        serv_printf("GOTO %s", ChrPtr(gname));
        StrBuf_ServGetln(Buf);
        if  (GetServerStatus(Buf, &err) != 2) {
@@ -844,134 +795,6 @@ long gotoroom(const StrBuf *gname)
 }
 
 
-/**
- * \brief Locate the room on the march list which we most want to go to.  
- * Each room
- * is measured given a "weight" of preference based on various factors.
- * \param desired_floor the room number on the citadel server
- * \return the roomname
- */
-char *pop_march(int desired_floor)
-{
-       static char TheRoom[128];
-       int TheFloor = 0;
-       int TheOrder = 32767;
-       int TheWeight = 0;
-       int weight;
-       struct march *mptr = NULL;
-
-       strcpy(TheRoom, "_BASEROOM_");
-       if (WC->march == NULL)
-               return (TheRoom);
-
-       for (mptr = WC->march; mptr != NULL; mptr = mptr->next) {
-               weight = 0;
-               if ((strcasecmp(mptr->march_name, "_BASEROOM_")))
-                       weight = weight + 10000;
-               if (mptr->march_floor == desired_floor)
-                       weight = weight + 5000;
-
-               weight = weight + ((128 - (mptr->march_floor)) * 128);
-               weight = weight + (128 - (mptr->march_order));
-
-               if (weight > TheWeight) {
-                       TheWeight = weight;
-                       strcpy(TheRoom, mptr->march_name);
-                       TheFloor = mptr->march_floor;
-                       TheOrder = mptr->march_order;
-               }
-       }
-       return (TheRoom);
-}
-
-
-
-/*
- * Goto next room having unread messages.
- *
- * We want to skip over rooms that the user has already been to, and take the
- * user back to the lobby when done.  The room we end up in is placed in
- * newroom - which is set to 0 (the lobby) initially.
- * We start the search in the current room rather than the beginning to prevent
- * two or more concurrent users from dragging each other back to the same room.
- */
-void gotonext(void)
-{
-       char buf[256];
-       struct march *mptr = NULL;
-       struct march *mptr2 = NULL;
-       char room_name[128];
-       StrBuf *next_room;
-       int ELoop = 0;
-
-       /*
-        * First check to see if the march-mode list is already allocated.
-        * If it is, pop the first room off the list and go there.
-        */
-
-       if (WC->march == NULL) {
-               serv_puts("LKRN");
-               serv_getln(buf, sizeof buf);
-               if (buf[0] == '1')
-                       while (serv_getln(buf, sizeof buf), strcmp(buf, "000")) {
-                               if (IsEmptyStr(buf)) {
-                                       if (ELoop > 10000)
-                                               return;
-                                       if (ELoop % 100 == 0)
-                                               sleeeeeeeeeep(1);
-                                       ELoop ++;
-                                       continue;                                       
-                               }
-                               extract_token(room_name, buf, 0, '|', sizeof room_name);
-                               if (strcasecmp(room_name, ChrPtr(WC->wc_roomname))) {
-                                       mptr = (struct march *) malloc(sizeof(struct march));
-                                       mptr->next = NULL;
-                                       safestrncpy(mptr->march_name, room_name, sizeof mptr->march_name);
-                                       mptr->march_floor = extract_int(buf, 2);
-                                       mptr->march_order = extract_int(buf, 3);
-                                       if (WC->march == NULL) 
-                                               WC->march = mptr;
-                                       else 
-                                               mptr2->next = mptr;
-                                       mptr2 = mptr;
-                               }
-                               buf[0] = '\0';
-                       }
-               /*
-                * add _BASEROOM_ to the end of the march list, so the user will end up
-                * in the system base room (usually the Lobby>) at the end of the loop
-                */
-               mptr = (struct march *) malloc(sizeof(struct march));
-               mptr->next = NULL;
-               mptr->march_order = 0;
-               mptr->march_floor = 0;
-               strcpy(mptr->march_name, "_BASEROOM_");
-               if (WC->march == NULL) {
-                       WC->march = mptr;
-               } else {
-                       mptr2 = WC->march;
-                       while (mptr2->next != NULL)
-                               mptr2 = mptr2->next;
-                       mptr2->next = mptr;
-               }
-               /*
-                * ...and remove the room we're currently in, so a <G>oto doesn't make us
-                * walk around in circles
-                */
-               remove_march(WC->wc_roomname);
-       }
-       if (WC->march != NULL) {
-               next_room = NewStrBufPlain(pop_march(-1), -1);/*TODO: migrate march to strbuf */
-       } else {
-               next_room = NewStrBufPlain(HKEY("_BASEROOM_"));
-       }
-
-
-       smart_goto(next_room);
-       FreeStrBuf(&next_room);
-}
-
-
 /*
  * goto next room
  */
@@ -994,36 +817,6 @@ void slrp_highest(void)
 }
 
 
-/*
- * un-goto the previous room
- */
-void ungoto(void)
-{
-       StrBuf *Buf;
-
-       if (!strcmp(WC->ugname, "")) {
-               smart_goto(WC->wc_roomname);
-               return;
-       }
-       serv_printf("GOTO %s", WC->ugname);
-       Buf = NewStrBuf();
-       StrBuf_ServGetln(Buf);
-       if (GetServerStatus(Buf, NULL) != 2) {
-               smart_goto(WC->wc_roomname);
-               FreeStrBuf(&Buf);
-               return;
-       }
-       if (WC->uglsn >= 0L) {
-               serv_printf("SLRP %ld", WC->uglsn);
-               StrBuf_ServGetln(Buf);
-       }
-       FlushStrBuf(Buf);
-       StrBufAppendBufPlain(Buf, WC->ugname, -1, 0);
-       strcpy(WC->ugname, "");
-       smart_goto(Buf);
-       FreeStrBuf(&Buf);
-}
-
 typedef struct __room_states {
        char password[SIZ];
        char dirname[SIZ];
@@ -1202,7 +995,7 @@ void display_editroom(void)
 
        /* print the tabbed dialog */
        wprintf("<div align=\"center\">");
-       wprintf("<table id=\"AdminTabs\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\""
+       wprintf("<table id=\"AdminTabs\" border=\"0\" cellspacing=\"0\" cellpadding=\"0\">"
                "<tr align=\"center\" style=\"cursor:pointer\"><td>&nbsp;</td>"
                );
 
@@ -1212,7 +1005,7 @@ void display_editroom(void)
                wprintf(_("Administration"));
        }
        else {
-               wprintf("< tab_cell_edit\"><a href=\"display_editroom&tab=admin\">");
+               wprintf("< tab_cell_edit\"><a href=\"display_editroom?tab=admin\">");
                wprintf(_("Administration"));
                wprintf("</a>");
        }
@@ -1227,7 +1020,7 @@ void display_editroom(void)
                        wprintf(_("Configuration"));
                }
                else {
-                       wprintf(" tab_cell_edit\"><a href=\"display_editroom&tab=config\">");
+                       wprintf(" tab_cell_edit\"><a href=\"display_editroom?tab=config\">");
                        wprintf(_("Configuration"));
                        wprintf("</a>");
                }
@@ -1240,7 +1033,7 @@ void display_editroom(void)
                        wprintf(_("Message expire policy"));
                }
                else {
-                       wprintf(" tab_cell_edit\"><a href=\"display_editroom&tab=expire\">");
+                       wprintf(" tab_cell_edit\"><a href=\"display_editroom?tab=expire\">");
                        wprintf(_("Message expire policy"));
                        wprintf("</a>");
                }
@@ -1253,7 +1046,7 @@ void display_editroom(void)
                        wprintf(_("Access controls"));
                }
                else {
-                       wprintf(" tab_cell_edit\"><a href=\"display_editroom&tab=access\">");
+                       wprintf(" tab_cell_edit\"><a href=\"display_editroom?tab=access\">");
                        wprintf(_("Access controls"));
                        wprintf("</a>");
                }
@@ -1266,7 +1059,7 @@ void display_editroom(void)
                        wprintf(_("Sharing"));
                }
                else {
-                       wprintf(" tab_cell_edit\"><a href=\"display_editroom&tab=sharing\">");
+                       wprintf(" tab_cell_edit\"><a href=\"display_editroom?tab=sharing\">");
                        wprintf(_("Sharing"));
                        wprintf("</a>");
                }
@@ -1279,7 +1072,7 @@ void display_editroom(void)
                        wprintf(_("Mailing list service"));
                }
                else {
-                       wprintf("< tab_cell_edit\"><a href=\"display_editroom&tab=listserv\">");
+                       wprintf("< tab_cell_edit\"><a href=\"display_editroom?tab=listserv\">");
                        wprintf(_("Mailing list service"));
                        wprintf("</a>");
                }
@@ -1294,7 +1087,7 @@ void display_editroom(void)
                wprintf(_("Remote retrieval"));
        }
        else {
-               wprintf("< tab_cell_edit\"><a href=\"display_editroom&tab=feeds\">");
+               wprintf("< tab_cell_edit\"><a href=\"display_editroom?tab=feeds\">");
                wprintf(_("Remote retrieval"));
                wprintf("</a>");
        }
@@ -1321,7 +1114,9 @@ void display_editroom(void)
                wprintf("');\">\n");
                wprintf(_("Delete this room"));
                wprintf("</a>\n"
-                       "<li><a href=\"display_editroompic\">\n");
+                       "<li><a href=\"display_editroompic?which_room=");
+               urlescputs(ChrPtr(WC->wc_roomname));
+               wprintf("\">\n");
                wprintf(_("Set or change the icon for this room's banner"));
                wprintf("</a>\n"
                        "<li><a href=\"display_editinfo\">\n");
@@ -1744,7 +1539,7 @@ void display_editroom(void)
                                        extract_token(recp, buf, 1, '|', sizeof recp);
                        
                                        escputs(recp);
-                                       wprintf(" <a href=\"netedit&cmd=remove&tab=listserv&line=listrecp|");
+                                       wprintf(" <a href=\"netedit?cmd=remove&tab=listserv&line=listrecp|");
                                        urlescputs(recp);
                                        wprintf("\">");
                                        wprintf(_("(remove)"));
@@ -1774,7 +1569,7 @@ void display_editroom(void)
                                        extract_token(recp, buf, 1, '|', sizeof recp);
                        
                                        escputs(recp);
-                                       wprintf(" <a href=\"netedit&cmd=remove&tab=listserv&line="
+                                       wprintf(" <a href=\"netedit?cmd=remove&tab=listserv&line="
                                                "digestrecp|");
                                        urlescputs(recp);
                                        wprintf("\">");
@@ -1998,7 +1793,7 @@ void display_editroom(void)
                                        wprintf("<td>%ld</td>", extract_long(buf, 5));  /* Fetching interval */
                        
                                        wprintf("<td class=\"button_link\">");
-                                       wprintf(" <a href=\"netedit&cmd=remove&tab=feeds&line=pop3client|");
+                                       wprintf(" <a href=\"netedit?cmd=remove&tab=feeds&line=pop3client|");
                                        urlescputs(recp);
                                        wprintf("\">");
                                        wprintf(_("(remove)"));
@@ -2065,7 +1860,7 @@ void display_editroom(void)
                                        wprintf("</td>");
 
                                        wprintf("<td class=\"button_link\">");
-                                       wprintf(" <a href=\"netedit&cmd=remove&tab=feeds&line=rssclient|");
+                                       wprintf(" <a href=\"netedit?cmd=remove&tab=feeds&line=rssclient|");
                                        urlescputs(recp);
                                        wprintf("\">");
                                        wprintf(_("(remove)"));
@@ -3084,7 +2879,7 @@ void change_view(void) {
  * \param max_folders how many folders???
  * \param num_floors hom many floors???
  */
-void do_folder_view(struct folder *fold, int max_folders, int num_floors) {
+void do_folder_view(struct __ofolder *fold, int max_folders, int num_floors) {
        char buf[SIZ];
        int levels;
        int i;
@@ -3203,7 +2998,7 @@ void do_folder_view(struct folder *fold, int max_folders, int num_floors) {
  * \param max_folders how many folders???
  * \param num_floors hom many floors???
  */
-void do_rooms_view(struct folder *fold, int max_folders, int num_floors) {
+void do_rooms_view(struct __ofolder *fold, int max_folders, int num_floors) {
        char buf[256];
        char floor_name[256];
        char old_floor_name[256];
@@ -3324,7 +3119,7 @@ void set_floordiv_expanded(void) {
  * \param max_folders how many folders???
  * \param num_floors hom many floors???
  */
-void do_iconbar_view(struct folder *fold, int max_folders, int num_floors) {
+void do_iconbar_view(struct __ofolder *fold, int max_folders, int num_floors) {
        char buf[256];
        char floor_name[256];
        char old_floor_name[256];
@@ -3464,8 +3259,8 @@ void list_all_rooms_by_floor(const char *viewpref) {
        StrBuf *Buf;
        char buf[SIZ];
        int swap = 0;
-       struct folder *fold = NULL;
-       struct folder ftmp;
+       struct __ofolder *fold = NULL;
+       struct __ofolder ftmp;
        int max_folders = 0;
        int alloc_folders = 0;
        int *floor_mapping;
@@ -3493,8 +3288,8 @@ void list_all_rooms_by_floor(const char *viewpref) {
        /** Start with the mailboxes */
        max_folders = 1;
        alloc_folders = 1;
-       fold = malloc(sizeof(struct folder));
-       memset(fold, 0, sizeof(struct folder));
+       fold = malloc(sizeof(struct __ofolder));
+       memset(fold, 0, sizeof(struct __ofolder));
        strcpy(fold[0].name, "My folders");
        fold[0].is_mailbox = 1;
 
@@ -3505,9 +3300,9 @@ void list_all_rooms_by_floor(const char *viewpref) {
                        if (max_folders >= alloc_folders) {
                                alloc_folders = max_folders + 100;
                                fold = realloc(fold,
-                                              alloc_folders * sizeof(struct folder));
+                                              alloc_folders * sizeof(struct __ofolder));
                        }
-                       memset(&fold[max_folders], 0, sizeof(struct folder));
+                       memset(&fold[max_folders], 0, sizeof(struct __ofolder));
                        extract_token(fold[max_folders].name, buf, 1, '|', sizeof fold[max_folders].name);
                        extract_token(buf3, buf, 0, '|', SIZ);
                        fold[max_folders].floor = atol (buf3);
@@ -3533,9 +3328,9 @@ void list_all_rooms_by_floor(const char *viewpref) {
                        if (max_folders >= alloc_folders) {
                                alloc_folders = max_folders + 100;
                                fold = realloc(fold,
-                                              alloc_folders * sizeof(struct folder));
+                                              alloc_folders * sizeof(struct __ofolder));
                        }
-                       memset(&fold[max_folders], 0, sizeof(struct folder));
+                       memset(&fold[max_folders], 0, sizeof(struct __ofolder));
                        extract_token(fold[max_folders].room, buf, 0, '|', sizeof fold[max_folders].room);
                        ra_flags = extract_int(buf, 5);
                        flags = extract_int(buf, 1);
@@ -3572,7 +3367,7 @@ void list_all_rooms_by_floor(const char *viewpref) {
                {
                        if (fold[i].num_rooms == 0) {
                                for (j=i; j<max_folders; j++) {
-                                       memcpy(&fold[j], &fold[j+1], sizeof(struct folder));
+                                       memcpy(&fold[j], &fold[j+1], sizeof(struct __ofolder));
                                }
                                max_folders--;
                                num_floors--;
@@ -3597,11 +3392,11 @@ void list_all_rooms_by_floor(const char *viewpref) {
                                }
                        }
                        if (swap > 0) {
-                               memcpy(&ftmp, &fold[j], sizeof(struct folder));
+                               memcpy(&ftmp, &fold[j], sizeof(struct __ofolder));
                                memcpy(&fold[j], &fold[j+1],
-                                      sizeof(struct folder));
+                                      sizeof(struct __ofolder));
                                memcpy(&fold[j+1], &ftmp,
-                                      sizeof(struct folder));
+                                      sizeof(struct __ofolder));
                        }
                }
        }
@@ -3691,13 +3486,13 @@ void knrooms(void)
                "OnChange=\"location.href=roomlistomatic.newview.options"
                "[selectedIndex].value\">\n");
 
-       wprintf("<option %s value=\"knrooms&view=rooms\">"
+       wprintf("<option %s value=\"knrooms?view=rooms\">"
                "View as room list"
                "</option>\n",
                ( !strcasecmp(ChrPtr(ListView), "rooms") ? "SELECTED" : "" )
                );
 
-       wprintf("<option %s value=\"knrooms&view=folders\">"
+       wprintf("<option %s value=\"knrooms?view=folders\">"
                "View as folder list"
                "</option>\n",
                ( !strcasecmp(ChrPtr(ListView), "folders") ? "SELECTED" : "" )
@@ -3743,130 +3538,21 @@ void set_room_policy(void) {
        display_editroom();
 }
 
-HashList *GetFloorListHash(StrBuf *Target, WCTemplputParams *TP) {
-       /* todo: check context */
-       const char *Err;
-       StrBuf *Buf;
-       StrBuf *Buf2;
-       HashList *floors;
-       HashList *floor;
-       floors = NewHash(1, NULL);
-       Buf = NewStrBuf();
-       serv_puts("LFLR"); /* get floors */
-       StrBufTCP_read_line(Buf, &WC->serv_sock, 0, &Err); /* '100', we hope */
-       if (GetServerStatus(Buf, NULL) == 1) 
-               while(StrBufTCP_read_line(Buf, &WC->serv_sock, 0, &Err), strcmp(ChrPtr(Buf), "000")) {
-                       int a;
-                       const char *floorNum = NULL;
-                       floor = NewHash(1, NULL);
-                       for(a=0; a<FLOOR_PARAM_LEN; a++) {
-                               Buf2 = NewStrBuf();
-                               StrBufExtract_token(Buf2, Buf, a, '|');
-                               if (a==0) {
-                                       floorNum = ChrPtr(Buf2); /* hmm, should we copy Buf2 first? */
-                               }
-                               Put(floor, FPKEY(a), Buf2, NULL);
-                       }
-                       Put(floors, HKEY(floorNum), floor, NULL);
-               }
-       FreeStrBuf(&Buf);
-       return floors;
-}
-
-void tmplput_FLOOR_Value(StrBuf *TemplBuffer, WCTemplputParams *TP) 
-{
-       StrBuf *val;
-       HashList *floor = (HashList *)(TP->Context);
-       void *value;
-       GetHash(floor, TKEY(0), &value);
-       val = (StrBuf *)value;
-       StrECMAEscAppend(TemplBuffer, val, 0);
-}
-HashList *GetRoomListHashLKRA(StrBuf *Target, WCTemplputParams *TP) 
-{
-       serv_puts("LKRA");
-       return GetRoomListHash(Target, TP);
-}
-HashList *GetRoomListHash(StrBuf *Target, WCTemplputParams *TP) 
-{
-       /* TODO: Check context */
-       HashList *rooms;
-       HashList *room;
-       StrBuf *buf;
-       StrBuf *buf2;
-       const char *Err;
-       buf = NewStrBuf();
-       rooms = NewHash(1, NULL);
-       StrBufTCP_read_line(buf, &WC->serv_sock, 0, &Err);
-       if (GetServerStatus(Buf, NULL) == 1) 
-               while(StrBufTCP_read_line(buf, &WC->serv_sock, 0, &Err), strcmp(ChrPtr(buf), "000")) {
-                       int i;
-                       const char *rmName = NULL;
-                       room = NewHash(1, NULL);
-                       for(i=0; i<ROOM_PARAM_LEN; i++) {
-                               buf2 = NewStrBuf();
-                               StrBufExtract_token(buf2, buf, i, '|');
-                               if (i==0) {
-                                       rmName = ChrPtr(buf2);
-                               }
-                               Put(room, RPKEY(i), buf2, NULL);
-                       }
-                       Put(rooms, rmName, strlen(rmName), room, NULL);
-               }
-       SortByHashKey(rooms, 1);
-       /*SortByPayload(rooms, SortRoomsByListOrder);  */
-       FreeStrBuf(&buf);
-       return rooms;
-}
-/** Unused function that orders rooms by the listorder flag */
-int SortRoomsByListOrder(const void *room1, const void *room2) 
-{
-       int l1;
-       int l2;
-       HashList *r1 = (HashList *)GetSearchPayload(room1);
-       HashList *r2 = (HashList *)GetSearchPayload(room2);
-       StrBuf *listOrderBuf1;
-       StrBuf *listOrderBuf2;
-  
-       GetHash(r1, RPKEY(3), (void *)&listOrderBuf1);
-       GetHash(r2, RPKEY(3), (void *)&listOrderBuf2);
-       l1 = atoi(ChrPtr(listOrderBuf1));
-       l2 = atoi(ChrPtr(listOrderBuf2));
-       if (l1 < l2) return -1;
-       else if (l1 > l2) return +1;
-       else return 0;
-}
-void tmplput_ROOM_Value(StrBuf *TemplBuffer, WCTemplputParams *TP) 
-{
-       void *value;
-       StrBuf *val;
-       HashList *room = (HashList *)(TP->Context);
-
-       GetHash(room, TKEY(0), &value);
-       val = (StrBuf *)value;
-       StrECMAEscAppend(TemplBuffer, val, 0);
-}
-void jsonRoomFlr(void) 
-{
-       /* Send as our own (application/json) content type */
-       hprintf("HTTP/1.1 200 OK\r\n");
-       hprintf("Content-type: application/json; charset=utf-8\r\n");
-       hprintf("Server: %s / %s\r\n", PACKAGE_STRING, ChrPtr(WC->serv_info->serv_software));
-       hprintf("Connection: close\r\n");
-       hprintf("Pragma: no-cache\r\nCache-Control: no-store\r\nExpires:-1\r\n");
-       begin_burst();
-       DoTemplate(HKEY("json_roomflr"),NULL,&NoCtx);
-       end_burst(); 
-}
 void tmplput_RoomName(StrBuf *Target, WCTemplputParams *TP)
 {
        StrBufAppendTemplate(Target, TP, WC->wc_roomname, 0);
 }
 
-void _gotonext(void) { slrp_highest(); gotonext(); }
-void dotskip(void) {smart_goto(sbstr("room"));}
-void _display_private(void) { display_private("", 0); }
+
+void _display_private(void) {
+       display_private("", 0);
+}
+
 void dotgoto(void) {
+       if (!havebstr("room")) {
+               readloop(readnew);
+               return;
+       }
        if (WC->wc_view != VIEW_MAILBOX) {      /* dotgoto acts like dotskip when we're in a mailbox view */
                slrp_highest();
        }
@@ -4078,9 +3764,6 @@ InitModule_ROOMOPS
        RegisterNamespace("ROOMNAME", 0, 1, tmplput_RoomName, 0);
 
        WebcitAddUrlHandler(HKEY("knrooms"), knrooms, 0);
-       WebcitAddUrlHandler(HKEY("gotonext"), _gotonext, NEED_URL);
-       WebcitAddUrlHandler(HKEY("skip"), gotonext, NEED_URL);
-       WebcitAddUrlHandler(HKEY("ungoto"), ungoto, NEED_URL);
        WebcitAddUrlHandler(HKEY("dotgoto"), dotgoto, NEED_URL);
        WebcitAddUrlHandler(HKEY("dotskip"), dotskip, NEED_URL);
        WebcitAddUrlHandler(HKEY("display_private"), _display_private, 0);
@@ -4100,7 +3783,6 @@ InitModule_ROOMOPS
        WebcitAddUrlHandler(HKEY("set_floordiv_expanded"), set_floordiv_expanded, NEED_URL|AJAX);
        WebcitAddUrlHandler(HKEY("changeview"), change_view, 0);
        WebcitAddUrlHandler(HKEY("toggle_self_service"), toggle_self_service, 0);
-       WebcitAddUrlHandler(HKEY("json_roomflr"), jsonRoomFlr, 0);
        RegisterNamespace("ROOMBANNER", 0, 1, tmplput_roombanner, 0);
 
        RegisterConditional(HKEY("COND:ROOM:TYPE_IS"), 0, ConditionalIsRoomtype, CTX_NONE);
@@ -4124,13 +3806,11 @@ InitModule_ROOMOPS
        RegisterConditional(HKEY("COND:ROOM:EDITACCESS"), 0, ConditionalHaveRoomeditRights, CTX_NONE);
 
        RegisterNamespace("ROOM:UNGOTO", 0, 0, tmplput_ungoto, 0);
-       RegisterIterator("FLOORS", 0, NULL, GetFloorListHash, NULL, DeleteHash, CTX_FLOORS, CTX_NONE, IT_NOFLAG);
-       RegisterNamespace("FLOOR:INFO", 1, 2, tmplput_FLOOR_Value, CTX_FLOORS);
-       RegisterIterator("LKRA", 0, NULL, GetRoomListHashLKRA, NULL, NULL, CTX_ROOMS, CTX_NONE, IT_NOFLAG);
-       RegisterNamespace("ROOM:INFO", 1, 2, tmplput_ROOM_Value, CTX_ROOMS);
-}
+       RegisterIterator("FLOORS", 0, NULL, GetFloorListHash, NULL, NULL, CTX_FLOORS, CTX_NONE, IT_NOFLAG);
 
 
+}
+
 
 void 
 SessionDestroyModule_ROOMOPS
@@ -4141,5 +3821,6 @@ SessionDestroyModule_ROOMOPS
        }
        
        free_march_list(sess);
+       DeleteHash(&sess->Floors);
 }
 /*@}*/