SYSLOG: more places to correct the loglevel parameters.
[citadel.git] / webcit / webcit.c
index a42f5ae83031d38d564c3347ce2b0137d47d4a08..2ce94be12d1b7d3d78556c533071a9f80f2e1a98 100644 (file)
@@ -133,12 +133,7 @@ void wDumpContent(int print_standard_html_footer)
  */
 void output_headers(   int do_httpheaders,     /* 1 = output HTTP headers                        */
                        int do_htmlhead,        /* 1 = output HTML <head> section and <body> opener */
-
-                       int do_room_banner,     /* 0=no, 1=yes,                              
-                                                * 2 = I'm going to embed my own, so don't open the 
-                                                *     <div id="content"> either.                  
-                                                */
-
+                       int do_room_banner,     /* 1 = include the room banner and <div id="content"></div> */
                        int unset_cookies,      /* 1 = session is terminating, so unset the cookies */
                        int suppress_check,     /* 1 = suppress check for instant messages        */
                        int cache               /* 1 = allow browser to cache this page      */
@@ -192,12 +187,12 @@ void output_headers(      int do_httpheaders,     /* 1 = output HTTP headers                        */
                if ( (WCC->logged_in) && (!unset_cookies) ) {
                        DoTemplate(HKEY("paging"), NULL, &NoCtx);
                }
-               if (do_room_banner == 1) {
+               if (do_room_banner) {
                        tmplput_roombanner(NULL, NULL);
                }
        }
 
-       if (do_room_banner == 1) {
+       if (do_room_banner) {
                wc_printf("<div id=\"content\">\n");
        }
 }
@@ -229,12 +224,16 @@ void http_redirect(const char *whichpage) {
 
 
 /*
- * Output a piece of content to the web browser using conformant HTTP and MIME semantics
+ * Output a piece of content to the web browser using conformant HTTP and MIME semantics.
+ *
+ * If this function is called, it is expected that begin_burst() has already been called
+ * and some sort of content has been fed into the buffer.  This function will transmit a
+ * bunch of headers to the client.  end_burst() will add some headers of its own, and then
+ * transmit the buffered content to the client.
  */
 void http_transmit_thing(const char *content_type, int is_static)
 {
-
-       syslog(9, "http_transmit_thing(%s)%s", content_type, ((is_static > 0) ? " (static)" : ""));
+       syslog(LOG_DEBUG, "http_transmit_thing(%s)%s", content_type, ((is_static > 0) ? " (static)" : ""));
        output_headers(0, 0, 0, 0, 0, is_static);
 
        hprintf("Content-type: %s\r\n"
@@ -468,7 +467,7 @@ void push_destination(void) {
 
        FreeStrBuf(&WCC->PushedDestination);
        WCC->PushedDestination = NewStrBufDup(SBSTR("url"));
-       syslog(9, "Push: %s", ChrPtr(WCC->PushedDestination));
+       syslog(LOG_DEBUG, "Push: %s", ChrPtr(WCC->PushedDestination));
        wc_printf("OK");
 }
 
@@ -506,7 +505,7 @@ void pop_destination(void) {
        /*
         * All righty then!  We have a destination saved, so go there now.
         */
-       syslog(9, "Pop: %s", ChrPtr(WCC->PushedDestination));
+       syslog(LOG_DEBUG, "Pop: %s", ChrPtr(WCC->PushedDestination));
        http_redirect(ChrPtr(WCC->PushedDestination));
 }
 
@@ -626,11 +625,11 @@ void session_loop(void)
 
        /* If the client sent a nonce that is incorrect, kill the request. */
        if (havebstr("nonce")) {
-               syslog(9, "Comparing supplied nonce %s to session nonce %d", 
+               syslog(LOG_DEBUG, "Comparing supplied nonce %s to session nonce %d", 
                        bstr("nonce"), WCC->nonce
                );
                if (ibstr("nonce") != WCC->nonce) {
-                       syslog(9, "Ignoring request with mismatched nonce.");
+                       syslog(LOG_INFO, "Ignoring request with mismatched nonce.");
                        hprintf("HTTP/1.1 404 Security check failed\r\n");
                        hprintf("Content-Type: text/plain\r\n");
                        begin_burst();
@@ -706,18 +705,18 @@ void session_loop(void)
         */
        if (havebstr("go")) {
                int ret;
-               syslog(9, "Explicit room selection: %s", bstr("go"));
+               syslog(LOG_DEBUG, "Explicit room selection: %s", bstr("go"));
                ret = gotoroom(sbstr("go"));    /* do quietly to avoid session output! */
                if ((ret/100) != 2) {
-                       syslog(1, "Unable to change to [%s]; Reason: %d", bstr("go"), ret);
+                       syslog(LOG_DEBUG, "Unable to change to [%s]; Reason: %d", bstr("go"), ret);
                }
        }
        else if (havebstr("gotofirst")) {
                int ret;
-               syslog(9, "Explicit room selection: %s", bstr("gotofirst"));
+               syslog(LOG_DEBUG, "Explicit room selection: %s", bstr("gotofirst"));
                ret = gotoroom(sbstr("gotofirst"));     /* do quietly to avoid session output! */
                if ((ret/100) != 2) {
-                       syslog(1, "Unable to change to [%s]; Reason: %d", bstr("gotofirst"), ret);
+                       syslog(LOG_INFO, "Unable to change to [%s]; Reason: %d", bstr("gotofirst"), ret);
                }
        }
 
@@ -728,13 +727,13 @@ void session_loop(void)
        else if ( (StrLength(WCC->CurRoom.name) == 0) && ( (StrLength(WCC->Hdr->c_roomname) > 0) )) {
                int ret;
 
-               syslog(9, "We are in '%s' but cookie indicates '%s', going there...",
+               syslog(LOG_DEBUG, "We are in '%s' but cookie indicates '%s', going there...",
                        ChrPtr(WCC->CurRoom.name),
                        ChrPtr(WCC->Hdr->c_roomname)
                );
                ret = gotoroom(WCC->Hdr->c_roomname);   /* do quietly to avoid session output! */
                if ((ret/100) != 2) {
-                       syslog(1, "COOKIEGOTO: Unable to change to [%s]; Reason: %d",
+                       syslog(LOG_DEBUG, "COOKIEGOTO: Unable to change to [%s]; Reason: %d",
                                ChrPtr(WCC->Hdr->c_roomname), ret);
                }
        }
@@ -742,6 +741,7 @@ void session_loop(void)
        if (WCC->Hdr->HR.Handler != NULL) {
                if (    (!WCC->logged_in)
                        && ((WCC->Hdr->HR.Handler->Flags & ANONYMOUS) == 0)
+                       && (WCC->serv_info != NULL)
                        && (WCC->serv_info->serv_supports_guest == 0)
                ) {
                        display_login();
@@ -800,7 +800,7 @@ void display_default_landing_page(void) {
                /* default action */
 
                if (havebstr("go")) {
-                       syslog(9, "Explicit room selection: %s", bstr("go"));
+                       syslog(LOG_DEBUG, "Explicit room selection: %s", bstr("go"));
                        StrBuf *teh_room = NewStrBufPlain(bstr("go"), strlen(bstr("go")));
                        smart_goto(teh_room);
                        FreeStrBuf(&teh_room);
@@ -864,7 +864,6 @@ void tmplput_importantmessage(StrBuf *Target, WCTemplputParams *TP)
        if (WCC != NULL) {
                if (StrLength(WCC->ImportantMsg) > 0) {
                        StrEscAppend(Target, WCC->ImportantMsg, NULL, 0, 0);
-                       FlushStrBuf(WCC->ImportantMsg);
                }
        }
 }
@@ -907,9 +906,9 @@ InitModule_WEBCIT
        WebcitAddUrlHandler(HKEY("pop"), "", 0, pop_destination, 0);
 
        WebcitAddUrlHandler(HKEY("401"), "", 0, authorization_required, ANONYMOUS|COOKIEUNNEEDED);
-       RegisterConditional(HKEY("COND:IMPMSG"), 0, ConditionalImportantMesage, CTX_NONE);
-       RegisterConditional(HKEY("COND:REST:DEPTH"), 0, Conditional_REST_DEPTH, CTX_NONE);
-       RegisterConditional(HKEY("COND:IS_HTTPS"), 0, Conditional_IS_HTTPS, CTX_NONE);
+       RegisterConditional("COND:IMPMSG", 0, ConditionalImportantMesage, CTX_NONE);
+       RegisterConditional("COND:REST:DEPTH", 0, Conditional_REST_DEPTH, CTX_NONE);
+       RegisterConditional("COND:IS_HTTPS", 0, Conditional_IS_HTTPS, CTX_NONE);
 
        RegisterNamespace("CSSLOCAL", 0, 0, tmplput_csslocal, NULL, CTX_NONE);
        RegisterNamespace("IMPORTANTMESSAGE", 0, 0, tmplput_importantmessage, NULL, CTX_NONE);
@@ -920,11 +919,11 @@ InitModule_WEBCIT
        
        snprintf(dir, SIZ, "%s/webcit.css", static_local_dir);
        if (!access(dir, R_OK)) {
-               syslog(9, "Using local Stylesheet [%s]", dir);
+               syslog(LOG_INFO, "Using local Stylesheet [%s]", dir);
                csslocal = NewStrBufPlain(HKEY("<link href=\"static.local/webcit.css\" rel=\"stylesheet\" type=\"text/css\" />"));
        }
        else
-               syslog(9, "No Site-local Stylesheet [%s] installed.", dir);
+               syslog(LOG_INFO, "No Site-local Stylesheet [%s] installed.", dir);
 
 }
 
@@ -974,6 +973,10 @@ SessionDetachModule_WEBCIT
        else
                FlushStrBuf(sess->WBuf);
        FlushStrBuf(sess->HBuf);
+       if (StrLength(sess->ImportantMsg) > 0) {
+               FlushStrBuf(sess->ImportantMsg);
+       }
+
 }
 
 void