off-by-one fix in siteconfig
[citadel.git] / webcit / webcit.c
index ac44ac1fd35ac2ffbb73d42f9ff2fbe6eeeced6a..5642ee168a3d8bfa2d1860e7b5aeb6abbefaa230 100644 (file)
@@ -6,30 +6,28 @@
  * Copyright (c) 1996-2011 by the citadel.org team
  *
  * This program is open source software.  You can redistribute it and/or
- * modify it under the terms of the GNU General Public License as
- * published by the Free Software Foundation; either version 3 of the
- * License, or (at your option) any later version.
+ * modify it under the terms of the GNU General Public License, version 3.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
  */
 
 #define SHOW_ME_VAPPEND_PRINTF
 #include <stdio.h>
 #include <stdarg.h>
 #include "webcit.h"
-#include "groupdav.h"
+#include "dav.h"
 #include "webserver.h"
 
 StrBuf *csslocal = NULL;
 HashList *HandlerHash = NULL;
 
+void stuff_to_cookie(int unset_cookie);
+extern int GetConnected(void);
+
+
 void PutRequestLocalMem(void *Data, DeleteHashDataFunc DeleteIt)
 {
         wcsession *WCC = WC;
@@ -198,20 +196,7 @@ void output_headers(       int do_httpheaders,     /* 1 = output HTTP headers                        */
                do_template("head");
 
                /* check for ImportantMessages (these display in a div overlaying the main screen) */
-               if (!IsEmptyStr(WCC->ImportantMessage)) {
-                       wc_printf("<div id=\"important_message\">\n"
-                               "<span class=\"imsg\">");
-                       StrEscAppend(WCC->WBuf, NULL, WCC->ImportantMessage, 0, 0);
-                       wc_printf("</span><br>\n"
-                               "</div>\n"
-                       );
-                       StrBufAppendBufPlain(WCC->trailing_javascript,
-                                            HKEY("setTimeout('hide_imsg_popup()', 5000);       \n"), 
-                                            0
-                       );
-                       WCC->ImportantMessage[0] = 0;
-               }
-               else if (StrLength(WCC->ImportantMsg) > 0) {
+               if (StrLength(WCC->ImportantMsg) > 0) {
                        wc_printf("<div id=\"important_message\">\n"
                                "<span class=\"imsg\">");
                        StrEscAppend(WCC->WBuf, WCC->ImportantMsg, NULL, 0, 0);
@@ -254,6 +239,7 @@ void http_redirect(const char *whichpage) {
        hprintf("Location: %s\r\n", whichpage);
        hprintf("URI: %s\r\n", whichpage);
        hprintf("Content-type: text/html; charset=utf-8\r\n");
+       stuff_to_cookie(0);
        begin_burst();
        wc_printf("<html><body>");
        wc_printf("Go <a href=\"%s\">here</A>.", whichpage);
@@ -269,7 +255,7 @@ void http_redirect(const char *whichpage) {
 void http_transmit_thing(const char *content_type, int is_static)
 {
 
-       syslog(9, "http_transmit_thing(%s)%s\n", content_type, ((is_static > 0) ? " (static)" : ""));
+       syslog(9, "http_transmit_thing(%s)%s", content_type, ((is_static > 0) ? " (static)" : ""));
        output_headers(0, 0, 0, 0, 0, is_static);
 
        hprintf("Content-type: %s\r\n"
@@ -330,7 +316,7 @@ void url_do_template(void) {
 /*
  * convenience function to indicate success
  */
-void display_success(char *successmessage)
+void display_success(const char *successmessage)
 {
        convenience_page("007700", "OK", successmessage);
 }
@@ -356,19 +342,20 @@ void authorization_required(void)
        wc_printf("<h1>");
        wc_printf(_("Authorization Required"));
        wc_printf("</h1>\r\n");
-       
 
-       if (WCC->ImportantMsg != NULL)
+       if (WCC->ImportantMsg != NULL) {
                message = ChrPtr(WCC->ImportantMsg);
-       else if (WCC->ImportantMessage != NULL)
-               message = WCC->ImportantMessage;
+       }
 
-       wc_printf(_("The resource you requested requires a valid username and password. "
-               "You could not be logged in: %s\n"), message);
+       wc_printf(
+               _("The resource you requested requires a valid username and password. "
+               "You could not be logged in: %s\n"),
+               message
+       );
        wDumpContent(0);
-       end_webcit_session();
 }
 
+
 /*
  * Convenience functions to wrap around asynchronous ajax responses
  */
@@ -386,6 +373,7 @@ void begin_ajax_response(void) {
        begin_burst();
 }
 
+
 /*
  * print ajax response footer 
  */
@@ -394,7 +382,6 @@ void end_ajax_response(void) {
 }
 
 
-
 /*
  * Wraps a Citadel server command in an AJAX transaction.
  */
@@ -406,7 +393,7 @@ void ajax_servcmd(void)
        char *junk;
        size_t len;
 
-       syslog(LOG_DEBUG, "ajax_servcmd() g_cmd=\"%s\"\n", bstr("g_cmd") );
+       syslog(LOG_DEBUG, "ajax_servcmd() g_cmd=\"%s\"", bstr("g_cmd") );
        begin_ajax_response();
        Buf = NewStrBuf();
        serv_puts(bstr("g_cmd"));
@@ -456,7 +443,7 @@ void ajax_servcmd(void)
         * This is kind of an ugly hack, but this is the only place it can go.
         * If the command was GEXP, then the instant messenger window must be
         * running, so reset the "last_pager_check" watchdog timer so
-        * that page_popup() doesn't try to open it a second time.
+        * that page_popup() doesn't try to open it a second time. TODO: page_popup isn't with us anymore.
         */
        if (!strncasecmp(bstr("g_cmd"), "GEXP", 4)) {
                WCC->last_pager_check = time(NULL);
@@ -503,10 +490,11 @@ void push_destination(void) {
 
        FreeStrBuf(&WCC->PushedDestination);
        WCC->PushedDestination = NewStrBufDup(SBSTR("url"));
-       syslog(9, "Push: %s\n", ChrPtr(WCC->PushedDestination));
+       syslog(9, "Push: %s", ChrPtr(WCC->PushedDestination));
        wc_printf("OK");
 }
 
+
 /*
  * Go to the URL saved by push_destination()
  */
@@ -540,7 +528,7 @@ void pop_destination(void) {
        /*
         * All righty then!  We have a destination saved, so go there now.
         */
-       syslog(9, "Pop: %s\n", ChrPtr(WCC->PushedDestination));
+       syslog(9, "Pop: %s", ChrPtr(WCC->PushedDestination));
        http_redirect(ChrPtr(WCC->PushedDestination));
 }
 
@@ -596,48 +584,6 @@ int ReadPostData(void)
 }
 
 
-void ParseREST_URL(void)
-{
-       StrBuf *Buf;
-       StrBuf *pFloor = NULL;
-       wcsession *WCC = WC;
-       long i = 0;
-       const char *pCh = NULL;
-       HashList *Floors;
-       void *vFloor;
-
-       syslog(1, "parsing rest URL: %s\n", ChrPtr(WCC->Hdr->HR.ReqLine));
-
-       WCC->Directory = NewHash(1, Flathash);
-       WCC->CurrentFloor = NULL;
-
-       Buf = NewStrBuf();
-       while (StrBufExtract_NextToken(Buf, WCC->Hdr->HR.ReqLine, &pCh,  '/') >= 0)
-       {
-               if (StrLength(Buf) != 0) {
-                       /* ignore empty path segments */
-                       StrBufUnescape(Buf, 1);
-                       Put(WCC->Directory, IKEY(i), Buf, HFreeStrBuf);
-                       if (i==0)
-                               pFloor = Buf;
-                       Buf = NewStrBuf();
-               }
-               i++;
-       }
-
-       FreeStrBuf(&Buf);
-       if (pFloor != NULL)
-       {
-               Floors = GetFloorListHash(NULL, NULL);
-               
-               if (Floors != NULL)
-               {
-                       if (GetHash(WCC->FloorsByName, SKEY(pFloor), &vFloor))
-                               WCC->CurrentFloor = (Floor*) vFloor;
-               }
-       }
-}
-
 int Conditional_REST_DEPTH(StrBuf *Target, WCTemplputParams *TP)
 {
        long Depth, IsDepth;
@@ -665,7 +611,6 @@ int Conditional_REST_DEPTH(StrBuf *Target, WCTemplputParams *TP)
  */
 void session_loop(void)
 {
-       int Flags = 0;
        int xhttp;
        StrBuf *Buf;
        
@@ -679,8 +624,6 @@ void session_loop(void)
        WCC->upload_length = 0;
        WCC->upload = NULL;
        WCC->Hdr->nWildfireHeaders = 0;
-       if (WCC->Hdr->HR.Handler != NULL)
-               Flags = WCC->Hdr->HR.Handler->Flags; /* so we can temporarily add our own... */
 
        if (WCC->Hdr->HR.ContentLength > 0) {
                if (ReadPostData() < 0) {
@@ -705,11 +648,11 @@ void session_loop(void)
 
        /* If the client sent a nonce that is incorrect, kill the request. */
        if (havebstr("nonce")) {
-               syslog(9, "Comparing supplied nonce %s to session nonce %d\n", 
+               syslog(9, "Comparing supplied nonce %s to session nonce %d", 
                        bstr("nonce"), WCC->nonce
                );
                if (ibstr("nonce") != WCC->nonce) {
-                       syslog(9, "Ignoring request with mismatched nonce.\n");
+                       syslog(9, "Ignoring request with mismatched nonce.");
                        hprintf("HTTP/1.1 404 Security check failed\r\n");
                        hprintf("Content-Type: text/plain\r\n");
                        begin_burst();
@@ -747,10 +690,10 @@ void session_loop(void)
         * If we're not logged in, but we have authentication data (either from
         * a cookie or from http-auth), try logging in to Citadel using that.
         */
-       if ((!WCC->logged_in)
-           && (StrLength(WCC->Hdr->c_username) > 0)
-           && (StrLength(WCC->Hdr->c_password) > 0))
-       {
+       if (    (!WCC->logged_in)
+               && (StrLength(WCC->Hdr->c_username) > 0)
+               && (StrLength(WCC->Hdr->c_password) > 0)
+       {
                long Status;
 
                FlushStrBuf(Buf);
@@ -785,18 +728,18 @@ void session_loop(void)
         */
        if (havebstr("go")) {
                int ret;
-               syslog(9, "Explicit room selection: %s\n", bstr("go"));
+               syslog(9, "Explicit room selection: %s", bstr("go"));
                ret = gotoroom(sbstr("go"));    /* do quietly to avoid session output! */
                if ((ret/100) != 2) {
-                       syslog(1, "Unable to change to [%s]; Reason: %d\n", bstr("go"), ret);
+                       syslog(1, "Unable to change to [%s]; Reason: %d", bstr("go"), ret);
                }
        }
        else if (havebstr("gotofirst")) {
                int ret;
-               syslog(9, "Explicit room selection: %s\n", bstr("gotofirst"));
+               syslog(9, "Explicit room selection: %s", bstr("gotofirst"));
                ret = gotoroom(sbstr("gotofirst"));     /* do quietly to avoid session output! */
                if ((ret/100) != 2) {
-                       syslog(1, "Unable to change to [%s]; Reason: %d\n", bstr("gotofirst"), ret);
+                       syslog(1, "Unable to change to [%s]; Reason: %d", bstr("gotofirst"), ret);
                }
        }
 
@@ -807,13 +750,13 @@ void session_loop(void)
        else if ( (StrLength(WCC->CurRoom.name) == 0) && ( (StrLength(WCC->Hdr->c_roomname) > 0) )) {
                int ret;
 
-               syslog(9, "We are in '%s' but cookie indicates '%s', going there...\n",
+               syslog(9, "We are in '%s' but cookie indicates '%s', going there...",
                        ChrPtr(WCC->CurRoom.name),
                        ChrPtr(WCC->Hdr->c_roomname)
                );
                ret = gotoroom(WCC->Hdr->c_roomname);   /* do quietly to avoid session output! */
                if ((ret/100) != 2) {
-                       syslog(1, "COOKIEGOTO: Unable to change to [%s]; Reason: %d\n",
+                       syslog(1, "COOKIEGOTO: Unable to change to [%s]; Reason: %d",
                                ChrPtr(WCC->Hdr->c_roomname), ret);
                }
        }
@@ -826,15 +769,13 @@ void session_loop(void)
                        display_login();
                }
                else {
-/*
-                       if ((WCC->Hdr->HR.Handler->Flags & PARSE_REST_URL) != 0)
-                               ParseREST_URL();
-*/
-                       if ((WCC->Hdr->HR.Handler->Flags & AJAX) != 0)
+                       if ((WCC->Hdr->HR.Handler->Flags & AJAX) != 0) {
                                begin_ajax_response();
+                       }
                        WCC->Hdr->HR.Handler->F();
-                       if ((WCC->Hdr->HR.Handler->Flags & AJAX) != 0)
+                       if ((WCC->Hdr->HR.Handler->Flags & AJAX) != 0) {
                                end_ajax_response();
+                       }
                }
        }
        /* When all else fails, display the default landing page or a main menu. */
@@ -855,10 +796,12 @@ void session_loop(void)
                 * Toplevel dav requests? or just a flat browser request? 
                 */
                else {
-                       if (xhttp)
-                               groupdav_main();
-                       else
+                       if (xhttp) {
+                               dav_main();
+                       }
+                       else {
                                display_main_menu();
+                       }
                }
        }
 
@@ -925,8 +868,7 @@ int ConditionalImportantMesage(StrBuf *Target, WCTemplputParams *TP)
 {
        wcsession *WCC = WC;
        if (WCC != NULL)
-               return ((!IsEmptyStr(WCC->ImportantMessage)) || 
-                       (StrLength(WCC->ImportantMsg) > 0));
+               return (StrLength(WCC->ImportantMsg) > 0);
        else
                return 0;
 }
@@ -936,11 +878,7 @@ void tmplput_importantmessage(StrBuf *Target, WCTemplputParams *TP)
        wcsession *WCC = WC;
        
        if (WCC != NULL) {
-               if (!IsEmptyStr(WCC->ImportantMessage)) {
-                       StrEscAppend(Target, NULL, WCC->ImportantMessage, 0, 0);
-                       WCC->ImportantMessage[0] = '\0';
-               }
-               else if (StrLength(WCC->ImportantMsg) > 0) {
+               if (StrLength(WCC->ImportantMsg) > 0) {
                        StrEscAppend(Target, WCC->ImportantMsg, NULL, 0, 0);
                        FlushStrBuf(WCC->ImportantMsg);
                }
@@ -997,11 +935,11 @@ InitModule_WEBCIT
        
        snprintf(dir, SIZ, "%s/webcit.css", static_local_dir);
        if (!access(dir, R_OK)) {
-               syslog(9, "Using local Stylesheet [%s]\n", dir);
+               syslog(9, "Using local Stylesheet [%s]", dir);
                csslocal = NewStrBufPlain(HKEY("<link href=\"static.local/webcit.css\" rel=\"stylesheet\" type=\"text/css\" />"));
        }
        else
-               syslog(9, "No Site-local Stylesheet [%s] installed. \n", dir);
+               syslog(9, "No Site-local Stylesheet [%s] installed.", dir);
 
 }