citadel.git
13 years agoFixed incorrect byte count when writing XML entity references
Art Cancro [Wed, 23 Feb 2011 16:41:12 +0000 (11:41 -0500)]
Fixed incorrect byte count when writing XML entity references

13 years agoSanitize v_seen and v_answered during export
Art Cancro [Tue, 22 Feb 2011 22:43:11 +0000 (17:43 -0500)]
Sanitize v_seen and v_answered during export

13 years agoEscape single and double quotes in export format
Art Cancro [Tue, 22 Feb 2011 21:06:36 +0000 (16:06 -0500)]
Escape single and double quotes in export format

13 years agoExport messages in numerical order
Art Cancro [Tue, 22 Feb 2011 16:38:25 +0000 (11:38 -0500)]
Export messages in numerical order

13 years agofixing html2ascii
Wilfried Goesgens [Mon, 21 Feb 2011 22:13:33 +0000 (23:13 +0100)]
fixing html2ascii

  - add possibility to scan 4 digit entities
  - don't scan over the end
  - add tests

13 years agoClicking on the room name in the banner goes to the top level
Art Cancro [Wed, 16 Feb 2011 17:57:56 +0000 (12:57 -0500)]
Clicking on the room name in the banner goes to the top level

13 years agoFixed a backwards conditional in the openid_manual_create template.
Art Cancro [Tue, 15 Feb 2011 03:53:06 +0000 (22:53 -0500)]
Fixed a backwards conditional in the openid_manual_create template.

13 years agocosmetic stuff
Art Cancro [Mon, 14 Feb 2011 18:34:35 +0000 (13:34 -0500)]
cosmetic stuff

13 years agoOpenID manual create is now functionally complete.
Art Cancro [Mon, 14 Feb 2011 18:17:36 +0000 (13:17 -0500)]
OpenID manual create is now functionally complete.
Just a few minor cosmetic things to take care of now.

13 years agoFinished everything except the openid_manual_create code path
Art Cancro [Mon, 14 Feb 2011 17:18:50 +0000 (12:18 -0500)]
Finished everything except the openid_manual_create code path

13 years agoBegin working on OpenID manual screen name selection mode
Art Cancro [Mon, 14 Feb 2011 17:03:16 +0000 (12:03 -0500)]
Begin working on OpenID manual screen name selection mode

13 years agoOnly offer XMPP over TLS if we have OpenSSL in the build.
Art Cancro [Mon, 14 Feb 2011 03:46:09 +0000 (22:46 -0500)]
Only offer XMPP over TLS if we have OpenSSL in the build.

13 years agoEnable XMPP over TLS.
Art Cancro [Mon, 14 Feb 2011 03:41:08 +0000 (22:41 -0500)]
Enable XMPP over TLS.
I don't know why this works now when it didn't work before.
Perhaps we fixed something in the I/O layer recently.

13 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sun, 6 Feb 2011 19:24:42 +0000 (20:24 +0100)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

13 years agoBUGFIX: json-escape roomname during outputting message list
Wilfried Goesgens [Sun, 6 Feb 2011 19:24:12 +0000 (20:24 +0100)]
BUGFIX: json-escape roomname during outputting message list

13 years agoRestored the ability to associate an OpenID with an existing account.
Art Cancro [Tue, 1 Feb 2011 04:45:50 +0000 (23:45 -0500)]
Restored the ability to associate an OpenID with an existing account.

13 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Mon, 31 Jan 2011 03:26:01 +0000 (22:26 -0500)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

13 years agoRSS: wrong pointer indirection *gna*
Wilfried Goesgens [Sun, 30 Jan 2011 21:29:30 +0000 (22:29 +0100)]
RSS: wrong pointer indirection *gna*

13 years agoRSS-Client: more leaks.
Wilfried Goesgens [Sun, 30 Jan 2011 21:24:38 +0000 (22:24 +0100)]
RSS-Client: more leaks.

  - in case of abort we would loose the reply bod

13 years agoRSS-Client: fix memory leaks
Wilfried Goesgens [Sun, 30 Jan 2011 21:20:33 +0000 (22:20 +0100)]
RSS-Client: fix memory leaks

13 years agoWhen registering a new user during an inline login, preserve the room we started...
Art Cancro [Sun, 30 Jan 2011 19:17:23 +0000 (14:17 -0500)]
When registering a new user during an inline login, preserve the room we started from.
This commit was brought to you from the front seat of my car.  I have some time to kill and I've got
my netbook tethered to my awesome Android phone hooked up to the T-Mobile network.  I'm not some
snobby metropolitan self-importanterati with an iPhone.  Android is where it's at, and where it
will continue to be.

13 years agoQP-Decoding: Ignore case of letter indicating _B_inary or _Q_uoted printeable, there...
Wilfried Goesgens [Sun, 30 Jan 2011 12:14:05 +0000 (13:14 +0100)]
QP-Decoding: Ignore case of letter indicating _B_inary or _Q_uoted printeable, there seem to be solutions around sending q,b instead of Q,B

13 years agoBy jimcuclamath: set maxium allowed password length to the length of the buffer we...
Wilfried Goesgens [Sun, 30 Jan 2011 10:00:47 +0000 (11:00 +0100)]
By jimcuclamath: set maxium allowed password length to the length of the buffer we read into.

13 years agoSend the correct data to become_logged_in() during self service user creation.
Art Cancro [Sat, 29 Jan 2011 20:47:31 +0000 (15:47 -0500)]
Send the correct data to become_logged_in() during self service user creation.
We needed to send it the output of NEWU, not the output of SETP.

13 years agoBegin working new user registration into the login dialog
Art Cancro [Fri, 28 Jan 2011 21:02:25 +0000 (16:02 -0500)]
Begin working new user registration into the login dialog

13 years agominor comments cleanup
Art Cancro [Fri, 28 Jan 2011 18:58:34 +0000 (13:58 -0500)]
minor comments cleanup

13 years agoChanged the 'if you are a new user' message and also updated it in the .po files
Art Cancro [Fri, 28 Jan 2011 18:45:55 +0000 (13:45 -0500)]
Changed the 'if you are a new user' message and also updated it in the .po files

13 years agoInitial version of 'register new user' dialog
Art Cancro [Fri, 28 Jan 2011 17:54:27 +0000 (12:54 -0500)]
Initial version of 'register new user' dialog

13 years agoInitial version of 'register new user' dialog
Art Cancro [Fri, 28 Jan 2011 17:50:55 +0000 (12:50 -0500)]
Initial version of 'register new user' dialog

13 years agoReplace the temporary log message with a permanent one
Art Cancro [Fri, 28 Jan 2011 17:13:58 +0000 (12:13 -0500)]
Replace the temporary log message with a permanent one

13 years agoOk this is it, the best of both worlds.
Art Cancro [Fri, 28 Jan 2011 17:07:34 +0000 (12:07 -0500)]
Ok this is it, the best of both worlds.
1. Go back to the 'cache the most recent msglist' and 'binary-search that list' method.
2. Make ONE attempt to reload the msglist if a search fails.

13 years agoRevert "Updating cmd_euid() to use the CtdlForEachMessage() API fixes the security...
Art Cancro [Fri, 28 Jan 2011 16:53:47 +0000 (11:53 -0500)]
Revert "Updating cmd_euid() to use the CtdlForEachMessage() API fixes the security check in blog view and saves some code"

This reverts commit 4ec6a9dae3de0cf26e3c52d1ba65a1f57038b7a7.

13 years agoRevert "Replaced cached_msglist array with a btree persistent through the session."
Art Cancro [Fri, 28 Jan 2011 16:53:41 +0000 (11:53 -0500)]
Revert "Replaced cached_msglist array with a btree persistent through the session."

This reverts commit e432540ab02282396bf87eafde6a1698819912ff.

13 years agoRevert "arrgh"
Art Cancro [Fri, 28 Jan 2011 16:53:35 +0000 (11:53 -0500)]
Revert "arrgh"

This reverts commit 590b3ab0deab5fbb58b56d7f3fcad75bafc9e9e1.

13 years agoRevert "xxx"
Art Cancro [Fri, 28 Jan 2011 16:53:26 +0000 (11:53 -0500)]
Revert "xxx"

This reverts commit 88def48c67c3a034b33d9550bf70afa5c4705039.

13 years agoxxx
Art Cancro [Fri, 28 Jan 2011 16:51:36 +0000 (11:51 -0500)]
xxx

13 years agoarrgh
Art Cancro [Fri, 28 Jan 2011 16:49:53 +0000 (11:49 -0500)]
arrgh

13 years agoReplaced cached_msglist array with a btree persistent through the session.
Art Cancro [Thu, 27 Jan 2011 23:11:22 +0000 (18:11 -0500)]
Replaced cached_msglist array with a btree persistent through the session.

13 years agoUpdating cmd_euid() to use the CtdlForEachMessage() API fixes the security check...
Art Cancro [Thu, 27 Jan 2011 03:59:23 +0000 (22:59 -0500)]
Updating cmd_euid() to use the CtdlForEachMessage() API fixes the security check in blog view and saves some code

13 years agoUse a binary search to locate msgnum in cached_msglist
Art Cancro [Thu, 27 Jan 2011 03:36:48 +0000 (22:36 -0500)]
Use a binary search to locate msgnum in cached_msglist

13 years agoDisplay PASS/FAIL syslog msgs for the new security check.
Art Cancro [Thu, 27 Jan 2011 02:38:21 +0000 (21:38 -0500)]
Display PASS/FAIL syslog msgs for the new security check.
This determines whether a requested message actually exists in the current room,
preventing unauthorized msgnum sweeps.  We do not actually fail the message yet; I
will add that when the security check yields no false positives.

13 years agoDisplay PASS/FAIL syslog msgs for the new security check.
Art Cancro [Thu, 27 Jan 2011 02:36:19 +0000 (21:36 -0500)]
Display PASS/FAIL syslog msgs for the new security check.
This determines whether a requested message actually exists in the current room,
preventing unauthorized msgnum sweeps.  We do not actually fail the message yet; I
will add that when the security check yields no false positives.

13 years agoCache the most recently fetched msglist in CtdlForEachMessage()
Art Cancro [Wed, 26 Jan 2011 23:08:16 +0000 (18:08 -0500)]
Cache the most recently fetched msglist in CtdlForEachMessage()
(This will be used for a security check in an upcoming commit)

13 years agoRemoved nonce/apop/pas2, no longer used by anyone
Art Cancro [Wed, 26 Jan 2011 22:18:31 +0000 (17:18 -0500)]
Removed nonce/apop/pas2, no longer used by anyone

13 years agoRemoved the MESSAGE_IN_ROOM sections in order to make way for a faster algorithm.
Art Cancro [Wed, 26 Jan 2011 21:18:22 +0000 (16:18 -0500)]
Removed the MESSAGE_IN_ROOM sections in order to make way for a faster algorithm.

13 years agoLink to http://www.citadel.org/doku.php/faq:generalquestions:webcit_unable_to_connect...
Art Cancro [Tue, 25 Jan 2011 21:46:37 +0000 (16:46 -0500)]
Link to citadel.org/doku.php/faq:generalquestions:webcit_unable_to_connect instead

13 years agoReinstate the 'read more...' link when issuing a 503
Art Cancro [Tue, 25 Jan 2011 21:30:52 +0000 (16:30 -0500)]
Reinstate the 'read more...' link when issuing a 503

13 years agoLocalized the string 'New user? Register now' using Google Translate
Art Cancro [Tue, 25 Jan 2011 19:27:50 +0000 (14:27 -0500)]
Localized the string 'New user?  Register now' using Google Translate

13 years agoINFO command 'openid support' is now indicated as the version of OpenID support ...
Art Cancro [Tue, 25 Jan 2011 16:40:35 +0000 (11:40 -0500)]
INFO command 'openid support' is now indicated as the version of OpenID support (currently 1) instead of a boolean.

13 years agomore login box cleanup
Art Cancro [Tue, 25 Jan 2011 04:46:34 +0000 (23:46 -0500)]
more login box cleanup

13 years agoCleaned up the login modal a bit
Art Cancro [Tue, 25 Jan 2011 04:29:27 +0000 (23:29 -0500)]
Cleaned up the login modal a bit

13 years agoCOND:AIDE now observes logged in semantics
Art Cancro [Tue, 25 Jan 2011 03:30:57 +0000 (22:30 -0500)]
COND:AIDE now observes logged in semantics

13 years agoDisabled the old login screen.
Art Cancro [Tue, 25 Jan 2011 03:18:59 +0000 (22:18 -0500)]
Disabled the old login screen.
Some of this code will be re-used for registration and language selection.

13 years agoOnly offer OpenID login if the citadel server supports it
Art Cancro [Tue, 25 Jan 2011 02:53:30 +0000 (21:53 -0500)]
Only offer OpenID login if the citadel server supports it

13 years agoauthpopup now returns the parent to the pushed_destination
Art Cancro [Mon, 24 Jan 2011 21:02:39 +0000 (16:02 -0500)]
authpopup now returns the parent to the pushed_destination

13 years agologin popout is working, along with non edge case openID login
Art Cancro [Mon, 24 Jan 2011 20:47:23 +0000 (15:47 -0500)]
login popout is working, along with non edge case openID login

13 years agoBegan implementation of authpopout
Art Cancro [Mon, 24 Jan 2011 18:38:29 +0000 (13:38 -0500)]
Began implementation of authpopout

13 years agoThe 'Delete' button in mailbox view went missing at some point; replaced it.
Art Cancro [Thu, 20 Jan 2011 04:10:54 +0000 (23:10 -0500)]
The 'Delete' button in mailbox view went missing at some point; replaced it.

13 years ago'Read all messages' button does not belong in the mailbox view. Remove it.
Art Cancro [Thu, 20 Jan 2011 04:04:56 +0000 (23:04 -0500)]
'Read all messages' button does not belong in the mailbox view.  Remove it.

13 years agoDisallow certain pages in robots.txt which would mislead crawlers.
Art Cancro [Thu, 20 Jan 2011 03:37:30 +0000 (22:37 -0500)]
Disallow certain pages in robots.txt which would mislead crawlers.
/printmsg
/msgheaders
/groupdav
/do_template
/static

13 years agoPrototype 1.7 seems to need ajax parameters wrapped with encodeURI()
Art Cancro [Wed, 19 Jan 2011 20:03:49 +0000 (15:03 -0500)]
Prototype 1.7 seems to need ajax parameters wrapped with encodeURI()
This fixes the broken mailbox view

13 years agoajax_servcmd() logging now displays the g_cmd being attempted.
Art Cancro [Wed, 19 Jan 2011 16:32:02 +0000 (11:32 -0500)]
ajax_servcmd() logging now displays the g_cmd being attempted.
This is in an attempt to debug the b0rken message delete in the mailbox view.
Also fixed a format string compiler warning.

13 years agoEnter/return key submits form in the new user/password dialog
Art Cancro [Tue, 18 Jan 2011 22:18:14 +0000 (17:18 -0500)]
Enter/return key submits form in the new user/password dialog

13 years agoCtdlUserLogout() fixed to more throroughly log the user out
Art Cancro [Tue, 18 Jan 2011 18:25:28 +0000 (13:25 -0500)]
CtdlUserLogout() fixed to more throroughly log the user out

13 years agoFixed bugs related to last three commits
Art Cancro [Mon, 17 Jan 2011 17:48:20 +0000 (12:48 -0500)]
Fixed bugs related to last three commits

13 years agoRemoved logging stuff from libcitadel
Art Cancro [Mon, 17 Jan 2011 17:42:11 +0000 (12:42 -0500)]
Removed logging stuff from libcitadel

13 years agoRemoved the logging facility from citserver, use syslog instead
Art Cancro [Mon, 17 Jan 2011 17:39:59 +0000 (12:39 -0500)]
Removed the logging facility from citserver, use syslog instead

13 years agoRemoved logging subsystem from webcit. It's all syslog now.
Art Cancro [Mon, 17 Jan 2011 17:00:36 +0000 (12:00 -0500)]
Removed logging subsystem from webcit.  It's all syslog now.

13 years agouse the gnu format string checker for CtdlLogPrintf; fix associated new warnings...
Wilfried Goesgens [Sat, 15 Jan 2011 17:47:03 +0000 (18:47 +0100)]
use the gnu format string checker for CtdlLogPrintf; fix associated new warnings / problems.

13 years agoMimeparser rewrite; fix bug detecting trailing MIME-Boundary
Wilfried Goesgens [Sat, 15 Jan 2011 15:14:16 +0000 (16:14 +0100)]
Mimeparser rewrite; fix bug detecting trailing MIME-Boundary

  - when searching for the '--' after the mime boundary to detect whether its the last, we had an off by one. fixed.

13 years agoHost header is now stored per-request instead of globally.
Art Cancro [Sat, 15 Jan 2011 04:01:04 +0000 (23:01 -0500)]
Host header is now stored per-request instead of globally.
This will allow sitemaps generated by hosts with multiple names
to be referenced correctly.

13 years agoRemoved some old TECH_PREVIEW sections.
Art Cancro [Thu, 13 Jan 2011 19:20:28 +0000 (14:20 -0500)]
Removed some old TECH_PREVIEW sections.
We no longer use TECH_PREVIEW because of the split master/stable repos.

13 years agoBugfixing / debugging in templating
Wilfried Goesgens [Tue, 11 Jan 2011 22:23:18 +0000 (23:23 +0100)]
Bugfixing / debugging in templating

  - fix crash; check for non-parseable tokens so we don't struggle over NULL-Pointers later on.
  - -T6 now barfs the results of conditionals.

13 years agoRemove invalid "subtoken"; we don't support this, and this special token doesn't...
Wilfried Goesgens [Tue, 11 Jan 2011 22:21:05 +0000 (23:21 +0100)]
Remove invalid "subtoken"; we don't support this, and this special token doesn't even evaluate this parameter.

13 years agoFix Room-edit-Template; thanks to Sam for reporting.
Wilfried Goesgens [Tue, 11 Jan 2011 22:17:49 +0000 (23:17 +0100)]
Fix Room-edit-Template; thanks to Sam for reporting.

  - the original code used inverse logic for this checkbox case, the template didn't reflect this.

13 years agoPreparing to get openid support into the modal dialog
Art Cancro [Tue, 11 Jan 2011 21:06:26 +0000 (16:06 -0500)]
Preparing to get openid support into the modal dialog

13 years agoMerge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Tue, 11 Jan 2011 20:52:51 +0000 (15:52 -0500)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel

13 years ago'go' and 'gotofirst' are both accepted
Art Cancro [Tue, 11 Jan 2011 20:00:21 +0000 (15:00 -0500)]
'go' and 'gotofirst' are both accepted

13 years agoMobile template removal
Wilfried Goesgens [Tue, 11 Jan 2011 18:56:18 +0000 (19:56 +0100)]
Mobile template removal

  - remove support for the .m.* template series from the cache.

13 years agoYou must be logged in to access this page.
Art Cancro [Tue, 11 Jan 2011 17:12:36 +0000 (12:12 -0500)]
You must be logged in to access this page.

13 years agoRemoved parts of OpenID from the traditional login screen
Art Cancro [Tue, 11 Jan 2011 16:56:28 +0000 (11:56 -0500)]
Removed parts of OpenID from the traditional login screen

13 years agoGot rid of all of the .m.html templates and is_mobile cruft
Art Cancro [Tue, 11 Jan 2011 16:47:30 +0000 (11:47 -0500)]
Got rid of all of the .m.html templates and is_mobile cruft

13 years agoFor closed systems, still handle login through the modal
Art Cancro [Tue, 11 Jan 2011 16:42:01 +0000 (11:42 -0500)]
For closed systems, still handle login through the modal

13 years agoExpose wiki pages to the site map
Art Cancro [Tue, 11 Jan 2011 04:59:15 +0000 (23:59 -0500)]
Expose wiki pages to the site map

13 years agoRequire logged-in in order to revert a wiki page
Art Cancro [Tue, 11 Jan 2011 04:41:27 +0000 (23:41 -0500)]
Require logged-in in order to revert a wiki page

13 years agocmd_euid now ac_logged_in_or_guest in order to make guest wiki work
Art Cancro [Tue, 11 Jan 2011 04:23:13 +0000 (23:23 -0500)]
cmd_euid now ac_logged_in_or_guest in order to make guest wiki work

13 years agoWrap the 'Edit this wiki page' link in GetLoggedInFirst()
Art Cancro [Tue, 11 Jan 2011 04:09:32 +0000 (23:09 -0500)]
Wrap the 'Edit this wiki page' link in GetLoggedInFirst()

13 years agoOops, we're in a new year; update the copyright date in serv_wiki.c
Art Cancro [Tue, 11 Jan 2011 04:00:39 +0000 (23:00 -0500)]
Oops, we're in a new year; update the copyright date in serv_wiki.c

13 years agoWiki revs now work again - replaced --global-reject-file with -r
Art Cancro [Tue, 11 Jan 2011 03:57:49 +0000 (22:57 -0500)]
Wiki revs now work again - replaced --global-reject-file with -r

13 years agoWhen we 503, do it in HTML
Art Cancro [Tue, 11 Jan 2011 03:53:12 +0000 (22:53 -0500)]
When we 503, do it in HTML

13 years agoFixed bug in ConditionalHavewikiType() which returned the wrong value
Art Cancro [Mon, 10 Jan 2011 21:11:18 +0000 (16:11 -0500)]
Fixed bug in ConditionalHavewikiType() which returned the wrong value

13 years agoFixed several errors introduced during templatization of the Wiki engine.
Art Cancro [Mon, 10 Jan 2011 04:48:45 +0000 (23:48 -0500)]
Fixed several errors introduced during templatization of the Wiki engine.
* the 'home' conditional was reversed
* the 'Edit this page' link should always appear

13 years agoForce wiki room views into the wiki viewer instead of a read loop
Art Cancro [Mon, 10 Jan 2011 04:17:51 +0000 (23:17 -0500)]
Force wiki room views into the wiki viewer instead of a read loop

13 years agofix parameter order of memset as reported by Silvio Cesare in debian Bug#609384
Wilfried Goesgens [Sun, 9 Jan 2011 10:09:04 +0000 (11:09 +0100)]
fix parameter order of memset as reported by Silvio Cesare in debian Bug#609384

13 years agominor cleanup
Art Cancro [Fri, 7 Jan 2011 20:56:25 +0000 (15:56 -0500)]
minor cleanup

13 years agoMade the elimination of nocookies permanent.
Art Cancro [Fri, 7 Jan 2011 20:51:04 +0000 (15:51 -0500)]
Made the elimination of nocookies permanent.

13 years agomore logging for previous commit
Art Cancro [Fri, 7 Jan 2011 19:40:21 +0000 (14:40 -0500)]
more logging for previous commit

13 years agoThe 'gotofirst' key is now called 'go' for brevity
Art Cancro [Fri, 7 Jan 2011 19:34:43 +0000 (14:34 -0500)]
The 'gotofirst' key is now called 'go' for brevity

13 years agoThe 'nocookies' error page is no longer needed
Art Cancro [Fri, 7 Jan 2011 17:13:49 +0000 (12:13 -0500)]
The 'nocookies' error page is no longer needed

13 years agopush/pop destination_url instead of passing it through the chain
Art Cancro [Wed, 5 Jan 2011 21:18:18 +0000 (16:18 -0500)]
push/pop destination_url instead of passing it through the chain