citadel.git
14 months agoMoved from citadel.h to server.h
Art Cancro [Sat, 11 Feb 2023 23:41:55 +0000 (18:41 -0500)]
Moved  from citadel.h to server.h

14 months agoRemoved references to as opposed to
Art Cancro [Sat, 11 Feb 2023 23:31:06 +0000 (18:31 -0500)]
Removed references to  as opposed to

14 months agoRemoved references to as opposed to
Art Cancro [Sat, 11 Feb 2023 23:30:23 +0000 (18:30 -0500)]
Removed references to  as opposed to

14 months agomoved from citadel.h to server.h
Art Cancro [Sat, 11 Feb 2023 23:29:06 +0000 (18:29 -0500)]
moved  from citadel.h to server.h

14 months agoserver/control.c : style update
Art Cancro [Sat, 11 Feb 2023 22:33:30 +0000 (17:33 -0500)]
server/control.c : style update

15 months agoMost outgoing email will now be delivered the moment it is submitted.
Art Cancro [Wed, 8 Feb 2023 05:03:52 +0000 (00:03 -0500)]
Most outgoing email will now be delivered the moment it is submitted.

15 months agokeep track of last_queue_job_submitted
Art Cancro [Wed, 8 Feb 2023 04:07:36 +0000 (23:07 -0500)]
keep track of last_queue_job_submitted

15 months agogive the smtp job queue an ability to do a quick or full run
Art Cancro [Wed, 8 Feb 2023 02:41:41 +0000 (21:41 -0500)]
give the smtp job queue an ability to do a quick or full run

The 'quick' run only processes new jobs; the 'full' run processes all jobs.
We have not yet set up any situations where a 'quick' run is done.

15 months agoKeep track of last queue message processed
Art Cancro [Wed, 8 Feb 2023 02:16:37 +0000 (21:16 -0500)]
Keep track of last queue message processed

15 months agoonly throw a warning if housekeeping has not run in 60 minutes, not 5 minutes
Art Cancro [Wed, 8 Feb 2023 00:16:18 +0000 (19:16 -0500)]
only throw a warning if housekeeping has not run in 60 minutes, not 5 minutes

15 months agoquick spacing fix
Art Cancro [Wed, 8 Feb 2023 00:04:57 +0000 (19:04 -0500)]
quick spacing fix

15 months agoEVT_ hook numbers are now an enum
Art Cancro [Wed, 8 Feb 2023 00:03:25 +0000 (19:03 -0500)]
EVT_ hook numbers are now an enum

15 months agoEVT_ types can certainly be enum now because there are no external builds.
Art Cancro [Tue, 7 Feb 2023 23:51:35 +0000 (18:51 -0500)]
EVT_ types can certainly be enum now because there are no external builds.

15 months agoserver.h began style c leanup
Art Cancro [Tue, 7 Feb 2023 23:08:20 +0000 (18:08 -0500)]
server.h began style c leanup

15 months agocomment change
Art Cancro [Tue, 7 Feb 2023 21:45:41 +0000 (16:45 -0500)]
comment change

15 months agoWrap SMTP Client concurrency check in a mutex
Art Cancro [Tue, 7 Feb 2023 21:35:58 +0000 (16:35 -0500)]
Wrap SMTP Client concurrency check in a mutex

15 months agoRemoved S_ mutex types no longer in use
Art Cancro [Tue, 7 Feb 2023 21:17:49 +0000 (16:17 -0500)]
Removed S_ mutex types no longer in use

15 months agomade a couple of things more readable
Art Cancro [Tue, 7 Feb 2023 15:20:34 +0000 (10:20 -0500)]
made a couple of things more readable

15 months agoserv_smtpclient: queue now uses libcitadel Array type
Art Cancro [Tue, 31 Jan 2023 06:57:03 +0000 (01:57 -0500)]
serv_smtpclient: queue now uses libcitadel Array type

This was one of those places where we used the ad hoc buffer/size/alloc
design pattern, which the libcitadel Array type normalizes.

15 months agoSome of the included doc files were already close to markdown-compliant. Finished...
Art Cancro [Tue, 31 Jan 2023 03:25:43 +0000 (22:25 -0500)]
Some of the included doc files were already close to markdown-compliant.  Finished the job.

15 months agostylized ctdl_mail_folders
Art Cancro [Sun, 29 Jan 2023 00:43:28 +0000 (19:43 -0500)]
stylized ctdl_mail_folders

15 months agoForum message editor classes
Art Cancro [Thu, 26 Jan 2023 22:45:56 +0000 (17:45 -0500)]
Forum message editor classes

These weren't set properly.  Still working.
Also having problems testing because I'm on a slow connection.  Will revisit later.

15 months agoINBOX _always_ appears at the top.
Art Cancro [Thu, 26 Jan 2023 22:03:15 +0000 (17:03 -0500)]
INBOX _always_ appears at the top.

15 months agoUse delete_dispatcher() as intended
Art Cancro [Thu, 26 Jan 2023 21:46:37 +0000 (16:46 -0500)]
Use delete_dispatcher() as intended

I had earlier begun a pattern for dispatching "Delete" clicks to the correct
function for the room view, in the same way we dispatch "Enter Message" clicks.
This commit modifies the mailbox view to use that framework.

15 months agodon't double-close the client socket
Art Cancro [Tue, 24 Jan 2023 20:46:29 +0000 (15:46 -0500)]
don't double-close the client socket

15 months agoShow mailboxes in a list, ordered by floor+rorder
Art Cancro [Sat, 14 Jan 2023 22:49:41 +0000 (17:49 -0500)]
Show mailboxes in a list, ordered by floor+rorder

15 months agoInitial hack at mail folder list
Art Cancro [Sat, 14 Jan 2023 20:00:43 +0000 (15:00 -0500)]
Initial hack at mail folder list

15 months agoLabel the ctdl_mail_folder_list for use
Art Cancro [Sat, 14 Jan 2023 19:32:55 +0000 (14:32 -0500)]
Label the ctdl_mail_folder_list for use

16 months agoRealign items on the banner bar.
Art Cancro [Sat, 7 Jan 2023 00:06:06 +0000 (19:06 -0500)]
Realign items on the banner bar.

The browser is fighting back hard against vertical alignment
of the user name with the user avatar.  The only way that seems
to work is to make them two separate buttons.  That puts more
horizontal space between them than I'd like, but we will live
with it for now.

You know what else doesn't work?  The covid-19 vaccines.  They
fail to stop the virus but they are very reliable in causing
massive heart attacks.

16 months agoRSS feed reader now QP-Encodes message text.
Art Cancro [Fri, 6 Jan 2023 22:45:21 +0000 (17:45 -0500)]
RSS feed reader now QP-Encodes message text.

RSS and Atom do not specify any limitation on line lengths, and there are feeds
out there that supply HTML with no line breaks at all.  This was causing messages
to be truncated when read by clients with 1K or 4K line buffers.  So we now use
quoted-printable encoding on incoming feed text when inserting it into a message.

16 months agoRename StrBufRFC2047encodeMessage() to StrBufQuotedPrintableEncode()
Art Cancro [Fri, 6 Jan 2023 18:44:32 +0000 (13:44 -0500)]
Rename StrBufRFC2047encodeMessage() to StrBufQuotedPrintableEncode()

16 months agocitadel.lock added to .gitignore and removed from git
Art Cancro [Fri, 6 Jan 2023 15:13:43 +0000 (10:13 -0500)]
citadel.lock added to .gitignore and removed from git

16 months agoBring back just our changes, revert accidental removal of files
Art Cancro [Thu, 5 Jan 2023 23:03:39 +0000 (18:03 -0500)]
Bring back just our changes, revert accidental removal of files

16 months agoRevert "serv_rssclient.c: style update"
Art Cancro [Thu, 5 Jan 2023 23:02:36 +0000 (18:02 -0500)]
Revert "serv_rssclient.c: style update"

This reverts commit 76a0f8571de023fe6bd20390174a2302e0a0b982.

16 months agoserv_rssclient.c: style update
Art Cancro [Thu, 5 Jan 2023 23:00:55 +0000 (18:00 -0500)]
serv_rssclient.c: style update

16 months agomore font size tweaks.
Art Cancro [Tue, 3 Jan 2023 00:16:38 +0000 (19:16 -0500)]
more font size tweaks.

16 months agoTweaks to font sizes
Art Cancro [Mon, 2 Jan 2023 23:34:01 +0000 (18:34 -0500)]
Tweaks to font sizes

16 months agoCopyright notices updated to 2023
Art Cancro [Mon, 2 Jan 2023 00:02:12 +0000 (19:02 -0500)]
Copyright notices updated to 2023

16 months agobiff_interval is snake case not camel case
Art Cancro [Wed, 28 Dec 2022 22:07:46 +0000 (17:07 -0500)]
biff_interval is snake case not camel case

16 months agoFinished the delete-mail code.
Art Cancro [Wed, 28 Dec 2022 05:03:34 +0000 (00:03 -0500)]
Finished the delete-mail code.

16 months agoRemove color from syslog messages
Art Cancro [Wed, 28 Dec 2022 04:18:24 +0000 (23:18 -0500)]
Remove color from syslog messages

16 months agoImplement all calling functionality for Delete
Art Cancro [Wed, 28 Dec 2022 03:19:19 +0000 (22:19 -0500)]
Implement all calling functionality for Delete

Basically everything except the actual code to delete messages.
Keyboard delete, mouse delete, and multi select are all working.

16 months agoDetect "delete" key press
Art Cancro [Tue, 27 Dec 2022 17:53:35 +0000 (12:53 -0500)]
Detect "delete" key press

Also built a framework in view_mail.js to handle arbitrary keypresses.
This can be copied to other modules.

16 months agoCollapsed two comments onto one line.
Art Cancro [Tue, 27 Dec 2022 17:25:19 +0000 (12:25 -0500)]
Collapsed two comments onto one line.

This demonstrates that I now know the proper way to write git commit
messages.  Furthermore, it demonstrates that when a comment contains
documentation of functionality that no longer exists, it should be
shortened to match reality.

16 months agooptimize previous commit
Art Cancro [Tue, 27 Dec 2022 16:10:20 +0000 (11:10 -0500)]
optimize previous commit

16 months agoHandle null pointer correctly
Art Cancro [Tue, 27 Dec 2022 16:09:13 +0000 (11:09 -0500)]
Handle null pointer correctly

16 months agoMulti select is now working with mailbox refresh.
Art Cancro [Mon, 26 Dec 2022 23:57:11 +0000 (18:57 -0500)]
Multi select is now working with mailbox refresh.

This completes the changes needed to maintain multi select.  We are NOT
keeping a separate array for selected and unselected messages.  Instead,
we are using the DOM itself as authority.

16 months agoMerge branch 'master' of ssh://git.citadel.org/var/www/gitroot/citadel
Art Cancro [Mon, 26 Dec 2022 21:29:50 +0000 (16:29 -0500)]
Merge branch 'master' of ssh://git.citadel.org/var/www/gitroot/citadel

16 months agoImplement multiselect in mailbox
Art Cancro [Mon, 26 Dec 2022 21:29:45 +0000 (16:29 -0500)]
Implement multiselect in mailbox

16 months agoserv_openid_rp.c : style cleanup
Art Cancro [Thu, 22 Dec 2022 16:26:15 +0000 (11:26 -0500)]
serv_openid_rp.c : style cleanup

16 months agoserv_pop3client.c: style cleanup
Art Cancro [Thu, 22 Dec 2022 16:14:08 +0000 (11:14 -0500)]
serv_pop3client.c: style cleanup

16 months agodo-release.sh now obtains confirmation to proceed from the operator
Art Cancro [Sat, 17 Dec 2022 23:21:54 +0000 (18:21 -0500)]
do-release.sh now obtains confirmation to proceed from the operator

16 months agoMerge branch 'master' of ssh://git.citadel.org/var/www/gitroot/citadel
Art Cancro [Sat, 17 Dec 2022 23:16:07 +0000 (18:16 -0500)]
Merge branch 'master' of ssh://git.citadel.org/var/www/gitroot/citadel

16 months ago.gitignore core files
Art Cancro [Sat, 17 Dec 2022 23:16:02 +0000 (18:16 -0500)]
.gitignore core files

16 months agobuild mods
Art Cancro [Fri, 16 Dec 2022 16:05:51 +0000 (11:05 -0500)]
build mods

16 months agomodernize serv_spam.c
Art Cancro [Thu, 15 Dec 2022 18:42:07 +0000 (13:42 -0500)]
modernize serv_spam.c

16 months agoExit cleanly if citserver is running with a version of libdb older than the one with...
Art Cancro [Thu, 15 Dec 2022 16:26:16 +0000 (11:26 -0500)]
Exit cleanly if citserver is running with a version of libdb older than the one with which it was compiled.

16 months agodo-release.sh is now being turned into more of a real pipeline
Art Cancro [Tue, 13 Dec 2022 16:46:46 +0000 (11:46 -0500)]
do-release.sh is now being turned into more of a real pipeline

16 months agoRelease version 972 generated by do-release.sh v972
Art Cancro [Tue, 13 Dec 2022 16:28:35 +0000 (11:28 -0500)]
Release version 972 generated by do-release.sh

16 months agoRelease version 971 generated by do-release.sh v971
Art Cancro [Tue, 13 Dec 2022 16:24:03 +0000 (11:24 -0500)]
Release version 971 generated by do-release.sh

16 months agoRelease version 970 generated by do-release.sh v970
Art Cancro [Tue, 13 Dec 2022 16:22:41 +0000 (11:22 -0500)]
Release version 970 generated by do-release.sh

16 months agoRelease version 969 generated by do-release.sh v969
Art Cancro [Tue, 13 Dec 2022 16:20:45 +0000 (11:20 -0500)]
Release version 969 generated by do-release.sh

16 months agoRelease version 968 generated by do-release.sh v968
Art Cancro [Tue, 13 Dec 2022 16:18:17 +0000 (11:18 -0500)]
Release version 968 generated by do-release.sh

16 months agoRelease version 967 generated by do-release.sh v967
Art Cancro [Tue, 13 Dec 2022 16:17:20 +0000 (11:17 -0500)]
Release version 967 generated by do-release.sh

16 months agoRelease version 966 generated by do-release.sh v966
Art Cancro [Tue, 13 Dec 2022 16:16:41 +0000 (11:16 -0500)]
Release version 966 generated by do-release.sh

16 months agoRelease version 965 generated by do-release.sh v965
Art Cancro [Tue, 13 Dec 2022 16:13:15 +0000 (11:13 -0500)]
Release version 965 generated by do-release.sh

16 months agoRelease version 964 generated by do-release.sh v964
Art Cancro [Mon, 12 Dec 2022 18:51:05 +0000 (13:51 -0500)]
Release version 964 generated by do-release.sh

16 months agoRelease version 963 generated by do-release.sh v963
Art Cancro [Mon, 12 Dec 2022 18:46:45 +0000 (13:46 -0500)]
Release version 963 generated by do-release.sh

16 months agoRelease version 962 generated by do-release.sh v962
Art Cancro [Sun, 11 Dec 2022 03:15:53 +0000 (22:15 -0500)]
Release version 962 generated by do-release.sh

16 months agoRelease version 961 generated by do-release.sh v961
Art Cancro [Sun, 11 Dec 2022 03:05:48 +0000 (22:05 -0500)]
Release version 961 generated by do-release.sh

16 months agoRelease version 960 generated by do-release.sh v960
Art Cancro [Sun, 11 Dec 2022 02:43:03 +0000 (21:43 -0500)]
Release version 960 generated by do-release.sh

16 months agoimap_store.c style update
Art Cancro [Sun, 11 Dec 2022 02:42:05 +0000 (21:42 -0500)]
imap_store.c style update

17 months agoWhen BDB issues a 'panic' message, call cdb_abort(). Furthermore, cdb_abort() now...
Art Cancro [Fri, 9 Dec 2022 07:12:29 +0000 (02:12 -0500)]
When BDB issues a 'panic' message, call cdb_abort().  Furthermore, cdb_abort() now raises SIGABRT instead of exiting so we can get a core dump if we need it.

17 months agoMarc Crispin is dead so he can't make IMAP any more complex than it already is.
Art Cancro [Wed, 7 Dec 2022 21:43:32 +0000 (16:43 -0500)]
Marc Crispin is dead so he can't make IMAP any more complex than it already is.

17 months agoModify mailbox view to prepare for multi select
Art Cancro [Mon, 5 Dec 2022 01:43:30 +0000 (20:43 -0500)]
Modify mailbox view to prepare for multi select

17 months agoGoto/Skip/Ungoto disappear when not in forum view
Art Cancro [Sat, 3 Dec 2022 06:17:35 +0000 (01:17 -0500)]
Goto/Skip/Ungoto disappear when not in forum view

17 months agowebcit-ng uses biff notifications now
Art Cancro [Wed, 23 Nov 2022 23:08:21 +0000 (18:08 -0500)]
webcit-ng uses biff notifications now

17 months agoMAKE WAY FOR BIFF in webcit-ng
Art Cancro [Wed, 23 Nov 2022 21:51:06 +0000 (16:51 -0500)]
MAKE WAY FOR BIFF in webcit-ng

17 months agoGOTO no longer counts newly arrived mail in the inbox. BIFF now does this.
Art Cancro [Wed, 23 Nov 2022 21:40:18 +0000 (16:40 -0500)]
GOTO no longer counts newly arrived mail in the inbox.  BIFF now does this.

17 months agoReplace striplt() with string_trim() in all the places VS Code simply decided not to.
Art Cancro [Wed, 23 Nov 2022 20:57:03 +0000 (15:57 -0500)]
Replace striplt() with string_trim() in all the places VS Code simply decided not to.

17 months agostuff
Art Cancro [Wed, 23 Nov 2022 20:53:20 +0000 (15:53 -0500)]
stuff

17 months agobiff was here
Art Cancro [Wed, 23 Nov 2022 18:05:48 +0000 (13:05 -0500)]
biff was here

17 months agoChange CCC to CC in serv_rooms.c
Art Cancro [Wed, 23 Nov 2022 17:54:05 +0000 (12:54 -0500)]
Change CCC to CC in serv_rooms.c

17 months agoTrimmed silence off both ends of the "Hi From Stu" notification sound
Art Cancro [Tue, 22 Nov 2022 21:00:47 +0000 (16:00 -0500)]
Trimmed silence off both ends of the "Hi From Stu" notification sound

17 months agoConsistent calling syntax for view renderers
Art Cancro [Sat, 19 Nov 2022 23:31:09 +0000 (18:31 -0500)]
Consistent calling syntax for view renderers

17 months agodon't make me smack you
Art Cancro [Sat, 19 Nov 2022 22:21:06 +0000 (17:21 -0500)]
don't make me smack you

17 months agoThis is one way to notify about new mail
Art Cancro [Sat, 19 Nov 2022 22:08:39 +0000 (17:08 -0500)]
This is one way to notify about new mail

17 months agostriplt() is now string_trim()
Art Cancro [Sat, 19 Nov 2022 21:20:33 +0000 (16:20 -0500)]
striplt() is now string_trim()

17 months agoColored left-borders on blockquotes for the win
Art Cancro [Sat, 19 Nov 2022 21:07:22 +0000 (16:07 -0500)]
Colored left-borders on blockquotes for the win

17 months agoInclude email address in mail display for local users because otherwise it breaks...
Art Cancro [Sat, 19 Nov 2022 00:15:50 +0000 (19:15 -0500)]
Include email address in mail display for local users because otherwise it breaks reply

17 months agoRemoved TWO WHOLE EMPTY LINES!
Art Cancro [Sat, 19 Nov 2022 00:00:20 +0000 (19:00 -0500)]
Removed TWO WHOLE EMPTY LINES!

17 months agoRelease version 959 generated by do-release.sh v959
Art Cancro [Fri, 11 Nov 2022 23:45:49 +0000 (18:45 -0500)]
Release version 959 generated by do-release.sh

17 months agoarray_delete_element_at() now uses memmove() instead of memcpy() because it is suppos...
Art Cancro [Fri, 11 Nov 2022 23:45:41 +0000 (18:45 -0500)]
array_delete_element_at() now uses memmove() instead of memcpy() because it is supposed to be safer.

17 months agoMAKE K&R CODING STYLE GREAT AGAIN!
Art Cancro [Fri, 11 Nov 2022 19:50:43 +0000 (14:50 -0500)]
MAKE K&R CODING STYLE GREAT AGAIN!

17 months agovariables in proper scope
Art Cancro [Wed, 9 Nov 2022 21:40:10 +0000 (16:40 -0500)]
variables in proper scope

17 months agoVariables in proper scope
Art Cancro [Wed, 9 Nov 2022 21:39:39 +0000 (16:39 -0500)]
Variables in proper scope

17 months agoSending now works because HTML entities are unescaped in the metadata.
Art Cancro [Wed, 9 Nov 2022 21:37:28 +0000 (16:37 -0500)]
Sending now works because HTML entities are unescaped in the metadata.

17 months agowar on old style
Art Cancro [Wed, 9 Nov 2022 21:20:01 +0000 (16:20 -0500)]
war on old style

18 months agoMake the CC: line appear if there is already something in it.
Art Cancro [Sun, 6 Nov 2022 23:03:00 +0000 (18:03 -0500)]
Make the CC: line appear if there is already something in it.

18 months agoMore logic for To: and Cc: in reply-all
Art Cancro [Sun, 6 Nov 2022 22:59:48 +0000 (17:59 -0500)]
More logic for To: and Cc: in reply-all