]>
code.citadel.org Git - citadel.git/log
Art Cancro [Tue, 20 Sep 2011 19:02:25 +0000 (15:02 -0400)]
Changed the naming convention of the setup wizard filename
Art Cancro [Tue, 20 Sep 2011 18:37:54 +0000 (14:37 -0400)]
The definition of ThreadIdHash() has been moved from webcit.h to libcitadel.h
Art Cancro [Tue, 20 Sep 2011 16:31:48 +0000 (12:31 -0400)]
Use base64 encoding for permalinks in bbs rooms, otherwise google+ mangles them
Wilfried Goesgens [Tue, 20 Sep 2011 14:38:46 +0000 (14:38 +0000)]
Disable RSS-shorter link expander.
Wilfried Goesgens [Tue, 20 Sep 2011 14:31:53 +0000 (14:31 +0000)]
remove notes about 'W' double use again.
Art Cancro [Tue, 20 Sep 2011 13:47:56 +0000 (09:47 -0400)]
serv_extnotify now uses field '2' instead of field 'W' within the server; resolve conflict with the use of 'W' for references
Wilfried Goesgens [Mon, 19 Sep 2011 18:47:52 +0000 (18:47 +0000)]
Fix indention; its broken in some places which seems to hide memleaks.
Wilfried Goesgens [Mon, 19 Sep 2011 21:19:12 +0000 (21:19 +0000)]
fix possible leaks around 'W'; the funambol code abuses it.
Wilfried Goesgens [Mon, 19 Sep 2011 21:18:24 +0000 (21:18 +0000)]
Fix memory leaks in the networker
Wilfried Goesgens [Mon, 19 Sep 2011 18:50:47 +0000 (18:50 +0000)]
'W' is double used for the user when doing extnotify spool messages; add this to our column description.
Wilfried Goesgens [Mon, 19 Sep 2011 18:47:52 +0000 (18:47 +0000)]
Fix indention; its broken in some places which seems to hide memleaks.
Wilfried Goesgens [Fri, 16 Sep 2011 18:53:13 +0000 (18:53 +0000)]
.debs: citserver depends on patch now.
Art Cancro [Thu, 15 Sep 2011 16:35:49 +0000 (12:35 -0400)]
Upgrade TinyMCE to v3.4.5
Art Cancro [Wed, 14 Sep 2011 21:49:51 +0000 (17:49 -0400)]
Conditional_USER_HAS_PIC() was leaving the download file open, causing the actual download to fail. Fixed.
Art Cancro [Wed, 14 Sep 2011 20:28:46 +0000 (16:28 -0400)]
Write out a log message when an unparented blog comment is encountered
Art Cancro [Wed, 14 Sep 2011 16:24:53 +0000 (12:24 -0400)]
bbsview_renderer 'go to page' links now use start_reading_at= instead of page= in order to make them more persistent when archived or indexed.
Art Cancro [Wed, 14 Sep 2011 16:03:30 +0000 (12:03 -0400)]
bbsview_renderer readfwd links now include a go= parameter to include the room name
Wilfried Goesgens [Wed, 14 Sep 2011 13:34:35 +0000 (13:34 +0000)]
Removing of static vars in the Networker
- we have to fiddle them through the SpoolControl structure into the ForeachMessage() loop.
Art Cancro [Tue, 13 Sep 2011 20:35:21 +0000 (16:35 -0400)]
oops ... there was no way to delete blog comments ... fixed that
Art Cancro [Tue, 13 Sep 2011 19:04:10 +0000 (15:04 -0400)]
Only show the Search box in the mailbox view because that's the only view that it works in.
Art Cancro [Mon, 12 Sep 2011 15:53:20 +0000 (11:53 -0400)]
Use autoconf to locate the diff and patch executables and pass those pathnames to serv_wiki.c
Art Cancro [Fri, 9 Sep 2011 17:04:25 +0000 (13:04 -0400)]
Added a couple more entity declarations
Wilfried Goesgens [Thu, 8 Sep 2011 17:18:12 +0000 (17:18 +0000)]
Remove global variables; replace by stack passing.
Wilfried Goesgens [Thu, 8 Sep 2011 13:45:29 +0000 (13:45 +0000)]
CC -> CCC in do_login
Wilfried Goesgens [Thu, 8 Sep 2011 12:35:51 +0000 (12:35 +0000)]
Networker reordering; remove / change dependencies
- move serv_network.h into modules/network where it belongs...
- move structs out of serv_network.h into their respective headers
- serv_expire doesn't need serv_network.h anymore, it seems to get the usetable struct from elsewhere
- the netfilter module was moved to the network directory, it seems to be closely dangled to networking
- move all code about the netfilter (config reading) into serv_netfilter.c
- move the code networker related from msgbase.c:CtdlDoIHavePermissionToPostInThisRoom() into serv_netconfig.c:netconfig_check_roomaccess()
- move the filterlist instance into serv_netfilter.c
lesson learned the hard way today: if you move a header, flush the dependencies, else the make process will abort with no usefull message at all.
-> Gentlemen please flush the dependencies and rebootstrap your workingcopy.
Wilfried Goesgens [Thu, 8 Sep 2011 12:07:55 +0000 (12:07 +0000)]
Remove unused AUTH variable from the buildsystem
Wilfried Goesgens [Thu, 8 Sep 2011 09:35:01 +0000 (09:35 +0000)]
Chop networker into handy bits; related functions now live in their own file.
- master has some different vars; adjusted.
Wilfried Goesgens [Wed, 7 Sep 2011 21:07:09 +0000 (21:07 +0000)]
remove unused code for locking
Art Cancro [Wed, 7 Sep 2011 19:44:18 +0000 (15:44 -0400)]
oops, I had SERV_TRACE enabled and committed that. fixed
Art Cancro [Wed, 7 Sep 2011 19:43:37 +0000 (15:43 -0400)]
Negated a strcmp in netconf.c that caused the function to hang every single time, how did this get this way?
Wilfried Goesgens [Wed, 7 Sep 2011 14:56:31 +0000 (14:56 +0000)]
Handle return values in Setup; catch errors & remove unneeded code.
Wilfried Goesgens [Wed, 7 Sep 2011 15:25:11 +0000 (15:25 +0000)]
Code shuffling fixes warning with inline function... weirdo.
Wilfried Goesgens [Wed, 7 Sep 2011 14:59:21 +0000 (14:59 +0000)]
Fix warnings all over citserver; handle function replies; remove unused code.
Wilfried Goesgens [Wed, 7 Sep 2011 14:57:14 +0000 (14:57 +0000)]
Cleanup our toolies, remove unneeded code; handle reply values.
Wilfried Goesgens [Wed, 7 Sep 2011 12:25:52 +0000 (12:25 +0000)]
remove unused code; evaluate returnvalues.
Wilfried Goesgens [Wed, 7 Sep 2011 12:25:26 +0000 (12:25 +0000)]
remove unused code.
Wilfried Goesgens [Wed, 7 Sep 2011 12:24:48 +0000 (12:24 +0000)]
Precisely report whats going wrong with the handling of the control file.
Wilfried Goesgens [Wed, 7 Sep 2011 12:13:44 +0000 (12:13 +0000)]
Fix more warnings; output errors to the users.
Wilfried Goesgens [Wed, 7 Sep 2011 09:37:33 +0000 (09:37 +0000)]
Fix compiler warnings in the textclient by evaluating returnvalues and removing unused code.
Wilfried Goesgens [Wed, 7 Sep 2011 12:13:00 +0000 (12:13 +0000)]
use StrBuf to create startup failure messages.
Wilfried Goesgens [Wed, 7 Sep 2011 12:39:03 +0000 (12:39 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Tue, 6 Sep 2011 23:00:12 +0000 (23:00 +0000)]
Limit length of Commands sent to citserver; do multible json requests if neccessary
- roomListDropHandler() when cut'n'paste moving split after the move vector reaches 800 chars
- deleteAllSelectedMessages() when <del> moving to trash / purging split into chunks to limit the command lengths
Art Cancro [Tue, 6 Sep 2011 21:20:06 +0000 (17:20 -0400)]
Test commit 2
Art Cancro [Tue, 6 Sep 2011 21:17:34 +0000 (17:17 -0400)]
Test commit
Wilfried Goesgens [Tue, 6 Sep 2011 18:52:59 +0000 (18:52 +0000)]
Libcitadel resync; forgot to add that one.
Wilfried Goesgens [Tue, 6 Sep 2011 18:46:53 +0000 (18:46 +0000)]
deleteAllSelectedMessages(): don't send one request per message, citadel can handle a list of them already.
- this dramaticaly increases the performance of pressing the <del> key when having several messages selected; less stress on the browser, webcit and citserver.
Wilfried Goesgens [Mon, 5 Sep 2011 08:56:58 +0000 (08:56 +0000)]
Sync libcitadel with the one from the libevent-branch
Wilfried Goesgens [Sun, 28 Aug 2011 08:31:30 +0000 (08:31 +0000)]
Adjust %s es in the chinese translation; Note to self: format string translates are bad.
Wilfried Goesgens [Sun, 28 Aug 2011 07:49:19 +0000 (07:49 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sun, 28 Aug 2011 07:48:34 +0000 (07:48 +0000)]
Add templatization for the Listsubscriber Interface; the old interface remains intact.
Wilfried Goesgens [Sun, 28 Aug 2011 07:45:01 +0000 (07:45 +0000)]
Add LPRM iterator for the public rooms.
Wilfried Goesgens [Sun, 28 Aug 2011 07:44:23 +0000 (07:44 +0000)]
remove unused copy to WCC
Art Cancro [Sat, 27 Aug 2011 23:25:57 +0000 (19:25 -0400)]
Clear of non-default language setting moved to its proper place
Art Cancro [Fri, 26 Aug 2011 17:03:57 +0000 (13:03 -0400)]
Make use of XML_StopParser() when XML_MAJOR_VERSION is >1, not >2. Thanks to Stefan for the bugfix.
Art Cancro [Fri, 26 Aug 2011 14:17:03 +0000 (10:17 -0400)]
Removed references to Subversion in the code
Art Cancro [Thu, 25 Aug 2011 21:28:18 +0000 (17:28 -0400)]
Fixed the remaining bugs that kept Drafts from working properly
Art Cancro [Thu, 25 Aug 2011 21:07:58 +0000 (17:07 -0400)]
Test commit
Art Cancro [Thu, 25 Aug 2011 20:02:40 +0000 (16:02 -0400)]
Cleanup of code path for handling message submit errors
Art Cancro [Thu, 25 Aug 2011 19:51:13 +0000 (15:51 -0400)]
Submitting a message and getting back a 550 from the server now results in an error message instead of a blank page.
Art Cancro [Thu, 25 Aug 2011 19:33:48 +0000 (15:33 -0400)]
Changed save_to_drafts to saving_to_drafts for clarity
Art Cancro [Wed, 24 Aug 2011 21:56:24 +0000 (17:56 -0400)]
Noted with a comment where we need to handle ENT0 errors
Art Cancro [Wed, 24 Aug 2011 21:12:03 +0000 (17:12 -0400)]
Only offer the 'Edit' option in mailbox rooms. Elsewhere it does not make sense.
Art Cancro [Wed, 24 Aug 2011 21:06:27 +0000 (17:06 -0400)]
If user clicks in the empty part of a mailbox view, display a blank pane instead of an error.
Art Cancro [Tue, 23 Aug 2011 21:13:09 +0000 (17:13 -0400)]
More 'greeking' the test mime data.
Art Cancro [Tue, 23 Aug 2011 20:57:11 +0000 (16:57 -0400)]
Began 'greeking' the test mime data.
Art Cancro [Mon, 22 Aug 2011 18:18:37 +0000 (14:18 -0400)]
Set all version numbers to 8.00 -- FEATURE FREEZE FOR 8.00
Art Cancro [Mon, 22 Aug 2011 17:20:04 +0000 (13:20 -0400)]
Added a checked and disabled dummy option in the room access tab, indicating that blog creators automatically become room aides.
This advises administrators of a built-in behavior, and also exposes a string to the translators so that its localization will already exist if we add that option later.
Art Cancro [Mon, 22 Aug 2011 17:07:12 +0000 (13:07 -0400)]
Blog owners automatically become room aides of their blogs.
(In the future we will offer a site-wide configuration setting to suppress this behavior.)
Wilfried Goesgens [Sat, 20 Aug 2011 11:58:57 +0000 (11:58 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sat, 20 Aug 2011 11:58:14 +0000 (11:58 +0000)]
QP-Encode questionmarks.
Wilfried Goesgens [Sat, 20 Aug 2011 09:50:26 +0000 (09:50 +0000)]
When QP encoding, we need to convert blanks to underscores
- Spamassasin test 'BAD_ENC_HEADER' matches if a subject looks like that:
Subject: =?UTF-8?Q?=5Btestml=5D l=C3=B6sch misch ey.?=
it needs to look like that:
Subject: =?UTF-8?Q?=5Btestml=5D_l=C3=B6sch_misch_ey.?=
Art Cancro [Fri, 19 Aug 2011 19:12:50 +0000 (15:12 -0400)]
Clear selected_language when marking a guest session as inuse=0.
This prevents new visitors from seeing their first page in Chinese after Baidu comes calling.
Wilfried Goesgens [Fri, 19 Aug 2011 17:17:31 +0000 (17:17 +0000)]
add missing var definition *ups*
Wilfried Goesgens [Fri, 19 Aug 2011 17:12:32 +0000 (17:12 +0000)]
Fix detecting of UTF8 Sequences
- we need to exactly check for both highest bits to be set, not one of them.
Wilfried Goesgens [Fri, 19 Aug 2011 16:43:30 +0000 (16:43 +0000)]
fix counting of UTF8-charwidth
- Ctdl_GetUtf8SequenceLength(): testbyte needs to be unsigned char, else >> will shift us new bits in from the left
- we need to shift 'test' to the right
- start counting at 0
Wilfried Goesgens [Sun, 3 Jul 2011 13:47:55 +0000 (13:47 +0000)]
Add ability to hex encode binary strings
- when encoding plain md5 binary buffers we have to pass the length into the hex encoder, add parameter
- add wrapper providing old schematic
- fix documentation of StrBufSipLine()
Wilfried Goesgens [Thu, 18 Aug 2011 18:18:38 +0000 (18:18 +0000)]
fix StrHtmlEcmaEscAppend, StrECMAEscAppend
- StrHtmlEcmaEscAppend(): reimplement 'nbsp' - handling
- StrECMAEscAppend(): copy over required stuff from StrHtmlEcmaEscAppend()
Wilfried Goesgens [Thu, 18 Aug 2011 17:53:18 +0000 (17:53 +0000)]
Fix StrHtmlEcmaEscAppend() more edge cases in utf8 handling
- Ctdl_GetUtf8SequenceLength(): return 0 for broken, 1 for non-utf8 sequences
- StrHtmlEcmaEscAppend(): another attempt to fix json appending:
- use switch instead of Rumpelstilskin if sequence
- use HKEY for our static sequences
- don't check for buffer expansion again while utf8-handling; we have 11 bytes reserved, utf8 will at most become 6 bytes
- Simply handle ASCII chars in the utf8 loop
- since aptr is moved implicitely, we mustn't move it for the last byte
- add missing handling for some escapers
- let unicode escapers pass
Wilfried Goesgens [Thu, 18 Aug 2011 10:30:35 +0000 (10:30 +0000)]
Don't add brackets <> to the reply to; it should be ok without.
Wilfried Goesgens [Thu, 18 Aug 2011 10:27:54 +0000 (10:27 +0000)]
parse reply-to header into its permanent database field
it seems as if some mailers (Open exchange for example) add Reply-To headers; if we don't parse it when receiving it,
our list service adds another header; thus parse it into the database of headers.
Wilfried Goesgens [Thu, 18 Aug 2011 09:53:01 +0000 (09:53 +0000)]
fix QP encoding
- once we decided to QP encode we also need to encode = (forgotten in last commit)
Wilfried Goesgens [Thu, 18 Aug 2011 09:14:48 +0000 (09:14 +0000)]
fix QP encoding
- once we decided to QP encode we also need to encode =[]
Wilfried Goesgens [Wed, 17 Aug 2011 10:13:28 +0000 (10:13 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Wed, 17 Aug 2011 10:12:21 +0000 (10:12 +0000)]
Fix envelope-to header.
- don't output leading whitespace
- don't output it at all if there is just whitespace inside.
Art Cancro [Tue, 16 Aug 2011 19:55:15 +0000 (15:55 -0400)]
Fixed a bug in the 'only replies are allowed in this room' logic in ENT0 command.
Art Cancro [Tue, 16 Aug 2011 04:03:58 +0000 (00:03 -0400)]
Began working on access control changes for blog rooms.
Art Cancro [Tue, 16 Aug 2011 03:49:35 +0000 (23:49 -0400)]
Improved coding style of the complex conditionals in CtdlRoomAccess()
Wilfried Goesgens [Fri, 12 Aug 2011 15:51:14 +0000 (15:51 +0000)]
network_spool_msg() handle QP
while appending the [roomname] to the mailsubject, we have to
- de-qp the original subject
- search for the roomname
- possibly prepend '[roomame] '
- and re-qp everything.
that way we solve...
- multiple [roomname] additions in case of QP encoded subjects
- non RFC-Conformant behaviour in case of roomnames with umlauts.
Wilfried Goesgens [Fri, 12 Aug 2011 15:49:45 +0000 (15:49 +0000)]
display_enter(): handle QP encodings
- while loading several headers from the server we need to de-QP, else we will find gibberish in our...
- Subject
- recipients
Wilfried Goesgens [Thu, 4 Aug 2011 21:09:56 +0000 (21:09 +0000)]
fix all the tiny conditional problems our new checker told us about.
Wilfried Goesgens [Thu, 4 Aug 2011 20:52:11 +0000 (20:52 +0000)]
use the regular template error logging for our new endconditional checker, so we get our clean regular and detailed error messages.
Wilfried Goesgens [Thu, 4 Aug 2011 20:08:30 +0000 (20:08 +0000)]
add .silent and some echo logic to our makefiles; thanks to sECuRE for the hints.
Wilfried Goesgens [Mon, 1 Aug 2011 23:10:00 +0000 (23:10 +0000)]
after reading a template sanity check conditionals whether they're paired
Wilfried Goesgens [Sun, 31 Jul 2011 22:40:06 +0000 (22:40 +0000)]
move the rest of the places to use AppendImportantMessage() or GetServerStatusMsg()
Wilfried Goesgens [Sun, 31 Jul 2011 16:49:56 +0000 (16:49 +0000)]
ups. zero based so an off by one.
Wilfried Goesgens [Sat, 30 Jul 2011 17:59:49 +0000 (17:59 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sat, 30 Jul 2011 17:58:48 +0000 (17:58 +0000)]
Fix our problems with strings like this: "abc'def" in template token strings.
Art Cancro [Sat, 30 Jul 2011 16:27:10 +0000 (12:27 -0400)]
Permalinks for messages in BBS rooms
Wilfried Goesgens [Sat, 30 Jul 2011 16:23:32 +0000 (16:23 +0000)]
check template token name for invalid chars; that way we find ')' etc.
Wilfried Goesgens [Thu, 28 Jul 2011 23:16:12 +0000 (23:16 +0000)]
buybuy plaintext important message.