Art Cancro [Fri, 15 Jul 2022 17:56:13 +0000 (13:56 -0400)]
Add a web API command for the server STAT command. This will allow us to implement a new-messages check that does not require loading the entire room again.
Art Cancro [Thu, 14 Jul 2022 15:39:25 +0000 (11:39 -0400)]
All right, this is more or less it. I had to resort to creating a function stuffbar() that has to be called whenever we render a new screen in the main div, to tell it whether or not the stuffbar requires displaying in this view. Since we will be using the stuffbar for multiple things this seems ok.
Art Cancro [Thu, 14 Jul 2022 03:11:17 +0000 (23:11 -0400)]
Finally got the divs to display correctly by making the mailbox a part of the top banner. Committing this as-is even though I still hjave to make the mailbox load and unload at the correct times.
Art Cancro [Wed, 6 Jul 2022 15:51:18 +0000 (11:51 -0400)]
Define the citserver BUILD_ID as a five digit number consisting of the two digit year and a zero-padded three digit julian date. No, this is not Year 2100 compliant. I will be delighted if Citadel is still in use half a century after I'm dead and this will be a small problem for someone to solve.
Art Cancro [Wed, 29 Jun 2022 21:17:04 +0000 (17:17 -0400)]
Pass through the data to tell the client if it has room aide privileges and/or permission to delete messages in the current room. Aide or Room Aide privileges are now indicated via a user-with-cog icon in the room name banner. The delete button in the forum view now only appears if the client believes it is allowed.
Art Cancro [Mon, 27 Jun 2022 16:34:48 +0000 (12:34 -0400)]
Removed close_masters() because it was completely redundant.
Master sockets are already closed during extension shutdown routines.
And yes we still use the word "master" because we are not politicially correct twits.
Art Cancro [Sat, 25 Jun 2022 17:25:32 +0000 (13:25 -0400)]
Removed the comments about not needing to block on select() , after remembering that even though the thundering herd problem no longer exists, we still have to deal with timer events and incoming data on client sockets. select() is still appropriate here.
Art Cancro [Sat, 25 Jun 2022 15:08:52 +0000 (11:08 -0400)]
The unused messages in setup.c are now in an unused function instead of being blocked out. I don't know if this makes a difference to the strings available for translation but I did it just in case.
Art Cancro [Tue, 14 Jun 2022 23:24:38 +0000 (19:24 -0400)]
configure (in Citadel Server) - don't accept "--prefix" anymore.
This option might confuse some people into thinking they're going
to get ${prefix}/[bin|etc|var] but we don't do that. Now we only
accept "--ctdldir" to reflect our own directory hierarchy.
Easy Install has been modified to use --ctdldir as well.
Art Cancro [Sun, 12 Jun 2022 04:27:59 +0000 (00:27 -0400)]
There are three specific compiler warnings that we don't care about. Suppress them using a GCC pragma in the header files instead of mucking up the build system.
Art Cancro [Sat, 11 Jun 2022 23:40:07 +0000 (19:40 -0400)]
CTDLDIR is now properly compiled into the source code based on what was configured at build time. This makes it properly run from its native directory if no extra commands are supplied, but it can run from another data directory if specified.
Art Cancro [Sat, 11 Jun 2022 17:46:34 +0000 (13:46 -0400)]
More work on "make install" including some simplification of database_cleanup.sh. Debian stopped updating their Berkeley DB packages so we aren't going to support their "db{version}_util" syntax anymore. This makes life easier for the build process, even though we now have no hope of expecting that a compatible version of BDB will be available in the operating system."
Art Cancro [Wed, 8 Jun 2022 19:26:51 +0000 (15:26 -0400)]
textclient: test to see whether iconv requires -liconv in ldflags. Now it should work on both Linux and FreeBSD. I will backport this patch to the production release.
Art Cancro [Sat, 4 Jun 2022 23:11:58 +0000 (19:11 -0400)]
This is an omnibus commit which moves the Citadel Server from crusty old GNU Autotools to the shiny new conf-IG-ure system. WARNING BROKEN BUILD ALERT: at the moment it only compiles the server and lacks 'clean' and 'install' targets. Subsequent commits will resolve these but don't try to build production from this yet.
Art Cancro [Mon, 23 May 2022 19:56:39 +0000 (20:56 +0100)]
Rewrote our local implementation of a Base64 encoder/decoder as specified
in RFC 2045 section 6.8. In the past, someone tried to make this "elegant"
and in the process they made it broken when certain conditions exist. If
you are reading this and it isn't broken, don't try to improve it. It works
and I don't want to fix it again. I don't care how many nanoseconds you think
you can shave off the execution time. Don't fucking touch it.
Art Cancro [Tue, 17 May 2022 18:03:11 +0000 (19:03 +0100)]
Temporarily added some debugs and an assert() statement to show where the message buffer is getting truncated during large reads on low memory systems.
Art Cancro [Mon, 2 May 2022 23:43:17 +0000 (19:43 -0400)]
Taking a peek at serv_expire.c to see what would be involved in deleting
users who aren't in LDAP anymore. And you know what that means: I can't
help myself but to update the comment style all over that file.
Art Cancro [Sat, 26 Feb 2022 20:13:14 +0000 (15:13 -0500)]
Handle messages that are empty (or which appear empty to MSG4 because they consist solely of a non-renderable attachment in Part 0) by delivering a null json instead of locking up.
Art Cancro [Thu, 17 Feb 2022 00:41:50 +0000 (19:41 -0500)]
The sidebar buttons are now unhighlighted by default. When rendering a room view, iterate through all of them, unhighlight any that are highlighted, and then highlight the correct one.
Art Cancro [Wed, 16 Feb 2022 23:53:34 +0000 (18:53 -0500)]
Use the Font Awesome 6.0.0 hosted version instead of 5.whatever ... note to self: now that I know they just randomly pull back versions off the CDN, we need to host our own or include it in the package during final distribution. Bad form, FA people. Bad form.
Art Cancro [Fri, 11 Feb 2022 21:56:42 +0000 (16:56 -0500)]
Fixed a bug in the "goto next room" logic that was causing the first click of Goto (or Skip) to load the march list but then didn't actually change rooms.