Art Cancro [Thu, 15 Nov 2007 16:15:09 +0000 (16:15 +0000)]
Fixed a bug introduced in r5517 that was causing
incoming network messages to simply be thrown away most of
the time. r5517 replaced a call to /bin/mv with a copy file
loop, but the loop operated in line-by-line text mode.
Network spool contains architecture-independent binary data,
so this was failing.
Dave West [Tue, 13 Nov 2007 02:37:45 +0000 (02:37 +0000)]
A little bit of speed up in the wordbreaker for full text indexing.
Also fixed a small bug that made some of our index tokens bad.
Maybe this will fix some of the text search problems some people are
seeing.
We also need to alter the indexer to index the message headers as well
as the body, at the moment we only index the body.
Art Cancro [Sun, 11 Nov 2007 05:35:30 +0000 (05:35 +0000)]
Amended the MSGP command to provide a way for the client to
indicate to the server that it prefers to decode Base64 and quoted-printable
on the client side when reading MIME parts with the MSG4 command.
Resolves bug 289.
Art Cancro [Sun, 11 Nov 2007 04:46:40 +0000 (04:46 +0000)]
* moved CtdlDecodeQuotedPrintable() into tools.c
(later we will move most or all of tools.c into libcitadel)
* amended citadel_ipc.c message reading loop. When using MSG4 (nearly
always), parse base64 and quoted-printable encodings, and decode them.
MSG4 does not *yet* send these, instead performing the decoding on
the server side. During experimentation I told the server not to
decode, and this will resolve Bug #289. All that's left to do is to
add something to the protocol so that the client can tell the server
that it wants non-decoded message text. I'll do that tomorrow.
Art Cancro [Sat, 10 Nov 2007 05:32:30 +0000 (05:32 +0000)]
When populating the address book popup with the contents of
an address book room (such as the Global Address Book), save the name of the room
we came from and go back there after fetching the address book. Fixes bug #227.
Art Cancro [Thu, 8 Nov 2007 23:05:25 +0000 (23:05 +0000)]
Fixed the problem dave reported yesterday, where a
large calendar hung the webcit renderer while displaying.
This turned out to have nothing to do with the size of the
calendar, but with a specific event that had no newline
at the end and caused the 000 terminator to appear at the
end of a line instead of on its own line. Switched from
MSG0 to MSG4 in webcit to both work around this problem and
save over-the-wire chatter. Dave's work from last night
plus this commit, resolve bug #284.
Art Cancro [Thu, 8 Nov 2007 15:22:01 +0000 (15:22 +0000)]
Added the User-Agent: and Accept: headers to our
HTTP client requests. Some HTTP servers (such as www.digg.com)
simply disconnect without any response if they are not present.
I correct the errors which are found by Firefox Tiny Validator.
- a div tag in excess at the foot of the all pages (there remains one
about it)
- a td tag which must be a th tag in the monthly view of the calendar
I added the name of the current user running in the title of the page. It
appears with the name of the site and that of the navigator in the bar
in top of the window.
Art Cancro [Tue, 6 Nov 2007 22:57:53 +0000 (22:57 +0000)]
Removed a stray </select> tag which appeared
after the Search: input box. This seems to have made the Reply/Move/Print
buttons reappear in IE 7, resolving Bug 262.
Art Cancro [Tue, 6 Nov 2007 22:49:41 +0000 (22:49 +0000)]
Removed an extra <div> and also fixed a <td> tag with
a missing right angle bracket. This fixes the problem with the
address book popup that I mentioned in Bug 262, but it does not
fix the entire bug. We are looking at two different problems
after all.
Dave West [Tue, 6 Nov 2007 19:40:39 +0000 (19:40 +0000)]
Add #include <stdarg.h>
Needed for the prototype of vlprintf, at least on the system I'm trying
to use Easy Install on anyway.
Why did this not show up any where else?
More to the point why did it not show up on my dev system, should be
practically identical to the system I'm trying to use Easy Install on.
Changed this initialisation line 142
ptr = msg ; to ptr = msg + 1;
seems to fix the body bug.
We have to test it.
It is possible that the dysfunctions of the messages displays
of Firefox and IE result from this useless body tag.
Fix the bug #279
if one creates a new event, its length defaults is set to an hour.
The bug at the origin of the problem - if one creates an event but
doesn't change the times from the defaut values it doesn't show up in
the day view - does not exist any more...
Uptated french translation
Dave West [Mon, 5 Nov 2007 00:03:07 +0000 (00:03 +0000)]
Changes to make notes deleteable... INCOMPLETE..
Note icon is now draggable.
Added a bit of text to act as a place holder for a trashcan object.
If a note is dragged to the trash object the note icon is hidden but the
note is not yet deleted.
Dave West [Sun, 4 Nov 2007 16:46:15 +0000 (16:46 +0000)]
Added a delete button to the Notes in place editor.
Can't for the life of me figure out how to pass a delete/save option
though.
Any help much appreciated.
Art Cancro [Sun, 4 Nov 2007 03:55:10 +0000 (03:55 +0000)]
Handle NULL data from XML parser in order to cope
with the Homeland Stupidity RSS feed, which IO deliberately
configured in such a way to crash Citadel and prove that our
parser wasn't yet ready for prime time. :)
Dave West [Sat, 3 Nov 2007 23:13:23 +0000 (23:13 +0000)]
Fix the thirty second delay properly.
Also added a watchdog timer to kill send command if it hangs at some
point due to a dodgy server.
This will prevent bug #231.
Dave West [Sat, 3 Nov 2007 22:57:56 +0000 (22:57 +0000)]
Fix thirty second delay in sendcommand when downing the server.
We can not call cleanup() as it uses CtdlIPCQuit which sends a QUIT to
the server that is no longer there and can't respond so it hangs.
If downing the server just do nq_cleanup() instead.
Art Cancro [Fri, 2 Nov 2007 13:54:36 +0000 (13:54 +0000)]
Handle 30X redirects when requesting RSS
feeds via HTTP. Also fixed a mistake in the request
headers, I had it using 'Server:' instead of 'Host:'. That's
what I get for staying up too late programming, I guess.
Art Cancro [Fri, 2 Nov 2007 04:17:45 +0000 (04:17 +0000)]
Checked in an RSS feed reader to replace the
standalone 'rss2ctdl' utility. It works. Still need
to add code to handle 302 redirects, and configuration screens.
Nocturn Bug 254 : I finally used table - not CSS - to fix the bad
shifted to the right of the fields during the edition of messages.
Dothebard : I corrected the stylesheet to avoid the complaints of the
errors console of Firefox
Art Cancro [Thu, 1 Nov 2007 19:08:25 +0000 (19:08 +0000)]
The list of existing MTA's to disable has been reduced
to include only software which is likely to have been included
as part of the operating system's default installation. We
really should not use this space as free advertisement for the
competition, especially one project in particular who is trying
to copy our ideas. I hope that particular project crashes and
burns, and the developers stranded on a deserted island with no
Internet access.
Art Cancro [Tue, 30 Oct 2007 16:20:30 +0000 (16:20 +0000)]
Removed an 'if' statement that appears to fix Bug #220.
I don't know if it creates any side effects!
In my testing it doesn't appear to, but I'd like everyone
to look at lots of different messages, particularly ones with
oddball MIME structure such as multipart within multipart,
encapsulated rfc822, etc. and see if I broke antthing.
Art Cancro [Mon, 29 Oct 2007 20:24:30 +0000 (20:24 +0000)]
Sieve GETENVELOPE - fill in a bogus envelope from
or to address if the supplied one is null, missing, or bogus.
Doesn't deliver a vacation message but it's better than
crashing.
Art Cancro [Mon, 29 Oct 2007 20:14:48 +0000 (20:14 +0000)]
Sieve GETENVELOPE - fill in a bogus envelope from
or to address if the supplied one is null, missing, or bogus.
Doesn't deliver a vacation message but it's better than
crashing.