]>
code.citadel.org Git - citadel.git/log
Art Cancro [Tue, 5 Apr 2011 18:32:13 +0000 (14:32 -0400)]
Reset run_queue_now back to 0 after a forced run of the SMTP queue.
Otherwise we continue to retry every message every minute, and that is bad.
Art Cancro [Wed, 23 Feb 2011 16:41:12 +0000 (11:41 -0500)]
Fixed incorrect byte count when writing XML entity references
(cherry picked from commit
77fc8e79ee0edb8b4b67fc4dcb3ed1b32381cb52 )
Art Cancro [Tue, 22 Feb 2011 23:35:33 +0000 (18:35 -0500)]
Backported XML export fixes from master
Art Cancro [Tue, 22 Feb 2011 22:43:11 +0000 (17:43 -0500)]
Sanitize v_seen and v_answered during export
(cherry picked from commit
eeda2be5a606771a06a74cca7705f4a7ec12c7fa )
Art Cancro [Tue, 22 Feb 2011 21:06:36 +0000 (16:06 -0500)]
Escape single and double quotes in export format
(cherry picked from commit
cbd9bcf9a70f48fbb6d85b0a8eab837ebe1838ce )
Art Cancro [Tue, 22 Feb 2011 23:33:15 +0000 (18:33 -0500)]
Art Cancro [Fri, 18 Feb 2011 16:20:52 +0000 (11:20 -0500)]
Enable XMPP over TLS
Wilfried Goesgens [Sat, 12 Feb 2011 13:43:21 +0000 (14:43 +0100)]
free the context on that exit place too.
Wilfried Goesgens [Sat, 12 Feb 2011 13:15:29 +0000 (14:15 +0100)]
Memleak: free the context on abort too.
Wilfried Goesgens [Sun, 6 Feb 2011 19:31:01 +0000 (20:31 +0100)]
Wilfried Goesgens [Sun, 30 Jan 2011 10:00:47 +0000 (11:00 +0100)]
By jimcuclamath: set maxium allowed password length to the length of the buffer we read into.
Wilfried Goesgens [Sat, 15 Jan 2011 17:47:03 +0000 (18:47 +0100)]
use the gnu format string checker for CtdlLogPrintf; fix associated new warnings / problems.
Wilfried Goesgens [Sat, 15 Jan 2011 13:05:54 +0000 (14:05 +0100)]
apply memset-0 fix here too.
Wilfried Goesgens [Sat, 15 Jan 2011 13:05:21 +0000 (14:05 +0100)]
SMTP-Bouncing: don't put message body on wrong Citadel-Message-field.
Art Cancro [Tue, 11 Jan 2011 03:59:15 +0000 (22:59 -0500)]
Wiki revs now work again - replaced --global-reject-file with -r
Wilfried Goesgens [Sat, 8 Jan 2011 09:06:13 +0000 (10:06 +0100)]
THIS IS 7.85
Art Cancro [Mon, 3 Jan 2011 16:52:25 +0000 (11:52 -0500)]
Fix hangups on binary blob reads from webcit stable
Wilfried Goesgens [Tue, 21 Dec 2010 17:06:07 +0000 (18:06 +0100)]
Fix bug in SMTP-Client to send two < in the envelope sender, which will probably result in bounces/rejects.
Art Cancro [Tue, 21 Dec 2010 03:23:49 +0000 (22:23 -0500)]
update version number in preparation for 7.85 release
Art Cancro [Mon, 20 Dec 2010 04:22:05 +0000 (23:22 -0500)]
Replaced client_read() with socket_read_blob() in serv_network.c
Art Cancro [Fri, 17 Dec 2010 19:21:03 +0000 (14:21 -0500)]
Wilfried Goesgens [Mon, 13 Dec 2010 17:23:31 +0000 (18:23 +0100)]
SMTP Async I/O:
- while sending data, wait relative to the size of the mail /128 + a minimal set of 50.
Wilfried Goesgens [Tue, 14 Dec 2010 00:48:14 +0000 (01:48 +0100)]
MimeParser Rewrite: add test to revalidate the results of the rewrite to the stable mimeparser.
Wilfried Goesgens [Sun, 21 Nov 2010 15:34:16 +0000 (16:34 +0100)]
Relax SMTP Client timeout settings as discussed.
- default is 30 seconds
- Server greeting 90 seconds (DNS lookups for RBLs might be slow
- Server sending the response to the EOM sequence; here we might have background processing like virus or spam scanning that wants to finish before finaly accepting the message.
Wilfried Goesgens [Sat, 6 Nov 2010 11:18:23 +0000 (12:18 +0100)]
Nonblocking sockets need to select while writing
we changed the SMTP outbound connections to be nonblocking so we could abort on not reacting SMTP-Servers.
thus we need to select before writing, else the connection will fail.
Wilfried Goesgens [Sat, 6 Nov 2010 12:51:41 +0000 (13:51 +0100)]
have flexible timouts while reading lines in our client mode connections
since some mailserver take a little longer to finish reading mails we need to wait after we send our '.\r\n'; its 90 seconds now, all other parts will wait 5s, quit will wait 1 second.
Wilfried Goesgens [Tue, 9 Nov 2010 00:29:50 +0000 (01:29 +0100)]
check whether the sorting algorithm specified via BSTRs is intended for us before using its groupchange detector.
Wilfried Goesgens [Sun, 14 Nov 2010 22:10:57 +0000 (23:10 +0100)]
Memleak: free the roomlist of the sieve-queued rooms on exit; other tiny leaks.
Wilfried Goesgens [Mon, 15 Nov 2010 11:41:55 +0000 (12:41 +0100)]
smtp_do_bounce(): don't loose msg['A'] when overwriting its content.
Wilfried Goesgens [Mon, 15 Nov 2010 11:46:17 +0000 (12:46 +0100)]
Memleak: CtdlMakeMessage(): don't forget about the original author.
Wilfried Goesgens [Mon, 15 Nov 2010 13:43:50 +0000 (14:43 +0100)]
Memleak: post_message(): don't forget about the recipient buffer.
Wilfried Goesgens [Tue, 16 Nov 2010 21:36:38 +0000 (22:36 +0100)]
Don't send identity header if we want to do gzip compression
Propfind replies send 'Content-encoding: identity' right now, which is superseeded by the frameworks 'Content-encoding: gzip' in case of the client indicates this.
sending that headers twice has uncertain results depending on the client; while the RFC demands to evaluate the later, some fail to read our reply then.
Wilfried Goesgens [Wed, 10 Nov 2010 19:22:16 +0000 (20:22 +0100)]
fix buffer overrun while converting charsets
* DecodeSegment() didn't check whether one of the temporary buffers would be able to bear the transcoding results
Wilfried Goesgens [Thu, 4 Nov 2010 19:28:27 +0000 (20:28 +0100)]
fix crash in SSL BLOB-Reading
- when diciding whether the read buffer contains more than the blob reader wants we had a wrong equation.
Wilfried Goesgens [Thu, 4 Nov 2010 23:12:50 +0000 (00:12 +0100)]
if we tell the client we're in error state, return.
if SNET would fail to open the temporary file, it would tell the client 'error' and continue to read -> hang
we now abort after reporting the error.
Wilfried Goesgens [Mon, 1 Nov 2010 09:24:51 +0000 (10:24 +0100)]
Finalize fixing of netconfig loosing incident
* need to set & check errno that tells us whether our tempfile was fresh created or already there
* remove tmpfile on error
* don't use fopen() because we can't specify the flags we need for that
* ftruncate() the tempfile at the right place
Wilfried Goesgens [Sat, 30 Oct 2010 17:54:01 +0000 (19:54 +0200)]
Prevent writing empty network configs Part II
* writenfree_spoolcontrol_file ()
- serialise into a StrBuf
- write that to a tempfile in the netconfig directory
- if we fail, abort & log error
- if we succed use rename () to replace the original config file.
Wilfried Goesgens [Sat, 30 Oct 2010 16:44:15 +0000 (18:44 +0200)]
* cmd_snet: make shure the target FS has enough space for the new config
- Create our own filename insteaf of using mk*tmp*; CC->cs_pid should be uniq.; we use O_CREAT|O_EXCL so we're shure its ours or fails.
- Create that filename in the same directory as the filal config filename; by that we can be shure its in the same filesystem, and if thats full, we will fail
- Stat the original file for sise (if not there assume 80) and write twice as much into that file so we're next to shure the content from the client will fit in
- the citadel protocol is a little st00pit here, we don't know the size in advance, and we can't return an error _after_ accepting the file
- instead of moving the content of the tempfile into the final file, we use rename() which is supposed to be atomic.
Wilfried Goesgens [Sat, 30 Oct 2010 16:43:20 +0000 (18:43 +0200)]
assoc_file_name(): return length of string
Wilfried Goesgens [Tue, 26 Oct 2010 19:34:32 +0000 (21:34 +0200)]
* sock_getln (): CtdlSockGetLine() gives us lines without \r\n, no need to look for them again
* sock_getln_err (): add integer pointer returning the actual return state in case of error
* ml_sock_gets (): use sock_getln_err () so we can abort on impropper replies
* smtp_try (): make socket nonblocking, so we can abort on error
-> we will wait 5 seconds for the remote site to send us the SMTP-State else we will abort the connection on failure.
Wilfried Goesgens [Mon, 4 Oct 2010 22:41:35 +0000 (00:41 +0200)]
* check whether we need to QP-Encode our from in case of umlauts or so in the users realname.
Wilfried Goesgens [Mon, 4 Oct 2010 22:14:33 +0000 (00:14 +0200)]
* StrBufSanitizeEmailRecipientVector () fix another off by one
Wilfried Goesgens [Thu, 23 Sep 2010 16:20:16 +0000 (18:20 +0200)]
* the number of messages available are unequal to those in scope of the list.
Wilfried Goesgens [Thu, 23 Sep 2010 16:19:28 +0000 (18:19 +0200)]
* off by one in range checking of indexed access
Art Cancro [Mon, 20 Sep 2010 20:25:43 +0000 (16:25 -0400)]
Backport infanticide prevention patch from head
Art Cancro [Mon, 13 Sep 2010 19:19:46 +0000 (15:19 -0400)]
Fixed a race condition which made the thread pool size unnecessarily large.
Wilfried Goesgens [Mon, 13 Sep 2010 21:47:24 +0000 (23:47 +0200)]
* knrooms():
- use the right values for the type of display
- detect properly whether we need to set a default
Art Cancro [Thu, 2 Sep 2010 20:16:58 +0000 (16:16 -0400)]
Removed a few more Id tags
Wilfried Goesgens [Thu, 2 Sep 2010 19:58:22 +0000 (21:58 +0200)]
* moving directories around isn't smart in a git workingcopy. create symlinks & ignore them.
Art Cancro [Thu, 2 Sep 2010 19:39:09 +0000 (15:39 -0400)]
Removed an Id tag
Art Cancro [Thu, 2 Sep 2010 19:34:24 +0000 (15:34 -0400)]
webcit to 7.84
Art Cancro [Thu, 2 Sep 2010 19:10:29 +0000 (15:10 -0400)]
libcitadel to 7.84
Wilfried Goesgens [Thu, 2 Sep 2010 18:47:46 +0000 (20:47 +0200)]
* set 7.84 version
Wilfried Göesgens [Sat, 28 Aug 2010 13:11:01 +0000 (13:11 +0000)]
* fix GTSN not to cut seen stats at 1024 chars
(cherry picked from commit
e766e2c6d4bfa8ebce17ca3039963a3761fd3e8f )
Wilfried Göesgens [Sat, 28 Aug 2010 13:10:50 +0000 (13:10 +0000)]
* do typedef the visit struct, remove all those 'struct' statements from all over the source
(cherry picked from commit
63262a64633e72e4096aaeedda6950c02fb4d990 )
Wilfried Göesgens [Sun, 29 Aug 2010 16:55:50 +0000 (16:55 +0000)]
* print name of context instead of number into the error message.
(cherry picked from commit
3c4dab06dfa7658653d7aca0a4025a8c35dcc3bb )
Wilfried Göesgens [Sun, 29 Aug 2010 16:55:55 +0000 (16:55 +0000)]
* substracting independend pointers with no conjunction gives mad numbers. thanks samjam for pointing that out.
(cherry picked from commit
7be3fa3266788de371f7ba1c1bc0d701b0080a26 )
Wilfried Göesgens [Sun, 29 Aug 2010 22:00:28 +0000 (22:00 +0000)]
* output what we're sending into the BIGBAD_IODBG too.
(cherry picked from commit
e6116200be29b3c203a3aa047eadf43245475bed )
Wilfried Goesgens [Tue, 31 Aug 2010 17:58:14 +0000 (19:58 +0200)]
* client_read_sslblob(): fix buffer handling, clean up the read-buffer if neccesary.
(cherry picked from commit
d91993b02381c683f14bfc6f45476c68ef45662a )
Art Cancro [Wed, 1 Sep 2010 16:37:38 +0000 (12:37 -0400)]
Oops, my svn/git autodetection logic is still broken. Fixed.
(cherry picked from commit
ea36c3b92b59412eb3d74ab248f2c371d254dc06 )
Art Cancro [Wed, 1 Sep 2010 13:49:36 +0000 (09:49 -0400)]
Yet another attempt at pushing my citadel/scripts/mk_svn_revision.sh changes to the stable-78x branch
Art Cancro [Fri, 27 Aug 2010 18:37:59 +0000 (18:37 +0000)]
* One more change to the recent header folding bugfix
Art Cancro [Thu, 26 Aug 2010 02:35:36 +0000 (02:35 +0000)]
* Fixed a wrap bug in convert_internet_message()
* This also is backported to stable, which is now 7.84
Wilfried Göesgens [Wed, 11 Aug 2010 11:15:32 +0000 (11:15 +0000)]
* GetRoomListHashLKRA(): just send a command if we're going to read the reply.
Art Cancro [Mon, 2 Aug 2010 15:09:20 +0000 (15:09 +0000)]
*** r8756 IS 7.83 ***
Wilfried Göesgens [Wed, 28 Jul 2010 22:19:41 +0000 (22:19 +0000)]
* display_shutdown(): fix template reference
Wilfried Göesgens [Wed, 28 Jul 2010 22:19:31 +0000 (22:19 +0000)]
* StrBufSanitizeEmailRecipientVector() fix bug cutting one of the email address
Art Cancro [Wed, 28 Jul 2010 21:27:42 +0000 (21:27 +0000)]
* All components of both stable and trunk noted as version 7.83
Art Cancro [Wed, 28 Jul 2010 03:06:12 +0000 (03:06 +0000)]
* When outputting legacy Citadel format messages, stop only when we reach a 0x00 byte, not when we reach any weird character.
Wilfried Göesgens [Tue, 27 Jul 2010 20:03:02 +0000 (20:03 +0000)]
* ctdl_internal_thread_func(): just use SYS_gettid if the system provides it. thit fixes the BSD build.
Art Cancro [Mon, 26 Jul 2010 20:28:52 +0000 (20:28 +0000)]
* Backport the important part of r8717 to stable. I forgot I did this on Friday. When running EVT_TIMER hooks from the housekeeping loop, do citthread_setspecific(MyConKey, NULL); before running *each* hook. Some of the hooks are setting MyConKey and then leaving it set. This is bad and causes crasheriferous behavior. This change should fix it.
Wilfried Göesgens [Mon, 26 Jul 2010 06:08:06 +0000 (06:08 +0000)]
Fix IMAP-List command
* imap_is_message_set (): here we have more abort conditions, which we need to put into account when drawing our final result
Wilfried Göesgens [Sun, 25 Jul 2010 15:40:12 +0000 (15:40 +0000)]
* StrBufDecodeBase64(): init output buffer so in case of an empty / illegal base64 string its defined.
Wilfried Göesgens [Sat, 24 Jul 2010 10:30:45 +0000 (10:30 +0000)]
* StrBufSanitizeEmailRecipientVector () fix null pointer accesses
Art Cancro [Thu, 22 Jul 2010 16:10:10 +0000 (16:10 +0000)]
*** CITADEL 7.82 RELEASE IS r8707 ***
Art Cancro [Thu, 22 Jul 2010 14:50:41 +0000 (14:50 +0000)]
* Backport r8705 to stable
Art Cancro [Wed, 21 Jul 2010 17:37:10 +0000 (17:37 +0000)]
* Version number to 782. NOT A RELEASE
Art Cancro [Wed, 21 Jul 2010 16:56:29 +0000 (16:56 +0000)]
* imap_load_part() is expecting the desired_section to be a char*, not a ChrPtr. Fixed. This probably fixes Alpine. Also backported to stable.
Art Cancro [Wed, 21 Jul 2010 16:50:53 +0000 (16:50 +0000)]
* indentation fix
Art Cancro [Wed, 21 Jul 2010 16:49:24 +0000 (16:49 +0000)]
* Fix a bug that caused a logging problem but did not affect protocol behavior
Art Cancro [Wed, 21 Jul 2010 16:39:48 +0000 (16:39 +0000)]
* Backport r8699 to stable
Wilfried Göesgens [Tue, 20 Jul 2010 20:26:42 +0000 (20:26 +0000)]
* if no version is to be found, and a ready made revision file is already there, don't create a new one.
Art Cancro [Tue, 20 Jul 2010 20:02:28 +0000 (20:02 +0000)]
*** THIS IS 7.81 ***
Art Cancro [Tue, 20 Jul 2010 19:46:38 +0000 (19:46 +0000)]
* Internal version numbers to 7.81
Wilfried Göesgens [Tue, 20 Jul 2010 18:37:30 +0000 (18:37 +0000)]
* Open 7.80 stable branch
Wilfried Göesgens [Tue, 20 Jul 2010 17:12:35 +0000 (17:12 +0000)]
* remove -finline-functions; it breaks the ubuntu build.
Wilfried Göesgens [Mon, 19 Jul 2010 21:20:17 +0000 (21:20 +0000)]
* update debian changelog.
Wilfried Göesgens [Mon, 19 Jul 2010 21:12:12 +0000 (21:12 +0000)]
* remove url-encoded strings; the Engine is advised to do that, so let it do its job.
Wilfried Göesgens [Mon, 19 Jul 2010 20:56:54 +0000 (20:56 +0000)]
* duplicate memreadline & bmstrcasestr to a const and non const version
* follow changes in citserver where appropriate.
Wilfried Göesgens [Mon, 19 Jul 2010 20:37:19 +0000 (20:37 +0000)]
* InitModule_MSGRENDERERS(): don't make citserver send us RFC822 messages inline via MSGP; fixes the Booboo helper mail bug.
Art Cancro [Thu, 15 Jul 2010 16:59:03 +0000 (16:59 +0000)]
* Removed the last instance if is_room_aide
Wilfried Göesgens [Wed, 14 Jul 2010 22:23:18 +0000 (22:23 +0000)]
* remove is_room_aide, its not filled anymore.
* instead of is_room_aide evaluate room->RAFlags & UA_ADMINALLOWED
Art Cancro [Wed, 14 Jul 2010 19:44:35 +0000 (19:44 +0000)]
* THIS IS 7.80
Art Cancro [Wed, 14 Jul 2010 15:09:35 +0000 (15:09 +0000)]
* Locked the banner div at top:0 to keep Google Chrome from floating it out of place
Art Cancro [Tue, 13 Jul 2010 23:04:39 +0000 (23:04 +0000)]
* Fix overflow behavior on small displays for login and logout pages.
Art Cancro [Tue, 13 Jul 2010 18:08:33 +0000 (18:08 +0000)]
* Changed the room banner layout back to a table. Say what you want about table based layouts but THEY WORK.
Art Cancro [Mon, 12 Jul 2010 21:21:58 +0000 (21:21 +0000)]
* Fixed appearance bugs in the CSS bubble tooltips in IE.
Wilfried Göesgens [Mon, 12 Jul 2010 17:33:43 +0000 (17:33 +0000)]
* entroom (): if we're aide or room-aide, we may view the edit screen, else just enter the room as we did before.
Art Cancro [Mon, 12 Jul 2010 17:16:45 +0000 (17:16 +0000)]
* Improved the thread pool logic so that we don't end up creating dozens of extra worker threads during shutdown
Wilfried Göesgens [Sun, 11 Jul 2010 22:09:08 +0000 (22:09 +0000)]
* add reply-to: header to mails sent to room list recipients