]>
code.citadel.org Git - citadel.git/log
Wilfried Goesgens [Thu, 12 Jul 2012 20:41:50 +0000 (22:41 +0200)]
URL-Handling: bugfixes
- add flag for relayisng
- when *Url is a valid pointer, preserve it to (*URL)->Next
Wilfried Goesgens [Thu, 12 Jul 2012 20:23:27 +0000 (22:23 +0200)]
URL-Parser: fix parsing of Usernames with @
- we previously would use strch to find the first @ in the URL
- when there is an @ inside of the username this one would be hit.
- since we first search for the end of the host-path, we can search from the right for the last @ to separate the user:auth from the real hostname.
Wilfried Goesgens [Thu, 12 Jul 2012 20:22:52 +0000 (22:22 +0200)]
Networker: remove duplicate colon from generated URL.
Wilfried Goesgens [Thu, 12 Jul 2012 14:03:16 +0000 (16:03 +0200)]
SMTP-Queue: add information about currently processed mails
- wrap boxes around the parts of the page
- add box with a WHOLIST filtered for SYS_SMTP_Send; Now we show a list of currently active outbound SMTP-Connections.
Wilfried Goesgens [Thu, 12 Jul 2012 14:00:24 +0000 (16:00 +0200)]
WHOLIST: add the possibility to filter the wholist for a user.
- add a parameter to the Iterator to specify the filter string
- set this parameter to 0 in all current templates
Wilfried Goesgens [Mon, 9 Jul 2012 18:04:45 +0000 (20:04 +0200)]
WHQ: templatize editing of user; fix handling of output after edit.
Wilfried Goesgens [Mon, 9 Jul 2012 18:04:14 +0000 (20:04 +0200)]
MailQ: fix template.
Wilfried Goesgens [Mon, 9 Jul 2012 12:14:41 +0000 (14:14 +0200)]
SMTP-Queue: streamline redisplaying
- on delete, display important message, and trigger re-display of the queue
- re-add the refresh button which re-loads the page
- add ListOnly=yes to output just the table to replace not the full document.
Wilfried Goesgens [Sun, 8 Jul 2012 17:30:11 +0000 (19:30 +0200)]
ImportantMessage: flush on session detach, not on first print; else we might not have it for later use.
Wilfried Goesgens [Sun, 8 Jul 2012 17:14:00 +0000 (19:14 +0200)]
fix comment tag
Wilfried Goesgens [Sun, 8 Jul 2012 16:50:49 +0000 (18:50 +0200)]
WHO: style cleanup; add missing divs.
Wilfried Goesgens [Sun, 8 Jul 2012 16:30:22 +0000 (18:30 +0200)]
who's online display: fix periodical updates
Wilfried Goesgens [Sun, 8 Jul 2012 15:02:58 +0000 (17:02 +0200)]
NETWORKER: don't report an error if the rome site tells us we're already on their NTT list.
Art Cancro [Wed, 4 Jul 2012 16:26:39 +0000 (12:26 -0400)]
new server command 'stat' to return name and mtime of current room
Wilfried Goesgens [Tue, 3 Jul 2012 22:41:10 +0000 (00:41 +0200)]
Call libcitadel init
Wilfried Goesgens [Tue, 3 Jul 2012 20:24:01 +0000 (22:24 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Tue, 3 Jul 2012 20:22:56 +0000 (22:22 +0200)]
EVENT-Client: fix the abort routines when we wake up and just get zero bytes.
Art Cancro [Tue, 3 Jul 2012 14:53:42 +0000 (10:53 -0400)]
Clarified an unclear warning message
Wilfried Goesgens [Mon, 2 Jul 2012 23:00:53 +0000 (01:00 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Mon, 2 Jul 2012 23:00:34 +0000 (01:00 +0200)]
Netspool: fix implementation specific details
- when not running in splice mode (or with older kernels...) moving the filepointer to the file end has wastes further atempts to read from it; since there is no lrewind, use fstat instead.
Wilfried Goesgens [Mon, 2 Jul 2012 22:57:25 +0000 (00:57 +0200)]
FDIO: make splice runtime optional
- splice tends to break. let the choice to the admin to enable it. Default to stable copying shit to userspace back and forth.
Art Cancro [Mon, 2 Jul 2012 20:55:48 +0000 (16:55 -0400)]
Include QRmtime in the list of values returned by GOTO
Art Cancro [Mon, 2 Jul 2012 20:52:21 +0000 (16:52 -0400)]
Updated the copyright declaration in several modules, removing any language which encourages the reader to contact the FSF. Our GPL is open source, not free software.
Art Cancro [Mon, 2 Jul 2012 20:48:09 +0000 (16:48 -0400)]
Updated the copyright declaration in several modules, removing any language which encourages the reader to contact the FSF. Our GPL is open source, not free software.
Art Cancro [Mon, 2 Jul 2012 20:42:00 +0000 (16:42 -0400)]
style
Wilfried Goesgens [Mon, 2 Jul 2012 19:55:35 +0000 (21:55 +0200)]
POP3Client: Log the Hostname, not sensitive information.
Wilfried Goesgens [Mon, 2 Jul 2012 19:09:26 +0000 (21:09 +0200)]
POP3Client: Check pointer before accessing it
Wilfried Goesgens [Sun, 1 Jul 2012 09:48:19 +0000 (11:48 +0200)]
Sharing: add NSYN
- expose the NSYN command to the webcit room sharing interface.
Wilfried Goesgens [Sun, 1 Jul 2012 09:32:33 +0000 (11:32 +0200)]
Add null-check before access.
Wilfried Goesgens [Sun, 1 Jul 2012 09:29:49 +0000 (11:29 +0200)]
Sharing: swap sequence to reduce warnings.
Wilfried Goesgens [Sun, 1 Jul 2012 09:29:20 +0000 (11:29 +0200)]
Room Edit: add missing closing div
Wilfried Goesgens [Sun, 1 Jul 2012 09:28:55 +0000 (11:28 +0200)]
Tidy: remove trailing / which makes all the rest barf
Wilfried Goesgens [Sun, 1 Jul 2012 09:03:07 +0000 (11:03 +0200)]
Roomedit - Sharing: remove lines unneeded
- add portable function to find & remove a section
- call that function instead of doing it in place.
- there is no input=input, its input=text
Wilfried Goesgens [Sun, 1 Jul 2012 09:01:27 +0000 (11:01 +0200)]
Roomedit - Sharing: swap layout
- if we change the sequence the tables appear, removing columns work.
- split i18n text so there is no html inside.
Wilfried Goesgens [Sun, 1 Jul 2012 08:59:53 +0000 (10:59 +0200)]
QueueView: use right end conditional
Wilfried Goesgens [Sat, 30 Jun 2012 14:37:30 +0000 (16:37 +0200)]
Important message: remove debug blurb
Wilfried Goesgens [Sat, 30 Jun 2012 14:35:39 +0000 (16:35 +0200)]
SMTPQueue: add ability to rerun the queue
- to protect the user from himself force him to read the hint text before actualy triggering SMTP runqueue
- add the status of the runqueue to the important message to give feedback to the user.
Wilfried Goesgens [Sat, 30 Jun 2012 14:33:31 +0000 (16:33 +0200)]
SMTPQueue: fix layout, add missing /div
Wilfried Goesgens [Sat, 30 Jun 2012 14:32:58 +0000 (16:32 +0200)]
Layout: allways add div for important message
- if something special arizes, we show the important_message mechanism.
- this div so far is only added, if there is something to show.
- in order to display events at runtime (from ajax replies) we now add it always.
- hide it if it should be empty
- only add the autohide-trigger if its shown.
Wilfried Goesgens [Sat, 30 Jun 2012 12:21:42 +0000 (14:21 +0200)]
Add define for mailq-view
Art Cancro [Tue, 26 Jun 2012 14:51:02 +0000 (10:51 -0400)]
changing internal version number to 8.12
Wilfried Goesgens [Sun, 24 Jun 2012 10:31:24 +0000 (12:31 +0200)]
NetQueue: make logging runtime configurable; add context.
Wilfried Goesgens [Sat, 23 Jun 2012 09:19:06 +0000 (11:19 +0200)]
NSYN: fix choosing of remote party.
Wilfried Goesgens [Fri, 22 Jun 2012 21:28:52 +0000 (23:28 +0200)]
MODULES: add priorities in execution
- specialy the EV_TIMER callbacks were suffering from wrong order execution which caused bad behaviours:
- network queueing now is executed before mail queue handling -> mailinglist posts are sent in < 60s instead of < 120s as before
- network spool consolidation is done before running the citadel networkers; that way the NTT-list won't be locked by running networkers
Wilfried Goesgens [Fri, 22 Jun 2012 18:58:57 +0000 (20:58 +0200)]
NetworkClient: fix filedescriptor leaks
- in all cases where we're done with the spoolfile we need to close its handle & flush the FDIO buffer if already alloc'd
Wilfried Goesgens [Tue, 19 Jun 2012 21:50:21 +0000 (23:50 +0200)]
EVENT Client: parametrize when to close the fd on detach or not
- we shouldn't close our FD if we want to continue using it later on after doing i.e. database io.
Wilfried Goesgens [Tue, 19 Jun 2012 21:44:55 +0000 (23:44 +0200)]
POP3Client: fix logging
- add final statistic statement with count
- remove uber-verbose log-statements
- make the rest of the logging configurable.
Wilfried Goesgens [Sat, 16 Jun 2012 08:49:08 +0000 (10:49 +0200)]
EVENT-Client: don't call the timeout function directly
- if we call the timeout function directly we might find upper stackframes which rely on the event-context still being valid. Thus we rather set a timeout of 0.0 which then calls the timeout function and kills the context.
Wilfried Goesgens [Fri, 15 Jun 2012 18:03:58 +0000 (20:03 +0200)]
EVENTClient: rather use the FD found on our internal structures then searching it on the watcher struct; its not allways there.
Wilfried Goesgens [Thu, 14 Jun 2012 22:06:26 +0000 (00:06 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Thu, 14 Jun 2012 22:05:21 +0000 (00:05 +0200)]
serv_read_binary(): abort if the server status returns anything else then 6xx
Wilfried Goesgens [Thu, 14 Jun 2012 22:04:27 +0000 (00:04 +0200)]
cmd_read(): fseek just returns 0 on success, not the current offset.
Art Cancro [Thu, 14 Jun 2012 21:04:41 +0000 (17:04 -0400)]
remove duplicate definition in it.po
Wilfried Goesgens [Wed, 13 Jun 2012 22:56:13 +0000 (00:56 +0200)]
NSYN: adjust to new semantics
- load stuff we need to properly decide whether to spool files or not.
Wilfried Goesgens [Wed, 13 Jun 2012 22:53:07 +0000 (00:53 +0200)]
Networkespool: use FileMoveChunked(); since the others won't read or won't write with offset.
Wilfried Goesgens [Wed, 13 Jun 2012 22:51:21 +0000 (00:51 +0200)]
Add FileMoveChunked(); which can read and write with offsets.
Wilfried Goesgens [Tue, 12 Jun 2012 21:19:14 +0000 (23:19 +0200)]
EVENT: when handling errors EAGAIN isn't fatal.
Wilfried Goesgens [Tue, 12 Jun 2012 21:18:02 +0000 (23:18 +0200)]
CURL: just call init once.
Wilfried Goesgens [Mon, 11 Jun 2012 20:25:00 +0000 (22:25 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Mon, 11 Jun 2012 20:24:13 +0000 (22:24 +0200)]
SMTP-Client: fix target port handling for relay & fallback hosts
Wilfried Goesgens [Mon, 11 Jun 2012 08:48:23 +0000 (10:48 +0200)]
Use right size value as input for splice.
Wilfried Goesgens [Sun, 10 Jun 2012 15:16:14 +0000 (17:16 +0200)]
Networkclient: opend spoolfile with proper flags for splice(); fix some minor stability issues
Wilfried Goesgens [Sun, 10 Jun 2012 15:12:58 +0000 (17:12 +0200)]
FileSendChunked(): replace sendfile by splice()
FileSendChunked+FileRecvChunked: handle situations in which the first splice reads more then the second can send.
Wilfried Goesgens [Sun, 10 Jun 2012 14:08:46 +0000 (16:08 +0200)]
NETP: extract password string when we need it. else it might be overwritten meanwhile.
Wilfried Goesgens [Sun, 10 Jun 2012 13:54:47 +0000 (15:54 +0200)]
networker: use the right char buffer for the password.
Wilfried Goesgens [Sun, 10 Jun 2012 12:49:09 +0000 (14:49 +0200)]
Networker: Follow changes of networking infrastructure in the networker client
Wilfried Goesgens [Sun, 10 Jun 2012 12:47:29 +0000 (14:47 +0200)]
Networker: also register STOP hook, so if sessions are timed out or killed the NTT-List is cleaned up.
Wilfried Goesgens [Sun, 10 Jun 2012 10:38:30 +0000 (12:38 +0200)]
Rework networker
- keep netconfigs in hash; create the usual deserialize/delete/... functions
- keep the netmap in hash; create the usual de/serialize/delete/... functions
- change sequence: serialize & save netmap; combine spoolfiles; free netmap.
- use strbufs splice() wrappers to combine the message-spoolfiles into host-spoolfiles instead of forking a shell & running cat + rm
- when appending to host-spoolfile fails, remove partial adds to avoid creating invalid spool control files
- only cleanup spool directory if we successfully combined all files; else we might loose messages if i.e. a networker is running for that node.
Wilfried Goesgens [Sun, 10 Jun 2012 08:33:10 +0000 (10:33 +0200)]
StrBufExtract_tokenFromStr: add wrapper around StrBufExtract_token() which takes a char* as string to de-tokenize.
Wilfried Goesgens [Sat, 9 Jun 2012 13:02:17 +0000 (15:02 +0200)]
READ: sanitize values & output errors on invalid parameters.
Wilfried Goesgens [Sat, 9 Jun 2012 12:56:41 +0000 (14:56 +0200)]
WRIT: catch silly send size values.
Art Cancro [Wed, 6 Jun 2012 22:06:02 +0000 (18:06 -0400)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Wed, 6 Jun 2012 22:05:57 +0000 (18:05 -0400)]
Field 'K' is now 'rep2=' in the citadel headers
Wilfried Goesgens [Tue, 5 Jun 2012 18:54:35 +0000 (20:54 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Tue, 5 Jun 2012 18:53:34 +0000 (20:53 +0200)]
SMTP-Client: Remove concurrency check; its done in do_housekeeping()
Wilfried Goesgens [Tue, 5 Jun 2012 18:52:25 +0000 (20:52 +0200)]
housekeeping: time() is expensive. don't use it inside a mutex.
Art Cancro [Tue, 5 Jun 2012 14:23:24 +0000 (10:23 -0400)]
Updated the comments in serv_smtp.c to reflect that it is strictly a server now.
Art Cancro [Mon, 4 Jun 2012 23:03:48 +0000 (19:03 -0400)]
Added an IDEN code for our z-push backend
Wilfried Goesgens [Mon, 4 Jun 2012 21:58:30 +0000 (23:58 +0200)]
Resync with launchpad translations
Wilfried Goesgens [Mon, 4 Jun 2012 21:25:16 +0000 (23:25 +0200)]
update french translation for setup as proposed by debian bug#672747
tnx Nicolas Delvaux & David Prévot
Wilfried Goesgens [Mon, 4 Jun 2012 21:04:20 +0000 (23:04 +0200)]
configure: check for splice() system call; sendfile isn't all apropriate in older linux or debian k/freebsd
Wilfried Goesgens [Mon, 4 Jun 2012 17:29:27 +0000 (19:29 +0200)]
MessageView: don't expose the user to json syntax.
Wilfried Goesgens [Sun, 3 Jun 2012 15:44:09 +0000 (17:44 +0200)]
RSSClient: stop curl watchers on emergency shutdown.
Wilfried Goesgens [Sun, 3 Jun 2012 13:40:00 +0000 (15:40 +0200)]
DeleteSmtpOutMsg(): we don't have a Queu-Item anymore; we can't log its id.
Wilfried Goesgens [Sun, 3 Jun 2012 12:41:38 +0000 (14:41 +0200)]
one more null-check
Wilfried Goesgens [Fri, 1 Jun 2012 18:55:57 +0000 (20:55 +0200)]
fix networker hickup
- refrain from freeing pointers in functions that don't get double pointers and NULL them afterwards
- call network_consolidate_spoolout () before writing & free'ing the network.
Wilfried Goesgens [Thu, 31 May 2012 22:37:47 +0000 (00:37 +0200)]
remove unneeded assignment
Wilfried Goesgens [Thu, 31 May 2012 22:37:10 +0000 (00:37 +0200)]
fix the rest of the unregister functions
Wilfried Goesgens [Thu, 31 May 2012 22:36:41 +0000 (00:36 +0200)]
remove double initialization
Wilfried Goesgens [Thu, 31 May 2012 22:35:39 +0000 (00:35 +0200)]
add some more NULL-pointer-checks; free allocated mem in case of OOM.
Wilfried Goesgens [Thu, 31 May 2012 21:43:32 +0000 (23:43 +0200)]
when failing by OOM, don't loose any more memory.
Wilfried Goesgens [Tue, 29 May 2012 21:42:30 +0000 (23:42 +0200)]
Hash: forgot to include some lines into the #if DEBUG
Wilfried Goesgens [Tue, 29 May 2012 21:31:31 +0000 (23:31 +0200)]
locate_host: initialize hostname buffer so we don't send bullshit to the session identifier.
Wilfried Goesgens [Sat, 26 May 2012 13:57:58 +0000 (15:57 +0200)]
allocate the buffer we use later on in all cases.
Wilfried Goesgens [Sat, 26 May 2012 13:54:38 +0000 (15:54 +0200)]
remove unneded assignmnet.
Wilfried Goesgens [Sat, 26 May 2012 13:53:36 +0000 (15:53 +0200)]
add some nullpointer checks.
Wilfried Goesgens [Sat, 26 May 2012 13:35:12 +0000 (15:35 +0200)]
remove unneeded assignment.
Wilfried Goesgens [Sat, 26 May 2012 13:32:11 +0000 (15:32 +0200)]
dbg_PrintHash(): #ifdef DEBUG everything related to pure verbose debugging.
Wilfried Goesgens [Sat, 26 May 2012 13:26:55 +0000 (15:26 +0200)]
remove duplicate assignments; don't compare twice if first is successfull.
Wilfried Goesgens [Sat, 26 May 2012 13:21:47 +0000 (15:21 +0200)]
remove unneeded assignment.