]>
code.citadel.org Git - citadel.git/log
Art Cancro [Fri, 26 Aug 2011 17:03:57 +0000 (13:03 -0400)]
Make use of XML_StopParser() when XML_MAJOR_VERSION is >1, not >2. Thanks to Stefan for the bugfix.
Art Cancro [Fri, 26 Aug 2011 14:17:03 +0000 (10:17 -0400)]
Removed references to Subversion in the code
Art Cancro [Thu, 25 Aug 2011 21:28:18 +0000 (17:28 -0400)]
Fixed the remaining bugs that kept Drafts from working properly
Art Cancro [Thu, 25 Aug 2011 21:07:58 +0000 (17:07 -0400)]
Test commit
Art Cancro [Thu, 25 Aug 2011 20:02:40 +0000 (16:02 -0400)]
Cleanup of code path for handling message submit errors
Art Cancro [Thu, 25 Aug 2011 19:51:13 +0000 (15:51 -0400)]
Submitting a message and getting back a 550 from the server now results in an error message instead of a blank page.
Art Cancro [Thu, 25 Aug 2011 19:33:48 +0000 (15:33 -0400)]
Changed save_to_drafts to saving_to_drafts for clarity
Art Cancro [Wed, 24 Aug 2011 21:56:24 +0000 (17:56 -0400)]
Noted with a comment where we need to handle ENT0 errors
Art Cancro [Wed, 24 Aug 2011 21:12:03 +0000 (17:12 -0400)]
Only offer the 'Edit' option in mailbox rooms. Elsewhere it does not make sense.
Art Cancro [Wed, 24 Aug 2011 21:06:27 +0000 (17:06 -0400)]
If user clicks in the empty part of a mailbox view, display a blank pane instead of an error.
Art Cancro [Tue, 23 Aug 2011 21:13:09 +0000 (17:13 -0400)]
More 'greeking' the test mime data.
Art Cancro [Tue, 23 Aug 2011 20:57:11 +0000 (16:57 -0400)]
Began 'greeking' the test mime data.
Art Cancro [Mon, 22 Aug 2011 18:18:37 +0000 (14:18 -0400)]
Set all version numbers to 8.00 -- FEATURE FREEZE FOR 8.00
Art Cancro [Mon, 22 Aug 2011 17:20:04 +0000 (13:20 -0400)]
Added a checked and disabled dummy option in the room access tab, indicating that blog creators automatically become room aides.
This advises administrators of a built-in behavior, and also exposes a string to the translators so that its localization will already exist if we add that option later.
Art Cancro [Mon, 22 Aug 2011 17:07:12 +0000 (13:07 -0400)]
Blog owners automatically become room aides of their blogs.
(In the future we will offer a site-wide configuration setting to suppress this behavior.)
Wilfried Goesgens [Sat, 20 Aug 2011 11:58:57 +0000 (11:58 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sat, 20 Aug 2011 11:58:14 +0000 (11:58 +0000)]
QP-Encode questionmarks.
Wilfried Goesgens [Sat, 20 Aug 2011 09:50:26 +0000 (09:50 +0000)]
When QP encoding, we need to convert blanks to underscores
- Spamassasin test 'BAD_ENC_HEADER' matches if a subject looks like that:
Subject: =?UTF-8?Q?=5Btestml=5D l=C3=B6sch misch ey.?=
it needs to look like that:
Subject: =?UTF-8?Q?=5Btestml=5D_l=C3=B6sch_misch_ey.?=
Art Cancro [Fri, 19 Aug 2011 19:12:50 +0000 (15:12 -0400)]
Clear selected_language when marking a guest session as inuse=0.
This prevents new visitors from seeing their first page in Chinese after Baidu comes calling.
Wilfried Goesgens [Fri, 19 Aug 2011 17:17:31 +0000 (17:17 +0000)]
add missing var definition *ups*
Wilfried Goesgens [Fri, 19 Aug 2011 17:12:32 +0000 (17:12 +0000)]
Fix detecting of UTF8 Sequences
- we need to exactly check for both highest bits to be set, not one of them.
Wilfried Goesgens [Fri, 19 Aug 2011 16:43:30 +0000 (16:43 +0000)]
fix counting of UTF8-charwidth
- Ctdl_GetUtf8SequenceLength(): testbyte needs to be unsigned char, else >> will shift us new bits in from the left
- we need to shift 'test' to the right
- start counting at 0
Wilfried Goesgens [Sun, 3 Jul 2011 13:47:55 +0000 (13:47 +0000)]
Add ability to hex encode binary strings
- when encoding plain md5 binary buffers we have to pass the length into the hex encoder, add parameter
- add wrapper providing old schematic
- fix documentation of StrBufSipLine()
Wilfried Goesgens [Thu, 18 Aug 2011 18:18:38 +0000 (18:18 +0000)]
fix StrHtmlEcmaEscAppend, StrECMAEscAppend
- StrHtmlEcmaEscAppend(): reimplement 'nbsp' - handling
- StrECMAEscAppend(): copy over required stuff from StrHtmlEcmaEscAppend()
Wilfried Goesgens [Thu, 18 Aug 2011 17:53:18 +0000 (17:53 +0000)]
Fix StrHtmlEcmaEscAppend() more edge cases in utf8 handling
- Ctdl_GetUtf8SequenceLength(): return 0 for broken, 1 for non-utf8 sequences
- StrHtmlEcmaEscAppend(): another attempt to fix json appending:
- use switch instead of Rumpelstilskin if sequence
- use HKEY for our static sequences
- don't check for buffer expansion again while utf8-handling; we have 11 bytes reserved, utf8 will at most become 6 bytes
- Simply handle ASCII chars in the utf8 loop
- since aptr is moved implicitely, we mustn't move it for the last byte
- add missing handling for some escapers
- let unicode escapers pass
Wilfried Goesgens [Thu, 18 Aug 2011 10:30:35 +0000 (10:30 +0000)]
Don't add brackets <> to the reply to; it should be ok without.
Wilfried Goesgens [Thu, 18 Aug 2011 10:27:54 +0000 (10:27 +0000)]
parse reply-to header into its permanent database field
it seems as if some mailers (Open exchange for example) add Reply-To headers; if we don't parse it when receiving it,
our list service adds another header; thus parse it into the database of headers.
Wilfried Goesgens [Thu, 18 Aug 2011 09:53:01 +0000 (09:53 +0000)]
fix QP encoding
- once we decided to QP encode we also need to encode = (forgotten in last commit)
Wilfried Goesgens [Thu, 18 Aug 2011 09:14:48 +0000 (09:14 +0000)]
fix QP encoding
- once we decided to QP encode we also need to encode =[]
Wilfried Goesgens [Wed, 17 Aug 2011 10:13:28 +0000 (10:13 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Wed, 17 Aug 2011 10:12:21 +0000 (10:12 +0000)]
Fix envelope-to header.
- don't output leading whitespace
- don't output it at all if there is just whitespace inside.
Art Cancro [Tue, 16 Aug 2011 19:55:15 +0000 (15:55 -0400)]
Fixed a bug in the 'only replies are allowed in this room' logic in ENT0 command.
Art Cancro [Tue, 16 Aug 2011 04:03:58 +0000 (00:03 -0400)]
Began working on access control changes for blog rooms.
Art Cancro [Tue, 16 Aug 2011 03:49:35 +0000 (23:49 -0400)]
Improved coding style of the complex conditionals in CtdlRoomAccess()
Wilfried Goesgens [Fri, 12 Aug 2011 15:51:14 +0000 (15:51 +0000)]
network_spool_msg() handle QP
while appending the [roomname] to the mailsubject, we have to
- de-qp the original subject
- search for the roomname
- possibly prepend '[roomame] '
- and re-qp everything.
that way we solve...
- multiple [roomname] additions in case of QP encoded subjects
- non RFC-Conformant behaviour in case of roomnames with umlauts.
Wilfried Goesgens [Fri, 12 Aug 2011 15:49:45 +0000 (15:49 +0000)]
display_enter(): handle QP encodings
- while loading several headers from the server we need to de-QP, else we will find gibberish in our...
- Subject
- recipients
Wilfried Goesgens [Thu, 4 Aug 2011 21:09:56 +0000 (21:09 +0000)]
fix all the tiny conditional problems our new checker told us about.
Wilfried Goesgens [Thu, 4 Aug 2011 20:52:11 +0000 (20:52 +0000)]
use the regular template error logging for our new endconditional checker, so we get our clean regular and detailed error messages.
Wilfried Goesgens [Thu, 4 Aug 2011 20:08:30 +0000 (20:08 +0000)]
add .silent and some echo logic to our makefiles; thanks to sECuRE for the hints.
Wilfried Goesgens [Mon, 1 Aug 2011 23:10:00 +0000 (23:10 +0000)]
after reading a template sanity check conditionals whether they're paired
Wilfried Goesgens [Sun, 31 Jul 2011 22:40:06 +0000 (22:40 +0000)]
move the rest of the places to use AppendImportantMessage() or GetServerStatusMsg()
Wilfried Goesgens [Sun, 31 Jul 2011 16:49:56 +0000 (16:49 +0000)]
ups. zero based so an off by one.
Wilfried Goesgens [Sat, 30 Jul 2011 17:59:49 +0000 (17:59 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sat, 30 Jul 2011 17:58:48 +0000 (17:58 +0000)]
Fix our problems with strings like this: "abc'def" in template token strings.
Art Cancro [Sat, 30 Jul 2011 16:27:10 +0000 (12:27 -0400)]
Permalinks for messages in BBS rooms
Wilfried Goesgens [Sat, 30 Jul 2011 16:23:32 +0000 (16:23 +0000)]
check template token name for invalid chars; that way we find ')' etc.
Wilfried Goesgens [Thu, 28 Jul 2011 23:16:12 +0000 (23:16 +0000)]
buybuy plaintext important message.
Art Cancro [Thu, 28 Jul 2011 17:05:06 +0000 (13:05 -0400)]
In BBS view, include an anchor tag on each message
Art Cancro [Thu, 28 Jul 2011 16:45:04 +0000 (12:45 -0400)]
Removed the Base64 encoding in RSS feed links. There was a bug in the other implementation and it was easier to just do it this way. It's all StrBuf now, which Willi will like :)
Wilfried Goesgens [Thu, 28 Jul 2011 12:32:42 +0000 (12:32 +0000)]
more documentation work..
Wilfried Goesgens [Thu, 28 Jul 2011 12:29:29 +0000 (12:29 +0000)]
work on documentation.
Wilfried Goesgens [Thu, 28 Jul 2011 12:15:36 +0000 (12:15 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Thu, 28 Jul 2011 12:13:42 +0000 (12:13 +0000)]
enhance GetServerStatus to GetServerStatusMsg; supply migration define
GetServerStatusMsg() can now directly add the server reply text after the status code into WC->ImportantMsg.
Art Cancro [Wed, 27 Jul 2011 20:35:02 +0000 (16:35 -0400)]
Worked around issue where gotoroom() is called with WC->CurRoom.name and the contents of this pointer then become invalid due to room change
the_mgt [Wed, 27 Jul 2011 10:17:47 +0000 (12:17 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
the_mgt [Wed, 27 Jul 2011 10:17:20 +0000 (12:17 +0200)]
Finetuned the IE dropshadow
Wilfried Goesgens [Mon, 25 Jul 2011 20:56:35 +0000 (20:56 +0000)]
template moving the messages select target.
Wilfried Goesgens [Mon, 25 Jul 2011 19:41:24 +0000 (19:41 +0000)]
switch to templated sieve editor; disable old.
the_mgt [Mon, 25 Jul 2011 11:40:10 +0000 (13:40 +0200)]
Indented, added some "" and the altern class, sieve rules should now display proper backgrounds
There seems to be one </div> tag too many
the_mgt [Mon, 25 Jul 2011 11:02:35 +0000 (13:02 +0200)]
Use MS own fullblownshadowing engine to create dropshadows, looks better now.
Maybe directions and thickness need finetuning.
Art Cancro [Mon, 25 Jul 2011 01:08:03 +0000 (21:08 -0400)]
Merged the Simplified Chinese (zh_CN) translation submitted by elliott callaway <flingkatu@gmail.com>
Wilfried Goesgens [Sun, 24 Jul 2011 21:11:19 +0000 (21:11 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sun, 24 Jul 2011 21:09:35 +0000 (21:09 +0000)]
fix bunches of tiny typos; do_template?template=sieve_list produces similar results to the non templated system.
Wilfried Goesgens [Sun, 24 Jul 2011 21:08:26 +0000 (21:08 +0000)]
narrow old and new sieve rules editor
- add some \n's to the old editor for easier diff
- pad our list of sieve rules with empty ones, so we work like the old one.
Art Cancro [Sun, 24 Jul 2011 18:30:21 +0000 (14:30 -0400)]
The monitoring page plays really stupid games with the session. Eliminate all.
root [Sun, 24 Jul 2011 18:14:32 +0000 (14:14 -0400)]
sitemap now uses its own private roomlist function. I know this is probably suboptimal but I'm desperate to find a fix here.
Art Cancro [Sun, 24 Jul 2011 17:52:01 +0000 (13:52 -0400)]
sitemap now uses GetRoomListHash() which is what I should have used in the first place
Wilfried Goesgens [Sun, 24 Jul 2011 15:56:42 +0000 (15:56 +0000)]
Implement selecting of sieve rule target room in dropdown.
Wilfried Goesgens [Sun, 24 Jul 2011 15:54:24 +0000 (15:54 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Sun, 24 Jul 2011 15:10:43 +0000 (15:10 +0000)]
upsi, that const was missing.
the_mgt [Sun, 24 Jul 2011 13:59:50 +0000 (15:59 +0200)]
IE <9 styling with seperate stylesheet
Added conditional for IE less than version 9, removed the nonworking stuff from general stylesheets and moved them to ie_lte8.css
Also forced IE8 to use IE8 rendering instead of "legacy" mode.
Wilfried Goesgens [Sun, 24 Jul 2011 13:43:32 +0000 (13:43 +0000)]
Fix lots of warnings all over the place, make inbound buffers of FMOUT const.
Wilfried Goesgens [Sun, 24 Jul 2011 13:35:59 +0000 (13:35 +0000)]
StrBufSipLine(): make input params const; fix several warnings about unused code.
Wilfried Goesgens [Sat, 23 Jul 2011 22:16:32 +0000 (22:16 +0000)]
cleanup webcit.h; utils.c, remove unneeded stuff
Wilfried Goesgens [Sat, 23 Jul 2011 20:21:45 +0000 (20:21 +0000)]
sieve editor: continue templating, add 'one' iterator for the default template
Wilfried Goesgens [Sat, 23 Jul 2011 20:18:38 +0000 (20:18 +0000)]
start fixing sieve editor templates
- use the right number of vars for const
- fix names with reality in C
Art Cancro [Sat, 23 Jul 2011 02:25:58 +0000 (22:25 -0400)]
Tinkered with the memory pointers in sitemap.c to try to hopefully fix the random crashes we have been having.
Wilfried Goesgens [Thu, 21 Jul 2011 20:39:36 +0000 (20:39 +0000)]
fix summary view
- add neccessary stuff to header/trailer to make the page complete
- add URL-handlers for the summary page sections for the refreshing
- fix tokens and circumvent our singlequote bug once more.
Wilfried Goesgens [Thu, 21 Jul 2011 20:38:53 +0000 (20:38 +0000)]
SERV:ADMIN doesn't need any parameters, it just has one optional one (escaping)
Art Cancro [Wed, 20 Jul 2011 16:59:42 +0000 (12:59 -0400)]
Avoid re-using sessions that are already bound to an executing thread. This will hopefully rightsize both the threadpool and the unbound session pool.
Art Cancro [Wed, 20 Jul 2011 15:53:20 +0000 (11:53 -0400)]
temporary logging for debug
Wilfried Goesgens [Tue, 19 Jul 2011 21:45:32 +0000 (21:45 +0000)]
fix pointer indirection to get the right escaper.
Art Cancro [Mon, 18 Jul 2011 20:45:06 +0000 (16:45 -0400)]
DBG_QR[2] now a configurable loggable
Art Cancro [Mon, 18 Jul 2011 20:21:29 +0000 (16:21 -0400)]
Wrap all calls to pthread_mutex_lock() and pthread_mutex_unlock() within CtdlLogResult()
Art Cancro [Mon, 18 Jul 2011 20:19:45 +0000 (16:19 -0400)]
Convenience function CtdlLogResult()
Wilfried Goesgens [Mon, 18 Jul 2011 00:06:58 +0000 (00:06 +0000)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Mon, 18 Jul 2011 00:06:17 +0000 (00:06 +0000)]
templatize uploading dialog for room/... graphics.
Wilfried Goesgens [Sun, 17 Jul 2011 23:35:30 +0000 (23:35 +0000)]
fix templating errors in display of a single user profile
Wilfried Goesgens [Sun, 17 Jul 2011 23:33:21 +0000 (23:33 +0000)]
we have to wrap do_template into some functions, else it won't work. fix the display of the user.
Wilfried Goesgens [Sun, 17 Jul 2011 23:10:44 +0000 (23:10 +0000)]
fix evaluating of userlist bios...
Wilfried Goesgens [Sun, 17 Jul 2011 23:09:53 +0000 (23:09 +0000)]
LBIO: output LISTING_FOLLOWS; skip the . and .. directory entries.
the_mgt [Sat, 16 Jul 2011 13:24:01 +0000 (15:24 +0200)]
"Fixed" issues in IE by removing PIE.htc behaviour from critical places
1. iconbar hover effect lagged awfully behind
2. messages and boxes began to fall apart when an element styled by PIE.htc was scrolled out of the #content div
This might be a bug in PIE.htc, need to check and report upstream, if so.
We are now back to edged uglyness without pretty box shadows, but usability has to be dominant until we find a proper fix
NOTE: border-radius.htc does not work on iconbar buttons, it totally messes them up!
the_mgt [Sat, 16 Jul 2011 13:17:52 +0000 (15:17 +0200)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Fri, 15 Jul 2011 18:46:41 +0000 (14:46 -0400)]
Attempting to fix a segfault generated in Removecontext()
Wilfried Goesgens [Fri, 15 Jul 2011 15:08:36 +0000 (15:08 +0000)]
templatize userlist
- move the little remaining stuff & needed functionality into useredit.c
- hash users by UID, faster, plus also uniq, and more clever to search from LBIO.
- utilize the new '1' parameter to LBIO so we can quickly locate users
- modify the users found in LBIO to mark them having a bio
- templatize userlist & user detailview.
Wilfried Goesgens [Fri, 15 Jul 2011 15:07:36 +0000 (15:07 +0000)]
add new outputtoken 'F', which does FMOUT with the escaper.
Wilfried Goesgens [Fri, 15 Jul 2011 15:07:07 +0000 (15:07 +0000)]
oops, forgot to add this file.
Wilfried Goesgens [Fri, 15 Jul 2011 15:01:54 +0000 (15:01 +0000)]
LBIO: add parameter
- if the user provided '1' just the UIDs are listed instead of the actual user name.
- we now use dirent and friends instead of outputting the output of the unix ls command *cough*
Wilfried Goesgens [Fri, 15 Jul 2011 12:54:38 +0000 (12:54 +0000)]
move beginbox & endbox to box_* so we can tidy up our static/t/ directory a little more.
Wilfried Goesgens [Fri, 15 Jul 2011 12:54:15 +0000 (12:54 +0000)]
fixed some hickups in summary templating