2 Revision 1.397 1999/10/26 20:20:29 ajc
3 * Removed the auto-reconnect stuff... it was locking the client in an active
4 loop more often than it was reconnecting.
6 Revision 1.396 1999/10/26 13:59:11 ajc
9 Revision 1.395 1999/10/26 03:48:39 ajc
10 * Shuffled around the order of events when a thread is terminating. All
11 mutex operations now happen prior to the freeing of the CitContext structure,
12 otherwise begin_critical_section() and end_critical_section() try to
13 manipulate the context's mutex count when there isn't any context.
15 Revision 1.394 1999/10/26 03:21:16 ajc
16 * Changed a lot of strncpy() calls to safestrncpy() and replaced most of their
17 hardcoded size arguments with 'sizeof' based arguments.
19 Revision 1.393 1999/10/24 19:22:51 nbryant
20 * Makefile.in, configure.in: added --enable-icq flag; made checks for
21 authentication libraries more intelligent.
23 Revision 1.392 1999/10/23 03:39:12 ajc
24 * Finished moving vCard functionality to the new message base functions.
26 Revision 1.391 1999/10/21 00:50:14 ajc
27 * Finished up the flags and replication checks in CtdlSaveMsgPointerInRoom().
29 Revision 1.390 1999/10/20 16:46:27 ajc
30 * More code shuffle. Added some flags to CtdlSaveMessagePointerInRoom() and
31 enabled the MOVE command to also do a "copy" operation (actually just
32 creates a second link and bumps the ref count). Implemented "<C>opy" in
35 Revision 1.389 1999/10/20 16:07:48 ajc
36 * Wholist fixes for users who are in chat mode
38 Revision 1.388 1999/10/20 03:42:29 ajc
39 * In the wholist, only show <private room> if the user viewing the list
40 doesn't know that room. Otherwise show the name.
42 Revision 1.387 1999/10/20 02:59:22 ajc
43 * Code reorganization. Making it easier to move/copy messages without
44 duplicating existing code.
46 Revision 1.386 1999/10/17 02:25:18 ajc
47 * Discovered a huge design flaw in the replication algorithm. Ripped it
48 out and replaced it with something a bit more robust.
50 Revision 1.385 1999/10/16 05:30:17 ajc
51 * Changes to message replication code. Don't do server-side hooks during
52 an ENT3 command. Also fixed a bug in cmd_whok() that caused crashes
53 after a file format change.
55 Revision 1.384 1999/10/14 03:04:16 ajc
56 * Finished the netproc side of Z (zap/supersede) processing for replication
58 Revision 1.383 1999/10/13 04:24:18 ajc
59 * Added search-by-header-fields to CtdlForEachMessage(), and then to the
60 server MSGS command. This will have lots of uses.
62 Revision 1.382 1999/10/13 01:36:39 ajc
63 * Starting some work on network zap (supersede) mode for replication
65 Revision 1.381 1999/10/08 02:55:57 ajc
66 * More vCard-related debugging
68 Revision 1.380 1999/10/07 02:58:46 ajc
69 * Semi-broken vCard replacement implementation in place.
70 * Added "Z" (Zap, supersede) field to message format
72 Revision 1.377 1999/10/04 03:19:52 ajc
73 * We now have a housekeeping thread and a housekeeping queue.
75 Revision 1.376 1999/10/03 21:48:21 ajc
76 * Added serv_upgrade.h to automagically convert pre-5.55 format user records
77 to 5.55 format user records and generate vCards.
79 Revision 1.375 1999/09/29 21:13:17 ajc
80 * CtdlWriteObject() can now store objects in personal rooms for any specified
81 user -- rather than only the current user or non-personal rooms.
83 Revision 1.374 1999/09/29 17:26:56 ajc
84 * serv_vcard.c: fixed crashola bug in cmd_greg()
85 * tools.c: simplified and improved the string tokenizer. Now it runs in a
86 single pass with no intermediate buffer.
88 Revision 1.373 1999/09/28 03:27:37 ajc
89 * Fully migrated cmd_greg() and cmd_regi() into serv_vcard (still has bugs)
91 Revision 1.372 1999/09/27 03:33:40 ajc
92 * cmd_regi() is now in serv_vcard and writes to the vcard instead of to the
93 usersupp file. Still needs tweaking.
95 Revision 1.371 1999/09/24 03:32:19 ajc
96 * "read my vCard" and "write my vCard" are written and tested.
98 Revision 1.370 1999/09/24 02:54:17 ajc
99 * Worked a little more on the vCard stuff. The serv_vcard module is now in
100 place, and a "read my vcard" function is there; "write my" is next...
102 Revision 1.369 1999/09/23 03:07:56 ajc
103 * The vCard 'class' is now linked into the server, though it's not really
104 functional yet. Its constructors/destructors are debugged, though.
106 Revision 1.368 1999/09/19 21:28:33 ajc
107 * Finished off the message architecture stuff with a new class of hooks to
108 enable future server-side handlers.
110 Revision 1.367 1999/09/19 15:57:06 ajc
111 * migrated cmd_ent3() to CtdlSaveMessage()
113 Revision 1.366 1999/09/19 05:13:57 ajc
114 * Debugged the new version of CtdlWriteObject()
116 Revision 1.365 1999/09/16 03:23:23 ajc
117 * Did most of the migration from save_message() to CtdlSaveMsg(). The
118 latter builds a "struct CtdlMessage" (so we can run server-side handlers
119 against it later on), then serializes it and stores to disk.
120 * BROKEN BUILD ALERT!! cmd_ent3() and CtdlWriteObject() are still not
121 migrated. They are stubbed out and will MALFUNCTION if used right now!!
123 Revision 1.364 1999/09/07 01:42:42 ajc
124 * cmd_msg3() now uses serialize_message() for its output. All message
125 commands will eventually exist as a "struct CtdlMessage" at some point
126 so that we can install server-side handler hooks.
128 Revision 1.363 1999/09/07 00:04:13 ajc
129 * netproc.c: put outgoing messages into the use table, too -- this prevents
130 locally originated messages from showing up again if a remote system is
131 misconfigured and spools them back to us.
133 Revision 1.362 1999/09/06 03:39:15 ajc
134 * citadel.c: run strproc() on new passwords
136 Revision 1.361 1999/09/03 17:50:26 playcow
137 For URL view, don't prompt user to select url if there is only one. Display
138 <U>RL View prompt if message contains url(s). -Ben
140 Revision 1.360 1999/09/02 02:09:59 ajc
141 * msgbase.c: new function serialize_message() for future use
143 Revision 1.359 1999/09/01 21:09:25 ajc
144 * database.c: display the GDBM version string on startup
146 Revision 1.358 1999/09/01 02:36:34 ajc
147 * Actually _enforce_ the max msg len limit
149 Revision 1.357 1999/09/01 01:51:48 ajc
150 * Added the ability to handle embedded URL's from the text client
152 Revision 1.356 1999/09/01 01:02:47 ajc
153 * Implemented "maximum message length" in global system config
155 Revision 1.355 1999/08/31 00:57:17 ajc
156 * Handle multipart/alternative properly during legacy message outputs.
157 Basically it just prints the first alternative and skips the rest.
159 Revision 1.354 1999/08/29 21:12:24 ajc
160 * Made some changes to the output of MIME (especially multipart) messages.
162 Revision 1.353 1999/08/29 19:56:43 ajc
165 Revision 1.352 1999/08/24 02:01:03 ajc
166 * html.c: added. This is an overly simplistic HTML-to-text converter.
168 Revision 1.351 1999/08/21 18:37:29 ajc
169 * Minor cosmetic cleanup. No code changes.
171 Revision 1.350 1999/08/21 05:15:34 ajc
172 * mailinglist.c, netmailer.c: fixed to allow list submissions from all posters
173 on a Citadel network rather than only on the local system.
175 Revision 1.349 1999/08/08 00:25:45 ajc
176 * Made one more byte available in locate_host() and in all the structs which
177 its output gets written to (client can display 24 positions but we were only
180 Revision 1.348 1999/08/07 16:34:38 nbryant
181 * serv_icq.c: warning fixes
183 Revision 1.347 1999/08/06 02:57:26 ajc
184 * locate_host.c: use strdoop() and phree() instead of strdup() and free()
185 * serv_icq.c: run learned IP's through Citadel's locate_host() & put in Wholist
187 Revision 1.346 1999/08/05 17:58:59 ajc
188 * RWHO command now returns express message code in postion 3
190 Revision 1.345 1999/08/04 02:21:45 ajc
191 * Fixed some bugs in the ICQ metaclient, and documented the new protocol cmds
193 Revision 1.344 1999/08/03 11:34:35 ajc
194 * Added client_icq.c and client_icq.h
196 Revision 1.343 1999/08/03 03:14:51 ajc
197 * Wrote the client side of the ICQ gateway. Now on to other projects. :)
199 Revision 1.342 1999/08/03 01:52:06 ajc
200 * Redesigned the client protocol commands for dealing with ICQ
201 * Implemented page function priority ordering to prevent pages from being
202 simultaneously delivered over multiple IM systems
203 * Migrated serv_icq.* into the Makefile
205 Revision 1.341 1999/08/01 21:36:30 ajc
206 * EXTREME coolness. The server side of the ICQ metaclient is now working.
207 It is set up using ICQL and ICQA commands, it automatically logs the user
208 onto ICQ along with Citadel, and displays all non-offline ICQ contacts
211 Revision 1.340 1999/07/31 07:18:01 ajc
212 * Restructured the express message infrastructure, adding a class of function
213 hooks for the addition of multiple paging modules with message routing
215 Revision 1.339 1999/07/30 22:20:19 ajc
216 * Applied bugfix patches contributed by Vaggelis Tsirkas:
217 * rooms.c: buffer overrun fix
218 * room_ops.c: cmd_rdir() now behaves better when directory doesn't exist
220 Revision 1.338 1999/07/30 03:32:24 ajc
221 * Added strdoop(), a leak-checked version of strdup()
222 * Small fixes to new API functions in msgbase.c
223 * ICQ metaclient stores/reads config using the message base API functions
225 Revision 1.337 1999/07/29 03:36:37 ajc
226 * msgbase.c: reorganized. output_message() now uses CtdlFetchMessage(),
227 cmd_msg3() now fetches directly from disk and spews to the client.
229 Revision 1.336 1999/07/28 04:02:37 ajc
230 * Server modules are now labelled with their RCS ID instead of a complex and
231 manually-updated data structure.
233 Revision 1.335 1999/07/28 03:50:24 ajc
234 * serv_expire.c: expire-by-age now calls CtdlFetchMessage() instead of
235 calling output_message() in MT_DATE mode.
236 * msgbase.c: removed MT_DATE mode ('twas a sleazy hack)
238 Revision 1.334 1999/07/27 22:47:26 ajc
239 * Implemented new data type "CtdlMessage" which will eventually be used as
240 widely as possible to represent a message in memory.
241 * Implemented CtdlFetchMessage() which is intended to become the back-end to
242 output_message() as well as a bunch of other things.
244 Revision 1.333 1999/07/27 20:00:24 ajc
245 Removed all references to CC->msglist and CC->num_msgs, and all utility
246 functions which relied upon them. Citadel Is Now Better.
248 Revision 1.332 1999/07/27 19:32:22 ajc
249 Removed serv_upgrade.c and all references to it in Makefile.in
250 Reworked new-mail-count to not use MessageFromList() etc.
252 Revision 1.331 1999/07/25 02:59:37 ajc
253 Fixed reference count problem in cmd_move()
255 Revision 1.330 1999/07/24 22:50:38 ajc
256 Continued replacing references to [get|put]_msglist() with better code.
257 For some reason, cmd_msgs() still doesn't always work right.
259 Revision 1.329 1999/07/24 22:16:41 ajc
260 Experimenting with automatic updating of ChangeLog by CVS. Simply twiddle
261 ChangeLog a bit (i.e. by adding or removing a newline from the end of the
262 file) before issusing "cvs commit", and the comments recorded by CVS will
263 automatically appear at the beginning of ChangeLog.
265 Revision 1.328 1999/07/24 22:14:21 ajc
266 cmd_move() now uses CtdlDeleteMessages().
267 WARNING: build is temporarily broken. Currently removing all references
268 to the "msglist" kept in CitContext. It's ugly and must die.
270 Thu Jul 22 22:26:50 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
271 * Moved message deletion into new API function CtdlDeleteMessages()
272 * Added CtdlWriteObject() to store generic data in the msgbase
273 * Fixed really dumb error that prevented network msgs from posting
275 Tue Jul 20 22:14:54 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
276 * Moved the actual work done in cmd_msgs() into a new API function
277 called CtdlForEachMessage() which is supplied a callback function.
279 Mon Jul 19 23:24:18 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
280 * Keep the (unqualified) content-type in the SuppMsgInfo record. We'll
281 be using this shortly to search rooms for specific object types.
283 Sun Jul 18 14:53:16 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
284 * Changes to dynloader et al to handle ICQ module being written
285 * serv_icq.c, serv_icq.mk: added (separate makefile is temporary)
287 1999-07-17 Nathan Bryant <bryant@cs.usm.maine.edu>
288 * chkpwd.c: DELETED CVS REVISION 1.3 (backed out Art's last change)
289 use 'cvs update -r 1.2 chkpwd.c; cvs update -A chkpwd.c' NOW to
290 avoid problems with working directories.
291 * Makefile.in: don't install chkpwd setuid if make install isn't
293 * citadel.spec: chmod u+s chkpwd during %install stage
295 Fri Jul 16 18:39:04 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
296 * PEXP and GEXP no longer trip the idle time display
297 * Fixed bug which duplicated incoming private mail to Trashcan
298 * Improved auto-reconnect by NOT using SIGPIPE and longjmp(); also
299 implemented a 15 second delay to wait for a crashed server to restart
300 * Relaxed the security check in chkpwd.c a bit; it was just flat-out
301 preventing logins on my system otherwise
303 Thu Jul 15 22:57:32 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
304 * eliminate redundant "name" parameter in [l]putuser(), now uses
305 usbuf->fullname to guarantee the correct name for the index
307 1999-07-12 Nathan Bryant <bryant@cs.usm.maine.edu>
308 * Makefile.in, configure.in: link netproc with gdbm
309 * netproc.c: only include gdbm.h if HAVE_GDBM_H
310 * user_ops.c: warning fix
312 Mon Jul 12 19:51:30 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
313 * Mail is now saved in both sender and recipient mailboxes. This is
314 structured in a way that will allow a separate "outbox" room and/or
315 multiple recipients in the future.
317 Sun Jul 11 18:46:48 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
318 * netproc.c: msgfind() no longer uses the timestamp as a message-ID
319 when no other message-ID is available (it screws up the loopzapper)
320 * room_ops.c: eliminate room name parameter in putroom() and its ilk;
321 get data from quickroom.QRname instead; prevents incorrect indexes
322 * Tentative implementation of "personal rooms" (user-private namespace)
323 * Added supplementary message info records for info that may change
324 at some time later than when the message is saved (i.e. ref counts)
325 * Implemented msg reference count increment/decrement; delete messages
326 whose reference count reaches zero
328 Wed Jul 7 23:25:09 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
329 * control.c: create citadel.control if it doesn't exist (yikes!)
330 * serv_expire.c: purge mailbox rooms belonging to non-existent users
331 * user_ops.c: don't delete user's mailbox at user-delete time
333 Mon Jul 5 17:01:29 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
334 * utilsmenu: removed menu items for defunct utilities
336 Mon Jun 28 16:24:10 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
337 * Changed any remaining references to UUCP, to "Internet" instead.
339 Thu Jun 24 11:13:23 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
340 * added server command line option "-f" to defrag databases on startup
341 * control.c: better performance and reliability in [get|put]_control()
342 * netproc.c: Finished the loopzapper
344 Mon Jun 21 00:04:15 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
345 * netproc.c: started writing a vortex checker. Not finished.
347 Wed Jun 9 23:34:25 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
348 * Replaced all code that generated temporary filenames with calls to
349 tmpnam(). Rewrote using tmpfile() where possible.
351 Thu Jun 3 11:35:18 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
352 * base64.c: mapped fi and fo to stdin and stdout using
353 actual code rather than assignment at declaration time
354 (several users of Red Hat Linux 6.0 reported problems)
356 Fri May 21 20:05:00 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
357 * Added function CtdlGetDynamicSymbol() for dynamic symbol allocation
358 * server.h: Changed discrete #define's to enum's where appropriate
359 * sysdep.c: Changed the startup message to give credit to the whole
360 development team :) Also made the message more GNU-ish.
362 Thu May 20 20:01:30 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
363 * database.c: print log messages for file defragmentations
364 * citserver.c: implemented CtdlAllocUserData() and CtdlGetUserData()
365 for arbitrary per-session data storage (by modules etc.) without
366 having to add fields to struct CitContext
367 * msgbase.c: removed "desired_section" from struct CitContext and
368 implemented it using CtdlGetUserData() as a test.
370 Wed May 19 19:30:28 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
371 * commands.c, commands.h, routines.c: began color scheme changes
373 1999-05-15 Nathan Bryant <bryant@cs.usm.maine.edu>
374 * configure.in: Added untested support for BSDI 4.x.
376 1999-05-13 Nathan Bryant <bryant@cs.usm.maine.edu>
377 * acconfig.h, configure.in, routines.c: fix for certain SYSV variants
378 which lack utmp.ut_host
379 * citadel.h, file_ops.c, msgbase.c, netproc.c, serv_chat.c: fix
380 namespace collision with <sys/stream.h> on aforementioned SYSV
382 * configure.in, getutline.c: check for paths.h
383 * configure.in, Makefile.in: check for -lsocket and -lnsl
385 1999-05-11 Nathan Bryant <bryant@cs.usm.maine.edu>
386 * chkpwd.c: fixed excessive paranoia; it used to refuse to run when
387 invoked by root and BBSUID != 0
388 * Makefile.in: ignore errors while installing /etc/pam.d/citadel
390 1999-04-27 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
391 * file_ops.c: fixed NDOP to not crash the server if it has trouble
393 * netpoll.c: upped default packet size
395 Mon Apr 26 22:06:57 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
396 * Repaired IGnorant security hole blunder re. citmail
398 Sun Apr 25 12:44:08 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
399 * serv_chat.c: notify user of number of participants upon entering chat
400 * Built the 5.53 distribution
402 Wed Apr 21 22:23:13 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
403 * aidepost.c: add -r flag to allow posting to rooms other than Aide>
404 * serv_expire.c: now posts transcripts of all auto-purged rooms/users
406 Tue Apr 20 12:45:55 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
407 * messages.c: downloading more than MAX_MSGS messages now truncates
408 (off the beginning of the list) rather than crashing.
410 Mon Apr 19 12:11:48 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
411 * whobbs.c: auto-detect when being called from a webserver, and act
412 as a CGI (print HTTP headers and HTML output)
414 1999-04-18 Nathan Bryant <bryant@cs.usm.maine.edu>
415 * serv_chat.c: fixed some potential buffer overruns (thanks dme)
417 Wed Apr 14 21:32:28 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
418 * Makefile.in: chmod 4755 citmail to prevent citmail from aborting
419 when called from sendmail due to citadel.config security check
421 1999-04-13 Nathan Bryant <bryant@cs.usm.maine.edu>
422 * dynloader.c: OpenBSD places underscores in front of symbol names
423 * Makefile.in: fixed a few sillies
424 * aidepost.c, citmail.c, file_ops.c, logging.c, msgbase.c, netmailer.c,
425 netproc.c, rcit.c, routines.c, serv_upgrade.c: fixed time_t handling
426 (have to cast it to long for printf/scanf)
428 Mon Apr 12 22:13:26 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
429 * aidepost.c: rewrote to unlink temp file before writing to it so that
430 it will automatically go away if interrupted. Also ran indent -kr -i8
432 1999-04-12 Nathan Bryant <bryant@cs.usm.maine.edu>
433 * configure.in, Makefile.in: taught it how to generate OpenBSD shared
435 * config.c, sysdep.c: fix -h option not setting proper modules dir
436 * configure.in, citadel.spec: make --enable-chkpwd the default
437 * setup.c: don't chown chkpwd
439 1999-04-11 Nathan Bryant <bryant@cs.usm.maine.edu>
440 * configure.in: another OpenBSD fix, but we're still not quite there yet
441 * serv_chat.c: warning fix
443 Thu Apr 8 22:51:28 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
444 * config.c: now requires a setup run for *any* rev level difference
445 * Updated docs & confs for 5.53b1 release
446 * setup.c: sets the 0600 permission bits on citadel.config that
447 is checked for in config.c
449 1999-04-08 Nathan Bryant <bryant@cs.usm.maine.edu>
450 * citserver.c: improved is_public_client(), also if a public_client
451 only supplies a numeric address, attempt to resolve it
452 * locate_host.c: verify that the forward DNS matches the reverse
453 * locate_host.c, locate_host.h: more general interface
454 * configure.in, acconfig.h: fixes for Digital UNIX
456 Wed Apr 7 21:36:16 EDT 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
457 * Implemented "access level required to create rooms" (client & server)
459 1999-04-07 Nathan Bryant <bryant@cs.usm.maine.edu>
460 * configure.in: updated help messages, OpenBSD support
461 * setup.c: if /etc/inittab doesn't exist, don't ask to create an
463 * server.h, sysdep.c: fix a potential deadlock/data corruption bug
464 * room_ops.c: fixed the 'gdbm error: Illegal data' message when
465 deleting a room which had never been posted to
466 * user_ops.c: include errno.h
467 * dynloader.c: fix for OpenBSD
469 1999-04-06 Nathan Bryant <bryant@cs.usm.maine.edu>
470 * Makefile.in, configure.in, getutline.c, sysdep.c:
471 fixes/bug workarounds for FreeBSD
473 1999-04-03 Nathan Bryant <bryant@cs.usm.maine.edu>
474 * Makefile.in, configure.in, chkpwd.c, acconfig.h: support for
475 `chkpwd', a setuid helper program for machines which use shadow
476 passwords (configure --enable-chkpwd)
477 * Makefile.in, configure.in, auth.c, citadel.pam, user_ops.c: support
478 for PAM or shadow passwords (configure --with-pam)
479 * Makefile.in: made some messages simpler
480 * citadel.spec: updated for 5.53; correct name of tarball; build with
481 --enable-chkpwd and --with-pam; add defattr tags so rpm's can be
482 built by non-root user
483 * commands.c: cosmetic cleanup
484 * config.c: (security/paranoia) check permissions on citadel.config
485 * configure.in: check for ncurses if we can't find curses
486 * dynloader.c: warning fix
487 * sysdep.c: don't complain if initgroups() fails
488 * citadel.c: fix systems with SYSV-style signal handling (e.g. libc5)
489 * Makefile.in: New! Improved! Cleaner! Shinier!
491 Sun Mar 21 14:21:47 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
492 * messages.c: cosmetic cleanups to message reading loop
494 Sat Mar 13 21:33:19 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
495 * commands.c: use bright colors by default in color mode
496 * citserver.c: initialize wholist fields with (not logged in) etc.
498 1999-03-08 Nathan Bryant <bryant@cs.usm.maine.edu>
499 * sysdep.c: call DLoader_Init() with an absolute path so that gdb can
501 * database.c: bail out if opening databases fails
503 Sat Mar 6 01:55:55 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
504 * serv_chat.c: use memfmout(), *not* cprintf() to transmit express
505 messages. Calling cprintf() on strings >256 bytes crashes the server
506 * msgbase.c: minor logging fix in save_message()
508 1999-03-05 Nathan Bryant <bryant@cs.usm.maine.edu>
509 * sysdep.c: add undocumented -r flag to citserver to prevent it from
510 dropping root permissions.
511 * sysdep.c: also drop supplementary groups
513 1999-03-04 Nathan Bryant <bryant@cs.usm.maine.edu>
514 * config.c: error checking in put_config()
515 * setup.c: chgrp files to the login group associated with BBSUID
516 * sysdep.c: copyright 1987-1999; drop root perms; load modules and call
517 master_startup() after dropping perms
519 Wed Mar 3 00:00:55 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
520 * Prevent buffer overruns in lowercase_name in [get|put]user()
521 * client_chat.c: use citedit() for page composition
523 Sat Feb 27 07:47:36 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
524 * rooms.c: download_to_local_disk() prompts for a filename if a blank
525 filename was supplied to it (for attachments without names)
526 * mime_parser.c: strip leading whitespace in content_type & disposition
528 1999-02-24 Nathan Bryant <bryant@cs.usm.maine.edu>
529 * configure.in: improved check for pthreads
530 * configure.in, routines.c, acconfig.h: check for ut_type in struct utmp
531 * configure.in, Makefile.in: support for building server modules as
532 relocatable objects for BSDI (which still uses a.out *gag* *choke*)
533 * configure.in: compiler choice & flags for BSDI; check for libtermcap
534 * database.c: don't use a critical section in open_databases()
535 * housekeeping.c: use getfloor()/putfloor() instead of
536 lgetfloor()/lputfloor() in check_ref_counts()
537 * mime_parser.c: include <errno.h>
538 * msgbase.c: include <limits.h>
539 * sysdep.c: hacks for BSDI. use signals to fake thread cancellation;
540 don't call master_cleanup() directly from signal handler.
541 * routines.c: prototype getutline() if necessary
542 * getutline.c: stupid bugfix
543 * acconfig.h, configure.in, locate_host.c, server.h: work around
544 nonreentrant gethostbyaddr() on BSDI
546 Mon Feb 15 22:59:00 EST 1999 Vaggelis Tsirkas
547 * citadel.c: increased hostname buffer size to handle very big names
549 1999-02-15 Nathan Bryant <bryant@cs.usm.maine.edu>
550 * sysdep.c(main): initialize alen before call to accept()
552 1999-02-04 Nathan Bryant <bryant@cs.usm.maine.edu>
553 * configure.in: improved check for cygwin
554 * configure.in, routines.c: access utmp directly instead of calling
555 `who' if getutline() is available.
556 * configure.in, Makefile.in, getutline.c: replace getutline() on
557 systems which don't have it
558 * routines.c: now always access utmp directly unless we can't find
561 1999-02-02 Nathan Bryant <bryant@cs.usm.maine.edu>
563 - ifdef out file download methods that require named pipes (client)
564 - include pthread.h and gdbm.h only if they are present (fixes
565 auto dependency generation)
566 - include snprintf.h where needed
567 - handle .exe suffixes for "make install"
569 Tue Feb 2 22:15:08 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
570 * Overhauled the express messaging system (again)
572 Mon Feb 1 19:48:04 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
573 * messages.c: implemented client download of MIME attachments
575 Sun Jan 31 18:29:18 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
576 * Added qpdecode.c to the distribution (decodes quoted-printable)
577 * Finished the MIME parser
578 * Gave MSG0 a reasonable behaviour for MIME messages
579 * Added the OPNA command for downloading attachments
581 Sat Jan 30 18:39:53 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
582 * Look for citadel.rc in current directory if not found elsewhere
583 * More work on the MIME parser
584 * Added base64.c to the distribution
586 1999-01-29 Nathan Bryant <bryant@cs.usm.maine.edu>
587 * fixes for IRIX (thanks to wr and family for use of the Indy):
588 - use memset()/memcpy() instead of bzero()/bcopy() in all cases
590 - handle `long' pid's
591 - a few other little bits
593 Mon Jan 25 21:23:07 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
594 * Fixed bug in save_message() which crashed the server on mail to sysop
595 * Rewrote pop_march() to be smarter about <G>oto heuristics
597 Sat Jan 23 14:32:19 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
598 * Changed internal storage of express messages from a linked list to
599 a single, resizable buffer.
600 * Added a "room order" key to the room record, to allow some control
601 over room listing order.
602 * Made the room list commands aware of the room order key.
603 * Overhauled <G>oto heuristics to pay attention to floor & room order
605 Wed Jan 20 19:21:51 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
606 * Added some more code to the unfinished MIME parser
607 * Changed module loading path to simply "modules" because after calling
608 get_config(), the cwd is guaranteed to be the correct BBS directory.
610 Tue Jan 19 21:28:29 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
611 * Fixed a bug in the user editing command (client side)
612 * Started a rewrite of the MIME parser
614 Thu Jan 14 21:21:15 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
615 * Brought over the mime_parser from WebCit and began preliminary work
616 on supporting MIME format messages.
618 Tue Jan 12 22:30:00 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
619 * Various changes to begin work on support for MIME messages
620 - Defined format type 4 for MIME
621 - msgbase.c: *temporary* hacks in output_message() for Type 4
622 - citmail.c: added more robust header parsing, and support
623 for Type 4. Also eliminated the crappy built-in
625 - Updated some of the technical documentation
627 Sun Jan 10 13:34:36 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
628 * Fixed access to page log room
630 Fri Jan 8 12:35:09 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
631 * control.c: include <limits.h> to fix PATH_MAX undefined
632 * serv_chat.c: made the following changes to cmd_sexp() --
633 * Send zero-length message to check only, don't send
634 * Send "-" message on the command line to invoke
635 the SEND_LISTING transfer mode for a multi-line message
636 * Added facilities to log all pages to a room (site configurable)
638 Tue Jan 5 23:24:52 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
639 * Replaced all occurances of malloc(), realloc(), and free() in the
640 server and server-modules with mallok(), reallok(), and phree().
641 Wrote macros and a set of leak-tracking functions.
643 Sun Jan 3 20:38:45 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
644 * Documentation changes
646 Fri Jan 1 01:01:45 EST 1999 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
647 * Fixed security problem relating to private rooms
649 Wed Dec 30 20:10:52 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
650 * sysdep.c: put a bigger string buffer into lprintf() to avoid overruns
652 Sat Dec 26 16:56:46 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
653 * internetmail.config: commented this file more clearly
655 Wed Dec 23 20:42:49 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
656 * citadel.c: added some experimental code to automatically reconnect
657 to the server if the connection is broken. For some reason, it only
660 Wed Dec 23 18:47:12 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
661 * sysdep.c: ignore SIGPIPE. This keeps broken connections from
662 crashing the whole server.
663 * Tagged everything for the official 5.50 release.
665 Mon Dec 21 07:54:20 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
666 * housekeeping.c: call kill_session() with session_to_kill,
667 not ccptr->cs_pid (was crashing the server)
669 Sat Dec 19 13:57:48 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
670 * Added "-i" flag to netproc to make it skip the export phase.
671 Updated other programs to call netproc in this way when appropriate.
672 * Updated network.txt to reflect the usage for netproc (which has
673 been wrong for several releases)
675 Thu Dec 17 00:17:04 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
676 * Started removing the word "beta" from the docs and code.
677 Preparing for an actual release.
678 * msgbase.c: generate an 'I' field when requested (i.e. on locally
679 originating messages. this was breaking parts of the network)
681 1998-12-15 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
682 * msgbase.c: remove extra call to alias() which was causing
683 Citadel-to-Citadel mail to fall into the bit bucket.
684 * msgbase.c: fixed tempfile naming problem that could cause a new
685 outgoing netmail message to overwrite another if netproc had not been
688 1998-12-14 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
689 * More session table stability nonsense
691 Sun Dec 13 17:40:08 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
692 * sysdep.c, citserver.c: (hopefully) fixed a session table concurrency
693 bug which was causing the server to occasionally crash.
694 * removed serv_test.so from the default build
696 Fri Dec 11 18:50:00 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
697 * setup.c: default value for maxsessions is now 0 (no limit)
698 * room_ops.c: don't allow users to create a room called "Mail"
699 * serv_expire.c: fixed "number of messages purged" display
700 * commands.c: when using color, default to low-intensity colors
702 Tue Dec 8 07:58:16 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
705 Sat Dec 5 01:24:03 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
706 * Added a new type of module hook for adding logging functions
707 * Removed whitespace to left and right of '@' in netmail recipients
708 * sysdep.c: read citadel.config _before_ initializing loadable modules
709 * stats.c: fixed segfault resulting from extracting log lines
710 * Ripped most of the "attachments" stuff out of both the client and
711 server. (Thought of a better way to handle it ... LATER.)
713 1998-12-03 Nathan Bryant <bryant@cs.usm.maine.edu>
714 * setup.c: create citadel.config with mode 0600
715 * Makefile.in: don't chmod sendcommand
716 * serv_upgrade.c: don't create citadel.config if it doesn't already
718 * setup.c: saner defaults for nodename and fqdn
720 Wed Dec 2 20:37:05 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
721 * msgbase.c: modified AddMessageToRoom() and all functions that call it
722 to use a more reliable/accurate method to set quickroom.QRhighest
723 * weekly.in: don't sort/purge filedir where filedir doesn't exist
725 1998-12-02 Nathan Bryant <bryant@cs.usm.maine.edu>
726 * weekly is now generated by configure
728 Mon Nov 30 19:48:52 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
729 * room_ops.c: added sort_msglist() to move and save operations
730 * sendcommand.c: added (also updated utils.txt, weekly, Makefile.in)
733 Sun Nov 29 23:57:39 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
734 * Fixed cmd_regi() to not display a second result code after xfer
735 * Makefile.in: Removed "chmod 4755 citmail netmailer"
737 1998-11-23 Nathan Bryant <bryant@cs.usm.maine.edu>
738 * citadel.spec: added
740 1998-11-22 Nathan Bryant <bryant@cs.usm.maine.edu>
741 * Makefile.in: split install target into install-exec, install-data,
742 and install-doc subtargets
744 Sat Nov 21 16:53:30 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
745 * Added a fourth color mode in the client: "user" which turns color
746 on or off according to a per-user flag stored on the server. Added
747 server-side support for this too, of course.
749 * serv_expire.c: finished the code to purge stale visits
750 * sysdep.c: strip trailing nonprintables in client_gets()
751 * routines2.c: fixed <.AS> command; all configs now work properly
752 * Moved num_parms() and all the extract() type functions into tools.c
753 and removed them from all other files. Linked in tools.[o|ro] there.
754 * netproc.c: handled incoming file transfers to correct room directory
755 * room_ops.c: fixed incorrect naming of files in info and images dirs
757 Fri Nov 20 20:29:07 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
758 * setup.c: removed all prompts that can be configured from within the
759 client in order to simplify the setup procedure
761 Thu Nov 19 23:28:33 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
762 * Fixed serv_upgrade.c and export5.c (found elsewhere) to use a new
763 export format which treats visits as a separate section
764 * serv_expire.c: began writing functions to purge rooms and visits
765 (neither work yet), and added a way to call defrag_databases()
767 Wed Nov 18 23:51:17 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
768 * Reimplemented 'visit' structs stored globally instead of as
771 Tue Nov 17 22:37:48 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
772 * Started implementing global room numbers.
774 Sun Nov 15 20:32:34 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
775 * room_ops.c: mailbox rooms always appear on the main floor
776 * made QR_MAILBOX rooms non-editable
777 * cmd_setr() delete old room record when room name changes
778 (This causes a big mess that exposes a flaw in the whole design.)
779 * room_ops.c: users can delete messages from their mailboxes
781 Thu Nov 12 23:59:13 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
782 * Rewrote cmd_rchg() and also increased the size of the "fakename"
783 buffer. Overruns are probably what was causing the crashes.
784 * Changed the way cmd_ent3() handles mail messages; the previous code
785 rerouted all private mail to the trash.
787 Wed Nov 11 17:57:39 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
788 * citserver.c: slight changes to cmd_rchg() and cmd_hchg() [crashes]
789 * citserver.c, msgbase.c, user_ops.c: hide the owner-prefix of mail
790 rooms in a couple more places: set_wtmpsupp() and make_message()
791 * sysdep.c: added an fflush() to lprintf() for "tail -f"-able logs
792 * serv_expire.c: purge ops are now a command instead of a cleanup
793 function. This is probably temporary as well.
794 * citadel.c: fixed the way <.WL> parses the returned data from a
797 1998-11-11 Nathan Bryant <bryant@cs.usm.maine.edu>
798 * serv_upgrade.c: fix uninitialized variable
800 Wed Nov 11 00:47:32 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
801 * msgbase.c: fixed a bug that was misrouting incoming network msgs
802 * server.h, database.c: wrapped all GDBM calls in critical sections
803 to avoid making those calls re-entrantly (gdbm fatal: lseek error)
805 1998-11-10 Nathan Bryant <bryant@cs.usm.maine.edu>
806 * Makefile.in: link in snprintf.o where needed
808 1998-11-09 Nathan Bryant <bryant@cs.usm.maine.edu>
809 * client_chat.c: eliminate calls to sprintf()
810 * commands.h, routines.c, routines2.c: warning fix
811 * commands.c, control.c, cux2ascii.c, file_ops.c, import.c,
812 ipc_c_tcp.c: eliminate sprintf() calls
814 Mon Nov 9 19:15:31 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
815 * serv_upgrade.c: added all missing fields to export/import
816 * serv_expire.c: support per-user purge time when purging users
817 * user_ops.c: added per-user purge time to AGUP and ASUP commands
818 * routines.c: added more stuff to <.A>ide <E>dit user
820 Sun Nov 8 22:56:53 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
821 * serv_expire.c: created; moved message expiry from serv_test.c,
822 moved user purge from userpurge.c
823 * userpurge.c: deleted
824 * routines2.c: finished <.AS> command
825 * room_ops.c: fixed Aide room access (for some reason, the Aide
826 room had the QR_MAILBOX flag set)
828 1998-11-08 Nathan Bryant <bryant@cs.usm.maine.edu>
829 * useradmin.c: really removed (cvs remove)
830 * aidepost.c, citadel.c: convert all sprintf() calls to snprintf()
831 * sysdep.c: fix overrun in lprintf() described by dme/Dead Monkey
832 * citmail.c, citserver.c: convert all sprintf() call to snprintf()
834 Sun Nov 8 13:19:36 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
835 * useradmin.c: removed
836 * utils.doc: removed references to useradmin and sysoputil
838 Fri Nov 6 20:22:20 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
839 * citadel.h (and related files): removed defunct parameters,
840 c_defent and c_msgbase (erase your test bbs)
841 * Implemented CONF server command for site-global configs
842 * Shuffled yesno() and yesno_d() from routines.c to commands.c
843 * commands.c: implemented boolprompt()
844 * routines2.c: started adding CONF questions to <.AS> command
845 * room_ops.c: began a fix for the mysterious disappearing Aide room
847 1998-11-05 Nathan Bryant <bryant@cs.usm.maine.edu>
848 * snprintf.c: warning fix propagated over from gcit
850 1998-11-04 Nathan Bryant <bryant@cs.usm.maine.edu>
851 * added RCS Id keyword strings to sources
852 * citmail.c: reverted to version 1.10
854 Wed Nov 4 10:53:13 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
855 * messages.c: temporarily set screenwidth to a fixed value of 80
856 during <P>rint operations.
858 Mon Nov 2 12:59:03 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
859 * setup.c: looks for 'citadel', 'bbs', or 'guest' in /etc/passwd to
860 try to get a default for bbsuid if it's currently set to 0
861 * citmail.c: changed usersupp.eternal to usersupp.usernum (why didn't
862 it complain about this before?)
863 * serv_upgrade.c: began writing an "export" command to do sidegrades
865 Sun Nov 1 18:47:42 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
866 * serv_upgrade.c: cosmetic changes
867 * Implemented message expiry by date (this really needs to be moved
868 out of serv_test.c, but where does it belong?)
870 1998-11-01 Nathan Bryant <bryant@cs.usm.maine.edu>
871 * serv_upgrade.c: warning fixes
872 * acconfig.h: remove ANSI_COLOR
873 * Configure, Makefile.tmpl: removed
875 Sat Oct 31 20:48:44 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
876 * More stoopid ANSI colour additions here and there.
877 * ANSI colour selection is now in citadel.rc instead of an option in
878 the configure script. "on" "off" and "auto" are available.
879 * added "build.txt" to the techdoc directory, with LS's build notes
881 1998-10-31 Nathan Bryant <bryant@cs.usm.maine.edu>
882 * citadel.c, commands.c, commands.h: set background color to black
883 before clearing screen, so that we can actually see text on
884 black-on-white xterms.
886 1998-10-29 Nathan Bryant <bryant@cs.usm.maine.edu>
887 * rooms.c: fix color of Mail>
888 * citadel.c: send ANSI detect sequence after attach_to_server() so the
889 terminal doesn't send the answerback sequence to the shell if we
892 Wed Oct 28 20:20:14 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us
893 * citadel.c: Added a splash of colour to the Wholist
895 1998-10-28 Nathan Bryant <bryant@cs.usm.maine.edu>
896 * configure.in: added comments
897 * mkinstalldirs: new file to be used for `make install'
898 * aclocal.m4, missing: new files, also swiped from automake
899 * citadel.c: don't mung the terminal if we can't find citadel.rc
900 * Makefile.in: added `install' target, `clean' removes
901 *.mo, rebuild configure when configure.in changes.
902 * configure.in: check for install and autoconf
903 * configure.in, Makefile.in: only pass -fPIC to gcc
904 * policy.c: warning fix for OSF/1 (use memset() instead of bzero())
906 Tue Oct 27 22:25:42 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
907 * Unified the "unpacked database" format for both upgrades and
908 sidegrades (also see export5.c elsewhere)
909 * citserver.c: clear out cmdbuf before reading a command; some server
910 commands were accidentally extracting parameters from previous cmds
911 * rooms.c: removed the warning about the ineffectiveness of kicking
912 users out of public rooms, because the new server can do lockouts
914 1998-10-27 Nathan Bryant <bryant@cs.usm.maine.edu>
915 * sysdep.c (client_gets), ipc_c_tcp.c (serv_gets): improved handling
917 * Makefile.in: partial support for VPATH builds, autodependency fix
919 Tue Oct 27 00:08:16 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
920 * minor documentation changes
922 Sun Oct 25 14:57:40 EST 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
923 * messages.c: fixed an oversight that was allowing attachments even
924 when disabled in citadel.rc
926 1998-10-25 Nathan Bryant <bryant@cs.usm.maine.edu>
927 * routines2.c: warning fix
929 Sat Oct 24 22:07:56 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
930 * Client: added message expiration policy questions to room edit
931 * Client: added <.A>ide <S>ystem configuration command
933 1998-10-24 Nathan Bryant <bryant@cs.usm.maine.edu>
934 * Makefile.in: Auto dependency generation (may require GNU make, but
935 does at least function without this feature on OSF/1 make);
936 Makefile is regenerated when Makefile.in changes (ditto);
937 `realclean' is now known as `distclean';
938 portability fixes for older Unix make utilities
939 * citadel.c, citadel.h, commands.c: make client suspendable
941 Fri Oct 23 19:34:38 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
942 * setup.c: default node name is now obtained from uname()
943 * config.c: added put_config()
944 * policy.c: added, moved GetExpirePolicy() from room_ops.c
945 * policy.c: implemented cmd_gpex() and cmd_spex()
947 Wed Oct 21 22:24:48 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
948 * Mail rooms now hide their owner-prefix from the client.
949 * proxy.c: added configurability and primitive message expiry
951 1998-10-20 Nathan Bryant <bryant@cs.usm.maine.edu>
952 * Makefile.tmpl: fix to build client with old Configure script
953 * configure.in: autologin defaults to enabled if crypt() is available
954 * room_ops.c: fix improper null-termination bug I introduced
956 Mon Oct 19 20:52:55 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
957 * Client ability to force display of prompts in Mail rooms, even when
958 the user has prompting turned off (citadel.rc option)
960 1998-10-16 Nathan Bryant <bryant@cs.usm.maine.edu>
961 * sysdep.c (cprintf): generate a newline on truncated buffer
962 * room_ops.c: exploitable overrun fixes
964 Thu Oct 15 19:27:32 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
965 * msgbase.c: reimplemented cmd_move()
966 room_ops.c: wrote AddMessageToRoom() which is used for both entering
968 * setup.c: system-default message expire policy of "number of
969 messages, 150" is now a default configuration instead of a temp hack
970 * proxy.c: cache dir create now dies on any error except EEXIST
972 Wed Oct 14 22:41:16 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
975 1998-10-13 Nathan Bryant <bryant@cs.usm.maine.edu>
976 * configure.in: don't check for -lcrypt unless autologin is enabled
977 * file_ops.c: fix another overrun
979 Mon Oct 12 15:27:21 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
980 * Killed the "rooms" subdirectory (it isn't used anymore)
981 * dynloader.c: Made dynamically added server commands case-insensitive
982 * import.c is now serv_upgrade.c, a module
983 * Removed most of the "level 9" trace messages no longer needed
985 1998-10-12 Nathan Bryant <bryant@cs.usm.maine.edu>
986 * Makefile.in: simplified to use pattern rules; files compiled with
987 -D_REENTRANT go to *.ro to allow the same files to be used with both
989 * tools.c, tools.h: new files; misc routines used by both client and
990 server go here. contains safestrncpy() at the moment.
991 * rooms.c: fix several exploitable buffer overruns
992 * sysdep.c: fix infinite loop when long lines are received from the
993 client; fix exploitable buffer overrun in cprintf()
994 * ipc_c_tcp.c: fix infinite loop on long line from server
995 * serv_upgrade.sh: remove uncnsrd-dependent absolute path
996 * .cvsignore: add *.ro
998 Sun Oct 11 23:17:48 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
999 * Built some more of the message expiry infrastructure
1001 1998-10-11 Nathan Bryant <bryant@cs.usm.maine.edu>
1002 * citserver.c: fix two more overruns, one of which was preventing
1003 the "From Host" from showing up in the <W>ho listing.
1005 Sun Oct 11 02:51:55 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1006 * Moved "struct visit" and its associated defs from citadel.h to
1007 server.h where they belong
1008 * Set up data structures for room policies (expiry, etc.)
1010 1998-10-10 Nathan Bryant <bryant@cs.usm.maine.edu>
1011 * citserver.c: fix overrun which caused segv's on servers with long
1014 Fri Oct 9 18:34:06 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1015 * user_ops.c: added PurgeStaleRelationships() to do processing at
1016 session logout time to remove visits for rooms which no longer exist
1017 * user_ops.c: implemented NewMailCount()
1019 1998-10-09 Nathan Bryant <bryant@cs.usm.maine.edu>
1020 * serv_chat.c: fix buffer overrun that was resulting in segv's
1021 * serv_chat.c: fix another overrun that could cause sessions to hang,
1022 and cleaned up some other strncpy()-related stuff. DON'T FORGET TO
1023 NULL-TERMINATE DESTINATION BUFFERS AFTER STRNCPY CALLS.
1025 Fri Oct 9 13:22:37 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1026 * Implemented "lazy mode" traversal - pressing the space bar will do
1027 <N>ext messsage, <G>oto next room, or read <N>ew as appropriate.
1028 * room_ops.c: modify CtdlRoomAccess() to allow access to mailbox rooms
1029 only to their owners.
1031 Thu Oct 8 17:13:27 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1032 * messages.c, citadel.rc: added the ability to display message numbers
1033 in the header when reading messages. I think this is butt ugly, but
1034 some of the DaveCode afficionados seem to like it...
1036 Thu Oct 8 15:34:45 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1037 * room_ops.c: Added is_noneditable() function to replace all of the
1038 duplicated code present in all functions which edit room parameters.
1040 1998-10-08 Nathan Bryant <bryant@cs.usm.maine.edu>
1041 * lots of warning fixes; builds with -std1 on dec unix
1042 * aidepost.c, citadel.h, citmail.c, file_ops.c, msgbase.c, netmailer.c,
1043 netproc.c, rcit.c, server.h, stats.c, userlist.c: use time_t where
1045 * control.c, room_ops.c, serv_chat.c, sysdep.c: use memset() instead of
1047 * dynloader.c, dynloader.h, messages.c, server.h, sysdep.c,
1048 sysdep_decls.h: function pointer/prototyping fixes
1049 * rooms.c: use mkfifo(3) instead of system("mkfifo")
1051 1998-10-07 Nathan Bryant <bryant@cs.usm.maine.edu>
1052 * snprintf.c, snprintf.h: new files
1053 * Makefile.in, configure.in, dynloader.c, sysdep.c: support for the
1054 above; citserver now builds and runs on Digital Unix 4.0d with the
1055 GNU-style configure script. there is a bug with the hostname display
1057 * netproc.c: sillyness fix
1058 * room_ops.h: prototype delete_room()
1059 * client_chat.c, commands.c, serv_chat.c, sysdep.c:
1060 use HAVE_SYS_SELECT_H macro
1062 Mon Oct 5 17:01:32 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1063 * Began fixing the stuff I broke
1065 Sun Oct 4 23:35:18 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1066 * Did the big migration to the new data structures. Lots of stuff is
1067 now broken. Basic moving from room to room works, but Mail is
1068 broken, and some of the administrative commands are unimplemented.
1070 1998-10-02 Nathan Bryant <bryant@cs.usm.maine.edu>
1071 * configure.in: autologin now defaults to disabled
1073 Fri Oct 2 00:04:31 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1074 * Finally removed all three usersupp.foo[MAXROOMS] elements, and
1075 migrated all the code that used them to use "struct visit" instead.
1077 Thu Oct 1 23:02:20 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1078 * Rewrote [l][get|put]room() functions to use room names rather than
1079 room index numbers. Temporarily prepended a "n" to these four
1080 function names until they are put to use.
1082 Thu Oct 1 16:27:13 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1083 * Removed a few more references to usersupp.lastseen[]
1085 1998-10-01 Nathan Bryant <bryant@cs.usm.maine.edu>
1086 * .cvsignore: add so_locations (generated by osf1 ld with shared libs)
1087 * Makefile.in: restructured variables for greater consistency, use
1088 @echo to print out notices during the make process, add so_locations
1090 * configure.in, Makefile.in: configure checks for -rdynamic
1091 * ipc_c_tcp.c: fix DEC compiler warning wrt unsigned char
1092 * stats.c: add semicolon to placate DREC compiler
1093 * user_ops.c: define _POSIX_C_SOURCE, include <limits.h>
1094 * configure.in: pass -pthread to DEC compiler, don't check for
1095 libpthread[s] on DEC Unix
1097 1998-09-30 Nathan Bryant <bryant@cs.usm.maine.edu>
1098 * Makefile.in: new variable PTHREAD_DEFS for portability
1099 * aidepost.c, citadel.c, citmail.c, mailinglist.c, msgform.c,
1100 netmailer.c, netpoll.c, netproc.c, rcit.c, readlog.c, setup.c,
1101 stats.c, userlist.c, whobbs.c: return type of main() is int
1102 * citadel.c, commands.c, messages.c: use time_t properly
1103 * citserver.c: include <limits.h>
1104 * config.guess, config.sub, install-sh: new files
1105 * configure.in: don't use gcc on Digital Unix
1107 Tue Sep 29 23:17:34 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1108 * room_ops.c: modified usergoto() to look at the new data structures
1109 for counting new messages and such.
1111 1998-09-29 Nathan Bryant <bryant@cs.usm.maine.edu>
1112 * user_ops.c: fix compiler warning and potential memory leak,
1114 * configure.in, Makefile.in: only build the server if we find pthreads
1115 * Makefile.in: realclean removes config.{cache,log,status}
1117 Tue Sep 29 13:20:14 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1118 * Removed code from some of the utilities which was still attempting
1119 to access the old non-gdbm data store.
1120 * housekeeping.c: rewrote check_ref_counts() to do a ForEachRoom()
1121 traversal instead of a MAXROOMS loop.
1122 * sysdep.c: set up a dummy CitContext record to be used during server
1123 startup, during which time there is no real context.
1125 Mon Sep 28 23:51:51 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1126 * Implemented the function ForEachRoom() to handle all-rooms traversal
1127 (this will work with both the old and new paradigms, because both
1128 use a GDBM database with one room per record). Migrated all room
1129 list commands to use it.
1131 Mon Sep 28 22:05:35 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1132 * Implemented the function CtdlRoomAccess() to handle *all* of the
1133 user-access-to-rooms functionality. Migrated all room list commands
1134 to use it. Still need to migrate gotos.
1136 1998-09-28 Nathan Bryant <bryant@cs.usm.maine.edu>
1137 * configure.in, acconfig.h: new files; partially functional GNU
1138 autoconf configure script. Run autoheader; autoconf; ./configure
1139 --prefix=`pwd` to test.
1140 * Makefile.tmpl: new file; this is what Makefile.in used to be. Used by
1142 * Makefile.in: modified to work with autoconf-style configure script
1143 * Configure: modified to use Makefile.tmpl and generate autoconf-style
1144 macros. Removed procfs detection. Pass -O2 to gcc, -O to other
1145 compilers. Removed mknod/mkfifo detection; code should use mkfifo(3).
1146 * citmail.c, msgform.c, netproc.c, routines.c, support.c, userlist.c,
1147 whobbs.c: use HAVE_STRERROR macro rather than NO_STRERROR
1148 * commands.c: use HAVE_TERMIOS_H macro rather than POSIX_TERMIO
1149 * netproc.c: remove procfs stuff. simply attempt to kill the target
1150 process with signal zero instead; this checks whether the process
1152 * setup.c, useradmin.c: use HAVE_CURSES_H macro
1154 Sun Sep 27 23:41:29 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1155 * BOTH the old and new generation systems are being written to at
1156 this point. Code that reads stuff is still using the old system.
1158 Sun Sep 27 16:10:49 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1159 * Changed all "generation" variables from char to long, in preparation
1160 for removing MAXROOMS. Generations for new rooms are now timestamps.
1161 * Defined "struct visit" to hold user/room relationships.
1162 * Removed some #define's from citadel.h that are no longer used.
1164 Wed Sep 23 13:41:49 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1165 * More changes to support attachments. They mostly work, but only
1166 in fixed-format messages.
1168 Mon Sep 21 21:19:17 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1169 * msgbase.c: began laying the groundwork to support attachments.
1170 Purchased Rogaine(tm) in preparation for expected hair loss.
1172 1998-09-21 Nathan Bryant <bryant@cs.usm.maine.edu>
1173 * msgbase.c: include dynloader.h
1174 * citadelapi.h: removed
1175 * dynloader.h: prototype CtdlRegisterUserHook()
1177 Sun Sep 20 18:56:37 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1178 * Added a UserFunctionHook category to implement hooks which perform
1179 operations on various users or usernames
1181 Fri Sep 18 21:14:41 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1182 * citserver.c: removed cmd_extn() and related code
1184 1998-09-18 Nathan Bryant <bryant@cs.usm.maine.edu>
1185 * user_ops.c: include dynloader.h
1186 * roomstats.{c,mk}: removed
1187 * Configure, Makefile.in: autodependency-related fixes
1189 Thu Sep 17 22:55:29 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1190 * Various changes to allow "new messages" to work correctly with Mail
1192 Thu Sep 17 22:21:45 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1193 * server.h, dynloader.c, citserver.c, user_ops.c: reduced the number
1194 of hook types by inventing an EventType field to the Session hook.
1195 * proxy.c: added pre-fetching
1197 1998-09-17 Nathan Bryant <bryant@cs.usm.maine.edu>
1198 * Makefile.in: add SERV_MODULES and PROXY_TARGETS to `cleaner'
1199 * dynloader.[ch], serv_{chat,test}.[ch], sysdep.c: cleaned
1200 up the dynamic loader interface as follows:
1201 - all the symbol table stuff is gone.
1202 - modules are loaded once at server startup and never unloaded.
1203 - Added a new function CtdlRegisterProtoHook() to handle the stuff
1204 that was being done with the symbol tables.
1205 - Dynamic_Module_Init() now returns a pointer to a static struct
1206 DLModule_Info; this structure itself has been modified to use char*
1207 fields instead of fixed char arrays.
1208 * roomstats.c: include <stdarg.h> not <stdargs.h> (is this file still
1210 * Configure, Makefile.in: added autodependency support
1212 Wed Sep 16 22:25:13 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1213 * Implemented separate structs, lists, and functions for each type
1214 of server-side hook available.
1216 1998-09-16 Nathan Bryant <bryant@cs.usm.maine.edu>
1217 * ipc_c_tcp.c: Fixed up some #include/prototyping stuff, call memcpy()
1220 * sysdep.c, user_ops.c: removed reference to hooks.h
1222 Wed Sep 16 11:42:42 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1223 * ipc_c_tcp.c: Reversed any changes that have been made to this file,
1224 because something was causing abominally slow response time.
1225 * proxy.c: added. This will eventually become a caching, pre-fetching
1226 multiuser proxy server for the Citadel protocol.
1228 1998-09-15 Nathan Bryant <bryant@cs.usm.maine.edu>
1229 * Makefile.in: remove support.o from serv_chat.so, add -fPIC to compile
1230 flags for serv_chat.o
1231 * dynloader.c: include "sysdep_decls.h", use RTLD_NOW not RTLD_LAZY
1232 * dynloader.h: prototype CtdlRegisterHook()
1233 * .cvsignore: added data
1235 Mon Sep 14 20:49:08 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1236 * Tried my hand at adding the ability for server extensions to
1237 register various types of "hooks" in addition to just adding
1238 server commands. This is probably not final.
1240 Tue Sep 8 12:11:56 EDT 1998 Brian Costello <btx@calyx.net>
1241 * Added support for dynamic server modules. Reworked serv_chat.c
1242 to be such a module.
1244 Tue Sep 1 23:09:50 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1245 * userpurge.c: rewrote using functions from the server core, rather
1246 than the now-defunct external API. This'll be ready once the module
1247 loading code is done. (I just had to commit _something_ tonight.)
1249 Mon Aug 31 22:47:58 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1250 * Yanked the citadelapi.c module. This wasn't working out well.
1251 * techdocs/citadelapi.txt - began documenting the new API to be used
1252 by modules which will be dynamic linked into the server - most of
1253 this API is existing server functions.
1254 * Added a ForEachUser() function with callback mechanism, and reworked
1255 cmd_list() to use it.
1257 Sun Aug 30 21:52:43 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1258 * Moved all of the gdbm databases to a separate "data" directory.
1260 1998-08-26 Nathan Bryant <bryant@cs.usm.maine.edu>
1261 * Makefile.in: realclean removes Makefile, fixed `touch citadel.h'
1264 1998-08-25 Nathan Bryant <bryant@cs.usm.maine.edu>
1265 * room_ops.c: include time.h
1266 * userlist.c, whobbs.c, serv_chat.c, user_ops.c, sysdep.c, stats.c,
1267 citadel_decls.h, commands.c, messages.h, routines.h, routines2.h:
1268 remove duplicated declarations
1270 Mon Aug 24 23:45:01 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1271 * setup.c: Removed yesno_s()
1272 * citadel.h, room_ops.c: added QRmtime field to struct quickroom,
1273 modified whenever a room is modified or posted in.
1274 * citadelapi.c: Added CtdlForEachRoom() function
1276 Mon Aug 24 20:04:04 EDT 1998 Nathan Bryant <bryant@cs.usm.maine.edu>
1277 * Makefile.in: new target `cleaner' does the same as `realclean'
1278 without removing sysdep.h
1279 * proto.h: is bad. eliminate. I've moved the prototypes into several
1280 header files, one per .c file
1282 Mon Aug 24 00:45:55 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1283 * Added a CtdlGotoRoom() function to the CitadelAPI.
1285 Sun Aug 23 21:47:00 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1286 * sysoputil is finally dead! Removed it from the build.
1287 * Added userpurge.c server extension (initial implementation)
1289 Tue Aug 18 00:42:33 EDT 1998 Nathan Bryant <bryant@cs.usm.maine.edu>
1290 * Makefile.in: `clean' target no longer rm's sysdep.h; new target
1291 `realclean' removes everything clean does, plus sysdep.h, plus
1293 * Configure: add -Wstrict-prototypes to CFLAGS for gcc systems
1294 * *.[ch]: protoized. Added several new header files containing
1295 prototypes and other external declarations; many duplicated
1296 declarations still should be moved to header files. proto.h must die
1299 Mon Aug 17 23:52:13 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1300 * Implemented a bunch of user account related functions in the
1303 Mon Aug 17 20:01:18 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1304 * Fixed the crash problem. It wasn't AGUP/ASUP, but rather a buffer
1305 overrun in getuser() (thanks, Nathan). Implemented overrun checks
1306 in getuser(), getroom(), and getfloor() to prevent future problems.
1308 Mon Aug 17 00:06:52 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1309 * Updated citmail.c with the latest stuff from the production system.
1310 * Implemented AGUP and ASUP commands, but AGUP crashes the server
1311 after its first successful use (user-not-found's don't affect it).
1313 Thu Aug 6 19:25:01 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1314 * Got the CitadelAPI library to the point where the server can start
1315 up an extension, and the extension will connect to the server, do
1316 some initialization, call a user-supplied CtdlMain(), and exit. Also
1317 hacked together a _temporary_ form of the new EXTN server command.
1319 Wed Aug 5 23:02:22 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1320 * Second attempt at getting the server API started. Now it runs
1321 outside of the server and builds a connection.
1323 Tue Aug 4 18:33:06 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1324 * Modified the appearance of Internet addresses when they arrive on
1326 * Removed the <E> field from the message format writeup in hack.txt.
1327 * Fixed-up citmail.c so that it doesn't try to do database lookups.
1329 Mon Aug 3 23:01:37 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1330 * Started developing the server-side API. This is in its very
1331 initial stages. See serverapi.c and techdoc/api.txt
1333 1998-08-02 Nathan Bryant <bryant@cs.usm.maine.edu>
1334 * Makefile.in: added config_decls.h to dependencies
1336 Sun Aug 2 21:09:09 EDT 1998 Nathan Bryant <bryant@cs.usm.maine.edu>
1337 * config_defs.h: renamed to config_decls.h
1338 * config.c, sysoputil.c: updated to reflect the above
1340 Sun Aug 2 18:52:05 EDT 1998 Nathan Bryant <bryant@cs.usm.maine.edu>
1341 * config_defs.h: new file, contains external declarations from config.c
1342 * config.c: moved defs to config_defs.h, use PATH_MAX from <limits.h>
1343 for bbs_home_directory
1344 * mailinglist.c, support.c: include <string.h>
1345 * sysoputil.c: include <string.h>, <limits.h>, "config_defs.h", remove
1346 duplicated defs, replace gets() call with fgets()
1347 * user_ops.c: define _XOPEN_SOURCE_EXTENDED
1349 Sat Aug 1 18:32:52 EDT 1998 Nathan Bryant <bryant@cs.usm.maine.edu>
1350 * ipc_c_tcp.c: fixed order of memcpy parameters after gethostbyname
1352 Sun Jul 19 17:26:12 EDT 1998 Nathan Bryant <bryant@cs.usm.maine.edu>
1353 * ChangeLog: reordered; the GNU standard is to add new entries to the
1355 * .cvsignore: added userlist
1357 Sun Jul 12 20:58:59 EDT 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1358 * Finished migrating everything to the new data store.
1359 * Replaced the binary "calllog" with the ASCII "citadel.log"
1360 * Began converting broken utilities that depend on the old data store
1362 Sat Jul 11 00:20:48 EDT 1998 Nathan Bryant <bryant@cs.usm.maine.edu>
1363 * Makefile.in: removed msgstats
1365 Fri Jul 10 1998 Art Cancro <ajc@uncnsrd.mt-kisco.ny.us>
1366 * Initial CVS import