Remove passwords from the LIST server command, even
authorArt Cancro <ajc@citadel.org>
Mon, 16 Jun 2008 13:01:56 +0000 (13:01 +0000)
committerArt Cancro <ajc@citadel.org>
Mon, 16 Jun 2008 13:01:56 +0000 (13:01 +0000)
for Aides.  This is a security risk.

citadel/user_ops.c

index 6baed0b2ee2607b20cba91b333a19c4d3ecec395..a7504f0e418a0de7d82cb30dcda26172a2a40177 100644 (file)
@@ -1648,16 +1648,13 @@ void ListThisUser(struct ctdluser *usbuf, void *data)
                if ((CC->user.axlevel >= 6)
                    || ((usbuf->flags & US_UNLISTED) == 0)
                    || ((CC->internal_pgm))) {
-                       cprintf("%s|%d|%ld|%ld|%ld|%ld|",
+                       cprintf("%s|%d|%ld|%ld|%ld|%ld||\n",
                                usbuf->fullname,
                                usbuf->axlevel,
                                usbuf->usernum,
                                (long)usbuf->lastcall,
                                usbuf->timescalled,
                                usbuf->posted);
-                       if (CC->user.axlevel >= 6)
-                               cprintf("%s", usbuf->password);
-                       cprintf("\n");
                }
        }
 }