Add some comments to rename_user indicating why the code is bad.

It traverses an unlocked context list and it leaves a big hole for
the actual operation to do something unexpected.

diff --git a/citadel/user_ops.c b/citadel/user_ops.c
index 7c9ed32b33630c7cd32926a0ef1a37a9ba0e1eab..6cbef4ff0bf3d7cb5306dc6ea01ff38b23ba6b2b 100644 (file)
--- a/citadel/user_ops.c
+++ b/citadel/user_ops.c
@@ -209,6 +209,7 @@ int rename_user(char *oldname, char *newname) {
  * We check that the user is not already logged in because we can't rename them
  * if they are logged in.
  * BUT THEN WE LEAVE A HUGE WINDOW FOR THEM TO LOG IN BEFORE WE LOCK TO RENAME THEM!!!!!
+ * We are also traversing an un-locked context list which is a very bad thing to do.
  */
        for (cptr = ContextList; cptr != NULL; cptr = cptr->next) {
                if (!strcasecmp(cptr->user.fullname, oldname)) {