Define a consistent way to turn message id into thread id hash

diff --git a/webcit/blogview_renderer.c b/webcit/blogview_renderer.c
index 1320c5497a92b95555e96da34fba958fb4fd2858..9c66093c8ac2631a16bdd1d4e00b789c4c063729 100644 (file)
--- a/webcit/blogview_renderer.c
+++ b/webcit/blogview_renderer.c
@@ -146,12 +146,12 @@ struct bltr blogview_learn_thread_references(long msgnum)
                {
                        if (!strncasecmp(ChrPtr(Buf), "msgn=", 5)) {
                                StrBufCutLeft(Buf, 5);
-                               bltr.id = abs(HashLittle(ChrPtr(Buf), StrLength(Buf)));
+                               bltr.id = ThreadIdHash(Buf);
                        }
                        else if (!strncasecmp(ChrPtr(Buf), "wefw=", 5)) {
                                StrBufCutLeft(Buf, 5);          /* trim the field name */
                                StrBufExtract_token(r, Buf, 0, '|');
-                               bltr.refs = abs(HashLittle(ChrPtr(r), StrLength(r)));
+                               bltr.refs = ThreadIdHash(r);
                        }
                }
        }

diff --git a/webcit/webcit.h b/webcit/webcit.h
index 022ed2d83f145adbfb3d1bb183e87f799428cfaa..ccd2b779d571590cab76edd8d71160319a95ff46 100644 (file)
--- a/webcit/webcit.h
+++ b/webcit/webcit.h
@@ -887,6 +887,9 @@ void http_datestring(char *buf, size_t n, time_t xtime);
 
 extern int time_to_die;                        /* Nonzero if server is shutting down */
 
+/* a nice consistent place to define how we turn a message id into a thread id hash */
+#define ThreadIdHash(Buf) abs(HashLittle(ChrPtr(Buf), StrLength(Buf)))
+
 /* 
  * Array type for a blog post.  The first message is the post; the rest are comments
  */