speedup Networker scheduling
authorWilfried Goesgens <dothebart@citadel.org>
Sun, 22 Jan 2012 23:26:07 +0000 (00:26 +0100)
committerWilfried Goesgens <dothebart@citadel.org>
Sun, 22 Jan 2012 23:26:07 +0000 (00:26 +0100)
  - iterate the netconfigs dir first to find out which rooms we realy care about
  - store roomnames case insensitive
  - store length
  - calculate the key of roomnames, so that while sorting out dupes its cheaper
  - minimize the locking of the roomlist by just swapping out the pointers while we process one list.

citadel/citserver.h
citadel/modules/network/netspool.h
citadel/modules/network/serv_netspool.c
citadel/modules/network/serv_network.c
citadel/modules/network/serv_network.h

index 1235a81d865ef40fbd01fb755816ab844b2737f6..b89e4e0f859d86515ec2bf393eb21abe73832cde 100644 (file)
 #include "context.h"
 
 /* Simple linked list structures ... used in a bunch of different places. */
+typedef struct RoomProcList RoomProcList;
 struct RoomProcList {
         struct RoomProcList *next;
         char name[ROOMNAMELEN];
+        char lcname[ROOMNAMELEN];
+       long namelen;
+       long key;
+       long QRNum;
 };
 struct UserProcList {
        struct UserProcList *next;
index 7e26e28af27ced81456a3c5b9228ce938aac4542..0c0364ce34c8c8fae9bbec34d045b054088f1d0e 100644 (file)
@@ -24,7 +24,7 @@ struct SpoolControl {
 };
 
 
-void network_spoolout_room(char *room_to_spool,                       
+void network_spoolout_room(RoomProcList *room_to_spool,                       
                           char *working_ignetcfg,
                           NetMap *the_netmap);
 void network_do_spoolin(char *working_ignetcfg, NetMap **the_netmap, int *netmap_changed);
index fbd0eb0e5f6bf9b13e6028fe3c34b0637e9f261d..06fa3a82f5a3c8e142d09b2272f8980c85f19244 100644 (file)
@@ -380,7 +380,7 @@ int is_recipient(SpoolControl *sc, const char *Name)
 /*
  * Batch up and send all outbound traffic from the current room
  */
-void network_spoolout_room(char *room_to_spool,                       
+void network_spoolout_room(RoomProcList *room_to_spool,                       
                           char *working_ignetcfg,
                           NetMap *the_netmap)
 {
@@ -394,8 +394,8 @@ void network_spoolout_room(char *room_to_spool,
         * Normally this should never happen, but once in a while maybe a room gets
         * queued for networking and then deleted before it can happen.
         */
-       if (CtdlGetRoom(&CC->room, room_to_spool) != 0) {
-               syslog(LOG_CRIT, "ERROR: cannot load <%s>\n", room_to_spool);
+       if (CtdlGetRoom(&CC->room, room_to_spool->name) != 0) {
+               syslog(LOG_CRIT, "ERROR: cannot load <%s>\n", room_to_spool->name);
                return;
        }
 
@@ -893,7 +893,7 @@ CTDL_MODULE_INIT(network_spool)
        if (!threading)
        {
                create_spool_dirs();
-               CtdlRegisterCleanupHook(destroy_network_queue_room);
+//////todo             CtdlRegisterCleanupHook(destroy_network_queue_room);
        }
        return "network_spool";
 }
index 7062a15f53213ddd4a609a4aa127abf7ee52232f..234a7722f0f1923773b0d0c066a9dac152935359 100644 (file)
 #include "netmail.h"
 #include "ctdl_module.h"
 
+/* comes from lookup3.c from libcitadel... */
+extern uint32_t hashlittle( const void *key, size_t length, uint32_t initval);
 
-
+typedef struct __roomlists {
+       RoomProcList *rplist;
+       HashList *RoomsInterestedIn;
+}roomlists;
 /*
  * When we do network processing, it's accomplished in two passes; one to
  * gather a list of rooms and one to actually do them.  It's ok that rplist
  */
 struct RoomProcList *rplist = NULL;
 
+int GetNetworkedRoomNumbers(const char *DirName, HashList *DirList)
+{
+       DIR *filedir = NULL;
+       struct dirent *d;
+       struct dirent *filedir_entry;
+       long RoomNR;
+       long Count;
+               
+       filedir = opendir (DirName);
+       if (filedir == NULL) {
+               return 0;
+       }
+
+       d = (struct dirent *)malloc(offsetof(struct dirent, d_name) + PATH_MAX + 1);
+       if (d == NULL) {
+               return 0;
+       }
 
+       while ((readdir_r(filedir, d, &filedir_entry) == 0) &&
+              (filedir_entry != NULL))
+       {
+               RoomNR = atol(filedir_entry->d_name);
+               if (RoomNR != 0) {
+                       Count++;
+                       Put(DirList, LKEY(RoomNR), &Count, reference_free_handler);
+               }
+       }
+       free(d);
+       closedir(filedir);
+       return Count;
+}
 
 
 
@@ -250,39 +285,89 @@ void cmd_nsyn(char *argbuf) {
 
 
 
+/*
+ * Batch up and send all outbound traffic from the current room
+ */
+void network_queue_interesting_rooms(struct ctdlroom *qrbuf, void *data) {
+       int i;
+       struct RoomProcList *ptr;
+       long QRNum = qrbuf->QRnumber;
+       void *v;
+       roomlists *RP = (roomlists*) data;
+
+       if (!GetHash(RP->RoomsInterestedIn, LKEY(QRNum), &v))
+               return;
+
+       ptr = (struct RoomProcList *) malloc(sizeof (struct RoomProcList));
+       if (ptr == NULL) return;
+
+       ptr->namelen = strlen(qrbuf->QRname);
+       if (ptr->namelen > ROOMNAMELEN)
+               ptr->namelen = ROOMNAMELEN - 1;
+
+       memcpy (ptr->name, qrbuf->QRname, ptr->namelen);
+       ptr->name[ptr->namelen] = 0;
+       ptr->QRNum = qrbuf->QRnumber;
+
+       for (i = 0; i < ptr->namelen; i++)
+       {
+               ptr->lcname[i] = tolower(ptr->name[i]);
+       }
+
+       ptr->key = hashlittle(ptr->lcname, ptr->namelen, 9872345);
+       ptr->next = RP->rplist;
+       RP->rplist = ptr;
+}
+
 /*
  * Batch up and send all outbound traffic from the current room
  */
 void network_queue_room(struct ctdlroom *qrbuf, void *data) {
+       int i;
        struct RoomProcList *ptr;
 
        ptr = (struct RoomProcList *) malloc(sizeof (struct RoomProcList));
        if (ptr == NULL) return;
 
-       safestrncpy(ptr->name, qrbuf->QRname, sizeof ptr->name);
+       ptr->namelen = strlen(qrbuf->QRname);
+       if (ptr->namelen > ROOMNAMELEN)
+               ptr->namelen = ROOMNAMELEN - 1;
+
+       memcpy (ptr->name, qrbuf->QRname, ptr->namelen);
+       ptr->name[ptr->namelen] = 0;
+       ptr->QRNum = qrbuf->QRnumber;
+
+       for (i = 0; i < ptr->namelen; i++)
+       {
+               ptr->lcname[i] = tolower(ptr->name[i]);
+       }
+
+       ptr->key = hashlittle(ptr->lcname, ptr->namelen, 9872345);
        begin_critical_section(S_RPLIST);
        ptr->next = rplist;
        rplist = ptr;
        end_critical_section(S_RPLIST);
 }
 
-void destroy_network_queue_room(void)
+void destroy_network_queue_room(RoomProcList *rplist)
 {
        struct RoomProcList *cur, *p;
 
        cur = rplist;
-       begin_critical_section(S_RPLIST);
        while (cur != NULL)
        {
                p = cur->next;
                free (cur);
                cur = p;                
        }
-       rplist = NULL;
-       end_critical_section(S_RPLIST);
 }
 
-
+void destroy_network_queue_room_locked (void)
+{
+       begin_critical_section(S_RPLIST);
+       destroy_network_queue_room(rplist);
+       end_critical_section(S_RPLIST);
+}
 
 
 
@@ -405,11 +490,11 @@ void network_bounce(struct CtdlMessage *msg, char *reason) {
 void network_do_queue(void) {
        static int doing_queue = 0;
        static time_t last_run = 0L;
-       struct RoomProcList *ptr;
        int full_processing = 1;
        char *working_ignetcfg;
        NetMap *the_netmap = NULL;
        int netmap_changed = 0;
+       roomlists RL;
 
        /*
         * Run the full set of processing tasks no more frequently
@@ -433,6 +518,19 @@ void network_do_queue(void) {
        }
        doing_queue = 1;
 
+       begin_critical_section(S_RPLIST);
+       RL.rplist = rplist;
+       rplist = NULL;
+       end_critical_section(S_RPLIST);
+
+       RL.RoomsInterestedIn = NewHash(1, lFlathash);
+       if (!GetNetworkedRoomNumbers(ctdl_netcfg_dir, RL.RoomsInterestedIn))
+       {
+               doing_queue = 0;
+               DeleteHash(&RL.RoomsInterestedIn);
+               if (RL.rplist == NULL)
+                       return;
+       }
        /* Load the IGnet Configuration into memory */
        working_ignetcfg = load_working_ignetcfg();
 
@@ -447,34 +545,34 @@ void network_do_queue(void) {
         */
        if (full_processing && !server_shutting_down) {
                syslog(LOG_DEBUG, "network: loading outbound queue\n");
-               CtdlForEachRoom(network_queue_room, NULL);
+               CtdlForEachRoom(network_queue_interesting_rooms, &RL);
        }
 
-       if (rplist != NULL) {
+       if (RL.rplist != NULL) {
+               RoomProcList *ptr, *cmp;
+               ptr = RL.rplist;
                syslog(LOG_DEBUG, "network: running outbound queue\n");
-               while (rplist != NULL && !server_shutting_down) {
-                       char spoolroomname[ROOMNAMELEN];
-                       safestrncpy(spoolroomname, rplist->name, sizeof spoolroomname);
-                       begin_critical_section(S_RPLIST);
-
-                       /* pop this record off the list */
-                       ptr = rplist;
-                       rplist = rplist->next;
-                       free(ptr);
-
-                       /* invalidate any duplicate entries to prevent double processing */
-                       for (ptr=rplist; ptr!=NULL; ptr=ptr->next) {
-                               if (!strcasecmp(ptr->name, spoolroomname)) {
-                                       ptr->name[0] = 0;
+               while (ptr != NULL && !server_shutting_down) {
+                       
+                       cmp = ptr->next;
+
+                       while (cmp != NULL) {
+                               if ((cmp->namelen > 0) &&
+                                   (cmp->key == ptr->key) &&
+                                   (cmp->namelen == ptr->namelen) &&
+                                   (strcmp(cmp->lcname, ptr->lcname) == 0))
+                               {
+                                       cmp->namelen = 0;
                                }
+                               cmp = cmp->next;
                        }
 
-                       end_critical_section(S_RPLIST);
-                       if (spoolroomname[0] != 0) {
-                               network_spoolout_room(spoolroomname, 
+                       if (ptr->namelen > 0) {
+                               network_spoolout_room(ptr, 
                                                      working_ignetcfg,
                                                      the_netmap);
                        }
+                       ptr = ptr->next;
                }
        }
 
@@ -499,7 +597,7 @@ void network_do_queue(void) {
        if (full_processing) {
                last_run = time(NULL);
        }
-
+       destroy_network_queue_room(RL.rplist);
        doing_queue = 0;
 }
 
@@ -522,7 +620,7 @@ CTDL_MODULE_INIT(network)
        {
                CtdlRegisterProtoHook(cmd_nsyn, "NSYN", "Synchronize room to node");
                CtdlRegisterRoomHook(network_room_handler);
-               CtdlRegisterCleanupHook(destroy_network_queue_room);
+               CtdlRegisterCleanupHook(destroy_network_queue_room_locked);
                CtdlRegisterSessionHook(network_do_queue, EVT_TIMER);
        }
        return "network";
index a855ca46293d97a08184884c24d7d597c8a5efd3..549959079c1b5bf8ff69a86a2a7521d267ee1429 100644 (file)
@@ -13,7 +13,7 @@ void load_network_filter_list(void);
 
 
 void network_queue_room(struct ctdlroom *, void *);
-void destroy_network_queue_room(void);
+////void destroy_network_queue_room(void);
 void network_bounce(struct CtdlMessage *msg, char *reason);
 int network_usetable(struct CtdlMessage *msg);