citadel.git
16 years agoSolution to bug no. 258 (forging of from headers with IMAP move)
Dave West [Sun, 28 Oct 2007 11:48:04 +0000 (11:48 +0000)]
Solution to bug no. 258 (forging of from headers with IMAP move)
I have implimented a configuration option in the site wide
configuration.
It is now possible to have Citadel keep the original from headers for
the message.

16 years agocome back to transparent buttons for messages, use the same way for display messages...
Thierry Pasqualier [Sun, 28 Oct 2007 07:31:24 +0000 (07:31 +0000)]
come back to transparent buttons for messages, use the same way for display messages actions, login and log off buttons

16 years agoical_putics() now calls ical_write_to_cal() with
Art Cancro [Sun, 28 Oct 2007 04:38:08 +0000 (04:38 +0000)]
ical_putics() now calls ical_write_to_cal() with
a NULL user.  ical_write_to_cal() has been modified so that
if it is called with a NULL user, it saves the supplied
calendar item to the currently selected room instead of
the user's default calendar.  RESOLVES BUG #255

16 years agoFixed the bug that results in non update of existing LDAP entries when
Dave West [Sat, 27 Oct 2007 23:57:36 +0000 (23:57 +0000)]
Fixed the bug that results in non update of existing LDAP entries when
detail is removed.

16 years agoReduced the timeout for LDAP disconnect to 1 minute due to granularity
Dave West [Sat, 27 Oct 2007 23:28:20 +0000 (23:28 +0000)]
Reduced the timeout for LDAP disconnect to 1 minute due to granularity
of the time this is 1 minute + 0-59 seconds.

16 years agoFixed bug No. 252. Changing the room settings of a personal mail box no
Dave West [Sat, 27 Oct 2007 22:53:32 +0000 (22:53 +0000)]
Fixed bug No. 252. Changing the room settings of a personal mail box no
longer makes the room public.
Also it is now possible to change a room to have it become a personal
mailbox.
Also copied the code from the create room stuff to disable the floor
combo box.

16 years agoUser can now choose to hide or display floors that contain no rooms
Dave West [Sat, 27 Oct 2007 20:43:31 +0000 (20:43 +0000)]
User can now choose to hide or display floors that contain no rooms
visible to them.

16 years agoAdded support for mobile phone number and fax number to the LDAP module.
Dave West [Sat, 27 Oct 2007 15:35:55 +0000 (15:35 +0000)]
Added support for mobile phone number and fax number to the LDAP module.

16 years agoFixed the mobile phone number in the vCard so it has the correct
Dave West [Sat, 27 Oct 2007 15:15:57 +0000 (15:15 +0000)]
Fixed the mobile phone number in the vCard so it has the correct
attribute name.

16 years agoAdded mobile phone number to vCard
Dave West [Sat, 27 Oct 2007 14:47:05 +0000 (14:47 +0000)]
Added mobile phone number to vCard

16 years agoAdded a fax number to the vCard.
Dave West [Sat, 27 Oct 2007 14:20:31 +0000 (14:20 +0000)]
Added a fax number to the vCard.

16 years agoUpdated the mime parser in webcit
Art Cancro [Fri, 26 Oct 2007 21:13:07 +0000 (21:13 +0000)]
Updated the mime parser in webcit

16 years agoreduction of spacing between boxes on advanced screen
Thierry Pasqualier [Fri, 26 Oct 2007 21:07:12 +0000 (21:07 +0000)]
reduction of spacing between boxes on advanced screen

16 years ago* some minor CSS changes
Thierry Pasqualier [Fri, 26 Oct 2007 20:40:13 +0000 (20:40 +0000)]
* some minor CSS changes
* the buttons of messages are now displayed as the other buttons

16 years agoUpdated extract_key() in mime_parser.c
Art Cancro [Fri, 26 Oct 2007 20:22:32 +0000 (20:22 +0000)]
Updated extract_key() in mime_parser.c
We now handle the rare situation in which the 'boundary'
key is not the last key in the content type declaration.  This
fixes the occasional 'Unexpected end of message (2)' error in
WebCit.

TODO: copy updated mime parser to webcit

16 years agoreduction of spacing between boxes on summary screen
Thierry Pasqualier [Fri, 26 Oct 2007 18:38:56 +0000 (18:38 +0000)]
reduction of spacing between boxes on summary screen

16 years ago* handle webcit version through sysdep.h
Wilfried Göesgens [Thu, 25 Oct 2007 21:51:16 +0000 (21:51 +0000)]
* handle webcit version through sysdep.h

16 years ago* 7.22 here too.
Wilfried Göesgens [Thu, 25 Oct 2007 20:54:18 +0000 (20:54 +0000)]
* 7.22 here too.

16 years agoUpdated WebCit version number to 7.22
Art Cancro [Thu, 25 Oct 2007 20:40:05 +0000 (20:40 +0000)]
Updated WebCit version number to 7.22

16 years ago* if the client disconnects, abort the ARTV EXPORT
Wilfried Göesgens [Thu, 25 Oct 2007 20:08:20 +0000 (20:08 +0000)]
* if the client disconnects, abort the ARTV EXPORT

16 years agoHTML form variable 'summary' was used in two
Art Cancro [Thu, 25 Oct 2007 19:53:48 +0000 (19:53 +0000)]
HTML form variable 'summary' was used in two
different places: for the summary description of a calendar
event, and for a flag to tell the message reading loop to
display a mailbox summary view.  As a result, if an event
summary began with a number, and the number was not zero,
the flag would be set, causing a mailbox summary to appear
instead of the calendar after save/cancel.   Renamed the
latter variable to 'is_summary' to remove the conflict.

16 years ago* reduction of font size of who list on left bar
Thierry Pasqualier [Thu, 25 Oct 2007 18:58:08 +0000 (18:58 +0000)]
* reduction of font size of who list on left bar
* reduction of editor width

16 years agoDisplay ongoing events which begin or end on the current day
Thierry Pasqualier [Thu, 25 Oct 2007 06:22:24 +0000 (06:22 +0000)]
Display ongoing events which begin or end on the current day

16 years agoFix counting for events at the end of day
Thierry Pasqualier [Thu, 25 Oct 2007 06:18:11 +0000 (06:18 +0000)]
Fix counting for events at the end of day

16 years agoRemoved some spurious logging
Art Cancro [Thu, 25 Oct 2007 03:43:53 +0000 (03:43 +0000)]
Removed some spurious logging

16 years agoCalendar day view: complete in two passes (once
Art Cancro [Wed, 24 Oct 2007 21:56:37 +0000 (21:56 +0000)]
Calendar day view: complete in two passes (once
for the hour grid and once for the middle panel) instead
of 25 passes.

16 years agoupdated french translation
Thierry Pasqualier [Wed, 24 Oct 2007 21:06:04 +0000 (21:06 +0000)]
updated french translation

16 years agoCleaned up some of the comments
Art Cancro [Wed, 24 Oct 2007 20:06:15 +0000 (20:06 +0000)]
Cleaned up some of the comments

16 years agofix the tab.c bug with IE : removed a useless div. The round
Thierry Pasqualier [Wed, 24 Oct 2007 17:47:07 +0000 (17:47 +0000)]
fix the tab.c bug with IE : removed a useless div. The round
corners on the bottom on tab content don't still work...

16 years agofix short and ongoing events bug display. test it
Thierry Pasqualier [Wed, 24 Oct 2007 06:56:06 +0000 (06:56 +0000)]
fix short and ongoing events bug display. test it

16 years agoUpdated the embedded JavaScript in tabs.c
Art Cancro [Wed, 24 Oct 2007 05:00:52 +0000 (05:00 +0000)]
Updated the embedded JavaScript in tabs.c
to switch the class of tabs between tab_cell_label and
tab_cell_edit when different tabs are selected.

16 years ago* some debugging to the day view, and the date calculating functions. Temporarily...
Wilfried Göesgens [Tue, 23 Oct 2007 21:22:01 +0000 (21:22 +0000)]
* some debugging to the day view, and the date calculating functions. Temporarily moved oven a function from libical, as its bugged there.

16 years ago* print a hint where we are when we shut down, so we can find gmon.out
Wilfried Göesgens [Tue, 23 Oct 2007 21:20:50 +0000 (21:20 +0000)]
* print a hint where we are when we shut down, so we can find gmon.out

16 years ago* check if we can find the debian systems TZ setting.
Wilfried Göesgens [Tue, 23 Oct 2007 21:18:57 +0000 (21:18 +0000)]
* check if we can find the debian systems TZ setting.

16 years agoimplemented Bubble Tooltips on calendar day view
Thierry Pasqualier [Tue, 23 Oct 2007 17:22:19 +0000 (17:22 +0000)]
implemented Bubble Tooltips on calendar day view
correct the default hour value to create an event

16 years agoOnly generate CSR if it is determined that we will
Art Cancro [Tue, 23 Oct 2007 15:55:44 +0000 (15:55 +0000)]
Only generate CSR if it is determined that we will
need it in the next step to generate a self-signed
certificate.

16 years agoPretty buttons for Log Off screen
Thierry Pasqualier [Tue, 23 Oct 2007 08:50:14 +0000 (08:50 +0000)]
Pretty buttons for Log Off screen

16 years ago* resynced german translation.
Wilfried Göesgens [Mon, 22 Oct 2007 17:26:52 +0000 (17:26 +0000)]
* resynced german translation.

16 years agoCSS : pretty buttons to attendee's reply messages
Thierry Pasqualier [Sun, 21 Oct 2007 14:09:13 +0000 (14:09 +0000)]
CSS : pretty buttons to attendee's reply messages

16 years agoI noticed the bug found by Devew on October 16th:
Thierry Pasqualier [Sun, 21 Oct 2007 12:55:33 +0000 (12:55 +0000)]
I noticed the bug found by Devew on October 16th:
        If one creates an event but does not change the times of the
        event from the default values it doesn't show up in the day view at all.
But I have no solution. I suggest fixing the default value to 0 on the place of
9 hour. By waiting to fix it.

16 years agoThe iconbar text need to be darker
Thierry Pasqualier [Sat, 20 Oct 2007 16:01:34 +0000 (16:01 +0000)]
The iconbar text need to be darker

16 years agoupdated stylesheet
Thierry Pasqualier [Sat, 20 Oct 2007 15:49:03 +0000 (15:49 +0000)]
updated stylesheet

16 years agoiconsbar : come back with a little background white, keep the button in light blue
Thierry Pasqualier [Sat, 20 Oct 2007 14:18:23 +0000 (14:18 +0000)]
iconsbar : come back with a little background white, keep the button in light blue

16 years agoimproved inet conf screen : altern rows
Thierry Pasqualier [Sat, 20 Oct 2007 14:10:16 +0000 (14:10 +0000)]
improved inet conf screen : altern rows

16 years agoimproved inet conf screen
Thierry Pasqualier [Sat, 20 Oct 2007 13:54:14 +0000 (13:54 +0000)]
improved inet conf screen

16 years agoupdated tabbed dialog API
Thierry Pasqualier [Sat, 20 Oct 2007 12:13:26 +0000 (12:13 +0000)]
updated tabbed dialog API

16 years agofix Slight glitch in tabbed dialog CSS. I had lost px unit and ponctuation
Thierry Pasqualier [Sat, 20 Oct 2007 07:23:26 +0000 (07:23 +0000)]
fix Slight glitch in tabbed dialog CSS. I had lost px unit and ponctuation

16 years agoCreate and maintain a directory for pop3client uidl maps
Art Cancro [Sat, 20 Oct 2007 05:06:14 +0000 (05:06 +0000)]
Create and maintain a directory for pop3client uidl maps

16 years agoCreate a linked list with learned uidl's
Art Cancro [Sat, 20 Oct 2007 04:51:54 +0000 (04:51 +0000)]
Create a linked list with learned uidl's

16 years agoRetrieve POP3 UIDL for each message. (Not yet doing
Art Cancro [Fri, 19 Oct 2007 03:58:20 +0000 (03:58 +0000)]
Retrieve POP3 UIDL for each message.  (Not yet doing
anything with it but we need to build a UIDL map in order to
offer a 'leave messages on server' option).

16 years agoRewrote extract_key() without repeated calls to strlen().
Art Cancro [Thu, 18 Oct 2007 04:24:58 +0000 (04:24 +0000)]
Rewrote extract_key() without repeated calls to strlen().

16 years agoPOP3 aggregation client: transmit CRLF newlines instead
Art Cancro [Thu, 18 Oct 2007 02:47:54 +0000 (02:47 +0000)]
POP3 aggregation client: transmit CRLF newlines instead
of LF newlines.  No bonus points will be awarded for guessing whose
POP3 server is b0rken and doesn't auto-detect the type of newlines
being used: this fix gets the client to work properly with the
brain-dead Microsoft Exchange server.

16 years agoDay view work with IE 6 and IE 5.5
Thierry Pasqualier [Wed, 17 Oct 2007 19:47:06 +0000 (19:47 +0000)]
Day view work with IE 6 and IE 5.5

16 years ago* stat the socket before we try to open it, looks better like that in the log.
Wilfried Göesgens [Tue, 16 Oct 2007 21:27:50 +0000 (21:27 +0000)]
* stat the socket before we try to open it, looks better like that in the log.

16 years ago* implemented messagemode 2
Wilfried Göesgens [Tue, 16 Oct 2007 21:23:37 +0000 (21:23 +0000)]
* implemented messagemode 2
* customize logging, if we want to pipe our protocol-data to a logfile, we don't need html comments.
* don't return false if we're already logged in, as pdas tend to try to authenticate all the time.

16 years agofix banner spacing (search field and view select) for IE
Thierry Pasqualier [Tue, 16 Oct 2007 20:54:11 +0000 (20:54 +0000)]
fix banner spacing (search field and view select) for IE

16 years agoFixed a bug that could cause us to keep a temporary file open.
Dave West [Tue, 16 Oct 2007 13:10:20 +0000 (13:10 +0000)]
Fixed a bug that could cause us to keep a temporary file open.
When moving the network temporary spool file to the permanent spool
file, if the fopen of the permanent spool file fails then the temporary
spool file was not closed.

16 years agoAdded a comment to serv_ldap.c
Dave West [Tue, 16 Oct 2007 07:29:03 +0000 (07:29 +0000)]
Added a comment to serv_ldap.c
Fixed an obvious bug (according to the comments) with the \Answered flag
in IMAP.

16 years agoDay view : events with minutes
Thierry Pasqualier [Mon, 15 Oct 2007 20:15:51 +0000 (20:15 +0000)]
Day view : events with minutes

16 years agoMini month calendar is complete. The 'previous month'
Art Cancro [Mon, 15 Oct 2007 17:42:49 +0000 (17:42 +0000)]
Mini month calendar is complete.  The 'previous month'
and 'next month' buttons are using AJAX updater in order to
eliminate the need to re-render the entire screen.

16 years agoCal day view : introduce a gap for event which begin at same hour, display events...
Thierry Pasqualier [Mon, 15 Oct 2007 12:01:26 +0000 (12:01 +0000)]
Cal day view : introduce a gap for event which begin at same hour, display events with round corners (CSS3 - only Firefox)

16 years agoCal day view : fix a display bug with timezone
Thierry Pasqualier [Mon, 15 Oct 2007 11:25:38 +0000 (11:25 +0000)]
Cal day view : fix a display bug with timezone

16 years agoAdded a mini month calendar to the day view.
Art Cancro [Mon, 15 Oct 2007 04:22:06 +0000 (04:22 +0000)]
Added a mini month calendar to the day view.
Day links are hot, but the previous/next month links are
not yet working.

16 years agoCalendar day view :
Thierry Pasqualier [Sun, 14 Oct 2007 20:05:21 +0000 (20:05 +0000)]
Calendar day view :
* first implementation of ongoing events
* without minutes

16 years agoAdded new function calls for aide_message and lprintf.
Dave West [Sun, 14 Oct 2007 16:50:27 +0000 (16:50 +0000)]
Added new function calls for aide_message and lprintf.
Original names remain for compatability but they can now be called as
CtdlAideMessage and CtdlLogPrintf respectively to comply with the Coding
Style document.
You will need to include ctdl_module.h to use these new names.
Please use the new names from now on.

16 years agoNow we build the Makefile includes for user modules as well.
Dave West [Sun, 14 Oct 2007 15:45:34 +0000 (15:45 +0000)]
Now we build the Makefile includes for user modules as well.

16 years agoDay view : in progress. Without minutes
Thierry Pasqualier [Sun, 14 Oct 2007 14:13:27 +0000 (14:13 +0000)]
Day view : in progress. Without minutes

16 years agoAdded a simple comment to include/ctdl_module.h
Dave West [Sun, 14 Oct 2007 12:51:28 +0000 (12:51 +0000)]
Added a simple comment to include/ctdl_module.h
Added code to automatically include modules into the Makefile

16 years agoDaily vue of Calendar.
Thierry Pasqualier [Sun, 14 Oct 2007 09:41:00 +0000 (09:41 +0000)]
Daily vue of Calendar.
I began to rewrite my code.
IG and Dothebart: you can verify the coherence with your codes
I continue later to fix the calculations of position and height of each  events.
I fix later the events wich span several days

16 years agoRemove 'can_do_msg4' variable from client. If
Art Cancro [Sun, 14 Oct 2007 04:30:27 +0000 (04:30 +0000)]
Remove 'can_do_msg4' variable from client.  If
anyone is pointing a 2007 client at a pre-2002 server, they've
already got other problems.  This simplifies things a bit.

16 years ago* speed up imap_pick_range by getting the Imap-Context once.
Wilfried Göesgens [Sat, 13 Oct 2007 17:08:46 +0000 (17:08 +0000)]
* speed up imap_pick_range by getting the Imap-Context once.
* call strlen only once in imap_macro_replace.

16 years ago* speed up client_write by fetching the context once.
Wilfried Göesgens [Sat, 13 Oct 2007 17:03:21 +0000 (17:03 +0000)]
* speed up client_write by fetching the context once.

16 years ago* imap profiling: mimeparser: use MemReadlineLen, keep its value; avoid strlen in...
Wilfried Göesgens [Sat, 13 Oct 2007 16:00:59 +0000 (16:00 +0000)]
* imap profiling: mimeparser: use MemReadlineLen, keep its value; avoid strlen in frequent used places.

16 years ago* don't call the context getter to frequent.
Wilfried Göesgens [Sat, 13 Oct 2007 15:56:27 +0000 (15:56 +0000)]
* don't call the context getter to frequent.

16 years ago* Imap profiling: memreadline function that returns the copied stringlength so we...
Wilfried Göesgens [Sat, 13 Oct 2007 15:55:23 +0000 (15:55 +0000)]
* Imap profiling: memreadline function that returns the copied stringlength so we can use it after.

16 years ago* we need to compare sizeof int to sizeof sizet to switch this between 32 and 64...
Wilfried Göesgens [Sat, 13 Oct 2007 14:34:39 +0000 (14:34 +0000)]
* we need to compare sizeof int to sizeof sizet to switch this between 32 and 64 bits.

16 years agoQuick fix to day view; still needs a bit of tweaking
Art Cancro [Sat, 13 Oct 2007 05:32:49 +0000 (05:32 +0000)]
Quick fix to day view; still needs a bit of tweaking

16 years agoBrought back a *small* amount of time_t in order to cope with
Art Cancro [Sat, 13 Oct 2007 05:18:17 +0000 (05:18 +0000)]
Brought back a *small* amount of time_t in order to cope with
events that occur during those times of day when the date is different
in the local timezone than it is in UTC.

16 years agoRewrote the multi day event code using only the
Art Cancro [Sat, 13 Oct 2007 05:00:06 +0000 (05:00 +0000)]
Rewrote the multi day event code using only the
libical API and no time_t/localtime stuff.

16 years agoFix display of events hour per hour
Thierry Pasqualier [Fri, 12 Oct 2007 21:39:47 +0000 (21:39 +0000)]
Fix display of events hour per hour

16 years agoSlight change to previous commit.
Art Cancro [Fri, 12 Oct 2007 20:24:44 +0000 (20:24 +0000)]
Slight change to previous commit.
davew found that we should be using 'filename' not 'buf'
But we also need to set the buffer length to 'sizeof filename'
instead of 'sizeof buf'

16 years agoNew calendar day view (incomplete)
Thierry Pasqualier [Fri, 12 Oct 2007 20:24:35 +0000 (20:24 +0000)]
New calendar day view (incomplete)

16 years agoFixed a bug in serv_network.c that was causing strange files to appear
Dave West [Fri, 12 Oct 2007 20:18:40 +0000 (20:18 +0000)]
Fixed a bug in serv_network.c that was causing strange files to appear
in citadel home directory.
This may also have caused spooled messages to go missing, depends on who
polled who.

16 years agoFix function names to be in line with coding style.
Dave West [Fri, 12 Oct 2007 18:20:36 +0000 (18:20 +0000)]
Fix function names to be in line with coding style.

16 years agoBegin fix ups of coding style to get a bit closer to what is published
Dave West [Fri, 12 Oct 2007 17:55:44 +0000 (17:55 +0000)]
Begin fix ups of coding style to get a bit closer to what is published
style.
Ran indent -kr -i8 serv_ldap.c as per Wiki instructions.

16 years ago* DST-Hack for all day events too.
Wilfried Göesgens [Fri, 12 Oct 2007 13:15:39 +0000 (13:15 +0000)]
* DST-Hack for all day events too.

16 years agoAdded a preference setting to allow each user to choose
Art Cancro [Fri, 12 Oct 2007 04:54:59 +0000 (04:54 +0000)]
Added a preference setting to allow each user to choose
to start the calendar view on either Sunday or Monday (or whatever
those days are called in the local language).

16 years ago* fix calculation of all day events
Wilfried Göesgens [Thu, 11 Oct 2007 22:23:53 +0000 (22:23 +0000)]
* fix calculation of all day events
* workaround troubles with daylight saving time.

16 years ago* mktime() modifies us, we mustn't call it twice on the same data, it doesn't work.
Wilfried Göesgens [Thu, 11 Oct 2007 19:33:30 +0000 (19:33 +0000)]
* mktime() modifies us, we mustn't call it twice on the same data, it doesn't work.

16 years ago* for some reason copying an event from our calendar seems to be the better way to...
Wilfried Göesgens [Thu, 11 Oct 2007 17:37:14 +0000 (17:37 +0000)]
* for some reason copying an event from our calendar seems to be the better way to init the struct tm we want to compare with later.

16 years agoCompleted the implementation of RFC2359
Art Cancro [Thu, 11 Oct 2007 02:21:35 +0000 (02:21 +0000)]
Completed the implementation of RFC2359
(the UIDPLUS extension to IMAP).

16 years agoBegan implementing the UIDPLUS extension.
Art Cancro [Wed, 10 Oct 2007 21:28:25 +0000 (21:28 +0000)]
Began implementing the UIDPLUS extension.
[APPENDUID xxx yyy] response is complete.
UID EXPUNGE is complete (uses 'fallback' methodology described in RFC2359)
Still need to do COPYUID and UID COPY before we can advertise this extension.

16 years agoFixed userlist command so it defaults to using unix domain socket
Dave West [Wed, 10 Oct 2007 19:19:14 +0000 (19:19 +0000)]
Fixed userlist command so it defaults to using unix domain socket
instead of SEGFLTing.

16 years agoVersion number to 7.22
Art Cancro [Wed, 10 Oct 2007 17:23:54 +0000 (17:23 +0000)]
Version number to 7.22

16 years agoLDAP module no longer allows duplicate values for the same attribute,
Dave West [Wed, 10 Oct 2007 17:01:23 +0000 (17:01 +0000)]
LDAP module no longer allows duplicate values for the same attribute,
stops the ldap server complaining.

16 years agoFixed same extract_token bug for webcit.
Dave West [Wed, 10 Oct 2007 16:21:51 +0000 (16:21 +0000)]
Fixed same extract_token bug for webcit.

16 years agoFixed a bug in extract_token that allowed a buffer overflow and probable
Dave West [Wed, 10 Oct 2007 16:13:47 +0000 (16:13 +0000)]
Fixed a bug in extract_token that allowed a buffer overflow and probable
crash.

16 years agoMade some ldap functions a little more generic, pass the ldap key in as
Dave West [Wed, 10 Oct 2007 13:12:41 +0000 (13:12 +0000)]
Made some ldap functions a little more generic, pass the ldap key in as
parameter.
Fixed a typo in an ldap log message.
Home telephone number is now written to correct ldap location.

16 years agoLDAP module changes.
Dave West [Tue, 9 Oct 2007 18:06:51 +0000 (18:06 +0000)]
LDAP module changes.
Now send messages to Aide room when errors occurr.
Don't monopolise the ldap server, disconnect after 5 minutes of not
being used.
Fixed a log message in serv_vcard.c

16 years ago* store some more informations with the calendar items
Wilfried Göesgens [Mon, 8 Oct 2007 22:00:06 +0000 (22:00 +0000)]
* store some more informations with the calendar items
* precalc some metrics in those additional storages
* use precalced value to evaluate whether to display or not...