citadel.git
15 years agoSystem users (SYS_*) now have proper user numbers.
Dave West [Thu, 17 Jul 2008 12:57:23 +0000 (12:57 +0000)]
System users (SYS_*) now have proper user numbers.
CtdlFillPrivateContext has been replaced by CtdlFillSystemContext.
CtdlFillSystemContext will create the system user if needed, upgrade the
system user from a user 0 if needed and also load the system user if
needed.
The auto purger now makes a log entry if it encounters a user 0 (not an
Aide message).
The Auto purger will post an Aide message if it encounters a user with
no name and a valid user number. This should NEVER happen.

Test thoroughly before release and needs to be tested thoroughly with
host auth systems too.

15 years agoThe user with number 1 is no longer automatically an Aide.
Dave West [Thu, 17 Jul 2008 10:54:00 +0000 (10:54 +0000)]
The user with number 1 is no longer automatically an Aide.
Plugs that little security hole that an attacker would need to be very
quick to exploit.
NB. If the system Aide is not correct in the config the Aide may loose
priviledges and will need to run setup to get them back.

15 years agoFix CtdlHostAlias to correctly check if the given fqdn is one we are
Dave West [Thu, 17 Jul 2008 10:48:36 +0000 (10:48 +0000)]
Fix CtdlHostAlias to correctly check if the given fqdn is one we are
masquerading as or one we do Directory mapping for.

15 years agomore work on recurrence
Art Cancro [Tue, 15 Jul 2008 19:05:24 +0000 (19:05 +0000)]
more work on recurrence

15 years ago* migrate ajax from get to post -> unlimited post size
Wilfried Göesgens [Tue, 15 Jul 2008 18:19:34 +0000 (18:19 +0000)]
* migrate ajax from get to post -> unlimited post size
* use SEXP user|-\n message so we don't need to escape pipes; this fixes Buf 416

15 years ago* removed handlers from webcit.h if possible
Wilfried Göesgens [Mon, 14 Jul 2008 20:35:00 +0000 (20:35 +0000)]
* removed handlers from webcit.h if possible
* added file local forward declarations where needed.

15 years ago* fix loop termination trouble
Wilfried Göesgens [Mon, 14 Jul 2008 19:12:30 +0000 (19:12 +0000)]
* fix loop termination trouble

15 years ago* fix buffer end situation
Wilfried Göesgens [Mon, 14 Jul 2008 19:08:34 +0000 (19:08 +0000)]
* fix buffer end situation

15 years agoDon't recur if dtstart is missing
Art Cancro [Mon, 14 Jul 2008 17:45:33 +0000 (17:45 +0000)]
Don't recur if dtstart is missing

15 years agodisplay_using_handler() cleanup
Art Cancro [Mon, 14 Jul 2008 17:28:50 +0000 (17:28 +0000)]
display_using_handler() cleanup

15 years agoExperimenting a bit with the recur api
Art Cancro [Mon, 14 Jul 2008 16:47:09 +0000 (16:47 +0000)]
Experimenting a bit with the recur api

15 years agoDetect recurring events when rendering a calendar.
Art Cancro [Mon, 14 Jul 2008 16:04:33 +0000 (16:04 +0000)]
Detect recurring events when rendering a calendar.

15 years agoSlight modification to dothebarts disabling of the timeout for artv
Dave West [Mon, 14 Jul 2008 10:04:46 +0000 (10:04 +0000)]
Slight modification to dothebarts disabling of the timeout for artv
import.
Now the dont_term flag is set after we are sure we can do artv (in case
the mallocs fail).

15 years ago* copy daves great handler script and modify it to fit the simpler needs of webcit.
Wilfried Göesgens [Sun, 13 Jul 2008 22:33:01 +0000 (22:33 +0000)]
* copy daves great handler script and modify it to fit the simpler needs of webcit.
* add init functions to all handler containing .c files; Register these calls in the init function
* replace strcmp URL to handler dispatcher by hashlist
* wrap calls that had more than one call in simple functions

15 years ago* ignore null pointers to free.
Wilfried Göesgens [Sun, 13 Jul 2008 21:50:20 +0000 (21:50 +0000)]
* ignore null pointers to free.

15 years ago* disable our idle-check for ARTV import/export since this tends to take longer.
Wilfried Göesgens [Sun, 13 Jul 2008 09:40:28 +0000 (09:40 +0000)]
* disable our idle-check for ARTV import/export since this tends to take longer.

15 years ago* fixed naming crash with the new libcitadel
Wilfried Göesgens [Sun, 13 Jul 2008 09:39:08 +0000 (09:39 +0000)]
* fixed naming crash with the new libcitadel

15 years agoDisable photo view for vcard
Matt [Sun, 13 Jul 2008 01:21:58 +0000 (01:21 +0000)]
Disable photo view for vcard

15 years ago* fixed several tiny flaws
Wilfried Göesgens [Sat, 12 Jul 2008 20:20:52 +0000 (20:20 +0000)]
* fixed several tiny flaws

15 years ago* some umlaut weirdness
Wilfried Göesgens [Sat, 12 Jul 2008 20:19:08 +0000 (20:19 +0000)]
* some umlaut weirdness

15 years ago* added GCC Format String checkers to the remaining printf alikes
Wilfried Göesgens [Sat, 12 Jul 2008 17:16:26 +0000 (17:16 +0000)]
* added GCC Format String checkers to the remaining printf alikes
* fix formatstring errors
* fix multiline preference saving
* fix signature en/decoding
We now have UNLIMITED signatures, so finaly one can put its $Company foo at the end of his mail autemagicaly.

15 years ago* missing encoding function added
Wilfried Göesgens [Sat, 12 Jul 2008 16:32:23 +0000 (16:32 +0000)]
* missing encoding function added
* some tiny fixes...

15 years ago* avoid to run over the buffer while parsing the url
Wilfried Göesgens [Sat, 12 Jul 2008 10:54:43 +0000 (10:54 +0000)]
* avoid to run over the buffer while parsing the url
* Migrated message listview to be enum controlled after handling the settings, as its simpler to handle in memory handling

15 years ago* fixed typo. Thanks for Michael to point this out.
Wilfried Göesgens [Fri, 11 Jul 2008 17:46:48 +0000 (17:46 +0000)]
* fixed typo. Thanks for Michael to point this out.

15 years ago* sanitize loops
Wilfried Göesgens [Wed, 9 Jul 2008 23:08:56 +0000 (23:08 +0000)]
* sanitize loops

15 years ago* catch some more error conditions, double frees...
Wilfried Göesgens [Wed, 9 Jul 2008 23:08:05 +0000 (23:08 +0000)]
* catch some more error conditions, double frees...

15 years ago* added gcc printf format checking to wprintf
Wilfried Göesgens [Wed, 9 Jul 2008 00:52:34 +0000 (00:52 +0000)]
* added gcc printf format checking to wprintf
* corrected warnings of the above incidents
* adopted strbuf in config handling
* added multiline config handling

15 years ago* new api version.
Wilfried Göesgens [Wed, 9 Jul 2008 00:48:39 +0000 (00:48 +0000)]
* new api version.

15 years ago* add new buffer class which handles concatenation of strings in dynamic buffers...
Wilfried Göesgens [Wed, 9 Jul 2008 00:47:39 +0000 (00:47 +0000)]
* add new buffer class which handles concatenation of strings in dynamic buffers for itself.
* adopt our algorithms to these new structures

15 years agoRenamed database_sleepycat.c to database.c
Art Cancro [Mon, 7 Jul 2008 13:20:07 +0000 (13:20 +0000)]
Renamed database_sleepycat.c to database.c
because it reflects the fact that we only have one backend store available;
and because Sleepycat Software no longer exists.

15 years agoRename is_wap to is_mobile
Matt [Mon, 7 Jul 2008 05:30:08 +0000 (05:30 +0000)]
Rename is_wap to is_mobile
Detect iPhone Safari,S60 WebKit and WinCE browsers (opera, pocket ie) by
user-agent
Different and experimental message view - code is messy at the moment so
cleanup will come soon

15 years agoReactivate "is_wap" for handheld browsers (iPhone, Opera, Nokia etc.).
Matt [Sun, 6 Jul 2008 04:50:34 +0000 (04:50 +0000)]
Reactivate "is_wap" for handheld browsers (iPhone, Opera, Nokia etc.).
Mobile templates end in .m.html

15 years agoSet the environment variable SUPPRESS_DBVERSION_CHECK to any
Art Cancro [Fri, 4 Jul 2008 03:51:50 +0000 (03:51 +0000)]
Set the environment variable SUPPRESS_DBVERSION_CHECK to any
non-null value, to suppress the test that prohibits Berkeley DB downgrade.

15 years ago* optimize serv_getln to reduce its WC to once.
Wilfried Göesgens [Mon, 30 Jun 2008 18:02:42 +0000 (18:02 +0000)]
* optimize serv_getln to reduce its WC to once.

15 years agoRewrite encoding checks for 64-bit cleanliness
Michael Hampton [Sun, 29 Jun 2008 12:47:36 +0000 (12:47 +0000)]
Rewrite encoding checks for 64-bit cleanliness

15 years agotext client no longer displays
Art Cancro [Sun, 29 Jun 2008 04:26:49 +0000 (04:26 +0000)]
text client no longer displays
passwords during new user validation.

15 years agoBetter handling of setup directory.
Art Cancro [Sun, 29 Jun 2008 04:13:52 +0000 (04:13 +0000)]
Better handling of setup directory.
Fixes bug # 365.

15 years agoRemoved the global variable 'home_specified'
Art Cancro [Sun, 29 Jun 2008 03:18:07 +0000 (03:18 +0000)]
Removed the global variable 'home_specified'
as it does not appear to be used for anything.

15 years agoAdded a serv_mrtg mode to tally total accounts and active accounts.
Art Cancro [Wed, 25 Jun 2008 21:08:59 +0000 (21:08 +0000)]
Added a serv_mrtg mode to tally total accounts and active accounts.
This will be useful for graphing site membership over long periods of time.

15 years ago* Applied matt's latest patches
Art Cancro [Tue, 24 Jun 2008 02:15:41 +0000 (02:15 +0000)]
* Applied matt's latest patches
* Corrected a spelling error in the previous commit

15 years ago* rather let webcit rate password than layer 9
Wilfried Göesgens [Mon, 23 Jun 2008 22:11:46 +0000 (22:11 +0000)]
* rather let webcit rate password than layer 9

15 years agoMinor formatting and comments cleanup.
Art Cancro [Mon, 23 Jun 2008 03:45:49 +0000 (03:45 +0000)]
Minor formatting and comments cleanup.
Also determined where in the code the hacking for recurring events must take
place, and inserted a comment there outlining the basic strategy.

15 years agominor formatting and comments cleanup
Art Cancro [Mon, 23 Jun 2008 03:31:18 +0000 (03:31 +0000)]
minor formatting and comments cleanup

15 years agominor formatting and comments cleanup
Art Cancro [Mon, 23 Jun 2008 03:08:04 +0000 (03:08 +0000)]
minor formatting and comments cleanup

15 years agooops, fixed it
Art Cancro [Sun, 22 Jun 2008 20:29:23 +0000 (20:29 +0000)]
oops, fixed it

15 years agooops, fixed it
Art Cancro [Sun, 22 Jun 2008 20:29:02 +0000 (20:29 +0000)]
oops, fixed it

15 years agoFixed makefile for generating pt_BR locale
Art Cancro [Sun, 22 Jun 2008 20:24:18 +0000 (20:24 +0000)]
Fixed makefile for generating pt_BR locale

15 years agoThe 'edit room' tab panel now uses the same CSS that is used
Art Cancro [Sun, 22 Jun 2008 04:36:04 +0000 (04:36 +0000)]
The 'edit room' tab panel now uses the same CSS that is used
in the tabs.c API.  This eliminates the problem with tabs breaking out into two
floating rows on narrow screens.

15 years ago* a way to exclude stuff from distribution packages
Wilfried Göesgens [Sat, 21 Jun 2008 22:33:51 +0000 (22:33 +0000)]
* a way to exclude stuff from distribution packages

15 years ago* backtrace invalid message error, so we can follow this a little deeper.
Wilfried Göesgens [Thu, 19 Jun 2008 22:25:41 +0000 (22:25 +0000)]
* backtrace invalid message error, so we can follow this a little deeper.

15 years agolibcitadel 7.37
Art Cancro [Thu, 19 Jun 2008 19:16:03 +0000 (19:16 +0000)]
libcitadel 7.37

15 years agoR6396 IS VERSION 7.37
Art Cancro [Thu, 19 Jun 2008 19:07:19 +0000 (19:07 +0000)]
R6396 IS VERSION 7.37

15 years ago* fix welcome mail sending; thanks to Frank Lichtenheld for pointing this out.
Wilfried Göesgens [Thu, 19 Jun 2008 18:10:10 +0000 (18:10 +0000)]
* fix welcome mail sending; thanks to Frank Lichtenheld for pointing this out.

15 years agowebcit configure.ac package string should be WebCit 7.37, not 7.36
Art Cancro [Thu, 19 Jun 2008 03:34:13 +0000 (03:34 +0000)]
webcit configure.ac package string should be WebCit 7.37, not 7.36

15 years agoIf an RSS feed contains an item with a missing title,
Art Cancro [Wed, 18 Jun 2008 02:28:11 +0000 (02:28 +0000)]
If an RSS feed contains an item with a missing title,
don't crash citserver when saving the item.

15 years ago* fix buffer handling in qp_encode_email_addrs()
Wilfried Göesgens [Tue, 17 Jun 2008 21:34:26 +0000 (21:34 +0000)]
* fix buffer handling in qp_encode_email_addrs()

15 years ago* handle the listen ip the right way.
Wilfried Göesgens [Mon, 16 Jun 2008 22:09:17 +0000 (22:09 +0000)]
* handle the listen ip the right way.

15 years agoSpeed up for the indexer.
Dave West [Mon, 16 Jun 2008 17:25:53 +0000 (17:25 +0000)]
Speed up for the indexer.
This will NOT cause a re-build of the index but it does significantly
improve performance when indexing a new message or if the index needs to
be re-built.
Basically the list of noise words is processed much faster.

15 years agoMinor alterations to some messages as services are destroyed during
Dave West [Mon, 16 Jun 2008 13:30:22 +0000 (13:30 +0000)]
Minor alterations to some messages as services are destroyed during
shutdown.

15 years agoImplimented a new way to check the control record at startup.
Dave West [Mon, 16 Jun 2008 13:06:14 +0000 (13:06 +0000)]
Implimented a new way to check the control record at startup.
We now have a check_control() that is called after the DB's are opened

15 years agoRemove passwords from the LIST server command, even
Art Cancro [Mon, 16 Jun 2008 13:01:56 +0000 (13:01 +0000)]
Remove passwords from the LIST server command, even
for Aides.  This is a security risk.

15 years agoTidy up useage message for configure script.
Dave West [Mon, 16 Jun 2008 12:11:31 +0000 (12:11 +0000)]
Tidy up useage message for configure script.

15 years agoTurn off the user 0 message that should not have gotten into the
Dave West [Mon, 16 Jun 2008 11:55:14 +0000 (11:55 +0000)]
Turn off the user 0 message that should not have gotten into the
release.

15 years agoWhen grabbing addresses for the address book popup, return
Art Cancro [Mon, 16 Jun 2008 03:22:25 +0000 (03:22 +0000)]
When grabbing addresses for the address book popup, return
to the original room using gotoroom(saved_roomname) rather than calling
BSTR.  Fixes this bug in three different places.

15 years agofix bug #360
Art Cancro [Mon, 16 Jun 2008 02:16:02 +0000 (02:16 +0000)]
fix bug #360

15 years ago* Shorten translation.
Wilfried Göesgens [Sun, 15 Jun 2008 12:45:52 +0000 (12:45 +0000)]
* Shorten translation.

15 years agoChanges to serv_network.c:
Art Cancro [Sat, 14 Jun 2008 14:47:32 +0000 (14:47 +0000)]
Changes to serv_network.c:
* The log message which indicates that network processing for a room has
  begun, now only prints if there is a netconfig for that room.  This
  will hopefully make the logs much smaller.
* Any buffer which holds a filename is now of size PATH_MAX, rather than
  SIZ or 256 or whatever.

15 years agoAdded a README.txt in ctdlphp/ indicating that
Art Cancro [Thu, 12 Jun 2008 20:58:53 +0000 (20:58 +0000)]
Added a README.txt in ctdlphp/ indicating that
it is incomplete, unsupported code.

15 years ago* incrase number of arguments.
Wilfried Göesgens [Thu, 12 Jun 2008 19:12:08 +0000 (19:12 +0000)]
* incrase number of arguments.

15 years ago* disable wml handling, since we don't have good content for that anyway.
Wilfried Göesgens [Thu, 12 Jun 2008 19:00:23 +0000 (19:00 +0000)]
* disable wml handling, since we don't have good content for that anyway.

15 years agoqp_encode_email_addrs() returns the supplied pointer unchanged
Art Cancro [Wed, 11 Jun 2008 20:33:00 +0000 (20:33 +0000)]
qp_encode_email_addrs() returns the supplied pointer unchanged
if it points to an empty string.

15 years agoThe before-save hook which is called when saving a calendar
Art Cancro [Tue, 10 Jun 2008 19:58:46 +0000 (19:58 +0000)]
The before-save hook which is called when saving a calendar
event now populates message headers from the calendar object without
the use of an intermediate data structure.

15 years agoAdded an aide_message() when an OpenID is claimed
Art Cancro [Tue, 10 Jun 2008 02:31:56 +0000 (02:31 +0000)]
Added an aide_message() when an OpenID is claimed

15 years agoAdded a link on the OpenID login page, that points to a new
Art Cancro [Sat, 7 Jun 2008 04:44:11 +0000 (04:44 +0000)]
Added a link on the OpenID login page, that points to a new
page on www.citadel.org describing what OpenID is and how
Citadel is using it.

15 years ago* When not using native auth mode, do not enable the OpenID server command set.
Art Cancro [Fri, 6 Jun 2008 03:50:43 +0000 (03:50 +0000)]
* When not using native auth mode, do not enable the OpenID server command set.
* When self-service new user account creation is disabled, do not allow account creation via OpenID.

15 years agoPopulate vCard from SREG even when there was a name conflict
Art Cancro [Thu, 5 Jun 2008 17:37:16 +0000 (17:37 +0000)]
Populate vCard from SREG even when there was a name conflict
and we had to hold on to the SREG data for a while

15 years agoAuto-populate vCard using Simple Registration Extension data
Art Cancro [Thu, 5 Jun 2008 17:09:37 +0000 (17:09 +0000)]
Auto-populate vCard using Simple Registration Extension data

15 years ago* Completed the code for creating a new account, manually specifying
Art Cancro [Thu, 5 Jun 2008 02:32:46 +0000 (02:32 +0000)]
* Completed the code for creating a new account, manually specifying
  the account name, when an OpenID was verified but the desired nickname
  either was not supplied or conflicts with an existing user.
* The SETP command can now be passed a special string that tells it the
  client wants the server to auto-generate a random password.

15 years ago* forgot -i in the initscript
Wilfried Göesgens [Wed, 4 Jun 2008 23:04:12 +0000 (23:04 +0000)]
* forgot -i in the initscript

15 years agoopenid blah blah blah
Art Cancro [Tue, 3 Jun 2008 16:30:35 +0000 (16:30 +0000)]
openid blah blah blah

15 years agoAdded a 'verify_only' result to OIDF, indicating the account
Art Cancro [Tue, 3 Jun 2008 15:45:13 +0000 (15:45 +0000)]
Added a 'verify_only' result to OIDF, indicating the account
creation via SRI failed and we need to specify a username
manually.

15 years ago* Removed some cruft from the login code. Combined the
Art Cancro [Tue, 3 Jun 2008 03:41:51 +0000 (03:41 +0000)]
* Removed some cruft from the login code.  Combined the
  do_login() and session_startup() functions.  Moved more duplicated
  code into a single code path.
* Completed the OpenID signin process for existing users, and for new
  users who have made their preferred nickname available via Simple
  Registration Extension (assuming this nickname is available on the
  Citadel system).  Other sign in flows are forthcoming...

15 years agoIf an Internet email is sent by a logged in user,
Art Cancro [Mon, 2 Jun 2008 21:41:15 +0000 (21:41 +0000)]
If an Internet email is sent by a logged in user,
create bounceto address from the user record, not from
the message.

15 years agomore openid work
Art Cancro [Mon, 2 Jun 2008 21:36:02 +0000 (21:36 +0000)]
more openid work

15 years agoBegan laying the framework for creating new users with OpenID
Art Cancro [Mon, 2 Jun 2008 18:07:15 +0000 (18:07 +0000)]
Began laying the framework for creating new users with OpenID

15 years ago* convert RSS Subject line into plaintext with our html to text function; this remove...
Wilfried Göesgens [Mon, 2 Jun 2008 18:05:45 +0000 (18:05 +0000)]
* convert RSS Subject line into plaintext with our html to text function; this removes the entities ./ sometimes gives.

15 years agoExport format has changed due to the addition of a new
Art Cancro [Mon, 2 Jun 2008 16:09:00 +0000 (16:09 +0000)]
Export format has changed due to the addition of a new
table, so the version number has changed.  Also added a serv_info field to
advise the client (e.g. WebCit) whether the server supports OpenID.  The
main reason is because we can only do OpenID in native auth mode -- but we
can also use this to temporarily shut off all OpenID features if we need
to complete a new software release before OpenID is finished.

15 years agoCompleted artv import/export of openids
Art Cancro [Mon, 2 Jun 2008 15:14:05 +0000 (15:14 +0000)]
Completed artv import/export of openids

15 years ago* Began implenmenting OpenID table import/export
Art Cancro [Mon, 2 Jun 2008 15:03:45 +0000 (15:03 +0000)]
* Began implenmenting OpenID table import/export
* Disabled the code to automatically learn the highest message/user/room numbers
  in the event that citadel.control is missing, because if you run it on a virgin
  server, it CRASHES.

15 years agoFixed a double free error in serv_openid_rp.c
Art Cancro [Mon, 2 Jun 2008 14:24:40 +0000 (14:24 +0000)]
Fixed a double free error in serv_openid_rp.c

15 years agoWhen doing an ARTV IMPORT, call rebuild_usersbynumber() afterward
Art Cancro [Mon, 2 Jun 2008 03:06:47 +0000 (03:06 +0000)]
When doing an ARTV IMPORT, call rebuild_usersbynumber() afterward

15 years agoCompleted the delete-user hook to remove any associated
Art Cancro [Mon, 2 Jun 2008 03:04:23 +0000 (03:04 +0000)]
Completed the delete-user hook to remove any associated
OpenID records.  Also completed an auto-purger function to delete any
stale OpenID associations.  Still need to add dump/load code.  Now I
remember why I tend to avoid adding top-level database tables.

15 years agoFixed a potential memory leak (not to worry, it's
Art Cancro [Sun, 1 Jun 2008 04:36:26 +0000 (04:36 +0000)]
Fixed a potential memory leak (not to worry, it's
in new, unreleased code)

15 years agoImplemented the code to detach an OpenID from an account.
Art Cancro [Sun, 1 Jun 2008 04:19:38 +0000 (04:19 +0000)]
Implemented the code to detach an OpenID from an account.

15 years agoSuccess! We can now log in an existing user with OpenID.
Art Cancro [Sat, 31 May 2008 05:06:24 +0000 (05:06 +0000)]
Success!  We can now log in an existing user with OpenID.
We still have to write the code to create a new user using OpenID.

15 years agoRe-enable OpenID development code
Art Cancro [Sat, 31 May 2008 04:30:22 +0000 (04:30 +0000)]
Re-enable OpenID development code

15 years agoOops, don't rebuild usersbynumber every time
Art Cancro [Fri, 30 May 2008 22:10:27 +0000 (22:10 +0000)]
Oops, don't rebuild usersbynumber every time

15 years ago* separate content-type header fields by ';' ; thanks Guido for pointing this out.
Wilfried Göesgens [Fri, 30 May 2008 20:57:12 +0000 (20:57 +0000)]
* separate content-type header fields by ';' ; thanks Guido for pointing this out.

15 years ago* allow debs to build against libcurl 3 + 4
Wilfried Göesgens [Fri, 30 May 2008 13:24:56 +0000 (13:24 +0000)]
* allow debs to build against libcurl 3 + 4

15 years agoOops ... libcitadel should be version 1.14, not 1.11
Art Cancro [Fri, 30 May 2008 04:03:22 +0000 (04:03 +0000)]
Oops ... libcitadel should be version 1.14, not 1.11