Art Cancro [Fri, 25 Aug 2023 03:47:33 +0000 (18:47 -0900)]
db debugging
Art Cancro [Fri, 25 Aug 2023 02:29:04 +0000 (17:29 -0900)]
dbnothing does nothing
Art Cancro [Fri, 25 Aug 2023 00:06:31 +0000 (15:06 -0900)]
dbnothing: temporary utility that just opens and closes the database as a test
Art Cancro [Thu, 24 Aug 2023 23:37:18 +0000 (14:37 -0900)]
ctdldump/ctdlload: fix usage messages
Art Cancro [Thu, 24 Aug 2023 23:23:09 +0000 (14:23 -0900)]
ctdldump/ctdlload: -h now works identical to citserver
Art Cancro [Thu, 24 Aug 2023 23:16:20 +0000 (14:16 -0900)]
ctdlload: use the backend API instead of BDB calls
It works, but it is several orders of magnitude slower. Why?
Art Cancro [Thu, 24 Aug 2023 18:44:37 +0000 (09:44 -0900)]
ctdldump: use the backend API instead of BDB calls
This makes ctdldump backend agnostic, or at least as backend
agnostic as citserver itself is at this point. We will probably
add some calling syntax across the board when we add more
backends, but at least this utility doesn't have to be rewritten
now. This makes me a happy ig. ctdlload will be next.
Art Cancro [Thu, 24 Aug 2023 15:08:02 +0000 (06:08 -0900)]
Makefile: BACKEND_LDFLAGS "created" by configure
Art Cancro [Thu, 24 Aug 2023 14:30:40 +0000 (05:30 -0900)]
Drop support for upgrading sites older than v811 (8.11)
That release was more than 11 years ago. Sites have had ample time to upgrade.
Art Cancro [Thu, 24 Aug 2023 14:09:38 +0000 (05:09 -0900)]
Makefile: move -ldb from hardcoded to a new BACKEND_LDFLAGS
Art Cancro [Thu, 24 Aug 2023 13:55:33 +0000 (04:55 -0900)]
Makefile: restructured so that backends can be compiled into utilities
database.c has been moved from server/ into server/backends/common.
Makefile now separates server objects from backend objects.
This is all in preparation for ctdldump and ctdlload to link the backend
code instead of calling BDB directly.
Art Cancro [Wed, 23 Aug 2023 18:37:10 +0000 (09:37 -0900)]
Remove CTDLUID definition, point to ctdluid symbol instead.
CTDLUID was probably a hard-coded preprocessor definition back in the
ancient times. Now it is not.
Art Cancro [Wed, 23 Aug 2023 14:17:28 +0000 (05:17 -0900)]
cdb_next_item() now returns both key and value
Art Cancro [Tue, 22 Aug 2023 03:54:07 +0000 (18:54 -0900)]
Removed call to db_env->set_cachesize()
The third parameter has always been set to 0
so it wasn't ever doing anything before.
Art Cancro [Tue, 22 Aug 2023 03:14:31 +0000 (18:14 -0900)]
Calls to cdb_fetch()/cdb_next_item() now check ptr for NULL or non-NULL
This is a better practice than checking to see if the data length was 0.
It now allows for extant but zero-length data to be returned.
Art Cancro [Mon, 21 Aug 2023 20:49:58 +0000 (11:49 -0900)]
cdb_free() is no longer needed; removed from backend API
Art Cancro [Mon, 21 Aug 2023 20:45:38 +0000 (11:45 -0900)]
cdb_fetch() and cdb_next_item() now return a struct cdbdata instead of a pointer to one
Art Cancro [Mon, 21 Aug 2023 19:09:45 +0000 (10:09 -0900)]
bdb_decompress_if_necessary() now operates on DBT instead of cdbdata
This allows us to maintain the DB_DBT_REALLOC heuristics.
Art Cancro [Mon, 21 Aug 2023 01:33:14 +0000 (16:33 -0900)]
Remove diagnostic section
Art Cancro [Mon, 21 Aug 2023 01:23:47 +0000 (16:23 -0900)]
Keep track of whether cdb->ptr must be freed by cdb_free()
This would happen, for example, if we decompressed the record.
Art Cancro [Sun, 20 Aug 2023 03:18:42 +0000 (18:18 -0900)]
Apply patch sent by UFarx to support CPPFLAGS
Art Cancro [Sun, 20 Aug 2023 02:42:31 +0000 (17:42 -0900)]
cdb_fetch()/cdb_next_item() return immutable data
************************************************************************
Before now, the Berkeley DB back end was supplied the DB_DBT_MALLOC flag
and it became the caller's responsibility to handle any memory allocated
and returned by cdb_fetch() and cdb_next_item(). These heuristics are
not expected to be compatible with new back ends currently in planning.
cdb_fetch() and cdb_next_item() now return data that is to be considered
immutable (don't write to it or you'll segfault). The caller must still
call cdb_free() to free the `struct cdbdata` itself, but the pointers
inside it point to buffers that the back end will reuse.
After a call to cdb_fetch() or cdb_next_item(), the buffers are
guaranteed to be readable until the next call to one of those functions
on the same table.
Art Cancro [Sat, 19 Aug 2023 21:34:34 +0000 (12:34 -0900)]
serv_imap.c: moved to new CtdlFetchMsgList() API.
This should be the last of them. Next step is to audit all other use of cdb_free().
Art Cancro [Sat, 19 Aug 2023 20:28:56 +0000 (11:28 -0900)]
serv_imap: removed all the CCC and CCCIMAP shorthand
Art Cancro [Thu, 17 Aug 2023 22:52:54 +0000 (13:52 -0900)]
msgbase.c all migrated to new api now
Art Cancro [Thu, 17 Aug 2023 22:32:56 +0000 (13:32 -0900)]
CtdlFetchMsgList() - treat no-record and zero-messages identically
In both cases, we return 0 to the caller and set the array pointer to NULL.
This simplifies the calling convention and eliminates extra code to check for both conditions
Art Cancro [Thu, 17 Aug 2023 22:23:20 +0000 (13:23 -0900)]
The previous commit was actually for CtdlDeleteMessages()
Art Cancro [Thu, 17 Aug 2023 22:20:49 +0000 (13:20 -0900)]
CtdlSaveMsgPointersInRoom() is now lmdb-safe
Art Cancro [Thu, 17 Aug 2023 22:13:33 +0000 (13:13 -0900)]
serv_nntp.c: move to new API
Art Cancro [Thu, 17 Aug 2023 21:25:48 +0000 (12:25 -0900)]
InitialMailCheck() uses new API
Art Cancro [Thu, 17 Aug 2023 21:11:39 +0000 (12:11 -0900)]
msgbase.c: change to new API
Art Cancro [Wed, 16 Aug 2023 18:14:58 +0000 (09:14 -0900)]
msgbase.c: upgrade CtdlSetSeen() to the new CtdlGetMsgList() API
Art Cancro [Wed, 16 Aug 2023 03:45:24 +0000 (18:45 -0900)]
serv_expire: move to new msglists call
Art Cancro [Wed, 16 Aug 2023 03:14:24 +0000 (18:14 -0900)]
DRY fetch of msglists.
A lot of the calls to cdb_fetch(CDB_MSGLISTS...) follow the same design pattern
and many of them are in need of rework to handle how they free their memory. So
I created a new function CtdlGetMsgList() to do it in a consistent way. Three
callers have been migrated to the new syntax.
Art Cancro [Wed, 16 Aug 2023 02:18:31 +0000 (17:18 -0900)]
serv_fulltext.c: copy the data returned by cdb_fetch() instead of taking ownership
We have to do this everywhere. Berkeley DB can be configured to hand off ownership of memory to
the caller, but LMDB cannot.
Art Cancro [Fri, 11 Aug 2023 20:14:09 +0000 (11:14 -0900)]
More renaming of symbols that are local to the berkeley_db module.
dbp[] is now bdb_table[]
dbenv is now bdb_env
Art Cancro [Fri, 11 Aug 2023 15:46:34 +0000 (06:46 -0900)]
Moved cdb_chmod_data() out of the backend API
This function only does file and directory level operations on
the data/ directory and files in it. These operations will be
common across all backends.
Art Cancro [Fri, 11 Aug 2023 15:21:58 +0000 (06:21 -0900)]
Renamed some more functions and variables that are specific to the bdb_ module.
Art Cancro [Fri, 11 Aug 2023 13:21:45 +0000 (04:21 -0900)]
comments cleanup
Art Cancro [Fri, 11 Aug 2023 13:13:23 +0000 (04:13 -0900)]
This works much better. TSD maintained in-module instead of globally.
Art Cancro [Fri, 11 Aug 2023 12:42:46 +0000 (03:42 -0900)]
Revert "Prepared for upcoming change to cdb_next_item() API."
This reverts commit
d805c8202867ff3cc4049e5df6a3e871c4fdc5be.
Art Cancro [Fri, 11 Aug 2023 12:42:20 +0000 (03:42 -0900)]
Revert "Changed the API for cdb_rewind() / cdb_next_item() to make the caller hold the cursor"
This reverts commit
733c6e8f2a624fb641cc50a9d253b3a914c25bba.
Art Cancro [Thu, 10 Aug 2023 17:07:07 +0000 (08:07 -0900)]
Changed the API for cdb_rewind() / cdb_next_item() to make the caller hold the cursor
Art Cancro [Thu, 10 Aug 2023 14:49:50 +0000 (05:49 -0900)]
Prepared for upcoming change to cdb_next_item() API.
cdb_next_item() is always preceded by a call to cdb_rewind() before the
iteration loop. We're going to remove the cursor from thread-specific
data, and replace it with a void pointer that the caller is responsible
for passing back. This will make the backend drivers easier to build.
Art Cancro [Thu, 10 Aug 2023 14:46:49 +0000 (05:46 -0900)]
imap_acl.c: update to C99 style comments
Art Cancro [Wed, 9 Aug 2023 15:57:51 +0000 (11:57 -0400)]
berkeley_db.c: remove includes that are no longer needed
Art Cancro [Wed, 9 Aug 2023 15:52:45 +0000 (11:52 -0400)]
document private/public functions in berkeley_db.c
Art Cancro [Wed, 9 Aug 2023 15:47:02 +0000 (11:47 -0400)]
berkeley_db.c: prefixed all module-local functions with bdb_ to avoid namespace collisions
Art Cancro [Wed, 9 Aug 2023 15:41:23 +0000 (11:41 -0400)]
Moved cdb_ prototypes from berkeley_db.c to database.c where they belong
Art Cancro [Wed, 9 Aug 2023 14:20:44 +0000 (10:20 -0400)]
Building better abstractions for the backend interface
Art Cancro [Wed, 9 Aug 2023 14:06:47 +0000 (10:06 -0400)]
server/database_bdb.c is now server/backends/berkeley_db/berkeley_db.c
Art Cancro [Tue, 8 Aug 2023 22:03:40 +0000 (18:03 -0400)]
cdb_init_backends() just calls bdb_init_backend() for now
Art Cancro [Tue, 8 Aug 2023 21:57:39 +0000 (17:57 -0400)]
Silenced a compiler warning by bringing in the correct include files.
Art Cancro [Tue, 8 Aug 2023 21:55:10 +0000 (17:55 -0400)]
Mostly finished the abstractions, now just need to silence some compiler warnings that came up
Art Cancro [Tue, 8 Aug 2023 21:47:13 +0000 (17:47 -0400)]
saving my work before I do the rest of the functions en masse
Art Cancro [Tue, 8 Aug 2023 21:42:35 +0000 (17:42 -0400)]
Tried it with a function that requires a parameter
Art Cancro [Tue, 8 Aug 2023 21:40:50 +0000 (17:40 -0400)]
Begin turning cdb_ functions into pointers assigned to bdb_ functions
Art Cancro [Tue, 8 Aug 2023 19:34:25 +0000 (15:34 -0400)]
made the prototypes prettier
Art Cancro [Tue, 8 Aug 2023 18:00:25 +0000 (14:00 -0400)]
ctdl_module_init_database() is now ctdl_module_init_database_bdb()
Art Cancro [Tue, 8 Aug 2023 17:25:16 +0000 (13:25 -0400)]
open_databases() and close_databases() are now cdb_open_databases() and cdb_close_databases()
Art Cancro [Tue, 8 Aug 2023 17:17:27 +0000 (13:17 -0400)]
usetable.c: moved CheckIfAlreadySeen() out of database.c
Art Cancro [Tue, 8 Aug 2023 14:04:54 +0000 (10:04 -0400)]
Also remove cdb_allocate_tsd(), cdb_free_tsd(), cdb_cull_logs()
It is important to get this right because it's going to become a driver interface for databases
Art Cancro [Tue, 8 Aug 2023 13:59:04 +0000 (09:59 -0400)]
Removed checkpoint_thread() prototype from database.h , this is not a real function anymore
Art Cancro [Mon, 7 Aug 2023 15:26:28 +0000 (06:26 -0900)]
database.h: assert that it is an internal API that should remain consistent across multiple back ends.
Art Cancro [Mon, 7 Aug 2023 15:24:03 +0000 (06:24 -0900)]
Renamed database.c to database_bdb.c
Art Cancro [Mon, 7 Aug 2023 15:18:38 +0000 (06:18 -0900)]
serv_nntp.c: change everything to C99 comment style
Art Cancro [Mon, 7 Aug 2023 14:55:11 +0000 (05:55 -0900)]
Marked code that will require some rework for LMDB.
When BDB returns data, the caller owns the memory and is required to
free it, which we usually do. I marked the places where we take ownership
of memory pointers and then set the BDB ptr to NULL. If we switch to
LMDB, those pointers remain valid forever, so we cannot simply free them
later.
Art Cancro [Fri, 4 Aug 2023 15:18:06 +0000 (11:18 -0400)]
point out sessions that are timed out but non-idle
Art Cancro [Wed, 2 Aug 2023 17:50:12 +0000 (13:50 -0400)]
verify that 'begin' and 'end' lines were found
Art Cancro [Wed, 2 Aug 2023 03:54:25 +0000 (18:54 -0900)]
began work on enumerating attachments in the mail view
Art Cancro [Wed, 2 Aug 2023 02:40:55 +0000 (17:40 -0900)]
Enumerate attachments in JSON message output
Art Cancro [Wed, 2 Aug 2023 00:44:02 +0000 (00:44 +0000)]
Merge branch 'ConstStr_Access_Checks' into 'master'
IMAP memory issues with use of ConstStr
See merge request citadel/citadel!5
Art Cancro [Tue, 1 Aug 2023 02:32:40 +0000 (17:32 -0900)]
Release version 988 generated by do-release.sh
Art Cancro [Tue, 1 Aug 2023 02:32:29 +0000 (17:32 -0900)]
ctdldump/ctdlload: -h now specifies the top-level Citadel directory, just like all the other programs, and defaults to the compiled-in Citadel directory, just like all the other programs
Art Cancro [Wed, 26 Jul 2023 17:05:47 +0000 (08:05 -0900)]
More reliable search for guesstimezone.sh
Art Cancro [Tue, 25 Jul 2023 23:08:30 +0000 (14:08 -0900)]
Release version 987 generated by do-release.sh
Art Cancro [Tue, 25 Jul 2023 23:08:20 +0000 (14:08 -0900)]
ctdldump/ctdlload: more testing
Art Cancro [Tue, 25 Jul 2023 19:10:17 +0000 (10:10 -0900)]
ctdlload: finished remaining record types; need to test
Art Cancro [Tue, 25 Jul 2023 15:34:07 +0000 (06:34 -0900)]
skip the database open for the unused table to keep it from erroring out
Art Cancro [Tue, 25 Jul 2023 15:28:32 +0000 (06:28 -0900)]
ctdlload: euidindex
Art Cancro [Tue, 25 Jul 2023 15:17:47 +0000 (06:17 -0900)]
ctdlload: usersbynumber
Art Cancro [Tue, 25 Jul 2023 14:53:23 +0000 (05:53 -0900)]
add some //FIXME tags where needed
Art Cancro [Mon, 24 Jul 2023 19:15:58 +0000 (10:15 -0900)]
import fulltext index records
Art Cancro [Mon, 24 Jul 2023 17:56:43 +0000 (08:56 -0900)]
stub functions for new import routines
Art Cancro [Mon, 24 Jul 2023 15:31:23 +0000 (06:31 -0900)]
Export euidindex records
Art Cancro [Mon, 24 Jul 2023 15:25:57 +0000 (06:25 -0900)]
export fulltext records
Art Cancro [Mon, 24 Jul 2023 15:16:49 +0000 (06:16 -0900)]
Both banners now use the same color scheme
Art Cancro [Mon, 24 Jul 2023 15:13:18 +0000 (06:13 -0900)]
Go back to exporting dir and usersbynumber records.
We will also be exporting fulltext, euidindex, etc records.
Re-generating them on the target server after import is just way too time consuming.
Art Cancro [Mon, 24 Jul 2023 15:09:18 +0000 (06:09 -0900)]
When exporting visit records, if there is corrupt (non-printable) data in seen/answered arrays, cut that out before exporting
Art Cancro [Sat, 22 Jul 2023 20:42:45 +0000 (11:42 -0900)]
Release version 986 generated by do-release.sh
Art Cancro [Sat, 22 Jul 2023 20:42:35 +0000 (11:42 -0900)]
Fixed bad import in thing
Art Cancro [Sat, 22 Jul 2023 16:24:12 +0000 (07:24 -0900)]
Release version 985 generated by do-release.sh
Art Cancro [Sat, 22 Jul 2023 16:24:05 +0000 (07:24 -0900)]
Aggressively sync
Art Cancro [Sat, 22 Jul 2023 16:09:49 +0000 (07:09 -0900)]
Be more aggressive about closing the databases during a segfault
Art Cancro [Sat, 22 Jul 2023 15:53:46 +0000 (06:53 -0900)]
Try to close the databases if we segfault
Art Cancro [Sat, 22 Jul 2023 14:50:11 +0000 (05:50 -0900)]
Release version 984 generated by do-release.sh
Art Cancro [Sat, 22 Jul 2023 14:48:44 +0000 (10:48 -0400)]
ctdldump/ctdlload: fixed on Raspberry Pi, reintroduced to build
Art Cancro [Sat, 22 Jul 2023 14:18:36 +0000 (10:18 -0400)]
add prototype for b64unalphabet() to silence warning
Art Cancro [Fri, 21 Jul 2023 22:10:57 +0000 (22:10 +0000)]
Merge branch 'Memory_Leak_SmtpClient' into 'master'
Memory leak in SMTP Client string trim
See merge request citadel/citadel!4
Art Cancro [Fri, 21 Jul 2023 21:30:18 +0000 (12:30 -0900)]
Release version 983 generated by do-release.sh