]> code.citadel.org Git - citadel.git/blobdiff - citadel/modules/rssclient/serv_rssclient.c
Removed an unused parameter from CtdlSubmitMsg(). Why was it even there?
[citadel.git] / citadel / modules / rssclient / serv_rssclient.c
index c69f6b4ad44f36340033c1b7e1c97480780335bb..ca05dd62d5067d619f77e030bf797b11a9b450a4 100644 (file)
@@ -1,23 +1,17 @@
 /*
- * $Id$
+ * Bring external RSS and/or Atom feeds into rooms.  This module implements a
+ * very loose parser that scrapes both kinds of feeds and is not picky about
+ * the standards compliance of the source data.
  *
- * Bring external RSS feeds into rooms.
+ * Copyright (c) 2007-2020 by the citadel.org team
  *
- * Copyright (c) 2007-2009 by the citadel.org team
+ * This program is open source software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License version 3.
  *
- *  This program is free software; you can redistribute it and/or modify
- *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 3 of the License, or
- *  (at your option) any later version.
- *
- *  This program is distributed in the hope that it will be useful,
- *  but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  GNU General Public License for more details.
- *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
  */
 
 #include <stdlib.h>
@@ -29,9 +23,9 @@
 # include <time.h>
 #else
 # if HAVE_SYS_TIME_H
-#  include <sys/time.h>
+#include <sys/time.h>
 # else
-#  include <time.h>
+#include <time.h>
 # endif
 #endif
 
 #include "config.h"
 #include "threads.h"
 #include "ctdl_module.h"
-#include "clientsocket.h"
 #include "msgbase.h"
 #include "parsedate.h"
 #include "database.h"
 #include "citadel_dirs.h"
-#include "md5.h"
 #include "context.h"
+#include "internet_addressing.h"
 
-typedef struct rssnetcfg rssnetcfg;
+struct rssroom {
+       struct rssroom *next;
+       char *room;
+};
 
-struct rssnetcfg {
-       rssnetcfg *next;
-       char url[256];
-       char *rooms;
-       time_t last_error_when;
-       int ItemType;
+struct rssurl {
+       struct rssurl *next;
+       char *url;
+       struct rssroom *rooms;
 };
 
-#define RSS_UNSET 0
-#define RSS_RSS 1
-#define RSS_ATOM 2
-
-typedef struct _rss_item {
-       char *chardata;
-       int chardata_len;
-       char *roomlist;
-       int done_parsing;
-       char *guid;
-       char *title;
+struct rssparser {
+       StrBuf *CData;
+       struct CtdlMessage *msg;
        char *link;
        char *description;
-       time_t pubdate;
-       char channel_title[256];
-       int item_tag_nesting;
-       char *author_or_creator;
-       char *author_url;
-}rss_item;
-
-
-typedef struct _rsscollection {
-       rss_item *Item;
-       rssnetcfg *Cfg;
-       
-
-} rsscollection;
-
-struct rssnetcfg *rnclist = NULL;
-
-
-#if 0
-#ifdef HAVE_ICONV
-#include <iconv.h>
-
+       char *item_id;
+       struct rssroom *rooms;
+};
 
-/* 
- * dug this out of the trashcan of the midgard project, lets see if it works for us.
- * original code by Alexander Bokovoy <bokovoy@avilink.ne> distributed under GPL V2 or later
- */
+time_t last_run = 0L;
+struct rssurl *rsstodo = NULL;
 
-/* Returns: 
- >= 0 - successfull, 0 means conversion doesn't use multibyte sequences 
-   -1 - error during iconv_open call 
-   -2 - error during iconv_close call 
-   ---------------------------------- 
-   This function expects that multibyte encoding in 'charset' wouldn't have 
-   characters with more than 3 bytes. It is not intended to convert UTF-8 because 
-   we'll never receive UTF-8 in our handler (it is handled by Exat itself). 
-*/ 
-static int 
-fill_encoding_info (const char *charset, XML_Encoding * info) 
-{ 
-  iconv_t cd = (iconv_t)(-1); 
-  int flag; 
-       CtdlLogPrintf(0, "RSS: fill encoding info ...\n");
-#if G_BYTE_ORDER == G_LITTLE_ENDIAN 
-  cd = iconv_open ("UCS-2LE", charset); 
-#else 
-  cd = iconv_open ("UCS-2BE", charset); 
-#endif 
-  if (cd == (iconv_t) (-1)) 
-    { 
-      return -1; 
-    } 
-  { 
-    unsigned short out; 
-    unsigned char buf[4]; 
-    unsigned int i0, i1, i2; 
-    int result; 
-    flag = 0; 
-    for (i0 = 0; i0 < 0x100; i0++) 
-      { 
-        buf[0] = i0; 
-        info->map[i0] = 0; 
-        //result = try (cd, buf, 1, &out); 
-        if (result < 0) 
-          { 
-          } 
-        else if (result > 0) 
-          { 
-            info->map[i0] = out; 
-          } 
-        else 
-          { 
-            for (i1 = 0; i1 < 0x100; i1++) 
-              { 
-                buf[1] = i1; 
-                ///result = try (cd, buf, 2, &out); 
-                if (result < 0) 
-                  { 
-                  } 
-                else if (result > 0) 
-                  { 
-                    flag++; 
-                    info->map[i0] = -2; 
-                  } 
-                else 
-                  { 
-                    for (i2 = 0; i2 < 0x100; i2++) 
-                      { 
-                        buf[2] = i2; 
-                        ////result = try (cd, buf, 3, &out); 
-                        if (result < 0) 
-                          { 
-                          } 
-                        else if (result > 0) 
-                          { 
-                            flag++; 
-                            info->map[i0] = -3; 
-                          } 
-                      } 
-                  } 
-              } 
-          } 
-      } 
-  } 
-  if (iconv_close (cd) < 0) 
-    { 
-      return -2; 
-    } 
-  return flag; 
-} 
-
-static int 
-iconv_convertor (void *data, const char *s) 
-{ 
-  XML_Encoding *info = data; 
-  int res; 
-       CtdlLogPrintf(0, "RSS: Converting ...\n");
-
-  if (s == NULL) 
-    return -1; 
-/*
-  GByteArray *result; 
-  result = g_byte_array_new (); 
-  if (process_block (info->data, (char *) s, strlen (s), result) == 0) 
-    { 
-      res = *(result->data); 
-      g_byte_array_free (result, TRUE); 
-      return res; 
-    } 
-  g_byte_array_free (result, TRUE); 
-*/
-  return -1; 
-} 
-
-static void 
-my_release (void *data) 
-{ 
-  iconv_t cd = (iconv_t) data; 
-  if (iconv_close (cd) != 0) 
-    { 
-/// TODO: uh no.      exit (1); 
-    } 
-} 
-int 
-handle_unknown_xml_encoding (void *encodingHandleData, 
-                            const XML_Char * name, 
-                            XML_Encoding * info) 
-{ 
-  int result; 
-  CtdlLogPrintf(0, "RSS: unknown encoding ...\n");
-  result = fill_encoding_info (name, info); 
-  if (result >= 0) 
-    { 
-      /*  
-        Special case: client asked for reverse conversion, we'll provide him with 
-        iconv descriptor which handles it. Client should release it by himself. 
-      */ 
-      if(encodingHandleData != NULL) 
-            *((iconv_t *)encodingHandleData) = iconv_open(name, "UTF-8"); 
-      /*  
-         Optimization: we do not need conversion function if encoding is one-to-one,  
-         info->map table will be enough  
-       */ 
-      if (result == 0) 
-        { 
-          info->data = NULL; 
-          info->convert = NULL; 
-          info->release = NULL; 
-          return 1; 
-        } 
-      /*  
-         We do need conversion function because this encoding uses multibyte sequences 
-       */ 
-      info->data = (void *) iconv_open ("UTF-8", name); 
-      if ((int)info->data == -1) 
-        return -1; 
-      info->convert = iconv_convertor; 
-      info->release = my_release; 
-      return 1; 
-    } 
-  if(encodingHandleData != NULL)  
-    *(iconv_t *)encodingHandleData = NULL; 
-  return 0; 
-} 
 
-#endif
-#endif
-
-/*
- * Commit a fetched and parsed RSS item to disk
- */
-void rss_save_item(rsscollection *rssc) {
-
-       struct MD5Context md5context;
-       u_char rawdigest[MD5_DIGEST_LEN];
+// This handler is called whenever an XML tag opens.
+//
+void rss_start_element(void *data, const char *el, const char **attribute)
+{
+       struct rssparser *r = (struct rssparser *)data;
        int i;
-       char utmsgid[SIZ];
-       struct cdbdata *cdbut;
-       struct UseTable ut;
-       struct CtdlMessage *msg;
-       struct recptypes *recp = NULL;
-       int msglen = 0;
-       rss_item *ri = rssc->Item;
-
-       recp = (struct recptypes *) malloc(sizeof(struct recptypes));
-       if (recp == NULL) return;
-       memset(recp, 0, sizeof(struct recptypes));
-       recp->recp_room = strdup(ri->roomlist);
-       recp->num_room = num_tokens(ri->roomlist, '|');
-       recp->recptypes_magic = RECPTYPES_MAGIC;
-   
-       /* Construct a GUID to use in the S_USETABLE table.
-        * If one is not present in the item itself, make one up.
-        */
-       if (ri->guid != NULL) {
-               snprintf(utmsgid, sizeof utmsgid, "rss/%s", ri->guid);
-       }
-       else {
-               MD5Init(&md5context);
-               if (ri->title != NULL) {
-                       MD5Update(&md5context, (unsigned char*)ri->title, strlen(ri->title));
-               }
-               if (ri->link != NULL) {
-                       MD5Update(&md5context, (unsigned char*)ri->link, strlen(ri->link));
-               }
-               MD5Final(rawdigest, &md5context);
-               for (i=0; i<MD5_DIGEST_LEN; i++) {
-                       sprintf(&utmsgid[i*2], "%02X", (unsigned char) (rawdigest[i] & 0xff));
-                       utmsgid[i*2] = tolower(utmsgid[i*2]);
-                       utmsgid[(i*2)+1] = tolower(utmsgid[(i*2)+1]);
-               }
-               strcat(utmsgid, "_rss2ctdl");
-       }
-
-       /* Find out if we've already seen this item */
-       cdbut = cdb_fetch(CDB_USETABLE, utmsgid, strlen(utmsgid));
-       if (cdbut != NULL) {
-               /* Item has already been seen */
-               CtdlLogPrintf(CTDL_DEBUG, "%s has already been seen\n", utmsgid);
-               cdb_free(cdbut);
-
-               /* rewrite the record anyway, to update the timestamp */
-               strcpy(ut.ut_msgid, utmsgid);
-               ut.ut_timestamp = time(NULL);
-               cdb_store(CDB_USETABLE, utmsgid, strlen(utmsgid), &ut, sizeof(struct UseTable) );
-       }
-       else {
-               /* Item has not been seen, so save it. */
-               CtdlLogPrintf(CTDL_DEBUG, "RSS: saving item...\n");
-               if (ri->description == NULL) ri->description = strdup("");
-               for (i=strlen(ri->description); i>=0; --i) {
-                       if (isspace(ri->description[i])) {
-                               ri->description[i] = ' ';
-                       }
-               }
-
-               msg = malloc(sizeof(struct CtdlMessage));
-               memset(msg, 0, sizeof(struct CtdlMessage));
-               msg->cm_magic = CTDLMESSAGE_MAGIC;
-               msg->cm_anon_type = MES_NORMAL;
-               msg->cm_format_type = FMT_RFC822;
 
-               if (ri->guid != NULL) {
-                       msg->cm_fields['E'] = strdup(ri->guid);
+       if (
+               (!strcasecmp(el, "entry"))
+               || (!strcasecmp(el, "item"))
+       ) {
+               // this is the start of a new item(rss) or entry(atom)
+               if (r->msg != NULL) {
+                       CM_Free(r->msg);
+                       r->msg = NULL;
                }
-
-               if (ri->author_or_creator != NULL) {
-                       msg->cm_fields['A'] = html_to_ascii(ri->author_or_creator,
-                               strlen(ri->author_or_creator), 512, 0);
-                       striplt(msg->cm_fields['A']);
-               }
-               else {
-                       msg->cm_fields['A'] = strdup("rss");
-               }
-
-               msg->cm_fields['N'] = strdup(NODENAME);
-               if (ri->title != NULL) {
-                       msg->cm_fields['U'] = html_to_ascii(ri->title, strlen(ri->title), 512, 0);
-                       striplt(msg->cm_fields['U']);
-               }
-               msg->cm_fields['T'] = malloc(64);
-               snprintf(msg->cm_fields['T'], 64, "%ld", ri->pubdate);
-               if (ri->channel_title != NULL) {
-                       if (!IsEmptyStr(ri->channel_title)) {
-                               msg->cm_fields['O'] = strdup(ri->channel_title);
+               r->msg = malloc(sizeof(struct CtdlMessage));
+               memset(r->msg, 0, sizeof(struct CtdlMessage));
+               r->msg->cm_magic = CTDLMESSAGE_MAGIC;
+               r->msg->cm_anon_type = MES_NORMAL;
+               r->msg->cm_format_type = FMT_RFC822;
+       }
+
+       else if (!strcasecmp(el, "link")) {                     // atom feeds have the link as an attribute
+               for(i = 0; attribute[i]; i += 2) {
+                       if (!strcasecmp(attribute[i], "href")) {
+                               if (r->link != NULL) {
+                                       free(r->link);
+                                       r->link = NULL;
+                               }
+                               r->link = strdup(attribute[i+1]);
+                               striplt(r->link);
                        }
                }
-               if (ri->link == NULL) 
-                       ri->link = strdup("");
-               msglen += 1024 + strlen(ri->link) + strlen(ri->description) ;
-               msg->cm_fields['M'] = malloc(msglen);
-               snprintf(msg->cm_fields['M'], msglen,
-                       "Content-type: text/html; charset=\"UTF-8\"\r\n\r\n"
-                       "<html><body>\n"
-                       "%s<br><br>\n"
-                       "<a href=\"%s\">%s</a>\n"
-                       "</body></html>\n"
-                       ,
-                       ri->description,
-                       ri->link, ri->link
-               );
-
-               CtdlSubmitMsg(msg, recp, NULL, 0);
-               CtdlFreeMessage(msg);
-
-               /* write the uidl to the use table so we don't store this item again */
-               strcpy(ut.ut_msgid, utmsgid);
-               ut.ut_timestamp = time(NULL);
-               cdb_store(CDB_USETABLE, utmsgid, strlen(utmsgid), &ut, sizeof(struct UseTable) );
        }
-       free_recipients(recp);
 }
 
 
-
-/*
- * Convert an RDF/RSS datestamp into a time_t
- */
-time_t rdf_parsedate(char *p)
+// This handler is called whenever an XML tag closes.
+//
+void rss_end_element(void *data, const char *el)
 {
-       struct tm tm;
-       time_t t = 0;
-
-       if (!p) return 0L;
-       if (strlen(p) < 10) return 0L;
-
-       memset(&tm, 0, sizeof tm);
-
-       /*
-        * If the timestamp appears to be in W3C datetime format, try to
-        * parse it.  See also: http://www.w3.org/TR/NOTE-datetime
-        *
-        * This code, along with parsedate.c, is a potential candidate for
-        * moving into libcitadel.
-        */
-       if ( (p[4] == '-') && (p[7] == '-') ) {
-               tm.tm_year = atoi(&p[0]) - 1900;
-               tm.tm_mon = atoi(&p[5]) - 1;
-               tm.tm_mday = atoi(&p[8]);
-               if ( (p[10] == 'T') && (p[13] == ':') ) {
-                       tm.tm_hour = atoi(&p[11]);
-                       tm.tm_min = atoi(&p[14]);
-               }
-               return mktime(&tm);
-       }
-
-       /* hmm... try RFC822 date stamp format */
-
-       t = parsedate(p);
-       if (t > 0) return(t);
+       struct rssparser *r = (struct rssparser *)data;
+       StrBuf *encoded_field;
 
-       /* yeesh.  ok, just return the current date and time. */
-       return(time(NULL));
-}
-
-#define RSS_UNSET 0
-#define RSS_RSS 1
-#define RSS_ATOM 2
-
-void flush_rss_ite(rss_item *ri)
-{
-       /* Initialize the feed item data structure */
-       if (ri->guid != NULL) free(ri->guid);
-       ri->guid = NULL;
-       if (ri->title != NULL) free(ri->title);
-       ri->title = NULL;
-       if (ri->link != NULL) free(ri->link);
-       ri->link = NULL;
-       if (ri->author_or_creator != NULL) free(ri->author_or_creator);
-       ri->author_or_creator = NULL;
-       if (ri->author_url != NULL) free(ri->author_url);
-       ri->author_url = NULL;
-       if (ri->description != NULL) free(ri->description);
-       ri->description = NULL;
-       /* Throw away any existing character data */
-       if (ri->chardata_len > 0) {
-               free(ri->chardata);
-               ri->chardata = 0;
-               ri->chardata_len = 0;
+       if (StrLength(r->CData) > 0) {                          // strip leading/trailing whitespace from field
+               StrBufTrim(r->CData);
        }
-}
 
-void rss_xml_start(void *data, const char *supplied_el, const char **attr) {
-       rsscollection *rssc = (rsscollection*) data;
-       rss_item *ri = rssc->Item;
-       char el[256];
-       char *sep = NULL;
-
-       /* Axe the namespace, we don't care about it */
-///    CtdlLogPrintf(0, "RSS: supplied el %d: %s...\n", rssc->Cfg->ItemType, supplied_el);
-       safestrncpy(el, supplied_el, sizeof el);
-       while (sep = strchr(el, ':'), sep) {
-               strcpy(el, ++sep);
-       }
+       if (                                                    // end of a new item(rss) or entry(atom)
+               (!strcasecmp(el, "entry"))
+               || (!strcasecmp(el, "item"))
+       ) {
+               if (r->msg != NULL) {                           // Save the message to the rooms
 
-       if ((rssc->Cfg->ItemType == RSS_UNSET) && !strcasecmp(el, "rss")) 
-       {
-               CtdlLogPrintf(9, "RSS: This is an RSS feed.\n");
-               rssc->Cfg->ItemType = RSS_RSS;
-       }
-       if ((rssc->Cfg->ItemType == RSS_UNSET) && !strcasecmp(el, "rdf")) 
-       {
-               CtdlLogPrintf(9, "RSS: This is an RDF feed.\n");
-               rssc->Cfg->ItemType = RSS_RSS;
-       }
-       else if ((rssc->Cfg->ItemType == RSS_UNSET) && !strcasecmp(el, "feed")) 
-       {
-               CtdlLogPrintf(9, "RSS: This is an ATOM feed.\n");
-               rssc->Cfg->ItemType = RSS_ATOM;
-       }
-       else if ((rssc->Cfg->ItemType == RSS_RSS) &&
-           !strcasecmp(el, "item")) 
-       {
-               ri->item_tag_nesting ++ ;
-               flush_rss_ite(ri);
-       }
-       else if ( (rssc->Cfg->ItemType == RSS_ATOM) &&
-                !strcasecmp(el, "entry")) 
-       { /* Atom feed... */
-               ++ri->item_tag_nesting;
-               flush_rss_ite(ri);
-       }
-       else if ((rssc->Cfg->ItemType == RSS_ATOM) &&
-                !strcasecmp(el, "link"))
-       {
-               int found ;
-               int i;
-
-               for (found = 0, i = 0;!found && attr[i] != NULL; i+=2)
-               {
-                       if (!strcmp(attr[i], "href"))
-                       {
-                               found = 1;
-                               if (ri->link != NULL)
-                                       free(ri->link);
-                               ri->link = strdup(attr[i+1]);
-                               striplt(ri->link);
+                       // use the link as an item id if nothing else is available
+                       if ((r->item_id == NULL) && (r->link != NULL)) {
+                               r->item_id = strdup(r->link);
                        }
+
+                       // check the use table
+                       StrBuf *u = NewStrBuf();
+                       StrBufAppendPrintf(u, "rss/%s", r->item_id);
+                       int already_seen = CheckIfAlreadySeen(u);
+                       FreeStrBuf(&u);
+
+                       if (already_seen == 0) {
+
+                               // Compose the message text
+                               StrBuf *TheMessage = NewStrBuf();
+                               StrBufAppendPrintf(TheMessage,
+                                       "Content-type: text/html\n\n"
+                                       "\n\n"
+                                       "<html><head></head><body>"
+                               );
+               
+                               if (r->description != NULL) {
+                                       StrBufAppendPrintf(TheMessage, "%s<br><br>\r\n", r->description);
+                                       free(r->description);
+                                       r->description = NULL;
+                               }
+               
+                               if (r->link != NULL) {
+                                       StrBufAppendPrintf(TheMessage, "<a href=\"%s\">%s</a>\r\n", r->link, r->link);
+                                       free(r->link);
+                                       r->link = NULL;
+                               }
+       
+                               StrBufAppendPrintf(TheMessage, "</body></html>\r\n");
+                               CM_SetField(r->msg, eMesageText, ChrPtr(TheMessage), StrLength(TheMessage));
+                               FreeStrBuf(&TheMessage);
+       
+                               if (CM_IsEmpty(r->msg, eAuthor)) {
+                                       CM_SetField(r->msg, eAuthor, HKEY("rss"));
+                               }
+       
+                               if (CM_IsEmpty(r->msg, eTimestamp)) {
+                                       CM_SetFieldLONG(r->msg, eTimestamp, time(NULL));
+                               }
+       
+                               // Save it to the room(s)
+                               struct rssroom *rr = NULL;
+                               long msgnum = (-1);
+                               for (rr=r->rooms; rr!=NULL; rr=rr->next) {
+                                       if (rr == r->rooms) {
+                                               msgnum = CtdlSubmitMsg(r->msg, NULL, rr->room);         // in first room, save msg
+                                       }
+                                       else {
+                                               CtdlSaveMsgPointerInRoom(rr->room, msgnum, 0, NULL);    // elsewhere, save a pointer
+                                       }
+                                       syslog(LOG_DEBUG, "rssclient: saved message %ld to %s", msgnum, rr->room);
+                               }
+                       }
+                       else {
+                               syslog(LOG_DEBUG, "rssclient: already seen %s", r->item_id);
+                       }
+       
+                       CM_Free(r->msg);
+                       r->msg = NULL;
                }
 
+               if (r->item_id != NULL) {
+                       free(r->item_id);
+                       r->item_id = NULL;
+               }
        }
 
-}
-
-void rss_xml_end(void *data, const char *supplied_el) {
-       rsscollection *rssc = (rsscollection*) data;
-       rss_item *ri = rssc->Item;
-       char el[256];
-       char *sep = NULL;
-
-       /* Axe the namespace, we don't care about it */
-       safestrncpy(el, supplied_el, sizeof el);
-       while (sep = strchr(el, ':'), sep) {
-               strcpy(el, ++sep);
+       else if (!strcasecmp(el, "title")) {                    // item subject (rss and atom)
+               if ((r->msg != NULL) && (CM_IsEmpty(r->msg, eMsgSubject))) {
+                       encoded_field = NewStrBuf();
+                       StrBufRFC2047encode(&encoded_field, r->CData);
+                       CM_SetAsFieldSB(r->msg, eMsgSubject, &encoded_field);
+               }
        }
-//     CtdlLogPrintf(0, "RSS: END %s...\n", el);
 
-       if ( (!strcasecmp(el, "title")) && (ri->item_tag_nesting == 0) && (ri->chardata != NULL) ) {
-               safestrncpy(ri->channel_title, ri->chardata, sizeof ri->channel_title);
-               striplt(ri->channel_title);
+       else if (!strcasecmp(el, "creator")) {                  // <creator> can be used if <author> is not present
+               if ((r->msg != NULL) && (CM_IsEmpty(r->msg, eAuthor))) {
+                       encoded_field = NewStrBuf();
+                       StrBufRFC2047encode(&encoded_field, r->CData);
+                       CM_SetAsFieldSB(r->msg, eAuthor, &encoded_field);
+               }
        }
 
-       if ( (rssc->Cfg->ItemType == RSS_RSS) && 
-            (!strcasecmp(el, "guid")) && (ri->chardata != NULL) ) {
-               if (ri->guid != NULL) free(ri->guid);
-               striplt(ri->chardata);
-               ri->guid = strdup(ri->chardata);
-       }
-       else if ( (rssc->Cfg->ItemType == RSS_ATOM) && 
-                 (!strcasecmp(el, "id")) && (ri->chardata != NULL) ) {
-               if (ri->guid != NULL) free(ri->guid);
-               striplt(ri->chardata);
-               ri->guid = strdup(ri->chardata);
+       else if (!strcasecmp(el, "author")) {                   // <author> supercedes <creator> if both are present
+               if (r->msg != NULL) {
+                       encoded_field = NewStrBuf();
+                       StrBufRFC2047encode(&encoded_field, r->CData);
+                       CM_SetAsFieldSB(r->msg, eAuthor, &encoded_field);
+               }
        }
 
-       else if ( (rssc->Cfg->ItemType == RSS_RSS) && (!strcasecmp(el, "link")) && (ri->chardata != NULL) ) {
-               if (ri->link != NULL) free(ri->link);
-               striplt(ri->chardata);
-               ri->link = strdup(ri->chardata);
+       else if (!strcasecmp(el, "pubdate")) {                  // date/time stamp (rss) Sat, 25 Feb 2017 14:28:01 EST
+               if ((r->msg)&&(r->msg->cm_fields[eTimestamp]==NULL)) {
+                       CM_SetFieldLONG(r->msg, eTimestamp, parsedate(ChrPtr(r->CData)));
+               }
        }
 
-       else if ( (!strcasecmp(el, "title")) && (ri->chardata != NULL) ) {
-               if (ri->title != NULL) free(ri->title);
-               striplt(ri->chardata);
-               ri->title = strdup(ri->chardata);
+       else if (!strcasecmp(el, "updated")) {                  // date/time stamp (atom) 2003-12-13T18:30:02Z
+               if ((r->msg)&&(r->msg->cm_fields[eTimestamp]==NULL)) {
+                       struct tm t;
+                       char zulu;
+                       memset(&t, 0, sizeof t);
+                       sscanf(ChrPtr(r->CData), "%d-%d-%dT%d:%d:%d%c", &t.tm_year, &t.tm_mon, &t.tm_mday, &t.tm_hour, &t.tm_min, &t.tm_sec, &zulu);
+                       t.tm_year -= 1900;
+                       t.tm_mon -= 1;
+                       CM_SetFieldLONG(r->msg, eTimestamp, mktime(&t));
+               }
        }
 
-       else if ((rssc->Cfg->ItemType == RSS_ATOM) && 
-                (!strcasecmp(el, "content")) && 
-                (ri->chardata != NULL) ) {
-               if (ri->description != NULL) free(ri->description);
-               ri->description = strdup(ri->chardata);
-       }
-       else if ( (rssc->Cfg->ItemType == RSS_RSS) && 
-                 (!strcasecmp(el, "description")) &&
-                 (ri->chardata != NULL) ) {
-               if (ri->description != NULL) free(ri->description);
-               ri->description = strdup(ri->chardata);
-       }
-                 
-       else if ((rssc->Cfg->ItemType == RSS_ATOM) && 
-                ((!strcasecmp(el, "published")) ||
-                 (!strcasecmp(el, "updated"))) &&
-                (ri->chardata != NULL) ) {
-               striplt(ri->chardata);
-               ri->pubdate = rdf_parsedate(ri->chardata);
+       else if (!strcasecmp(el, "link")) {                     // link to story (rss)
+               if (r->link != NULL) {
+                       free(r->link);
+                       r->link = NULL;
+               }
+               r->link = strdup(ChrPtr(r->CData));
        }
 
-
-       else if ((rssc->Cfg->ItemType == RSS_RSS) && 
-                ((!strcasecmp(el, "pubdate")) || 
-                 (!strcasecmp(el, "date"))) && 
-                (ri->chardata != NULL) ) {
-               striplt(ri->chardata);
-               ri->pubdate = rdf_parsedate(ri->chardata);
+       else if (
+               (!strcasecmp(el, "guid"))                       // unique item id (rss)
+               || (!strcasecmp(el, "id"))                      // unique item id (atom)
+       ) {
+               if (r->item_id != NULL) {
+                       free(r->item_id);
+                       r->item_id = NULL;
+               }
+               r->item_id = strdup(ChrPtr(r->CData));
        }
 
-       else if ((rssc->Cfg->ItemType == RSS_RSS) && 
-                ((!strcasecmp(el, "author")) || 
-                 (!strcasecmp(el, "creator"))) && 
-                (ri->chardata != NULL) ) {
-               if (ri->author_or_creator != NULL) free(ri->author_or_creator);
-               striplt(ri->chardata);
-               ri->author_or_creator = strdup(ri->chardata);
+       else if (
+               (!strcasecmp(el, "description"))                // message text (rss)
+               || (!strcasecmp(el, "summary"))                 // message text (atom)
+               || (!strcasecmp(el, "content"))                 // message text (atom)
+       ) {
+               if (r->description != NULL) {
+                       free(r->description);
+                       r->description = NULL;
+               }
+               r->description = strdup(ChrPtr(r->CData));
        }
 
-       else if ((rssc->Cfg->ItemType == RSS_ATOM) && 
-                (!strcasecmp(el, "name")) && 
-                (ri->chardata != NULL) ) {
-               if (ri->author_or_creator != NULL) free(ri->author_or_creator);
-               striplt(ri->chardata);
-               ri->author_or_creator = strdup(ri->chardata);
-       }
-       else if ((rssc->Cfg->ItemType == RSS_ATOM) && 
-                (!strcasecmp(el, "uri")) && 
-                (ri->chardata != NULL) ) {
-               if (ri->author_url != NULL) free(ri->author_url);
-               striplt(ri->chardata);
-               ri->author_url = strdup(ri->chardata);
+       if (r->CData != NULL) {
+               FreeStrBuf(&r->CData);
+               r->CData = NULL;
        }
+}
 
-       else if ((rssc->Cfg->ItemType == RSS_RSS) && 
-                !strcasecmp(el, "item")) {
-               --ri->item_tag_nesting;
-               rss_save_item(rssc);
-       }
-       else if ((rssc->Cfg->ItemType == RSS_ATOM) && 
-                !strcasecmp(el, "entry")) {
-               --ri->item_tag_nesting;
-               rss_save_item(rssc);
-       }
 
-       else if ( (!strcasecmp(el, "rss")) || 
-                 (!strcasecmp(el, "rdf")) ) {
-//             CtdlLogPrintf(CTDL_DEBUG, "End of feed detected.  Closing parser.\n");
-               ri->done_parsing = 1;
-       }
+// This handler is called whenever data appears between opening and closing tags.
+//
+void rss_handle_data(void *data, const char *content, int length)
+{
+       struct rssparser *r = (struct rssparser *)data;
 
-       if (ri->chardata_len > 0) {
-               free(ri->chardata);
-               ri->chardata = 0;
-               ri->chardata_len = 0;
+       if (r->CData == NULL) {
+               r->CData = NewStrBuf();
        }
 
+       StrBufAppendBufPlain(r->CData, content, length, 0);
 }
 
 
-/*
- * This callback stores up the data which appears in between tags.
- */
-void rss_xml_chardata(void *data, const XML_Char *s, int len) {
-       rsscollection *rssc = (rsscollection*) data;
-       rss_item *ri = rssc->Item;
-       int old_len;
-       int new_len;
-       char *new_buffer;
-
-       old_len = ri->chardata_len;
-       new_len = old_len + len;
-       new_buffer = realloc(ri->chardata, new_len + 1);
-       if (new_buffer != NULL) {
-               memcpy(&new_buffer[old_len], s, len);
-               new_buffer[new_len] = 0;
-               ri->chardata = new_buffer;
-               ri->chardata_len = new_len;
-       }
+// Feed has been downloaded, now parse it.
+//
+void rss_parse_feed(StrBuf *Feed, struct rssroom *rooms)
+{
+       struct rssparser r;
+
+       memset(&r, 0, sizeof r);
+       r.rooms = rooms;
+       XML_Parser p = XML_ParserCreate("UTF-8");
+       XML_SetElementHandler(p, rss_start_element, rss_end_element);
+       XML_SetCharacterDataHandler(p, rss_handle_data);
+       XML_SetUserData(p, (void *)&r);
+       XML_Parse(p, ChrPtr(Feed), StrLength(Feed), XML_TRUE);
+       XML_ParserFree(p);
 }
 
 
-
-/*
- * Callback function for passing libcurl's output to expat for parsing
- */
-size_t rss_libcurl_callback(void *ptr, size_t size, size_t nmemb, void *stream)
+// Add a feed/room pair into the todo list
+//
+void rssclient_push_todo(char *rssurl, char *roomname)
 {
-       XML_Parse((XML_Parser)stream, ptr, (size * nmemb), 0);
-       return (size*nmemb);
-}
+       struct rssurl *r = NULL;
+       struct rssurl *thisone = NULL;
+       struct rssroom *newroom = NULL;
 
+       syslog(LOG_DEBUG, "rssclient: will fetch %s to %s", rssurl, roomname);
 
+       for (r=rsstodo; r!=NULL; r=r->next) {
+               if (!strcasecmp(r->url, rssurl)) {
+                       thisone = r;
+               }
+       }
 
-/*
- * Begin a feed parse
- */
-void rss_do_fetching(rssnetcfg *Cfg) {
-       rsscollection rssc;
-       rss_item ri;
-       XML_Parser xp;
+       if (thisone == NULL) {
+               thisone = malloc(sizeof(struct rssurl));
+               thisone->url = strdup(rssurl);
+               thisone->rooms = NULL;
+               thisone->next = rsstodo;
+               rsstodo = thisone;
+       }
 
+       newroom = malloc(sizeof(struct rssroom));
+       newroom->room = strdup(roomname);
+       newroom->next = thisone->rooms;
+       thisone->rooms = newroom;
+}
+
+
+// pull one feed (possibly multiple rooms)
+//
+void rss_pull_one_feed(struct rssurl *url)
+{
        CURL *curl;
        CURLcode res;
-       char errmsg[1024] = "";
+       StrBuf *Downloaded = NULL;
 
-       rssc.Item = &ri;
-       rssc.Cfg = Cfg;
-
-       CtdlLogPrintf(CTDL_DEBUG, "Fetching RSS feed <%s>\n", Cfg->url);
+       syslog(LOG_DEBUG, "rssclient: fetching %s", url->url);
 
        curl = curl_easy_init();
        if (!curl) {
-               CtdlLogPrintf(CTDL_ALERT, "Unable to initialize libcurl.\n");
                return;
        }
 
-       xp = XML_ParserCreateNS("UTF-8", ':');
-       if (!xp) {
-               CtdlLogPrintf(CTDL_ALERT, "Cannot create XML parser!\n");
-               curl_easy_cleanup(curl);
-               return;
-       }
+       Downloaded = NewStrBuf();
 
-       curl_easy_setopt(curl, CURLOPT_URL, Cfg->url);
-       curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0);
-       curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0);
-       curl_easy_setopt(curl, CURLOPT_WRITEDATA, xp);
-       curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, rss_libcurl_callback);
-       curl_easy_setopt(curl, CURLOPT_ERRORBUFFER, errmsg);
-       curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1);
-#ifdef CURLOPT_HTTP_CONTENT_DECODING
-       curl_easy_setopt(curl, CURLOPT_HTTP_CONTENT_DECODING, 1);
-       curl_easy_setopt(curl, CURLOPT_ENCODING, "");
-#endif
-       curl_easy_setopt(curl, CURLOPT_USERAGENT, CITADEL);
-       curl_easy_setopt(curl, CURLOPT_TIMEOUT, 180);           /* die after 180 seconds */
-       if (!IsEmptyStr(config.c_ip_addr)) {
-               curl_easy_setopt(curl, CURLOPT_INTERFACE, config.c_ip_addr);
+       curl_easy_setopt(curl, CURLOPT_URL, url->url);
+       curl_easy_setopt(curl, CURLOPT_SSL_VERIFYPEER, 0L);
+       curl_easy_setopt(curl, CURLOPT_SSL_VERIFYHOST, 0L);
+       curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L);                     // Follow redirects
+       curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, CurlFillStrBuf_callback); // What to do with downloaded data
+       curl_easy_setopt(curl, CURLOPT_WRITEDATA, Downloaded);                  // Give it our StrBuf to work with
+       curl_easy_setopt(curl, CURLOPT_TIMEOUT, 20L);                           // Time out after 20 seconds
+       res = curl_easy_perform(curl);                                          // Perform the request
+       if (res != CURLE_OK) {
+               syslog(LOG_WARNING, "rssclient: failed to load feed: %s", curl_easy_strerror(res));
        }
-
-       memset(&ri, 0, sizeof(rss_item));
-       ri.roomlist = Cfg->rooms;
-#ifdef HAVE_ICONV
-#if 0
-       XML_SetUnknownEncodingHandler(xp,
-                                     handle_unknown_xml_encoding,
-                                     NULL);
-#endif
-#endif
-       XML_SetElementHandler(xp, rss_xml_start, rss_xml_end);
-       XML_SetCharacterDataHandler(xp, rss_xml_chardata);
-       XML_SetUserData(xp, &rssc);
-       if (CtdlThreadCheckStop())
-       {
-               XML_ParserFree(xp);
-               curl_easy_cleanup(curl);
-               return;
-       }
-       
-       if (CtdlThreadCheckStop())
-               goto shutdown ;
-
-       res = curl_easy_perform(curl);
-       if (res) {
-               CtdlLogPrintf(CTDL_ALERT, "libcurl error %d: %s\n", res, errmsg);
-       }
-
-       if (CtdlThreadCheckStop())
-               goto shutdown ;
-
-       if (ri.done_parsing == 0)
-               XML_Parse(xp, "", 0, 1);
-
-
-       CtdlLogPrintf(CTDL_ALERT, "RSS: XML Status [%s] \n", 
-                     XML_ErrorString(
-                             XML_GetErrorCode(xp)));
-
-shutdown:
        curl_easy_cleanup(curl);
-       XML_ParserFree(xp);
 
-       flush_rss_ite(&ri);
+       rss_parse_feed(Downloaded, url->rooms);                                 // parse the feed
+       FreeStrBuf(&Downloaded);                                                // free the downloaded feed data
 }
 
 
-/*
- * Scan a room's netconfig to determine whether it is requesting any RSS feeds
- */
-void rssclient_scan_room(struct ctdlroom *qrbuf, void *data)
+// We have a list, now download the feeds
+//
+void rss_pull_feeds(void)
 {
-       char filename[PATH_MAX];
-       char buf[1024];
-       char instr[32];
-       FILE *fp;
-       char feedurl[256];
-       rssnetcfg *rncptr = NULL;
-       rssnetcfg *use_this_rncptr = NULL;
-       int len = 0;
-       char *ptr = NULL;
-
-       assoc_file_name(filename, sizeof filename, qrbuf, ctdl_netcfg_dir);
-
-       if (CtdlThreadCheckStop())
-               return;
-               
-       /* Only do net processing for rooms that have netconfigs */
-       fp = fopen(filename, "r");
-       if (fp == NULL) {
-               return;
+       struct rssurl *r;
+       struct rssroom *rr;
+
+       while (rsstodo != NULL) {
+               rss_pull_one_feed(rsstodo);
+               r = rsstodo;
+               rsstodo = rsstodo->next;
+               while (r->rooms != NULL) {
+                       rr = r->rooms;
+                       r->rooms = r->rooms->next;
+                       free(rr->room);
+                       free(rr);
+               }
+               free(r->url);
+               free(r);
        }
+}
 
-       while (fgets(buf, sizeof buf, fp) != NULL && !CtdlThreadCheckStop()) {
-               buf[strlen(buf)-1] = 0;
-
-               extract_token(instr, buf, 0, '|', sizeof instr);
-               if (!strcasecmp(instr, "rssclient")) {
-
-                       use_this_rncptr = NULL;
-
-                       extract_token(feedurl, buf, 1, '|', sizeof feedurl);
 
-                       /* If any other rooms have requested the same feed, then we will just add this
-                        * room to the target list for that client request.
-                        */
-                       for (rncptr=rnclist; rncptr!=NULL; rncptr=rncptr->next) {
-                               if (!strcmp(rncptr->url, feedurl)) {
-                                       use_this_rncptr = rncptr;
-                               }
-                       }
+// Scan a room's netconfig looking for RSS feed parsing requests
+//
+void rssclient_scan_room(struct ctdlroom *qrbuf, void *data)
+{
+       char *serialized_config = NULL;
+       int num_configs = 0;
+       char cfgline[SIZ];
+       int i = 0;
 
-                       /* Otherwise create a new client request */
-                       if (use_this_rncptr == NULL) {
-                               rncptr = (rssnetcfg *) malloc(sizeof(rssnetcfg));
-                               rncptr->ItemType = RSS_UNSET;
-                               if (rncptr != NULL) {
-                                       rncptr->next = rnclist;
-                                       safestrncpy(rncptr->url, feedurl, sizeof rncptr->url);
-                                       rncptr->rooms = NULL;
-                                       rnclist = rncptr;
-                                       use_this_rncptr = rncptr;
-                               }
-                       }
+        serialized_config = LoadRoomNetConfigFile(qrbuf->QRnumber);
+        if (!serialized_config) {
+               return;
+       }
 
-                       /* Add the room name to the request */
-                       if (use_this_rncptr != NULL) {
-                               if (use_this_rncptr->rooms == NULL) {
-                                       rncptr->rooms = strdup(qrbuf->QRname);
-                               }
-                               else {
-                                       len = strlen(use_this_rncptr->rooms) + strlen(qrbuf->QRname) + 5;
-                                       ptr = realloc(use_this_rncptr->rooms, len);
-                                       if (ptr != NULL) {
-                                               strcat(ptr, "|");
-                                               strcat(ptr, qrbuf->QRname);
-                                               use_this_rncptr->rooms = ptr;
-                                       }
-                               }
+       num_configs = num_tokens(serialized_config, '\n');
+       for (i=0; i<num_configs; ++i) {
+               extract_token(cfgline, serialized_config, i, '\n', sizeof cfgline);
+               if (!strncasecmp(cfgline, HKEY("rssclient|"))) {
+                       strcpy(cfgline, &cfgline[10]);
+                       char *vbar = strchr(cfgline, '|');
+                       if (vbar != NULL) {
+                               *vbar = 0;
                        }
+                       rssclient_push_todo(cfgline, qrbuf->QRname);
                }
-
        }
 
-       fclose(fp);
-
+       free(serialized_config);
 }
 
+
 /*
  * Scan for rooms that have RSS client requests configured
  */
-void *rssclient_scan(void *args) {
-       static time_t last_run = 0L;
-       static int doing_rssclient = 0;
-       rssnetcfg *rptr = NULL;
-       CitContext rssclientCC;
-
-       /* Give this thread its own private CitContext */
-       CtdlFillSystemContext(&rssclientCC, "rssclient");
-       citthread_setspecific(MyConKey, (void *)&rssclientCC );
-
-       CtdlThreadAllocTSD();
-
-       /*
-        * This is a simple concurrency check to make sure only one rssclient run
-        * is done at a time.  We could do this with a mutex, but since we
-        * don't really require extremely fine granularity here, we'll do it
-        * with a static variable instead.
-        */
-       if (doing_rssclient) return NULL;
-       doing_rssclient = 1;
-
-       CtdlLogPrintf(CTDL_DEBUG, "rssclient started\n");
-       CtdlForEachRoom(rssclient_scan_room, NULL);
-
-       while (rnclist != NULL && !CtdlThreadCheckStop()) {
-               rss_do_fetching(rnclist);
-               rptr = rnclist;
-               rnclist = rnclist->next;
-               if (rptr->rooms != NULL) free(rptr->rooms);
-               free(rptr);
+void rssclient_scan(void) {
+       time_t now = time(NULL);
+
+       /* Run no more than once every 15 minutes. */
+       if ((now - last_run) < 900) {
+               syslog(LOG_DEBUG,
+                       "rssclient: polling interval not yet reached; last run was %ldm%lds ago",
+                       ((now - last_run) / 60),
+                       ((now - last_run) % 60)
+               );
+               return;
        }
 
-       CtdlLogPrintf(CTDL_DEBUG, "rssclient ended\n");
+       syslog(LOG_DEBUG, "rssclient: started");
+       CtdlForEachRoom(rssclient_scan_room, NULL);
+       rss_pull_feeds();
+       syslog(LOG_DEBUG, "rssclient: ended");
        last_run = time(NULL);
-       doing_rssclient = 0;
-       if (!CtdlThreadCheckStop())
-               CtdlThreadSchedule ("RSS Client", CTDLTHREAD_BIGSTACK, rssclient_scan, NULL, last_run + config.c_net_freq);
-       else
-               CtdlLogPrintf(CTDL_DEBUG, "rssclient: Task STOPPED.\n");
-       CtdlClearSystemContext();
-       return NULL;
+       return;
 }
 
 
 CTDL_MODULE_INIT(rssclient)
 {
-       if (threading)
+       if (!threading)
        {
-               CtdlLogPrintf(CTDL_INFO, "%s\n", curl_version());
-               CtdlThreadSchedule ("RSS Client", CTDLTHREAD_BIGSTACK, rssclient_scan, NULL, 0);
+               syslog(LOG_INFO, "rssclient: using %s", curl_version());
+               CtdlRegisterSessionHook(rssclient_scan, EVT_TIMER, PRIO_AGGR + 300);
        }
-       /* return our Subversion id for the Log */
-        return "$Id$";
+       return "rssclient";
 }
+