]> code.citadel.org Git - citadel.git/blobdiff - citadel/room_ops.c
Added an elastic string buffer class to libcitadel. Why do I have a feeling I'm...
[citadel.git] / citadel / room_ops.c
index 4cfeae3125a8a7bc6cac3f3d974f4d1934962b85..44573dae34d985470c823f491b9005dba760efb8 100644 (file)
 /* 
- * $Id$
- * 
  * Server functions which perform operations on room objects.
  *
+ * Copyright (c) 1987-2021 by the citadel.org team
+ *
+ * This program is open source software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License, version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
  */
-#include "sysdep.h"
-#include <stdlib.h>
-#include <unistd.h>
+
 #include <stdio.h>
-#include <sys/stat.h>
-#include <string.h>
-#include <time.h>
-#include <limits.h>
-#include <errno.h>
-#include "citadel.h"
-#include "server.h"
-#include "database.h"
-#include "config.h"
-#include "room_ops.h"
-#include "sysdep_decls.h"
-#include "support.h"
-#include "user_ops.h"
-#include "msgbase.h"
+#include <libcitadel.h>
+
 #include "citserver.h"
+#include "ctdl_module.h"
+#include "config.h"
 #include "control.h"
-#include "tools.h"
+#include "user_ops.h"
+#include "room_ops.h"
 
 struct floor *floorcache[MAXFLOORS];
 
+/* 
+ * Determine whether the currently logged in session has permission to read
+ * messages in the current room.
+ */
+int CtdlDoIHavePermissionToReadMessagesInThisRoom(void) {
+       if (    (!(CC->logged_in))
+               && (!(CC->internal_pgm))
+               && (!CtdlGetConfigInt("c_guest_logins"))
+       ) {
+               return(om_not_logged_in);
+       }
+       return(om_ok);
+}
+
+
 /*
- * Generic routine for determining user access to rooms
+ * Check to see whether we have permission to post a message in the current
+ * room.  Returns a *CITADEL ERROR CODE* and puts a message in errmsgbuf, or
+ * returns 0 on success.
  */
-int CtdlRoomAccess(struct quickroom *roombuf, struct usersupp *userbuf)
-{
+int CtdlDoIHavePermissionToPostInThisRoom(
+       char *errmsgbuf, 
+       size_t n, 
+       const char* RemoteIdentifier,
+       PostType PostPublic,
+       int is_reply
+) {
+       int ra;
+
+       if (!(CC->logged_in) && (PostPublic == POST_LOGGED_IN)) {
+               snprintf(errmsgbuf, n, "Not logged in.");
+               return (ERROR + NOT_LOGGED_IN);
+       }
+       else if (PostPublic == CHECK_EXISTANCE) {
+               return (0);                                     // evaluate whether a recipient exists
+       }
+       else if (!(CC->logged_in)) {
+               if ((CC->room.QRflags & QR_READONLY)) {
+                       snprintf(errmsgbuf, n, "Not logged in.");
+                       return (ERROR + NOT_LOGGED_IN);
+               }
+               if (CC->room.QRflags2 & QR2_MODERATED) {
+                       snprintf(errmsgbuf, n, "Not logged in Moderation feature not yet implemented!");
+                       return (ERROR + NOT_LOGGED_IN);
+               }
+               // FIXME what was this?  AJC 2021
+               //if ((PostPublic != POST_LMTP) && (CC->room.QRflags2 & QR2_SMTP_PUBLIC) == 0) {
+                       //return CtdlNetconfigCheckRoomaccess(errmsgbuf, n, RemoteIdentifier);
+               //}
+               return (0);
+       }
+
+       if ((CC->user.axlevel < AxProbU) && ((CC->room.QRflags & QR_MAILBOX) == 0)) {
+               snprintf(errmsgbuf, n, "Need to be validated to enter (except in %s> to sysop)", MAILROOM);
+               return (ERROR + HIGHER_ACCESS_REQUIRED);
+       }
+
+       CtdlRoomAccess(&CC->room, &CC->user, &ra, NULL);
+
+       if (ra & UA_POSTALLOWED) {
+               strcpy(errmsgbuf, "OK to post or reply here");
+               return(0);
+       }
+
+       if ( (ra & UA_REPLYALLOWED) && (is_reply) ) {
+               /*
+                * To be thorough, we ought to check to see if the message they are
+                * replying to is actually a valid one in this room, but unless this
+                * actually becomes a problem we'll go with high performance instead.
+                */
+               strcpy(errmsgbuf, "OK to reply here");
+               return(0);
+       }
+
+       if ( (ra & UA_REPLYALLOWED) && (!is_reply) ) {
+               /* Clarify what happened with a better error message */
+               snprintf(errmsgbuf, n, "You may only reply to existing messages here.");
+               return (ERROR + HIGHER_ACCESS_REQUIRED);
+       }
+
+       snprintf(errmsgbuf, n, "Higher access is required to post in this room.");
+       return (ERROR + HIGHER_ACCESS_REQUIRED);
+
+}
+
+
+/*
+ * Check whether the current user has permission to delete messages from
+ * the current room (returns 1 for yes, 0 for no)
+ */
+int CtdlDoIHavePermissionToDeleteMessagesFromThisRoom(void) {
+       int ra;
+       CtdlRoomAccess(&CC->room, &CC->user, &ra, NULL);
+       if (ra & UA_DELETEALLOWED) return(1);
+       return(0);
+}
+
+
+/*
+ * Retrieve access control information for any user/room pair.
+ * Yes, it has a couple of gotos.  If you don't like that, go die in a car fire.
+ */
+void CtdlRoomAccess(struct ctdlroom *roombuf, struct ctdluser *userbuf, int *result, int *view) {
        int retval = 0;
-       struct visit vbuf;
+       visit vbuf;
+       int is_me = 0;
+       int is_guest = 0;
+
+       if (userbuf == &CC->user) {
+               is_me = 1;
+       }
+
+       if ((is_me) && (CtdlGetConfigInt("c_guest_logins")) && (!CC->logged_in)) {
+               is_guest = 1;
+       }
 
        /* for internal programs, always do everything */
        if (((CC->internal_pgm)) && (roombuf->QRflags & QR_INUSE)) {
-               return (UA_KNOWN | UA_GOTOALLOWED);
+               retval = (UA_KNOWN | UA_GOTOALLOWED | UA_POSTALLOWED | UA_DELETEALLOWED | UA_REPLYALLOWED);
+               vbuf.v_view = 0;
+               goto SKIP_EVERYTHING;
        }
-       /* For mailbox rooms, only allow access to the owner */
-       if (roombuf->QRflags & QR_MAILBOX) {
-               if (userbuf->usernum != atol(roombuf->QRname)) {
-                       return (retval);
-               }
+
+       /* If guest mode is enabled, always grant access to the Lobby */
+       if ((is_guest) && (!strcasecmp(roombuf->QRname, BASEROOM))) {
+               retval = (UA_KNOWN | UA_GOTOALLOWED);
+               vbuf.v_view = 0;
+               goto SKIP_EVERYTHING;
        }
+
        /* Locate any applicable user/room relationships */
-       CtdlGetRelationship(&vbuf, userbuf, roombuf);
+       if (is_guest) {
+               memset(&vbuf, 0, sizeof vbuf);
+       }
+       else {
+               CtdlGetRelationship(&vbuf, userbuf, roombuf);
+       }
 
        /* Force the properties of the Aide room */
-       if (!strcasecmp(roombuf->QRname, AIDEROOM)) {
-               if (userbuf->axlevel >= 6) {
-                       retval = UA_KNOWN | UA_GOTOALLOWED;
+       if (!strcasecmp(roombuf->QRname, CtdlGetConfigStr("c_aideroom"))) {
+               if (userbuf->axlevel >= AxAideU) {
+                       retval = UA_KNOWN | UA_GOTOALLOWED | UA_POSTALLOWED | UA_DELETEALLOWED | UA_REPLYALLOWED;
                } else {
                        retval = 0;
                }
                goto NEWMSG;
        }
-       /* For mailboxes, we skip all the access stuff (and we've
-        * already checked by this point that the mailbox belongs
-        * to the user)
-        */
-       if (roombuf->QRflags & QR_MAILBOX) {
-               retval = UA_KNOWN | UA_GOTOALLOWED;
-               goto NEWMSG;
-       }
+
        /* If this is a public room, it's accessible... */
-       if ((roombuf->QRflags & QR_PRIVATE) == 0) {
+       if (    ((roombuf->QRflags & QR_PRIVATE) == 0) 
+               && ((roombuf->QRflags & QR_MAILBOX) == 0)
+       ) {
                retval = retval | UA_KNOWN | UA_GOTOALLOWED;
        }
+
        /* If this is a preferred users only room, check access level */
        if (roombuf->QRflags & QR_PREFONLY) {
-               if (userbuf->axlevel < 5) {
+               if (userbuf->axlevel < AxPrefU) {
                        retval = retval & ~UA_KNOWN & ~UA_GOTOALLOWED;
                }
        }
+
        /* For private rooms, check the generation number matchups */
-       if (roombuf->QRflags & QR_PRIVATE) {
+       if (    (roombuf->QRflags & QR_PRIVATE) 
+               && ((roombuf->QRflags & QR_MAILBOX) == 0)
+       ) {
 
                /* An explicit match means the user belongs in this room */
                if (vbuf.v_flags & V_ACCESS) {
@@ -86,106 +198,200 @@ int CtdlRoomAccess(struct quickroom *roombuf, struct usersupp *userbuf)
                /* Otherwise, check if this is a guess-name or passworded
                 * room.  If it is, a goto may at least be attempted
                 */
-               else if ((roombuf->QRflags & QR_PRIVATE)
-                        || (roombuf->QRflags & QR_PASSWORDED)) {
+               else if (       (roombuf->QRflags & QR_PRIVATE)
+                               || (roombuf->QRflags & QR_PASSWORDED)
+               ) {
                        retval = retval & ~UA_KNOWN;
                        retval = retval | UA_GOTOALLOWED;
                }
        }
+
+       /* For mailbox rooms, also check the namespace */
+       /* Also, mailbox owners can delete their messages */
+       if ( (roombuf->QRflags & QR_MAILBOX) && (atol(roombuf->QRname) != 0)) {
+               if (userbuf->usernum == atol(roombuf->QRname)) {
+                       retval = retval | UA_KNOWN | UA_GOTOALLOWED | UA_POSTALLOWED | UA_DELETEALLOWED | UA_REPLYALLOWED;
+               }
+               /* An explicit match means the user belongs in this room */
+               if (vbuf.v_flags & V_ACCESS) {
+                       retval = retval | UA_KNOWN | UA_GOTOALLOWED | UA_POSTALLOWED | UA_DELETEALLOWED | UA_REPLYALLOWED;
+               }
+       }
+
+       /* For non-mailbox rooms... */
+       else {
+
+               /* User is allowed to post in the room unless:
+                * - User is not validated
+                * - User has no net privileges and it is a shared network room
+                * - It is a read-only room
+                * - It is a blog room (in which case we only allow replies to existing messages)
+                */
+               int post_allowed = 1;
+               int reply_allowed = 1;
+               if (userbuf->axlevel < AxProbU) {
+                       post_allowed = 0;
+                       reply_allowed = 0;
+               }
+               if ((userbuf->axlevel < AxNetU) && (roombuf->QRflags & QR_NETWORK)) {
+                       post_allowed = 0;
+                       reply_allowed = 0;
+               }
+               if (roombuf->QRflags & QR_READONLY) {
+                       post_allowed = 0;
+                       reply_allowed = 0;
+               }
+               if (roombuf->QRdefaultview == VIEW_BLOG) {
+                       post_allowed = 0;
+               }
+               if (post_allowed) {
+                       retval = retval | UA_POSTALLOWED | UA_REPLYALLOWED;
+               }
+               if (reply_allowed) {
+                       retval = retval | UA_REPLYALLOWED;
+               }
+
+               /* If "collaborative deletion" is active for this room, any user who can post
+                * is also allowed to delete
+                */
+               if (roombuf->QRflags2 & QR2_COLLABDEL) {
+                       if (retval & UA_POSTALLOWED) {
+                               retval = retval | UA_DELETEALLOWED;
+                       }
+               }
+
+       }
+
        /* Check to see if the user has forgotten this room */
        if (vbuf.v_flags & V_FORGET) {
                retval = retval & ~UA_KNOWN;
-               retval = retval | UA_ZAPPED;
+               if (    ( ((roombuf->QRflags & QR_PRIVATE) == 0) 
+                       && ((roombuf->QRflags & QR_MAILBOX) == 0)
+               ) || (  (roombuf->QRflags & QR_MAILBOX) 
+                       && (atol(roombuf->QRname) == CC->user.usernum))
+               ) {
+                       retval = retval | UA_ZAPPED;
+               }
        }
+
        /* If user is explicitly locked out of this room, deny everything */
        if (vbuf.v_flags & V_LOCKOUT) {
-               retval = retval & ~UA_KNOWN & ~UA_GOTOALLOWED;
+               retval = retval & ~UA_KNOWN & ~UA_GOTOALLOWED & ~UA_POSTALLOWED & ~UA_REPLYALLOWED;
        }
 
-       /* Aides get access to everything */
-       if (userbuf->axlevel >= 6) {
+       /* Aides get access to all private rooms */
+       if (    (userbuf->axlevel >= AxAideU)
+               && ((roombuf->QRflags & QR_MAILBOX) == 0)
+       ) {
                if (vbuf.v_flags & V_FORGET) {
-                       retval = retval | UA_GOTOALLOWED;
+                       retval = retval | UA_GOTOALLOWED | UA_POSTALLOWED | UA_REPLYALLOWED;
                }
                else {
-                       retval = retval | UA_KNOWN | UA_GOTOALLOWED;
+                       retval = retval | UA_KNOWN | UA_GOTOALLOWED | UA_POSTALLOWED | UA_REPLYALLOWED;
                }
        }
 
+       /* Aides can gain access to mailboxes as well, but they don't show
+        * by default.
+        */
+       if (    (userbuf->axlevel >= AxAideU)
+               && (roombuf->QRflags & QR_MAILBOX)
+       ) {
+               retval = retval | UA_GOTOALLOWED | UA_POSTALLOWED | UA_REPLYALLOWED;
+       }
+
+       /* Aides and Room Aides have admin privileges */
+       if (    (userbuf->axlevel >= AxAideU)
+               || (userbuf->usernum == roombuf->QRroomaide)
+       ) {
+               retval = retval | UA_ADMINALLOWED | UA_DELETEALLOWED | UA_POSTALLOWED | UA_REPLYALLOWED;
+       }
+
 NEWMSG:        /* By the way, we also check for the presence of new messages */
-       if ((roombuf->QRhighest) > (vbuf.v_lastseen)) {
+       if (is_msg_in_sequence_set(vbuf.v_seen, roombuf->QRhighest) == 0) {
                retval = retval | UA_HASNEWMSGS;
        }
-       return (retval);
+
+       /* System rooms never show up in the list. */
+       if (roombuf->QRflags2 & QR2_SYSTEM) {
+               retval = retval & ~UA_KNOWN;
+       }
+
+SKIP_EVERYTHING:
+       /* Now give the caller the information it wants. */
+       if (result != NULL) *result = retval;
+       if (view != NULL) *view = vbuf.v_view;
 }
 
+
 /*
  * Self-checking stuff for a room record read into memory
  */
-void room_sanity_check(struct quickroom *qrbuf)
-{
+void room_sanity_check(struct ctdlroom *qrbuf) {
        /* Mailbox rooms are always on the lowest floor */
        if (qrbuf->QRflags & QR_MAILBOX) {
                qrbuf->QRfloor = 0;
        }
        /* Listing order of 0 is illegal except for base rooms */
-       if (qrbuf->QRorder == 0)
-               if (!is_noneditable(qrbuf))
+       if (qrbuf->QRorder == 0) {
+               if (    !(qrbuf->QRflags & QR_MAILBOX)
+                       && strncasecmp(qrbuf->QRname, CtdlGetConfigStr("c_baseroom"), ROOMNAMELEN)
+                       && strncasecmp(qrbuf->QRname, CtdlGetConfigStr("c_aideroom"), ROOMNAMELEN)
+               ) {
                        qrbuf->QRorder = 64;
+               }
+       }
 }
 
 
 /*
- * getroom()  -  retrieve room data from disk
+ * CtdlGetRoom()  -  retrieve room data from disk
  */
-int getroom(struct quickroom *qrbuf, char *room_name)
-{
+int CtdlGetRoom(struct ctdlroom *qrbuf, const char *room_name) {
        struct cdbdata *cdbqr;
        char lowercase_name[ROOMNAMELEN];
        char personal_lowercase_name[ROOMNAMELEN];
-       int a;
+       const char *sptr;
+       char *dptr, *eptr;
 
-       for (a = 0; room_name[a] && a < sizeof lowercase_name - 1; ++a) {
-               lowercase_name[a] = tolower(room_name[a]);
+       dptr = lowercase_name;
+       sptr = room_name;
+       eptr = (dptr + (sizeof lowercase_name - 1));
+       while (!IsEmptyStr(sptr) && (dptr < eptr)) {
+               *dptr = tolower(*sptr);
+               sptr++; dptr++;
        }
-       lowercase_name[a] = 0;
+       *dptr = '\0';
 
-       memset(qrbuf, 0, sizeof(struct quickroom));
+       memset(qrbuf, 0, sizeof(struct ctdlroom));
 
        /* First, try the public namespace */
-       cdbqr = cdb_fetch(CDB_QUICKROOM,
-                         lowercase_name, strlen(lowercase_name));
+       cdbqr = cdb_fetch(CDB_ROOMS, lowercase_name, strlen(lowercase_name));
 
        /* If that didn't work, try the user's personal namespace */
        if (cdbqr == NULL) {
-               sprintf(personal_lowercase_name, "%010ld.%s",
-                       CC->usersupp.usernum, lowercase_name);
-               cdbqr = cdb_fetch(CDB_QUICKROOM,
-                                 personal_lowercase_name,
-                                 strlen(personal_lowercase_name));
+               snprintf(personal_lowercase_name, sizeof personal_lowercase_name, "%010ld.%s", CC->user.usernum, lowercase_name);
+               cdbqr = cdb_fetch(CDB_ROOMS, personal_lowercase_name, strlen(personal_lowercase_name));
        }
        if (cdbqr != NULL) {
-               memcpy(qrbuf, cdbqr->ptr,
-                      ((cdbqr->len > sizeof(struct quickroom)) ?
-                       sizeof(struct quickroom) : cdbqr->len));
+               memcpy(qrbuf, cdbqr->ptr, ((cdbqr->len > sizeof(struct ctdlroom)) ?  sizeof(struct ctdlroom) : cdbqr->len));
                cdb_free(cdbqr);
-
                room_sanity_check(qrbuf);
-
                return (0);
-       } else {
+       }
+       else {
                return (1);
        }
 }
 
+
 /*
- * lgetroom()  -  same as getroom() but locks the record (if supported)
+ * CtdlGetRoomLock()  -  same as getroom() but locks the record (if supported)
  */
-int lgetroom(struct quickroom *qrbuf, char *room_name)
-{
+int CtdlGetRoomLock(struct ctdlroom *qrbuf, const char *room_name) {
        register int retval;
-       retval = getroom(qrbuf, room_name);
-       if (retval == 0) begin_critical_section(S_QUICKROOM);
+       retval = CtdlGetRoom(qrbuf, room_name);
+       if (retval == 0) begin_critical_section(S_ROOMS);
        return(retval);
 }
 
@@ -194,31 +400,36 @@ int lgetroom(struct quickroom *qrbuf, char *room_name)
  * b_putroom()  -  back end to putroom() and b_deleteroom()
  *              (if the supplied buffer is NULL, delete the room record)
  */
-void b_putroom(struct quickroom *qrbuf, char *room_name)
+void b_putroom(struct ctdlroom *qrbuf, char *room_name)
 {
        char lowercase_name[ROOMNAMELEN];
-       int a;
+       char *aptr, *bptr;
+       long len;
 
-       for (a = 0; a <= strlen(room_name); ++a) {
-               lowercase_name[a] = tolower(room_name[a]);
+       aptr = room_name;
+       bptr = lowercase_name;
+       while (!IsEmptyStr(aptr)) {
+               *bptr = tolower(*aptr);
+               aptr++;
+               bptr++;
        }
+       *bptr='\0';
 
+       len = bptr - lowercase_name;
        if (qrbuf == NULL) {
-               cdb_delete(CDB_QUICKROOM,
-                          lowercase_name, strlen(lowercase_name));
-       else {
+               cdb_delete(CDB_ROOMS, lowercase_name, len);
+       }
+       else {
                time(&qrbuf->QRmtime);
-               cdb_store(CDB_QUICKROOM,
-                         lowercase_name, strlen(lowercase_name),
-                         qrbuf, sizeof(struct quickroom));
+               cdb_store(CDB_ROOMS, lowercase_name, len, qrbuf, sizeof(struct ctdlroom));
        }
 }
 
 
 /* 
- * putroom()  -  store room data to disk
+ * CtdlPutRoom()  -  store room data to disk
  */
-void putroom(struct quickroom *qrbuf) {
+void CtdlPutRoom(struct ctdlroom *qrbuf) {
        b_putroom(qrbuf, qrbuf->QRname);
 }
 
@@ -231,144 +442,197 @@ void b_deleteroom(char *room_name) {
 }
 
 
+/*
+ * CtdlPutRoomLock()  -  same as CtdlPutRoom() but unlocks the record (if supported)
+ */
+void CtdlPutRoomLock(struct ctdlroom *qrbuf) {
+       CtdlPutRoom(qrbuf);
+       end_critical_section(S_ROOMS);
+}
+
 
 /*
- * lputroom()  -  same as putroom() but unlocks the record (if supported)
+ * CtdlGetFloorByName()  -  retrieve the number of the named floor
+ * return < 0 if not found else return floor number
  */
-void lputroom(struct quickroom *qrbuf)
-{
+int CtdlGetFloorByName(const char *floor_name) {
+       int a;
+       struct floor *flbuf = NULL;
 
-       putroom(qrbuf);
-       end_critical_section(S_QUICKROOM);
+       for (a = 0; a < MAXFLOORS; ++a) {
+               flbuf = CtdlGetCachedFloor(a);
 
+               /* check to see if it already exists */
+               if ((!strcasecmp(flbuf->f_name, floor_name)) && (flbuf->f_flags & F_INUSE)) {
+                       return a;
+               }
+       }
+       return -1;
 }
 
-/****************************************************************************/
 
 /*
- * getfloor()  -  retrieve floor data from disk
+ * CtdlGetFloorByNameLock()  -  retrieve floor number for given floor and lock the floor list.
  */
-void getfloor(struct floor *flbuf, int floor_num)
+int CtdlGetFloorByNameLock(const char *floor_name)
 {
+       begin_critical_section(S_FLOORTAB);
+       return CtdlGetFloorByName(floor_name);
+}
+
+
+/*
+ * CtdlGetAvailableFloor()  -  Return number of first unused floor
+ * return < 0 if none available
+ */
+int CtdlGetAvailableFloor(void) {
+       int a;
+       struct floor *flbuf = NULL;
+
+       for (a = 0; a < MAXFLOORS; a++) {
+               flbuf = CtdlGetCachedFloor(a);
+
+               /* check to see if it already exists */
+               if ((flbuf->f_flags & F_INUSE) == 0) {
+                       return a;
+               }
+       }
+       return -1;
+}
+
+
+/*
+ * CtdlGetFloor()  -  retrieve floor data from disk
+ */
+void CtdlGetFloor(struct floor *flbuf, int floor_num) {
        struct cdbdata *cdbfl;
 
        memset(flbuf, 0, sizeof(struct floor));
        cdbfl = cdb_fetch(CDB_FLOORTAB, &floor_num, sizeof(int));
        if (cdbfl != NULL) {
-               memcpy(flbuf, cdbfl->ptr,
-                      ((cdbfl->len > sizeof(struct floor)) ?
-                       sizeof(struct floor) : cdbfl->len));
+               memcpy(flbuf, cdbfl->ptr, ((cdbfl->len > sizeof(struct floor)) ?  sizeof(struct floor) : cdbfl->len));
                cdb_free(cdbfl);
        } else {
                if (floor_num == 0) {
-                       strcpy(flbuf->f_name, "Main Floor");
+                       safestrncpy(flbuf->f_name, "Main Floor", sizeof flbuf->f_name);
                        flbuf->f_flags = F_INUSE;
                        flbuf->f_ref_count = 3;
                }
        }
-
 }
 
+
 /*
- * lgetfloor()  -  same as getfloor() but locks the record (if supported)
+ * lgetfloor()  -  same as CtdlGetFloor() but locks the record (if supported)
  */
-void lgetfloor(struct floor *flbuf, int floor_num)
-{
-
+void lgetfloor(struct floor *flbuf, int floor_num) {
        begin_critical_section(S_FLOORTAB);
-       getfloor(flbuf, floor_num);
+       CtdlGetFloor(flbuf, floor_num);
 }
 
 
 /*
- * cgetfloor()  -  Get floor record from *cache* (loads from disk if needed)
+ * CtdlGetCachedFloor()  -  Get floor record from *cache* (loads from disk if needed)
  *    
  * This is strictly a performance hack.
  */
-struct floor *cgetfloor(int floor_num) {
+struct floor *CtdlGetCachedFloor(int floor_num) {
        static int initialized = 0;
        int i;
+       int fetch_new = 0;
+       struct floor *fl = NULL;
 
+       begin_critical_section(S_FLOORCACHE);
        if (initialized == 0) {
                for (i=0; i<MAXFLOORS; ++i) {
                        floorcache[floor_num] = NULL;
                }
        initialized = 1;
        }
-       
        if (floorcache[floor_num] == NULL) {
-               floorcache[floor_num] = mallok(sizeof(struct floor));
-               getfloor(floorcache[floor_num], floor_num);
+               fetch_new = 1;
+       }
+       end_critical_section(S_FLOORCACHE);
+
+       if (fetch_new) {
+               fl = malloc(sizeof(struct floor));
+               CtdlGetFloor(fl, floor_num);
+               begin_critical_section(S_FLOORCACHE);
+               if (floorcache[floor_num] != NULL) {
+                       free(floorcache[floor_num]);
+               }
+               floorcache[floor_num] = fl;
+               end_critical_section(S_FLOORCACHE);
        }
 
        return(floorcache[floor_num]);
 }
 
 
-
 /*
- * putfloor()  -  store floor data on disk
+ * CtdlPutFloor()  -  store floor data on disk
  */
-void putfloor(struct floor *flbuf, int floor_num)
-{
-       cdb_store(CDB_FLOORTAB, &floor_num, sizeof(int),
-                 flbuf, sizeof(struct floor));
-
+void CtdlPutFloor(struct floor *flbuf, int floor_num) {
        /* If we've cached this, clear it out, 'cuz it's WRONG now! */
+       begin_critical_section(S_FLOORCACHE);
        if (floorcache[floor_num] != NULL) {
-               phree(floorcache[floor_num]);
-               floorcache[floor_num] = NULL;
+               free(floorcache[floor_num]);
+               floorcache[floor_num] = malloc(sizeof(struct floor));
+               memcpy(floorcache[floor_num], flbuf, sizeof(struct floor));
        }
+       end_critical_section(S_FLOORCACHE);
+
+       cdb_store(CDB_FLOORTAB, &floor_num, sizeof(int),
+                 flbuf, sizeof(struct floor));
 }
 
 
 /*
- * lputfloor()  -  same as putfloor() but unlocks the record (if supported)
+ * CtdlPutFloorLock()  -  same as CtdlPutFloor() but unlocks the record (if supported)
  */
-void lputfloor(struct floor *flbuf, int floor_num)
-{
-
-       putfloor(flbuf, floor_num);
+void CtdlPutFloorLock(struct floor *flbuf, int floor_num) {
+       CtdlPutFloor(flbuf, floor_num);
        end_critical_section(S_FLOORTAB);
 
 }
 
 
+/*
+ * lputfloor()  -  same as CtdlPutFloor() but unlocks the record (if supported)
+ */
+void lputfloor(struct floor *flbuf, int floor_num) {
+       CtdlPutFloorLock(flbuf, floor_num);
+}
+
 /* 
- *  Traverse the room file...
+ * Iterate through the room table, performing a callback for each room.
  */
-void ForEachRoom(void (*CallBack) (struct quickroom *EachRoom, void *out_data),
-               void *in_data)
-{
-       struct quickroom qrbuf;
+void CtdlForEachRoom(ForEachRoomCallBack callback_func, void *in_data) {
+       struct ctdlroom qrbuf;
        struct cdbdata *cdbqr;
 
-       cdb_begin_transaction();
-       cdb_rewind(CDB_QUICKROOM);
+       cdb_rewind(CDB_ROOMS);
 
-       while (cdbqr = cdb_next_item(CDB_QUICKROOM), cdbqr != NULL) {
-               memset(&qrbuf, 0, sizeof(struct quickroom));
-               memcpy(&qrbuf, cdbqr->ptr,
-                      ((cdbqr->len > sizeof(struct quickroom)) ?
-                       sizeof(struct quickroom) : cdbqr->len));
+       while (cdbqr = cdb_next_item(CDB_ROOMS), cdbqr != NULL) {
+               memset(&qrbuf, 0, sizeof(struct ctdlroom));
+               memcpy(&qrbuf, cdbqr->ptr, ((cdbqr->len > sizeof(struct ctdlroom)) ?  sizeof(struct ctdlroom) : cdbqr->len) );
                cdb_free(cdbqr);
                room_sanity_check(&qrbuf);
-               if (qrbuf.QRflags & QR_INUSE)
-                       (*CallBack)(&qrbuf, in_data);
+               if (qrbuf.QRflags & QR_INUSE) {
+                       callback_func(&qrbuf, in_data);
+               }
        }
-       cdb_end_transaction();
 }
 
 
 /*
  * delete_msglist()  -  delete room message pointers
  */
-void delete_msglist(struct quickroom *whichroom)
-{
+void delete_msglist(struct ctdlroom *whichroom) {
         struct cdbdata *cdbml;
 
        /* Make sure the msglist we're deleting actually exists, otherwise
-        * gdbm will complain when we try to delete an invalid record
+        * libdb will complain when we try to delete an invalid record
         */
         cdbml = cdb_fetch(CDB_MSGLISTS, &whichroom->QRnumber, sizeof(long));
         if (cdbml != NULL) {
@@ -380,39 +644,38 @@ void delete_msglist(struct quickroom *whichroom)
 }
 
 
+/*
+ * Message pointer compare function for sort_msglist()
+ */
+int sort_msglist_cmp(const void *m1, const void *m2) {
+       if ((*(const long *)m1) > (*(const long *)m2)) return(1);
+       if ((*(const long *)m1) < (*(const long *)m2)) return(-1);
+       return(0);
+}
 
 
 /*
  * sort message pointers
  * (returns new msg count)
  */
-int sort_msglist(long listptrs[], int oldcount)
-{
-       int a, b;
-       long hold1, hold2;
+int sort_msglist(long listptrs[], int oldcount) {
        int numitems;
+       int i = 0;
 
        numitems = oldcount;
-       if (numitems < 2)
+       if (numitems < 2) {
                return (oldcount);
+       }
 
        /* do the sort */
-       for (a = numitems - 2; a >= 0; --a) {
-               for (b = 0; b <= a; ++b) {
-                       if (listptrs[b] > (listptrs[b + 1])) {
-                               hold1 = listptrs[b];
-                               hold2 = listptrs[b + 1];
-                               listptrs[b] = hold2;
-                               listptrs[b + 1] = hold1;
-                       }
-               }
-       }
+       qsort(listptrs, numitems, sizeof(long), sort_msglist_cmp);
 
        /* and yank any nulls */
-       while ((numitems > 0) && (listptrs[0] == 0L)) {
-               memcpy(&listptrs[0], &listptrs[1],
-                      (sizeof(long) * (numitems - 1)));
-               --numitems;
+       while ((i < numitems) && (listptrs[i] == 0L)) i++;
+
+       if (i > 0) {
+               memmove(&listptrs[0], &listptrs[i], (sizeof(long) * (numitems - i)));
+               numitems-=i;
        }
 
        return (numitems);
@@ -422,763 +685,403 @@ int sort_msglist(long listptrs[], int oldcount)
 /*
  * Determine whether a given room is non-editable.
  */
-int is_noneditable(struct quickroom *qrbuf)
-{
-
-       /* Lobby> and Aide> are non-editable */
-       if (!strcasecmp(qrbuf->QRname, BASEROOM))
-               return (1);
-       else if (!strcasecmp(qrbuf->QRname, AIDEROOM))
-               return (1);
+int CtdlIsNonEditable(struct ctdlroom *qrbuf) {
 
-       /* Mail> rooms are also non-editable */
-       else if ( (qrbuf->QRflags & QR_MAILBOX)
-            && (!strcasecmp(&qrbuf->QRname[11], MAILROOM)) )
+       /* Mail> rooms are non-editable */
+       if ( (qrbuf->QRflags & QR_MAILBOX) && (!strcasecmp(&qrbuf->QRname[11], MAILROOM)) ) {
                return (1);
+       }
 
        /* Everything else is editable */
-       else
-               return (0);
+       return (0);
 }
 
 
 
 /*
- * Back-back-end for all room listing commands
+ * Make the specified room the current room for this session.  No validation
+ * or access control is done here -- the caller should make sure that the
+ * specified room exists and is ok to access.
  */
-void list_roomname(struct quickroom *qrbuf)
+void CtdlUserGoto(char *where, int display_result, int transiently,
+               int *retmsgs, int *retnew, long *retoldest, long *retnewest)
 {
+       int a;
+       int new_messages = 0;
+       int old_messages = 0;
+       int total_messages = 0;
+       long oldest_message = 0;
+       long newest_message = 0;
+       int info = 0;
+       int rmailflag;
+       int raideflag;
+       int newmailcount = 0;
+       visit vbuf;
        char truncated_roomname[ROOMNAMELEN];
+        struct cdbdata *cdbfr;
+       long *msglist = NULL;
+       int num_msgs = 0;
+       unsigned int original_v_flags;
+       int num_sets;
+       int s;
+       char setstr[128], lostr[64], histr[64];
+       long lo, hi;
+       int is_trash = 0;
+
+       /* If the supplied room name is NULL, the caller wants us to know that
+        * it has already copied the room record into CC->room, so
+        * we can skip the extra database fetch.
+        */
+       if (where != NULL) {
+               safestrncpy(CC->room.QRname, where, sizeof CC->room.QRname);
+               CtdlGetRoom(&CC->room, where);
+       }
 
-       /* For mailbox rooms, chop off the owner prefix */
-       if (qrbuf->QRflags & QR_MAILBOX) {
-               strcpy(truncated_roomname, qrbuf->QRname);
-               strcpy(truncated_roomname, &truncated_roomname[11]);
-               cprintf("%s", truncated_roomname);
+       /* Take care of all the formalities. */
+
+       begin_critical_section(S_USERS);
+       CtdlGetRelationship(&vbuf, &CC->user, &CC->room);
+       original_v_flags = vbuf.v_flags;
+
+       /* Know the room ... but not if it's the page log room, or if the
+        * caller specified that we're only entering this room transiently.
+        */
+       int add_room_to_known_list = 1;
+       if (transiently == 1) {
+               add_room_to_known_list = 0;
        }
-       /* For all other rooms, just display the name in its entirety */
-       else {
-               cprintf("%s", qrbuf->QRname);
+       char *c_logpages = CtdlGetConfigStr("c_logpages");
+       if ( (c_logpages != NULL) && (!strcasecmp(CC->room.QRname, c_logpages)) ) {
+               add_room_to_known_list = 0;
        }
+       if (add_room_to_known_list) {
+               vbuf.v_flags = vbuf.v_flags & ~V_FORGET & ~V_LOCKOUT;
+               vbuf.v_flags = vbuf.v_flags | V_ACCESS;
+       }
+       
+       /* Only rewrite the database record if we changed something */
+       if (vbuf.v_flags != original_v_flags) {
+               CtdlSetRelationship(&vbuf, &CC->user, &CC->room);
+       }
+       end_critical_section(S_USERS);
 
-       /* ...and now the other parameters */
-       cprintf("|%u|%d|%d\n",
-               qrbuf->QRflags,
-               (int) qrbuf->QRfloor,
-               (int) qrbuf->QRorder);
-}
-
+       /* Check for new mail */
+       newmailcount = NewMailCount();
 
-/* 
- * cmd_lrms()   -  List all accessible rooms, known or forgotten
- */
-void cmd_lrms_backend(struct quickroom *qrbuf, void *data)
-{
-       int FloorBeingSearched = (-1);
-       FloorBeingSearched = *(int *)data;
-
-       if (((CtdlRoomAccess(qrbuf, &CC->usersupp)
-             & (UA_KNOWN | UA_ZAPPED)))
-           && ((qrbuf->QRfloor == (FloorBeingSearched))
-               || ((FloorBeingSearched) < 0)))
-               list_roomname(qrbuf);
-}
+       /* Set info to 1 if the room banner is new since our last visit.
+        * Some clients only want to display it when it changes.
+        */
+       if (CC->room.msgnum_info > vbuf.v_lastseen) {
+               info = 1;
+       }
 
-void cmd_lrms(char *argbuf)
-{
-       int FloorBeingSearched = (-1);
-       if (strlen(argbuf) > 0)
-               FloorBeingSearched = extract_int(argbuf, 0);
+        cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->room.QRnumber, sizeof(long));
+        if (cdbfr != NULL) {
+               msglist = (long *) cdbfr->ptr;
+               cdbfr->ptr = NULL;      /* CtdlUserGoto() now owns this memory */
+               num_msgs = cdbfr->len / sizeof(long);
+               cdb_free(cdbfr);
+       }
 
-       if (CtdlAccessCheck(ac_logged_in)) return;
+       total_messages = 0;
+       for (a=0; a<num_msgs; ++a) {
+               if (msglist[a] > 0L) ++total_messages;
+       }
 
-       if (getuser(&CC->usersupp, CC->curr_user)) {
-               cprintf("%d Can't locate user!\n", ERROR + INTERNAL_ERROR);
-               return;
+       if (total_messages > 0) {
+               oldest_message = msglist[0];
+               newest_message = msglist[num_msgs - 1];
        }
-       cprintf("%d Accessible rooms:\n", LISTING_FOLLOWS);
 
-       ForEachRoom(cmd_lrms_backend, &FloorBeingSearched);
-       cprintf("000\n");
-}
+       num_sets = num_tokens(vbuf.v_seen, ',');
+       for (s=0; s<num_sets; ++s) {
+               extract_token(setstr, vbuf.v_seen, s, ',', sizeof setstr);
 
+               extract_token(lostr, setstr, 0, ':', sizeof lostr);
+               if (num_tokens(setstr, ':') >= 2) {
+                       extract_token(histr, setstr, 1, ':', sizeof histr);
+                       if (!strcmp(histr, "*")) {
+                               snprintf(histr, sizeof histr, "%ld", LONG_MAX);
+                       }
+               } 
+               else {
+                       strcpy(histr, lostr);
+               }
+               lo = atol(lostr);
+               hi = atol(histr);
 
+               for (a=0; a<num_msgs; ++a) if (msglist[a] > 0L) {
+                       if ((msglist[a] >= lo) && (msglist[a] <= hi)) {
+                               ++old_messages;
+                               msglist[a] = 0L;
+                       }
+               }
+       }
+       new_messages = total_messages - old_messages;
 
-/* 
- * cmd_lkra()   -  List all known rooms
- */
-void cmd_lkra_backend(struct quickroom *qrbuf, void *data)
-{
-       int FloorBeingSearched = (-1);
-       FloorBeingSearched = *(int *)data;
-
-       if (((CtdlRoomAccess(qrbuf, &CC->usersupp)
-             & (UA_KNOWN)))
-           && ((qrbuf->QRfloor == (FloorBeingSearched))
-               || ((FloorBeingSearched) < 0)))
-               list_roomname(qrbuf);
-}
+       if (msglist != NULL) free(msglist);
 
-void cmd_lkra(char *argbuf)
-{
-       int FloorBeingSearched = (-1);
-       if (strlen(argbuf) > 0)
-               FloorBeingSearched = extract_int(argbuf, 0);
+       if (CC->room.QRflags & QR_MAILBOX)
+               rmailflag = 1;
+       else
+               rmailflag = 0;
 
-       if (CtdlAccessCheck(ac_logged_in)) return;
-       
-       if (getuser(&CC->usersupp, CC->curr_user)) {
-               cprintf("%d Can't locate user!\n", ERROR + INTERNAL_ERROR);
-               return;
+       if ((CC->room.QRroomaide == CC->user.usernum) || (CC->user.axlevel >= AxAideU))
+               raideflag = 1;
+       else
+               raideflag = 0;
+
+       safestrncpy(truncated_roomname, CC->room.QRname, sizeof truncated_roomname);
+       if ( (CC->room.QRflags & QR_MAILBOX) && (atol(CC->room.QRname) == CC->user.usernum) ) {
+               safestrncpy(truncated_roomname, &truncated_roomname[11], sizeof truncated_roomname);
        }
-       cprintf("%d Known rooms:\n", LISTING_FOLLOWS);
 
-       ForEachRoom(cmd_lkra_backend, &FloorBeingSearched);
-       cprintf("000\n");
-}
+       if (!strcasecmp(truncated_roomname, USERTRASHROOM)) {
+               is_trash = 1;
+       }
 
+       if (retmsgs != NULL) *retmsgs = total_messages;
+       if (retnew != NULL) *retnew = new_messages;
+       if (retoldest != NULL) *retoldest = oldest_message;
+       if (retnewest != NULL) *retnewest = newest_message;
+       syslog(LOG_DEBUG, "room_ops: %s : %d new of %d total messages, oldest=%ld, newest=%ld",
+                  CC->room.QRname, new_messages, total_messages, oldest_message, newest_message
+       );
 
+       CC->curr_view = (int)vbuf.v_view;
 
-/* 
- * cmd_lkrn()   -  List all known rooms with new messages
- */
-void cmd_lkrn_backend(struct quickroom *qrbuf, void *data)
-{
-       int ra;
-       int FloorBeingSearched = (-1);
-       FloorBeingSearched = *(int *)data;
-
-       ra = CtdlRoomAccess(qrbuf, &CC->usersupp);
-       if ((ra & UA_KNOWN)
-           && (ra & UA_HASNEWMSGS)
-           && ((qrbuf->QRfloor == (FloorBeingSearched))
-               || ((FloorBeingSearched) < 0)))
-               list_roomname(qrbuf);
+       if (display_result) {
+               cprintf("%d%c%s|%d|%d|%d|%d|%ld|%ld|%d|%d|%d|%d|%d|%d|%d|%d|%ld|\n",
+                       CIT_OK, CtdlCheckExpress(),
+                       truncated_roomname,
+                       (int)new_messages,
+                       (int)total_messages,
+                       (int)info,
+                       (int)CC->room.QRflags,
+                       (long)CC->room.QRhighest,
+                       (long)vbuf.v_lastseen,
+                       (int)rmailflag,
+                       (int)raideflag,
+                       (int)newmailcount,
+                       (int)CC->room.QRfloor,
+                       (int)vbuf.v_view,
+                       (int)CC->room.QRdefaultview,
+                       (int)is_trash,
+                       (int)CC->room.QRflags2,
+                       (long)CC->room.QRmtime
+               );
+       }
 }
 
-void cmd_lkrn(char *argbuf)
-{
-       int FloorBeingSearched = (-1);
-       if (strlen(argbuf) > 0)
-               FloorBeingSearched = extract_int(argbuf, 0);
-
-       if (CtdlAccessCheck(ac_logged_in)) return;
-       
-       if (getuser(&CC->usersupp, CC->curr_user)) {
-               cprintf("%d Can't locate user!\n", ERROR + INTERNAL_ERROR);
-               return;
-       }
-       cprintf("%d Rooms w/ new msgs:\n", LISTING_FOLLOWS);
-
-       ForEachRoom(cmd_lkrn_backend, &FloorBeingSearched);
-       cprintf("000\n");
-}
 
-
-
-/* 
- * cmd_lkro()   -  List all known rooms
+/*
+ * Handle some of the macro named rooms
  */
-void cmd_lkro_backend(struct quickroom *qrbuf, void *data)
-{
-       int ra;
-       int FloorBeingSearched = (-1);
-       FloorBeingSearched = *(int *)data;
-
-       ra = CtdlRoomAccess(qrbuf, &CC->usersupp);
-       if ((ra & UA_KNOWN)
-           && ((ra & UA_HASNEWMSGS) == 0)
-           && ((qrbuf->QRfloor == (FloorBeingSearched))
-               || ((FloorBeingSearched) < 0)))
-               list_roomname(qrbuf);
-}
-
-void cmd_lkro(char *argbuf)
-{
-       int FloorBeingSearched = (-1);
-       if (strlen(argbuf) > 0)
-               FloorBeingSearched = extract_int(argbuf, 0);
-
-       if (CtdlAccessCheck(ac_logged_in)) return;
-       
-       if (getuser(&CC->usersupp, CC->curr_user)) {
-               cprintf("%d Can't locate user!\n", ERROR + INTERNAL_ERROR);
-               return;
+void convert_room_name_macros(char *towhere, size_t maxlen) {
+       if (!strcasecmp(towhere, "_BASEROOM_")) {
+               safestrncpy(towhere, CtdlGetConfigStr("c_baseroom"), maxlen);
        }
-       cprintf("%d Rooms w/o new msgs:\n", LISTING_FOLLOWS);
-
-       ForEachRoom(cmd_lkro_backend, &FloorBeingSearched);
-       cprintf("000\n");
-}
-
-
-
-/* 
- * cmd_lzrm()   -  List all forgotten rooms
- */
-void cmd_lzrm_backend(struct quickroom *qrbuf, void *data)
-{
-       int ra;
-       int FloorBeingSearched = (-1);
-       FloorBeingSearched = *(int *)data;
-
-       ra = CtdlRoomAccess(qrbuf, &CC->usersupp);
-       if ((ra & UA_GOTOALLOWED)
-           && (ra & UA_ZAPPED)
-           && ((qrbuf->QRfloor == (FloorBeingSearched))
-               || ((FloorBeingSearched) < 0)))
-               list_roomname(qrbuf);
-}
-
-void cmd_lzrm(char *argbuf)
-{
-       int FloorBeingSearched = (-1);
-       if (strlen(argbuf) > 0)
-               FloorBeingSearched = extract_int(argbuf, 0);
-
-       if (CtdlAccessCheck(ac_logged_in)) return;
-       
-       if (getuser(&CC->usersupp, CC->curr_user)) {
-               cprintf("%d Can't locate user!\n", ERROR + INTERNAL_ERROR);
-               return;
+       else if (!strcasecmp(towhere, "_MAIL_")) {
+               safestrncpy(towhere, MAILROOM, maxlen);
        }
-       cprintf("%d Zapped rooms:\n", LISTING_FOLLOWS);
-
-       ForEachRoom(cmd_lzrm_backend, &FloorBeingSearched);
-       cprintf("000\n");
-}
-
-
-
-void usergoto(char *where, int display_result, int *retmsgs, int *retnew)
-{
-       int a;
-       int new_messages = 0;
-       int total_messages = 0;
-       int info = 0;
-       int rmailflag;
-       int raideflag;
-       int newmailcount = 0;
-       struct visit vbuf;
-       char truncated_roomname[ROOMNAMELEN];
-        struct cdbdata *cdbfr;
-       long *msglist = NULL;
-       int num_msgs = 0;
-
-       strcpy(CC->quickroom.QRname, where);
-       getroom(&CC->quickroom, where);
-
-       lgetuser(&CC->usersupp, CC->curr_user);
-       CtdlGetRelationship(&vbuf, &CC->usersupp, &CC->quickroom);
-
-       /* Know the room ... but not if it's the page log room */
-       if (strcasecmp(where, config.c_logpages)) {
-               vbuf.v_flags = vbuf.v_flags & ~V_FORGET & ~V_LOCKOUT;
-               vbuf.v_flags = vbuf.v_flags | V_ACCESS;
+       else if (!strcasecmp(towhere, "_TRASH_")) {
+               safestrncpy(towhere, USERTRASHROOM, maxlen);
        }
-       CtdlSetRelationship(&vbuf, &CC->usersupp, &CC->quickroom);
-       lputuser(&CC->usersupp);
-
-       /* check for new mail */
-       newmailcount = NewMailCount();
-
-       /* set info to 1 if the user needs to read the room's info file */
-       if (CC->quickroom.QRinfo > vbuf.v_lastseen)
-               info = 1;
-
-       get_mm();
-        cdbfr = cdb_fetch(CDB_MSGLISTS, &CC->quickroom.QRnumber, sizeof(long));
-        if (cdbfr != NULL) {
-               msglist = mallok(cdbfr->len);
-               memcpy(msglist, cdbfr->ptr, cdbfr->len);
-               num_msgs = cdbfr->len / sizeof(long);
-               cdb_free(cdbfr);
+       else if (!strcasecmp(towhere, "_DRAFTS_")) {
+               safestrncpy(towhere, USERDRAFTROOM, maxlen);
        }
-
-       if (num_msgs > 0) for (a = 0; a < num_msgs; ++a) {
-               if (msglist[a] > 0L) {
-                       ++total_messages;
-                       if (msglist[a] > vbuf.v_lastseen) {
-                               ++new_messages;
-                       }
-               }
+       else if (!strcasecmp(towhere, "_BITBUCKET_")) {
+               safestrncpy(towhere, CtdlGetConfigStr("c_twitroom"), maxlen);
        }
-
-       if (msglist != NULL) phree(msglist);
-
-       if (CC->quickroom.QRflags & QR_MAILBOX)
-               rmailflag = 1;
-       else
-               rmailflag = 0;
-
-       if ((CC->quickroom.QRroomaide == CC->usersupp.usernum)
-           || (CC->usersupp.axlevel >= 6))
-               raideflag = 1;
-       else
-               raideflag = 0;
-
-       strcpy(truncated_roomname, CC->quickroom.QRname);
-       if (CC->quickroom.QRflags & QR_MAILBOX) {
-               strcpy(truncated_roomname, &truncated_roomname[11]);
+       else if (!strcasecmp(towhere, "_CALENDAR_")) {
+               safestrncpy(towhere, USERCALENDARROOM, maxlen);
        }
-
-       if (retmsgs != NULL) *retmsgs = total_messages;
-       if (retnew != NULL) *retnew = new_messages;
-       lprintf(9, "<%s> %d new of %d total messages\n",
-               CC->quickroom.QRname, new_messages, total_messages);
-
-       if (display_result)
-               cprintf("%d%c%s|%d|%d|%d|%d|%ld|%ld|%d|%d|%d|%d\n",
-                       OK, CtdlCheckExpress(),
-                       truncated_roomname,
-                       new_messages, total_messages,
-                       info, CC->quickroom.QRflags,
-                       CC->quickroom.QRhighest,
-                       vbuf.v_lastseen,
-                       rmailflag, raideflag, newmailcount,
-                       CC->quickroom.QRfloor);
-
-}
-
-
-/* 
- * cmd_goto()  -  goto a new room
- */
-void cmd_goto(char *gargs)
-{
-       struct quickroom QRscratch;
-       int c;
-       int ok = 0;
-       int ra;
-       char augmented_roomname[SIZ];
-       char towhere[SIZ];
-       char password[SIZ];
-
-       if (CtdlAccessCheck(ac_logged_in)) return;
-
-       extract(towhere, gargs, 0);
-       extract(password, gargs, 1);
-
-       getuser(&CC->usersupp, CC->curr_user);
-
-       if (!strcasecmp(towhere, "_BASEROOM_"))
-               strcpy(towhere, BASEROOM);
-
-       if (!strcasecmp(towhere, "_MAIL_"))
-               strcpy(towhere, MAILROOM);
-
-       if (!strcasecmp(towhere, "_BITBUCKET_"))
-               strcpy(towhere, config.c_twitroom);
-
-
-       /* First try a regular match */
-       c = getroom(&QRscratch, towhere);
-
-       /* Then try a mailbox name match */
-       if (c != 0) {
-               MailboxName(augmented_roomname, &CC->usersupp, towhere);
-               c = getroom(&QRscratch, augmented_roomname);
-               if (c == 0)
-                       strcpy(towhere, augmented_roomname);
+       else if (!strcasecmp(towhere, "_TASKS_")) {
+               safestrncpy(towhere, USERTASKSROOM, maxlen);
        }
-
-       /* And if the room was found... */
-       if (c == 0) {
-
-               /* let internal programs go directly to any room */
-               if (CC->internal_pgm) {
-                       usergoto(towhere, 1, NULL, NULL);
-                       return;
-               }
-
-               /* See if there is an existing user/room relationship */
-               ra = CtdlRoomAccess(&QRscratch, &CC->usersupp);
-
-               /* normal clients have to pass through security */
-               if (ra & UA_GOTOALLOWED)
-                       ok = 1;
-
-               if (ok == 1) {
-                       if ((QRscratch.QRflags & QR_PASSWORDED) &&
-                           ((ra & UA_KNOWN) == 0) &&
-                           (strcasecmp(QRscratch.QRpasswd, password)) &&
-                           (CC->usersupp.axlevel < 6)
-                           ) {
-                               cprintf("%d wrong or missing passwd\n",
-                                       ERROR + PASSWORD_REQUIRED);
-                               return;
-                       } else if ((QRscratch.QRflags & QR_PRIVATE) &&
-                                  ((QRscratch.QRflags & QR_PASSWORDED) == 0) &&
-                                  ((QRscratch.QRflags & QR_GUESSNAME) == 0) &&
-                                  ((ra & UA_KNOWN) == 0) &&
-                                  (CC->usersupp.axlevel < 6)
-                                  ) {
-                               goto NOPE;
-                       } else {
-                               usergoto(towhere, 1, NULL, NULL);
-                               return;
-                       }
-               }
+       else if (!strcasecmp(towhere, "_CONTACTS_")) {
+               safestrncpy(towhere, USERCONTACTSROOM, maxlen);
        }
-
-NOPE:  cprintf("%d room '%s' not found\n", ERROR + ROOM_NOT_FOUND, towhere);
-}
-
-
-void cmd_whok(void)
-{
-       struct usersupp temp;
-       struct cdbdata *cdbus;
-
-       cdb_begin_transaction();
-       getuser(&CC->usersupp, CC->curr_user);
-       if (CtdlAccessCheck(ac_room_aide)) return;
-
-       cprintf("%d Who knows room:\n", LISTING_FOLLOWS);
-       cdb_rewind(CDB_USERSUPP);
-       while (cdbus = cdb_next_item(CDB_USERSUPP), cdbus != NULL) {
-               memset(&temp, 0, sizeof temp);
-               memcpy(&temp, cdbus->ptr, sizeof temp);
-               cdb_free(cdbus);
-
-               if ((CC->quickroom.QRflags & QR_INUSE)
-                   && (CtdlRoomAccess(&CC->quickroom, &temp) & UA_KNOWN)
-                   )
-                       cprintf("%s\n", temp.fullname);
-       }
-       cdb_end_transaction();
-       cprintf("000\n");
-}
-
-
-/*
- * RDIR command for room directory
- */
-void cmd_rdir(void)
-{
-       char buf[SIZ];
-       char flnm[SIZ];
-       char comment[SIZ];
-       FILE *ls, *fd;
-       struct stat statbuf;
-
-       if (CtdlAccessCheck(ac_logged_in)) return;
-       
-       getroom(&CC->quickroom, CC->quickroom.QRname);
-       getuser(&CC->usersupp, CC->curr_user);
-
-       if ((CC->quickroom.QRflags & QR_DIRECTORY) == 0) {
-               cprintf("%d not here.\n", ERROR + NOT_HERE);
-               return;
-       }
-       if (((CC->quickroom.QRflags & QR_VISDIR) == 0)
-           && (CC->usersupp.axlevel < 6)
-           && (CC->usersupp.usernum != CC->quickroom.QRroomaide)) {
-               cprintf("%d not here.\n", ERROR + HIGHER_ACCESS_REQUIRED);
-               return;
-       }
-       cprintf("%d %s|%s/files/%s\n",
-       LISTING_FOLLOWS, config.c_fqdn, BBSDIR, CC->quickroom.QRdirname);
-
-        sprintf(buf, "ls %s/files/%s  >%s 2> /dev/null",
-                BBSDIR, CC->quickroom.QRdirname, CC->temp);
-        system(buf);
-
-       sprintf(buf, "%s/files/%s/filedir", BBSDIR, CC->quickroom.QRdirname);
-       fd = fopen(buf, "r");
-       if (fd == NULL)
-               fd = fopen("/dev/null", "r");
-
-       ls = fopen(CC->temp, "r");
-       while (fgets(flnm, sizeof flnm, ls) != NULL) {
-               flnm[strlen(flnm) - 1] = 0;
-               if (strcasecmp(flnm, "filedir")) {
-                       sprintf(buf, "%s/files/%s/%s",
-                               BBSDIR, CC->quickroom.QRdirname, flnm);
-                       stat(buf, &statbuf);
-                       strcpy(comment, "");
-                       fseek(fd, 0L, 0);
-                       while ((fgets(buf, sizeof buf, fd) != NULL)
-                              && (strlen(comment) == 0)) {
-                               buf[strlen(buf) - 1] = 0;
-                               if ((!strncasecmp(buf, flnm, strlen(flnm)))
-                                   && (buf[strlen(flnm)] == ' '))
-                                       safestrncpy(comment,
-                                           &buf[strlen(flnm) + 1],
-                                           sizeof comment);
-                       }
-                       cprintf("%s|%ld|%s\n", flnm, statbuf.st_size, comment);
-               }
+       else if (!strcasecmp(towhere, "_NOTES_")) {
+               safestrncpy(towhere, USERNOTESROOM, maxlen);
        }
-       fclose(ls);
-       fclose(fd);
-       unlink(CC->temp);
-
-       cprintf("000\n");
-}
-
-/*
- * get room parameters (aide or room aide command)
- */
-void cmd_getr(void)
-{
-       if (CtdlAccessCheck(ac_room_aide)) return;
-
-       /********
-       if (is_noneditable(&CC->quickroom)) {
-               cprintf("%d Can't edit this room.\n", ERROR + NOT_HERE);
-               return;
-       }
-       ************/
-
-       getroom(&CC->quickroom, CC->quickroom.QRname);
-       cprintf("%d%c%s|%s|%s|%d|%d|%d\n",
-               OK, CtdlCheckExpress(),
-               CC->quickroom.QRname,
-               ((CC->quickroom.QRflags & QR_PASSWORDED) ? CC->quickroom.QRpasswd : ""),
-               ((CC->quickroom.QRflags & QR_DIRECTORY) ? CC->quickroom.QRdirname : ""),
-               CC->quickroom.QRflags,
-               (int) CC->quickroom.QRfloor,
-               (int) CC->quickroom.QRorder);
 }
 
 
 /*
- * set room parameters (aide or room aide command)
+ * Back end function to rename a room.
+ * You can also specify which floor to move the room to, or specify -1 to
+ * keep the room on the same floor it was on.
+ *
+ * If you are renaming a mailbox room, you must supply the namespace prefix
+ * in *at least* the old name!
  */
-void cmd_setr(char *args)
-{
-       char buf[SIZ];
+int CtdlRenameRoom(char *old_name, char *new_name, int new_floor) {
+       int old_floor = 0;
+       struct ctdlroom qrbuf;
+       struct ctdlroom qrtmp;
+       int ret = 0;
        struct floor *fl;
        struct floor flbuf;
-       char old_name[ROOMNAMELEN];
-       int old_floor;
-       int new_order = 0;
-       int ne = 0;
-
-       if (CtdlAccessCheck(ac_room_aide)) return;
+       long owner = 0L;
+       char actual_old_name[ROOMNAMELEN];
 
-       if (is_noneditable(&CC->quickroom)) {
-               ne = 1;
-       }
+       syslog(LOG_DEBUG, "room_ops: CtdlRenameRoom(%s, %s, %d)", old_name, new_name, new_floor);
 
-       /***
-               cprintf("%d Can't edit this room.\n", ERROR + NOT_HERE);
-               return;
+       if (new_floor >= 0) {
+               fl = CtdlGetCachedFloor(new_floor);
+               if ((fl->f_flags & F_INUSE) == 0) {
+                       return(crr_invalid_floor);
+               }
        }
-       ***/
 
+       begin_critical_section(S_ROOMS);
 
-       if (num_parms(args) >= 6) {
-               fl = cgetfloor(extract_int(args, 5));
-               if ((fl->f_flags & F_INUSE) == 0) {
-                       cprintf("%d Invalid floor number.\n",
-                               ERROR + INVALID_FLOOR_OPERATION);
-                       return;
-               }
+       if ( (CtdlGetRoom(&qrtmp, new_name) == 0) && (strcasecmp(new_name, old_name)) ) {
+               ret = crr_already_exists;
        }
-       if (num_parms(args) >= 7) {
-               new_order = extract_int(args, 6);
-               if (new_order < 1)
-                       new_order = 1;
-               if (new_order > 127)
-                       new_order = 127;
-       }
-       lgetroom(&CC->quickroom, CC->quickroom.QRname);
-
-       /* Non-editable base rooms can't be renamed */
-       strcpy(old_name, CC->quickroom.QRname);
-       if (!ne) {
-               extract(buf, args, 0);
-               buf[ROOMNAMELEN] = 0;
-               safestrncpy(CC->quickroom.QRname, buf,
-                       sizeof CC->quickroom.QRname);
-       }
-
-       extract(buf, args, 1);
-       buf[10] = 0;
-       safestrncpy(CC->quickroom.QRpasswd, buf, sizeof CC->quickroom.QRpasswd);
-       extract(buf, args, 2);
-       buf[15] = 0;
-       safestrncpy(CC->quickroom.QRdirname, buf,
-               sizeof CC->quickroom.QRdirname);
-       CC->quickroom.QRflags = (extract_int(args, 3) | QR_INUSE);
-       if (num_parms(args) >= 7)
-               CC->quickroom.QRorder = (char) new_order;
-
-       /* Clean up a client boo-boo: if the client set the room to
-        * guess-name or passworded, ensure that the private flag is
-        * also set.
-        */
-       if ((CC->quickroom.QRflags & QR_GUESSNAME)
-           || (CC->quickroom.QRflags & QR_PASSWORDED))
-               CC->quickroom.QRflags |= QR_PRIVATE;
 
-       /* Kick everyone out if the client requested it (by changing the
-        * room's generation number)
-        */
-       if (extract_int(args, 4)) {
-               time(&CC->quickroom.QRgen);
+       else if (CtdlGetRoom(&qrbuf, old_name) != 0) {
+               ret = crr_room_not_found;
        }
-       old_floor = CC->quickroom.QRfloor;
-       if (num_parms(args) >= 6) {
-               CC->quickroom.QRfloor = extract_int(args, 5);
+
+       else if ( (CC->user.axlevel < AxAideU) && (!CC->internal_pgm)
+                 && (CC->user.usernum != qrbuf.QRroomaide)
+                 && ( (((qrbuf.QRflags & QR_MAILBOX) == 0) || (atol(qrbuf.QRname) != CC->user.usernum))) )  {
+               ret = crr_access_denied;
        }
-       /* Write the room record back to disk */
-       lputroom(&CC->quickroom);
 
-       /* If the room name changed, then there are now two room records,
-        * so we have to delete the old one.
-        */
-       if (strcasecmp(CC->quickroom.QRname, old_name)) {
-               b_deleteroom(old_name);
-       }
-       /* adjust the floor reference counts */
-       lgetfloor(&flbuf, old_floor);
-       --flbuf.f_ref_count;
-       lputfloor(&flbuf, old_floor);
-       lgetfloor(&flbuf, CC->quickroom.QRfloor);
-       ++flbuf.f_ref_count;
-       lputfloor(&flbuf, CC->quickroom.QRfloor);
-
-       /* create a room directory if necessary */
-       if (CC->quickroom.QRflags & QR_DIRECTORY) {
-               sprintf(buf,
-                   "mkdir ./files/%s </dev/null >/dev/null 2>/dev/null",
-                       CC->quickroom.QRdirname);
-               system(buf);
-       }
-       sprintf(buf, "%s> edited by %s\n", CC->quickroom.QRname, CC->curr_user);
-       aide_message(buf);
-       cprintf("%d Ok\n", OK);
-}
+       else if (CtdlIsNonEditable(&qrbuf)) {
+               ret = crr_noneditable;
+       }
 
+       else {
+               /* Rename it */
+               safestrncpy(actual_old_name, qrbuf.QRname, sizeof actual_old_name);
+               if (qrbuf.QRflags & QR_MAILBOX) {
+                       owner = atol(qrbuf.QRname);
+               }
+               if ( (owner > 0L) && (atol(new_name) == 0L) ) {
+                       snprintf(qrbuf.QRname, sizeof(qrbuf.QRname),
+                                       "%010ld.%s", owner, new_name);
+               }
+               else {
+                       safestrncpy(qrbuf.QRname, new_name,
+                                               sizeof(qrbuf.QRname));
+               }
 
+               /* Reject change of floor for baseroom/aideroom */
+               if (!strncasecmp(old_name, CtdlGetConfigStr("c_baseroom"), ROOMNAMELEN) ||
+                   !strncasecmp(old_name, CtdlGetConfigStr("c_aideroom"), ROOMNAMELEN))
+               {
+                       new_floor = 0;
+               }
 
-/* 
- * get the name of the room aide for this room
- */
-void cmd_geta(void)
-{
-       struct usersupp usbuf;
+               /* Take care of floor stuff */
+               old_floor = qrbuf.QRfloor;
+               if (new_floor < 0) {
+                       new_floor = old_floor;
+               }
+               qrbuf.QRfloor = new_floor;
+               CtdlPutRoom(&qrbuf);
 
-       if (CtdlAccessCheck(ac_logged_in)) return;
+               begin_critical_section(S_CONFIG);
+       
+               /* If baseroom/aideroom name changes, update config */
+               if (!strncasecmp(old_name, CtdlGetConfigStr("c_baseroom"), ROOMNAMELEN)) {
+                       CtdlSetConfigStr("c_baseroom", new_name);
+               }
+               if (!strncasecmp(old_name, CtdlGetConfigStr("c_aideroom"), ROOMNAMELEN)) {
+                       CtdlSetConfigStr("c_aideroom", new_name);
+               }
+       
+               end_critical_section(S_CONFIG);
+       
+               /* If the room name changed, then there are now two room
+                * records, so we have to delete the old one.
+                */
+               if (strcasecmp(new_name, old_name)) {
+                       b_deleteroom(actual_old_name);
+               }
 
-       if (is_noneditable(&CC->quickroom)) {
-               cprintf("%d Can't edit this room.\n", ERROR + NOT_HERE);
-               return;
-       }
-       if (getuserbynumber(&usbuf, CC->quickroom.QRroomaide) == 0) {
-               cprintf("%d %s\n", OK, usbuf.fullname);
-       } else {
-               cprintf("%d \n", OK);
+               ret = crr_ok;
        }
-}
-
 
-/* 
- * set the room aide for this room
- */
-void cmd_seta(char *new_ra)
-{
-       struct usersupp usbuf;
-       long newu;
-       char buf[SIZ];
-       int post_notice;
+       end_critical_section(S_ROOMS);
 
-       if (CtdlAccessCheck(ac_room_aide)) return;
-
-       if (getuser(&usbuf, new_ra) != 0) {
-               newu = (-1L);
-       } else {
-               newu = usbuf.usernum;
-       }
-
-       lgetroom(&CC->quickroom, CC->quickroom.QRname);
-       post_notice = 0;
-       if (CC->quickroom.QRroomaide != newu) {
-               post_notice = 1;
+       /* Adjust the floor reference counts if necessary */
+       if (new_floor != old_floor) {
+               lgetfloor(&flbuf, old_floor);
+               --flbuf.f_ref_count;
+               lputfloor(&flbuf, old_floor);
+               syslog(LOG_DEBUG, "room_ops: reference count for floor %d is now %d", old_floor, flbuf.f_ref_count);
+               lgetfloor(&flbuf, new_floor);
+               ++flbuf.f_ref_count;
+               lputfloor(&flbuf, new_floor);
+               syslog(LOG_DEBUG, "room_ops: reference count for floor %d is now %d", new_floor, flbuf.f_ref_count);
        }
-       CC->quickroom.QRroomaide = newu;
-       lputroom(&CC->quickroom);
 
-       /*
-        * We have to post the change notice _after_ writing changes to 
-        * the room table, otherwise it would deadlock!
-        */
-       if (post_notice == 1) {
-               sprintf(buf, "%s is now room aide for %s>\n",
-                       usbuf.fullname, CC->quickroom.QRname);
-               aide_message(buf);
-       }
-       cprintf("%d Ok\n", OK);
+       /* ...and everybody say "YATTA!" */     
+       return(ret);
 }
 
+
 /*
- * Generate an associated file name for a room
+ * Asynchronously schedule a room for deletion.  By placing the room into an invalid private namespace,
+ * the room will appear deleted to the user(s), but the session doesn't need to block while waiting for
+ * database operations to complete.  Instead, the room gets purged when THE DREADED AUTO-PURGER makes
+ * its next run.  Aren't we so clever?!!
  */
-void assoc_file_name(char *buf, struct quickroom *qrbuf, char *prefix)
-{
-       sprintf(buf, "./%s/%ld", prefix, qrbuf->QRnumber);
-}
+void CtdlScheduleRoomForDeletion(struct ctdlroom *qrbuf) {
+       char old_name[ROOMNAMELEN];
+       static int seq = 0;
 
-/* 
- * retrieve info file for this room
- */
-void cmd_rinf(void)
-{
-       char filename[128];
-       char buf[SIZ];
-       FILE *info_fp;
+       syslog(LOG_NOTICE, "room_ops: scheduling room <%s> for deletion", qrbuf->QRname);
 
-       assoc_file_name(filename, &CC->quickroom, "info");
-       info_fp = fopen(filename, "r");
+       safestrncpy(old_name, qrbuf->QRname, sizeof old_name);
+       CtdlGetRoom(qrbuf, qrbuf->QRname);
 
-       if (info_fp == NULL) {
-               cprintf("%d No info file.\n", ERROR);
-               return;
-       }
-       cprintf("%d Info:\n", LISTING_FOLLOWS);
-       while (fgets(buf, sizeof buf, info_fp) != NULL) {
-               if (strlen(buf) > 0)
-                       buf[strlen(buf) - 1] = 0;
-               cprintf("%s\n", buf);
-       }
-       cprintf("000\n");
-       fclose(info_fp);
+       /* Turn the room into a private mailbox owned by a user who doesn't
+        * exist.  This will immediately make the room invisible to everyone,
+        * and qualify the room for purging.
+        */
+       snprintf(qrbuf->QRname, sizeof qrbuf->QRname, "9999999999.%08lx.%04d.%s",
+               time(NULL),
+               ++seq,
+               old_name
+       );
+       qrbuf->QRflags |= QR_MAILBOX;
+       time(&qrbuf->QRgen);    /* Use a timestamp as the new generation number  */
+       CtdlPutRoom(qrbuf);
+       b_deleteroom(old_name);
 }
 
+
 /*
  * Back end processing to delete a room and everything associated with it
+ * (This one is synchronous and should only get called by THE DREADED
+ * AUTO-PURGER in serv_expire.c.  All user-facing code should call
+ * the asynchronous schedule_room_for_deletion() instead.)
  */
-void delete_room(struct quickroom *qrbuf)
-{
+void CtdlDeleteRoom(struct ctdlroom *qrbuf) {
        struct floor flbuf;
-       char filename[100];
-
-       lprintf(9, "Deleting room <%s>\n", qrbuf->QRname);
-
-       /* Delete the info file */
-       assoc_file_name(filename, qrbuf, "info");
-       unlink(filename);
+       char configdbkeyname[25];
 
-       /* Delete the image file */
-       assoc_file_name(filename, qrbuf, "images");
-       unlink(filename);
+       syslog(LOG_NOTICE, "room_ops: deleting room <%s>", qrbuf->QRname);
 
-       /* Delete the room's network config file */
-       assoc_file_name(filename, qrbuf, "netconfigs");
-       unlink(filename);
+       /* Delete the room's network configdb entry */
+       netcfg_keyname(configdbkeyname, qrbuf->QRnumber);
+       CtdlDelConfig(configdbkeyname);
 
        /* Delete the messages in the room
-        * (Careful: this opens an S_QUICKROOM critical section!)
+        * (Careful: this opens an S_ROOMS critical section!)
         */
-       CtdlDeleteMessages(qrbuf->QRname, 0L, "");
+       CtdlDeleteMessages(qrbuf->QRname, NULL, 0, "");
 
        /* Flag the room record as not in use */
-       lgetroom(qrbuf, qrbuf->QRname);
+       CtdlGetRoomLock(qrbuf, qrbuf->QRname);
        qrbuf->QRflags = 0;
-       lputroom(qrbuf);
+       CtdlPutRoomLock(qrbuf);
 
        /* then decrement the reference count for the floor */
        lgetfloor(&flbuf, (int) (qrbuf->QRfloor));
@@ -1190,17 +1093,16 @@ void delete_room(struct quickroom *qrbuf)
 }
 
 
-
 /*
  * Check access control for deleting a room
  */
-int CtdlDoIHavePermissionToDeleteThisRoom(struct quickroom *qr) {
+int CtdlDoIHavePermissionToDeleteThisRoom(struct ctdlroom *qr) {
 
        if ((!(CC->logged_in)) && (!(CC->internal_pgm))) {
                return(0);
        }
 
-       if (is_noneditable(qr)) {
+       if (CtdlIsNonEditable(qr)) {
                return(0);
        }
 
@@ -1211,84 +1113,50 @@ int CtdlDoIHavePermissionToDeleteThisRoom(struct quickroom *qr) {
 
                if (strlen(qr->QRname) < 12) return(0); /* bad name */
 
-               if (atol(qr->QRname) != CC->usersupp.usernum) {
+               if (atol(qr->QRname) != CC->user.usernum) {
                        return(0);      /* not my room */
                }
 
                /* Can't delete your Mail> room */
-               if (!strcasecmp(&qr->QRname[12], MAILROOM)) return(0);
+               if (!strcasecmp(&qr->QRname[11], MAILROOM)) return(0);
 
                /* Otherwise it's ok */
                return(1);
        }
 
        /*
-        * For normal rooms, just check for aide or room aide status.
+        * For normal rooms, just check for admin or room admin status.
         */
-       else {
-               return(is_room_aide());
-       }
-
-       /* Should never get to this point, but to keep the compiler quiet... */
-       return(0);
-}
-
-/*
- * aide command: kill the current room
- */
-void cmd_kill(char *argbuf)
-{
-       char aaa[100];
-       char deleted_room_name[ROOMNAMELEN];
-       int kill_ok;
-
-       kill_ok = extract_int(argbuf, 0);
-
-       if (CtdlDoIHavePermissionToDeleteThisRoom(&CC->quickroom) == 0) {
-               cprintf("%d Can't delete this room.\n", ERROR + NOT_HERE);
-               return;
-       }
-       if (kill_ok) {
-               strcpy(deleted_room_name, CC->quickroom.QRname);
-               delete_room(&CC->quickroom);    /* Do the dirty work */
-               usergoto(BASEROOM, 0, NULL, NULL); /* Return to the Lobby */
-
-               /* tell the world what we did */
-               sprintf(aaa, "%s> killed by %s\n",
-                       deleted_room_name, CC->curr_user);
-               aide_message(aaa);
-               cprintf("%d '%s' deleted.\n", OK, deleted_room_name);
-       } else {
-               cprintf("%d ok to delete.\n", OK);
-       }
+       return(is_room_aide());
 }
 
 
 /*
  * Internal code to create a new room (returns room flags)
  *
- * Room types:  0=public, 1=guessname, 2=passworded, 3=inv-only,
+ * Room types:  0=public, 1=hidden, 2=passworded, 3=invitation-only,
  *              4=mailbox, 5=mailbox, but caller supplies namespace
  */
-unsigned create_room(char *new_room_name,
+unsigned CtdlCreateRoom(char *new_room_name,
                     int new_room_type,
                     char *new_room_pass,
                     int new_room_floor,
-                    int really_create)
+                    int really_create,
+                    int avoid_access,
+                    int new_room_view)
 {
-
-       struct quickroom qrbuf;
+       struct ctdlroom qrbuf;
        struct floor flbuf;
-       struct visit vbuf;
+       visit vbuf;
 
-       lprintf(9, "create_room(%s)\n", new_room_name);
-       if (getroom(&qrbuf, new_room_name) == 0) {
-               lprintf(9, "%s already exists.\n", new_room_name);
-               return (0);     /* already exists */
-       }
+       syslog(LOG_DEBUG, "room_ops: CtdlCreateRoom(name=%s, type=%d, view=%d)", new_room_name, new_room_type, new_room_view);
 
+       if (CtdlGetRoom(&qrbuf, new_room_name) == 0) {
+               syslog(LOG_DEBUG, "room_ops: cannot create room <%s> - already exists", new_room_name);
+               return(0);
+       }
 
-       memset(&qrbuf, 0, sizeof(struct quickroom));
+       memset(&qrbuf, 0, sizeof(struct ctdlroom));
        safestrncpy(qrbuf.QRpasswd, new_room_pass, sizeof qrbuf.QRpasswd);
        qrbuf.QRflags = QR_INUSE;
        if (new_room_type > 0)
@@ -1297,26 +1165,36 @@ unsigned create_room(char *new_room_name,
                qrbuf.QRflags = (qrbuf.QRflags | QR_GUESSNAME);
        if (new_room_type == 2)
                qrbuf.QRflags = (qrbuf.QRflags | QR_PASSWORDED);
-       if ( (new_room_type == 4) || (new_room_type == 5) )
+       if ( (new_room_type == 4) || (new_room_type == 5) ) {
                qrbuf.QRflags = (qrbuf.QRflags | QR_MAILBOX);
+               /* qrbuf.QRflags2 |= QR2_SUBJECTREQ; */
+       }
 
        /* If the user is requesting a personal room, set up the room
         * name accordingly (prepend the user number)
         */
        if (new_room_type == 4) {
-               MailboxName(qrbuf.QRname, &CC->usersupp, new_room_name);
+               CtdlMailboxName(qrbuf.QRname, sizeof qrbuf.QRname, &CC->user, new_room_name);
        }
        else {
                safestrncpy(qrbuf.QRname, new_room_name, sizeof qrbuf.QRname);
        }
 
        /* If the room is private, and the system administrator has elected
-        * to automatically grant room aide privileges, do so now; otherwise,
-        * set the room aide to undefined.
+        * to automatically grant room admin privileges, do so now.
         */
        if ((qrbuf.QRflags & QR_PRIVATE) && (CREATAIDE == 1)) {
-               qrbuf.QRroomaide = CC->usersupp.usernum;
-       } else {
+               qrbuf.QRroomaide = CC->user.usernum;
+       }
+       /* Blog owners automatically become room admins of their blogs.
+        * (In the future we will offer a site-wide configuration setting to suppress this behavior.)
+        */
+       else if (new_room_view == VIEW_BLOG) {
+               qrbuf.QRroomaide = CC->user.usernum;
+       }
+       /* Otherwise, set the room admin to undefined.
+        */
+       else {
                qrbuf.QRroomaide = (-1L);
        }
 
@@ -1326,331 +1204,30 @@ unsigned create_room(char *new_room_name,
         */
        if (!really_create) return (qrbuf.QRflags);
 
-       /* cdb_begin_transaction();  commented out because a transaction
-          is already open when creating __CtdlSMTPspoolout__ while
-          initializing serv_smtp.c
-        */
-
        qrbuf.QRnumber = get_new_room_number();
        qrbuf.QRhighest = 0L;   /* No messages in this room yet */
        time(&qrbuf.QRgen);     /* Use a timestamp as the generation number */
        qrbuf.QRfloor = new_room_floor;
+       qrbuf.QRdefaultview = new_room_view;
 
        /* save what we just did... */
-       putroom(&qrbuf);
+       CtdlPutRoom(&qrbuf);
 
        /* bump the reference count on whatever floor the room is on */
        lgetfloor(&flbuf, (int) qrbuf.QRfloor);
        flbuf.f_ref_count = flbuf.f_ref_count + 1;
        lputfloor(&flbuf, (int) qrbuf.QRfloor);
 
-       /* be sure not to kick the creator out of the room! */
-       lgetuser(&CC->usersupp, CC->curr_user);
-       CtdlGetRelationship(&vbuf, &CC->usersupp, &qrbuf);
-       vbuf.v_flags = vbuf.v_flags & ~V_FORGET & ~V_LOCKOUT;
-       vbuf.v_flags = vbuf.v_flags | V_ACCESS;
-       CtdlSetRelationship(&vbuf, &CC->usersupp, &qrbuf);
-       lputuser(&CC->usersupp);
+       /* Grant the creator access to the room unless the avoid_access
+        * parameter was specified.
+        */
+       if ( (CC->logged_in) && (avoid_access == 0) ) {
+               CtdlGetRelationship(&vbuf, &CC->user, &qrbuf);
+               vbuf.v_flags = vbuf.v_flags & ~V_FORGET & ~V_LOCKOUT;
+               vbuf.v_flags = vbuf.v_flags | V_ACCESS;
+               CtdlSetRelationship(&vbuf, &CC->user, &qrbuf);
+       }
 
        /* resume our happy day */
-       /* cdb_end_transaction(); */
        return (qrbuf.QRflags);
 }
-
-
-/*
- * create a new room
- */
-void cmd_cre8(char *args)
-{
-       int cre8_ok;
-       char new_room_name[SIZ];
-       int new_room_type;
-       char new_room_pass[SIZ];
-       int new_room_floor;
-       char aaa[SIZ];
-       unsigned newflags;
-       struct quickroom qrbuf;
-       struct floor *fl;
-
-       cre8_ok = extract_int(args, 0);
-       extract(new_room_name, args, 1);
-       new_room_name[ROOMNAMELEN - 1] = 0;
-       new_room_type = extract_int(args, 2);
-       extract(new_room_pass, args, 3);
-       new_room_pass[9] = 0;
-       new_room_floor = 0;
-
-       if ((strlen(new_room_name) == 0) && (cre8_ok == 1)) {
-               cprintf("%d Invalid room name.\n", ERROR);
-               return;
-       }
-
-       if (!strcasecmp(new_room_name, MAILROOM)) {
-               cprintf("%d '%s' already exists.\n",
-                       ERROR + ALREADY_EXISTS, new_room_name);
-               return;
-       }
-
-       if (num_parms(args) >= 5) {
-               fl = cgetfloor(extract_int(args, 4));
-               if ((fl->f_flags & F_INUSE) == 0) {
-                       cprintf("%d Invalid floor number.\n",
-                               ERROR + INVALID_FLOOR_OPERATION);
-                       return;
-               } else {
-                       new_room_floor = extract_int(args, 4);
-               }
-       }
-
-       if (CtdlAccessCheck(ac_logged_in)) return;
-
-       if (CC->usersupp.axlevel < config.c_createax) {
-               cprintf("%d You need higher access to create rooms.\n",
-                       ERROR + HIGHER_ACCESS_REQUIRED);
-               return;
-       }
-
-       if ((strlen(new_room_name) == 0) && (cre8_ok == 0)) {
-               cprintf("%d Ok to create rooms.\n", OK);
-               return;
-       }
-
-       if ((new_room_type < 0) || (new_room_type > 4)) {
-               cprintf("%d Invalid room type.\n", ERROR);
-               return;
-       }
-
-       /* Check to make sure the requested room name doesn't already exist */
-       newflags = create_room(new_room_name,
-                          new_room_type, new_room_pass, new_room_floor, 0);
-       if (newflags == 0) {
-               cprintf("%d '%s' already exists.\n",
-                       ERROR + ALREADY_EXISTS, qrbuf.QRname);
-               return;
-       }
-
-       if (cre8_ok == 0) {
-               cprintf("%d OK to create '%s'\n", OK, new_room_name);
-               return;
-       }
-
-       /* If we reach this point, the room needs to be created. */
-
-       newflags = create_room(new_room_name,
-                          new_room_type, new_room_pass, new_room_floor, 1);
-
-       /* post a message in Aide> describing the new room */
-       safestrncpy(aaa, new_room_name, sizeof aaa);
-       strcat(aaa, "> created by ");
-       strcat(aaa, CC->usersupp.fullname);
-       if (newflags & QR_MAILBOX)
-               strcat(aaa, " [personal]");
-       else if (newflags & QR_PRIVATE)
-               strcat(aaa, " [private]");
-       if (newflags & QR_GUESSNAME)
-               strcat(aaa, "[guessname] ");
-       if (newflags & QR_PASSWORDED) {
-               strcat(aaa, "\n Password: ");
-               strcat(aaa, new_room_pass);
-       }
-       strcat(aaa, "\n");
-       aide_message(aaa);
-
-       cprintf("%d '%s' has been created.\n", OK, qrbuf.QRname);
-}
-
-
-
-void cmd_einf(char *ok)
-{                              /* enter info file for current room */
-       FILE *fp;
-       char infofilename[SIZ];
-       char buf[SIZ];
-
-       if (CtdlAccessCheck(ac_room_aide)) return;
-
-       if (atoi(ok) == 0) {
-               cprintf("%d Ok.\n", OK);
-               return;
-       }
-       assoc_file_name(infofilename, &CC->quickroom, "info");
-       lprintf(9, "opening\n");
-       fp = fopen(infofilename, "w");
-       lprintf(9, "checking\n");
-       if (fp == NULL) {
-               cprintf("%d Cannot open %s: %s\n",
-                 ERROR + INTERNAL_ERROR, infofilename, strerror(errno));
-               return;
-       }
-       cprintf("%d Send info...\n", SEND_LISTING);
-
-       do {
-               client_gets(buf);
-               if (strcmp(buf, "000"))
-                       fprintf(fp, "%s\n", buf);
-       } while (strcmp(buf, "000"));
-       fclose(fp);
-
-       /* now update the room index so people will see our new info */
-       lgetroom(&CC->quickroom, CC->quickroom.QRname);         /* lock so no one steps on us */
-       CC->quickroom.QRinfo = CC->quickroom.QRhighest + 1L;
-       lputroom(&CC->quickroom);
-}
-
-
-/* 
- * cmd_lflr()   -  List all known floors
- */
-void cmd_lflr(void)
-{
-       int a;
-       struct floor flbuf;
-
-       if (CtdlAccessCheck(ac_logged_in)) return;
-
-       cprintf("%d Known floors:\n", LISTING_FOLLOWS);
-
-       for (a = 0; a < MAXFLOORS; ++a) {
-               getfloor(&flbuf, a);
-               if (flbuf.f_flags & F_INUSE) {
-                       cprintf("%d|%s|%d\n",
-                               a,
-                               flbuf.f_name,
-                               flbuf.f_ref_count);
-               }
-       }
-       cprintf("000\n");
-}
-
-
-
-/*
- * create a new floor
- */
-void cmd_cflr(char *argbuf)
-{
-       char new_floor_name[SIZ];
-       struct floor flbuf;
-       int cflr_ok;
-       int free_slot = (-1);
-       int a;
-
-       extract(new_floor_name, argbuf, 0);
-       cflr_ok = extract_int(argbuf, 1);
-
-
-       if (CtdlAccessCheck(ac_aide)) return;
-
-       for (a = 0; a < MAXFLOORS; ++a) {
-               getfloor(&flbuf, a);
-
-               /* note any free slots while we're scanning... */
-               if (((flbuf.f_flags & F_INUSE) == 0)
-                   && (free_slot < 0))
-                       free_slot = a;
-
-               /* check to see if it already exists */
-               if ((!strcasecmp(flbuf.f_name, new_floor_name))
-                   && (flbuf.f_flags & F_INUSE)) {
-                       cprintf("%d Floor '%s' already exists.\n",
-                               ERROR + ALREADY_EXISTS,
-                               flbuf.f_name);
-                       return;
-               }
-       }
-
-       if (free_slot < 0) {
-               cprintf("%d There is no space available for a new floor.\n",
-                       ERROR + INVALID_FLOOR_OPERATION);
-               return;
-       }
-       if (cflr_ok == 0) {
-               cprintf("%d ok to create...\n", OK);
-               return;
-       }
-       lgetfloor(&flbuf, free_slot);
-       flbuf.f_flags = F_INUSE;
-       flbuf.f_ref_count = 0;
-       safestrncpy(flbuf.f_name, new_floor_name, sizeof flbuf.f_name);
-       lputfloor(&flbuf, free_slot);
-       cprintf("%d %d\n", OK, free_slot);
-}
-
-
-
-/*
- * delete a floor
- */
-void cmd_kflr(char *argbuf)
-{
-       struct floor flbuf;
-       int floor_to_delete;
-       int kflr_ok;
-       int delete_ok;
-
-       floor_to_delete = extract_int(argbuf, 0);
-       kflr_ok = extract_int(argbuf, 1);
-
-       if (CtdlAccessCheck(ac_aide)) return;
-
-       lgetfloor(&flbuf, floor_to_delete);
-
-       delete_ok = 1;
-       if ((flbuf.f_flags & F_INUSE) == 0) {
-               cprintf("%d Floor %d not in use.\n",
-                       ERROR + INVALID_FLOOR_OPERATION, floor_to_delete);
-               delete_ok = 0;
-       } else {
-               if (flbuf.f_ref_count != 0) {
-                       cprintf("%d Cannot delete; floor contains %d rooms.\n",
-                               ERROR + INVALID_FLOOR_OPERATION,
-                               flbuf.f_ref_count);
-                       delete_ok = 0;
-               } else {
-                       if (kflr_ok == 1) {
-                               cprintf("%d Ok\n", OK);
-                       } else {
-                               cprintf("%d Ok to delete...\n", OK);
-                       }
-
-               }
-
-       }
-
-       if ((delete_ok == 1) && (kflr_ok == 1))
-               flbuf.f_flags = 0;
-       lputfloor(&flbuf, floor_to_delete);
-}
-
-/*
- * edit a floor
- */
-void cmd_eflr(char *argbuf)
-{
-       struct floor flbuf;
-       int floor_num;
-       int np;
-
-       np = num_parms(argbuf);
-       if (np < 1) {
-               cprintf("%d Usage error.\n", ERROR);
-               return;
-       }
-
-       if (CtdlAccessCheck(ac_aide)) return;
-
-       floor_num = extract_int(argbuf, 0);
-       lgetfloor(&flbuf, floor_num);
-       if ((flbuf.f_flags & F_INUSE) == 0) {
-               lputfloor(&flbuf, floor_num);
-               cprintf("%d Floor %d is not in use.\n",
-                       ERROR + INVALID_FLOOR_OPERATION, floor_num);
-               return;
-       }
-       if (np >= 2)
-               extract(flbuf.f_name, argbuf, 1);
-       lputfloor(&flbuf, floor_num);
-
-       cprintf("%d Ok\n", OK);
-}