view_mail.js: set variables to local scope

diff --git a/webcit-ng/static/js/view_mail.js b/webcit-ng/static/js/view_mail.js
index 33beeec36786daf779a89b5da11fc36eab9263ef..edf6c7963a87d57785b67805bbade3a311ce4d29 100644 (file)
--- a/webcit-ng/static/js/view_mail.js
+++ b/webcit-ng/static/js/view_mail.js
@@ -49,8 +49,8 @@ mail_delete_func = async(table, row) => {
 
 // Delete the selected messages (can be activated by mouse click or keypress)
 function mail_delete_selected() {
-       var table = document.getElementById("ctdl-onscreen-mailbox");
-       var i, row;
+       let table = document.getElementById("ctdl-onscreen-mailbox");
+       let i, row;
        for (i=0; row=table.rows[i]; ++i) {
                if (row.classList.contains("ctdl-mail-selected")) {
                        mail_delete_func(table, row);
@@ -82,28 +82,26 @@ function mail_keypress(event) {
 
 // Handler function for dragging email messages to other folders
 function mail_dragstart(event) {
-       var i;
-       var count = 0;
-       var table = document.getElementById("ctdl-onscreen-mailbox");
-       var messages_being_dragged = [] ;
+       let i;
+       let count = 0;
+       let table = document.getElementById("ctdl-onscreen-mailbox");
+       let messages_being_dragged = [] ;
 
        if (event.target.classList.contains("ctdl-mail-selected")) {
                // The row being dragged IS selected.  See if any OTHER rows are selected, and they will come along for the ride.
                for (i=1; row=table.rows[i]; ++i) {
                        if (row.classList.contains("ctdl-mail-selected")) {
                                count = count + 1;
-                               messages_being_dragged.push(row.id);
+                               messages_being_dragged.push(row.id);    // Tell the clipboard what's being moved.
                        }
                }
        }
        else {
                // The row being dragged is NOT selected.  It will be dragged on its own, ignoring the selected rows.
                count = 1;
-               messages_being_dragged.push(event.target.id);
+               messages_being_dragged.push(event.target.id);           // Tell the clipboard what's being moved.
        }
 
-       // FIXME tell the clipboard what's being moved.
-
        // Set the custom drag image to an envelope + number of messages being dragged
        d = document.getElementById("ctdl_draggo");
        d.innerHTML = "<font size='+2'><i class='fa fa-envelope' style='color: red'></i> " + count + "</font>"
@@ -287,7 +285,7 @@ function click_message(event, msgnum) {
 
 // render one row in the mailbox table (this could be called from one of several places)
 function mail_render_row(msg, is_selected) {
-       row     = "<tr "
+       let row = "<tr "
                + "id=\"ctdl-msgsum-" + msg["msgnum"] + "\" "
                + (is_selected ? "class=\"ctdl-mail-selected\" " : "")
                + "onClick=\"click_message(event," + msg["msgnum"] + ");\""