]>
code.citadel.org Git - citadel.git/log
Wilfried Goesgens [Sun, 12 Dec 2010 14:09:49 +0000 (15:09 +0100)]
Ignore all of our test binaries.
Wilfried Goesgens [Sun, 12 Dec 2010 14:06:09 +0000 (15:06 +0100)]
Add possibility to trigger the tests with Valgrind
Wilfried Goesgens [Sun, 12 Dec 2010 14:03:43 +0000 (15:03 +0100)]
Bugfix: several errors in our test program
- initialize the count before passing it into wildfirea
- free all our buffers properly.
Wilfried Goesgens [Sun, 12 Dec 2010 14:02:40 +0000 (15:02 +0100)]
Bugfixing: free our hashpositions...
Art Cancro [Sun, 12 Dec 2010 03:15:35 +0000 (22:15 -0500)]
Attachments count is now updated in navbar
Art Cancro [Sun, 12 Dec 2010 02:23:16 +0000 (21:23 -0500)]
Show throbber during attachment upload
Art Cancro [Sat, 11 Dec 2010 22:24:06 +0000 (17:24 -0500)]
Hide upload box during an upload. TODO: add throbber.
Art Cancro [Sat, 11 Dec 2010 17:41:31 +0000 (12:41 -0500)]
remove image borders in the upload pane
Art Cancro [Sat, 11 Dec 2010 17:36:13 +0000 (12:36 -0500)]
Change 'Attach' to 'Attachments: 0' (updater will follow)
Wilfried Goesgens [Sat, 11 Dec 2010 15:36:07 +0000 (16:36 +0100)]
Integrate IGs tests
- add to run_tests.sh
- wrap c-unit around the test cases...
Art Cancro [Sat, 11 Dec 2010 02:23:52 +0000 (21:23 -0500)]
New upload dialog is now feature complete
Art Cancro [Fri, 10 Dec 2010 21:25:51 +0000 (16:25 -0500)]
Uploading now works. It is ugly but it works.
Art Cancro [Fri, 10 Dec 2010 21:18:58 +0000 (16:18 -0500)]
Perform uploads via a (eventually to be hidden) iframe
Art Cancro [Fri, 10 Dec 2010 18:31:54 +0000 (13:31 -0500)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Fri, 10 Dec 2010 18:14:35 +0000 (19:14 +0100)]
Mimeparser Bugfix:
- while parsing the headers, don't forget to \0 the extracted strings.
Wilfried Goesgens [Fri, 10 Dec 2010 18:13:28 +0000 (19:13 +0100)]
Performance improvement / Bugfix Mime handling while outputting messages:
- we switched to decode just that part we'd want to output, we should choose the pointer with the decoded buffer.
Art Cancro [Fri, 10 Dec 2010 17:26:25 +0000 (12:26 -0500)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Fri, 10 Dec 2010 17:26:22 +0000 (12:26 -0500)]
Reworking the enter message and attach dialogs
Wilfried Goesgens [Fri, 10 Dec 2010 17:18:12 +0000 (18:18 +0100)]
Fix typo in translation.
Wilfried Goesgens [Fri, 10 Dec 2010 17:14:40 +0000 (18:14 +0100)]
Mimeparser bugfix; if we continue we must flush the already parsed headers too.
Wilfried Goesgens [Fri, 10 Dec 2010 16:08:54 +0000 (17:08 +0100)]
Hunt for mime_parser bugs...
- don't prepend the content-type/content-length - mime header if we don't intend to use it anyways.
Art Cancro [Thu, 9 Dec 2010 17:07:24 +0000 (12:07 -0500)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Thu, 9 Dec 2010 00:05:16 +0000 (01:05 +0100)]
More tiny bugfixes on the mimeparser
- in the for-loop, search first start as initializer, this saves one unneccesary memcmp
- cr/lf detection: we need to do that _before_ the first mime content is evaluated.
Art Cancro [Wed, 8 Dec 2010 14:04:52 +0000 (09:04 -0500)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Wed, 8 Dec 2010 03:17:47 +0000 (22:17 -0500)]
Added the regression test I wrote while fixing stripallbut() yesterday
Wilfried Goesgens [Tue, 7 Dec 2010 22:30:12 +0000 (23:30 +0100)]
Correctly evaluate whether we have a decoded mime part, or if we need to output the raw content.
Wilfried Goesgens [Tue, 7 Dec 2010 22:20:43 +0000 (23:20 +0100)]
Performance: use memchr to find the next '-' and then call memcmp to check whether this is a boundary
- we fast forward to the next '-' since every mime boundary starts with '-'
- from a '-' we check thorough whether at this point we can find the searched boundary
Thanks to cirrus for pointing me to memchr()
Wilfried Goesgens [Tue, 7 Dec 2010 21:27:52 +0000 (22:27 +0100)]
Add more test-mimecontainers.
Wilfried Goesgens [Tue, 7 Dec 2010 21:24:49 +0000 (22:24 +0100)]
Be more conservative about when not to apply binary searching for the next boundary or not.
Art Cancro [Tue, 7 Dec 2010 16:31:35 +0000 (11:31 -0500)]
Rewrote stripallbut() again, tested extensively
Wilfried Goesgens [Sun, 5 Dec 2010 16:31:26 +0000 (17:31 +0100)]
Add test running our wildfire sample code
Wilfried Goesgens [Sun, 5 Dec 2010 16:30:40 +0000 (17:30 +0100)]
In the name of test-coverage: #if 0 the parts we don't need.
Wilfried Goesgens [Sun, 5 Dec 2010 16:14:43 +0000 (17:14 +0100)]
Don't forget to cleanup gcov output in xdgmime
Wilfried Goesgens [Sun, 5 Dec 2010 14:47:18 +0000 (15:47 +0100)]
More shell calls to all our tests
- look up all our staticaly coded mimetypes from randomly generated filenames
- read all contents we find across all test mimecontainers.
Wilfried Goesgens [Sun, 5 Dec 2010 14:45:21 +0000 (15:45 +0100)]
Add test for loading one mimepart from the mimestructure; decode its content inside.
- this found a bug of a const char being modified inside of the call.
Wilfried Goesgens [Sun, 5 Dec 2010 14:43:46 +0000 (15:43 +0100)]
Add test for looking up the icon for a specific mimetype.
Wilfried Goesgens [Sun, 5 Dec 2010 14:41:19 +0000 (15:41 +0100)]
Don't put a static buffer into content_encoding; its changed inside.
- while decoding thats overwritten. probably a bug sleeping in here waiting for its discovery for a long time.
Wilfried Goesgens [Thu, 2 Dec 2010 00:20:40 +0000 (01:20 +0100)]
Update to launchpad R24
- remove fuzzy strings, launchpad doesn't support them
- add new translation
Wilfried Goesgens [Thu, 2 Dec 2010 00:18:28 +0000 (01:18 +0100)]
add scripts to run and test and have code coverage analysis across them.
Wilfried Goesgens [Thu, 2 Dec 2010 00:17:05 +0000 (01:17 +0100)]
Add possibility to trigger the mimeparser internal encoding-decoder
Wilfried Goesgens [Thu, 2 Dec 2010 00:14:53 +0000 (01:14 +0100)]
Testdata: add an email with base64 encoded content.
Wilfried Goesgens [Thu, 2 Dec 2010 00:14:10 +0000 (01:14 +0100)]
Remove loop, its a little unfriendly to run it a 10000 times.
Wilfried Goesgens [Thu, 2 Dec 2010 00:11:41 +0000 (01:11 +0100)]
Add test to call mime lookup algorithms
Wilfried Goesgens [Thu, 2 Dec 2010 00:10:41 +0000 (01:10 +0100)]
Ignore more missing .gcov files
Wilfried Goesgens [Wed, 1 Dec 2010 21:25:57 +0000 (22:25 +0100)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Wed, 1 Dec 2010 21:24:13 +0000 (22:24 +0100)]
Resync to launchpad translation add Bulgarian
- remove fuzzy strings, launchpad doesn't have them and patching chokes on them
Wilfried Goesgens [Wed, 1 Dec 2010 19:40:30 +0000 (20:40 +0100)]
Ignore gcov generated files.
Art Cancro [Tue, 30 Nov 2010 09:04:37 +0000 (04:04 -0500)]
Dismissing the popup-is-blocked window now opens it (hopefully)
Art Cancro [Tue, 30 Nov 2010 08:57:00 +0000 (03:57 -0500)]
toggleModal() now explicitly accepts an argument of 1 (on) or 0 (off)
Art Cancro [Tue, 30 Nov 2010 08:40:45 +0000 (03:40 -0500)]
Modal dialog for the popup blocker warning
Art Cancro [Tue, 30 Nov 2010 08:03:05 +0000 (03:03 -0500)]
fix stupidness in closewindow icon
Art Cancro [Tue, 30 Nov 2010 07:57:28 +0000 (02:57 -0500)]
make the cancel button 32x32
Art Cancro [Tue, 30 Nov 2010 06:52:24 +0000 (01:52 -0500)]
Use modal dialog for confirm logoff
Art Cancro [Tue, 30 Nov 2010 06:11:43 +0000 (01:11 -0500)]
Integrated a modal dialog framework (not in use yet)
Wilfried Goesgens [Sun, 28 Nov 2010 20:02:00 +0000 (21:02 +0100)]
Memleak: getaddrinfo needs freeadrinfo here too.
Wilfried Goesgens [Sun, 28 Nov 2010 18:46:18 +0000 (19:46 +0100)]
Mime-parser rework: parse the mime headers of the current container so we can guess the size of the content to jump accross; binary/ascii is used to switch the search algorithm for the next boundary.
- the old mime parser version skipped empty containers; we do this by hand
- for some reason the numbers addressing the mimeparts grow different, maybe mixed use of old/new may cause confusion...
Wilfried Goesgens [Sat, 27 Nov 2010 13:15:51 +0000 (14:15 +0100)]
Exclude testdata from the distribution tgzs; they don't need it and they're huge.
Wilfried Goesgens [Sat, 27 Nov 2010 13:11:18 +0000 (14:11 +0100)]
Anonimize?
Wilfried Goesgens [Sat, 27 Nov 2010 13:10:47 +0000 (14:10 +0100)]
ignore new test binary for git
Wilfried Goesgens [Sat, 27 Nov 2010 13:09:47 +0000 (14:09 +0100)]
Add test mime containers that (used to..) cause troubles in the recent past.
Wilfried Goesgens [Sat, 27 Nov 2010 12:52:45 +0000 (13:52 +0100)]
Add mime-parser-testing tool
to be able to test the mimeparser in an insulated binary, here we have a test, that reads a given file into memory, and parses it using the mime parser.
Wilfried Goesgens [Sat, 27 Nov 2010 12:45:46 +0000 (13:45 +0100)]
More hickups found due to the mimetester; pre push.
- the_mime_parser (): we need to know where parse_MimeHeaders() finds the end of the headers.
- the_mime_parser (): don't move the pointer around just to count up to the end-pointer. this can be done by pointer substraction.
- parse_MimeHeaders (): move the parameter so our caller gets to know what we read
- parse_MimeHeaders (): if (ptr >= content_end) after reading is probably a bug (also there in stable..), that makes us fail to read the last line, if. move it to the end of the pointer.
- don't call strchr twice; remember & evaluate the first result
- stripping the disposition-header can be done right where we found it.
Wilfried Goesgens [Sat, 27 Nov 2010 11:51:16 +0000 (12:51 +0100)]
fix crash: we want to do is_digit() on *char* not on char*
some bug the mimetest found before push.
Wilfried Goesgens [Fri, 26 Nov 2010 13:44:31 +0000 (14:44 +0100)]
Don't leak FD's while serving static files if they're not there
Ok, this case is rather theoretic, but if for some reason files disappear
after webcits start initialising, we might hit this point.
Wilfried Goesgens [Fri, 26 Nov 2010 00:13:32 +0000 (01:13 +0100)]
First Step: chop mimeparser into pieces.
- move the cluster of buffers into a struct compatible to the CKEY macro
- add the interesting other evaluated flags & numbers to that struct
- move finding & parsing of the 'interesting headers' into its own function.
by all this we hope to get informations about the mimepart before we have to search for its end
Wilfried Goesgens [Fri, 26 Nov 2010 00:11:08 +0000 (01:11 +0100)]
* rewrite stripallbut() to return the length
- remove strlen from the for loop abort condition
- move string around _once_
- return the length of the string we operated on, since we know it after the operation anyways.
Art Cancro [Thu, 25 Nov 2010 20:10:00 +0000 (15:10 -0500)]
<HTML> and <HEAD> set to overflow: hidden to get rid of extra scrollbars
Art Cancro [Thu, 25 Nov 2010 15:34:01 +0000 (10:34 -0500)]
remove a FIXME that we fixed
Wilfried Goesgens [Mon, 22 Nov 2010 23:36:48 +0000 (00:36 +0100)]
avoid decoding mime-parts unless we realy need to.
- suff... doesn't need to decode all attachments; we just need the mime headers here.
- when searching for the attachment we want to output, we also don't need the content.
- when outputing an attachment, just decode the attachment were actualy interested in.
Wilfried Goesgens [Mon, 22 Nov 2010 23:30:57 +0000 (00:30 +0100)]
performance improvements: replace memcmp
- looping forward while moving a pointer and doing memcmp isn't fast. replace it by strstr
- \r\n can be done in a pointer dereferencing comparison.
Note: maybe we need to fallback to the memcmp way if there is binary content?
In that case we should do a little smarter and try to use contentlength-headers etc.
Wilfried Goesgens [Mon, 22 Nov 2010 19:41:28 +0000 (20:41 +0100)]
Add PID/GID/UID of communications parters with unix domain sockets to login-loglines.
This is an addition to Stuarts patch.
Wilfried Goesgens [Sun, 21 Nov 2010 18:55:40 +0000 (19:55 +0100)]
Log remote-IP on login attempts
By Stuart Cianos
Art Cancro [Mon, 22 Nov 2010 04:58:33 +0000 (23:58 -0500)]
Permalinks work now but they are ugly.
Art Cancro [Mon, 22 Nov 2010 04:27:11 +0000 (23:27 -0500)]
Began working on a permalink system WARNING NOT WORKING YET
Wilfried Goesgens [Sun, 21 Nov 2010 17:48:01 +0000 (18:48 +0100)]
avoid calling GETR for the number of total/read messages
so far webcit used a call of GETR to retrieve the number of messages available in the current room for displaying the room banner.
However, GOTO already gave us this information, and GETR is only available for aides, so we got Important messages with that error when logged in as joe average.
This went under the radar for quiet a while, since the error message wasn't printed but silently ignored.
Wilfried Goesgens [Sun, 21 Nov 2010 15:34:16 +0000 (16:34 +0100)]
Relax SMTP Client timeout settings as discussed.
- default is 30 seconds
- Server greeting 90 seconds (DNS lookups for RBLs might be slow
- Server sending the response to the EOM sequence; here we might have background processing like virus or spam scanning that wants to finish before finaly accepting the message.
Art Cancro [Fri, 19 Nov 2010 18:43:35 +0000 (13:43 -0500)]
Began fleshing out the CSS for blog view
Art Cancro [Thu, 18 Nov 2010 02:55:12 +0000 (21:55 -0500)]
Only move from spooltmp to spoolin if there's actually something there.
Wilfried Goesgens [Tue, 16 Nov 2010 21:36:38 +0000 (22:36 +0100)]
Don't send identity header if we want to do gzip compression
Propfind replies send 'Content-encoding: identity' right now, which is superseeded by the frameworks 'Content-encoding: gzip' in case of the client indicates this.
sending that headers twice has uncertain results depending on the client; while the RFC demands to evaluate the later, some fail to read our reply then.
Art Cancro [Tue, 16 Nov 2010 15:48:51 +0000 (10:48 -0500)]
event_jid is a buffer, not a pointer, so don't free() it
Wilfried Goesgens [Mon, 15 Nov 2010 13:43:50 +0000 (14:43 +0100)]
Memleak: post_message(): don't forget about the recipient buffer.
Wilfried Goesgens [Mon, 15 Nov 2010 12:26:50 +0000 (13:26 +0100)]
Memleak: put request local strings into the http-header array (we used SVPUT to manage them in advance)
Wilfried Goesgens [Mon, 15 Nov 2010 11:46:17 +0000 (12:46 +0100)]
Memleak: CtdlMakeMessage(): don't forget about the original author.
Wilfried Goesgens [Mon, 15 Nov 2010 11:41:55 +0000 (12:41 +0100)]
smtp_do_bounce(): don't loose msg['A'] when overwriting its content.
Art Cancro [Mon, 15 Nov 2010 15:18:48 +0000 (10:18 -0500)]
Removed a few unneeded calls to scr_flush()
Art Cancro [Mon, 15 Nov 2010 04:17:15 +0000 (23:17 -0500)]
Began defining CSS for blog view
Wilfried Goesgens [Sun, 14 Nov 2010 22:15:16 +0000 (23:15 +0100)]
Memleak: free the list of search hooks on exit
Wilfried Goesgens [Sun, 14 Nov 2010 22:14:41 +0000 (23:14 +0100)]
Memleak: free the global inet-config on exit.
Wilfried Goesgens [Sun, 14 Nov 2010 22:11:40 +0000 (23:11 +0100)]
Memleak: free the XMPP-Eventqueue on shutdown
TODO: the event_jid member contains an unclean pointer, no clue why.
Wilfried Goesgens [Sun, 14 Nov 2010 22:10:57 +0000 (23:10 +0100)]
Memleak: free the roomlist of the sieve-queued rooms on exit; other tiny leaks.
Wilfried Goesgens [Sun, 14 Nov 2010 22:10:10 +0000 (23:10 +0100)]
Memleak: fix the varous handler & config lists of the rss module on exit.
Wilfried Goesgens [Sun, 14 Nov 2010 22:09:32 +0000 (23:09 +0100)]
Memleak: free the imap-handlerlist on exit
Wilfried Goesgens [Sun, 14 Nov 2010 22:08:44 +0000 (23:08 +0100)]
Memleak: free the nttlist (network host list) on exit
Wilfried Goesgens [Sun, 14 Nov 2010 22:07:10 +0000 (23:07 +0100)]
Memleak: sock_connect() needs to call freeaddrinfo()
Wilfried Goesgens [Sat, 13 Nov 2010 16:07:34 +0000 (17:07 +0100)]
found one more place using IO directly, rerouting it to buffered IO else it will spoil the sequence.
Art Cancro [Fri, 12 Nov 2010 20:05:40 +0000 (15:05 -0500)]
New templates for rendering messages as blog posts and comments
Art Cancro [Fri, 12 Nov 2010 16:37:40 +0000 (11:37 -0500)]
Localized strings for blog view
Wilfried Goesgens [Wed, 10 Nov 2010 19:22:16 +0000 (20:22 +0100)]
fix buffer overrun while converting charsets
* DecodeSegment() didn't check whether one of the temporary buffers would be able to bear the transcoding results
Art Cancro [Wed, 10 Nov 2010 05:04:45 +0000 (00:04 -0500)]
msgbuttons are now back to being ordinary links.
They're smaller this way, and they also don't misbehave
under Internet Exploder.
Wilfried Goesgens [Tue, 9 Nov 2010 21:59:46 +0000 (22:59 +0100)]
Update translations to Launchpad R13