Wilfried Goesgens [Sun, 28 Nov 2010 20:02:00 +0000 (21:02 +0100)]
Memleak: getaddrinfo needs freeadrinfo here too.
Wilfried Goesgens [Sun, 28 Nov 2010 18:46:18 +0000 (19:46 +0100)]
Mime-parser rework: parse the mime headers of the current container so we can guess the size of the content to jump accross; binary/ascii is used to switch the search algorithm for the next boundary.
- the old mime parser version skipped empty containers; we do this by hand
- for some reason the numbers addressing the mimeparts grow different, maybe mixed use of old/new may cause confusion...
Wilfried Goesgens [Sat, 27 Nov 2010 13:15:51 +0000 (14:15 +0100)]
Exclude testdata from the distribution tgzs; they don't need it and they're huge.
Wilfried Goesgens [Sat, 27 Nov 2010 13:11:18 +0000 (14:11 +0100)]
Anonimize?
Wilfried Goesgens [Sat, 27 Nov 2010 13:10:47 +0000 (14:10 +0100)]
ignore new test binary for git
Wilfried Goesgens [Sat, 27 Nov 2010 13:09:47 +0000 (14:09 +0100)]
Add test mime containers that (used to..) cause troubles in the recent past.
Wilfried Goesgens [Sat, 27 Nov 2010 12:52:45 +0000 (13:52 +0100)]
Add mime-parser-testing tool
to be able to test the mimeparser in an insulated binary, here we have a test, that reads a given file into memory, and parses it using the mime parser.
Wilfried Goesgens [Sat, 27 Nov 2010 12:45:46 +0000 (13:45 +0100)]
More hickups found due to the mimetester; pre push.
- the_mime_parser (): we need to know where parse_MimeHeaders() finds the end of the headers.
- the_mime_parser (): don't move the pointer around just to count up to the end-pointer. this can be done by pointer substraction.
- parse_MimeHeaders (): move the parameter so our caller gets to know what we read
- parse_MimeHeaders (): if (ptr >= content_end) after reading is probably a bug (also there in stable..), that makes us fail to read the last line, if. move it to the end of the pointer.
- don't call strchr twice; remember & evaluate the first result
- stripping the disposition-header can be done right where we found it.
Wilfried Goesgens [Sat, 27 Nov 2010 11:51:16 +0000 (12:51 +0100)]
fix crash: we want to do is_digit() on *char* not on char*
some bug the mimetest found before push.
Wilfried Goesgens [Fri, 26 Nov 2010 13:44:31 +0000 (14:44 +0100)]
Don't leak FD's while serving static files if they're not there
Ok, this case is rather theoretic, but if for some reason files disappear
after webcits start initialising, we might hit this point.
Wilfried Goesgens [Fri, 26 Nov 2010 00:13:32 +0000 (01:13 +0100)]
First Step: chop mimeparser into pieces.
- move the cluster of buffers into a struct compatible to the CKEY macro
- add the interesting other evaluated flags & numbers to that struct
- move finding & parsing of the 'interesting headers' into its own function.
by all this we hope to get informations about the mimepart before we have to search for its end
Wilfried Goesgens [Fri, 26 Nov 2010 00:11:08 +0000 (01:11 +0100)]
* rewrite stripallbut() to return the length
- remove strlen from the for loop abort condition
- move string around _once_
- return the length of the string we operated on, since we know it after the operation anyways.
Art Cancro [Thu, 25 Nov 2010 20:10:00 +0000 (15:10 -0500)]
<HTML> and <HEAD> set to overflow: hidden to get rid of extra scrollbars
Art Cancro [Thu, 25 Nov 2010 15:34:01 +0000 (10:34 -0500)]
remove a FIXME that we fixed
Wilfried Goesgens [Mon, 22 Nov 2010 23:36:48 +0000 (00:36 +0100)]
avoid decoding mime-parts unless we realy need to.
- suff... doesn't need to decode all attachments; we just need the mime headers here.
- when searching for the attachment we want to output, we also don't need the content.
- when outputing an attachment, just decode the attachment were actualy interested in.
Wilfried Goesgens [Mon, 22 Nov 2010 23:30:57 +0000 (00:30 +0100)]
performance improvements: replace memcmp
- looping forward while moving a pointer and doing memcmp isn't fast. replace it by strstr
- \r\n can be done in a pointer dereferencing comparison.
Note: maybe we need to fallback to the memcmp way if there is binary content?
In that case we should do a little smarter and try to use contentlength-headers etc.
Wilfried Goesgens [Mon, 22 Nov 2010 19:41:28 +0000 (20:41 +0100)]
Add PID/GID/UID of communications parters with unix domain sockets to login-loglines.
This is an addition to Stuarts patch.
Wilfried Goesgens [Sun, 21 Nov 2010 18:55:40 +0000 (19:55 +0100)]
Log remote-IP on login attempts
By Stuart Cianos
Art Cancro [Mon, 22 Nov 2010 04:58:33 +0000 (23:58 -0500)]
Permalinks work now but they are ugly.
Art Cancro [Mon, 22 Nov 2010 04:27:11 +0000 (23:27 -0500)]
Began working on a permalink system WARNING NOT WORKING YET
Wilfried Goesgens [Sun, 21 Nov 2010 17:48:01 +0000 (18:48 +0100)]
avoid calling GETR for the number of total/read messages
so far webcit used a call of GETR to retrieve the number of messages available in the current room for displaying the room banner.
However, GOTO already gave us this information, and GETR is only available for aides, so we got Important messages with that error when logged in as joe average.
This went under the radar for quiet a while, since the error message wasn't printed but silently ignored.
Wilfried Goesgens [Sun, 21 Nov 2010 15:34:16 +0000 (16:34 +0100)]
Relax SMTP Client timeout settings as discussed.
- default is 30 seconds
- Server greeting 90 seconds (DNS lookups for RBLs might be slow
- Server sending the response to the EOM sequence; here we might have background processing like virus or spam scanning that wants to finish before finaly accepting the message.
Art Cancro [Fri, 19 Nov 2010 18:43:35 +0000 (13:43 -0500)]
Began fleshing out the CSS for blog view
Art Cancro [Thu, 18 Nov 2010 02:55:12 +0000 (21:55 -0500)]
Only move from spooltmp to spoolin if there's actually something there.
Wilfried Goesgens [Tue, 16 Nov 2010 21:36:38 +0000 (22:36 +0100)]
Don't send identity header if we want to do gzip compression
Propfind replies send 'Content-encoding: identity' right now, which is superseeded by the frameworks 'Content-encoding: gzip' in case of the client indicates this.
sending that headers twice has uncertain results depending on the client; while the RFC demands to evaluate the later, some fail to read our reply then.
Art Cancro [Tue, 16 Nov 2010 15:48:51 +0000 (10:48 -0500)]
event_jid is a buffer, not a pointer, so don't free() it
Wilfried Goesgens [Mon, 15 Nov 2010 13:43:50 +0000 (14:43 +0100)]
Memleak: post_message(): don't forget about the recipient buffer.
Wilfried Goesgens [Mon, 15 Nov 2010 12:26:50 +0000 (13:26 +0100)]
Memleak: put request local strings into the http-header array (we used SVPUT to manage them in advance)
Wilfried Goesgens [Mon, 15 Nov 2010 11:46:17 +0000 (12:46 +0100)]
Memleak: CtdlMakeMessage(): don't forget about the original author.
Wilfried Goesgens [Mon, 15 Nov 2010 11:41:55 +0000 (12:41 +0100)]
smtp_do_bounce(): don't loose msg['A'] when overwriting its content.
Art Cancro [Mon, 15 Nov 2010 15:18:48 +0000 (10:18 -0500)]
Removed a few unneeded calls to scr_flush()
Art Cancro [Mon, 15 Nov 2010 04:17:15 +0000 (23:17 -0500)]
Began defining CSS for blog view
Wilfried Goesgens [Sun, 14 Nov 2010 22:15:16 +0000 (23:15 +0100)]
Memleak: free the list of search hooks on exit
Wilfried Goesgens [Sun, 14 Nov 2010 22:14:41 +0000 (23:14 +0100)]
Memleak: free the global inet-config on exit.
Wilfried Goesgens [Sun, 14 Nov 2010 22:11:40 +0000 (23:11 +0100)]
Memleak: free the XMPP-Eventqueue on shutdown
TODO: the event_jid member contains an unclean pointer, no clue why.
Wilfried Goesgens [Sun, 14 Nov 2010 22:10:57 +0000 (23:10 +0100)]
Memleak: free the roomlist of the sieve-queued rooms on exit; other tiny leaks.
Wilfried Goesgens [Sun, 14 Nov 2010 22:10:10 +0000 (23:10 +0100)]
Memleak: fix the varous handler & config lists of the rss module on exit.
Wilfried Goesgens [Sun, 14 Nov 2010 22:09:32 +0000 (23:09 +0100)]
Memleak: free the imap-handlerlist on exit
Wilfried Goesgens [Sun, 14 Nov 2010 22:08:44 +0000 (23:08 +0100)]
Memleak: free the nttlist (network host list) on exit
Wilfried Goesgens [Sun, 14 Nov 2010 22:07:10 +0000 (23:07 +0100)]
Memleak: sock_connect() needs to call freeaddrinfo()
Wilfried Goesgens [Sat, 13 Nov 2010 16:07:34 +0000 (17:07 +0100)]
found one more place using IO directly, rerouting it to buffered IO else it will spoil the sequence.
Art Cancro [Fri, 12 Nov 2010 20:05:40 +0000 (15:05 -0500)]
New templates for rendering messages as blog posts and comments
Art Cancro [Fri, 12 Nov 2010 16:37:40 +0000 (11:37 -0500)]
Localized strings for blog view
Wilfried Goesgens [Wed, 10 Nov 2010 19:22:16 +0000 (20:22 +0100)]
fix buffer overrun while converting charsets
* DecodeSegment() didn't check whether one of the temporary buffers would be able to bear the transcoding results
Art Cancro [Wed, 10 Nov 2010 05:04:45 +0000 (00:04 -0500)]
msgbuttons are now back to being ordinary links.
They're smaller this way, and they also don't misbehave
under Internet Exploder.
Wilfried Goesgens [Tue, 9 Nov 2010 21:59:46 +0000 (22:59 +0100)]
Update translations to Launchpad R13
Wilfried Goesgens [Tue, 9 Nov 2010 00:29:50 +0000 (01:29 +0100)]
check whether the sorting algorithm specified via BSTRs is intended for us before using its groupchange detector.
root [Mon, 8 Nov 2010 22:31:13 +0000 (23:31 +0100)]
add script to generate gcov/lcov output.
Wilfried Goesgens [Mon, 8 Nov 2010 20:44:29 +0000 (21:44 +0100)]
fix some incompletely transformed reply strings; thanks gcov & imaptest
Wilfried Goesgens [Mon, 8 Nov 2010 20:43:19 +0000 (21:43 +0100)]
more gcov files to ignore...
Wilfried Goesgens [Mon, 8 Nov 2010 20:40:53 +0000 (21:40 +0100)]
add a way to configure code coverage
Wilfried Goesgens [Mon, 8 Nov 2010 20:38:31 +0000 (21:38 +0100)]
Ignore data files left behind by gcov
Wilfried Goesgens [Sun, 7 Nov 2010 20:29:18 +0000 (21:29 +0100)]
Rewrite IMAP-Module to buffer its output
- move defines from imap_tools.h into serv_imap.h
- switch includes in sequence
- we now have IMAP->Reply, which we write into, until IUnbuffer sends it to the client
- IReply & IReplyPrintf do now send 'Params[0].Key BAD xxxxxx\r\n' to the client; this makes the code more compact.
- IA* append stuff to the outbuffer that we want to send.
- replace rumpelstilskin handler lookup by hashlist and central register calls.
- replace if's in the sequence separating the handlers by their required pre-conditions by flags on the register call.
this should
- (hopefully) fix some troubles with evolutions imap, which wouldn't like to read enough chunks until the line ends
- speed up stuff like header fetching in huge lists, since we reduce the number of context switches here.
Wilfried Goesgens [Sat, 6 Nov 2010 12:51:41 +0000 (13:51 +0100)]
have flexible timouts while reading lines in our client mode connections
since some mailserver take a little longer to finish reading mails we need to wait after we send our '.\r\n'; its 90 seconds now, all other parts will wait 5s, quit will wait 1 second.
Wilfried Goesgens [Sat, 6 Nov 2010 11:18:23 +0000 (12:18 +0100)]
Nonblocking sockets need to select while writing
we changed the SMTP outbound connections to be nonblocking so we could abort on not reacting SMTP-Servers.
thus we need to select before writing, else the connection will fail.
Wilfried Goesgens [Thu, 4 Nov 2010 23:17:09 +0000 (00:17 +0100)]
handle errors during netedit:
- put server errors into the ImportantMessage
- use StrBuf
- use GetServerStatus
Wilfried Goesgens [Thu, 4 Nov 2010 23:14:38 +0000 (00:14 +0100)]
New macro for putting a Citserver reply into important message: SRV_STATUS_MSG
Use it like that:
StrBuf_ServGetln(Line);
if (GetServerStatus(Line, NULL) != 1) {
AppendImportantMessage(SRV_STATUS_MSG(Line));
Wilfried Goesgens [Thu, 4 Nov 2010 23:12:50 +0000 (00:12 +0100)]
if we tell the client we're in error state, return.
if SNET would fail to open the temporary file, it would tell the client 'error' and continue to read -> hang
we now abort after reporting the error.
Wilfried Goesgens [Thu, 4 Nov 2010 21:33:33 +0000 (22:33 +0100)]
don't fetch a RSS before the network frequency is elapsed
currently the RSS-Thread is run over and over; we shouldn't stress our partrers to much, so we let the network poll frequency elaps before we try to poll the rss feed again.
Wilfried Goesgens [Thu, 4 Nov 2010 19:28:27 +0000 (20:28 +0100)]
fix crash in SSL BLOB-Reading
- when diciding whether the read buffer contains more than the blob reader wants we had a wrong equation.
Wilfried Goesgens [Wed, 3 Nov 2010 20:47:55 +0000 (21:47 +0100)]
move old tokenizer over to the managesieve server; its only used there.
- remove old_imap_tokenizer from imap_tools.h
- move old_imap_tokenizer to modules/managesieve/serv_managesieve.c
- move imap_tools.h to modules/imap; since its not needed globaly anymore.
Wilfried Goesgens [Mon, 1 Nov 2010 23:03:41 +0000 (00:03 +0100)]
Ups, its el_GR not el_EL
Wilfried Goesgens [Mon, 1 Nov 2010 22:38:07 +0000 (23:38 +0100)]
Do a more precise match to find out our UID
Wilfried Goesgens [Mon, 1 Nov 2010 22:24:54 +0000 (23:24 +0100)]
fix compilation
- Makefile had a wrong include
- msgfmt would abort on missing linebreaks
Art Cancro [Mon, 1 Nov 2010 18:19:14 +0000 (14:19 -0400)]
Cosmetic cleanup of previous two commits
Art Cancro [Mon, 1 Nov 2010 18:10:07 +0000 (14:10 -0400)]
Fixed the viewdefs code to handle the fact that enum 9 is now
drafts and 10 is blogs. This fixes the select-o-matic thing.
Art Cancro [Mon, 1 Nov 2010 17:23:03 +0000 (13:23 -0400)]
viewdefs is now boolean
Wilfried Goesgens [Mon, 1 Nov 2010 10:48:23 +0000 (11:48 +0100)]
Blanks.
Wilfried Goesgens [Mon, 1 Nov 2010 10:46:37 +0000 (11:46 +0100)]
Blanks are beautyfull.
Wilfried Goesgens [Mon, 1 Nov 2010 10:07:19 +0000 (11:07 +0100)]
Add more url-shorteners that showed up in my way.
Wilfried Goesgens [Mon, 1 Nov 2010 09:45:42 +0000 (10:45 +0100)]
Update translation to Launchpad r7
Wilfried Goesgens [Mon, 1 Nov 2010 09:24:51 +0000 (10:24 +0100)]
Finalize fixing of netconfig loosing incident
* need to set & check errno that tells us whether our tempfile was fresh created or already there
* remove tmpfile on error
* don't use fopen() because we can't specify the flags we need for that
* ftruncate() the tempfile at the right place
Wilfried Goesgens [Sat, 30 Oct 2010 17:54:01 +0000 (19:54 +0200)]
Prevent writing empty network configs Part II
* writenfree_spoolcontrol_file ()
- serialise into a StrBuf
- write that to a tempfile in the netconfig directory
- if we fail, abort & log error
- if we succed use rename () to replace the original config file.
Wilfried Goesgens [Sat, 30 Oct 2010 17:17:55 +0000 (19:17 +0200)]
add string representations of the RoomNetCfg as RoomNetCfgStr[maxRoomNetCfg]
Wilfried Goesgens [Sat, 30 Oct 2010 16:44:15 +0000 (18:44 +0200)]
* cmd_snet: make shure the target FS has enough space for the new config
- Create our own filename insteaf of using mk*tmp*; CC->cs_pid should be uniq.; we use O_CREAT|O_EXCL so we're shure its ours or fails.
- Create that filename in the same directory as the filal config filename; by that we can be shure its in the same filesystem, and if thats full, we will fail
- Stat the original file for sise (if not there assume 80) and write twice as much into that file so we're next to shure the content from the client will fit in
- the citadel protocol is a little st00pit here, we don't know the size in advance, and we can't return an error _after_ accepting the file
- instead of moving the content of the tempfile into the final file, we use rename() which is supposed to be atomic.
Wilfried Goesgens [Sat, 30 Oct 2010 16:43:20 +0000 (18:43 +0200)]
assoc_file_name(): return length of string
Wilfried Goesgens [Sat, 30 Oct 2010 13:19:56 +0000 (15:19 +0200)]
Translation update to Launchpad #6
- add Greek
- add Svenska
- sort locale list
Art Cancro [Wed, 27 Oct 2010 19:03:06 +0000 (15:03 -0400)]
Moved the TinyMCE toolbar to the top of the editor window.
Art Cancro [Wed, 27 Oct 2010 18:53:46 +0000 (14:53 -0400)]
Added a little bit of clever JavaScript to make the TinyMCE window occupy
the full height of the browser window.
Art Cancro [Wed, 27 Oct 2010 16:54:58 +0000 (12:54 -0400)]
Upgrade TinyMCE
Art Cancro [Tue, 26 Oct 2010 22:51:36 +0000 (18:51 -0400)]
Don't output a space between imap namespaces
(patch suggested by samjam to fix javamail errors)
Art Cancro [Tue, 26 Oct 2010 22:50:55 +0000 (18:50 -0400)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Tue, 26 Oct 2010 22:51:19 +0000 (00:51 +0200)]
* blanks.
Wilfried Goesgens [Tue, 26 Oct 2010 22:47:20 +0000 (00:47 +0200)]
* blanx
Wilfried Goesgens [Tue, 26 Oct 2010 22:43:08 +0000 (00:43 +0200)]
* blank.
Wilfried Goesgens [Tue, 26 Oct 2010 22:41:41 +0000 (00:41 +0200)]
blanx?
Wilfried Goesgens [Tue, 26 Oct 2010 22:39:53 +0000 (00:39 +0200)]
blahangkx
Wilfried Goesgens [Tue, 26 Oct 2010 22:31:42 +0000 (00:31 +0200)]
* bllannnks.
Wilfried Goesgens [Tue, 26 Oct 2010 22:30:57 +0000 (00:30 +0200)]
* Blanks!
Wilfried Goesgens [Tue, 26 Oct 2010 22:29:07 +0000 (00:29 +0200)]
* blanks???
Wilfried Goesgens [Tue, 26 Oct 2010 22:13:49 +0000 (00:13 +0200)]
* blaahaaank
Wilfried Goesgens [Tue, 26 Oct 2010 22:07:08 +0000 (00:07 +0200)]
* o noes blanks?
Wilfried Goesgens [Tue, 26 Oct 2010 22:03:57 +0000 (00:03 +0200)]
oh, well, maybe a blank anyways here?
Art Cancro [Tue, 26 Oct 2010 21:40:48 +0000 (17:40 -0400)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Wilfried Goesgens [Tue, 26 Oct 2010 21:25:26 +0000 (23:25 +0200)]
* oh noes, thas blank wasn't that nice after all.
Wilfried Goesgens [Tue, 26 Oct 2010 21:14:29 +0000 (23:14 +0200)]
blanks? blanks anyone? they're nice.
Wilfried Goesgens [Tue, 26 Oct 2010 21:06:20 +0000 (23:06 +0200)]
* make it const, not written anyways
Wilfried Goesgens [Tue, 26 Oct 2010 19:34:32 +0000 (21:34 +0200)]
* sock_getln (): CtdlSockGetLine() gives us lines without \r\n, no need to look for them again
* sock_getln_err (): add integer pointer returning the actual return state in case of error
* ml_sock_gets (): use sock_getln_err () so we can abort on impropper replies
* smtp_try (): make socket nonblocking, so we can abort on error
-> we will wait 5 seconds for the remote site to send us the SMTP-State else we will abort the connection on failure.
Art Cancro [Tue, 26 Oct 2010 04:20:30 +0000 (00:20 -0400)]
Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel
Art Cancro [Tue, 26 Oct 2010 04:17:37 +0000 (00:17 -0400)]
Numerous style changes to the 'edit message' dialog. The save,
cancel, and address book buttons now occupy the navbar instead of
a bunch of controls that shouldn't have been there anyway. I
also fixed a javascript bug that was making the addressbook popup
silently fail in the background if we were in a room that didn't
require message recipients.
The attachment dialog now sits above the message body pane, but
this will soon get migrated into the navbar as well (maybe another
popup).
Finally, the background of the message entry div now more or less
occupies the entire space available to it; this still needs more
tuning in order to make the editor occupy the correct amount of
space in the pane.
projects / citadel.git / log