citadel.git
17 years agoRemoved the old CtdlSaveMsgPointerInRoom() API. Everything now
Art Cancro [Sat, 5 Aug 2006 04:00:50 +0000 (04:00 +0000)]
Removed the old CtdlSaveMsgPointerInRoom() API.  Everything now
uses the bulk-capable CtdlSaveMsgPointersInRoom() instead.

17 years agoBugfix for previous commit: IMAP and POP3 expunge operations
Art Cancro [Fri, 28 Jul 2006 04:14:15 +0000 (04:14 +0000)]
Bugfix for previous commit: IMAP and POP3 expunge operations
were calling CtdlDeleteMessages() with num_msgs=0 if there was nothing to delete; this
was bad because it causes all msgs in the room to be deleted.

17 years agoCtdlDeleteMessages() now has a bulk API. Updated all of the
Art Cancro [Fri, 28 Jul 2006 03:30:57 +0000 (03:30 +0000)]
CtdlDeleteMessages() now has a bulk API.  Updated all of the
callers to use it.  Also updated the IMAP and POP3 expunge functions to actually
make use of the bulk delete.  This should significantly improve performance
when used with large folders.

17 years agoCtdlDeleteMessages() now uses the bulk API CtdlCopyMsgsToRoom()
Art Cancro [Thu, 27 Jul 2006 04:21:07 +0000 (04:21 +0000)]
CtdlDeleteMessages() now uses the bulk API CtdlCopyMsgsToRoom()
to move deleted messages to the __CtdlDeletedMessages__ room.  The next
step will be to make CtdlDeleteMessages() itself a bulk-move API.

17 years agoRemoved a spurious FIXME that had already been fixed
Art Cancro [Thu, 27 Jul 2006 03:35:37 +0000 (03:35 +0000)]
Removed a spurious FIXME that had already been fixed

17 years agoConfigure and observe the server setting for default timezone
Art Cancro [Wed, 19 Jul 2006 03:32:48 +0000 (03:32 +0000)]
Configure and observe the server setting for default timezone
for calendar items which have no zone set and are not UTC.

17 years agoAdd the cal zone to INFO command
Art Cancro [Wed, 19 Jul 2006 03:24:05 +0000 (03:24 +0000)]
Add the cal zone to INFO command

17 years agoAdded a global system config item for the default time
Art Cancro [Wed, 19 Jul 2006 02:23:12 +0000 (02:23 +0000)]
Added a global system config item for the default time
zone for unzoned calendar items.  Patched ical_dezonify to use it.

17 years ago* added some points to the roadmap.
Wilfried Göesgens [Tue, 18 Jul 2006 22:27:53 +0000 (22:27 +0000)]
* added some points to the roadmap.
* check for citadel.sock before we try to shutdown citadel on upgrade.

17 years agomore timezone hacking. this will work eventually.
Art Cancro [Tue, 18 Jul 2006 03:24:37 +0000 (03:24 +0000)]
more timezone hacking.  this will work eventually.

17 years agoFixed a logic bug that caused the full text index
Art Cancro [Tue, 18 Jul 2006 02:39:51 +0000 (02:39 +0000)]
Fixed a logic bug that caused the full text index
to get rebuilt from scratch every time the global system configuration
was edited.

17 years agoSelf-signed cert now uses a wildcard name
Art Cancro [Mon, 17 Jul 2006 17:18:52 +0000 (17:18 +0000)]
Self-signed cert now uses a wildcard name

17 years agoSelf-signed cert now uses a wildcard name
Art Cancro [Mon, 17 Jul 2006 17:15:52 +0000 (17:15 +0000)]
Self-signed cert now uses a wildcard name

17 years agoAdded a FIXME comment noting that imap_do_expunge() needs
Art Cancro [Mon, 17 Jul 2006 16:23:55 +0000 (16:23 +0000)]
Added a FIXME comment noting that imap_do_expunge() needs
to use the new bulk move API

17 years agoBrought over the new ical_dezonify that handles unspecified
Art Cancro [Mon, 17 Jul 2006 03:44:38 +0000 (03:44 +0000)]
Brought over the new ical_dezonify that handles unspecified
timezones by converting from a default timezone to UTC.  This
also has the temporary hack that always uses America/New_York as the
default time zone.  Needs to be fixed before we publish.

17 years agoMake a note of the fact that we've hardcoded
Art Cancro [Mon, 17 Jul 2006 03:37:14 +0000 (03:37 +0000)]
Make a note of the fact that we've hardcoded
the America/New_York timezone in for now.

17 years agoFor some reason it's not properly saving the
Art Cancro [Thu, 13 Jul 2006 03:47:40 +0000 (03:47 +0000)]
For some reason it's not properly saving the
converted timestamps back into the data structure.  Added log
messages for testing.

17 years agoWhen finding a non-UTC timestamp with no time
Art Cancro [Thu, 13 Jul 2006 03:22:51 +0000 (03:22 +0000)]
When finding a non-UTC timestamp with no time
zone specified, convert from the local timezone to UTC.  Currently
it is hardcoded for the America/New_York timezone, but we will fix
that.

17 years agoical_dezonify: rearranged code and added log output
Art Cancro [Wed, 12 Jul 2006 03:47:47 +0000 (03:47 +0000)]
ical_dezonify: rearranged code and added log output
to determine whether a timestamp is either (1) already UTC, (2) not UTC
but included a time zone to convert from, or (3) not UTC but no timezone
specified.  Still need to handle (3) better, but we need to find a way
to determine the current timezone.

17 years ago* added items from the purged whishlist room, as much as i can remember.
Wilfried Göesgens [Tue, 11 Jul 2006 19:46:05 +0000 (19:46 +0000)]
* added items from the purged whishlist room, as much as i can remember.

17 years agoWhen generating Message ID's, pad with leading zeroes
Art Cancro [Tue, 11 Jul 2006 17:16:14 +0000 (17:16 +0000)]
When generating Message ID's, pad with leading zeroes
to ten places in order to thwart a b0rken SpamAssassin rule which
assumes that less than five characters to the left of the @ means
a message is spam.

17 years ago* as ubuntu for example purges /var/run, we need to make sure that we can open our...
Wilfried Göesgens [Mon, 10 Jul 2006 23:08:39 +0000 (23:08 +0000)]
* as ubuntu for example purges /var/run, we need to make sure that we can open our sockets.

17 years agoCorrected Matt's name in the credits
Art Cancro [Sun, 9 Jul 2006 14:06:39 +0000 (14:06 +0000)]
Corrected Matt's name in the credits

17 years agoCorrected Matt's name in the credits
Art Cancro [Sun, 9 Jul 2006 14:05:59 +0000 (14:05 +0000)]
Corrected Matt's name in the credits

17 years ago* don't translate citadel commands!
Wilfried Göesgens [Thu, 6 Jul 2006 21:04:18 +0000 (21:04 +0000)]
* don't translate citadel commands!

17 years ago* New HALT command shuts down server but suspends instead of exiting.
Art Cancro [Thu, 6 Jul 2006 02:44:20 +0000 (02:44 +0000)]
* New HALT command shuts down server but suspends instead of exiting.
* setup.c: fixed a citadel.config path problem that prevented alternative dir installations
from working properly

17 years agoChanges to Easy Install based on fleeb's suggestions.
Art Cancro [Wed, 5 Jul 2006 03:14:48 +0000 (03:14 +0000)]
Changes to Easy Install based on fleeb's suggestions.
Makes the hunt for wget or curl a bit more reliable.

17 years agoAllow internal programs to rename rooms and create new rooms.
Michael Hampton [Fri, 23 Jun 2006 11:29:59 +0000 (11:29 +0000)]
Allow internal programs to rename rooms and create new rooms.

17 years agoMailing lists need to have confirmations logged to comply with various laws
Michael Hampton [Fri, 23 Jun 2006 11:29:05 +0000 (11:29 +0000)]
Mailing lists need to have confirmations logged to comply with various laws

17 years ago* corrected some typos in the dirs
Wilfried Göesgens [Thu, 22 Jun 2006 19:07:09 +0000 (19:07 +0000)]
* corrected some typos in the dirs
* removed citadel.schema

17 years agocitadel_ipc.c: comment out block of code that
Art Cancro [Wed, 21 Jun 2006 03:26:57 +0000 (03:26 +0000)]
citadel_ipc.c: comment out block of code that
handles certain OpenSSL errors incorrectly.  It was recursing into itself
infinitely until a stack overflow.  The condition under which this occurs
has not been located or fixed, but at least now it will exit with an
OpenSSL error message.

17 years agoApplied Matt's patches for the addition of four new client
Art Cancro [Wed, 21 Jun 2006 02:45:12 +0000 (02:45 +0000)]
Applied Matt's patches for the addition of four new client
commands for quick navigation between rooms and floors.

17 years agogettext.c: 'search' is now a fixed length string buffer.
Art Cancro [Sun, 18 Jun 2006 03:44:16 +0000 (03:44 +0000)]
gettext.c: 'search' is now a fixed length string buffer.
Memory allocation issues were causing WebCit to crash in some situations.

17 years agoran create-pot.sh
Art Cancro [Fri, 9 Jun 2006 03:42:46 +0000 (03:42 +0000)]
ran create-pot.sh

17 years agoDon't reference <malloc.h> - it is not needed
Art Cancro [Wed, 7 Jun 2006 03:47:25 +0000 (03:47 +0000)]
Don't reference <malloc.h> - it is not needed

17 years agoDanish translation (da_DK) supplied by Flemming Veggerby
Art Cancro [Wed, 31 May 2006 18:31:47 +0000 (18:31 +0000)]
Danish translation (da_DK) supplied by Flemming Veggerby

17 years agoInternal version number update to 6.82
Art Cancro [Tue, 30 May 2006 14:03:25 +0000 (14:03 +0000)]
Internal version number update to 6.82

17 years agoHandle read-only rooms more gracefully when attempting
Art Cancro [Fri, 26 May 2006 16:38:49 +0000 (16:38 +0000)]
Handle read-only rooms more gracefully when attempting
to post calendar items, etc.

17 years agosetup.c: more directory initialization submitted by serge gagnon
Art Cancro [Fri, 26 May 2006 03:41:09 +0000 (03:41 +0000)]
setup.c: more directory initialization submitted by serge gagnon

17 years agohtml.c: convert some common character entity references
Art Cancro [Fri, 26 May 2006 03:34:07 +0000 (03:34 +0000)]
html.c: convert some common character entity references
to fake it on a 7 bit terminal

17 years ago* Fixed some compiler warnings in the new unsignedchar-safe version
Art Cancro [Tue, 23 May 2006 02:01:36 +0000 (02:01 +0000)]
* Fixed some compiler warnings in the new unsignedchar-safe version
  of text_to_server_qp()
* Added in an ifdef block around the call to endtls() to make it
  safe to compile on non-OpenSSL hosts

17 years agohtml.c: removed extra newlines entering/exiting blockquote sections.
Art Cancro [Mon, 22 May 2006 19:37:41 +0000 (19:37 +0000)]
html.c: removed extra newlines entering/exiting blockquote sections.

17 years agoWhen THE DREADED AUTO-PURGER expires user accounts,
Art Cancro [Mon, 22 May 2006 03:06:00 +0000 (03:06 +0000)]
When THE DREADED AUTO-PURGER expires user accounts,
we were previously expiring accounts for which an associated Unix account no longer exists
if running in autologin mode.  This is now the ONLY condition under which an account will
be expired in this mode.

17 years agotext_to_server_qp() use unsigned char instead of char.
Art Cancro [Mon, 22 May 2006 02:57:37 +0000 (02:57 +0000)]
text_to_server_qp() use unsigned char instead of char.
Fixes bug in transmitting some UTF-8 characters.

17 years agoApplied patch submitted by Matt for empty field checking in calendar items
Art Cancro [Mon, 22 May 2006 02:40:03 +0000 (02:40 +0000)]
Applied patch submitted by Matt for empty field checking in calendar items

17 years agohtml.c: rendering of BLOCKQUOTE sections is now
Art Cancro [Thu, 18 May 2006 03:34:37 +0000 (03:34 +0000)]
html.c: rendering of BLOCKQUOTE sections is now
more Citadel-like and less AOL-like.  Happy happy joy joy.

17 years agoIMAP COPY messages in bulk. I think it works
Art Cancro [Thu, 18 May 2006 03:08:26 +0000 (03:08 +0000)]
IMAP COPY messages in bulk.   I think it works
but it needs lots more testing.

17 years agoCtdlSaveMsgPointerInRoom() is now a simple wrapper around
Art Cancro [Wed, 17 May 2006 03:49:57 +0000 (03:49 +0000)]
CtdlSaveMsgPointerInRoom() is now a simple wrapper around
the new CtdlSaveMsgPointersInRoom() which can accept a list of
message pointers instead of a single one.  This is being written
with IMAP optimization in mind.  It has not been extensively tested.
Do not run production on this code yetsvn commit -m "CtdlSaveMsgPointerInRoom() is now a simple wrapper around
the new CtdlSaveMsgPointersInRoom() which can accept a list of
message pointers instead of a single one.  This is being written
with IMAP optimization in mind.  It has not been extensively tested.

17 years agoSmall change to a log message
Art Cancro [Tue, 16 May 2006 01:58:33 +0000 (01:58 +0000)]
Small change to a log message

18 years agoDon't compute existing length of WC->preferences when it
Art Cancro [Wed, 10 May 2006 02:05:47 +0000 (02:05 +0000)]
Don't compute existing length of WC->preferences when it
is NULL.  This was causing webcit to crash during new user creation.

18 years agoFixed the PLAIN auth method in SMTP so that it accepts
Art Cancro [Tue, 9 May 2006 03:33:21 +0000 (03:33 +0000)]
Fixed the PLAIN auth method in SMTP so that it accepts
the username/password either inline (like Thunderbird does it) or multistate (like Pine
does it).

18 years agoCall endtls() when an HTTP session ends normally -- not
Art Cancro [Mon, 8 May 2006 03:30:49 +0000 (03:30 +0000)]
Call endtls() when an HTTP session ends normally -- not
just when it sends abnormally.  This fixes that huge memory
leak I've been trying to find all this time.

18 years agomime_parser.c: updated some of the comments
Art Cancro [Thu, 4 May 2006 18:12:08 +0000 (18:12 +0000)]
mime_parser.c: updated some of the comments

18 years agomime_parser.c: pad the encoded-to-unencoded buffer
Art Cancro [Wed, 3 May 2006 03:29:12 +0000 (03:29 +0000)]
mime_parser.c: pad the encoded-to-unencoded buffer
a bit more, because certain MIME parts (such as tnef) were blowing the target
buffer.  This fixes a problem whose symptom is a server crash during fulltext
indexing.

18 years agomime_parser.c: pad the encoded-to-unencoded buffer
Art Cancro [Wed, 3 May 2006 03:27:19 +0000 (03:27 +0000)]
mime_parser.c: pad the encoded-to-unencoded buffer
a bit more, because certain MIME parts (such as tnef) were blowing the target
buffer.  This fixes a problem whose symptom is a server crash during fulltext
indexing.

18 years agowebcit_before_automake is now the trunk
Art Cancro [Tue, 2 May 2006 14:36:00 +0000 (14:36 +0000)]
webcit_before_automake is now the trunk

18 years agoautomake build is now a branch
Art Cancro [Tue, 2 May 2006 14:35:25 +0000 (14:35 +0000)]
automake build is now a branch

18 years agosrc/crypto.c: possible fix for memory leak related
Art Cancro [Tue, 2 May 2006 02:58:22 +0000 (02:58 +0000)]
src/crypto.c: possible fix for memory leak related
to OpenSSL.  See http://bugs.php.net/bug.php?id=36480 for more info.

18 years agopo update
Art Cancro [Tue, 2 May 2006 02:39:14 +0000 (02:39 +0000)]
po update

18 years agoAdded /static/webcit-tinymce.css which is applied when
Art Cancro [Wed, 26 Apr 2006 02:58:14 +0000 (02:58 +0000)]
Added /static/webcit-tinymce.css which is applied when
TinyMCE is called from WebCit.  Configured it to use a 10pt font in
the editor window instead of the tiny font.

18 years agoAdded /static/webcit-tinymce.css which is applied when
Art Cancro [Wed, 26 Apr 2006 02:58:00 +0000 (02:58 +0000)]
Added /static/webcit-tinymce.css which is applied when
TinyMCE is called from WebCit.  Configured it to use a 10pt font in
the editor window instead of the tiny font.

18 years agoIMAP FETCH operations now check before every iteration
Art Cancro [Tue, 25 Apr 2006 15:23:52 +0000 (15:23 +0000)]
IMAP FETCH operations now check before every iteration
of the per-message loop, whether CC->kill_me is set.  The loop is aborted
if the session has been marked for cancellation, which usually happens
because the user cancelled out while the FETCH was still in progress.

18 years agoMinor fixes to set_preference() in preferences.c
Art Cancro [Mon, 24 Apr 2006 15:01:29 +0000 (15:01 +0000)]
Minor fixes to set_preference() in preferences.c

18 years agotraces and troubleshooting on pref save during logout
Art Cancro [Fri, 21 Apr 2006 21:42:05 +0000 (21:42 +0000)]
traces and troubleshooting on pref save during logout

18 years agofixed nls available output message (thought I did this already)
Art Cancro [Fri, 21 Apr 2006 19:25:48 +0000 (19:25 +0000)]
fixed nls available output message (thought I did this already)

18 years agoFix tab label
Art Cancro [Fri, 21 Apr 2006 19:17:29 +0000 (19:17 +0000)]
Fix tab label

18 years agoAdded the 'Nifty Corners' library and implemented our
Art Cancro [Fri, 21 Apr 2006 03:20:10 +0000 (03:20 +0000)]
Added the 'Nifty Corners' library and implemented our
tabbed dialog with it.

18 years ago* [debian] depend on the locale packages.
Wilfried Göesgens [Wed, 19 Apr 2006 23:05:41 +0000 (23:05 +0000)]
* [debian] depend on the locale packages.

18 years ago* [debian] just sugest the server, as we don't need it to be installed localy.
Wilfried Göesgens [Wed, 19 Apr 2006 21:06:03 +0000 (21:06 +0000)]
* [debian] just sugest the server, as we don't need it to be installed localy.

18 years ago* fresh copy of the automake environment.
Wilfried Göesgens [Wed, 19 Apr 2006 19:48:55 +0000 (19:48 +0000)]
* fresh copy of the automake environment.

18 years ago* sort the libs in other direction
Wilfried Göesgens [Wed, 19 Apr 2006 19:47:34 +0000 (19:47 +0000)]
* sort the libs in other direction
* some additions in the debian build.

18 years agoConvert es.po to UTF-8
Art Cancro [Wed, 19 Apr 2006 04:01:09 +0000 (04:01 +0000)]
Convert es.po to UTF-8

18 years agoAdded es_ES.po
Art Cancro [Wed, 19 Apr 2006 03:46:38 +0000 (03:46 +0000)]
Added es_ES.po

18 years agoRemoved the old NLS output from the configure.in summary,
Art Cancro [Tue, 18 Apr 2006 17:01:07 +0000 (17:01 +0000)]
Removed the old NLS output from the configure.in summary,
and replaced with the new one.

18 years agoTHIS IS 6.81
Art Cancro [Mon, 17 Apr 2006 14:26:10 +0000 (14:26 +0000)]
THIS IS 6.81

18 years agothese ones where missing.
Wilfried Göesgens [Sun, 16 Apr 2006 15:36:11 +0000 (15:36 +0000)]
these ones where missing.

18 years ago* don't call autogen in buildpackages script.
Wilfried Göesgens [Sun, 16 Apr 2006 15:28:29 +0000 (15:28 +0000)]
* don't call autogen in buildpackages script.

18 years ago* added various files generated by autogen.sh, because of problems with autogen on...
Wilfried Göesgens [Sun, 16 Apr 2006 15:21:12 +0000 (15:21 +0000)]
* added various files generated by autogen.sh, because of problems with autogen on several systems.

18 years ago* renamed the openldap file, as in the package.
Wilfried Göesgens [Sat, 15 Apr 2006 20:18:21 +0000 (20:18 +0000)]
* renamed the openldap file, as in the package.

18 years ago* though POTFILES is automatically generated on newer
Wilfried Göesgens [Sat, 15 Apr 2006 12:28:12 +0000 (12:28 +0000)]
* though POTFILES is automatically generated on newer
  systems from POTFILES.in, we add it for the older ones.

18 years agoVersion 6.81
Art Cancro [Fri, 14 Apr 2006 03:20:26 +0000 (03:20 +0000)]
Version 6.81

18 years agowebserver.c: bind to LOCALEDIR for message catalog.
Art Cancro [Fri, 14 Apr 2006 02:57:16 +0000 (02:57 +0000)]
webserver.c: bind to LOCALEDIR for message catalog.

18 years agoserv_network.c: moved a call to CtdlFreeMessage() out one nesting
Art Cancro [Wed, 12 Apr 2006 14:40:33 +0000 (14:40 +0000)]
serv_network.c: moved a call to CtdlFreeMessage() out one nesting
level to avoid prematurely freeing a message when spooling it
to more than one node.

18 years agonewinstall.sh: if 'dialog' not found or unusable, try 'cdialog'
Art Cancro [Mon, 10 Apr 2006 18:24:22 +0000 (18:24 +0000)]
newinstall.sh: if 'dialog' not found or unusable, try 'cdialog'

18 years ago* fix freebsd build.
Wilfried Göesgens [Sun, 9 Apr 2006 21:30:25 +0000 (21:30 +0000)]
* fix freebsd build.

18 years agoUpdated version number to 6.80
Art Cancro [Fri, 7 Apr 2006 17:19:13 +0000 (17:19 +0000)]
Updated version number to 6.80

18 years agoeasy install: changed tar -xvf to tar -xf, less verbosity
Art Cancro [Fri, 7 Apr 2006 16:11:23 +0000 (16:11 +0000)]
easy install: changed tar -xvf to tar -xf, less verbosity

18 years agoThe hunt for 'dialog' requires one that supports the 'gauge' mode
Art Cancro [Fri, 7 Apr 2006 16:09:33 +0000 (16:09 +0000)]
The hunt for 'dialog' requires one that supports the 'gauge' mode

18 years agonewinstall.sh is GPL v2
Art Cancro [Fri, 7 Apr 2006 15:50:29 +0000 (15:50 +0000)]
newinstall.sh is GPL v2

18 years agoInternal version number is now 6.80
Art Cancro [Fri, 7 Apr 2006 15:33:28 +0000 (15:33 +0000)]
Internal version number is now 6.80

18 years agowe need to call another shellscript now.
Wilfried Göesgens [Thu, 6 Apr 2006 23:43:18 +0000 (23:43 +0000)]
we need to call another shellscript now.

18 years agomore modern version.
Wilfried Göesgens [Thu, 6 Apr 2006 22:05:35 +0000 (22:05 +0000)]
more modern version.

18 years agoFixed the 'add new note' button not woring
Art Cancro [Thu, 6 Apr 2006 21:18:24 +0000 (21:18 +0000)]
Fixed the 'add new note' button not woring
when there were already no notes on the page.

18 years agoserv_smtp.c: when sending out mail, try EHLO first, then HELO
Art Cancro [Thu, 6 Apr 2006 20:27:06 +0000 (20:27 +0000)]
serv_smtp.c: when sending out mail, try EHLO first, then HELO

18 years ago* missing flag for libiconv added to the linker flags.
Wilfried Göesgens [Wed, 5 Apr 2006 22:19:35 +0000 (22:19 +0000)]
* missing flag for libiconv added to the linker flags.

18 years agoReceived our 'enterprise number' 1.3.6.1.4.1.25404 from IANA.
Art Cancro [Wed, 5 Apr 2006 02:07:41 +0000 (02:07 +0000)]
Received our 'enterprise number' 1.3.6.1.4.1.25404 from IANA.
Updated our LDAP schema.

18 years agooops, there were remnants of a temporary hack
Art Cancro [Tue, 4 Apr 2006 18:36:44 +0000 (18:36 +0000)]
oops, there were remnants of a temporary hack
to ft_wordbreaker.h in the previous commit.  fixed.

18 years agoIn r3487 we had set the master listening sockets to
Art Cancro [Tue, 4 Apr 2006 18:29:19 +0000 (18:29 +0000)]
In r3487 we had set the master listening sockets to
non-blocking in order to avoid locking up the server when select() returns
but accept() does not.  This sets the individual connection sockets to non
blocking as well.  Now, the individual sockets are set back to blocking mode.
This prevents certain network operations from barfing when running on
FreeBSD.

18 years agoWhen client_write() fails, display the byte count as well.
Art Cancro [Tue, 4 Apr 2006 17:09:30 +0000 (17:09 +0000)]
When client_write() fails, display the byte count as well.

18 years agowhen client_write() fails, display the error
Art Cancro [Tue, 4 Apr 2006 16:53:30 +0000 (16:53 +0000)]
when client_write() fails, display the error
string and its number