Wilfried Göesgens [Sun, 31 Jan 2010 15:04:07 +0000 (15:04 +0000)]
* don't re-load vcards, if the server already sent them.
Wilfried Göesgens [Sun, 31 Jan 2010 14:45:51 +0000 (14:45 +0000)]
* we don't even compile this, OFF WITH ITS HEAD!
Dave West [Sat, 30 Jan 2010 16:11:50 +0000 (16:11 +0000)]
Attempt to fix the crash that results from a new sessions context
not existing before the command loop is entered.
This fixes a theoretical non atomic opperation but does not seem
to cause unwanted side effects. Lets see if it cures the problem
on those systems that are seeing it regularly.
Wilfried Göesgens [Fri, 29 Jan 2010 14:17:00 +0000 (14:17 +0000)]
* get the pointer after we sent the greating, its NULL in advance.
Wilfried Göesgens [Thu, 28 Jan 2010 23:38:03 +0000 (23:38 +0000)]
* int/long 64 bit blabla *narf*
Wilfried Göesgens [Wed, 27 Jan 2010 23:35:41 +0000 (23:35 +0000)]
* be more accurate, len needs to be at least sizeof(magic)
Wilfried Göesgens [Wed, 27 Jan 2010 23:23:58 +0000 (23:23 +0000)]
* checking whether cdb->len == 0 was missing as abort precondition
Art Cancro [Tue, 26 Jan 2010 05:14:24 +0000 (05:14 +0000)]
* played with message numbers a bit in preparation for tweaking the bbs view again
Art Cancro [Mon, 25 Jan 2010 15:31:11 +0000 (15:31 +0000)]
* html2ascii now renders *bold* and /italic/ and _underlined_ text as shown here.
Wilfried Göesgens [Sun, 24 Jan 2010 21:59:37 +0000 (21:59 +0000)]
* merge from dav_rework:
* modularize the parser for load_msg_ptrs
* add parser that has the euid
* add work on the URL parsers
* unfinished: new propfind; is #ifdefed
Art Cancro [Sun, 24 Jan 2010 21:49:51 +0000 (21:49 +0000)]
* svn id tag
Art Cancro [Sun, 24 Jan 2010 21:49:14 +0000 (21:49 +0000)]
* svn id tag
Wilfried Göesgens [Sun, 24 Jan 2010 11:11:37 +0000 (11:11 +0000)]
* merge in much of the dav_rework branch: (the drift was becoming to big, no functional changes)
* make configure search for cunit
* rename struct floor to Floor, since floor was already taken by math.h
* move over most of the functions from webserver.c to sysdep.c so main() is isolated and more easy to be replaced by another main in a test-suite-binary
* add first unit test implementations
- test the LANG header parser
- start testing the floor evaluation
Wilfried Göesgens [Fri, 22 Jan 2010 21:55:22 +0000 (21:55 +0000)]
* add literal support to imap login / passwords; this should fix our communication with nginx as proxy.
Wilfried Göesgens [Fri, 22 Jan 2010 19:21:15 +0000 (19:21 +0000)]
* port our setuid function from citserver to webcit; -u can now specify the UID to run as
Art Cancro [Wed, 20 Jan 2010 15:50:18 +0000 (15:50 +0000)]
Session SMTP data is null. WTF? We will crash now.
Art Cancro [Tue, 19 Jan 2010 04:42:13 +0000 (04:42 +0000)]
* Replaced older/newer messages buttons with previous/next 20/50/100 buttons
Art Cancro [Tue, 19 Jan 2010 04:40:42 +0000 (04:40 +0000)]
* Replaced older/newer messages buttons with previous/next 20/50/100 buttons
Art Cancro [Sun, 17 Jan 2010 23:12:55 +0000 (23:12 +0000)]
* Fixed another fread() bug
Wilfried Göesgens [Sun, 17 Jan 2010 23:01:50 +0000 (23:01 +0000)]
* add function to check whether a token parameter would give us a string
* add preeval-grammer check for the tabbed api
Wilfried Göesgens [Sun, 17 Jan 2010 21:38:48 +0000 (21:38 +0000)]
* fix all those tiny bugs pointed out by our new subtemplate checking
Wilfried Göesgens [Sun, 17 Jan 2010 21:18:13 +0000 (21:18 +0000)]
* check whether a template exists
* ITERATE now recommends the token parameter to actualy be marked as such.
Art Cancro [Sat, 16 Jan 2010 22:49:46 +0000 (22:49 +0000)]
* Fixed some more of the things that broke in r8201.
NOTE: fread() returns the number of BLOCKS read, not the number of BYTES read.
Wilfried Göesgens [Sat, 16 Jan 2010 16:54:08 +0000 (16:54 +0000)]
* add macro to register defines with just a define as param
* flip the Current room QR-Flag conditionals to _one_ conditional working with a parameter
* make the templates follow that change.
Wilfried Göesgens [Sat, 16 Jan 2010 15:26:33 +0000 (15:26 +0000)]
* if the config room has another view than VIEW_BBS, set it. Else it might stop us from saving our Config.
Wilfried Göesgens [Sat, 16 Jan 2010 14:11:05 +0000 (14:11 +0000)]
* memset(0) the folders, else we might struggle...
Art Cancro [Sat, 16 Jan 2010 05:11:09 +0000 (05:11 +0000)]
* When a 'read new' operation returns zero messages, make the 'older messages' link available to start reading old messages from the end instead of the beginning of the room.
Art Cancro [Sat, 16 Jan 2010 05:00:19 +0000 (05:00 +0000)]
* the JavaScript code for the new BBS view has been moved out of bbs_renderer.c and into static/wclib.js where it belongs.
Art Cancro [Fri, 15 Jan 2010 02:58:13 +0000 (02:58 +0000)]
* fixed some log messages that still had color in them. That doesn't belong in the tree. Sorry...
Art Cancro [Fri, 15 Jan 2010 02:52:33 +0000 (02:52 +0000)]
* When an outgoing message being delivered via SMTP does not properly terminate, don't just log a warning, but also output an extra CRLF so that the dot terminator on the next line is handled by the receiver.
Wilfried Göesgens [Thu, 14 Jan 2010 23:02:29 +0000 (23:02 +0000)]
* uninitialized...
Wilfried Göesgens [Thu, 14 Jan 2010 22:55:31 +0000 (22:55 +0000)]
* unititialized var...
Wilfried Göesgens [Thu, 14 Jan 2010 21:46:39 +0000 (21:46 +0000)]
* create function to parse the output of goto into our folder structure
* migrate wcsessions goto fragments to a static folder instance 'CurRoom'
* make all places follow that change
* use the room structure in goto_config_room
Wilfried Göesgens [Thu, 14 Jan 2010 21:41:32 +0000 (21:41 +0000)]
* ignore .swp and .orig files so some more void files won't make it into our template repository.
Wilfried Göesgens [Thu, 14 Jan 2010 20:37:44 +0000 (20:37 +0000)]
* flip sequence, C99 Baby!
Art Cancro [Wed, 13 Jan 2010 21:38:05 +0000 (21:38 +0000)]
* Removed some cruft leftover from the old bbs view
Art Cancro [Wed, 13 Jan 2010 20:35:30 +0000 (20:35 +0000)]
* Removed some cruft leftover from the old bbs view
Art Cancro [Wed, 13 Jan 2010 04:50:31 +0000 (04:50 +0000)]
* Removed the extra log message now that the bug is fixed
Art Cancro [Wed, 13 Jan 2010 00:08:13 +0000 (00:08 +0000)]
* fixed a bug in network_process_file() that was causing every message to be loaded into a buffer with a length of 1 byte.
Art Cancro [Wed, 13 Jan 2010 00:04:15 +0000 (00:04 +0000)]
* Added some more diagnostics to serv_network.c -- troubleshooting a problem
Wilfried Göesgens [Tue, 12 Jan 2010 21:02:26 +0000 (21:02 +0000)]
* fix memleak
* fix template reference
Wilfried Göesgens [Tue, 12 Jan 2010 19:17:09 +0000 (19:17 +0000)]
* upsi, some links to templates which didn't follow the moving action
Wilfried Göesgens [Sun, 10 Jan 2010 22:16:34 +0000 (22:16 +0000)]
* remove xtoi, its not used anymore.
Wilfried Göesgens [Sun, 10 Jan 2010 21:54:10 +0000 (21:54 +0000)]
* fix server cookie feature
Wilfried Göesgens [Sun, 10 Jan 2010 21:17:44 +0000 (21:17 +0000)]
* use the HexEscAppend thing instead of printf appending...
* move some cookie logic over
Wilfried Göesgens [Sun, 10 Jan 2010 21:14:15 +0000 (21:14 +0000)]
* hm, something is going wrong here. allocing bigger spaces here for filenames fixes it, fancily even valgrind doesn't show whats going wrong...
Wilfried Göesgens [Sun, 10 Jan 2010 21:12:04 +0000 (21:12 +0000)]
* add function to append strings encoding them in hex digits; this is basicaly a stripped down copy of the url escaper.
Wilfried Göesgens [Sun, 10 Jan 2010 21:09:07 +0000 (21:09 +0000)]
* fix memleak: free our message area if alloced
Dave West [Sun, 10 Jan 2010 12:41:01 +0000 (12:41 +0000)]
Fix race condition that caused segfaults in imap and xmpp as seen on
uncensored.
The race was that a new connection could begin doing its greeting
function and another thread could begin the connections command loop
function before the greeting had completed setting up the connection
environment.
Art Cancro [Thu, 7 Jan 2010 15:52:39 +0000 (15:52 +0000)]
* Made the 'older messages' and 'newer messages' link text just a bit smaller. It was looking obnoxious at the previous size.
* Also configured those links to turn to a red background when the mouse hovers over them
Art Cancro [Wed, 6 Jan 2010 21:50:59 +0000 (21:50 +0000)]
* Modified configure.ac to look for gc/gc_local_alloc.h instead of gc/gc.h, since the former is what the source code is actually calling for. THIS HEADER DOES NOT APPEAR IN RED HAT OR CENTOS BUILDS OF LIBGC. Why is this in here at all?
Wilfried Göesgens [Wed, 6 Jan 2010 21:39:13 +0000 (21:39 +0000)]
* make static/ install recurseable
Art Cancro [Wed, 6 Jan 2010 20:24:26 +0000 (20:24 +0000)]
* Cleaned up the HTML and CSS for the new bbs view.
Wilfried Göesgens [Tue, 5 Jan 2010 23:29:18 +0000 (23:29 +0000)]
* read reply....
Wilfried Göesgens [Tue, 5 Jan 2010 23:07:05 +0000 (23:07 +0000)]
as
modules/wiki/serv_wiki.c: In function 'wiki_rev_callback':
modules/wiki/serv_wiki.c:447: warning: cast from pointer to integer of different size
modules/wiki/serv_wiki.c:447: warning: cast from pointer to integer of different size
points out, this wasn't 64 bit clean.
Wilfried Göesgens [Tue, 5 Jan 2010 23:01:35 +0000 (23:01 +0000)]
* want if mkdir, chmod, chown fail...
Wilfried Göesgens [Tue, 5 Jan 2010 22:58:11 +0000 (22:58 +0000)]
* memset config before reading it
* warn if the file didn't have the size we expected
Wilfried Göesgens [Tue, 5 Jan 2010 22:21:48 +0000 (22:21 +0000)]
* only warn if they didn't already exist
Wilfried Göesgens [Tue, 5 Jan 2010 22:01:37 +0000 (22:01 +0000)]
* use the results of fread instead of trusting that it worked out
* check (and log if not) we were able to mkdir & chown our spool directories
Wilfried Göesgens [Tue, 5 Jan 2010 21:59:47 +0000 (21:59 +0000)]
* make it const where possible...
* cast into openssl, they want unsigned char * (why?)
Wilfried Göesgens [Sun, 3 Jan 2010 23:49:17 +0000 (23:49 +0000)]
* some more work on unit testing
Wilfried Göesgens [Sun, 3 Jan 2010 23:48:21 +0000 (23:48 +0000)]
* allow mime header sub tokens to have blanks left and right of the =
Wilfried Göesgens [Sun, 3 Jan 2010 23:44:40 +0000 (23:44 +0000)]
* some more input condition sanitizing
Wilfried Göesgens [Sat, 2 Jan 2010 23:24:54 +0000 (23:24 +0000)]
* rewrite memfmout() so it doesn't split overlong lines; It now will try to output everything till the last blank, and reattempt with the next line; if that doesn't work the overlong string is outputt'ed
Wilfried Göesgens [Sat, 2 Jan 2010 23:22:37 +0000 (23:22 +0000)]
* add cputbuf which outputs a StrBuf to the client
Wilfried Göesgens [Sat, 2 Jan 2010 19:49:13 +0000 (19:49 +0000)]
* remove replace part of memfmout(); its not used anymore anyways
Wilfried Göesgens [Fri, 1 Jan 2010 15:53:29 +0000 (15:53 +0000)]
* fix some logmessages, so not we output the right information
Wilfried Göesgens [Fri, 1 Jan 2010 15:39:28 +0000 (15:39 +0000)]
* is_mobile evaluation is wrong here, since we're -1 or 0 if not / undetected; so we have to compare whether not 1
Art Cancro [Fri, 1 Jan 2010 07:05:49 +0000 (07:05 +0000)]
* Updated the citserver and webcit initialization banners to output a copyright date whose range now ends in 2010. Everyone please remember to update the copyright banner on each individual file if you're the first one to touch that file in 2010.
Art Cancro [Thu, 31 Dec 2009 20:27:13 +0000 (20:27 +0000)]
* Minor cleanups to bbs view
Art Cancro [Thu, 31 Dec 2009 20:14:43 +0000 (20:14 +0000)]
* The new BBS view is now complete. Share And Enjoy
Wilfried Göesgens [Thu, 31 Dec 2009 10:26:57 +0000 (10:26 +0000)]
* By Mcbrittmat:
* add the room extraction mechanisms to groupdav_delete as to the other rooms
* make it actualy send the request answer with end_boost
Art Cancro [Wed, 30 Dec 2009 22:38:05 +0000 (22:38 +0000)]
* Enhance the older/newer logic. It's still not quite right.
Art Cancro [Wed, 30 Dec 2009 21:34:26 +0000 (21:34 +0000)]
* Renamed 'morediv' to 'newerdiv'
Art Cancro [Wed, 30 Dec 2009 21:32:00 +0000 (21:32 +0000)]
* The javascript 'moremsgs()' function now accepts any msgs subcommand instead of hardcoding 'gt'
Art Cancro [Wed, 30 Dec 2009 18:13:37 +0000 (18:13 +0000)]
* Version number to 7.80
* Required Citadel server version also set to 7.80, because I am about to write some code which requires a new server command
Art Cancro [Wed, 30 Dec 2009 18:10:05 +0000 (18:10 +0000)]
* Added a new 'MSGS LT' subcommand
* Version number to 7.80
Art Cancro [Wed, 30 Dec 2009 18:00:56 +0000 (18:00 +0000)]
* Cleaned up the logic at the end of the bbsview display. Still not sure what we should do here. Maybe an auto-update?
Art Cancro [Wed, 30 Dec 2009 17:39:56 +0000 (17:39 +0000)]
* Moved begin_ajax_response() to bbsview_PrintViewHeader() where it belongs. This fixes the screen corruption that was happening when a 'no more messages' condition is reached.
Art Cancro [Wed, 30 Dec 2009 16:44:53 +0000 (16:44 +0000)]
* Cleaned up the look of the 'more' link in the new BBS view
Wilfried Göesgens [Tue, 29 Dec 2009 18:07:36 +0000 (18:07 +0000)]
* apply r8166 from the davrework-branch:
* make the template loader recursive; now t/ can contain subdirectories
* create the template key from the directory relative to t/ with '/' seperated by _ :
* t/knrooms/rooms.html is represented as knrooms_rooms so it would be equal to t/knrooms_rooms.html
* have an optional dbg/ directory next to t; this will be used for creating special templates for debugging / testing
Wilfried Göesgens [Tue, 29 Dec 2009 13:23:00 +0000 (13:23 +0000)]
* add the needed parameters to knrooms calls in two more templates
* thanks easku1234 for reporting
Wilfried Göesgens [Mon, 28 Dec 2009 15:48:12 +0000 (15:48 +0000)]
* reorganize some templates into subdirectories
* addopt new template names
Thats the move list:
display_aide_menu.html aide/display_menu.html aide_display_menu
display_ignet_confirmdelete.html aide/ignetconf/display_confirm_delete.html aide_ignetconf_display_confirm_delete
edit_node.html aide/ignetconf/edit_node.html aide_ignetconf_edit_node
section_ignetconf.html aide/ignetconf/section.html aide_ignetconf_section
add_node.html aide/ignetconf/add.html aide_ignetconf_add
display_netconf.html aide/display_ignetconf.html aide_display_ignetconf
display_sitewide_config.html aide aide_display_sitewide_config
tab_siteconfig_access.html aide/siteconfig/tab_access.html aide_siteconfig_tab_access
tab_siteconfig_autopurger.html aide/siteconfig/tab_autopurger.html aide_siteconfig_tab_autopurger
tab_siteconfig_directory.html aide/siteconfig/tab_directory.html aide_siteconfig_tab_directory
tab_siteconfig_general.html aide/siteconfig/tab_general.html aide_siteconfig_tab_general
tab_siteconfig_indexing.html aide/siteconfig/tab_indexing.html aide_siteconfig_tab_indexing
tab_siteconfig_network.html aide/siteconfig/tab_network.html aide_siteconfig_tab_network
tab_siteconfig_pop3.html aide/siteconfig/tab_pop3.html aide_siteconfig_tab_pop3
tab_siteconfig_pushmail.html aide/siteconfig/tab_pushmail.html aide_siteconfig_tab_pushmail
tab_siteconfig_tuning.html aide/siteconfig/tab_tuning.html aide_siteconfig_tab_tuning
siteconfig_tzsection.html aide/siteconfig/tzsection.html aide_siteconfig_tzsection
submit_siteconfig.html aide/siteconfig/submit.html aide_siteconfig_submit
aide_inetconf.html aide/display_inetconf.html aide_display_inetconf
aide_inet_aliases.html aide/inet/aliases.html
aide_inet_clamav.html aide/inet/clamav.html
aide_inet_dirnames.html aide/inet/dirnames.html
aide_inet_fallbackhosts.html aide/inet/fallbackhosts.html
aide_inet_masqdomains.html aide/inet/masqdomains.html
aide_inet_notify.html aide/inet/notify.html
aide_inet_rbldns.html aide/inet/rbldns.html
aide_inet_smarthosts.html aide/inet/smarthosts.html
aide_inet_spamass.html aide/inet/spamass.html
page_now.html paging/now.html paging_now
paging_anchor.html paging/anchor.html paging_anchor
paging_failed_hook.html paging/failed_hook.html paging_failed_hook
display_serverrestartpage.html aide/display_serverrestart_page.html aide_display_serverrestart_page
display_serverrestart.html aide
display_serverrestartpagedo.html aide/display_serverrestart_page_do.html
box_serverrestart.html aide/serverrestart/box.html
box_serverrestartpage.html aide/serverrestart/box_page.html
box_serverrestartpagedo.html aide/serverrestart/box_page_do.html
section_files_onefile.html files/section_onefile.html files_section_onefile
files_jspicview.html files/picview.js
pushemail.html prefs/pushemail.html prefs_pushemail
section_userlist_select.html aide/edituser/section.html
edituser_select.html aide/edituser/select.html aide_edituser_select
edituser_add.html aide/edituser/add.html aide_edituser_add
userlist_detailview.html aide/edituser/detailview.html aide_edituser_detailview
wholist_section.html who/iconbar.html who_iconbar
whosimplesection.html who/iconbar_section.html who_iconbar_section
wholiststatic_header.html who/list_static_header.html
wholiststatic.html who/box_list_static.html
wholistsummarysection.html who/summary.html who_summary
whosummarysection.html who/summary_section.html who_summary_section
whosection.html who/bla_list_section.html
Wilfried Göesgens [Sat, 26 Dec 2009 15:12:42 +0000 (15:12 +0000)]
* apply R8157 from the dav-rework branch:
* make the template loader recursive; now t/ can contain subdirectories
* create the template key from the directory relative to t/ with '/' seperated by _ :
* t/knrooms/rooms.html is represented as knrooms_rooms so it would be equal to t/knrooms_rooms.html
* have an optional dbg/ directory next to t; this will be used for creating special templates for debugging / testing
Michael Hampton [Wed, 23 Dec 2009 18:41:20 +0000 (18:41 +0000)]
Switch to 4096 bit Diffie-Hellman parameters for Citadel text client/protocol
Art Cancro [Tue, 22 Dec 2009 17:31:11 +0000 (17:31 +0000)]
* Some RSS feeds are tagged as <rdf> instead of <rss>. Handle these as RSS instead of discarding them.
Wilfried Göesgens [Tue, 22 Dec 2009 15:43:42 +0000 (15:43 +0000)]
* wrong evaluation of return value; we're actualy _expecting_ 4xx instead of !4xx
Wilfried Göesgens [Mon, 21 Dec 2009 12:41:20 +0000 (12:41 +0000)]
* make shure the buffer is cleared
* if the result is unexpected, log an error
Wilfried Göesgens [Mon, 21 Dec 2009 12:38:16 +0000 (12:38 +0000)]
* apply the release stuff to head too from r8127
Wilfried Göesgens [Sun, 20 Dec 2009 22:42:13 +0000 (22:42 +0000)]
* fix StrBufNum_tokens
* add some more tests for the tokenizer
* add some tests to check StrBufCutRight, StrBufCutLeft, StrBufCutAt; Make them NULL aware
Wilfried Göesgens [Sat, 19 Dec 2009 21:45:10 +0000 (21:45 +0000)]
* init the pointer, so we don't use random ones here
Michael Hampton [Sat, 19 Dec 2009 00:02:37 +0000 (00:02 +0000)]
Allow citadel / libcitadel to be built outside their source directory, e.g.:
mkdir build/citadel; cd build/citadel; ../../src/citadel/configure; make
Wilfried Göesgens [Fri, 18 Dec 2009 08:07:02 +0000 (08:07 +0000)]
* by matt:
* add RA-Flags token
* use RA flags to detect whether a room has new messages or not in the room treeview; this was using QRFlags by mistake
Wilfried Göesgens [Tue, 15 Dec 2009 20:27:01 +0000 (20:27 +0000)]
* fix StrBufIsNumber; its not used right now, but it should be sane ;-)
* add more tests
Art Cancro [Mon, 14 Dec 2009 17:17:12 +0000 (17:17 +0000)]
* Merged the new BBS view code, with an ifdef around it. Define NEW_BBS_VIEW if you want to test it out. Unfinished.
Art Cancro [Mon, 14 Dec 2009 17:13:03 +0000 (17:13 +0000)]
* Silenced a couple more warn_unused_result warnings
Wilfried Göesgens [Sun, 13 Dec 2009 20:26:27 +0000 (20:26 +0000)]
* shuffle arround stuff a little bit
* move debug stuff into own functions so its a little cleaner
Wilfried Göesgens [Sun, 13 Dec 2009 19:05:04 +0000 (19:05 +0000)]
* more testcoverage
* found one input param check
Wilfried Göesgens [Sun, 13 Dec 2009 16:44:02 +0000 (16:44 +0000)]
* add (optional) gcov flags
Wilfried Göesgens [Sun, 13 Dec 2009 14:18:46 +0000 (14:18 +0000)]
* keep local pointers to SMTP as sSMTP instead of querying it on and on. Faster and better debuggable.