Dave West [Fri, 21 Mar 2008 21:42:54 +0000 (21:42 +0000)]
Did away with lprintf all together now its called CtdlLogPrintf()
This is a step towards the coding convention listed on the web site.
Art Cancro [Fri, 21 Mar 2008 20:09:41 +0000 (20:09 +0000)]
svn_revision() now declared in svn_revision.h
Dave West [Thu, 20 Mar 2008 20:48:13 +0000 (20:48 +0000)]
Bootstrap now calls mk_svn_revision.sh for the package builders.
Dave West [Thu, 20 Mar 2008 19:22:26 +0000 (19:22 +0000)]
Now the text client and webcit show the servers svn revision too.
Dave West [Thu, 20 Mar 2008 18:32:07 +0000 (18:32 +0000)]
Now the server records the SVN revision in the log at startup.
Dave West [Thu, 20 Mar 2008 15:39:58 +0000 (15:39 +0000)]
A test fix for the thread cancellation routine.
We only log situations where we would have cancelled a thread, we don't
actually cancel them.
With this code we should not see cancellation requests during normal
running.
Cancelation requests during normal running were due to threads being
asked to stop when load decreased but the idle thread detection aloud a
thread to be asked to stop just as select gave it a task and made it not
idle.
Now if select gives a thread a job to do and the thread was asked to
stop during the select the thread changes its state back to running and
refuses the stop request. This only happens if the system is NOT
shutting down.
Dave West [Thu, 20 Mar 2008 13:26:47 +0000 (13:26 +0000)]
Prevent cancellation of threads but log that we would have cancelled it.
Its causing problems on Uncensored.
Wilfried Göesgens [Thu, 20 Mar 2008 09:57:42 +0000 (09:57 +0000)]
* use snprintf to avoid stack corruption.
Wilfried Göesgens [Thu, 20 Mar 2008 09:08:38 +0000 (09:08 +0000)]
* init command buf empty to avoid fancy side effects
Wilfried Göesgens [Wed, 19 Mar 2008 23:19:38 +0000 (23:19 +0000)]
* this way arround some compilers like the casts better.
Art Cancro [Wed, 19 Mar 2008 19:41:58 +0000 (19:41 +0000)]
oops ... minor fix to above
Art Cancro [Wed, 19 Mar 2008 19:28:48 +0000 (19:28 +0000)]
EVT_LOGOUT hooks are now called with the thread's current
CitContext set to that of the session being logged out, even when
killing a session administratively. This allows the identity of the
user to be passed along to module hooks. This fixes the problem in
the Jabber server where buddy 'ghosts' whould remain visible to
clients if the user disconnected without logging off.
Art Cancro [Wed, 19 Mar 2008 17:46:00 +0000 (17:46 +0000)]
bmstrcasestr() now returns NULL if either of its supplied
arguments is NULL ... instead of passing NULL to strlen() and making
the program crash.
Dave West [Wed, 19 Mar 2008 17:31:31 +0000 (17:31 +0000)]
Auto purger thread was declaring itself as the indexer_thread() in the
log
Dave West [Tue, 18 Mar 2008 23:28:55 +0000 (23:28 +0000)]
When doing shutdown we allow each thread up to 5 seconds to exit on its
own after asking it nicely to do so. After 5 seconds we will cancel()
the thread. Its possible that we may loose messages in this manner
since its similar to a SIGTERM. Because of this we write messages to the
log about this event. If we are seeing these entries in the log we need
to track down why the thread is strugling to exit and fix it.
Dave West [Tue, 18 Mar 2008 21:58:56 +0000 (21:58 +0000)]
Moved remaining POP3 options onto the POP3 configuration tab
Dave West [Tue, 18 Mar 2008 21:50:25 +0000 (21:50 +0000)]
Added new POP3 client config options
Dave West [Tue, 18 Mar 2008 21:46:56 +0000 (21:46 +0000)]
Added code to handle new POP3 client config options.
Dave West [Tue, 18 Mar 2008 21:12:03 +0000 (21:12 +0000)]
Oops, managed to commit a partial change regarding the POP3 client
interval. Here is the rest of it.
Still to do are text client and documentation.
Dave West [Tue, 18 Mar 2008 21:05:27 +0000 (21:05 +0000)]
Added some more CtdlThreadCheckStop() calls to speed shutdown.
Dave West [Tue, 18 Mar 2008 20:56:43 +0000 (20:56 +0000)]
POP3 client now makes use of CtdlThreadCheckStop() to help speed
shutdowns.
Dave West [Tue, 18 Mar 2008 20:49:41 +0000 (20:49 +0000)]
RSS client now makes use of CtdlThreadCheckStop() to help speed up
shutdown.
Dave West [Tue, 18 Mar 2008 19:58:41 +0000 (19:58 +0000)]
Ignet now makes use of CtdlThreadCheckStop() to check if it should exit.
This should improve shutdown times.
Still need to be able to interrupt the syscalls for a full solution.
Art Cancro [Tue, 18 Mar 2008 19:15:08 +0000 (19:15 +0000)]
libical, expat, and libsieve are now *required*.
If any are missing, configure will abort, telling the user what is missing and
pointing them to the relevant page on our web site.
Dave West [Tue, 18 Mar 2008 15:18:14 +0000 (15:18 +0000)]
Missed one. Only need to use a copy of the context list here and
traverse it in a safe manner.
Dave West [Tue, 18 Mar 2008 15:01:22 +0000 (15:01 +0000)]
mrtg now reads the context list safely.
Dave West [Tue, 18 Mar 2008 15:00:28 +0000 (15:00 +0000)]
Jabber now reads the context list safely and it writes it safely too.
Dave West [Tue, 18 Mar 2008 14:59:28 +0000 (14:59 +0000)]
RWHO command uses new function to read the context list safely.
Dave West [Tue, 18 Mar 2008 14:58:28 +0000 (14:58 +0000)]
Created a routine to get a copy of the context list so that it can be
read safely at leasure.
Dave West [Tue, 18 Mar 2008 14:01:44 +0000 (14:01 +0000)]
Now the RWHO command processes the context list in a safe manner.
Dave West [Mon, 17 Mar 2008 23:35:42 +0000 (23:35 +0000)]
Re-ordered the sequence of checking email addresses against valid system
addresses. This allows us to have a GAB entry for rooms and allows
messages originating internally to be addressed to a room.
For the GAB lookup to work as expected the email address for the room
must be simply room_roomname without the @domain. If the domain part is
included the aliasing routines will translate it into the address of the
person who created the GAB entry.
This should fix bug #324.
Dave West [Mon, 17 Mar 2008 21:48:06 +0000 (21:48 +0000)]
Zero calls is possible, contrary to the comment so now we check for less
than zero.
Art Cancro [Mon, 17 Mar 2008 15:53:29 +0000 (15:53 +0000)]
Applied new nl.po translation
Art Cancro [Mon, 17 Mar 2008 15:11:49 +0000 (15:11 +0000)]
When dumping or scanning the wholist in the Jabber
service, only pay attention to sessions that have users logged
in. Doing otherwise exposes empty JID's that cause clients to
malfunction.
Wilfried Göesgens [Mon, 17 Mar 2008 07:20:50 +0000 (07:20 +0000)]
* corrected typo in iconv check
Wilfried Göesgens [Sun, 16 Mar 2008 14:45:30 +0000 (14:45 +0000)]
* use larger buffer for subject, as QP encoded subjects can get larger.
Art Cancro [Sat, 15 Mar 2008 03:57:51 +0000 (03:57 +0000)]
removed an unused variable
Art Cancro [Sat, 15 Mar 2008 03:54:55 +0000 (03:54 +0000)]
More reliable (hopefully) XMPP logout (unavailable +
unsubscribe + roster delete) notifications
Art Cancro [Sat, 15 Mar 2008 03:20:27 +0000 (03:20 +0000)]
New utility function convert_spaces_to_underscores()
We do this in a couple of different places so it's going into libcitadel.
Art Cancro [Fri, 14 Mar 2008 18:39:38 +0000 (18:39 +0000)]
Rewrote the sender/recipients/dsn display code in smtpqueue.c
This version avoids excessive strlen and displays the complete data.
Art Cancro [Fri, 14 Mar 2008 16:03:19 +0000 (16:03 +0000)]
Fixed missing display of messages in SMTP queue.
Wilfried Göesgens [Thu, 13 Mar 2008 23:45:06 +0000 (23:45 +0000)]
* download attachments too.
Wilfried Göesgens [Mon, 10 Mar 2008 22:00:14 +0000 (22:00 +0000)]
* abstract #ifdef HAVE_ICONV around utf8ify_rfc822_string to one place as they started spreadding all over the place
* de-QP email-attachment filenames
* put icon/mime logic into the attachment list
* if we have an application/octet-stream, try to guess the mime for the icon by its extension
Wilfried Göesgens [Mon, 10 Mar 2008 19:34:08 +0000 (19:34 +0000)]
* text interface for the recently added QR2 flags
Wilfried Göesgens [Mon, 10 Mar 2008 19:06:14 +0000 (19:06 +0000)]
* check for links if they exist before trying to create them
* don't abort if creating fails.
Art Cancro [Mon, 10 Mar 2008 18:18:43 +0000 (18:18 +0000)]
WebCit UI for user rename
Art Cancro [Mon, 10 Mar 2008 17:55:22 +0000 (17:55 +0000)]
Text mode user interface -- added UI for rename user
Wilfried Göesgens [Sun, 9 Mar 2008 22:03:20 +0000 (22:03 +0000)]
* don't search for null-lengthened strings.
Wilfried Göesgens [Sun, 9 Mar 2008 22:02:31 +0000 (22:02 +0000)]
* if we get a zero length line, skip the whole processing.
Art Cancro [Fri, 7 Mar 2008 20:01:54 +0000 (20:01 +0000)]
Added a RENU command (REName a User)
Wilfried Göesgens [Wed, 5 Mar 2008 18:13:06 +0000 (18:13 +0000)]
* first of the three sorts uses URLescputs, the second and third mustn't
* added way to easy make the debs disable zlib for sniffing
Art Cancro [Wed, 5 Mar 2008 04:16:09 +0000 (04:16 +0000)]
WebCit v7.34
Art Cancro [Wed, 5 Mar 2008 04:14:14 +0000 (04:14 +0000)]
Backed out changes in r6088 of addressbook_popup.c
The list may have been nicely sorted, but selecting addresses from the list
causes the names to have escaped HTML characters in them.
Wilfried Göesgens [Mon, 3 Mar 2008 21:34:08 +0000 (21:34 +0000)]
* removed unneeded DH-Targets.
Wilfried Göesgens [Mon, 3 Mar 2008 21:03:35 +0000 (21:03 +0000)]
* wrong number set
Wilfried Göesgens [Mon, 3 Mar 2008 20:57:57 +0000 (20:57 +0000)]
* THIS IS 7.33 / 1.08
Wilfried Göesgens [Sun, 2 Mar 2008 17:30:45 +0000 (17:30 +0000)]
* missing typo
Wilfried Göesgens [Sun, 2 Mar 2008 17:05:20 +0000 (17:05 +0000)]
* prefer the actual session id
* configure now will find iconv and friends in non-libc situations if its present in the LDFLAGS provided directories (i.e. -L /usr/local/lib/)
Wilfried Göesgens [Sun, 2 Mar 2008 14:20:45 +0000 (14:20 +0000)]
* make server_getln return the number of bytes it read
* sort Phonebook popup alphabeticaly
* sort Olson-Timezones alphabeticaly
* sort Who Is Online views first by Idle/Active then alphabetical
* move wholist_section summary.c -> who.c so we can easily use the above algorithms
Wilfried Göesgens [Sun, 2 Mar 2008 14:17:43 +0000 (14:17 +0000)]
* documented hashlist
* the user may now sort the array in his prefered way.
(this will mark the array tainted, and increase search times)
* several sort funcions:
* sort by the Hash-String
* sort by the Hashkey (untaints the array)
* sort by a user definable Comparator Function
Wilfried Göesgens [Sat, 1 Mar 2008 14:50:10 +0000 (14:50 +0000)]
* hack gnome iconsets in.
Wilfried Göesgens [Sat, 1 Mar 2008 12:52:23 +0000 (12:52 +0000)]
* Prepend our explicit warrant to link with openssl in the COPYING
* recommend shared-mime-info
Wilfried Göesgens [Sat, 1 Mar 2008 12:51:54 +0000 (12:51 +0000)]
* Prepend our explicit warrant to link with openssl in the COPYING
* recommend shared-mime-info
Wilfried Göesgens [Fri, 29 Feb 2008 19:18:18 +0000 (19:18 +0000)]
* html.c is in libcitadel now, don't try to compile it here.
Wilfried Göesgens [Thu, 28 Feb 2008 23:14:16 +0000 (23:14 +0000)]
* distribute the ldap schemata on make install-doc
Art Cancro [Thu, 28 Feb 2008 17:28:52 +0000 (17:28 +0000)]
html_to_ascii() moved into libcitadel
Wilfried Göesgens [Wed, 27 Feb 2008 23:10:42 +0000 (23:10 +0000)]
* don't double libcitadel header function for safestrncpy in webcit.h
* instead of dumb pointing to 255, search backwards from the copied amount of chars.
Wilfried Göesgens [Wed, 27 Feb 2008 23:06:49 +0000 (23:06 +0000)]
* safestrncpy counts the copied string anyway, and nobody needs the returned pointer
-> return a long
-> return the number of copied bytes.
-> return negative values if we hit the boundary.
Art Cancro [Wed, 27 Feb 2008 21:45:37 +0000 (21:45 +0000)]
When clicking on a contact's email address to send
them mail, put the display name inside quotes. This escapes any commas
which may be present. Resolves bug 271.
Art Cancro [Wed, 27 Feb 2008 21:38:05 +0000 (21:38 +0000)]
Multipart/alternative (possibly nested inside multipart/mixed)
Wilfried Göesgens [Wed, 27 Feb 2008 00:18:36 +0000 (00:18 +0000)]
* sample aproach to use the citadel commandline client html renderer to create a plaintext part for multipart alternative mails.
this is considered to be more polite to text users.
Art Cancro [Tue, 26 Feb 2008 17:04:39 +0000 (17:04 +0000)]
XMPP service ... remove from tech preview, as several
clients are now working. Also allow underscores in user names, which are converted to
spaces.
Wilfried Göesgens [Mon, 25 Feb 2008 23:03:09 +0000 (23:03 +0000)]
* refreshed translation files with new strings
* re-synced german translation
* one more x-flag in the buildpackages script
Wilfried Göesgens [Mon, 25 Feb 2008 22:23:24 +0000 (22:23 +0000)]
* dynamicdrive.com 's fadeshow can be triggered from within the webcit files app
Wilfried Göesgens [Mon, 25 Feb 2008 21:51:07 +0000 (21:51 +0000)]
* if we're in single-lang gettext mode, just show the locale root gave us in the select dialog.
Wilfried Göesgens [Mon, 25 Feb 2008 20:03:29 +0000 (20:03 +0000)]
* allow users to move messages into a room they're allowed to post to.
* this fixes #345
Wilfried Göesgens [Sun, 24 Feb 2008 22:40:03 +0000 (22:40 +0000)]
* use default configure options to find threadsafe locale
* if we don't have uselocale, opt out all functions / structs related to it.
* if LDFLAGS have: -lgettextlib -lgettextpo -lgettextsrc -liconv -lintl this detection seems to work
Wilfried Göesgens [Sun, 24 Feb 2008 21:26:35 +0000 (21:26 +0000)]
* hm, how could this get through? we don't have getpwuid_r on openbsd, and we already check it.
Wilfried Göesgens [Sun, 24 Feb 2008 15:13:49 +0000 (15:13 +0000)]
* collect sender / read / unread information for calendar items
* dislpay the sender in the bubbles
* set the event Class depending on read / unread state
* added some css classes to view this information
Wilfried Göesgens [Sat, 23 Feb 2008 18:43:41 +0000 (18:43 +0000)]
* add icon directory
* increment libcitadel required version
* modified hash debug printf; so we need to modify uses.
* display icons using our brand new mime to icon lookup facility
Wilfried Göesgens [Sat, 23 Feb 2008 18:37:23 +0000 (18:37 +0000)]
* fixed several crash / invalid data cases in the hash implementation
* add mimetype to icon facility
* fix some warnings in the deb-build
* bumped version no
Wilfried Göesgens [Wed, 20 Feb 2008 22:19:44 +0000 (22:19 +0000)]
* re-designed loop with strlen inside
* if validate_recipients hits bonus-blanks, ignore them.
* use snprintf even if we are shure our buffer is big enough.
Wilfried Göesgens [Wed, 20 Feb 2008 19:40:54 +0000 (19:40 +0000)]
* sanitize migrate_aliases.sh
* use migrate_aliases.sh the intended way in the postinst script.
Wilfried Göesgens [Mon, 18 Feb 2008 22:44:35 +0000 (22:44 +0000)]
* decode qp string in vcards, even if they're not explicitely tagged being quoted printable if we find evidence that there could be some.
Wilfried Göesgens [Mon, 18 Feb 2008 20:58:43 +0000 (20:58 +0000)]
* add picture view to the files app
Wilfried Göesgens [Mon, 18 Feb 2008 19:45:49 +0000 (19:45 +0000)]
* fix exec permissions
Art Cancro [Sun, 17 Feb 2008 05:26:53 +0000 (05:26 +0000)]
Removed a temporary hack to vlprintf() that displayed the
address of the currently bound CitContext. Updated the
internal version number to 7.32 because we are going to have
to push an emergency update.
Art Cancro [Sun, 17 Feb 2008 05:18:31 +0000 (05:18 +0000)]
The networker and RSS client each start up their own threads
as well, so they also need private CitContext structures.
Art Cancro [Sun, 17 Feb 2008 04:56:49 +0000 (04:56 +0000)]
The auto-purger has its own thread so it needs its own
CitContext. Sharing the masterCC with housekeeping threads could be
causing data corruption issues.
Art Cancro [Sun, 17 Feb 2008 02:00:15 +0000 (02:00 +0000)]
The fix to Bug 311 didn't work. Applied a cleaner fix.
Art Cancro [Fri, 15 Feb 2008 03:45:47 +0000 (03:45 +0000)]
Search box is only enabled when the server's full text index is enabled.
Art Cancro [Thu, 14 Feb 2008 15:39:36 +0000 (15:39 +0000)]
When reading/writing netconfigs files, do not purge
shares for nodes that are thought to be defunct. We consistently
get this wrong.
Dave West [Wed, 13 Feb 2008 22:47:42 +0000 (22:47 +0000)]
When using host auth mode the user is given a default email address
based on the gecos field from the passwd file which is usually
"firstname_lastname" this results in the user not being able to receive
mail to their default username address.
To rememdy this when the user logs in for the first time we now create
the users vCard as normal and then add an alias to the vCard.
The alias is username@domain as opposed to firstname_lastname@domain.
We only add the alias if it would differ from the original address.
We only do this in host auth mode.
Dave West [Wed, 13 Feb 2008 21:33:37 +0000 (21:33 +0000)]
Fixed a small bug in serv_vcard.c that could leave the cm_fields['E']
initialised to an invalid pointer.
Dave West [Wed, 13 Feb 2008 19:04:57 +0000 (19:04 +0000)]
We are unable to purge users that have no name but the auto purger seems
to be finding some.
Altered the code so that we do not create a Users Purged message if we
try to purge a user with no name.
Instead we create a User Corrupt message containing the user number of
every user with no name.
These users shouldn't exist so we need to find out where they are coming
from.
Dave West [Wed, 13 Feb 2008 18:25:56 +0000 (18:25 +0000)]
Now the auto purger time drop list obeys the 24 hour option in the user
preferances.
Its a little obfuscated though.
Art Cancro [Wed, 13 Feb 2008 15:25:29 +0000 (15:25 +0000)]
Removed the 'defrag databases' stub function and command
line option from the citserver. This is a vestige of
the GDBM days and we're never going back there.
Wilfried Göesgens [Tue, 12 Feb 2008 08:19:58 +0000 (08:19 +0000)]
* fix endless loop if we don't find a PID file.
Art Cancro [Tue, 12 Feb 2008 04:24:07 +0000 (04:24 +0000)]
Removed some spurious trace messages
Wilfried Göesgens [Mon, 11 Feb 2008 23:49:30 +0000 (23:49 +0000)]
THIS IS 7.31