Art Cancro [Mon, 10 Jan 2011 04:48:45 +0000 (23:48 -0500)]
Fixed several errors introduced during templatization of the Wiki engine.
* the 'home' conditional was reversed
* the 'Edit this page' link should always appear
Art Cancro [Mon, 10 Jan 2011 04:17:51 +0000 (23:17 -0500)]
Force wiki room views into the wiki viewer instead of a read loop
Art Cancro [Fri, 7 Jan 2011 20:56:25 +0000 (15:56 -0500)]
minor cleanup
Art Cancro [Fri, 7 Jan 2011 20:51:04 +0000 (15:51 -0500)]
Made the elimination of nocookies permanent.
Art Cancro [Fri, 7 Jan 2011 19:40:21 +0000 (14:40 -0500)]
more logging for previous commit
Art Cancro [Fri, 7 Jan 2011 19:34:43 +0000 (14:34 -0500)]
The 'gotofirst' key is now called 'go' for brevity
Art Cancro [Fri, 7 Jan 2011 17:13:49 +0000 (12:13 -0500)]
The 'nocookies' error page is no longer needed
Art Cancro [Wed, 5 Jan 2011 21:18:18 +0000 (16:18 -0500)]
push/pop destination_url instead of passing it through the chain
Art Cancro [Wed, 5 Jan 2011 20:00:29 +0000 (15:00 -0500)]
Add new member 'PushedDestination' to wcsession. This will be used soon.
Art Cancro [Wed, 5 Jan 2011 17:18:09 +0000 (12:18 -0500)]
minor html markup change
Art Cancro [Wed, 5 Jan 2011 16:57:11 +0000 (11:57 -0500)]
Moved the noscript warning to head.html
Art Cancro [Wed, 5 Jan 2011 04:08:22 +0000 (23:08 -0500)]
COND:ROOM:EDITACCESS now observes (not) logged in
Art Cancro [Wed, 5 Jan 2011 03:58:55 +0000 (22:58 -0500)]
Applied the GetLoggedInFirst() semantics to the Reply buttons
Art Cancro [Wed, 5 Jan 2011 02:36:30 +0000 (21:36 -0500)]
fix b0rken on IE, maybe operat too
Art Cancro [Wed, 5 Jan 2011 00:09:46 +0000 (19:09 -0500)]
The Citadel icon is now a cute button
Art Cancro [Tue, 4 Jan 2011 23:55:23 +0000 (18:55 -0500)]
Auth box now uses proper Citadel and OpenID icons
Art Cancro [Tue, 4 Jan 2011 20:43:43 +0000 (15:43 -0500)]
New CSS for the login modal
Art Cancro [Tue, 4 Jan 2011 04:43:47 +0000 (23:43 -0500)]
Cleaned up the CSS for the login box
Art Cancro [Mon, 3 Jan 2011 21:47:32 +0000 (16:47 -0500)]
Added a bit of whitespace
Art Cancro [Mon, 3 Jan 2011 21:46:43 +0000 (16:46 -0500)]
Replaced missing 'content' div in create room screen.
Art Cancro [Mon, 3 Jan 2011 21:28:36 +0000 (16:28 -0500)]
GetLoggedInFirst() now goes directly to destination_url if already logged in
Art Cancro [Fri, 31 Dec 2010 22:29:39 +0000 (17:29 -0500)]
Cleanup of previous commit
Art Cancro [Fri, 31 Dec 2010 19:50:52 +0000 (14:50 -0500)]
503 Service Unavailable when we can't connect to citserver
Art Cancro [Thu, 30 Dec 2010 21:50:45 +0000 (16:50 -0500)]
Fixed broken location of sources in create-pot.sh
Art Cancro [Thu, 30 Dec 2010 20:52:29 +0000 (15:52 -0500)]
Performed a bunch of markup fixes suggested by validator.w3.org
Art Cancro [Thu, 30 Dec 2010 20:18:12 +0000 (15:18 -0500)]
cosmetic stuff
Art Cancro [Wed, 29 Dec 2010 22:50:53 +0000 (17:50 -0500)]
The 'Log in' button now routes to GetLoggedInFirst(do_welcome)
Art Cancro [Wed, 29 Dec 2010 22:41:23 +0000 (17:41 -0500)]
Smooth transition between logged-in and not-logged-in states
Art Cancro [Wed, 29 Dec 2010 22:34:21 +0000 (17:34 -0500)]
Initial version of modal login is now working.
Art Cancro [Wed, 29 Dec 2010 18:55:02 +0000 (13:55 -0500)]
Wrote the initial version of the 'ajax_login_username_password' handler
Art Cancro [Wed, 29 Dec 2010 18:43:58 +0000 (13:43 -0500)]
Changed 'free software' to 'open source' to piss off Richard Stallman
Art Cancro [Wed, 29 Dec 2010 18:40:53 +0000 (13:40 -0500)]
Changed 'free software' to 'open source' to piss off Richard Stallman
Art Cancro [Wed, 29 Dec 2010 18:21:53 +0000 (13:21 -0500)]
Initial (not yet working) version of modal/ajax login box
Art Cancro [Wed, 29 Dec 2010 16:00:53 +0000 (11:00 -0500)]
Began implementing GetLoggedInFirst(destination_url) path
Art Cancro [Wed, 29 Dec 2010 15:39:08 +0000 (10:39 -0500)]
cosmetic cleanup only
Art Cancro [Tue, 28 Dec 2010 22:55:36 +0000 (17:55 -0500)]
Summary page displays site name instead of user name when not logged in
Art Cancro [Tue, 28 Dec 2010 22:20:27 +0000 (17:20 -0500)]
Smoother navigation and restricted iconbar for guest mode
Art Cancro [Tue, 28 Dec 2010 19:10:16 +0000 (14:10 -0500)]
A conditional in roombanner.html was reversed. Fixed it.
Art Cancro [Tue, 28 Dec 2010 18:26:30 +0000 (13:26 -0500)]
added a javascript alert to display an error when does not exist.
Art Cancro [Tue, 28 Dec 2010 02:00:15 +0000 (21:00 -0500)]
upgrade scriptaculous to 1.9.0
Art Cancro [Tue, 28 Dec 2010 01:58:40 +0000 (20:58 -0500)]
upgrade prototype to 1.7
Art Cancro [Thu, 23 Dec 2010 05:20:03 +0000 (00:20 -0500)]
Began removing some of the logged-in checks
Art Cancro [Thu, 23 Dec 2010 05:15:33 +0000 (00:15 -0500)]
Tuned up the 'logged in as' / 'not logged in' ...
Art Cancro [Wed, 22 Dec 2010 23:00:07 +0000 (18:00 -0500)]
Templated a new location in the banner to display loggedin/notloggedin
Art Cancro [Wed, 22 Dec 2010 22:50:49 +0000 (17:50 -0500)]
Room info popup is now onMouseOver instead of onClick
Wilfried Goesgens [Wed, 22 Dec 2010 13:18:46 +0000 (14:18 +0100)]
Resync i18n with launchpad
Wilfried Goesgens [Wed, 22 Dec 2010 13:16:11 +0000 (14:16 +0100)]
Resync i18n with launchpad; add Czek translation.
Art Cancro [Wed, 26 Jan 2011 23:08:16 +0000 (18:08 -0500)]
Cache the most recently fetched msglist in CtdlForEachMessage()
(This will be used for a security check in an upcoming commit)
Art Cancro [Wed, 26 Jan 2011 22:18:31 +0000 (17:18 -0500)]
Removed nonce/apop/pas2, no longer used by anyone
Art Cancro [Wed, 26 Jan 2011 21:18:22 +0000 (16:18 -0500)]
Removed the MESSAGE_IN_ROOM sections in order to make way for a faster algorithm.
Art Cancro [Tue, 25 Jan 2011 16:40:35 +0000 (11:40 -0500)]
INFO command 'openid support' is now indicated as the version of OpenID support (currently 1) instead of a boolean.
Art Cancro [Tue, 18 Jan 2011 18:25:28 +0000 (13:25 -0500)]
CtdlUserLogout() fixed to more throroughly log the user out
Art Cancro [Mon, 17 Jan 2011 17:48:20 +0000 (12:48 -0500)]
Fixed bugs related to last three commits
Conflicts:
webcit/auth.c
webcit/openid.c
webcit/sysdep.c
webcit/tcp_sockets.c
Art Cancro [Mon, 17 Jan 2011 17:39:59 +0000 (12:39 -0500)]
Removed the logging facility from citserver, use syslog instead
added libevent modified files.
Wilfried Goesgens [Sat, 15 Jan 2011 17:47:03 +0000 (18:47 +0100)]
use the gnu format string checker for CtdlLogPrintf; fix associated new warnings / problems.
Art Cancro [Tue, 11 Jan 2011 04:41:27 +0000 (23:41 -0500)]
Require logged-in in order to revert a wiki page
Art Cancro [Tue, 11 Jan 2011 04:23:13 +0000 (23:23 -0500)]
cmd_euid now ac_logged_in_or_guest in order to make guest wiki work
Art Cancro [Tue, 11 Jan 2011 04:00:39 +0000 (23:00 -0500)]
Oops, we're in a new year; update the copyright date in serv_wiki.c
Art Cancro [Tue, 11 Jan 2011 03:57:49 +0000 (22:57 -0500)]
Wiki revs now work again - replaced --global-reject-file with -r
Art Cancro [Tue, 11 Jan 2011 03:53:12 +0000 (22:53 -0500)]
When we 503, do it in HTML
Conflicts:
webcit/webcit.c
Wilfried Goesgens [Sun, 9 Jan 2011 10:09:04 +0000 (11:09 +0100)]
fix parameter order of memset as reported by Silvio Cesare in debian Bug#609384
Art Cancro [Mon, 3 Jan 2011 17:08:35 +0000 (12:08 -0500)]
forward-port r4a30bae41553 from stable
Art Cancro [Thu, 30 Dec 2010 21:43:28 +0000 (16:43 -0500)]
use the short commit hash
Wilfried Goesgens [Wed, 22 Dec 2010 13:18:46 +0000 (14:18 +0100)]
Resync i18n with launchpad
Wilfried Goesgens [Wed, 22 Dec 2010 12:03:46 +0000 (13:03 +0100)]
fix typo in french po file.
Wilfried Goesgens [Wed, 22 Dec 2010 11:59:41 +0000 (12:59 +0100)]
Fix off by one here too; else we will send two '<' in the MAIL FROM command.
Wilfried Goesgens [Thu, 1 Sep 2011 17:07:06 +0000 (17:07 +0000)]
start working on a way do do CLANG compilation.
Wilfried Goesgens [Thu, 1 Sep 2011 16:42:07 +0000 (16:42 +0000)]
Multiple cleanup
- DeletePOP3Aggregator() free the read message struct
- comment out table revalidation
- remove duplicate return statement
- correctly handle queueing of dns query. We don't care about the result.
Wilfried Goesgens [Thu, 1 Sep 2011 16:40:27 +0000 (16:40 +0000)]
Queue functions have to return eNextState in order for the caller to i.e. swap successfully between queus.
Wilfried Goesgens [Thu, 1 Sep 2011 16:37:33 +0000 (16:37 +0000)]
Silence the very noisy 'Interrupted CtdlThreadSelect'
Wilfried Goesgens [Thu, 1 Sep 2011 16:34:44 +0000 (16:34 +0000)]
FB->ReadWritePointer has to point to FB->Buf->Buf if the buffer is nonempty; logic in other functions depends on this.
Wilfried Goesgens [Wed, 31 Aug 2011 09:45:58 +0000 (09:45 +0000)]
When sending chunks in a loop, terminate imemdiately if the remote party goes away.
Wilfried Goesgens [Thu, 4 Aug 2011 20:08:30 +0000 (20:08 +0000)]
add .silent and some echo logic to our makefiles; thanks to sECuRE for the hints.
Wilfried Goesgens [Wed, 31 Aug 2011 08:03:52 +0000 (08:03 +0000)]
Add testhash function, since we experienced troubles here.
Wilfried Goesgens [Wed, 31 Aug 2011 08:02:42 +0000 (08:02 +0000)]
Add function to do some revalidations on hashlists; Attention; this can be cpu intense; don't use for production code.
Wilfried Goesgens [Wed, 31 Aug 2011 08:01:45 +0000 (08:01 +0000)]
StrBufChunkSipLine(): compact buffer if we have a remaining snippet at the end of the buffer
Wilfried Goesgens [Wed, 31 Aug 2011 08:00:52 +0000 (08:00 +0000)]
Continue reading if the IO Grammer layer tells us so.
Wilfried Goesgens [Wed, 31 Aug 2011 08:00:23 +0000 (08:00 +0000)]
Correct logging expressions
Art Cancro [Mon, 22 Aug 2011 18:18:37 +0000 (14:18 -0400)]
Set all version numbers to 8.00 -- FEATURE FREEZE FOR 8.00
Wilfried Goesgens [Wed, 24 Aug 2011 13:15:43 +0000 (15:15 +0200)]
Cleanup Pop3Aggregator
- Fix varous Memleaks
- pop3client_scan_room() Combine old pop3collector syntax into a parseable URL.
- use just one URL pointer
- POP3C_GetOneMessageIDFromUseTable(): duplicate; obsolete; deleted.
- add username to pop3 usetable entries
- use our own Context
Wilfried Goesgens [Wed, 24 Aug 2011 13:10:34 +0000 (15:10 +0200)]
Fix Shutdown; work on IODebug
- StopClientWatchers(): stop watchers regardless whether the fd is 0 or not.
- streamline IODebugging
Wilfried Goesgens [Wed, 24 Aug 2011 13:09:45 +0000 (15:09 +0200)]
Add IODebugging to CtdlReadMessageBodyAsync
Wilfried Goesgens [Wed, 24 Aug 2011 09:43:56 +0000 (11:43 +0200)]
When creating system contexts, set the Context name.
Wilfried Goesgens [Wed, 24 Aug 2011 09:38:12 +0000 (11:38 +0200)]
rename our context so its more filename friendly.
Wilfried Goesgens [Sun, 21 Aug 2011 20:33:04 +0000 (22:33 +0200)]
add missing newline in logging.
Wilfried Goesgens [Sun, 21 Aug 2011 20:28:36 +0000 (22:28 +0200)]
in some rare conditions, we seem to need to check the pointer first before accessing it.
Wilfried Goesgens [Sat, 20 Aug 2011 17:38:17 +0000 (17:38 +0000)]
one time 'room' var is enough.
Wilfried Goesgens [Sat, 20 Aug 2011 17:37:45 +0000 (17:37 +0000)]
protect access to the counter by mutex, else we might get race conditions.
Wilfried Goesgens [Sat, 20 Aug 2011 11:58:14 +0000 (11:58 +0000)]
QP-Encode questionmarks.
Wilfried Goesgens [Sat, 20 Aug 2011 09:50:26 +0000 (09:50 +0000)]
When QP encoding, we need to convert blanks to underscores
- Spamassasin test 'BAD_ENC_HEADER' matches if a subject looks like that:
Subject: =?UTF-8?Q?=5Btestml=5D l=C3=B6sch misch ey.?=
it needs to look like that:
Subject: =?UTF-8?Q?=5Btestml=5D_l=C3=B6sch_misch_ey.?=
Wilfried Goesgens [Fri, 19 Aug 2011 17:17:31 +0000 (17:17 +0000)]
add missing var definition *ups*
Wilfried Goesgens [Fri, 19 Aug 2011 17:12:32 +0000 (17:12 +0000)]
Fix detecting of UTF8 Sequences
- we need to exactly check for both highest bits to be set, not one of them.
Wilfried Goesgens [Fri, 19 Aug 2011 16:43:30 +0000 (16:43 +0000)]
fix counting of UTF8-charwidth
- Ctdl_GetUtf8SequenceLength(): testbyte needs to be unsigned char, else >> will shift us new bits in from the left
- we need to shift 'test' to the right
- start counting at 0
Wilfried Goesgens [Thu, 18 Aug 2011 18:18:38 +0000 (18:18 +0000)]
fix StrHtmlEcmaEscAppend, StrECMAEscAppend
- StrHtmlEcmaEscAppend(): reimplement 'nbsp' - handling
- StrECMAEscAppend(): copy over required stuff from StrHtmlEcmaEscAppend()
Wilfried Goesgens [Thu, 18 Aug 2011 17:53:18 +0000 (17:53 +0000)]
Fix StrHtmlEcmaEscAppend() more edge cases in utf8 handling
- Ctdl_GetUtf8SequenceLength(): return 0 for broken, 1 for non-utf8 sequences
- StrHtmlEcmaEscAppend(): another attempt to fix json appending:
- use switch instead of Rumpelstilskin if sequence
- use HKEY for our static sequences
- don't check for buffer expansion again while utf8-handling; we have 11 bytes reserved, utf8 will at most become 6 bytes
- Simply handle ASCII chars in the utf8 loop
- since aptr is moved implicitely, we mustn't move it for the last byte
- add missing handling for some escapers
- let unicode escapers pass
Conflicts:
libcitadel/lib/stringbuf.c
Wilfried Goesgens [Thu, 18 Aug 2011 09:53:01 +0000 (09:53 +0000)]
fix QP encoding
- once we decided to QP encode we also need to encode = (forgotten in last commit)
Wilfried Goesgens [Thu, 18 Aug 2011 09:14:48 +0000 (09:14 +0000)]
fix QP encoding
- once we decided to QP encode we also need to encode =[]
Wilfried Goesgens [Wed, 17 Aug 2011 17:43:15 +0000 (17:43 +0000)]
Work on event'ing the pop3 aggregator
- POP3_C_ReAttachToFetchMessages(): we manage the transition DB-IO -> Network I/O
- POP3C_GetListCommandState(): after receiving the list-OK we have to continue reading the list items
- POP3C_GetListOneLine(): the server sends us the size of the message; save it for later use.
- POP3C_GetOneMessagID(): after reading all list-items, start DB lookup whether we knew them already.
- POP3C_GetOneMessageIDState(): if more items are in the list, call us again with the next message ID.
- POP3_FetchNetworkUsetableEntry(): fetch one UT-entry per call; forward to POP3_C_ReAttachToFetchMessages() once we saw all items in the list.
- POP3C_SendGetOneMsg(): cycle over the list till we find the next Mail we didn't know already & fetch it; if no more items in list -> goodbuye.
- POP3C_ReadMessageBody() after the I/O layer read the message from the socket, parse it; move our context over to the DB-Queue.
- POP3C_ReadMessageBodyFollowing(): On success initialize the async message reader; let the I/O layer read the message, then continue parsing & saving it.
- POP3C_StoreMsgRead(): parse & save the message to the DB. Continue with remembering it in the UT table.
- POP3C_SendDelete(): check whether we want to delete the mails on the server, if do; else continue with POP3C_SendGetOneMsg() to fetch next in list.
- POP3_C_ReadServerStatus(): switch between line based read operation and reading whole messages.
we now can successfully aggregate one pop3 account.
Wilfried Goesgens [Wed, 17 Aug 2011 17:18:07 +0000 (17:18 +0000)]
add infrastructure to cleanly swap inbetween the DB and the IO queue; add infrastructure needed for async message reading.
- QueueDBOperation(): use our own vars on the AsyncIO struct, so we don't overwrite handlers & events from the file I/O stuff.
- DB_PerformNext(): don't use default: so we get warnings if new states are added and not handled here.
- DB_PerformNext(): if we don't get a DB query or Terminate, the db operations are done, remove our handlers, this AsyncIO context is handed over into another Queue by the application logic.
- NextDBOperation(): use our own vars on the AsyncIO struct, so we don't overwrite handlers & events from the file I/O stuff.
- HandleInbound(): handle more read-states; needed for message reading.
- HandleInbound(): move Rumpelstilskin lookup if to switch()
- IO_send_callback(): fix/add IO debugging to /tmp/foo
- IO_send_callback(): Adjust switch to some edge cases:
- eSendReply: check whether we're done with sending, if, fall forward to writing.
- eReadMore: was missing, continue reading (if)
- eReadPayload: new, read smtp messages for example.
- eDBQuery: the application logic want to perform database I/O with this context, clean up hooks and remove it from this queue.
- set_start_callback(): properly hanle the new cases
- IO_recv_callback(): fix/add IO debugging to /tmp/foo
- ReAttachIO(): use me if you want to continue with file I/O after i.e. DB-I/O
Wilfried Goesgens [Wed, 17 Aug 2011 17:13:59 +0000 (17:13 +0000)]
Add async message reading
- CtdlSubmitMsg(): make param const, since its just read
- add NewAsyncMsg(): preprocess the parameters provided by application logic, return the worker struct for message reading
- add CtdlReadMessageBodyAsync(): call me from your IO handler to read a message from the socket asynchroneous.
- add DeleteAsyncMsg(): call me to delete the worker vars.