citadel.git
14 years ago* New parameter to CtdlSaveMsgPointersInRoom() to suppress the reference count adjust...
Art Cancro [Fri, 5 Mar 2010 21:19:07 +0000 (21:19 +0000)]
* New parameter to CtdlSaveMsgPointersInRoom() to suppress the reference count adjustment.  To be used ONLY when we're going to rewrite the metadata manually.  Used ONLY by serv_migrate.  Everyone else HANDS OFF.

14 years ago* fix off by one while copying email headers
Wilfried Göesgens [Thu, 4 Mar 2010 23:19:24 +0000 (23:19 +0000)]
* fix off by one while copying email headers
* check for CRLF regardles of what the caller is telling us, we did it like that in advance too.

14 years ago* Fix rooms.c call to citedit()
Art Cancro [Thu, 4 Mar 2010 20:02:46 +0000 (20:02 +0000)]
* Fix rooms.c call to citedit()

14 years ago* cleanup
Art Cancro [Thu, 4 Mar 2010 15:23:06 +0000 (15:23 +0000)]
* cleanup

14 years ago* citedit() does not make use of the client's IPC context. Removing that parameter.
Art Cancro [Thu, 4 Mar 2010 15:09:52 +0000 (15:09 +0000)]
* citedit() does not make use of the client's IPC context.  Removing that parameter.

14 years ago* Removed code from serv_chat.c that checks to see whether the final character was...
Art Cancro [Wed, 3 Mar 2010 05:29:25 +0000 (05:29 +0000)]
* Removed code from serv_chat.c that checks to see whether the final character was a newline.  Moved it to memfmout() instead.  memfmout() is now guaranteed to output a newline as its final character *if* it outputs any data at all.

14 years ago* Changed strings to 'First Name' and 'Last Name' in the vcard editor to avoid namesp...
Art Cancro [Wed, 3 Mar 2010 05:17:28 +0000 (05:17 +0000)]
* Changed strings to 'First Name' and 'Last Name' in the vcard editor to avoid namespace conflict with the strings 'First' and 'Last' in the bbsview.  Also changed these strings in all existing localizations in order to avoid losing them.

14 years ago* don't use strchr to find the end of the email header; instead iterate over it until...
Wilfried Göesgens [Tue, 2 Mar 2010 22:59:44 +0000 (22:59 +0000)]
* don't use strchr to find the end of the email header; instead iterate over it untill we run into it anyway

14 years ago* #if-out the buffered-read-debug-o-matic
Wilfried Göesgens [Tue, 2 Mar 2010 22:58:17 +0000 (22:58 +0000)]
* #if-out the buffered-read-debug-o-matic

14 years ago* Slightly more computationally efficient version of memfmout() that doesn't use...
Art Cancro [Tue, 2 Mar 2010 20:10:40 +0000 (20:10 +0000)]
* Slightly more computationally efficient version of memfmout() that doesn't use cprintf() and doesn't switch into kernel space one character at a time.

14 years ago* Replaced memfmout() with a much simpler version that doesn't contain unneeded fmout...
Art Cancro [Tue, 2 Mar 2010 18:11:58 +0000 (18:11 +0000)]
* Replaced memfmout() with a much simpler version that doesn't contain unneeded fmout() cruft.

14 years ago* The PEXP command has been deprecated for ten years and no one is using it. Removin...
Art Cancro [Tue, 2 Mar 2010 16:43:20 +0000 (16:43 +0000)]
* The PEXP command has been deprecated for ten years and no one is using it.  Removing this command.

14 years ago* Eliminate an unused variable
Art Cancro [Tue, 2 Mar 2010 04:58:17 +0000 (04:58 +0000)]
* Eliminate an unused variable

14 years ago* add configure detection for solaris localtime_r, it needs to know the size of the...
Wilfried Göesgens [Mon, 1 Mar 2010 20:50:38 +0000 (20:50 +0000)]
* add configure detection for solaris localtime_r, it needs to know the size of the buffer

14 years ago* forgot to commit this: add CTX_STRBUFARR
Wilfried Göesgens [Mon, 1 Mar 2010 20:44:59 +0000 (20:44 +0000)]
* forgot to commit this: add CTX_STRBUFARR

14 years ago* incooperate Stefan Schwarz' sugestions
Wilfried Göesgens [Mon, 1 Mar 2010 20:15:29 +0000 (20:15 +0000)]
* incooperate Stefan Schwarz' sugestions
* work out remaining fuzzies

14 years ago* defines for pop aggregation columns
Wilfried Göesgens [Sun, 28 Feb 2010 22:09:45 +0000 (22:09 +0000)]
* defines for pop aggregation columns

14 years ago* fix register to allow escapers
Wilfried Göesgens [Sun, 28 Feb 2010 21:57:33 +0000 (21:57 +0000)]
* fix register to allow escapers

14 years ago* add generic lists with strings
Wilfried Göesgens [Sun, 28 Feb 2010 21:33:29 +0000 (21:33 +0000)]
* add generic lists with strings
* use them for the configs, since there is no way to say how many items are in the list

14 years ago* ups wrong varname
Wilfried Göesgens [Sun, 28 Feb 2010 19:47:25 +0000 (19:47 +0000)]
* ups wrong varname

14 years ago* general way to do retrieve / save autopurger data
Wilfried Göesgens [Sun, 28 Feb 2010 19:30:27 +0000 (19:30 +0000)]
* general way to do retrieve / save autopurger data

14 years ago* add proper error handling to room netconfig loading
Wilfried Göesgens [Sun, 28 Feb 2010 19:29:31 +0000 (19:29 +0000)]
* add proper error handling to room netconfig loading

14 years ago* add macro for use of ConstStr as parameter
Wilfried Göesgens [Sun, 28 Feb 2010 19:28:10 +0000 (19:28 +0000)]
* add macro for use of ConstStr as parameter

14 years ago* add handler to get the value or string representation of a define
Wilfried Göesgens [Sun, 28 Feb 2010 19:27:30 +0000 (19:27 +0000)]
* add handler to get the value or string representation of a define

14 years ago* add const string evaluator
Wilfried Göesgens [Sun, 28 Feb 2010 19:26:43 +0000 (19:26 +0000)]
* add const string evaluator

14 years ago* use the just commited defines; append -policy to the commandnames so its uniq
Wilfried Göesgens [Sun, 28 Feb 2010 15:11:40 +0000 (15:11 +0000)]
* use the just commited defines; append -policy to the commandnames so its uniq

14 years ago* add defines for the autopurger tokens
Wilfried Göesgens [Sun, 28 Feb 2010 15:09:07 +0000 (15:09 +0000)]
* add defines for the autopurger tokens

14 years ago* add COND:FLOOR:ISSUBROOM to detect whether the current room is on thet floor we...
Wilfried Göesgens [Sun, 28 Feb 2010 10:32:19 +0000 (10:32 +0000)]
* add COND:FLOOR:ISSUBROOM to detect whether the current room is on thet floor we're iterating

14 years ago* put is_https into a COND:IS_HTTPS
Wilfried Göesgens [Sat, 27 Feb 2010 23:17:19 +0000 (23:17 +0000)]
* put is_https into a COND:IS_HTTPS

14 years ago* whops, wrong param offset; allow parameter
Wilfried Göesgens [Sat, 27 Feb 2010 22:25:10 +0000 (22:25 +0000)]
* whops, wrong param offset; allow parameter

14 years ago* implement ITERATE:THISROOM:GNET
Wilfried Göesgens [Sat, 27 Feb 2010 22:18:24 +0000 (22:18 +0000)]
* implement ITERATE:THISROOM:GNET

14 years ago* Hail X-Macros! use typed enums instead of plain strings to generate our keys
Wilfried Göesgens [Sat, 27 Feb 2010 12:46:22 +0000 (12:46 +0000)]
* Hail X-Macros! use typed enums instead of plain strings to generate our keys

14 years ago* macro to get a string out of a define / enum
Wilfried Göesgens [Sat, 27 Feb 2010 12:45:36 +0000 (12:45 +0000)]
* macro to get a string out of a define / enum

14 years ago* ups, forgot to commit this; make memreadline const
Wilfried Göesgens [Sat, 27 Feb 2010 12:45:01 +0000 (12:45 +0000)]
* ups, forgot to commit this; make memreadline const

14 years ago* ups. don't need the switch anymore
Wilfried Göesgens [Sat, 27 Feb 2010 12:19:27 +0000 (12:19 +0000)]
* ups. don't need the switch anymore

14 years ago* switch room types to defines; no strcmp needed anymore.
Wilfried Göesgens [Sat, 27 Feb 2010 12:11:55 +0000 (12:11 +0000)]
* switch room types to defines; no strcmp needed anymore.

14 years ago* use eUsrAxlvl all over the place
Wilfried Göesgens [Fri, 26 Feb 2010 18:11:39 +0000 (18:11 +0000)]
* use eUsrAxlvl all over the place

14 years ago* utilize user enum, forward it into the templates as define
Wilfried Göesgens [Fri, 26 Feb 2010 17:43:27 +0000 (17:43 +0000)]
* utilize user enum, forward it into the templates as define

14 years ago* add user accesslevel enum
Wilfried Göesgens [Fri, 26 Feb 2010 17:39:48 +0000 (17:39 +0000)]
* add user accesslevel enum

14 years ago* add conditionals for the QR2 flagset
Wilfried Göesgens [Thu, 25 Feb 2010 23:27:38 +0000 (23:27 +0000)]
* add conditionals for the QR2 flagset

14 years ago* rework imap tokenizer, we no longer copy the stuff around, we keep a reference...
Wilfried Göesgens [Thu, 25 Feb 2010 22:43:57 +0000 (22:43 +0000)]
* rework imap tokenizer, we no longer copy the stuff around, we keep a reference in the source buffer
* we may have "unlimited" numbers of tokens
* spread the change of ConstStr all over the imap server
* lots of consts all over the whole place

14 years ago* remove header of a function which was moved to libcitadel a while ago
Wilfried Göesgens [Thu, 25 Feb 2010 19:05:04 +0000 (19:05 +0000)]
* remove header of a function which was moved to libcitadel a while ago
* if UBER_VERBOSE_DEBUGGING is defined, wc_printf will wrap its output with File:Function:Line[string]

14 years agoFix HaveMoreLinesWaiting. Fixes IG's problem with async.
Dave West [Thu, 25 Feb 2010 13:19:11 +0000 (13:19 +0000)]
Fix HaveMoreLinesWaiting. Fixes IG's problem with async.

14 years ago* Working on async
Art Cancro [Thu, 25 Feb 2010 05:56:07 +0000 (05:56 +0000)]
* Working on async

14 years ago* Noticed that when serv_chat.c sets async_waiting to 1, it also checks to see if...
Art Cancro [Thu, 25 Feb 2010 05:21:39 +0000 (05:21 +0000)]
* Noticed that when serv_chat.c sets async_waiting to 1, it also checks to see if the target session is in CON_IDLE, and if so, switches it to CON_READY.  serv_xmpp.c now does this as well.  Also unified this action in both modules by creating a shared function called set_async_waiting().

14 years ago* Fixed some warnings
Art Cancro [Wed, 24 Feb 2010 17:47:17 +0000 (17:47 +0000)]
* Fixed some warnings

14 years agoFix async messages (hopefully).
Dave West [Wed, 24 Feb 2010 16:32:08 +0000 (16:32 +0000)]
Fix async messages (hopefully).

14 years ago* In the extremely unlikely event that CtdlGetContextArray() returns NULL, set the...
Art Cancro [Tue, 23 Feb 2010 20:14:30 +0000 (20:14 +0000)]
* In the extremely unlikely event that CtdlGetContextArray() returns NULL, set the number of sessions to 0 instead of undefined.

14 years ago* Tweaked some of the XMPP stanzas to include a valid 'to=' parameter. The presence...
Art Cancro [Tue, 23 Feb 2010 16:28:58 +0000 (16:28 +0000)]
* Tweaked some of the XMPP stanzas to include a valid 'to=' parameter.  The presence of online buddies at login time is now working again in the current version of Pidgin.  Unsolicited events are still not being received at all, however.  This includes incoming instant messages and presence/nonpresence updates which occur during the session.

14 years ago* More XMPP tweaks, none of which fixed our current batch of problems
Art Cancro [Tue, 23 Feb 2010 05:17:04 +0000 (05:17 +0000)]
* More XMPP tweaks, none of which fixed our current batch of problems

14 years ago* When an XMPP client closes its stream, close the server's stream and log out the...
Art Cancro [Tue, 23 Feb 2010 04:14:48 +0000 (04:14 +0000)]
* When an XMPP client closes its stream, close the server's stream and log out the session.

14 years ago* make it const baby!
Wilfried Göesgens [Mon, 22 Feb 2010 22:09:44 +0000 (22:09 +0000)]
* make it const baby!

14 years ago* make the user const
Wilfried Göesgens [Mon, 22 Feb 2010 22:02:57 +0000 (22:02 +0000)]
* make the user const

14 years ago* first Trim the right end, so we don't need to move stuff around we would later cut
Wilfried Göesgens [Mon, 22 Feb 2010 21:34:43 +0000 (21:34 +0000)]
* first Trim the right end, so we don't need to move stuff around we would later cut
* protect us for a bufferunderrun here

14 years ago* more debugging
Art Cancro [Mon, 22 Feb 2010 19:02:14 +0000 (19:02 +0000)]
* more debugging

14 years ago* Renamed the 'jabber' module to 'xmpp' module. Also renamed functions starting...
Art Cancro [Mon, 22 Feb 2010 18:30:51 +0000 (18:30 +0000)]
* Renamed the 'jabber' module to 'xmpp' module.  Also renamed functions starting with jabber_ to xmpp_ .  Obviously I did *not* rename any of the XML namespaces because that would break the protocol.

14 years ago* fill the migrate buffer so the new sock_getln works
Wilfried Göesgens [Sun, 21 Feb 2010 21:05:43 +0000 (21:05 +0000)]
* fill the migrate buffer so the new sock_getln works

14 years ago* init pointer to NULL, try not to free null pointers. this won't be fixeable it...
Wilfried Göesgens [Sun, 21 Feb 2010 20:04:39 +0000 (20:04 +0000)]
* init pointer to NULL, try not to free null pointers. this won't be fixeable it will have to wait till the rework

14 years ago* free the subjects of the tabs
Wilfried Göesgens [Sun, 21 Feb 2010 20:03:27 +0000 (20:03 +0000)]
* free the subjects of the tabs

14 years ago* fix endless loop; respect kill_me
Wilfried Göesgens [Sun, 21 Feb 2010 19:37:28 +0000 (19:37 +0000)]
* fix endless loop; respect kill_me

14 years ago* more memleaks...
Wilfried Göesgens [Sun, 21 Feb 2010 18:37:02 +0000 (18:37 +0000)]
* more memleaks...

14 years ago* memleak...
Wilfried Göesgens [Sun, 21 Feb 2010 18:27:41 +0000 (18:27 +0000)]
* memleak...

14 years ago* since valgrinds name reacting to killall has become verry fancy to type, do the...
Wilfried Göesgens [Sun, 21 Feb 2010 18:19:13 +0000 (18:19 +0000)]
* since valgrinds name reacting to killall has become verry fancy to type, do the same on SIGINT as SIGHUP when running from the console: cleanup shit and exit.

14 years ago* fix handler name to match template scheme
Wilfried Göesgens [Sun, 21 Feb 2010 18:11:07 +0000 (18:11 +0000)]
* fix handler name to match template scheme

14 years ago* just define vars if we need them
Wilfried Göesgens [Sun, 21 Feb 2010 18:09:29 +0000 (18:09 +0000)]
* just define vars if we need them

14 years ago* remove obsolete configure options
Wilfried Göesgens [Sun, 21 Feb 2010 17:44:13 +0000 (17:44 +0000)]
* remove obsolete configure options

14 years ago* its a pointer, so compare it with NULL not 0
Wilfried Göesgens [Sun, 21 Feb 2010 17:03:06 +0000 (17:03 +0000)]
* its a pointer, so compare it with NULL not 0

14 years ago* don't forget to separate the headers from the body here.
Wilfried Göesgens [Sun, 21 Feb 2010 13:07:08 +0000 (13:07 +0000)]
* don't forget to separate the headers from the body here.

14 years ago* migrate append to StrBuf; switch the lineconverter out to stringbuf
Wilfried Göesgens [Sun, 21 Feb 2010 12:48:07 +0000 (12:48 +0000)]
* migrate append to StrBuf; switch the lineconverter out to stringbuf

14 years ago* some doxygen grouping
Wilfried Göesgens [Sun, 21 Feb 2010 12:44:00 +0000 (12:44 +0000)]
* some doxygen grouping
* add -tounixlf string converter

14 years ago* post increment...
Wilfried Göesgens [Sun, 21 Feb 2010 12:42:47 +0000 (12:42 +0000)]
* post increment...

14 years ago* Implemented XEP-0199: XMPP Ping ... see http://xmpp.org/extensions/xep-0199.html...
Art Cancro [Sun, 21 Feb 2010 06:30:08 +0000 (06:30 +0000)]
* Implemented XEP-0199: XMPP Ping ... see xmpp.org/extensions/xep-0199.html for protocol information

14 years ago* Reply to XMPP queries in unsupported namespaces with a <service-unavailable/> error...
Art Cancro [Sun, 21 Feb 2010 05:37:32 +0000 (05:37 +0000)]
* Reply to XMPP queries in unsupported namespaces with a <service-unavailable/> error instead of an empty result.

14 years ago* const now the bugged code is gone.
Wilfried Göesgens [Sat, 20 Feb 2010 15:16:05 +0000 (15:16 +0000)]
* const now the bugged code is gone.

14 years ago* found new bug in the RFC822 Decoder
Wilfried Göesgens [Sat, 20 Feb 2010 14:16:03 +0000 (14:16 +0000)]
* found new bug in the RFC822 Decoder

14 years ago* debug output for BLOB reading too.
Wilfried Göesgens [Sat, 20 Feb 2010 11:53:27 +0000 (11:53 +0000)]
* debug output for BLOB reading too.

14 years ago* protect access to client_sock here too.
Wilfried Göesgens [Fri, 19 Feb 2010 18:36:55 +0000 (18:36 +0000)]
* protect access to client_sock here too.

14 years ago* add linebreak so we don't expose our weakness here.
Wilfried Göesgens [Fri, 19 Feb 2010 00:14:03 +0000 (00:14 +0000)]
* add linebreak so we don't expose our weakness here.

14 years ago* don't break overlong lines on random places and loose chars, find the nearest previ...
Wilfried Göesgens [Fri, 19 Feb 2010 00:04:26 +0000 (00:04 +0000)]
* don't break overlong lines on random places and loose chars, find the nearest previous / next whitespace and kick it there.
* don't use cprintf, since we know the buffersize hand have reserved space for the newline... client_write is faster.

14 years ago* work around ' bug
Wilfried Göesgens [Thu, 18 Feb 2010 21:36:28 +0000 (21:36 +0000)]
* work around ' bug

14 years ago* change sort order, group the two not simoultaneus selectable ones, and hint not...
Wilfried Göesgens [Thu, 18 Feb 2010 20:51:58 +0000 (20:51 +0000)]
* change sort order, group the two not simoultaneus selectable ones, and hint not to select both

14 years ago* display_login doesn't need parameters.
Wilfried Göesgens [Thu, 18 Feb 2010 20:28:59 +0000 (20:28 +0000)]
* display_login doesn't need parameters.

14 years ago* fix returnvalue of wrapper to be identical to as before
Wilfried Göesgens [Wed, 17 Feb 2010 18:56:48 +0000 (18:56 +0000)]
* fix returnvalue of wrapper to be identical to as before

14 years ago* text client: try the user's password with and without strproc() processing. This...
Art Cancro [Wed, 17 Feb 2010 17:29:05 +0000 (17:29 +0000)]
* text client: try the user's password with and without strproc() processing.  This will allow authentication of users in LDAP etc. who have special characters in their passwords, without breaking the sites using self-contained auth that have passwords stored (unbeknownst to the users) whose passwords went into the db stripped.  Resolves bug 457.

14 years ago* During setup, the default LDAP port number is now 389 instead of 0.
Art Cancro [Wed, 17 Feb 2010 17:09:25 +0000 (17:09 +0000)]
* During setup, the default LDAP port number is now 389 instead of 0.

14 years ago* Switch from ldap_search_st() to ldap_search_ext_s(). The latter is not deprecated.
Art Cancro [Wed, 17 Feb 2010 16:53:03 +0000 (16:53 +0000)]
* Switch from ldap_search_st() to ldap_search_ext_s().  The latter is not deprecated.
* Ignore the return value from ldap_search_ext_s() because it appears to be misleading.  Instead, check to see whether the search returned any results (null or not null).  This also fixes a potential memory leak resulting from ldap_search_ext_s() returning an error code but still populating the search results.

14 years ago* ldap.c needs a little love. (I only added some extra debug messages and comments...
Art Cancro [Wed, 17 Feb 2010 16:21:06 +0000 (16:21 +0000)]
* ldap.c needs a little love.  (I only added some extra debug messages and comments for now.)

14 years ago* suse gcc complains about empty paramlist of functions; since that just means anythi...
Wilfried Göesgens [Mon, 15 Feb 2010 23:23:14 +0000 (23:23 +0000)]
* suse gcc complains about empty paramlist of functions; since that just means anything can be here, its bad coding style anyway.

14 years ago* Implemented a new way to show where the new and old messages are, that is visually...
Art Cancro [Mon, 15 Feb 2010 22:47:57 +0000 (22:47 +0000)]
* Implemented a new way to show where the new and old messages are, that is visually consistent with the rest of the layout.  TRANSLATORS: there are a few new strings; please localize

14 years ago* Reverted r8284 ... we're going to do this a different way
Art Cancro [Mon, 15 Feb 2010 22:26:25 +0000 (22:26 +0000)]
* Reverted r8284 ... we're going to do this a different way

14 years ago* return the number of chars we read; it doesn't have to be the length of the string
Wilfried Göesgens [Mon, 15 Feb 2010 09:55:12 +0000 (09:55 +0000)]
* return the number of chars we read; it doesn't have to be the length of the string

14 years ago* generaly NULL *Pos before re-caclulating it
Wilfried Göesgens [Sun, 14 Feb 2010 21:09:27 +0000 (21:09 +0000)]
* generaly NULL *Pos before re-caclulating it
* when re-allocating the read-buffer re-position pNL

14 years ago* add missing debug statements for server I/O debugging
Wilfried Göesgens [Sun, 14 Feb 2010 21:07:13 +0000 (21:07 +0000)]
* add missing debug statements for server I/O debugging
* flush server read buffer before reading the next line

14 years ago* copy the FD so we're safe of other threads setting it to -1 meanwhile
Wilfried Göesgens [Sun, 14 Feb 2010 11:34:41 +0000 (11:34 +0000)]
* copy the FD so we're safe of other threads setting it to -1 meanwhile

14 years ago* remove debug code
Wilfried Göesgens [Sun, 14 Feb 2010 11:27:27 +0000 (11:27 +0000)]
* remove debug code

14 years ago* don't flush the inbuffer on send; while this is appropriate for a citadel client...
Wilfried Göesgens [Sun, 14 Feb 2010 11:25:21 +0000 (11:25 +0000)]
* don't flush the inbuffer on send; while this is appropriate for a citadel client, it may irretate smtp traffic
* add some debug code for the linebuffered reader so we may find it again later

14 years ago* fix the linebuffered reader; some cases (like having a part of a line in the buffer...
Wilfried Göesgens [Sun, 14 Feb 2010 11:21:56 +0000 (11:21 +0000)]
* fix the linebuffered reader; some cases (like having a part of a line in the buffer, and reading more of the same line) didn't work
* if we have the chance to flush the IOBuf because of we read everything inside, take it!

14 years ago* check whether the FD got fuxored meanwhile before adding it to the select set
Wilfried Göesgens [Sat, 13 Feb 2010 00:01:30 +0000 (00:01 +0000)]
* check whether the FD got fuxored meanwhile before adding it to the select set

14 years ago* wrong pointer...
Wilfried Göesgens [Fri, 12 Feb 2010 23:59:53 +0000 (23:59 +0000)]
* wrong pointer...

14 years ago* make the write -1 aware here too.
Wilfried Göesgens [Fri, 12 Feb 2010 20:45:14 +0000 (20:45 +0000)]
* make the write -1 aware here too.
* don't close -1