Art Cancro [Mon, 28 Jan 2008 16:25:50 +0000 (16:25 +0000)]
* Unfinished code is now disabled.
To enable it, do 'CFLAGS=-DTECH_PREVIEW' prior to configure.
This will activate the Jabber and Wiki modules.
* Citadel and WebCit configure scripts now check to make sure that
libcitadel is current enough.
* Cleaned up some compiler warnings.
Wilfried Göesgens [Sun, 27 Jan 2008 22:57:43 +0000 (22:57 +0000)]
* now getmail does s.th. almost usefull
Wilfried Göesgens [Sun, 27 Jan 2008 18:31:56 +0000 (18:31 +0000)]
* user creation commandline tool
* some sample data
Wilfried Göesgens [Sun, 27 Jan 2008 17:27:32 +0000 (17:27 +0000)]
* support dele command
* z-push plugin
* sample edit config command
Wilfried Göesgens [Sun, 27 Jan 2008 00:31:44 +0000 (00:31 +0000)]
* we didn't calculate our directories in a proper sequence. fixed hereby.
Wilfried Göesgens [Sun, 27 Jan 2008 00:07:06 +0000 (00:07 +0000)]
* try to watch the PID for shutting down citserver
Wilfried Göesgens [Sat, 26 Jan 2008 23:57:07 +0000 (23:57 +0000)]
* restart by doing 'sendcommand down 1' which will make citserver restart internaly.
Dave West [Sat, 26 Jan 2008 18:57:31 +0000 (18:57 +0000)]
Fix the segault on server shutdown that crept in when we decided to
purge users at logout.
Art Cancro [Fri, 25 Jan 2008 03:59:59 +0000 (03:59 +0000)]
Shuffled around the order of resolver library tests.
Art Cancro [Thu, 24 Jan 2008 16:43:23 +0000 (16:43 +0000)]
Fixed bug #226. The sample message supplied was
a multipart/mixed that contained nothing except an attached message/rfc822
submessage. This is quite unusual but I suppose it is legal. With no viewable
parts at the top level, webcit assumed that the message was corrupt. Changed the
code so that this is no longer an error condition. Instead of displaying an error
and jumping to the exit point, we now display nothing and jump to the portion of
read_message() that displays attachments and submessages.
Art Cancro [Thu, 24 Jan 2008 04:51:44 +0000 (04:51 +0000)]
Added a second test for libresolv that takes into
consideration the fact that res_query() is a macro on some hosts.
Art Cancro [Thu, 24 Jan 2008 03:47:48 +0000 (03:47 +0000)]
Nothing happens.
Art Cancro [Wed, 23 Jan 2008 18:28:39 +0000 (18:28 +0000)]
Implemented the XYZZY command.
Art Cancro [Wed, 23 Jan 2008 17:39:26 +0000 (17:39 +0000)]
Applied Matt's latest funambol65 patch.
Matt: please clean up your compiler warnings.
Art Cancro [Wed, 23 Jan 2008 17:35:26 +0000 (17:35 +0000)]
Modified ical_dezonify() again. It seems that there
is never a need to free the icaltimezone, as it will always be one
of three things:
1. A built-in timezone (memory belongs to libical)
2. Hardcoded UTC timezone (memory belongs to libical)
3. A supplied timezone from another component (memory belongs to caller)
Removed the call to icaltimezone_free().
Wilfried Göesgens [Tue, 22 Jan 2008 22:21:53 +0000 (22:21 +0000)]
* OpenBSD compatibility: select properly while reading/writing to sockets
* some minor deb changes.
Wilfried Göesgens [Tue, 22 Jan 2008 22:20:28 +0000 (22:20 +0000)]
* if two edit in the same screen...
Wilfried Göesgens [Tue, 22 Jan 2008 21:22:10 +0000 (21:22 +0000)]
* correctly handle tcp write, so that we work properly on openbsd. Thanks to Maide for this work.
Wilfried Göesgens [Tue, 22 Jan 2008 21:21:24 +0000 (21:21 +0000)]
* use the hash to store our config.
Dave West [Tue, 22 Jan 2008 10:16:47 +0000 (10:16 +0000)]
Clean up in Hash functions.
Some bug fixes too.
Addition of hash ittereator functions.
This is Dothebarts spiffing new hash functions.
Art Cancro [Tue, 22 Jan 2008 05:02:04 +0000 (05:02 +0000)]
Fixed the webcit preferences bug once and for all, using a proper
linked list instead of a clumsy hack with the string tokenizer.
Art Cancro [Mon, 21 Jan 2008 14:55:07 +0000 (14:55 +0000)]
Added funambol_newmail_soap.xml
Wilfried Göesgens [Sun, 20 Jan 2008 21:10:17 +0000 (21:10 +0000)]
* sanitize the next message pointer loop in the "Goto Next Room"-Call
* include missing header.
Wilfried Göesgens [Sun, 20 Jan 2008 15:05:22 +0000 (15:05 +0000)]
* add skelleton hash lib.
Dave West [Sun, 20 Jan 2008 13:52:06 +0000 (13:52 +0000)]
Now when a room is created or deleted this users icon bar is updated
immediately.
Other users will have to wait until their iconbar is refreshed (up to
300 seconds) but since they have no knowledge of when the room was
created/deleted they'll never notice.
Art Cancro [Sun, 20 Jan 2008 04:47:06 +0000 (04:47 +0000)]
Add remote hostname and IP address to 'Session started.' log message
Art Cancro [Sun, 20 Jan 2008 04:43:25 +0000 (04:43 +0000)]
Applied Matt's new patch. Adds 'extnotify' and removes
the 'pager' and 'funambol' modules.
Dave West [Sat, 19 Jan 2008 23:53:29 +0000 (23:53 +0000)]
Fix the user purge / delete thing once and for all.
When a user is deleted they are purged from the database immediately
unless they are currently logged in.
This used to rely on the autopurger purging the user at a later date.
Now when the user logs out we check to see if they have been marked for
deletion and if they have purge them immediately.
Dave West [Sat, 19 Jan 2008 21:29:37 +0000 (21:29 +0000)]
If we are redirected we need to close this socket before the goto retry
which causes a new one to be opened.
Art Cancro [Sat, 19 Jan 2008 06:51:26 +0000 (06:51 +0000)]
Aha! Finally found the culprit. Someone (possibly me) at
some point in the past decided to set the TZ environment variable
to UTC if it was empty. This is wrong because an empty TZ causes
libc to discover the timezone by other means. As a result, hosts
that were in other timezones were getting their times changed to
UTC.
Art Cancro [Sat, 19 Jan 2008 06:02:47 +0000 (06:02 +0000)]
Backed out previous commit
Art Cancro [Sat, 19 Jan 2008 05:35:02 +0000 (05:35 +0000)]
Applied matt's latest patch set
Art Cancro [Fri, 18 Jan 2008 05:12:23 +0000 (05:12 +0000)]
Reinstated the call to icaltimezone_copy()
Wilfried Göesgens [Thu, 17 Jan 2008 23:21:09 +0000 (23:21 +0000)]
* this way the package builds again.
Art Cancro [Thu, 17 Jan 2008 22:29:07 +0000 (22:29 +0000)]
Fixed infinite-loop bug in room name display code.
Dave West [Thu, 17 Jan 2008 22:07:54 +0000 (22:07 +0000)]
Fix reply quoting in webcit.
Wilfried Göesgens [Thu, 17 Jan 2008 21:01:04 +0000 (21:01 +0000)]
* decode subject in the right position; if we decode the full text, we don't get hickups with sections passing the border.
* put in a correct dummy string.
Art Cancro [Thu, 17 Jan 2008 20:29:27 +0000 (20:29 +0000)]
The encoding and decoding tables for Base64 are
no longer calculated at startup. CtdlInitBase64Table() is removed. The tables
are now hardcoded as 'const' arrays. Not only will this eliminate the need to do
a startup calculation, but since it is now const we will get a nice clean segv if
some other code attempts to clobber them.
Art Cancro [Thu, 17 Jan 2008 06:20:17 +0000 (06:20 +0000)]
Backed out r5921 and r5936 because they were causing
SSL session lockups and CitContext table corruption.
Art Cancro [Thu, 17 Jan 2008 05:19:48 +0000 (05:19 +0000)]
Temporary workaround to compile with old libical
Art Cancro [Thu, 17 Jan 2008 05:08:46 +0000 (05:08 +0000)]
dtable/etable initialization code in libcitadel was
not complete. CtdlEncodeBase64() still initialized upon each call -- and it was
initializing dtable, not etable, causing dtable to have the wrong data the next time
CtdlDecodeBase64() is called. Fixed. Also noticed that WebCit was not calling the
initialization function at all, so this has probably been broken ever since the move
to libcitadel. Fixed this too.
Wilfried Göesgens [Wed, 16 Jan 2008 22:37:00 +0000 (22:37 +0000)]
* checking a pointer is useless if you dereference it in advance.
Wilfried Göesgens [Wed, 16 Jan 2008 22:28:17 +0000 (22:28 +0000)]
* for loops seem to execute at least once? hm.
Wilfried Göesgens [Wed, 16 Jan 2008 22:10:55 +0000 (22:10 +0000)]
* if the token extractor fails to do its work, rather return '0' than some random number.
Wilfried Göesgens [Wed, 16 Jan 2008 22:04:40 +0000 (22:04 +0000)]
* don't overrun our room list.
Dave West [Wed, 16 Jan 2008 14:56:40 +0000 (14:56 +0000)]
Changed log message when worker thread select is interrupted. It now
says it was interrupted rather than an unhandled select failure.
Dave West [Wed, 16 Jan 2008 14:53:36 +0000 (14:53 +0000)]
Fixed the configure message for libical. It now says no if libical is
too old.
Art Cancro [Wed, 16 Jan 2008 14:42:41 +0000 (14:42 +0000)]
VIEW_ definitions are now in libcitadel.h
Also added a version number check to libcitadel.h and to the
library itself. citserver and webcit will refuse to run if
the linked version of libcitadel is older than the one used
at compile time.
Wilfried Göesgens [Wed, 16 Jan 2008 00:31:11 +0000 (00:31 +0000)]
* have a friendly buildpackage script here to.
* be a bit more lintian friendly.
Wilfried Göesgens [Tue, 15 Jan 2008 23:47:30 +0000 (23:47 +0000)]
* our upstream changelog.
Wilfried Göesgens [Tue, 15 Jan 2008 23:10:28 +0000 (23:10 +0000)]
* free the libical ringbuffer after displaying all the events of a calendar. this should fix the leaks with libicals lazy alloc.
Wilfried Göesgens [Tue, 15 Jan 2008 23:07:06 +0000 (23:07 +0000)]
* use snprintf
* if TZ environment variable is unset, set UTC, so valgrind finaly shuts up on all our date/time printing functions.
Dave West [Tue, 15 Jan 2008 17:06:42 +0000 (17:06 +0000)]
Clean up in housekeeping.c
Removed some unused variables and old comments.
Dave West [Tue, 15 Jan 2008 16:54:31 +0000 (16:54 +0000)]
Alter the webcit shutdown a bit more.
Sending the watcher process a TERM kill the child and exits the watcher
without shutdown.
Sending the watcher a HUP shuts down cleanly.
Dothebart said this was the prefered way to do it.
Dave West [Tue, 15 Jan 2008 15:19:09 +0000 (15:19 +0000)]
Now citadel.pid contains the pid of the watcher process in case
something wants to stop us via the pid file.
Dave West [Tue, 15 Jan 2008 15:05:43 +0000 (15:05 +0000)]
Fixed signal handlers and contents of pid file.
Now webcit exits when sent SIG_HUP or SIG_TERM
Dave West [Tue, 15 Jan 2008 14:15:06 +0000 (14:15 +0000)]
Now the autopurger will always attempt to purge users regardless of the
"Default user purge time" but it will not purge users on time if it is
disabled.
This change added so that dead users are removed if need be.
Check this out guys. The changes are simple but lots of possible things
to test with catastrophic results if I got it wrong.
This should mean that users that have been deleted but not purged and
users that want to be deleted get deleted even if the user purge is
turned off.
Only deleteing users based on time is disabled if the user purge is
0.
Wilfried Göesgens [Mon, 14 Jan 2008 00:47:31 +0000 (00:47 +0000)]
* if we can't find iconv in the libc, try to find it in a separate library (like for *bsd)
Wilfried Göesgens [Mon, 14 Jan 2008 00:13:12 +0000 (00:13 +0000)]
* new urlesc here too.
Wilfried Göesgens [Sun, 13 Jan 2008 22:06:42 +0000 (22:06 +0000)]
* urlescs new parameter added.
Wilfried Göesgens [Sun, 13 Jan 2008 22:03:47 +0000 (22:03 +0000)]
* remove snprintf
* urlesc is in libcitadel, don't keep a local copy of it.
Wilfried Göesgens [Sun, 13 Jan 2008 22:02:24 +0000 (22:02 +0000)]
* sanitize urlesc, so we don't buffer overrun.
Wilfried Göesgens [Sun, 13 Jan 2008 21:39:47 +0000 (21:39 +0000)]
* more witchhunt on sprintf
Wilfried Göesgens [Sun, 13 Jan 2008 21:31:19 +0000 (21:31 +0000)]
* the same for msgescputs
Wilfried Göesgens [Sun, 13 Jan 2008 21:00:53 +0000 (21:00 +0000)]
* jsesc works with pointermagic rather than strcat now.
* use snprintf in compress_gzip just to be shure.
Wilfried Göesgens [Sun, 13 Jan 2008 19:39:55 +0000 (19:39 +0000)]
* openbsd has no -lresolv, its in their libc.
* TODO: can we get rid of AM macros, as we don't require automake in the whole other configure?
* socket.h requires types.h
Wilfried Göesgens [Sun, 13 Jan 2008 16:57:43 +0000 (16:57 +0000)]
* avoid some function calls openBSD doesn't like us to use. (like sprintf) fancily this evades one error valgrind was always complaining about.
Dave West [Sun, 13 Jan 2008 16:40:49 +0000 (16:40 +0000)]
do_hosekeeping is now a seperate thread. This releases worker threads
from worrying about mundane tasks.
Some other code regarding experimental select() in threads. Its turned
off at the moment.
Wilfried Göesgens [Sat, 12 Jan 2008 22:56:39 +0000 (22:56 +0000)]
* fixed tbirds managesieve login troubles.
Art Cancro [Fri, 11 Jan 2008 04:12:04 +0000 (04:12 +0000)]
added some debugging traces
Dave West [Thu, 10 Jan 2008 01:10:14 +0000 (01:10 +0000)]
Attempt to fix bug #313.
It fixes the bug but its not 100% matching the scheme, or at least I
don't think so.
This goes a long way to demonstrating I'm no where near as good at this
as Thierry.
Wilfried Göesgens [Thu, 10 Jan 2008 00:09:28 +0000 (00:09 +0000)]
* openbsd doesn't like pam. so... if we don't have the calls don't use 'em
Dave West [Wed, 9 Jan 2008 22:22:36 +0000 (22:22 +0000)]
Fix the repeated signature and extra space at beginning of subject Bug
#314
Art Cancro [Tue, 8 Jan 2008 19:33:13 +0000 (19:33 +0000)]
configure now *requires* libresolv to be present.
Dave West [Mon, 7 Jan 2008 22:56:27 +0000 (22:56 +0000)]
Small increase in performance when creating new threads.
Art Cancro [Sun, 6 Jan 2008 05:56:04 +0000 (05:56 +0000)]
WebCit now detects whether the Citadel server has Sieve support
enabled, and refuses to display the Sieve configuration screens if
it is not there. This will hopefully eliminate complaints in the support
forum of 'mailbox filtering does not work' when the actual problem is that
the server doesn't have libsieve linked into it.
Wilfried Göesgens [Fri, 4 Jan 2008 15:28:07 +0000 (15:28 +0000)]
* sanitized the decision whether we have one line auth or {+chars}
* test more thoroughly if we're realy logged in
* print citserver version from configure
Wilfried Göesgens [Wed, 2 Jan 2008 20:28:10 +0000 (20:28 +0000)]
* free the libical ringbuffer in apropriate places
* some more new libical gizmoes.
Wilfried Göesgens [Wed, 2 Jan 2008 20:26:29 +0000 (20:26 +0000)]
* remove more unneeded files from the sourcedist tgz
Art Cancro [Wed, 2 Jan 2008 19:06:39 +0000 (19:06 +0000)]
Prepared some of the authmode stuff for the imminent addition
of a third mode (LDAP without PAM). The mode itself will not
be written until after the next production release of the code.
Changed the use of 0 and 1 constants to AUTHMODE_NATIVE and
AUTHMODE_HOST.
Art Cancro [Tue, 1 Jan 2008 16:19:13 +0000 (16:19 +0000)]
More verbose logging for get_default_icaltimezone() when it
fails to retrieve built in time zones. This is for the purpose
of troubleshooting a bug which has appeared in libical.
Art Cancro [Mon, 31 Dec 2007 05:37:16 +0000 (05:37 +0000)]
* Cleaned up some misc comments
* Re-enabled the verbose logging for ical_dezonify() in an attempt
to figure out what the f**k is going on with timezones all
of a sudden.
Wilfried Göesgens [Sun, 30 Dec 2007 14:18:06 +0000 (14:18 +0000)]
* disable dspam
* some package tweaks.
Dave West [Sat, 29 Dec 2007 21:56:15 +0000 (21:56 +0000)]
Fixed up a compiler warning
Dave West [Sat, 29 Dec 2007 21:53:09 +0000 (21:53 +0000)]
Abstracted pthread from threads.* into sysdep_decls.h to ease porting.
At the moment its all typdefs ande #defines.
Dave West [Sat, 29 Dec 2007 20:31:52 +0000 (20:31 +0000)]
Removed redundant prototype of create_maintenance_threads()
Dave West [Sat, 29 Dec 2007 20:14:24 +0000 (20:14 +0000)]
Removed two unused mutex's.
Dave West [Sat, 29 Dec 2007 20:10:06 +0000 (20:10 +0000)]
Removed a few unneccesary lock calls to get a small speed up.
Changed the calc for load average. Now for the purposes of load averages
sleeping is the same as running since it means the thread can't do
something else in the mean time.
Started a new worker thread style for experimental purposes turn on by
un-commenting the #define NEW_WORKER at the top of threads.c
Dave West [Sat, 29 Dec 2007 19:39:11 +0000 (19:39 +0000)]
Removed excess return from init function as it breaks the build with a
segflt.
Dave West [Sat, 29 Dec 2007 18:43:18 +0000 (18:43 +0000)]
Created a function to close the master sockets. It is intended to call
this earlier in the shutdown thus causing any threads waiting in select
to exit quicker.
Added a big comment about the worker_thread
Dave West [Sat, 29 Dec 2007 18:23:43 +0000 (18:23 +0000)]
Fix the missing #define CTDLTHREAD_BIGSTACK for the rss client.
Fix a couple of compiler warnings too.
Art Cancro [Sat, 29 Dec 2007 17:18:04 +0000 (17:18 +0000)]
Another test commit
Art Cancro [Sat, 29 Dec 2007 17:14:05 +0000 (17:14 +0000)]
Copyright dates are now 2008.
Art Cancro [Sat, 29 Dec 2007 17:12:12 +0000 (17:12 +0000)]
commit test
Art Cancro [Sat, 29 Dec 2007 16:54:47 +0000 (16:54 +0000)]
include threads.h in serv_rssclient.c
Art Cancro [Thu, 27 Dec 2007 18:24:10 +0000 (18:24 +0000)]
Added a missing 'NO' to some error messages in IMAP RENAME
Wilfried Göesgens [Tue, 25 Dec 2007 19:18:59 +0000 (19:18 +0000)]
* don't load the module.
Wilfried Göesgens [Tue, 25 Dec 2007 19:18:30 +0000 (19:18 +0000)]
* initial dspam integration module
Michael Hampton [Tue, 25 Dec 2007 08:38:25 +0000 (08:38 +0000)]
Somebody broke the build by forgetting to #include "threads.h" in some of
the modules. Now it compiles again...
Dave West [Sun, 23 Dec 2007 14:56:45 +0000 (14:56 +0000)]
Moved all threading code into threads.c
Slight alteration to worker thread startup code.
Altered the order of the shutdown so that we shutdown the modules and
the ports before closing the database. I'm curious about the remaining
locks in the data base after shutdown.
Still to come.
Wrappers for the pthread calls so that they can return to sysdep.c (the
portability file).
Further speed improvements.
Module to get thread data for user display.