citadel.git
12 years agowhen generating subjects for calendar items do quoted printeable encoding
Wilfried Goesgens [Sun, 3 Apr 2011 21:47:46 +0000 (23:47 +0200)]
when generating subjects for calendar items do quoted printeable encoding

12 years agosmtp client: if msg_size is 0, assume memory corruption and defer
Art Cancro [Sat, 2 Apr 2011 17:54:15 +0000 (13:54 -0400)]
smtp client: if msg_size is 0, assume memory corruption and defer

12 years agoTemporarily adding dump of badmail to smtpclient
Art Cancro [Fri, 1 Apr 2011 15:35:48 +0000 (11:35 -0400)]
Temporarily adding dump of badmail to smtpclient

12 years agoFix searching of ']'
Wilfried Goesgens [Thu, 31 Mar 2011 22:50:43 +0000 (00:50 +0200)]
Fix searching of ']'

12 years agoMailinglist client: don't add roomname to subject if its already there
Wilfried Goesgens [Thu, 31 Mar 2011 21:11:14 +0000 (23:11 +0200)]
Mailinglist client: don't add roomname to subject if its already there

12 years agoAdded a few more Disallow: lines to robots.txt
Art Cancro [Tue, 22 Mar 2011 19:56:36 +0000 (15:56 -0400)]
Added a few more Disallow: lines to robots.txt

12 years agoLog citadel protocol commands using the session number
Art Cancro [Tue, 22 Mar 2011 16:47:18 +0000 (12:47 -0400)]
Log citadel protocol commands using the session number
and also the user number in addition to their name, instead of the IP address (which with
IPv6 is going to create just way too much volume).  This is part of my continuing attempt
to figure out why turning on guest mode on Uncensored is giving everyone access to my
mailbox.

12 years agoserv_upgrade will delete internal system accounts no longer needed
Art Cancro [Tue, 22 Mar 2011 03:03:24 +0000 (23:03 -0400)]
serv_upgrade will delete internal system accounts no longer needed

12 years agoModified select_on_master() to only have one code path to exit
Art Cancro [Mon, 21 Mar 2011 15:50:28 +0000 (11:50 -0400)]
Modified select_on_master() to only have one code path to exit

12 years agoDisabled the status bar in the text client because it doesn't work on busted Mac...
Art Cancro [Mon, 21 Mar 2011 15:21:46 +0000 (11:21 -0400)]
Disabled the status bar in the text client because it doesn't work on busted Mac terminal app

12 years agoDecrement num_workers when exiting worker_thread() under _any_ circumstances.
Art Cancro [Mon, 21 Mar 2011 15:02:19 +0000 (11:02 -0400)]
Decrement num_workers when exiting worker_thread() under _any_ circumstances.
This allows system shutdown to proceed normally.

12 years agoBegan working on the 'clean shutdown' code for the new thread architecture.
Art Cancro [Mon, 21 Mar 2011 03:34:08 +0000 (23:34 -0400)]
Began working on the 'clean shutdown' code for the new thread architecture.

12 years agoInitial implementation of the worker thread pool size manager
Art Cancro [Sun, 20 Mar 2011 18:00:45 +0000 (14:00 -0400)]
Initial implementation of the worker thread pool size manager

12 years agoClose sockets properly at logout
Art Cancro [Sun, 20 Mar 2011 06:16:13 +0000 (02:16 -0400)]
Close sockets properly at logout

12 years agoSwitched back to the old style thread architecture in preparation for eventual migrat...
Art Cancro [Sun, 20 Mar 2011 06:00:41 +0000 (02:00 -0400)]
Switched back to the old style thread architecture in preparation for eventual migration to libev

12 years agoRemoved the DEBUG_MEMORY_LEAKS framework because we do this with Valgrind now.
Art Cancro [Fri, 18 Mar 2011 18:13:16 +0000 (14:13 -0400)]
Removed the DEBUG_MEMORY_LEAKS framework because we do this with Valgrind now.

12 years agoMoved all of the background tasks back to the old EVT_TIMER style
Art Cancro [Fri, 18 Mar 2011 16:47:10 +0000 (12:47 -0400)]
Moved all of the background tasks back to the old EVT_TIMER style
in order to prepare for the forthcoming simplification of the server thread architecture

12 years agoTemporarily disable CtdlThreadGC() to get Uncensored stabilized
Art Cancro [Fri, 18 Mar 2011 15:34:16 +0000 (11:34 -0400)]
Temporarily disable CtdlThreadGC() to get Uncensored stabilized

12 years agoTemporarily disable terminate_stuck_sessions() because it is running at unexpected...
Art Cancro [Thu, 17 Mar 2011 16:48:54 +0000 (12:48 -0400)]
Temporarily disable terminate_stuck_sessions() because it is running at unexpected times

12 years agoMore debugging
Art Cancro [Thu, 17 Mar 2011 16:09:24 +0000 (12:09 -0400)]
More debugging

12 years agomore logging and testing
Art Cancro [Thu, 17 Mar 2011 03:07:23 +0000 (23:07 -0400)]
more logging and testing

12 years agoAdd some more debugging to the session destroyer; -> backtrace.
Wilfried Goesgens [Tue, 15 Mar 2011 22:36:28 +0000 (23:36 +0100)]
Add some more debugging to the session destroyer; -> backtrace.

12 years agoAdded protocol names to all 'client disconnected' syslogs
Art Cancro [Mon, 14 Mar 2011 16:59:46 +0000 (12:59 -0400)]
Added protocol names to all 'client disconnected' syslogs

12 years ago* in knrooms we flush the cached floorlist, since the user wants the _current_ pictur...
Wilfried Goesgens [Sun, 13 Mar 2011 19:23:53 +0000 (20:23 +0100)]
* in knrooms we flush the cached floorlist, since the user wants the _current_ picture of read state.

12 years agoWe don't have this timer here.
Wilfried Goesgens [Sun, 4 Sep 2011 15:07:15 +0000 (15:07 +0000)]
We don't have this timer here.

12 years agoCC->kill_me now contains an enum indicating the REASON session was killed
Art Cancro [Sun, 13 Mar 2011 17:32:47 +0000 (13:32 -0400)]
CC->kill_me now contains an enum indicating the REASON session was killed

12 years agoRemoved newlines from syslog in pop3 and imap modules
Art Cancro [Sun, 13 Mar 2011 07:50:01 +0000 (03:50 -0400)]
Removed newlines from syslog in pop3 and imap modules

12 years agoCtdlUserLogout() syslog who owned the session we killed
Art Cancro [Sun, 13 Mar 2011 07:30:59 +0000 (03:30 -0400)]
CtdlUserLogout() syslog who owned the session we killed

12 years agoRun RSS pulls no more than once every 15 minutes.
Art Cancro [Sun, 13 Mar 2011 07:14:11 +0000 (03:14 -0400)]
Run RSS pulls no more than once every 15 minutes.
The last_run check had been pulled and we were running every minute.

12 years agoIndicate which function we were in when the connection to citserver broke
Art Cancro [Sun, 13 Mar 2011 07:09:06 +0000 (03:09 -0400)]
Indicate which function we were in when the connection to citserver broke

12 years agoWelcome mail is now from nobody@example.com
Art Cancro [Sat, 12 Mar 2011 05:35:04 +0000 (00:35 -0500)]
Welcome mail is now from nobody@example.com

12 years agoRSS-Client: fix storing of sender in case of we just have a plain email address.
Wilfried Goesgens [Thu, 10 Mar 2011 22:01:27 +0000 (23:01 +0100)]
RSS-Client: fix storing of sender in case of we just have a plain email address.

12 years agofix possible buffer underrun by 1
Wilfried Goesgens [Thu, 10 Mar 2011 20:48:15 +0000 (21:48 +0100)]
fix possible buffer underrun by 1

12 years agoIO fixups
Wilfried Goesgens [Thu, 10 Mar 2011 19:36:35 +0000 (20:36 +0100)]
IO fixups

 - prepend accept() by select()
 - open a pipe to ourselves, so we can wake us up on all selects() waiting for input -> clean shutdown.

12 years agoFix Crash; don't access pointers before checking them for NULL
Wilfried Goesgens [Thu, 10 Mar 2011 07:43:56 +0000 (08:43 +0100)]
Fix Crash; don't access pointers before checking them for NULL

12 years agoAdded the ability to specify a file defining *simple* redirect patterns.
Art Cancro [Wed, 9 Mar 2011 19:07:35 +0000 (14:07 -0500)]
Added the ability to specify a file defining *simple* redirect patterns.
This is needed for sites transitioning away from conventional web servers.

12 years agoAllow LFLR to work in guest mode
Art Cancro [Fri, 4 Mar 2011 18:08:44 +0000 (13:08 -0500)]
Allow LFLR to work in guest mode

12 years agoValidate new users screen now uses the main room banner
Art Cancro [Tue, 1 Mar 2011 04:57:31 +0000 (23:57 -0500)]
Validate new users screen now uses the main room banner

12 years agoFlush the cached room list when logging in or out.
Art Cancro [Tue, 1 Mar 2011 04:46:31 +0000 (23:46 -0500)]
Flush the cached room list when logging in or out.

12 years agoKnown rooms page now uses the auto-generated room banner.
Art Cancro [Tue, 1 Mar 2011 04:36:51 +0000 (23:36 -0500)]
Known rooms page now uses the auto-generated room banner.
Also removed the folder view.  This will be redone as a better in-iconbar version later.

12 years agominor update to readme.txt
Art Cancro [Sat, 26 Feb 2011 21:41:16 +0000 (16:41 -0500)]
minor update to readme.txt

12 years agoadd finish tranlation imported from launchpad.
Wilfried Goesgens [Sat, 26 Feb 2011 10:29:32 +0000 (11:29 +0100)]
add finish tranlation imported from launchpad.

12 years agoResync with Launchpad translations.
Wilfried Goesgens [Sat, 26 Feb 2011 10:27:15 +0000 (11:27 +0100)]
Resync with Launchpad translations.

12 years agoTwo more url shortener services...
Wilfried Goesgens [Sat, 26 Feb 2011 10:26:53 +0000 (11:26 +0100)]
Two more url shortener services...

12 years agoFollow syslog change here, else we won't compile.
Wilfried Goesgens [Sat, 26 Feb 2011 10:26:27 +0000 (11:26 +0100)]
Follow syslog change here, else we won't compile.

12 years agoSwitching languages now works again
Art Cancro [Fri, 25 Feb 2011 03:27:13 +0000 (22:27 -0500)]
Switching languages now works again

12 years agoPut the language selector box back in (but it doesn't work yet)
Art Cancro [Thu, 24 Feb 2011 04:14:42 +0000 (23:14 -0500)]
Put the language selector box back in (but it doesn't work yet)

12 years agoadded a FIXME
Art Cancro [Wed, 23 Feb 2011 18:08:05 +0000 (13:08 -0500)]
added a FIXME

12 years agoFixed incorrect byte count when writing XML entity references
Art Cancro [Wed, 23 Feb 2011 16:41:12 +0000 (11:41 -0500)]
Fixed incorrect byte count when writing XML entity references

12 years agoSanitize v_seen and v_answered during export
Art Cancro [Tue, 22 Feb 2011 22:43:11 +0000 (17:43 -0500)]
Sanitize v_seen and v_answered during export

12 years agoEscape single and double quotes in export format
Art Cancro [Tue, 22 Feb 2011 21:06:36 +0000 (16:06 -0500)]
Escape single and double quotes in export format

12 years agoExport messages in numerical order
Art Cancro [Tue, 22 Feb 2011 16:38:25 +0000 (11:38 -0500)]
Export messages in numerical order

12 years agoClicking on the room name in the banner goes to the top level
Art Cancro [Wed, 16 Feb 2011 17:57:56 +0000 (12:57 -0500)]
Clicking on the room name in the banner goes to the top level

12 years agoFixed a backwards conditional in the openid_manual_create template.
Art Cancro [Tue, 15 Feb 2011 03:53:06 +0000 (22:53 -0500)]
Fixed a backwards conditional in the openid_manual_create template.

12 years agocosmetic stuff
Art Cancro [Mon, 14 Feb 2011 18:34:35 +0000 (13:34 -0500)]
cosmetic stuff

12 years agoOpenID manual create is now functionally complete.
Art Cancro [Mon, 14 Feb 2011 18:17:36 +0000 (13:17 -0500)]
OpenID manual create is now functionally complete.
Just a few minor cosmetic things to take care of now.

12 years agoFinished everything except the openid_manual_create code path
Art Cancro [Mon, 14 Feb 2011 17:18:50 +0000 (12:18 -0500)]
Finished everything except the openid_manual_create code path

12 years agoBegin working on OpenID manual screen name selection mode
Art Cancro [Mon, 14 Feb 2011 17:03:16 +0000 (12:03 -0500)]
Begin working on OpenID manual screen name selection mode

12 years agoOnly offer XMPP over TLS if we have OpenSSL in the build.
Art Cancro [Mon, 14 Feb 2011 03:46:09 +0000 (22:46 -0500)]
Only offer XMPP over TLS if we have OpenSSL in the build.

12 years agoEnable XMPP over TLS.
Art Cancro [Mon, 14 Feb 2011 03:41:08 +0000 (22:41 -0500)]
Enable XMPP over TLS.
I don't know why this works now when it didn't work before.
Perhaps we fixed something in the I/O layer recently.

12 years agoBUGFIX: json-escape roomname during outputting message list
Wilfried Goesgens [Sun, 6 Feb 2011 19:24:12 +0000 (20:24 +0100)]
BUGFIX: json-escape roomname during outputting message list

12 years agoRestored the ability to associate an OpenID with an existing account.
Art Cancro [Tue, 1 Feb 2011 04:45:50 +0000 (23:45 -0500)]
Restored the ability to associate an OpenID with an existing account.

12 years agoRSS-Client: fix memory leaks
Wilfried Goesgens [Sun, 30 Jan 2011 21:20:33 +0000 (22:20 +0100)]
RSS-Client: fix memory leaks

12 years agoWhen registering a new user during an inline login, preserve the room we started...
Art Cancro [Sun, 30 Jan 2011 19:17:23 +0000 (14:17 -0500)]
When registering a new user during an inline login, preserve the room we started from.
This commit was brought to you from the front seat of my car.  I have some time to kill and I've got
my netbook tethered to my awesome Android phone hooked up to the T-Mobile network.  I'm not some
snobby metropolitan self-importanterati with an iPhone.  Android is where it's at, and where it
will continue to be.

12 years agoBy jimcuclamath: set maxium allowed password length to the length of the buffer we...
Wilfried Goesgens [Sun, 30 Jan 2011 10:00:47 +0000 (11:00 +0100)]
By jimcuclamath: set maxium allowed password length to the length of the buffer we read into.

12 years agoSend the correct data to become_logged_in() during self service user creation.
Art Cancro [Sat, 29 Jan 2011 20:47:31 +0000 (15:47 -0500)]
Send the correct data to become_logged_in() during self service user creation.
We needed to send it the output of NEWU, not the output of SETP.

12 years agoBegin working new user registration into the login dialog
Art Cancro [Fri, 28 Jan 2011 21:02:25 +0000 (16:02 -0500)]
Begin working new user registration into the login dialog

12 years agominor comments cleanup
Art Cancro [Fri, 28 Jan 2011 18:58:34 +0000 (13:58 -0500)]
minor comments cleanup

12 years agoChanged the 'if you are a new user' message and also updated it in the .po files
Art Cancro [Fri, 28 Jan 2011 18:45:55 +0000 (13:45 -0500)]
Changed the 'if you are a new user' message and also updated it in the .po files

12 years agoInitial version of 'register new user' dialog
Art Cancro [Fri, 28 Jan 2011 17:54:27 +0000 (12:54 -0500)]
Initial version of 'register new user' dialog

12 years agoInitial version of 'register new user' dialog
Art Cancro [Fri, 28 Jan 2011 17:50:55 +0000 (12:50 -0500)]
Initial version of 'register new user' dialog

12 years agoReplace the temporary log message with a permanent one
Art Cancro [Fri, 28 Jan 2011 17:13:58 +0000 (12:13 -0500)]
Replace the temporary log message with a permanent one

12 years agoOk this is it, the best of both worlds.
Art Cancro [Fri, 28 Jan 2011 17:07:34 +0000 (12:07 -0500)]
Ok this is it, the best of both worlds.
1. Go back to the 'cache the most recent msglist' and 'binary-search that list' method.
2. Make ONE attempt to reload the msglist if a search fails.

12 years agoRevert "Updating cmd_euid() to use the CtdlForEachMessage() API fixes the security...
Art Cancro [Fri, 28 Jan 2011 16:53:47 +0000 (11:53 -0500)]
Revert "Updating cmd_euid() to use the CtdlForEachMessage() API fixes the security check in blog view and saves some code"

This reverts commit 4ec6a9dae3de0cf26e3c52d1ba65a1f57038b7a7.

12 years agoRevert "Replaced cached_msglist array with a btree persistent through the session."
Art Cancro [Fri, 28 Jan 2011 16:53:41 +0000 (11:53 -0500)]
Revert "Replaced cached_msglist array with a btree persistent through the session."

This reverts commit e432540ab02282396bf87eafde6a1698819912ff.

12 years agoRevert "arrgh"
Art Cancro [Fri, 28 Jan 2011 16:53:35 +0000 (11:53 -0500)]
Revert "arrgh"

This reverts commit 590b3ab0deab5fbb58b56d7f3fcad75bafc9e9e1.

12 years agoRevert "xxx"
Art Cancro [Fri, 28 Jan 2011 16:53:26 +0000 (11:53 -0500)]
Revert "xxx"

This reverts commit 88def48c67c3a034b33d9550bf70afa5c4705039.

12 years agoxxx
Art Cancro [Fri, 28 Jan 2011 16:51:36 +0000 (11:51 -0500)]
xxx

12 years agoarrgh
Art Cancro [Fri, 28 Jan 2011 16:49:53 +0000 (11:49 -0500)]
arrgh

12 years agoReplaced cached_msglist array with a btree persistent through the session.
Art Cancro [Thu, 27 Jan 2011 23:11:22 +0000 (18:11 -0500)]
Replaced cached_msglist array with a btree persistent through the session.

12 years agoUpdating cmd_euid() to use the CtdlForEachMessage() API fixes the security check...
Art Cancro [Thu, 27 Jan 2011 03:59:23 +0000 (22:59 -0500)]
Updating cmd_euid() to use the CtdlForEachMessage() API fixes the security check in blog view and saves some code

12 years agoUse a binary search to locate msgnum in cached_msglist
Art Cancro [Thu, 27 Jan 2011 03:36:48 +0000 (22:36 -0500)]
Use a binary search to locate msgnum in cached_msglist

12 years agoDisplay PASS/FAIL syslog msgs for the new security check.
Art Cancro [Thu, 27 Jan 2011 02:38:21 +0000 (21:38 -0500)]
Display PASS/FAIL syslog msgs for the new security check.
This determines whether a requested message actually exists in the current room,
preventing unauthorized msgnum sweeps.  We do not actually fail the message yet; I
will add that when the security check yields no false positives.

12 years agoDisplay PASS/FAIL syslog msgs for the new security check.
Art Cancro [Thu, 27 Jan 2011 02:36:19 +0000 (21:36 -0500)]
Display PASS/FAIL syslog msgs for the new security check.
This determines whether a requested message actually exists in the current room,
preventing unauthorized msgnum sweeps.  We do not actually fail the message yet; I
will add that when the security check yields no false positives.

12 years agoLink to http://www.citadel.org/doku.php/faq:generalquestions:webcit_unable_to_connect...
Art Cancro [Tue, 25 Jan 2011 21:46:37 +0000 (16:46 -0500)]
Link to citadel.org/doku.php/faq:generalquestions:webcit_unable_to_connect instead

12 years agoReinstate the 'read more...' link when issuing a 503
Art Cancro [Tue, 25 Jan 2011 21:30:52 +0000 (16:30 -0500)]
Reinstate the 'read more...' link when issuing a 503

12 years agoLocalized the string 'New user? Register now' using Google Translate
Art Cancro [Tue, 25 Jan 2011 19:27:50 +0000 (14:27 -0500)]
Localized the string 'New user?  Register now' using Google Translate

12 years agomore login box cleanup
Art Cancro [Tue, 25 Jan 2011 04:46:34 +0000 (23:46 -0500)]
more login box cleanup

12 years agoCleaned up the login modal a bit
Art Cancro [Tue, 25 Jan 2011 04:29:27 +0000 (23:29 -0500)]
Cleaned up the login modal a bit

12 years agoCOND:AIDE now observes logged in semantics
Art Cancro [Tue, 25 Jan 2011 03:30:57 +0000 (22:30 -0500)]
COND:AIDE now observes logged in semantics

12 years agoDisabled the old login screen.
Art Cancro [Tue, 25 Jan 2011 03:18:59 +0000 (22:18 -0500)]
Disabled the old login screen.
Some of this code will be re-used for registration and language selection.

12 years agoOnly offer OpenID login if the citadel server supports it
Art Cancro [Tue, 25 Jan 2011 02:53:30 +0000 (21:53 -0500)]
Only offer OpenID login if the citadel server supports it

12 years agoauthpopup now returns the parent to the pushed_destination
Art Cancro [Mon, 24 Jan 2011 21:02:39 +0000 (16:02 -0500)]
authpopup now returns the parent to the pushed_destination

12 years agologin popout is working, along with non edge case openID login
Art Cancro [Mon, 24 Jan 2011 20:47:23 +0000 (15:47 -0500)]
login popout is working, along with non edge case openID login

12 years agoBegan implementation of authpopout
Art Cancro [Mon, 24 Jan 2011 18:38:29 +0000 (13:38 -0500)]
Began implementation of authpopout

12 years agoThe 'Delete' button in mailbox view went missing at some point; replaced it.
Art Cancro [Thu, 20 Jan 2011 04:10:54 +0000 (23:10 -0500)]
The 'Delete' button in mailbox view went missing at some point; replaced it.

12 years ago'Read all messages' button does not belong in the mailbox view. Remove it.
Art Cancro [Thu, 20 Jan 2011 04:04:56 +0000 (23:04 -0500)]
'Read all messages' button does not belong in the mailbox view.  Remove it.

12 years agoDisallow certain pages in robots.txt which would mislead crawlers.
Art Cancro [Thu, 20 Jan 2011 03:37:30 +0000 (22:37 -0500)]
Disallow certain pages in robots.txt which would mislead crawlers.
/printmsg
/msgheaders
/groupdav
/do_template
/static

12 years agoPrototype 1.7 seems to need ajax parameters wrapped with encodeURI()
Art Cancro [Wed, 19 Jan 2011 20:03:49 +0000 (15:03 -0500)]
Prototype 1.7 seems to need ajax parameters wrapped with encodeURI()
This fixes the broken mailbox view

12 years agoajax_servcmd() logging now displays the g_cmd being attempted.
Art Cancro [Wed, 19 Jan 2011 16:32:02 +0000 (11:32 -0500)]
ajax_servcmd() logging now displays the g_cmd being attempted.
This is in an attempt to debug the b0rken message delete in the mailbox view.
Also fixed a format string compiler warning.